Re: [libvirt PATCHv1 8/8] docs: virtiofs: add section about ID remapping

2023-09-13 Thread Daniel P . Berrangé
On Wed, Sep 13, 2023 at 04:14:55PM +0100, Daniel P. Berrangé wrote: > On Wed, Sep 13, 2023 at 05:07:27PM +0200, Ján Tomko wrote: > > On a Tuesday in 2023, Daniel P. Berrangé wrote: > > > On Tue, Sep 12, 2023 at 04:05:04PM +0200, Ján Tomko wrote: > > > > On a Monday in 2023, Daniel P. Berrangé

Re: [libvirt PATCHv1 8/8] docs: virtiofs: add section about ID remapping

2023-09-13 Thread Daniel P . Berrangé
On Wed, Sep 13, 2023 at 05:07:27PM +0200, Ján Tomko wrote: > On a Tuesday in 2023, Daniel P. Berrangé wrote: > > On Tue, Sep 12, 2023 at 04:05:04PM +0200, Ján Tomko wrote: > > > On a Monday in 2023, Daniel P. Berrangé wrote: > > > > I would expect libvirt to "do the right thing" and automatically

Re: [libvirt PATCHv1 8/8] docs: virtiofs: add section about ID remapping

2023-09-13 Thread Ján Tomko
On a Tuesday in 2023, Daniel P. Berrangé wrote: On Tue, Sep 12, 2023 at 04:05:04PM +0200, Ján Tomko wrote: On a Monday in 2023, Daniel P. Berrangé wrote: > I would expect libvirt to "do the right thing" and automatically load > the /etc/subuid data for the current user and NOT require any extra

Re: [libvirt PATCH] ci: jobs.sh: Add back '--no-suite syntax-check --print-errorlogs'

2023-09-13 Thread Daniel P . Berrangé
On Wed, Sep 13, 2023 at 01:55:54PM +0200, Erik Skultety wrote: > Commit f688a53a converted .gitlab-ci.yml to the usage of ci/jobs.sh > functions, but in doing that our test options > '--no-suite syntax-check --print-errorlogs' > got lost in the process and since commit 8e660c52 didn't

Re: [libvirt PATCH v2 0/5] Add support for vDPA block devices

2023-09-13 Thread Erik Skultety
On Wed, Sep 13, 2023 at 12:57:09PM +0200, Erik Skultety wrote: > On Wed, Sep 13, 2023 at 08:56:35AM +0100, Daniel P. Berrangé wrote: > > On Tue, Sep 12, 2023 at 04:11:01PM -0500, Jonathon Jongsma wrote: > > > On 9/12/23 7:00 AM, Peter Krempa wrote: > > > > On Mon, Sep 11, 2023 at 16:53:42 -0500,

[libvirt PATCH] ci: jobs.sh: Add back '--no-suite syntax-check --print-errorlogs'

2023-09-13 Thread Erik Skultety
Commit f688a53a converted .gitlab-ci.yml to the usage of ci/jobs.sh functions, but in doing that our test options '--no-suite syntax-check --print-errorlogs' got lost in the process and since commit 8e660c52 didn't introduce them in the first place, it caused a behavioral regression. This

Re: [libvirt PATCH v2 0/5] Add support for vDPA block devices

2023-09-13 Thread Erik Skultety
On Wed, Sep 13, 2023 at 08:56:35AM +0100, Daniel P. Berrangé wrote: > On Tue, Sep 12, 2023 at 04:11:01PM -0500, Jonathon Jongsma wrote: > > On 9/12/23 7:00 AM, Peter Krempa wrote: > > > On Mon, Sep 11, 2023 at 16:53:42 -0500, Jonathon Jongsma wrote: > > > > see

Re: [libvirt PATCH v2 18/35] .gitlab-ci.yml: Convert the native build job to the build.sh usage

2023-09-13 Thread Daniel P . Berrangé
On Mon, Sep 11, 2023 at 03:43:19PM +0200, Erik Skultety wrote: > Individual shell command executions are replaced by respective > functions in the ci/build.sh base script. This will make sure we use > the same recipes in GitLab jobs as well as in local executions. > > Signed-off-by: Erik Skultety

Re: [libvirt PATCH v2 0/5] Add support for vDPA block devices

2023-09-13 Thread Daniel P . Berrangé
On Tue, Sep 12, 2023 at 04:11:01PM -0500, Jonathon Jongsma wrote: > On 9/12/23 7:00 AM, Peter Krempa wrote: > > On Mon, Sep 11, 2023 at 16:53:42 -0500, Jonathon Jongsma wrote: > > > see https://bugzilla.redhat.com/show_bug.cgi?id=1900770. > > > > > > Changes in v2: > > > - Don't use

[PATCH (pushed)] virStorageSourceClear: Clear 'vdpadev' field

2023-09-13 Thread Peter Krempa
Release memory for the recently added field. Fixes: 1df106cc20a4cc6417cfbaf01860f465ec3dd915 Signed-off-by: Peter Krempa --- src/conf/storage_source_conf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/storage_source_conf.c b/src/conf/storage_source_conf.c index

Re: [libvirt PATCH v2 0/5] Add support for vDPA block devices

2023-09-13 Thread Peter Krempa
On Tue, Sep 12, 2023 at 16:11:01 -0500, Jonathon Jongsma wrote: > On 9/12/23 7:00 AM, Peter Krempa wrote: > > On Mon, Sep 11, 2023 at 16:53:42 -0500, Jonathon Jongsma wrote: > > > see https://bugzilla.redhat.com/show_bug.cgi?id=1900770. > > > > > > Changes in v2: > > > - Don't use