Re: [libvirt PATCH] qemu: DomainGetGuestVcpusParams: reduce scope of tmp

On 9/29/23 8:48 AM, Ján Tomko wrote: Wrap the macro body in a new block and move the declaration of 'tmp' into it, to avoid the need to mix g_autofree with manual freeing. Signed-off-by: Ján Tomko --- src/qemu/qemu_driver.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-)

Re: [PATCH] qemu: Add VIR_FREE in ADD_BITMAP

On a Friday in 2023, Michal Prívozník wrote: On 9/28/23 13:55, Anastasia Belova wrote: virBitmapFormat returns the string that should be freed. All strings in three ADD_BITMAP calls in qemuDomainGetGuestVcpusParams are contained in tmp. So memory leak is possible here without VIR_FREE. Fixes:

[libvirt PATCH] qemu: DomainGetGuestVcpusParams: reduce scope of tmp

Wrap the macro body in a new block and move the declaration of 'tmp' into it, to avoid the need to mix g_autofree with manual freeing. Signed-off-by: Ján Tomko --- src/qemu/qemu_driver.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_driver.c

Re: [PATCH] NEWS: Document my contributions for upcoming release

On a Friday in 2023, Michal Privoznik wrote: Signed-off-by: Michal Privoznik --- NEWS.rst | 12 1 file changed, 12 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index c17a1d002d..6f46e86ba8 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -43,8 +43,20 @@ v9.8.0 (unreleased) stability

Re: [PATCH] NEWS: Fix placement of network metadata entry

On a Friday in 2023, Michal Privoznik wrote: The network metadata support is a new feature in the upcoming release, not a removed one. Place it accordingly. Signed-off-by: Michal Privoznik --- NEWS.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Ján Tomko Jano

libvirt-9.8.0 release candidate 2

I have just tagged v9.8.0-rc2 in the repository and pushed signed tarballs and source RPMs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to

[PATCH] NEWS: Document my contributions for upcoming release

Signed-off-by: Michal Privoznik --- NEWS.rst | 12 1 file changed, 12 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index c17a1d002d..6f46e86ba8 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -43,8 +43,20 @@ v9.8.0 (unreleased) stability of qemu. Therefore, when available, libvirt

[PATCH] NEWS: Fix placement of network metadata entry

The network metadata support is a new feature in the upcoming release, not a removed one. Place it accordingly. Signed-off-by: Michal Privoznik --- NEWS.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/NEWS.rst b/NEWS.rst index 768e6fc326..c17a1d002d 100644 ---

Re: [PATCH] qemu: Add VIR_FREE in ADD_BITMAP

On 9/28/23 13:55, Anastasia Belova wrote: > virBitmapFormat returns the string that should be freed. > > All strings in three ADD_BITMAP calls in qemuDomainGetGuestVcpusParams > are contained in tmp. So memory leak is possible here without VIR_FREE. > > Fixes: 3e7db8d3e8 ("Remove backslash