On a Thursday in 2023, Peter Krempa wrote:
The 'virt-aa-helper' process gets a XML of the VM it needs to create a
profile for. For a disk type='volume' this XML contained only the
pool and volume name.
The 'virt-aa-helper' needs a local path though for anything it needs to
label. This means
On a Thursday in 2023, Peter Krempa wrote:
Re-translating the disk source pools when reconnecting to a VM makes no
sense as the volume might have changed or pool became inactive. The VM
still uses the original volume though. Failing to re-translate the pool
also causes the VM to be killed.
Fix
On a Thursday in 2023, Peter Krempa wrote:
Enable the flags in the status xml2xmtest and add an exaple to the test
data.
Signed-off-by: Peter Krempa
---
tests/qemustatusxml2xmldata/modern-in.xml | 4 ++--
tests/qemustatusxml2xmltest.c | 6 --
2 files changed, 6 insertions(+), 4
On a Thursday in 2023, Peter Krempa wrote:
Re-translating a disk type='volume' definition from a storage pool is
not a good idea in cases when the volume might have changed or we might
not have access to the storage driver.
Specific cases are if a storage pool is not activated on daemon
On a Thursday in 2023, Peter Krempa wrote:
If a disk definition was already translated re-doing it makes no sense.
Skip the translation if the 'actualtype' is already populated.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On a Thursday in 2023, Peter Krempa wrote:
Register autoptr cleanup function for virStorageSourcePoolDef and
refactor the parser to simplify the logic.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 35 +++---
src/conf/storage_source_conf.h | 1 +
2
On a Thursday in 2023, Peter Krempa wrote:
Use proper enum type and refactor the formatter accordingly.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 12
src/conf/storage_source_conf.h | 2 +-
2 files changed, 5 insertions(+), 9 deletions(-)
Reviewed-by: Ján
Juan Quintela writes:
> Set the 'block' migration capability to 'true' instead.
>
> Signed-off-by: Juan Quintela
> Acked-by: Stefan Hajnoczi
> Reviewed-by: Thomas Huth
>
> ---
>
> Improve documentation and style (markus)
> ---
> docs/about/deprecated.rst | 7 +++
> qapi/migration.json
Juan Quintela writes:
> Set the 'block_incremental' migration parameter to 'true' instead.
>
> Reviewed-by: Thomas Huth
> Acked-by: Stefan Hajnoczi
> Signed-off-by: Juan Quintela
>
> ---
>
> Improve documentation and style (thanks Markus)
> ---
> docs/about/deprecated.rst | 7 +++
>
Juan Quintela writes:
> Signed-off-by: Juan Quintela
> ---
> qapi/migration.json | 7 +++
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/qapi/migration.json b/qapi/migration.json
> index d7dfaa5db9..6865fea3c5 100644
> --- a/qapi/migration.json
> +++
Hello Libvirt Community,
For the last 18(!) years, libvirt community mailing lists have been kindly
hosted by Red Hat Corporate IT on the redhat.com Mailman installation.
In retrospect this wasn't the ideal home for community mailing lists but
that decision is ancient history.
Unfortunately as a
This has been replaced by a "pmu-mask" property that provides much more
flexibility.
Signed-off-by: Rob Bradford
Acked-by: LIU Zhiwei
---
docs/about/deprecated.rst | 10 ++
1 file changed, 10 insertions(+)
diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
index
On 2023/10/11 22:45, Rob Bradford wrote:
This has been replaced by a "pmu-mask" property that provides much more
flexibility.
Signed-off-by: Rob Bradford
---
docs/about/deprecated.rst | 10 ++
1 file changed, 10 insertions(+)
diff --git a/docs/about/deprecated.rst
This has been replaced by a "pmu-mask" property that provides much more
flexibility.
Signed-off-by: Rob Bradford
---
docs/about/deprecated.rst | 10 ++
1 file changed, 10 insertions(+)
diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
index 8b136320e2..37f3414ef8
Set the 'block_incremental' migration parameter to 'true' instead.
Reviewed-by: Thomas Huth
Acked-by: Stefan Hajnoczi
Signed-off-by: Juan Quintela
---
Improve documentation and style (thanks Markus)
---
docs/about/deprecated.rst | 7 +++
qapi/migration.json | 8 +++-
Signed-off-by: Juan Quintela
Acked-by: Stefan Hajnoczi
Acked-by: Peter Xu
---
docs/about/deprecated.rst | 8
qapi/migration.json | 79 +--
migration/options.c | 13 +++
3 files changed, 72 insertions(+), 28 deletions(-)
diff --git
It is obsolete. It is better to use driver-mirror with NBD instead.
CC: Kevin Wolf
CC: Eric Blake
CC: Stefan Hajnoczi
CC: Hanna Czenczek
Signed-off-by: Juan Quintela
Acked-by: Stefan Hajnoczi
---
docs/about/deprecated.rst | 10 ++
qapi/migration.json | 29
[DON'T MERGE]
Block migration is obsolete, users should use blockdev-mirror
instead.
Make it one error to set them.
Signed-off-by: Juan Quintela
---
migration/migration-hmp-cmds.c | 15 ++-
migration/migration.c | 35 +++---
2 files changed, 21
[DON'T MERGE]
We were abusing capabilities and parameters to implement -i/-b.
Previous patch convert that options into one error. Remove all the
helpers needed to implement them.
Signed-off-by: Juan Quintela
---
migration/migration.h | 4
migration/options.h | 6 --
[DON'T MERGE]
Signed-off-by: Juan Quintela
---
meson.build|2 -
qapi/migration.json| 31 +-
include/migration/misc.h |8 -
migration/block.h | 52 --
migration/options.h|1 -
migration/block.c | 1030
[DON'T MERGE]
Signed-off-by: Juan Quintela
---
docs/about/deprecated.rst | 7 -
qapi/migration.json| 55 +++---
migration/options.h| 1 -
migration/block.c | 2 +-
migration/migration-hmp-cmds.c | 18 +--
Set the 'block' migration capability to 'true' instead.
Signed-off-by: Juan Quintela
Acked-by: Stefan Hajnoczi
Reviewed-by: Thomas Huth
---
Improve documentation and style (markus)
---
docs/about/deprecated.rst | 7 +++
qapi/migration.json | 6 --
migration/migration.c | 5
The new line was only printed when command options were used. When we
used migration parameters and capabilities, it wasn't.
Signed-off-by: Juan Quintela
---
migration/migration-hmp-cmds.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/migration/migration-hmp-cmds.c
Signed-off-by: Juan Quintela
---
qapi/migration.json | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/qapi/migration.json b/qapi/migration.json
index d7dfaa5db9..6865fea3c5 100644
--- a/qapi/migration.json
+++ b/qapi/migration.json
@@ -73,7 +73,7 @@
{ 'struct':
On this v4:
- addressed all markus comments.
- rebased on latest.
- improve formatting of migration.json
- print block migration status when needed.
- patches 7-10 are not mean to merge, they just show why we want to
deprecate block migration and remove its support.
- Patch 7 just drop support
25 matches
Mail list logo
