This patch fixes the secret type checking done in the
virDomainDiskDefParseXML function. Previously, it would not allow any
volumes that utilized a secret. This patch is a simple bypass of the
checking code for volumes.
Signed-off-by: Adam Walters
---
src/conf/domain_conf.c | 9 +++--
1
check for expected vs actual
secret usage, but at that particular point in the code, Ján was correct that the
pool definition has not yet been parsed. Thus, I had to keep my bypass.
Adam Walters (2):
qemu: conf Implement domain RBD storage pool support
domain: conf: Fix secret type checki
ain's disk definition at runtime to
allow access to a RBD storage pool.
Signed-off-by: Adam Walters
---
src/qemu/qemu_conf.c | 62 +++-
1 file changed, 61 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
ind
On Thu, Jan 30, 2014 at 9:46 AM, Ján Tomko wrote:
> On 01/23/2014 08:45 PM, Adam Walters wrote:
> > This patch fixes the secret type checking done in the
> > virDomainDiskDefParseXML function. Previously, it would not allow any
> > volumes that utilized a secret. This patch
On Thu, Jan 30, 2014 at 9:46 AM, Ján Tomko wrote:
> On 01/23/2014 08:45 PM, Adam Walters wrote:
> > This patch adds a helper function, qemuAddRBDPoolSourceHost, and
> > implements the usage of this function to allow RBD storage pools in QEMU
> > domain XML.
> >
>
On Tue, Jan 28, 2014 at 12:07 PM, Daniel P. Berrange wrote:
> On Thu, Jan 23, 2014 at 03:14:19PM -0500, Adam Walters wrote:
> > This patchset adds a driver named 'config' which provides access to
> > configuration data, such as secret and storage definitions, without
>
On Tue, Jan 28, 2014 at 8:05 AM, Daniel P. Berrange wrote:
> On Thu, Jan 23, 2014 at 03:06:16PM -0500, Adam Walters wrote:
> > This patchset implements a tiered driver loading system. I split the
> hypervisor
> > drivers out into their own tier, which is loaded after the oth
storage pool backings), and storage requires QEMU (for
access to secrets). This causes issues during libvirtd startup.
Signed-off-by: Adam Walters
---
src/storage/storage_driver.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/src/storage/storage_driver.c b/src
ng of the secrets driver to just above the storage
driver.
Signed-off-by: Adam Walters
---
daemon/libvirtd.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
index 1e76f5a..251c2f4 100644
--- a/daemon/libvirtd.c
+++ b/d
This patch completes the addition of the config driver by adding it to
the configure script, Makefile, and loading the driver in libvirtd.
Additionally, to prevent a make syntax-check error, I also added
src/config/config_driver.c to po/POTFILES.in.
Signed-off-by: Adam Walters
---
configure.ac
en
drivers, including the current case between the QEMU and storage
drivers.
Signed-off-by: Adam Walters
---
include/libvirt/virterror.h | 2 +
src/config/config_driver.c | 238
src/config/config_driver.h | 44
src/util/virerror.c | 2
startup of libvirtd without any loss of functionality.
Adam Walters (4):
config: Adding config driver
configure: Implement config driver
libvirtd: Reorder load of secrets driver
storage: Change hardcoded QEMU connection to use config driver
configure.ac | 11 +
, all other changes are a single line addition to the
driver source files to define this field.
Signed-off-by: Adam Walters
---
src/check-driverimpls.pl| 1 +
src/driver.h| 7 +++
src/interface/interface_backend_netcf.c | 1 +
src/libxl
most anywhere.
Adam Walters (2):
driver: Implement new state driver field
libvirt: Implement tiered driver loading
src/check-driverimpls.pl| 1 +
src/driver.h| 7 +
src/interface/interface_backend_netcf.c | 1 +
src/libvirt.c
he number of tiers can be changed to mitigate it without
requiring too much effort.
Signed-off-by: Adam Walters
---
src/libvirt.c | 45 +++--
1 file changed, 27 insertions(+), 18 deletions(-)
diff --git a/src/libvirt.c b/src/libvirt.c
index c15e29a..d8d1723 1
This patch fixes the secret type checking done in the
virDomainDiskDefParseXML function. Previously, it would not allow any
volumes that utilized a secret. This patch is a simple bypass of the
checking code for volumes.
Signed-off-by: Adam Walters
---
src/conf/domain_conf.c | 6 --
1 file
any problems with my patches, please let me
know, and I will fix them up as soon as time permits.
Adam Walters (2):
qemu: conf Implement domain RBD storage pool support
domain: conf: Fix secret type checking for network volumes
src/conf/domain_conf.c | 6 +++--
src/qemu/qemu_conf.c | 62
ain's disk definition at runtime to
allow access to a RBD storage pool.
Signed-off-by: Adam Walters
---
src/qemu/qemu_conf.c | 62 +++-
1 file changed, 61 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
ind
On Wed, Jan 22, 2014 at 8:36 AM, Matthias Bolte <
matthias.bo...@googlemail.com> wrote:
> 2014/1/22 Adam Walters :
> > On Mon, Jan 20, 2014 at 11:27 AM, Daniel P. Berrange <
> berra...@redhat.com>
> > wrote:
> >>
> >> On Fri, Dec 20, 2013 at 1
On Mon, Jan 20, 2014 at 11:27 AM, Daniel P. Berrange wrote:
> On Fri, Dec 20, 2013 at 11:03:53PM -0500, Adam Walters wrote:
> > This patchset adds a driver named 'config' that allows access to
> configuration
> > data, such as secret and storage definitions. This
working
to implement the suggestions tonight and/or tomorrow night.
On Mon, Jan 20, 2014 at 10:34 AM, Peter Krempa wrote:
> On 12/21/13 05:03, Adam Walters wrote:
> > This is the source code to the config driver. This driver is a
> hypervisor driver that does not support any domain ope
On Mon, Jan 20, 2014 at 11:27 AM, Daniel P. Berrange wrote:
> On Fri, Dec 20, 2013 at 11:03:53PM -0500, Adam Walters wrote:
> > This patchset adds a driver named 'config' that allows access to
> configuration
> > data, such as secret and storage definitions. This
rovide any number of extra tiers without much trouble.
Signed-off-by: Adam Walters
---
src/libvirt.c | 57 +
1 file changed, 49 insertions(+), 8 deletions(-)
diff --git a/src/libvirt.c b/src/libvirt.c
index 77f481e..9c00491 100644
appreciate any comments and suggestions about this patchset. It works
for me on 4 machines running three different distros of Linux (Archlinux,
Gentoo, and CentOS), so I would imagine it should work most anywhere.
Adam Walters (3):
driver: Implement new state driver field
storage: Fix
storage
requires QEMU. This causes issues during startup.
Signed-off-by: Adam Walters
---
src/storage/storage_driver.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c
index a614279..1077a66 100644
--- a/src
This completes the addition of the config driver to libvirt. The final piece
here is to add the config driver into the Makefile (via automake) so that the
driver is actually compiled and linked.
Signed-off-by: Adam Walters
---
src/Makefile.am | 25 +
1 file changed, 25
This conditionally enables compilation of the config driver based on if we are
building libvirtd or not. Since this is only needed for hypervisor modules
during libvirtd startup, we don't need to bother compiling the config driver
when only building the client.
Signed-off-by: Adam Wa
This implements a new field in the virStateDriver struct. In order to prevent
possible compilation issues, this patch also implements te new field in all of
the existing drivers. Other than in driver.h, the changes are all a single line
addition to the files.
Signed-off-by: Adam Walters
Adding config_driver.c to POTFILES.in to fix a syntax-check error.
Signed-off-by: Adam Walters
---
po/POTFILES.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/po/POTFILES.in b/po/POTFILES.in
index 49dfc9c..0e23610 100644
--- a/po/POTFILES.in
+++ b/po/POTFILES.in
@@ -27,6 +27,7 @@ src
nd-aid to allow access to this type
of data in the interim if a better resolution is a ways off.
Adam Walters (7):
config: Adding source for the config driver
config: Adding header for the config driver
virterror: Adding a new VIR_FROM_ define
libvirtd: Add config driver hooks
po: Add confi
-start routines
of other drivers. This is the first step toward breaking the circular
dependencies present in QEMU and the Storage driver, in addition to preventing
future cases.
Signed-off-by: Adam Walters
---
src/config/config_driver.c | 237 +
1
This is the header file for the config driver.
Signed-off-by: Adam Walters
---
src/config/config_driver.h | 44
1 file changed, 44 insertions(+)
create mode 100644 src/config/config_driver.h
diff --git a/src/config/config_driver.h b/src/config
have it loaded
earlier in the startup sequence.
Signed-off-by: Adam Walters
---
daemon/libvirtd.c | 21 +++--
1 file changed, 15 insertions(+), 6 deletions(-)
diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
index 49c42ad..251c2f4 100644
--- a/daemon/libvirtd.c
+++ b/d
This patch adds VIR_FROM_CONFIG to the virErrorDomain enum. Both of these files
must be patched in unison to prevent compilation failures.
Signed-off-by: Adam Walters
---
include/libvirt/virterror.h | 2 ++
src/util/virerror.c | 2 ++
2 files changed, 4 insertions(+)
diff --git a
This function is a helper function that grabs RBD hosts from a storage pool
definition, and applies them to the domain's disk defi
nitions at runtime. This is a pre-requisite for RBD storage pool support in the
domain XML.
Signed-off-by: Adam Walters
---
src/qemu/qemu_conf.c
let me
know, and I will fix them as soon as I can.
Adam Walters (3):
qemu: conf: Implement qemuAddRBDPoolSourceHost function
qemu: conf: Implement RBD storage pool support
domain: conf: Fix secret type checking
src/conf/domain_conf.c | 6 +++--
src/qemu/qemu_conf.c | 62
This patch fixes the secret type checking done in the virDomainDiskDefParseXML
function. Previously, it would not allow any volumes that utilized a secret.
This patch is a simple bypass of the checking code for volumes.
Signed-off-by: Adam Walters
---
src/conf/domain_conf.c | 6 --
1 file
and secret, if
applicable.
Signed-off-by: Adam Walters
---
src/qemu/qemu_conf.c | 23 ++-
1 file changed, 22 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index 2d42c3b..c28908a 100644
--- a/src/qemu/qemu_conf.c
+++ b/src/qemu
e:
> On Mon, Dec 09, 2013 at 12:15:52PM +0100, Peter Krempa wrote:
> > On 12/09/13 11:56, Daniel P. Berrange wrote:
> > > On Sat, Dec 07, 2013 at 02:03:00AM -0500, Adam Walters wrote:
> > >> This patch works around a race condition present during
> > >> libvirt
so doesn't hurt that I
only have qemu configured and ready to go for testing, too).
Adam Walters (1):
qemu: conf: Work around race condition on libvirt start
src/qemu/qemu_conf.c | 11 +++
1 file changed, 11 insertions(+)
--
1.8.4.2
--
libvir-list mailing list
libvir-list@r
This patch works around a race condition present during
libvirt startup. The race condition only applies when
using storage pool volumes for domain disks, and even
then, only when restarting libvirt with running domains.
The gist of the patch is simply to enter a (limited)
retry loop during qemuTr
ption rate of storage
pools in frontend software thus far. I'll try and think about and implement
possible solutions to this race condition over the weekend.
On Fri, Dec 6, 2013 at 4:40 PM, Adam Walters wrote:
> Unfortunately, after I got home, I discovered that this patch introduces a
&g
pool was active at that point, otherwise, it would remain paused until
someone resumed it.
On Fri, Dec 6, 2013 at 3:10 PM, Adam Walters wrote:
> While testing Peter's changes to my patches, I discovered that when
> restarting libvirt with domains running, they would no longer show
>
This patch is updated to not contain a switch statement
on the mode. The patch as a whole allows RBD storage pool
volumes to be used within domain XML.
---
src/qemu/qemu_conf.c | 23 ++-
1 file changed, 22 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_conf.c b/src/qe
This helper function pulls the host definitions from the
RBD storage pool definition, and applies it to the disk
definition.
---
src/qemu/qemu_conf.c | 39 +++
1 file changed, 39 insertions(+)
diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index 43787
virDomainDiskDefForeachPath returned 0 previously for disks of type
VIR_DOMAIN_DISK_TYPE_NETWORK. This patch extends this check to also
bypass the function for VIR_DOMAIN_DISK_TYPE_VOLUME, shoudl the new
disk variable def->actualtype contain VIR_DOMAIN_DISK_TYPE_NETWORK.
---
src/conf/domain_conf.c
While testing Peter's changes to my patches, I discovered that when
restarting libvirt with domains running, they would no longer show
up when a 'virsh list' was issued. I tracked this bug down to this
section of code within virDomainDiskDefParseXML. The symptom was
that libvirt was issuing an inte
could probably use
testing by others if anyone else has Ceph configured.
The last patch in this series isn't needed in order to have RBD volumes work
for domains, but it is needed if you don't want to have to kill the domain to
get it back under the control of libvirt.
Adam Walters (4):
sorry for
the delayed response. I had to make a trip out to Tallahassee yesterday for
work, which took all day.
On Thu, Dec 5, 2013 at 6:13 AM, Peter Krempa wrote:
> From: Adam Walters
>
> This implements RBD storage pool support in the
> qemuTranslateDiskSourcePool function. This
This patch resolves a compile issue caused by the
removal of examples/domsuspend code in commit
5eb4b04211ea379c58f735dee6c2852c8b80da89. This issue
is only seen in a fresh checkout, but causes the build
and configure to fail.
---
configure.ac | 1 -
1 file changed, 1 deletion(-)
diff --git a/con
This implements RBD storage pool support in the
qemuTranslateDiskSourcePool function. This support
is working on my machine, but could probably use
some additional testing. It is implemented very
similarly to the ISCSI support.
---
src/qemu/qemu_conf.c | 36 +++-
1
bug in configure.ac introduced in a recent
commit. I had to fix it in order to get my Archlinux package to compile
on another machine so I could test the code before submission, so I
figured that I would go ahead and share it with everyone, too.
Adam Walters (3):
qemu: conf: Add
This helper function pulls the host definitions from the
RBD storage pool definition, and applies it to the disk
definition.
---
src/qemu/qemu_conf.c | 39 +++
1 file changed, 39 insertions(+)
diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index 44e43
This patch modifies the switch statement in qemuBuildVolumeString
to format and pass the needed argument to handle a volume from an
RBD storage pool properly. If the volume is a VIR_STORAGE_VOL_NETWORK
but is not from an RBD pool, I goto cleanup, just like the other
unimplemented volume types. Curr
be the better method to interact with storage, and
thus
likely to be the best way to go in the future. I figure that additional storage
backend support may well help to get others using the API instead of duplicating
configuration options across every VM.
Adam Walters (3):
qemu: config: Add
Add a function to grab the RBD hosts from a pool definition and add
them to the disk definition. This function allows the addition of
RBD storage pool functionality.
---
src/qemu/qemu_conf.c | 39 +++
1 file changed, 39 insertions(+)
diff --git a/src/qemu/qemu_
Modify switch statement in qemuTranslateDiskSourcePool
to parse the storage pool definition for RBD pools
instead of throwing an error. I do throw errors for
any other usage case of VIR_STORAGE_VOL_NETWORK, as my
code does not cover their use cases currently. Once I
have the ability to test such us
---
src/qemu/qemu_command.c | 11 ++---
src/qemu/qemu_conf.c| 66 ++---
2 files changed, 71 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 966aa0d..1bec983 100644
--- a/src/qemu/qemu_command.c
, being a modified copy of the iSCSI storage volume code.
Adam Walters (1):
Implementing RBD support for QEMU via Storage API (Storage pools)
src/qemu/qemu_command.c | 11 ++---
src/qemu/qemu_conf.c| 66 ++---
2 files changed, 71 insertions(+), 6
59 matches
Mail list logo
