Hey Laine,
Have some time to review this?
2017-06-23 1:44 GMT+01:00 <ar...@gnome.org>:
> From: Alberto Ruiz <ar...@gnome.org>
>
> Fixes #913446
>
> This patch addresses a few problems found by the initial reviews:
>
> * leaseTime
2017-06-22 21:47 GMT+01:00 Laine Stump <la...@laine.org>:
> On 06/22/2017 12:21 PM, Alberto Ruiz wrote:
>> Hello Laine,
>>
>> 2017-06-21 17:30 GMT+01:00 Laine Stump <la...@laine.org
>> <mailto:la...@laine.org>>:
>>
>> On 06/21/2017 03
2017-06-22 22:05 GMT+01:00 Laine Stump <la...@laine.org>:
>
> On 06/22/2017 01:12 PM, Alberto Ruiz wrote:
> >
> >
> > 2017-06-21 17:30 GMT+01:00 Laine Stump <la...@laine.org
> > <mailto:la...@laine.org>>:
> >
> > On 06/21/2017 03:27
2017-06-21 17:30 GMT+01:00 Laine Stump <la...@laine.org>:
> On 06/21/2017 03:27 AM, Peter Krempa wrote:
> > On Tue, Jun 20, 2017 at 19:00:43 +0100, ar...@gnome.org wrote:
> >> From: Alberto Ruiz <ar...@gnome.org>
> >
> > Missing commit message.
>
2017-06-21 17:30 GMT+01:00 Laine Stump <la...@laine.org>:
> On 06/21/2017 03:27 AM, Peter Krempa wrote:
> > On Tue, Jun 20, 2017 at 19:00:43 +0100, ar...@gnome.org wrote:
> >> From: Alberto Ruiz <ar...@gnome.org>
> >
> > Missing commit message.
>
Hello Laine,
2017-06-21 17:30 GMT+01:00 Laine Stump <la...@laine.org>:
> On 06/21/2017 03:27 AM, Peter Krempa wrote:
> > On Tue, Jun 20, 2017 at 19:00:43 +0100, ar...@gnome.org wrote:
> >> From: Alberto Ruiz <ar...@gnome.org>
> >
> > Missing commit
uot;,%" PRId64, leasetime);
> > +/* TODO: Discuss the use of "deprecated" for ipv6*/
> > +/* TODO: Discuss what is the default value that we want as
> dnsmasq's is 1 hour */
> > +/* TODO: Discuss what to do if value exceeds maximum, use default
> value for now */
> > +else {
> > +virBufferAsprintf(, "%s", "");
> > +}
> > +
> > +result = virBufferContentAndReset();
> > +virBufferFreeAndReset ();
> > +
> > +return result;
> > +}
> >
> > int
> > networkDnsmasqConfContents(virNetworkObjPtr network,
> > @@ -1213,6 +1249,7 @@ networkDnsmasqConfContents(virNetworkObjPtr
> network,
> > }
> > for (r = 0; r < ipdef->nranges; r++) {
> > int thisRange;
> > +char *leasestr;
> >
> > if (!(saddr = virSocketAddrFormat(>ranges[r].start))
> ||
> > !(eaddr = virSocketAddrFormat(>ranges[r].end)))
> > @@ -1220,12 +1257,22 @@ networkDnsmasqConfContents(virNetworkObjPtr
> network,
> >
> > virBufferAsprintf(, "dhcp-range=%s,%s",
> >saddr, eaddr);
> > -if (VIR_SOCKET_ADDR_IS_FAMILY(>address, AF_INET6))
> > +
> > +/* Add ipv6 prefix length parameter if needed */
> > +if (ipdef == ipv6def)
> > virBufferAsprintf(, ",%d", prefix);
> > +
> > +leasestr = networkDnsmasqConfLeaseValueToString
> (ipdef->leasetime);
> > +if (!leasestr)
> > +goto cleanup;
> > +virBufferAsprintf(, "%s", leasestr);
> > +
> > +/* Add the newline */
> > virBufferAddLit(, "\n");
> >
> > VIR_FREE(saddr);
> > VIR_FREE(eaddr);
> > +VIR_FREE(leasestr);
> > thisRange = virSocketAddrGetRange(>ranges[r].start,
> >>ranges[r].end,
> >>address,
>
> Also this patch does not apply to current master.
>
> Peter
>
--
Cheers,
Alberto Ruiz
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
riv...@redhat.com>
wrote:
> On 13.10.2016 00:03, Alberto Ruiz wrote:
> > Support for custom dhcp wide and per host leasetime.
> >
> > It is specified as a child tag for :
> >
> > 24h
> > ...
> >
> >
> > And as an attribute for :
> &g
kxml2confdata/%s.conf",
+virAsprintf(, "%s/networkxml2confdata/%s.conf",
+abs_srcdir, info->name) < 0 ||
+virAsprintf(, "%s/networkxml2confdata/%s.hostsfile",
abs_srcdir, info->name) < 0) {
goto cl
On Tue, Apr 19, 2016 at 2:34 AM, Laine Stump <la...@laine.org> wrote:
> On 04/18/2016 06:52 PM, Cole Robinson wrote:
>
>> On 04/15/2016 08:18 PM, Alberto Ruiz wrote:
>>
>>> From 112f61ec5cfdc39f7a157825c4209f7bae34c483 Mon Sep 17 00:00:00 2001
>>> Fro
On Mon, Apr 18, 2016 at 11:52 PM, Cole Robinson <crobi...@redhat.com> wrote:
> On 04/15/2016 08:18 PM, Alberto Ruiz wrote:
> > From 112f61ec5cfdc39f7a157825c4209f7bae34c483 Mon Sep 17 00:00:00 2001
> > From: Alberto Ruiz <ar...@gnome.org>
> > Date: Wed, 13 Ap
work with services after the machines
have to be rebooted. One has to discover the ip again... setup ssh keys...
This patch is a first attempt so feel free to let me know if I'm aiming at
the right direction.
Thanks!
[0]https://bugzilla.redhat.com/show_bug.cgi?id=913446
--
Alberto Ruiz
12 matches
Mail list logo
