Re: [libvirt PATCH 2/2] ci: Avoid use of magic constants

2021-09-13 Thread Beraldo Leal
kerfiles: > +if img["name"][len(name_prefix):] not in dockerfiles: > stale_images[img["name"]] = img["id"] > > return stale_images > -- > 2.31.1 > Reviewed-by: Beraldo Leal -- Beraldo

Re: [libvirt PATCH 0/4] RFC: tests: introduce lavocado

2021-07-22 Thread Beraldo Leal
On Thu, Jul 22, 2021 at 09:44:28AM +0100, Daniel P. Berrangé wrote: > On Wed, Jul 21, 2021 at 04:22:19PM -0300, Beraldo Leal wrote: > > On Wed, Jul 21, 2021 at 06:50:03PM +0100, Daniel P. Berrangé wrote: > > > On Thu, Jul 01, 2021 at 06:09:47PM -0300, Beraldo Leal wrote: >

Re: [libvirt PATCH 0/4] RFC: tests: introduce lavocado

2021-07-21 Thread Beraldo Leal
On Wed, Jul 21, 2021 at 06:50:03PM +0100, Daniel P. Berrangé wrote: > On Thu, Jul 01, 2021 at 06:09:47PM -0300, Beraldo Leal wrote: > > On Thu, Jul 01, 2021 at 07:04:32PM +0100, Daniel P. Berrangé wrote: > > > On Wed, Jun 30, 2021 at 01:36:30PM -0300, Beraldo Leal wrote: >

Re: [libvirt PATCH 0/4] RFC: tests: introduce lavocado

2021-07-02 Thread Beraldo Leal
On Fri, Jul 02, 2021 at 12:43:57PM +0100, Daniel P. Berrangé wrote: > On Thu, Jul 01, 2021 at 06:09:47PM -0300, Beraldo Leal wrote: > > On Thu, Jul 01, 2021 at 07:04:32PM +0100, Daniel P. Berrangé wrote: > > > On Wed, Jun 30, 2021 at 01:36:30PM -0300, Beraldo Leal wrote: >

Re: [libvirt PATCH 0/4] RFC: tests: introduce lavocado

2021-07-01 Thread Beraldo Leal
On Thu, Jul 01, 2021 at 07:04:32PM +0100, Daniel P. Berrangé wrote: > On Wed, Jun 30, 2021 at 01:36:30PM -0300, Beraldo Leal wrote: > > If I look at Avocado, I think (correct me if i'm wrong) > > 1. The harness is essentially the standard Python harness > with a thin CLI w

[libvirt PATCH 4/4] tests.lavocado: adding a README and Makefile for convenience

2021-06-30 Thread Beraldo Leal
Signed-off-by: Beraldo Leal --- tests/lavocado/Makefile | 2 + tests/lavocado/README.md | 124 +++ 2 files changed, 126 insertions(+) create mode 100644 tests/lavocado/Makefile create mode 100644 tests/lavocado/README.md diff --git a/tests/lavocado

[libvirt PATCH 3/4] tests.lavocado: adding a .gitignore

2021-06-30 Thread Beraldo Leal
This will prevent unnecessary Python object and temporary files to be tracked by git. Signed-off-by: Beraldo Leal --- tests/lavocado/.gitignore | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 tests/lavocado/.gitignore diff --git a/tests/lavocado/.gitignore b/tests/lavocado

[libvirt PATCH 2/4] tests.lavocado: adding basic transient domain tests

2021-06-30 Thread Beraldo Leal
This basic test case validates the core lifecycle and operations on transient domains and came from libvirt-tck as an exercise in porting tests. Signed-off-by: Beraldo Leal --- tests/lavocado/tests/domain/transient.py | 102 +++ 1 file changed, 102 insertions(+) create mode

[libvirt PATCH 1/4] tests: introduce lavocado: initial code structure

2021-06-30 Thread Beraldo Leal
to speed up common test writing scenarios. Signed-off-by: Beraldo Leal --- tests/lavocado/lavocado/__init__.py | 0 tests/lavocado/lavocado/defaults.py | 11 ++ tests/lavocado/lavocado/exceptions.py | 20 +++ tests/lavocado/lavocado/helpers/__init__.py | 0 tests/lavocado

[libvirt PATCH 0/4] RFC: tests: introduce lavocado

2021-06-30 Thread Beraldo Leal
in this environment and not tamper with your main system. I'm adding more information with some details inside the README file. Beraldo Leal (4): tests: introduce lavocado: initial code structure tests.lavocado: adding basic transient domain tests tests.lavocado: adding a .gitignore tests.lavocado