Re: [libvirt] [PATCH] virsh nodecpustats returns incorrect stats of cpu on Linux when the number of online cpu exceed 9.

2014-01-16 Thread Bing Bu Cao
On 01/14/2014 09:40 PM, Daniel P. Berrange wrote: On Mon, Jan 13, 2014 at 06:28:07PM +0800, m...@linux.vnet.ibm.com wrote: From: Bing Bu Cao To retrieve node cpu statistics on Linux system, the linuxNodeGetCPUstats function use STRPREFIX() to match the cpuid with the cpuid read from /proc

Re: [libvirt] [PATCH] virsh nodecpustats returns incorrect stats of cpu on Linux when the number of online cpu exceed 9.

2014-01-15 Thread Bing Bu Cao
On 01/14/2014 09:30 PM, Ján Tomko wrote: On 01/13/2014 11:28 AM, m...@linux.vnet.ibm.com wrote: From: Bing Bu Cao To retrieve node cpu statistics on Linux system, the linuxNodeGetCPUstats function use STRPREFIX() to match the cpuid with the cpuid read from /proc/cpustat, it will cause obvious

Re: [libvirt] [PATCH 1/1] virsh nodecpustats erroneously returns stats for offline cpus on Linux

2013-12-20 Thread Bing Bu Cao
o/libvir-list -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list -- Best Regards, Bing Bu Cao -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 1/1] virsh nodecpustats erroneously returns stats for offline cpus on Linux

2013-12-19 Thread Bing Bu Cao
On 12/19/2013 12:40 PM, Pradipta Kr. Banerjee wrote: From: "Pradipta Kr. Banerjee" virsh nodecpustats erroneously returns stats for offline cpus on Linux To retrieve node cpu statistics on Linux system, the linuxNodeGetCPUstats function performs a minimal match of the input cpuid with the cpui

Re: [libvirt] [PATCH 1/1] virsh nodecpustats erroneously returns stats for offline cpus on Linux

2013-12-19 Thread Bing Bu Cao
if (sscanf(buf, @@ -697,6 +698,7 @@ linuxNodeGetCPUStats(FILE *procstat, ret = 0; goto cleanup; } +virStringFreeList(buf_header); } virReportInvalidArg(cpuNum, -- 1.8.3.1 -- libvir-list mailing list libvir-list@redhat.com https://www.