Re: [libvirt] ZFS backend does fail if used on non top level pools

2018-05-11 Thread Brian Candler
> This one is the "unknown" for me.  What happens if you create > Xzfs/images/vol1 (or your command below) without first creating Xzfs/images? Answer: it fails, unless you give the '-p' flag.    -p    Creates all the non-existing parent datasets. Datasets created in this 

Re: [libvirt] PATCH: better error checking for LOCAL_PEERCRED

2013-10-17 Thread Brian Candler
On 17/10/2013 13:29, Eric Blake wrote: On the other hand, making someone chase a URL is less convenient than attaching the patch (ideally, sending inline the way 'git send-email' does things is preferred, but since 'git am' can also handle attachments, it's still easier on the maintainer to send

Re: [libvirt] PATCH: better error checking for LOCAL_PEERCRED

2013-10-16 Thread Brian Candler
On 15/10/2013 12:16, Daniel P. Berrange wrote: Unfortunately your patch does not apply since your mail client has messed up line wrapping. Also there have been conflicting changes to the code since your patch. I would fix it myself, but I don't have ability to compile test code on BSD platforms.

[libvirt] PATCH: better error checking for LOCAL_PEERCRED

2013-10-14 Thread Brian Candler
-like systems. Regards, Brian Candler. --- src/rpc/virnetsocket.c.orig 2013-10-10 22:37:49.0 +0100 +++ src/rpc/virnetsocket.c 2013-10-12 22:51:57.0 +0100 @@ -1157,8 +1157,10 @@ { struct xucred cr; socklen_t cr_len = sizeof(cr); +int ret = -1; virObjectLock

[libvirt] PATCH: better error checking for LOCAL_PEERCRED

2013-10-13 Thread Brian Candler
-like systems. You could just have if (cr.cr_ngroups = 0) instead. Regards, Brian Candler. --- src/rpc/virnetsocket.c.orig2013-10-10 22:37:49.0 +0100 +++ src/rpc/virnetsocket.c2013-10-12 22:51:57.0 +0100 @@ -1157,8 +1157,10 @@ { struct xucred cr; socklen_t cr_len