At 2017-09-05 22:01:56, "Chen Hanxiao" wrote:
>From: Chen Hanxiao
>
> We had 'size' limits for virDomainMemoryPeek
> and virDomainBlockPeek by macro
> REMOTE_DOMAIN_BLOCK_PEEK_BUFFER_MAX and
> REMOTE_DOMAIN_MEMORY_PEEK_BUFFER_MAX.
>
> The descr
From: Chen Hanxiao
Option --full will always display the name and MAC
address of the interface.
Both virsh help and virsh man page didn't mention that.
Signed-off-by: Chen Hanxiao
---
tools/virsh-domain-monitor.c | 2 +-
tools/virsh.pod | 6 +++---
2 files chang
From: Chen Hanxiao
We lacked of hot unplugging redirdev device.
This patch adds support for it.
We could use detach-device --live now.
Signed-off-by: Chen Hanxiao
---
src/qemu/qemu_driver.c | 4 +-
src/qemu/qemu_hotplug.c | 111
src
From: Chen Hanxiao
In the definition of virHookQemuOpType and virHookNetworkOpType,
we should use 'stopped' rather than 'shutdown'.
Signed-off-by: Chen Hanxiao
---
docs/hooks.html.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/hooks.html.in
At 2017-11-10 16:35:59, "Chen Hanxiao" wrote:
>From: Chen Hanxiao
>
> We lacked of hot unplugging redirdev device.
> This patch adds support for it.
> We could use detach-device --live now.
>
>Signed-off-by: Chen Hanxiao
ping
Regards,
- Chen
--
libvi
From: Chen Hanxiao
In [1], are described as "on_poweroff",
"on_reboot", "on_crash".
but we accept "poweroff", "reboot" and "crash".
This patch adds docs about them.
[1]: https://libvirt.org/formatdomain.html#elementsE
At 2018-06-21 19:28:55, "Chen Hanxiao" wrote:
>From: Chen Hanxiao
>
>In [1], are described as "on_poweroff",
> "on_reboot", "on_crash".
> but we accept "poweroff", "reboot" and "crash".
>This
At 2018-07-03 15:36:19, "Michal Prívozník" wrote:
>On 07/02/2018 01:08 PM, dubo163 wrote:
>> From: dubobo
>>
>> the libvirtd pid file is not match the os process pid number
>> which is smaller than before.
>>
>> this would be exist if the libvirtd process coredump or the os
>> process was kill
At 2017-11-20 11:08:54, "Chen Hanxiao" wrote:
>
>At 2017-11-10 16:35:59, "Chen Hanxiao" wrote:
>>From: Chen Hanxiao
>>
>> We lacked of hot unplugging redirdev device.
>> This patch adds support for it.
>> We could use detach-devi
From: Chen Hanxiao
Commit 5e5019bf removed this kind of error.
But we've already protected race condition by qemuDomainObjEnterAgent,
it was very unlikely to revieve a sync from other calls.
For call from virDomain*, it's better to show this error
if we really got a mismatch sync.
At 2017-11-30 14:11:36, "Nikolay Shirokovskiy"
wrote:
>
>
>On 30.11.2017 06:08, Chen Hanxiao wrote:
>> From: Chen Hanxiao
>>
>> Commit 5e5019bf removed this kind of error.
>>
>> But we've already protected race condition by qemuDomainOb
From: Chen Hanxiao
We lacked of hot unplugging redirdev device.
This patch add support for it.
We could use detach-device --live now.
Signed-off-by: Chen Hanxiao
---
rebase on 3.10
src/qemu/qemu_driver.c | 4 +-
src/qemu/qemu_hotplug.c | 111
From: Chen Hanxiao
We lacked of hot unplugging redirdev device.
This patch add support for it.
We could use detach-device --live now.
Signed-off-by: Chen Hanxiao
---
v2: add news section
docs/news.xml | 9
src/qemu/qemu_driver.c | 4 +-
src/qemu/qemu_hotplug.c | 111
From: Chen Hanxiao
Since commit 5e5019bf, we've no longer use
VIR_ERR_AGENT_UNSYNCED anymore.
Mark it as DEPRECATED.
Signed-off-by: Chen Hanxiao
---
include/libvirt/virterror.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/libvirt/virterror.h b/include/li
At 2017-12-07 17:30:15, "Michal Privoznik" wrote:
>On 12/07/2017 02:59 AM, Chen Hanxiao wrote:
>> From: Chen Hanxiao
>>
>> Since commit 5e5019bf, we've no longer use
>> VIR_ERR_AGENT_UNSYNCED anymore.
>> Mark it as DEPRECATED.
>>
>
At 2017-12-07 17:35:42, "Peter Krempa" wrote:
>On Thu, Dec 07, 2017 at 09:26:12 +0800, Chen Hanxiao wrote:
>> From: Chen Hanxiao
>>
>> We lacked of hot unplugging redirdev device.
>> This patch add support for it.
>> We could use detach-de
v2.1:
split original patch into a patchset, put News in a seperate patch
Chen Hanxiao (2):
qemu: Add support for hot unplug redirdev device
news: add change of hot unplug redirdev
docs/news.xml | 9
src/qemu/qemu_driver.c | 4 +-
src/qemu/qemu_hotplug.c | 111
From: Chen Hanxiao
Add hot unplug redirdev in news 'New features' section
Signed-off-by: Chen Hanxiao
---
v2.1:
put news part into a seperate patch
docs/news.xml | 9 +
1 file changed, 9 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 0ec9857e2..ec32dc
From: Chen Hanxiao
We lacked of hot unplugging redirdev device.
This patch add support for it.
We could use detach-device --live now.
Signed-off-by: Chen Hanxiao
---
v2.1:
rebase on master
src/qemu/qemu_driver.c | 4 +-
src/qemu/qemu_hotplug.c | 111
At 2017-12-07 18:42:37, "Chen Hanxiao" wrote:
>v2.1:
>split original patch into a patchset, put News in a seperate patch
>
>Chen Hanxiao (2):
> qemu: Add support for hot unplug redirdev device
> news: add change of hot unplug redirdev
>
> docs/news.x
From: Chen Hanxiao
Some services, such as Nova, check whether device was not found
by errror messages "not found". [1]
This patch unify logs of qemuDomainDetachDeviceLive, which will be helpful.
[1]
https://github.com/openstack/nova/blob/master/nova/virt/libvirt/guest.py#L406
Sig
At 2017-12-16 09:26:32, "John Ferlan" wrote:
>
>
>On 12/14/2017 06:16 AM, Chen Hanxiao wrote:
>> From: Chen Hanxiao
>>
>> Some services, such as Nova, check whether device was not found
>> by errror messages "not found&
From: Chen Hanxiao
As the description of daemon/libvirtd.conf, setting
key_file, cert_file or key_file will override the default value.
But if we set any one of them, we need to set all the rest of them.
This patch set default value to them as daemon/libvirtd.conf
described.
Signed-off-by
ining the copy and pasted code.
>
>Signed-off-by: John Ferlan
>---
>
> An offshoot of the redirdev hot unplug patches from Chen Hanxiao.
> Let's create a helper that can remove the TLS chardev objects for
> the specific devices that may have used them.
>
Reviewed-by: Chen Ha
At 2017-12-18 21:57:11, "John Ferlan" wrote:
>
>
>On 12/15/2017 09:50 PM, Chen Hanxiao wrote:
>>
>>
>> At 2017-12-16 09:26:32, "John Ferlan" wrote:
>>>
>>>
>>> On 12/14/2017 06:16 AM, Chen Hanxiao wrote:
>>>&g
From: Chen Hanxiao
We used VIR_ERR_OPERATION_FAILED when target detaching device
is not found.
That error code VIR_ERR_OPERATION_FAILED is widely used,
so the tools powered by libvirt, such as nova,
can't catch the exact errors from libvirt.
This patch uses VIR_ERR_NO_DEVICE instead.
Signe
t; the morning" I realized I could/should have taken the next step to check
> the chardev source for TCP and haveTLS being set similar to how the Add
> code does things. So that's what this patch does.
>
Ahh, more helpful helper.
Reviewed-by: Chen Hanxiao
Regards,
- Chen
--
From: Chen Hanxiao
We lacked of hot unplugging redirdev device.
This patch add support for it.
We could use detach-device --live now.
Signed-off-by: Chen Hanxiao
---
v3:
use helper qemuDomainDelChardevTLSObjects
address John's comments
v2:
rebase on master
src/qemu/qemu_driver.c
From: Chen Hanxiao
Add hot unplug redirdev in news 'Improvements' section
Signed-off-by: Chen Hanxiao
---
v3:
move it into 'Improvements' section
docs/news.xml | 11 +++
1 file changed, 11 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index bb611b7
v3:
use helper qemuDomainDelChardevTLSObjects and address some comments
v2:
rebased on master
Chen Hanxiao (2):
qemu: Add support for hot unplugging redirdev device which can use the
detach-device --live
news: add change of hot unplug redirdev
docs/news.xml | 11
From: Chen Hanxiao
We don't have @result. Use the right one: @matches
Signed-off-by: Chen Hanxiao
---
src/util/virstring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/virstring.c b/src/util/virstring.c
index b2ebce27f..0cb06bdc9 100644
--- a/src
From: Chen Hanxiao
If we insert or eject a CD-ROM/floppy device with a boot order,
we may get:
unsupported configuration: boot order 2 is already used by another device
This check should be skipped in this case.
Signed-off-by: Chen Hanxiao
---
src/conf/domain_conf.c | 16
At 2018-01-03 17:46:02, "Ján Tomko" wrote:
>On Sat, Dec 23, 2017 at 05:49:08PM +0800, Chen Hanxiao wrote:
>>From: Chen Hanxiao
>>
>>We don't have @result. Use the right one: @matches
>>
>>Signed-off-by: Chen Hanxiao
>>---
>> src/
From: Chen Hanxiao
commit 9026d1152c236ac7a7ab25845220a8e14d6bc630
forgot to change the referenced @result variable.
This patch completed this.
Signed-off-by: Chen Hanxiao
---
src/util/virstring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/virstring.c b/src
From: Chen Hanxiao
Reviewed-by: John Ferlan
Signed-off-by: Chen Hanxiao
---
v4:
remove part
v3:
move it into 'Improvements' section
docs/news.xml | 5 +
1 file changed, 5 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index bb611b7ba..838dd5b39 100644
--- a/doc
From: Chen Hanxiao
Commit id '162efa1a' added support hotplug a redirdev, but
did not add the hot unplug. This patch will add that support
to allow usage of the detach-device --live on the device.
Reviewed-by: John Ferlan
Signed-off-by: Chen Hanxiao
---
v4:
commit message chang
v4:
update commit messages and news
v3:
use helper qemuDomainDelChardevTLSObjects and address some comments
v2:
rebased on master
Chen Hanxiao (2):
qemu: Add support for hot unplugging redirdev device which can use the
detach-device --live
news: add change of hot unplug redirdev
From: Chen Hanxiao
We used VIR_ERR_OPERATION_FAILED when target detaching device
is not found.
That error code VIR_ERR_OPERATION_FAILED is widely used,
so the tools powered by libvirt, such as nova,
can't catch the exact errors from libvirt.
This patch introduce VIR_ERR_DEVICE_MISSING for
We used VIR_ERR_OPERATION_INVALID for failing to find the desired
device.
But this error code is widely used.
This brings troubles to the project(i.e nova) powered by libvirt,
they had to analyze error messages to find out what
had happened.
Chen Hanxiao (2):
qemu_hotplug: more proper error
From: Chen Hanxiao
More proper/detail error messages updated.
Signed-off-by: Chen Hanxiao
---
src/libvirt_private.syms | 2 ++
src/qemu/qemu_hotplug.c | 42 +-
2 files changed, 31 insertions(+), 13 deletions(-)
diff --git a/src/libvirt_private.syms b
From: Chen Hanxiao
Reviewed-by: John Ferlan
Signed-off-by: Chen Hanxiao
---
v4:
remove part
v3:
move it into 'Improvements' section
docs/news.xml | 5 +
1 file changed, 5 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index bb611b7ba..838dd5b39 100644
--- a/doc
v4.1:
call qemuDomainRemoveRedirdevDevice in qemuDomainRemoveDevice
v4:
update commit messages and news
v3:
use helper qemuDomainDelChardevTLSObjects and address some comments
v2:
rebased on master
Chen Hanxiao (2):
qemu: Add support for hot unplugging redirdev device which can use
From: Chen Hanxiao
Commit id '162efa1a' added support hotplug a redirdev, but
did not add the hot unplug. This patch will add that support
to allow usage of the detach-device --live on the device.
Reviewed-by: John Ferlan
Signed-off-by: Chen Hanxiao
---
v4
在 2018-01-05 21:16:20，"John Ferlan" 写道：
>
>
>On 01/05/2018 05:40 AM, Ján Tomko wrote:
>> On Fri, Dec 22, 2017 at 04:04:03PM +0800, Chen Hanxiao wrote:
>>> From: Chen Hanxiao
>>>
[...]
>>> + if ((ret = qemuDomainWaitForDeviceRemoval(vm)) ==
At 2018-01-05 23:01:50, "John Ferlan" wrote:
>
>
>On 12/25/2017 06:21 AM, Chen Hanxiao wrote:
>> From: Chen Hanxiao
>>
>> If we insert or eject a CD-ROM/floppy device with a boot order,
>> we may get:
>> unsupported configuration: boot orde
From: Chen Hanxiao
If we insert or eject a CD-ROM/floppy device by:
'virsh change-media VM --eject/--insert some.iso --live',
and the original CD-ROM device was configed with a boot order,
we may get:
unsupported configuration: boot order 2 is already used by another device
We ju
At 2018-01-11 21:36:29, "Ján Tomko" wrote:
>On Thu, Jan 11, 2018 at 06:16:37PM +0800, Chen Hanxiao wrote:
>>From: Chen Hanxiao
>>
>>If we insert or eject a CD-ROM/floppy device by:
>> 'virsh change-media VM --eject/--insert some.iso --live',
>&
From: Chen Hanxiao
As the description of daemon/libvirtd.conf, setting
key_file, cert_file or key_file will override the default value.
But if we set any one of them, we need to set all the rest of them.
This patch set default value to them as daemon/libvirtd.conf
described.
Signed-off-by
At 2018-01-12 17:44:38, "Jiri Denemark" wrote:
>On Fri, Jan 12, 2018 at 17:09:10 +0800, Chen Hanxiao wrote:
>> From: Chen Hanxiao
>>
>> As the description of daemon/libvirtd.conf, setting
>> key_file, cert_file or key_file will override the default value.
From: Chen Hanxiao
As the description of daemon/libvirtd.conf, setting
key_file, cert_file or key_file will override the default value.
But if we set any one of them, we need to set all the rest of them.
This patch clarify that description.
Signed-off-by: Chen Hanxiao
---
daemon
From: Chen Hanxiao
As the description of daemon/libvirtd.conf, setting
key_file, cert_file or key_file will override the default value.
But if we set any one of them, we need to set all the rest of them.
This patch clarify that description.
Signed-off-by: Chen Hanxiao
---
v2:
fix a typo
From: Chen Hanxiao
Provide more details related to the requirement that setting one
of the values requires setting all of them.
Signed-off-by: Chen Hanxiao
---
v3:
description updated follow John's comments
v2:
fix a typo
daemon/libvirtd.conf | 14 ++
1 file change
From: Chen Hanxiao
Signed-off-by: Chen Hanxiao
---
docs/news.xml | 5 +
1 file changed, 5 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index b4d980624..5798f42d8 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -37,6 +37,11
From: Chen Hanxiao
Modify OPERATION_FAILED error codes to use DEVICE_MISSING instead.
Signed-off-by: Chen Hanxiao
---
v3:
modify virDomainNetFindIdx to use VIR_ERR_DEVICE_MISSING
src/conf/domain_conf.c | 8
src/qemu/qemu_hotplug.c | 24
2 files changed
Use Introduce VIR_ERR_DEVICE_MISSING for hotplug and detach device
error message.
Chen Hanxiao (5):
qemu: Add some more details for hotplug errors when device not found
qemu: Introduce VIR_ERR_DEVICE_MISSING
qemu: Use VIR_ERR_DEVICE_MISSING for various hotplug messages
qemu: Use
From: Chen Hanxiao
Add new error code to be able to allow consumers (such as Nova) to be
able to key of a specific error code rather than needing to search the
error message."
Signed-off-by: Chen Hanxiao
---
v3:
commit message updated
include/libvirt/virterror.h | 1 +
src/util/virer
From: Chen Hanxiao
Modify OPERATION_FAILED error codes to use DEVICE_MISSING instead.
Signed-off-by: Chen Hanxiao
---
src/qemu/qemu_driver.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index
From: Chen Hanxiao
More proper/detail error messages updated.
Signed-off-by: Chen Hanxiao
---
v3:
subject changed.
some description of logs changed.
src/libvirt_private.syms | 2 ++
src/qemu/qemu_hotplug.c | 35 +++
2 files changed, 25 insertions(+), 12
From: Chen Hanxiao
Introduce VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_ARP to get ip address
of VM from the output of `arp -an` command.
We can use:
domifaddr f26-cloud --source arp
to get the address.
Signed-off-by: Chen Hanxiao
---
include/libvirt/libvirt-domain.h | 1 +
src/qemu
At 2018-01-24 02:01:27, "Martin Kletzander" wrote:
>On Tue, Jan 23, 2018 at 03:40:02PM +0800, Chen Hanxiao wrote:
>>From: Chen Hanxiao
>>
>>Introduce VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_ARP to get ip address
>>of VM from the output of `arp -an`
From: Chen Hanxiao
Signed-off-by: Chen Hanxiao
---
docs/news.xml | 5 +
1 file changed, 5 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index b9e04c632..105917f4d 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -47,6 +47,11 @@
interfaces, NWFilters, and so on
From: Chen Hanxiao
introduce VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_ARP to get ip address
of VM from the output of /proc/net/arp
Signed-off-by: Chen Hanxiao
---
include/libvirt/libvirt-domain.h | 1 +
src/qemu/qemu_driver.c | 75
2 files changed
From: Chen Hanxiao
We can use:
domifaddr f26-cloud --source arp
to get the address.
Signed-off-by: Chen Hanxiao
---
tools/virsh-domain-monitor.c | 2 ++
tools/virsh.pod | 7 ---
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/tools/virsh-domain-monitor.c b
From: Chen Hanxiao
introduce helper to parse /proc/net/arp and
store it in struct virArpTable.
Signed-off-by: Chen Hanxiao
---
src/libvirt_private.syms | 2 ++
src/util/virmacaddr.c| 67
src/util/virmacaddr.h| 18 +
3 files
introduce VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_ARP to get ip address
of VM from the output of /proc/net/arp
Chen Hanxiao (4):
util: introduce helper to parse /proc/net/arp
qemu: introduce qemuARPGetInterfaces to get IP from host's arp table
virsh: add --source arp to domifaddr
news:
From: Chen Hanxiao
introduce helper to parse /proc/net/arp and
store it in struct virArpTable.
Signed-off-by: Chen Hanxiao
---
v3:
s/virGetArpTable/virArpTableGet
alloc virArpTable in virArpTableGet
return ENOSUPP on none-Linux platform
move helpers to virarptable.[ch]
po/POTFILES.in
From: Chen Hanxiao
introduce VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_ARP to get ip address
of VM from the output of /proc/net/arp
Signed-off-by: Chen Hanxiao
---
v3:
add docs in virDomainInterfaceAddresses
remove error label
show network interface which did not match the arp table
include
From: Chen Hanxiao
We can use:
domifaddr f26-cloud --source arp
to get the address.
Acked-by: Michal Privoznik
Signed-off-by: Chen Hanxiao
---
tools/virsh-domain-monitor.c | 2 ++
tools/virsh.pod | 7 ---
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/tools
From: Chen Hanxiao
Signed-off-by: Chen Hanxiao
---
v3:
more verbose description
docs/news.xml | 9 +
1 file changed, 9 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 2268fdf79..706546e6d 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -56,6 +56,15
introduce VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_ARP to get ip address
of VM from the output of /proc/net/arp
Chen Hanxiao (4):
util: introduce helper to parse /proc/net/arp
qemu: introduce qemuARPGetInterfaces to get IP from host's arp table
virsh: add --source arp to domifaddr
news:
At 2018-01-31 23:32:35, "John Ferlan" wrote:
>
>
>On 01/22/2018 11:24 PM, Chen Hanxiao wrote:
>> From: Chen Hanxiao
>>
>> Add new error code to be able to allow consumers (such as Nova) to be
>> able to key of a specific error code rather
At 2018-01-31 23:33:35, "John Ferlan" wrote:
>
>
>On 01/22/2018 11:24 PM, Chen Hanxiao wrote:
>> From: Chen Hanxiao
>>
>> Modify OPERATION_FAILED error codes to use DEVICE_MISSING instead.
>
>I'll modify this one to:
>
>Modify
From: Chen Hanxiao
Signed-off-by: Chen Hanxiao
---
Changes | 2 +-
Virt.xs | 1 +
lib/Sys/Virt/Error.pm | 4
3 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/Changes b/Changes
index eda3ec5..22d5752 100644
--- a/Changes
+++ b/Changes
@@ -2,7 +2,7
At 2018-01-31 23:34:55, "John Ferlan" wrote:
>
>Let's alter the commit message to be more similar to patch 3/5, e.g.:
>
>qemu: Use VIR_ERR_DEVICE_MISSING for various coldplug messages
>
>On 01/22/2018 11:24 PM, Chen Hanxiao wrote:
>> From: Chen Hanxia
From: Chen Hanxiao
Signed-off-by: Chen Hanxiao
---
error.go | 3 +++
error_compat.h | 6 ++
2 files changed, 9 insertions(+)
diff --git a/error.go b/error.go
index fb218f7..9de277c 100644
--- a/error.go
+++ b/error.go
@@ -353,6 +353,9 @@ const (
// error in libssh
At 2018-01-29 20:01:30, "Peter Krempa" wrote:
>On Mon, Jan 29, 2018 at 16:35:33 +0800, Chen Hanxiao wrote:
>> From: Chen Hanxiao
>>
>> introduce helper to parse /proc/net/arp and
>> store it in struct virArpTable.
>>
>> Signed-off-by: Chen H
From: Chen Hanxiao
Some of netlink functions don't have the right
@parameters description according to the declaration of function.
This patch fix them.
Signed-off-by: Chen Hanxiao
---
src/util/virnetlink.c | 35 ++-
1 file changed, 18 insertions(+
introduce VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_ARP to get ip address
of VM from the output of /proc/net/arp
Chen Hanxiao (5):
util: introduce virNetlinkGetNeighbor to get neighbor table entry
util: introduce helper to parse message from RTM_GETNEIGH query
qemu: introduce qemuARPGetInterfaces
From: Chen Hanxiao
We can use:
domifaddr f26-cloud --source arp
to get the address.
Acked-by: Michal Privoznik
Signed-off-by: Chen Hanxiao
---
tools/virsh-domain-monitor.c | 2 ++
tools/virsh.pod | 7 ---
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/tools
From: Chen Hanxiao
introduce VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_ARP to get ip address
of VM from the message of netlink RTM_GETNEIGH
Signed-off-by: Chen Hanxiao
---
v4：
remove dummy entry
use VIR_APPEND_ELEMENT
v3:
add docs in virDomainInterfaceAddresses
remove error label
show
From: Chen Hanxiao
introduce helper to parse RTM_GETNEIGH query message and
store it in struct virArpTable.
Signed-off-by: Chen Hanxiao
---
v4:
use netlink query instead of parsing /proc/net/arp
v3:
s/virGetArpTable/virArpTableGet
alloc virArpTable in virArpTableGet
return ENOSUPP on
From: Chen Hanxiao
use RTM_GETNEIGH to query arp table entry by netlink socket
Signed-off-by: Chen Hanxiao
---
v4:
use netlink to get arp table entry
src/libvirt_private.syms | 1 +
src/util/virnetlink.c| 82
src/util/virnetlink.h
From: Chen Hanxiao
Signed-off-by: Chen Hanxiao
---
v3:
more verbose description
docs/news.xml | 9 +
1 file changed, 9 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 5a2943a58..5d6a467d3 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -72,6 +72,15
&
> watchdog->action == dev->action &&
> virDomainDeviceInfoAddressIsEqual(&dev->info, &watchdog->info))) {
> virReportError(VIR_ERR_DEVICE_MISSING,
>--
Reviewed-by: Chen Hanxiao
Regards,
- Chen
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
From: Chen Hanxiao
We forgot to free alloced mem when failed to
dup ifname or macaddr.
Also use VIR_STEAL_PTR to simplify codes.
Signed-off-by: Chen Hanxiao
---
src/qemu/qemu_agent.c | 3 +--
src/qemu/qemu_driver.c | 7 +++
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a
At 2018-02-08 15:46:59, "Chen Hanxiao" wrote:
>introduce VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_ARP to get ip address
>of VM from the output of /proc/net/arp
>
>Chen Hanxiao (5):
> util: introduce virNetlinkGetNeighbor to get neighbor table entry
> util: introduce
From: Chen Hanxiao
introduce helper to parse RTM_GETNEIGH query message and
store it in struct virArpTable.
Signed-off-by: Chen Hanxiao
---
v4-rebase:
fit split Makefile.am
fit new virMacAddr fields
v4:
use netlink query instead of parsing /proc/net/arp
v3:
s/virGetArpTable
From: Chen Hanxiao
We can use:
domifaddr f26-cloud --source arp
to get the address.
Acked-by: Michal Privoznik
Signed-off-by: Chen Hanxiao
---
tools/virsh-domain-monitor.c | 2 ++
tools/virsh.pod | 7 ---
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/tools
From: Chen Hanxiao
introduce VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_ARP to get ip address
of VM from the message of netlink RTM_GETNEIGH
Signed-off-by: Chen Hanxiao
---
v4：
remove dummy entry
use VIR_APPEND_ELEMENT
v3:
add docs in virDomainInterfaceAddresses
remove error label
show
introduce VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_ARP to get ip address
of VM from the output of /proc/net/arp
Chen Hanxiao (5):
util: introduce virNetlinkGetNeighbor to get neighbor table entry
util: introduce helper to parse message from RTM_GETNEIGH query
qemu: introduce qemuARPGetInterfaces
From: Chen Hanxiao
use RTM_GETNEIGH to query arp table entry by netlink socket
Signed-off-by: Chen Hanxiao
---
v4:
use netlink to get arp table entry
src/libvirt_private.syms | 1 +
src/util/virnetlink.c| 82
src/util/virnetlink.h
From: Chen Hanxiao
Signed-off-by: Chen Hanxiao
---
v4:
rebase on 4.2
v3:
more verbose description
docs/news.xml | 9 +
1 file changed, 9 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index a51ca973e..6d729d508 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -46,6
At 2018-03-08 15:11:54, "Chen Hanxiao" wrote:
>introduce VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_ARP to get ip address
>of VM from the output of /proc/net/arp
>
>Chen Hanxiao (5):
> util: introduce virNetlinkGetNeighbor to get neighbor table entry
> util: introduce
At 2018-03-15 18:23:03, "Michal Privoznik" wrote:
>On 03/08/2018 08:11 AM, Chen Hanxiao wrote:
>> introduce VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_ARP to get ip address
>> of VM from the output of /proc/net/arp
>>
>> Chen Hanxiao (5):
>> util: intr
nged, 1 deletion(-)
>
My fault. Thanks.
Reviewed-by: Chen Hanxiao
Regards,
- Chen
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
BLE_H__
>
> # include "internal.h"
>-# include
>
> typedef struct _virArpTableEntry virArpTableEntry;
> typedef virArpTableEntry *virArpTableEntryPtr;
>--
Reviewed-by: Chen Hanxiao
Regards,
- Chen
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
From: Chen Hanxiao
commit b4b5c82ce forgot to add this.
Signed-off-by: Chen Hanxiao
---
tools/virsh-domain-monitor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c
index 68da11ed5..0f768d394 100644
--- a/tools
Address John's comment on v4
Chen Hanxiao (2):
virarptable: fix some leaks and format issue
qemu: fix some leaks
src/qemu/qemu_driver.c | 3 +++
src/util/virarptable.c | 13 +++--
2 files changed, 14 insertions(+), 2 deletions(-)
--
2.14.3
--
libvir-list mailing list
libvir
At 2018-03-16 18:53:58, "John Ferlan" wrote:
>
>
>On 03/08/2018 02:11 AM, Chen Hanxiao wrote:
>> From: Chen Hanxiao
>>
>> introduce helper to parse RTM_GETNEIGH query message and
>> store it in struct virArpTable.
>>
>> Signed-of
From: Chen Hanxiao
fix some leaks and format issue
Also support virArpTableFree to get NULL.
Signed-off-by: Chen Hanxiao
---
src/util/virarptable.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/src/util/virarptable.c b/src/util/virarptable.c
index
401 - 500 of 536 matches
Mail list logo
