Re: libvirt-devaddr: a new library for device address assignment

2020-03-14 Thread Dan Kenigsberg
On Fri, Mar 13, 2020 at 12:47 PM Daniel P. Berrangé wrote: > > On Fri, Mar 13, 2020 at 11:23:44AM +0200, Dan Kenigsberg wrote: > > On Wed, 4 Mar 2020, 14:51 Daniel P. Berrangé, wrote: > > > > > > We've been doing alot of refactoring of code in recent t

Re: libvirt-devaddr: a new library for device address assignment

2020-03-13 Thread Dan Kenigsberg
On Wed, 4 Mar 2020, 14:51 Daniel P. Berrangé, wrote: > > We've been doing alot of refactoring of code in recent times, and also > have plans for significant infrastructure changes. We still need to > spend time delivering interesting features to users / applications. > This mail is to introduce an

Re: [libvirt PATCH v2 0/6] element (was: virtio failover / vfio auto-plug-on-migrate)

2020-01-25 Thread Dan Kenigsberg
On Fri, 24 Jan 2020, 17:54 Laine Stump, wrote: > V1: https://www.redhat.com/archives/libvir-list/2020-January/msg00813.html > > This all used different names in V1 - in that incarnation the > configuration was done using "failover" and "backupAlias" attributes > added to the subelement of . But

Re: [libvirt PATCH 12/12] conf/qemu: new attribute "useBackupMAC"

2020-01-22 Thread Dan Kenigsberg
On Tue, Jan 21, 2020 at 4:47 PM Daniel P. Berrangé wrote: > > On Tue, Jan 21, 2020 at 12:46:38PM +0200, Dan Kenigsberg wrote: > > On Mon, Jan 20, 2020 at 8:33 PM Daniel P. Berrangé > > wrote: > > > > > > On Sun, Jan 19, 2020 at 10:24:19PM -0500, Laine Stu

Re: [libvirt PATCH 12/12] conf/qemu: new attribute "useBackupMAC"

2020-01-21 Thread Dan Kenigsberg
purpose of this feature is to remove the need for end-user intervention. The bond device no longer need to be created in the guest, it can be configured by management on the host side. Defining bonds in Linux is an established procedure. You select pre-existing interfaces, each with its diff

[libvirt] [libvirt-tck PATCH] Add cases for nvram

2019-12-13 Thread Dan Zheng
This is to add the tests for below flags: - Sys::Virt::Domain::UNDEFINE_KEEP_NVRAM - Sys::Virt::Domain::UNDEFINE_NVRAM Signed-off-by: Dan Zheng --- scripts/domain/401-ovmf-nvram.t | 143 1 file changed, 143 insertions(+) create mode 100644 scripts/domain/401

[libvirt] [libvirt-tck PATCH] Add cases for nvram

2019-12-12 Thread Dan Zheng
This is to add the tests for below flags: - Sys::Virt::Domain::UNDEFINE_KEEP_NVRAM - Sys::Virt::Domain::UNDEFINE_NVRAM Signed-off-by: Dan Zheng --- scripts/domain/401-ovmf-nvram.t | 143 1 file changed, 143 insertions(+) create mode 100644 scripts/domain/401

Re: [libvirt] Error when creating VM with persistent memory

2019-09-04 Thread Dan Williams
On Wed, Sep 4, 2019 at 12:56 AM Seema Pandit wrote: > > Actually there is still some issue around this. When trying to start another > VM, so using even more pmem, there is a different issue now. Error copied > below. > > []# virsh start manual_clone > > error: Failed to start domain manual_clon

Re: [libvirt] Error when creating VM with persistent memory

2019-09-04 Thread Dan Williams
On Mon, Sep 2, 2019 at 10:10 AM Seema Pandit wrote: > > After adding the memoryBacking tag in xml as below (in addition, to other xml > changes to add nvdimm), virsh could allocate AD memory larger than the system > RAM and VMs could start successfully. > > > > > > > > > > > > This

Re: [libvirt] Contributing to Libvirt

2019-03-11 Thread Dan Fries
Hi Libvirt, It's often said that persistence and patience are the keys to success in life. I think persons managing content and marketing at Libvirt would be remiss for not trying out my work. Hoping to hear from you soon. Best, Dan On Monday, March 4, 2019 at 7:36 AM, Dan Fries

[libvirt] [libvirt-perl] Remove-the-unused-parameter-in-document

2019-02-26 Thread Dan Zheng
>From d3b0044699732dba54ff0360e626ea1738bfe872 Mon Sep 17 00:00:00 2001 From: Dan Zheng Date: Tue, 26 Feb 2019 17:35:49 +0800 Subject: [PATCH] Remove the unused parameter in document Signed-off-by: Dan Zheng --- lib/Sys/Virt/Domain.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

[libvirt] [PATCH] doc: better explanation for virStoragePoolSetAutostart

2018-08-21 Thread Dan Kenigsberg
The former documentation was an unhelpful tautology. The suggested doc mimicks^Wcopies the one of virDomainSetAutostart. Signed-off-by: Dan Kenigsberg --- src/libvirt-storage.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/libvirt-storage.c b/src/libvirt-storage.c

[libvirt] [libvirt-tck] [PATCH] Add new option for virt-builder

2018-01-15 Thread Dan Zheng
>From 0cbe381e782a18cfa9730e8791a80ff01497d8fc Mon Sep 17 00:00:00 2001 From: Dan Zheng Date: Tue, 16 Jan 2018 13:39:50 +0800 Subject: [PATCH] Add new option for virt-builder Using --selinux-relabel is required by Fedora and RHEL guests to ensure SELinux labels correctly in the disk im

[libvirt] [PATCH] check/add for mdev_types capability

2018-01-15 Thread Dan Zheng
>From be62ea5394d52fa168079edc3aa7e558363a3026 Mon Sep 17 00:00:00 2001 From: Dan Zheng Date: Tue, 16 Jan 2018 12:21:21 +0800 Subject: [PATCH] nodedev: check/add for mdev_types capability This is similar to commit f44ec9c1. Commit id '500cbc06' introduced a new nested capability el

Re: [libvirt] [PATCH v4] virsh: add [--domain DOMAIN] option to domxml-to-native DOMAIN COMMAND

2017-06-28 Thread Dan
> the command line. If not used positionally, then the --xml would be > required, e.g. if someone used "virsh domxml-to-native --xml @file > --format @format". > > Having the [--domain] indicates that in order to use it, it must have > that --domain argument because "virs

Re: [libvirt] [PATCH v4] virsh: add [--domain DOMAIN] option to domxml-to-native DOMAIN COMMAND

2017-06-27 Thread Dan
On Tue, Jun 27, 2017 at 10:26:32AM +0200, Martin Kletzander wrote: > On Mon, Jun 26, 2017 at 09:05:23PM -0400, Dan wrote: > > On Mon, Jun 26, 2017 at 09:30:11PM -0300, Julio Faracco wrote: > > > Hi Dan, > > > > > > Have you tested the --xml argument as VSH_

Re: [libvirt] [PATCH v4] virsh: add [--domain DOMAIN] option to domxml-to-native DOMAIN COMMAND

2017-06-26 Thread Dan
On Mon, Jun 26, 2017 at 09:30:11PM -0300, Julio Faracco wrote: > Hi Dan, > > Have you tested the --xml argument as VSH_OT_ARGV? > {.name = "domain", > - .type = VSH_OT_DATA, > + .type = VSH_OT_STRING, > .flags = VSH_OFLAG_REQ_OPT, > .

Re: [libvirt] [PATCH v4] virsh: add [--domain DOMAIN] option to domxml-to-native DOMAIN COMMAND

2017-06-26 Thread Dan
- > > John > I think we may need to modify vshCmddefHelp() in vsh.c to really make it look like as expected. For example, in some case, the SYNOPSIS part also displayed incorrectly. SYNOPSIS domxml-to-native Instead, the following is similar to what we want: SYNOPSIS- domxml-to-

Re: [libvirt] [PATCH v4] virsh: add [--domain DOMAIN] option to domxml-to-native DOMAIN COMMAND

2017-06-26 Thread Dan
n name, id or uuid , while the requirement is to not make --xml mandatory; i.e.: OPTIONS [--format] target config data type format [--xml] xml data file to export from

Re: [libvirt] [PATCH v4] virsh: add [--domain DOMAIN] option to domxml-to-native DOMAIN COMMAND

2017-06-26 Thread Dan
> > John > Hey John, I attempted to fix it this morning, but I cannot seem to be able to get it fixed the way according to current man page specificiation. Either --help is not working (as you found out), or the command option is not working when I tried to fix it by different ways.

Re: [libvirt] [PATCH v2] virsh: add [--domain DOMAIN] option to domxml-to-native DOMAIN COMMAND

2017-06-03 Thread Dan
On Fri, Jun 02, 2017 at 11:33:50AM +0200, Martin Kletzander wrote: > On Fri, Jun 02, 2017 at 05:18:52AM -0400, Dan wrote: > > On Tue, May 30, 2017 at 08:45:37AM +0200, Peter Krempa wrote: > > > On Mon, May 29, 2017 at 14:08:53 -0400, Daniel Liu wrote: > > > > Th

Re: [libvirt] [PATCH v2] virsh: add [--domain DOMAIN] option to domxml-to-native DOMAIN COMMAND

2017-06-02 Thread Dan
uot;, _("convert from domain XML to native failed")); some test cases when this error happened: $ virsh -c qemu:///system domxml-to-native qemu-argv dl_dumpxml170529.xml error: convert from domain XML to native command failed error: (domain_definition):111: expected '&

Re: [libvirt] [PATCH v2] virsh: add [--domain DOMAIN] option to domxml-to-native DOMAIN COMMAND

2017-05-31 Thread Dan
n, format, xmlData, > > flags); > > -if (configData != NULL) { > > -vshPrint(ctl, "%s", configData); > > -VIR_FREE(configData); > > +if (!(configData = virConnectDomainXMLToNative(priv->conn, format, > > xmlData, flags))) { > > +vshError(ctl, "%s", > > + _("convert from domain XML to native command failed")); > > For 'xen' the output is not really a command, so this message also is > not very good. > I have never used/tested xen. And actually I do not know where to start setting it up except thinking about googling. Could you elaborate a bit more? Thanks, Dan > > +goto cleanup; > > } else { > > -ret = false; > > +vshPrint(ctl, "%s", configData); > > +ret = true; -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] virsh: add --domain option for domain-to-native

2017-05-31 Thread Dan
On Mon, May 29, 2017 at 05:50:46PM -0300, Julio Faracco wrote: > It would be nice to include the changes into documentation, wouldn't it? > tools/virsh.pod has an entry for example. > Many thanks for pointing it out. I modified man page by editing virsh.pod in v3 patch. Dan >

Re: [libvirt] [PATCH v2] virsh: add [--domain DOMAIN] option to domxml-to-native DOMAIN COMMAND

2017-05-31 Thread Dan
; > xmlData can be NULL after this in case of an error. > > > +} else if (xml) { > > +if (virFileReadAll(xml, VSH_MAX_XML_FILE, &xmlData) < 0) > > +goto cleanup; > > +} > > + > > +if (!xmlData) { > > So this could just be else {} of the last condition and if xmlData is > NULL after calling virDomainGetXMLDesc(), there should be different > error message. > > Other things were pointed out already, I guess. All right thanks a lot. Dan -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [GSoC] Project of libvirt/qemu fuzzing

2017-05-30 Thread Dan
On Tue, May 30, 2017 at 02:08:54PM +0100, Stefan Hajnoczi wrote: > On Tue, May 30, 2017 at 12:03 PM, Dan wrote: > > The project of qemu command line fuzzing has been accepted as a GSoC > > project [1] [2]. As a student participating Google Summer of Code > > activity, I am

[libvirt] [GSoC] Project of libvirt/qemu fuzzing

2017-05-30 Thread Dan
Dear all, The project of qemu command line fuzzing has been accepted as a GSoC project [1] [2]. As a student participating Google Summer of Code activity, I am extremely exitited to get started today on May 30th, 2017. During the past months, I have received tremendous guidance from my mentors as

Re: [libvirt] [PATCH] virsh: add --domain option for domain-to-native

2017-05-29 Thread Dan
On Mon, May 29, 2017 at 08:53:18PM +0200, Martin Kletzander wrote: > On Mon, May 29, 2017 at 02:25:03PM -0400, Dan wrote: > > On Tue, May 16, 2017 at 11:41:55AM +0200, Martin Kletzander wrote: > > > On Mon, May 15, 2017 at 04:29:48AM -0400, Daniel Liu wrote: > &

Re: [libvirt] [PATCH] virsh: add --domain option for domain-to-native

2017-05-29 Thread Dan
Data); > > +ret = true; > > +goto cleanup; > > } else { > > -ret = false; > > +vshError(ctl, _("convert from domain XML to native command > > failed")); > > +goto cleanup; > > } > > Since you are cha

Re: [libvirt] [virt-tools-list] Problem with firewalls on Arch Linux

2017-05-25 Thread Dan
On Thu, May 25, 2017 at 09:42:42AM -0400, Cole Robinson wrote: > On 05/25/2017 06:08 AM, Derek Richline wrote: > > Hi all: > > > > I noticed that Virt Manager will not start the network "default" unless > > it detects a running firewalld. Arch Linux only ships with iptables by > > default. Can Vir

Re: [libvirt] [PATCH] RFE: virsh: add domxml-to-native [--domain DOMAIN] option

2017-05-15 Thread Dan
On Mon, Apr 24, 2017 at 09:17:12AM +0200, Peter Krempa wrote: > On Sun, Apr 23, 2017 at 20:54:47 -0400, Dan wrote: > > Please use your full name for patch submissions. > I just did a new send-email patch submission to the list. Hopefully it corrected my previous mistakes. > &

[libvirt] [PATCH] RFE: virsh: add domxml-to-native [--domain DOMAIN] option

2017-04-23 Thread Dan
. [1]. https://bugzilla.redhat.com/show_bug.cgi?id=835476 Dan --- tools/virsh-domain.c | 68 ++-- 1 file changed, 55 insertions(+), 13 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index db8accfe4..9ac855b19 100644

[libvirt] [libvirt-perl][PATCH] Fix typo in NodeDevice.pm

2017-04-19 Thread Dan Zheng
In commit 24a7f8b41ed09e885120af5336de69d3d4c91980, node device events were written with storage pool prefix by mistake. Signed-off-by: Dan Zheng --- lib/Sys/Virt/NodeDevice.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/Sys/Virt/NodeDevice.pm b/lib/Sys/Virt

[libvirt] seek alternative way of compiling historical version

2017-04-02 Thread Dan
at all? P.S., I was just reading v0.0.1 libvirt [1]. It is so nice to see there is, well, was nothing more then 2000 LOC for C source code. [1] ftp://libvirt.org/libvirt/old/libvir-0.0.1.tar.gz Dan -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [GSOC] project libvirt fuzzing

2017-03-31 Thread Dan
are related works such as oss-fuzz. However, the most obvious difference is that here it can be potentially closely integrated into existing libvirt community workflow, or any other open source community of the like who would like to have their own fuzzing CI with flexible and version-ed config

[libvirt] How about fuzz testing on oss-fuzz?

2017-03-31 Thread Dan
Hi all, I have seen libxml2 has already been added as a project in oss-fuzz [1]. Any idea about libvirt? While we could do our own fuzzing of some form, do we want to also try it out using google's free resource? Dan [1] https://github.com/google/oss-fuzz -- libvir-list mailing list l

Re: [libvirt] encountered failed test cases with latest checkout of libvirt

2017-03-29 Thread Dan
> run the test when I make changes to the code. On the other hand, I would > also like to learn the right way to do the testing or whatever it takes to > make > things right. > > I am running linux using vmware Workstation Pro 12 on Windows 10. > Linux version 4.4.55-1-MANJARO (b

Re: [libvirt] [PATCH] ruby-libvirt: Don't crash in leases_wrap() by passing NULLs to rb_str_new2()

2016-03-07 Thread Dan Williams
On Thu, 2016-01-14 at 21:44 -0500, Chris Lalancette wrote: > On Thu, Jan 14, 2016 at 9:38 PM, Chris Lalancette com> > wrote: > > > > > Hi! > > > > On Thu, Jan 14, 2016 at 2:56 PM, Dan Williams > > wrote: > > > > > &

Re: [libvirt] [PATCH] ruby-libvirt: Don't crash in leases_wrap() by passing NULLs to rb_str_new2()

2016-01-14 Thread Dan Williams
On Thu, 2016-01-14 at 13:19 -0500, Laine Stump wrote: > On 01/14/2016 11:01 AM, Dan Williams wrote: > > On Thu, 2016-01-07 at 11:12 -0600, Dan Williams wrote: > > > Not all lease values are mandatory, and when they aren't supplied > > > by the libvirt driver t

Re: [libvirt] [PATCH] ruby-libvirt: Don't crash in leases_wrap() by passing NULLs to rb_str_new2()

2016-01-14 Thread Dan Williams
On Thu, 2016-01-07 at 11:12 -0600, Dan Williams wrote: > Not all lease values are mandatory, and when they aren't supplied > by the libvirt driver they get set to NULL. That makes > rb_str_new2() bail out. Ping? Does this patch look OK or is there anything else I need to do wi

[libvirt] [PATCH] ruby-libvirt: Don't crash in leases_wrap() by passing NULLs to rb_str_new2()

2016-01-07 Thread Dan Williams
Not all lease values are mandatory, and when they aren't supplied by the libvirt driver they get set to NULL. That makes rb_str_new2() bail out. Signed-off-by: Dan Williams --- For example using the qemu driver we don't get 'iaid', and that makes ruby unhappy: [{"ifac

Re: [libvirt] Libvirt bite sized tasks

2015-06-15 Thread Dan Mossor
On 06/15/2015 10:11 AM, Michal Privoznik wrote: On 15.06.2015 15:37, Dan Mossor wrote: On 06/15/2015 02:59 AM, Michal Privoznik wrote: Dear lists, I've just started new wiki page which aim is to summarize small and trivial tasks, that starting contributors can take, investigate and impl

Re: [libvirt] Libvirt bite sized tasks

2015-06-15 Thread Dan Mossor
? Is there work in progress to tie it to FAS or OpenID? [0]https://www.redhat.com/archives/libvir-list/2015-June/msg00584.html -- Dan Mossor, RHCSA Systems Engineer Fedora Server WG | Fedora KDE WG | Fedora QA Team Fedora Infrastructure Apprentice FAS: dmossor IRC: danofsatx San Antonio, Texas, USA

Re: [libvirt] Accessing libvirtd remotely as non-root user

2015-06-12 Thread Dan Mossor
On 06/12/2015 12:58 PM, Laine Stump wrote: On 06/12/2015 12:14 PM, Dan Mossor wrote: On 06/12/2015 03:48 AM, Daniel P. Berrange wrote: On Thu, Jun 11, 2015 at 05:26:20PM -0500, Dan Mossor wrote: I manage libvirtd on a few remote machines, and my security policies require me to disable root

Re: [libvirt] Accessing libvirtd remotely as non-root user

2015-06-12 Thread Dan Mossor
On 06/12/2015 03:48 AM, Daniel P. Berrange wrote: On Thu, Jun 11, 2015 at 05:26:20PM -0500, Dan Mossor wrote: I manage libvirtd on a few remote machines, and my security policies require me to disable root login via SSH. Up to this point, I've been using root due to the systems being in st

Re: [libvirt] Accessing libvirtd remotely as non-root user

2015-06-12 Thread Dan Mossor
On 06/12/2015 03:48 AM, Daniel P. Berrange wrote: On Thu, Jun 11, 2015 at 05:26:20PM -0500, Dan Mossor wrote: I manage libvirtd on a few remote machines, and my security policies require me to disable root login via SSH. Up to this point, I've been using root due to the systems being in st

[libvirt] Accessing libvirtd remotely as non-root user

2015-06-11 Thread Dan Mossor
method of connecting virt-manager or virsh to a remote system with a non-root account? I keep getting "authentication failed: no agent is available to authenticate" with a user that is in the kvm and qemu groups on the systems I've tried using the ssh transport. Thanks in advance

Re: [libvirt] Exact meaning of "nativeMode" attribute in vlan tags

2015-02-22 Thread Dan Mossor
nativeMode='tagged' means that packets in the native vlan will be tagged when sent or received on that port. I hope this helps, I can try to reword it if I made it even more confusing. -Dan -- Dan Mossor Systems Engineer at Large Fedora KDE WG | Fedora QA Team | Fedora Server SIG

[libvirt] [PATCH] doc: fix documentation of virDomainSet(Get)Metadata

2014-05-28 Thread Dan Kenigsberg
The documentation of the functions should match the argument name in the actual function signature. Signed-off-by: Dan Kenigsberg --- src/libvirt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 72a9f6d..f01b6dd 100644 --- a/src

Re: [libvirt] [PATCH] network: disallow / for bridged/macvtap networks

2014-01-27 Thread Dan Kenigsberg
ied. I considered it too disruptive to suddenly break > working configs on the next reboot after a libvirt upgrade. BTW, is there other means to re-use libvirt's handling of tc in order to apply QoS on the physical-facing leg of the forwarded bridge (in case that we end up going that way). Regards, Dan. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Users] libvirt migration port configuration and virPortAllocator

2014-01-08 Thread Dan Kenigsberg
rt mailing list (CCed). Unfortunately, that version is not even on virt-preview http://fedorapeople.org/groups/virt/virt-preview/fedora-19 (but it is on http://fedorapeople.org/groups/virt/virt-preview/fedora-20 !) Dan. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] docs: add a permalink to html headers

2013-12-08 Thread Dan Kenigsberg
Note to reviewers: this patch is too naive and has devastating effect of headers that lack a named anchor element. Still, I'd love to hear your opinion about the idea. On Sun, Dec 08, 2013 at 02:05:46PM +0000, Dan Kenigsberg wrote: > Quite often, I need to cite URLs like > http://

[libvirt] [PATCH] docs: add a permalink to html headers

2013-12-08 Thread Dan Kenigsberg
Quite often, I need to cite URLs like http://libvirt.org/formatnetwork.html#elementQoS but it is annoying to copy them from the table of contents or the html source. This patch borrows from the Python documentation in order to make it easier to cite headers on libvirt's oneline documentation.

Re: [libvirt] [Users] Time keeping in Windows VM

2013-11-19 Thread Dan Kenigsberg
On Tue, Nov 19, 2013 at 04:36:24PM +, Martin Goldstone wrote: > Hi all, > > We're currently experiencing an issue in our production oVirt 3.2.2 > environment (on CentOS 6.4) with time keeping on our Windows guests. It > seems to have appeared around the time of the recent DST change. It's take

Re: [libvirt] [vdsm] Host local_host running without virtualization hardware acceleration

2013-11-05 Thread Dan Kenigsberg
access KVM kernel module: No such file or directory > failed to initialize KVM: No such file or directory > > looking at strace: > open("/dev/kvm", O_RDWR|O_CLOEXEC) = -1 ENOENT (No such file or > directory) > > Any clue on what may be happened? What's y

Re: [libvirt] the case for volatile nwfilters

2013-10-31 Thread Dan Kenigsberg
On Thu, Oct 31, 2013 at 09:20:16AM +, Daniel P. Berrange wrote: > > > > I believe you *can* update a filter while it is in use. NWFilter will > build the new ruleset, then switch over to it atomically. Thanks, I was not aware that one code re-define an existing nwfilter.

Re: [libvirt] the case for volatile nwfilters

2013-10-30 Thread Dan Kenigsberg
On Wed, Oct 30, 2013 at 10:13:28AM +, Daniel P. Berrange wrote: > On Wed, Oct 30, 2013 at 11:57:16AM +0200, Laine Stump wrote: > > On 10/29/2013 06:33 PM, Dan Kenigsberg wrote: > > > I'd like oVirt to make a more extensive usage of libvirt's nwfilters in >

[libvirt] the case for volatile nwfilters

2013-10-29 Thread Dan Kenigsberg
e could instead have just-in-time filter definition such as avoiding nwfilter persistence. Would something like this be beneficial to other libvirt users? Would it be easy to implement within libvirt? Regards, Dan. -- libvir-list mail

Re: [libvirt] [Users] vdsmd seg fault

2013-10-18 Thread Dan Kenigsberg
On Fri, Oct 18, 2013 at 11:32:51AM -0700, Jason Brooks wrote: > > On Fri, 2013-10-18 at 14:16 +0300, Dan Kenigsberg wrote: > > On Thu, Oct 17, 2013 at 05:15:48PM -0400, Jason Brooks wrote: > > > > > > > > > - Original Message - > > > &g

Re: [libvirt] [Users] Migration issues with ovirt 3.3

2013-10-11 Thread Dan Kenigsberg
On Thu, Oct 10, 2013 at 08:40:29AM +0200, Jiri Denemark wrote: > On Wed, Oct 09, 2013 at 16:18:25 +0100, Dan Kenigsberg wrote: > > On Wed, Oct 09, 2013 at 04:52:20PM +0200, Gianluca Cecchi wrote: > > > On Wed, Oct 9, 2013 at 3:43 PM, Dan Kenigsberg wrote: > > > >

Re: [libvirt] [Users] Migration issues with ovirt 3.3

2013-10-09 Thread Dan Kenigsberg
On Wed, Oct 09, 2013 at 04:52:20PM +0200, Gianluca Cecchi wrote: > On Wed, Oct 9, 2013 at 3:43 PM, Dan Kenigsberg wrote: > > On Wed, Oct 09, 2013 at 02:42:22PM +0200, Gianluca Cecchi wrote: > >> On Tue, Oct 8, 2013 at 10:40 AM, Dan Kenigsberg wrote: > >> > >> &

Re: [libvirt] [Users] Migration issues with ovirt 3.3

2013-10-09 Thread Dan Kenigsberg
On Wed, Oct 09, 2013 at 02:42:22PM +0200, Gianluca Cecchi wrote: > On Tue, Oct 8, 2013 at 10:40 AM, Dan Kenigsberg wrote: > > > > >> > >> But migration still fails > >> > > > > It seems like an unrelated failure. I do not know what's block

[libvirt] Second pass at patch to get different SELinux Labels for virt-sandbox

2013-10-04 Thread Dan Walsh
selinux-policy-3.12.1-87.fc21 selinux-policy-3.12.1-87.fc20 Now have lxc_contexts files that look like > cat /etc/selinux/targeted/contexts/lxc_contexts lxc=system_u:system_r:svirt_lxc_net_t:s0 qemu=system_u:system_r:svirt_qemu_net_t:s0 kvm=system_u:system_r:svirt_qemu_net_t:s0 process=system_u:s

[libvirt] [sandbox PATCH] virt-sandbox patch to launch containers with proper label

2013-10-04 Thread Dan Walsh
virt-sandbox should be launching containers based off the lxc_context file from selinux-policy. I changed the hard coded paths to match the latest fedora assigned labels. Fedora 20 SELinux Policy and beyond will have proper SELinux labels in its lxc_contexts file. --- bin/virt-sandbox-service

[libvirt] Patch to launch virt-sandbox-containers with correct label.

2013-09-25 Thread Dan Walsh
[sandbox PATCH] virt-sandbox patch to launch containers with proper -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [sandbox PATCH] virt-sandbox patch to launch containers with proper label

2013-09-25 Thread Dan Walsh
virt-sandbox should be launching containers based off the lxc_context file from selinux-policy. I changed the hard coded paths to match the latest fedora assigned labels. Fedora 20 SELinux Policy and beyond will have proper SELinux labels in its lxc_contexts file. --- bin/virt-sandbox-service

Re: [libvirt] [Users] Live Migration failed oVirt 3.3 Nightly

2013-09-15 Thread Dan Kenigsberg
On Sun, Sep 15, 2013 at 09:57:47PM +1000, Andrew Lau wrote: > On Sun, Sep 15, 2013 at 9:34 PM, Dan Kenigsberg wrote: > > > On Sun, Sep 15, 2013 at 08:44:18PM +1000, Andrew Lau wrote: > > > On Sun, Sep 15, 2013 at 8:00 PM, Dan Kenigsberg > > wrote: > > > &

Re: [libvirt] [Users] Starting VM Error

2013-09-15 Thread Dan Kenigsberg
mu : qemu kvm is just as mine) I've added libvir-list so the fine folks there could check why qemu cannot read/write files group-owned by kvm. Dan. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Users] VNC/Spice console connection failure

2013-09-10 Thread Dan Kenigsberg
On Tue, Sep 10, 2013 at 05:31:23PM +, SULLIVAN, Chris (WGK) wrote: > Hi Itamar, > > BZ created: https://bugzilla.redhat.com/show_bug.cgi?id=1006490 > > Thanks, Thanks, but we cannot simply require libvirt > 1.1.0, as it does not ship with F19. We need get a fix backported to F19, so that we

[libvirt] [sandbox PATCH 4/5] Fix SEE ALSO lines to be multi-line

2013-08-15 Thread Dan Walsh
--- bin/virt-sandbox-service.pod | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/bin/virt-sandbox-service.pod b/bin/virt-sandbox-service.pod index 7752145..b879a46 100644 --- a/bin/virt-sandbox-service.pod +++ b/bin/virt-sandbox-service.pod @@ -54,7 +54,11 @@ supported cur

[libvirt] [sandbox PATCH 3/5] -S is not supported by virt-sandbox

2013-08-15 Thread Dan Walsh
-S option has been removed from virt-sandbox, should be removed from man page. --- bin/virt-sandbox.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/bin/virt-sandbox.c b/bin/virt-sandbox.c index 14700d7..c21a8a6 100644 --- a/bin/virt-sandbox.c +++ b/bin/virt-sandbox.c @@ -269,8 +269,6 @@ vir

[libvirt] Refactored previous patch into 5 patches

2013-08-15 Thread Dan Walsh
[sandbox PATCH 1/5] Add virt-sandbox -s inherit, to execute the [sandbox PATCH 2/5] Unit files only exist in Systemd Containers. [sandbox PATCH 3/5] -S is not supported by virt-sandbox [sandbox PATCH 4/5] Fix SEE ALSO lines to be multi-line [sandbox PATCH 5/5] virt-sandbox needs to mention LIBVIRT_

[libvirt] [sandbox PATCH 5/5] virt-sandbox needs to mention LIBVIRT_DEFAULT_URI environment variable.

2013-08-15 Thread Dan Walsh
Since lots of people want to try out LXC with virt-sandbox, executing -c lxc:/// is a pain, but users might not know about the varible or the config file. --- bin/virt-sandbox.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/bin/virt-sandbox.c b/bin/virt-sandbox.c index c2

[libvirt] [sandbox PATCH 1/5] Add virt-sandbox -s inherit, to execute the sandbox from the parent.

2013-08-15 Thread Dan Walsh
This will allow us to run sandbox as the calling process, If I am running a shell as staff_u:unconfined_r:unconfined_t:s0, and I execute virt-sandbox -c lxc/// -- /bin/sh /bin/sh will run as staff_u:unconfined_r:unconfined_t:s0 --- bin/virt-sandbox.c | 4 configure.ac

[libvirt] [sandbox PATCH 2/5] Unit files only exist in Systemd Containers.

2013-08-15 Thread Dan Walsh
Do not attempt to fix the unit file of Generic Containers. --- bin/virt-sandbox-service | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/bin/virt-sandbox-service b/bin/virt-sandbox-service index 03873c9..3e83c94 100755 --- a/bin/virt-sandbo

[libvirt] [sandbox PATCH 2/2] Unit files only exist in Systemd Containers.

2013-08-13 Thread Dan Walsh
Do not attempt to fix the unit file of Generic Containers. --- bin/virt-sandbox-service | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/bin/virt-sandbox-service b/bin/virt-sandbox-service index 03873c9..3e83c94 100755 --- a/bin/virt-sandbo

[libvirt] Updated patch for virt-sandbox -s inherit

2013-08-13 Thread Dan Walsh
> -s static,label=unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023 Well running "virt-sandbox -s inherit" would run as unconfined_t for most users. I the future we need to add a check to libvirt to ask SELinux if it is ok for a user to transiton to the label, rather then just to do it. I

[libvirt] [sandbox PATCH 1/2] Add virt-sandbox -s inherit, to execute the sandbox from the parent.

2013-08-13 Thread Dan Walsh
This will allow us to run sandbox as the calling process, If I am running a shell as staff_u:unconfined_r:unconfined_t:s0, and I execute virt-sandbox -c lxc/// -- /bin/sh /bin/sh will run as staff_u:unconfined_r:unconfined_t:s0 --- bin/virt-sandbox-service.pod | 6 +- bin/virt-s

[libvirt] Add virt-sandbox -s inherit, to execute the sandbox with parents label

2013-08-13 Thread Dan Walsh
This will allow us to run sandbox as the calling process, If I am running a shell as staff_u:unconfined_r:unconfined_t:s0, and I execute virt-sandbox -c lxc/// -- /bin/sh The second patch fixes a problem when users try to upgrade Generic Containers. [sandbox PATCH 1/2] Add virt-sandbox -s inheri

Re: [libvirt] [PATCH] Configuring systemd to restart libvirt on failure

2013-07-31 Thread Dan Kenigsberg
On Tue, Jul 30, 2013 at 03:32:59PM +0300, Mooli Tayer wrote: > This will create a respawn behaviour in case libvirt > process exits due to nonzero exit code, is terminated > by a signal, an operation times out or the configured > watchdog timeout is triggered. > see http://www.freedesktop.org/softw

Re: [libvirt] [PATCH] Configuring systemd to restart libvirt on abort

2013-07-30 Thread Dan Kenigsberg
ted regardless whether > > it exited cleanly or not, got terminated > >abnormally by a signal or hit a timeout. > > [/quote] > > > > I tend towards saying 'on-failure' here. > > I agree. we defiantly want restart in the 'on-failure' > cases. Would 'on-failure' mean that libvirtd is to be restarted if it has exited with an error due to wrong configuration? This may spell nasty thrashing of systemd. Dan. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] qemu64 - not valid cpu with 'Intel Westmere Family'

2013-07-03 Thread Dan Kenigsberg
On Wed, Jul 03, 2013 at 04:51:30PM +0200, Sandro Bonazzola wrote: > Il 03/07/2013 16:40, Sandro Bonazzola ha scritto: > > Hi, > > I'm trying to run latest vdsm master on RHEL-6.4. > > I've built the rpms against livirt-1.10 > > > > I'm creating a VM using cpu family = 'Intel Westmere Family' >

Re: [libvirt] configuring a disconnected

2013-07-02 Thread Dan Kenigsberg
On Tue, Jul 02, 2013 at 05:32:20PM -0400, Laine Stump wrote: > On 07/02/2013 04:07 PM, Dan Kenigsberg wrote: > > On Mon, Jun 24, 2013 at 11:22:16AM +0100, Daniel P. Berrange wrote: > >> On Sun, Jun 23, 2013 at 03:34:06PM +0300, Dan Kenigsberg wrote: > >>> On Fri, Ju

Re: [libvirt] configuring a disconnected

2013-07-02 Thread Dan Kenigsberg
On Mon, Jun 24, 2013 at 11:22:16AM +0100, Daniel P. Berrange wrote: > On Sun, Jun 23, 2013 at 03:34:06PM +0300, Dan Kenigsberg wrote: > > On Fri, Jun 21, 2013 at 04:31:53AM -0500, Daniel P. Berrange wrote: > > > On Thu, Jun 20, 2013 at 02:42:31PM +0300, Dan Kenigsberg wrot

Re: [libvirt] configuring a disconnected

2013-06-23 Thread Dan Kenigsberg
On Fri, Jun 21, 2013 at 04:31:53AM -0500, Daniel P. Berrange wrote: > On Thu, Jun 20, 2013 at 02:42:31PM +0300, Dan Kenigsberg wrote: > > Hi List, > > > > Like most of us, I've bought my actual computer with an Ethernet > > interface card, that I can connect to

[libvirt] configuring a disconnected

2013-06-20 Thread Dan Kenigsberg
means "keep this interface dangling out there"? Regards, Dan. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [sandbox PATCH 13/15] Use args.uri rather then hard coding lxc:///

2013-04-03 Thread Dan Walsh
Signed-off-by: Dan Walsh --- bin/virt-sandbox-service | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/virt-sandbox-service b/bin/virt-sandbox-service index 8571374..8c9ea76 100755 --- a/bin/virt-sandbox-service +++ b/bin/virt-sandbox-service @@ -928,7 +928,7 @@ def

[libvirt] [sandbox PATCH 05/15] Change virt-sandbox-service-create.pod to use correct command --copy

2013-04-03 Thread Dan Walsh
Current the documentation says that you use --clone while the code uses --copy when you are createing a sandbox service container. Signed-off-by: Dan Walsh --- bin/virt-sandbox-service-create.pod | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/bin/virt-sandbox-service

[libvirt] [sandbox PATCH 06/15] Internationalize all output strings in virt-sandbox-service

2013-04-03 Thread Dan Walsh
Wrap all output strings with _() to make sure we get proper translations. Signed-off-by: Dan Walsh --- bin/virt-sandbox-service | 48 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/bin/virt-sandbox-service b/bin/virt-sandbox

[libvirt] [sandbox PATCH 12/15] Add support for InteractiveContainer

2013-04-03 Thread Dan Walsh
First use case will be OpenShift Differentiate on create based on whether one or more unit files specified (ServiceContainer), or a command is specified (Interactive Container). Signed-off-by: Dan Walsh --- bin/virt-sandbox-service| 165 bin

[libvirt] [sandbox PATCH 10/15] Change variable config to config_path to avoid confusion.

2013-04-03 Thread Dan Walsh
save_config uses an internal variable to indicate the path to the virt-sandbox configuration file, this path renames this variable to prevent confusion. Signed-off-by: Dan Walsh --- bin/virt-sandbox-service | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/bin

[libvirt] [sandbox PATCH 15/15] Create new /etc/rc.d directory to bind mount over system.

2013-04-03 Thread Dan Walsh
We need to prevent SYSVInit scripts from running by default in the ServiceContainer. The so we recreate all of the directories under /etc/rc.d and copy the functions file over. Signed-off-by: Dan Walsh --- bin/virt-sandbox-service | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions

[libvirt] [sandbox PATCH 08/15] Make CONFIG_PATH external to the Container Class

2013-04-03 Thread Dan Walsh
This patch moves CONFIG_PATH external from the Container Class. This will eliminate the need to create a container to get this constant. Signed-off-by: Dan Walsh --- bin/virt-sandbox-service | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/bin/virt-sandbox

[libvirt] [sandbox PATCH 11/15] Refactor Container class into Container and ServiceContainer Class.

2013-04-03 Thread Dan Walsh
This way we can share common methods between the ServiceContainer and the InteractiveContainer (Patch to be added) --- bin/virt-sandbox-service | 754 --- 1 file changed, 385 insertions(+), 369 deletions(-) diff --git a/bin/virt-sandbox-service b/bin/vi

[libvirt] [sandbox PATCH 14/15] Check for LXC if virt-sandbox-service execute command specified

2013-04-03 Thread Dan Walsh
virt-sandbox-service execute is not supported on qemu sandboxes. Signed-off-by: Dan Walsh --- bin/virt-sandbox-service | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/bin/virt-sandbox-service b/bin/virt-sandbox-service index 8c9ea76..7b0410a 100755 --- a/bin/virt-sandbox

[libvirt] [sandbox PATCH 02/15] Add support for InteractiveContainers to virt-sandbox-service-util

2013-04-03 Thread Dan Walsh
We need to add support for interactive sandbox/containers for OpenShift. This patch will create the correct container type based off the /etc/libvirt-sandbox/service/* --- bin/virt-sandbox-service-util.c | 31 +++ 1 file changed, 19 insertions(+), 12 deletions(-) dif

[libvirt] Patch set to add InteractiveContainer support to virt-sandbox

2013-04-03 Thread Dan Walsh
Resend of patches with lots of cleanups. This patch set adds InteractiveContainer support to virt-sandbox-service command. This is needed if we want to support the OpenShift model of containers. There are also some bug fix patches in the set. [sandbox PATCH 01/15] virt-sandbox-service-util

[libvirt] [sandbox PATCH 03/15] Move virt-sandbox-service bash completion script to default directory.

2013-04-03 Thread Dan Walsh
bash_completion scripts have added a new way to do completions, where you place you scripts in /usr/share/bash_completion/completions rather then /etc/bash_completions.d. We should follow the new standard, and this patch moves our bash_completion script to the proper location with the proper name.

[libvirt] [sandbox PATCH 09/15] Add exception handler GlibGerror to virt-sandbox-service

2013-04-03 Thread Dan Walsh
GlibGerror can be raised by virt-sandbox-service, this patch will catch the exception and write the error to stderr. Signed-off-by: Dan Walsh --- bin/virt-sandbox-service | 4 1 file changed, 4 insertions(+) diff --git a/bin/virt-sandbox-service b/bin/virt-sandbox-service index df88284

[libvirt] [sandbox PATCH 01/15] virt-sandbox-service-util needs to free allocated memory.

2013-04-03 Thread Dan Walsh
Coverity found that we could be leaking memory with virt-sandbox-service-util -e --- bin/virt-sandbox-service-util.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/bin/virt-sandbox-service-util.c b/bin/virt-sandbox-service-util.c index 4d164d8..a292fcd 100644 --- a/bi

  1   2   3   4   >