On 11/16/20 4:43 PM, Andrea Bolognani wrote:
On Fri, 2020-11-13 at 16:23 -0300, Daniel Henrique Barboza wrote:
On 11/13/20 10:51 AM, Andrea Bolognani wrote:
I only skimmed the remaining patches and didn't dig into the code as
much, or as recently, as you have, but from a high-level
: 19d74fdf0eb5d2e89e80ceedea736425160ffccb
Reported-by: John Ferlan
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_tpm.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_tpm.c b/src/qemu/qemu_tpm.c
index 8adb0e42b8..872be16570 100644
--- a/src/qemu
virQEMUDomainCapsCache code
Reviewed-by: Daniel Henrique Barboza
src/conf/domain_capabilities.c| 88
src/conf/domain_capabilities.h| 4 -
src/libvirt_private.syms | 1 -
src/qemu/qemu_capabilities.c | 129
(Peter, I cc'ed you because I cited one of your commits and you might want
to weight in)
On 11/13/20 10:51 AM, Andrea Bolognani wrote:
On Fri, 2020-11-13 at 09:58 -0300, Daniel Henrique Barboza wrote:
On 11/13/20 7:30 AM, Andrea Bolognani wrote:
On Wed, 2020-11-11 at 19:07 -0300, Daniel
On 11/13/20 2:39 PM, John Ferlan wrote:
Coverity found a bad merge conflict resolution...
Thanks John. Just posted a fix. Guess I'll have to find a way to
run Coverity before pushing stuff ...
DHB
On 11/12/20 4:48 PM, Daniel Henrique Barboza wrote:
Signed-off-by: Daniel Henrique
: 74b2834333ab3bf500f870e0a6d4e8309379d96a
Reported-by: John Ferlan
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_driver.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 78ccf96df5..ac38edf009 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu
On 11/12/20 7:21 PM, Jonathon Jongsma wrote:
On Thu, 12 Nov 2020 18:48:30 -0300
Daniel Henrique Barboza wrote:
I intended to clean up the virDomainDefFree() calls that I
kept seeing in qemu_driver.c, ended up doing a bit more than
that.
Daniel Henrique Barboza (10):
qemu_driver.c: use
On 11/13/20 10:51 AM, Andrea Bolognani wrote:
On Fri, 2020-11-13 at 09:58 -0300, Daniel Henrique Barboza wrote:
On 11/13/20 7:30 AM, Andrea Bolognani wrote:
On Wed, 2020-11-11 at 19:07 -0300, Daniel Henrique Barboza wrote:
+++ b/tests/qemuxml2argvdata/memory-hotplug-ppc64-nonuma.args
On 11/13/20 7:30 AM, Andrea Bolognani wrote:
On Wed, 2020-11-11 at 19:07 -0300, Daniel Henrique Barboza wrote:
+++ b/tests/qemuxml2argvdata/memory-hotplug-ppc64-nonuma.args
@@ -11,7 +11,7 @@ QEMU_AUDIO_DRV=none \
-name QEMUGuest1 \
-S \
-machine pseries,accel=kvm,usb=off,dump-guest
On 11/12/20 8:33 AM, Ján Tomko wrote:
s/rs/rst/
Ops! Thanks for catching that. Fixed in my local branch.
DHB
Jano
On a Wednesday in 2020, Daniel Henrique Barboza wrote:
Document that we're not reflecting the aligned value in the
live domain XML, and that we fixed a bug
On 11/12/20 8:28 AM, Michal Privoznik wrote:
On 11/11/20 11:07 PM, Daniel Henrique Barboza wrote:
Hi,
This is a work that I intended to do after pSeries NVDIMM changes
I made in commit v6.7.0-302-gd3f3c2c97f. The reasoning is that
if ppc64 NVDIMM alignment can be done in PostParse time
Use g_autoptr() to deprecate the 'cleanup' label.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 2fe8d06fdf..67d11aca92 100644
--- a/src
Remove obsolete 'cleanup' labels after the changes from the
previous patch.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c | 42 +++---
1 file changed, 15 insertions(+), 27 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_snapshot.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c
index 8e3540bbc1..a31a62b7ec 100644
--- a/src/qemu/qemu_snapshot.c
+++ b/src/qemu/qemu_snapshot.c
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_driver.c | 54 ++
1 file changed, 18 insertions(+), 36 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 05f8eb2cb7..fdbac9d21d 100644
--- a/src/qemu/qemu_driver.c
Use g_autoptr() and remove the 'cleanup' label.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index f28178af61..aea0a6bd93 100644
--- a/src/qemu
Some labels became deprecated after the previous patches.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_driver.c | 132 +
1 file changed, 55 insertions(+), 77 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index
Use VIR_AUTOCLOSE with 'fd' and delete the 'cleanup' label.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 67d11aca92..f28178af61 100644
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c | 15 +--
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 70896ad80e..3c17e6e4b4 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_driver.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index fdbac9d21d..2198e7f1e9 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_driver.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 2198e7f1e9..6ff7289fd1 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
I intended to clean up the virDomainDefFree() calls that I
kept seeing in qemu_driver.c, ended up doing a bit more than
that.
Daniel Henrique Barboza (10):
qemu_driver.c: use g_autoptr() with virDomainDef pointers
qemu_driver.c: use g_autoptr() with qemuMigrationParams pointers
if
virt-install needed some tuning or something...
Reviewed-by: Daniel Henrique Barboza
docs/kbase/virtiofs.rst | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/docs/kbase/virtiofs.rst b/docs/kbase/virtiofs.rst
index 01440420d7..c0bc07a68d 100644
--- a/docs/kbase
.
Signed-off-by: Michal Privoznik
---
Reviewed-by: Daniel Henrique Barboza
src/util/virnetdevopenvswitch.c | 36 +++--
1 file changed, 12 insertions(+), 24 deletions(-)
diff --git a/src/util/virnetdevopenvswitch.c b/src/util/virnetdevopenvswitch.c
index d809152f33
check it's a openvswitch interface
s/a openvswitch/an openvswitch
ps: I am aware that those were existing typos and you just moved them, but
might as
well fix it while you're at it :)
Reviewed-by: Daniel Henrique Barboza
+ */
+if (!path ||
+!(tmpIfname = strr
/show_bug.cgi?id=1839095
Signed-off-by: Jiri Denemark
---
Reviewed-by: Daniel Henrique Barboza
src/qemu/qemu_process.c | 35 ++-
1 file changed, 26 insertions(+), 9 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 0a36b49c85
This function has no callers left after we moved the mem module
alignment to PostParse callbacks.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c | 20
src/qemu/qemu_domain.h | 2 --
2 files changed, 22 deletions(-)
diff --git a/src/qemu/qemu_domain.c b
where the alignments are being done.
Signed-off-by: Daniel Henrique Barboza
---
src/conf/domain_conf.c | 9 +
src/qemu/qemu_domain.c | 20 ++--
2 files changed, 19 insertions(+), 10 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index e4aecc9a4d
the PostParse callback
will align the mem object.
This means that we can live without a qemuDomainMemoryDeviceAlignSize()
call at the start of qemuDomainAttachMemory().
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_hotplug.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src
() that will get the already aligned mem object
from the domain definition.
This means that the qemuDomainMemoryDeviceAlignSize() call at the
start of this function is now obsolete and can be removed.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_hotplug.c | 6 +++---
1 file changed, 3
Document that we're not reflecting the aligned value in the
live domain XML, and that we fixed a bug that occurred in
pSeries guests where a guest might start with an extra 256MiB
of memory.
Signed-off-by: Daniel Henrique Barboza
---
NEWS.rst | 14 ++
1 file changed, 14 insertions
ore calculating 'hotplugmem'.
We'll also generated aligned values in the resulting XML as well.
Some xml2xml tests were changed to reflect this new behavior.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c| 45 +++
tests/qemuxml2argvd
The function is no longer used for ppc64 alignment. This allow us
to exclude the 'def' argument and simplify its usage. Let's also
make it clearer in the comment that the function is now returning
x86 specific values.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c | 14
().
Daniel Henrique Barboza (10):
domain_conf.c: handle all ppc64 dimms in
virDomainNVDimmAlignSizePseries
qemu_domain.c: align memory modules before calculating 'initialmem'
domain_conf.c: align pSeries mem modules in
virDomainMemoryDefPostParse()
qemu_domain.c: simplify
This simplifies the handling of ppc64 alignment in other parts
of the code, with a single function to handle all cases for the
architecture.
No functional changes were made just yet. Function was renamed to
reflect the broader scope.
Signed-off-by: Daniel Henrique Barboza
---
src/conf
().
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c| 42 ++-
.../memory-hotplug-ppc64-nonuma.args | 2 +-
2 files changed, 24 insertions(+), 20 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 375a9e5075
for mem module alignment for pSeries in
the QEMU driver, simplifying the code a bit.
Signed-off-by: Daniel Henrique Barboza
---
src/conf/domain_conf.c | 1 -
src/qemu/qemu_domain.c | 13 +++--
2 files changed, 3 insertions(+), 11 deletions(-)
diff --git a/src/conf/domain_conf.c b/src
On 11/10/20 2:04 AM, Masayoshi Mizuma wrote:
From: Masayoshi Mizuma
A qemu guest which has virtiofs config fails to start if the previous
starting failed because of invalid option or something.
For example of the reproduction:
# virsh start guest
error: Failed to start domain guest
-by: Daniel Henrique Barboza
Successfully build here:
https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/213586713
While technically this is a v2 of:
https://www.redhat.com/archives/libvir-list/2020-November/msg00308.html
it's implementing completely different approach and thus I did
:
Reviewed-by: Daniel Henrique Barboza
Shouldn't you add some test cases for this new behavior though? I'm a bit
nervous with pushing this upstream without any coverage.
Thanks,
DHB
Nikolay Shirokovskiy (10):
qemu: qemuDomainRenameCallback: fix sending false undefined event
qemu: rename
On 11/3/20 9:00 AM, Nikolay Shirokovskiy wrote:
This is basically just saves checkpoints metadata on disk after name is changed
"This basically just saves ..."
in memory as path to domain checkpoints directory depends on name. After that
old checkpoint directory is deleted with checkpoint
On 11/3/20 9:00 AM, Nikolay Shirokovskiy wrote:
This is basically just saves snapshots metadata on disk after name is changed
Extra 'is'. "This basically just saves "
in memory as path to domain snapshot directory depends on name. After that
old snapshot directory is deleted with
qemu_migration_cookie: Make cookie parsing robust against missing
domain job
tests: Add testing of qemu migration cookie
qemumigrationcookiexmltest: Add synthetic test case
virCPUDefFormatBufFull: Use virXMLFormatElement
Reviewed-by: Daniel Henrique Barboza
src/conf/cpu_conf.c
On 10/30/20 1:47 PM, Peter Krempa wrote:
Add a test case attempting to excercise the most of the cookie XML
s/excercise/exercise
Reviewed-by: Daniel Henrique Barboza
parsing/formatting infra. Note that the data is not based on any real
case.
Signed-off-by: Peter Krempa
---
.../full
On 11/5/20 12:26 PM, Peter Krempa wrote:
On Thu, Nov 05, 2020 at 10:50:23 -0300, Daniel Henrique Barboza wrote:
On 11/4/20 2:05 PM, Peter Krempa wrote:
We didn't use it rigorously and some helpers even cast it away. Remove
const from all hash utility functions.
Unrelated question: how
replacements
tests: Remove 'virhashtest'
LGTM
Reviewed-by: Daniel Henrique Barboza
src/conf/backup_conf.c| 2 +-
src/conf/domain_addr.h| 2 +-
src/conf/domain_conf.c| 12 +-
src/conf/domain_conf.h
On 11/4/20 2:05 PM, Peter Krempa wrote:
We didn't use it rigorously and some helpers even cast it away. Remove
const from all hash utility functions.
Unrelated question: how much do we care about standardizing a bit the
'const' usage in the code? I for one had to rely on casting to satisfy
, according to google). Either way is fine AFAIC.
Reviewed-by: Daniel Henrique Barboza
analyse all iterators add virHashForEachSafe which first gets a list of
elements and iterates them outside of the hash table.
This will allow replace the internals of the hash table with other
implementation which
Same thing I mentioned in patch 01 (split the docs, conf and logic in
separated patches) applies to this patch and patch 04.
Thanks,
DHB
On 10/21/20 7:59 AM, Shalini Chellathurai Saroja wrote:
From: Farhan Ali
Each AP Card device can support upto 256 AP Queues.
AP Queues are also detected
This patch is doing multiple things in a single punch:
- docs/ changes
- parse code in src/conf
- added logic in node_device_udev.c
- test changes
I suggest you split this one in at least 3 patches: changes in 'docs',
changes in 'src/conf' with nodedevxml2xmltest.c changes, another patch
with
in patch 8. There's no cleanup labels to
be added there, so it's a trivial removal of the two VIR_DIR_CLOSE()
calls and turning the DIR var to g_autoptr().
Assuming you go with that (and fix my whitespace nit in patch 12! :P ), feel
free to add my R-b in all patches:
Reviewed-by: Daniel Henrique Barb
/* Assume a single directory entry */
+if (virDirRead(dir, , path) > 0)
+return g_strdup(entry->d_name);
Nit: extra whitespace after 'return'
Reviewed-by: Daniel Henrique Barboza
- cleanup:
-return sg;
+return NULL;
}
/* Returns device name (e.g. &
-by: Laine Stump
---
Reviewed-by: Daniel Henrique Barboza
src/node_device/node_device_udev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/node_device/node_device_udev.c
b/src/node_device/node_device_udev.c
index b1b8427c05..ec0bf9192b 100644
--- a/src/node_device
On 10/27/20 9:47 AM, Hao Wang wrote:
Introduce DomainGetDirtyRateInfo API for domain's memory dirty rate
calculation and query.
Signed-off-by: Hao Wang
Signed-off-by: Zhou Yimin
Reviewed-by: Chuan Zheng
---
This patch does not compile/test successfully in my env. There are
at least 2
On 10/19/20 9:58 AM, Hao Wang wrote:
Implement qemuMonitorJSONExtractDirtyRateInfo to deal with the return from
qmp "query-dirty-rate", and store them in virDomainDirtyRateInfo.
Signed-off-by: Hao Wang
Reviewed-by: Chuan Zheng
---
This patch failed to compile in my env:
should indeed be considered fatal.
Signed-off-by: Daniel P. Berrangé
---
Just a FYI: there is a trivial conflict in qemu_interface.h when applying
it to current master.
Reviewed-by: Daniel Henrique Barboza
src/qemu/qemu_hotplug.c | 7 +--
src/qemu/qemu_interface.c | 21
On 10/20/20 2:54 PM, Masayoshi Mizuma wrote:
From: Masayoshi Mizuma
virtiofsd has --thread-pool-size=NUM option to limit the
thread pool size. It will be useful to tune the performance.
Add pool element to use the option like as:
result in the
pre-migration checks failing (not that migration with SEV works at the
time of this patch).
This patch enables autofill of these attributes right before launching
QEMU and thus updating the live XML.
Signed-off-by: Erik Skultety
---
Reviewed-by: Daniel Henrique Barboza
src/conf
SEV, but that's okay, we never guaranteed error messages to
remain the same.
Signed-off-by: Erik Skultety
---
Reviewed-by: Daniel Henrique Barboza
src/qemu/qemu_process.c | 9 -
src/qemu/qemu_validate.c | 8
2 files changed, 8 insertions(+), 9 deletions(-)
diff --git
sing g_autofree in qemuMonitorJSONCheckErrorFull()
and qemuMonitorJSONCheckReply()"
On 10/15/20 11:17 PM, Yi Li wrote:
Eliminate cleanup code by using g_autofree.
Signed-off-by: Yi Li
---
The code LGTM. With the commit title/msg changes:
Reviewed-by: Daniel Henrique Barboza
src/qemu
On 10/15/20 8:46 AM, Michal Privoznik wrote:
On 10/14/20 10:42 PM, Daniel Henrique Barboza wrote:
Hi,
This is another step following up the work done in [1].
Recapping, the idea is to move any validation that can
be done in parse/define time to qemu_validate.c instead
of let it sit inside
=1850654
Signed-off-by: Tim Wiederhake
---
Reviewed-by: Daniel Henrique Barboza
docs/manpages/virsh.rst | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst
index 8fee4c7afe..d34a1c8684 100644
--- a/docs/manpages/virsh.rst
make the attributes optional and should fill them in automatically
in the QEMU driver right before starting it.
Resolves: https://gitlab.com/libvirt/libvirt/-/issues/57
Signed-off-by: Erik Skultety
---
Already considering that changed that was squashed in later:
Reviewed-by: Daniel Henrique
On 10/9/20 11:13 AM, Erik Skultety wrote:
Signed-off-by: Erik Skultety
---
Reviewed-by: Daniel Henrique Barboza
src/qemu/qemu_process.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 6b5de29fdb..2cc1d58266
On 10/9/20 11:13 AM, Erik Skultety wrote:
These XML attributes have been mandatory since the introduction of SEV
support to libvirt. This design decision was based on QEMU's
requirement for these to be mandatory for migration purposes, as
differences in these values across platforms must
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_validate.c | 58
1 file changed, 29 insertions(+), 29 deletions(-)
diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c
index 5b5c2ab3dd..eeec2270e6 100644
--- a/src/qemu
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_validate.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c
index 0f4cb3c983..b5bea4a0ee 100644
--- a/src/qemu/qemu_validate.c
+++ b/src/qemu
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_command.c | 9 ++---
src/qemu/qemu_validate.c | 8
tests/qemuxml2xmltest.c | 2 +-
3 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 9f45faa490
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_command.c | 6 --
src/qemu/qemu_validate.c | 8
2 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index f9387a65e0..29bfa665c4 100644
--- a/src/qemu
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_command.c | 8 +---
src/qemu/qemu_validate.c | 8
tests/qemuxml2xmltest.c | 3 ++-
3 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index acbd5b1234
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_command.c | 21 -
src/qemu/qemu_validate.c | 29 ++---
tests/qemuxml2xmltest.c | 10 +++---
3 files changed, 33 insertions(+), 27 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_command.c | 78 +--
src/qemu/qemu_validate.c | 96 +++
.../pseries-panic-address.err | 2 +-
tests/qemuxml2argvtest.c | 10
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_command.c | 11 ++-
src/qemu/qemu_command.h | 3 +--
src/qemu/qemu_hotplug.c | 2 +-
src/qemu/qemu_validate.c | 19 ++-
tests/qemuxml2xmltest.c | 3 ++-
5 files changed, 20 insertions(+), 18 deletions
All but VIR_CPU_MODE_HOST_MODEL were moved. 'host_model' mode
has nuances that forbid the verification to be moved to parse
time.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_command.c | 20 --
src/qemu/qemu_validate.c | 56
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_command.c | 9 +
src/qemu/qemu_validate.c | 7 +++
tests/qemuxml2xmltest.c | 2 +-
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index f350800ff0..87d76827e8
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_command.c | 15 ---
src/qemu/qemu_validate.c | 14 ++
tests/qemuxml2xmltest.c | 12 +---
3 files changed, 23 insertions(+), 18 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_command.c | 20
src/qemu/qemu_validate.c | 25 +
tests/qemuxml2argvtest.c | 6 +++---
tests/qemuxml2xmltest.c | 4 ++--
4 files changed, 30 insertions(+), 25 deletions(-)
diff --git a/src
We have a lot of "if (usingVirtio)" checks being done while
constructing the NIC command line. Let's put all of them in
a single "if".
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_command.c | 50 -
1 file changed,
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_command.c | 7 ---
src/qemu/qemu_validate.c | 10 ++
2 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index b2c6bd43a2..a5abd814a2 100644
--- a/src/qemu
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_command.c | 5 -
src/qemu/qemu_validate.c | 15 +++
tests/qemuxml2xmltest.c | 2 +-
3 files changed, 16 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 34d57606f0
Hi,
This is another step following up the work done in [1].
Recapping, the idea is to move any validation that can
be done in parse/define time to qemu_validate.c instead
of let it sit inside a command line build function in
qemu_command.c. I'll again copy/paste the reasoning Cole
Robinson gave
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_command.c | 28 ++--
src/qemu/qemu_command.h | 1 -
src/qemu/qemu_hotplug.c | 2 +-
src/qemu/qemu_validate.c | 38 --
tests/qemuxml2xmltest.c | 9 ++---
5 files changed
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_command.c| 10 +++---
src/qemu/qemu_validate.c | 8
.../net-virtio-rxqueuesize-invalid-size.err| 2 +-
tests/qemuxml2xmltest.c
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_command.c | 27 ---
src/qemu/qemu_validate.c | 31 +--
tests/qemuxml2argvtest.c | 4 +++-
3 files changed, 32 insertions(+), 30 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_command.c | 6 --
src/qemu/qemu_validate.c | 9 +
tests/qemuhotplugtest.c | 1 +
3 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index a4f1cbce11..f9387a65e0
of erroring it out from the
common code in virDomainDiskDefValidate(), we're failing earlier
with a different error message.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_command.c | 11 ---
src/qemu/qemu_validate.c | 19
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_command.c | 24 ---
src/qemu/qemu_validate.c | 41 +++-
2 files changed, 40 insertions(+), 25 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index
Rename the function to qemuValidateDomainVCpuTopology() to reflect
what it is currently doing as well.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_validate.c | 174 +++
1 file changed, 87 insertions(+), 87 deletions(-)
diff --git a/src/qemu
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_command.c | 4
src/qemu/qemu_validate.c | 8
tests/qemuxml2xmltest.c | 4 ++--
3 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 06ac175b67..1629fac659
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_command.c | 18 -
src/qemu/qemu_validate.c | 43 +++-
tests/qemuxml2argvtest.c | 2 +-
tests/qemuxml2xmltest.c | 2 +-
4 files changed, 44 insertions(+), 21 deletions(-)
diff --git
On 10/13/20 11:06 AM, Michal Privoznik wrote:
On 10/13/20 3:09 PM, Daniel Henrique Barboza wrote:
On 10/8/20 3:10 PM, Michal Privoznik wrote:
See 2/2 for detailed explanation.
Long story short - we can squeeze more bandwidth from TAP devices we
create for domains.
Michal Prívozník (2
for the Virtio Free page reporting
feature
QEMU: introduce Virtio free page reporting feature
provide testing for free-page-reporting feature in QEMU
Reviewed-by: Daniel Henrique Barboza
docs/formatdomain.rst | 6
docs/schemas/domaincommon.rng
-by: Daniel Henrique Barboza
Have you tried it out with older kernels? Reading the bug I understood
that 4.2 and older (2015 kernels) does not have qdisc support and that you
can, for example, test for NETIF_F_LLTX of the ETHTOOL_GFEATURES ioctl to
verify it.
I consider this to be a 'nice to have
This patch failed to compile in my env:
FAILED: tools/virsh.p/virsh-domain.c.o
[]
-D_FUNCTION_DEF -MD -MQ tools/virsh.p/virsh-domain.c.o -MF
tools/virsh.p/virsh-domain.c.o.d -o tools/virsh.p/virsh-domain.c.o -c
../tools/virsh-domain.c
In file included from
nodes and QEMU is new enough to expose ID of
+ * the default RAM we want to use it for default RAM (construct
+ * memory-backend-* with corresponding attributes instead of obsolete
+ * -mem-path and -mem-prealloc.
I think you're missing a closing ')' in this sentence up here ^
Everything
On 10/7/20 4:10 PM, Ján Tomko wrote:
Signed-off-by: Ján Tomko
---
Reviewed-by: Daniel Henrique Barboza
tools/virsh-completer-domain.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/virsh-completer-domain.c b/tools/virsh-completer-domain.c
index
On 10/2/20 2:28 PM, Michal Prívozník wrote:
On 10/2/20 6:42 PM, Daniel Henrique Barboza wrote:
On 10/2/20 1:07 PM, Michal Prívozník wrote:
On 10/1/20 4:35 PM, Daniel Henrique Barboza wrote:
When VIR_EXEC_DAEMON is true and cmd->pidfile exists, the parent
[...]
Resolves: ht
On 10/2/20 1:07 PM, Michal Prívozník wrote:
On 10/1/20 4:35 PM, Daniel Henrique Barboza wrote:
When VIR_EXEC_DAEMON is true and cmd->pidfile exists, the parent
[...]
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1882093
Signed-off-by: Daniel Henrique Barboza
---
src/u
The code is ok but the commit message can be improved. Usually
we want a commit title with a single-line summary of what you're
changing, a blank line, and a description describes in more
the change, and your signed-off tag. This guideline can be
found here:
different
CPU models that have different CPU freatures.
Signed-off-by: Zhenyu Zheng
---
Reviewed-by: Daniel Henrique Barboza
src/cpu/cpu_arm.c | 39 ---
1 file changed, 36 insertions(+), 3 deletions(-)
diff --git a/src/cpu/cpu_arm.c b/src/cpu/cpu_arm.c
index
501 - 600 of 1918 matches
Mail list logo
