' backend.
An example of a TPM Proxy device connected to a TPM Resource Manager
'/dev/tpmrm0' will look like this:
Signed-off-by: Daniel Henrique Barboza
---
docs/formatdomain.html.in | 19 ++-
docs/schemas/domaincommon.rng | 1 +
2 files changed, 19 insertions
with the H_TPM_COMM
hypercall to connect with the TPM Resource Manager, enabling
the guest to open and close TPM sessions with the host TPM.
Reviewed-by: Stefan Berger
Reviewed-by: Ján Tomko
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_capabilities.c| 4
src/qemu
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_alias.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_alias.c b/src/qemu/qemu_alias.c
index b0ea62af39..d6527cb046 100644
--- a/src/qemu/qemu_alias.c
+++ b/src/qemu/qemu_alias.c
@@ -390,7 +390,7
On 5/14/20 11:32 AM, Daniel Henrique Barboza wrote:
On 5/14/20 11:09 AM, Ján Tomko wrote:
On a Wednesday in 2020, Daniel Henrique Barboza wrote:
Aside from trivial XML parsing/format changes, this patch adds
additional rules for TPM device support to better accomodate
[...]
Any
On 5/14/20 11:09 AM, Ján Tomko wrote:
On a Wednesday in 2020, Daniel Henrique Barboza wrote:
Aside from trivial XML parsing/format changes, this patch adds
additional rules for TPM device support to better accomodate
all the available scenarios with the new TPM Proxy.
The changes make
Signed-off-by: Daniel Henrique Barboza
---
docs/news.xml | 17 +
1 file changed, 17 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 4cef804aac..c22a0f0a18 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -44,6 +44,23
capabilities for this device again inside
qemu_command.c.
Reviewed-by: Stefan Berger
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_alias.c | 16
src/qemu/qemu_command.c | 21 +
2 files changed, 37 insertions(+)
diff --git a/src/qemu/qemu_alias.c b/src
are valid:
- a single TPM device
- a single TPM Proxy device
- a single TPM + single TPM Proxy devices
These combinations in the same domain are NOT allowed:
- 2 or more TPM devices
- 2 or more TPM Proxy devices
Signed-off-by: Daniel Henrique Barboza
---
src/conf/domain_conf.c | 45
Add tests for both supported scenarios: a single TPM Proxy and
a TPM Proxy with a regular TPM device in the same domain.
Reviewed-by: Stefan Berger
Signed-off-by: Daniel Henrique Barboza
---
.../ppc64-tpmproxy-single.ppc64-latest.args | 34 +
.../ppc64-tpmproxy-with-tpm.ppc64
Next patch will make use of g_autoptr() with virDomainTPMDefPtr.
Signed-off-by: Daniel Henrique Barboza
---
src/conf/domain_conf.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index 8f178ade34..60dbba3b19 100644
--- a/src/conf/domain_conf.h
This tests aims to exercise how a TPM Proxy device can be
added in the domain, either alone or with a regular TPM
device. It also ensures that we do not allow bogus scenarios
to slip by.
Reviewed-by: Stefan Berger
Signed-off-by: Daniel Henrique Barboza
---
tests/qemuxml2argvdata/ppc64-tpm
.
Signed-off-by: Daniel Henrique Barboza
---
src/conf/domain_audit.c | 3 +++
src/conf/domain_conf.c | 18 ++
src/conf/domain_conf.h | 2 ++
src/qemu/qemu_cgroup.c | 12 +---
src/qemu/qemu_domain.c | 9 +
src/qemu
no benefits unless
the guest is running on specialized PPC64 hardware
- fixed identation in patch 6 (former 5). Added Stefan's r-b
v2 link: https://www.redhat.com/archives/libvir-list/2020-May/msg00604.html
v1 link: https://www.redhat.com/archives/libvir-list/2020-May/msg00604.html
Daniel Henrique
' backend.
An example of a TPM Proxy device connected to a TPM Resource Manager
'/dev/tpmrm0' will look like this:
Signed-off-by: Daniel Henrique Barboza
---
docs/formatdomain.html.in | 18 +-
docs/schemas/domaincommon.rng | 1 +
2 files changed, 18 insertions(+), 1
with the H_TPM_COMM
hypercall to connect with the TPM Resource Manager, enabling
the guest to open and close TPM sessions with the host TPM.
Reviewed-by: Stefan Berger
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_capabilities.c| 4
src/qemu/qemu_capabilities.h
On 5/13/20 11:35 AM, Stefan Berger wrote:
On 5/13/20 10:10 AM, Daniel Henrique Barboza wrote:
Aside from trivial XML parsing/format changes, this patch adds
additional rules for TPM device support to better accomodate
all the available scenarios with the new TPM Proxy.
The changes make
On 5/13/20 12:45 PM, Stefan Berger wrote:
[...]
I think users need to understand that a pSeries guest will not benefit from
this but only a pSeries guest that is a secure virtual machine that needs
special hardware to run and where there is an Ultravisor. Everyone would want
more security
On 5/13/20 12:32 PM, Michal Privoznik wrote:
On 5/13/20 4:48 PM, Daniel Henrique Barboza wrote:
On 5/12/20 11:52 AM, Michal Privoznik wrote:
[...]
I think the problem is simpler to handle in Libvirt when QEMU deprecates the old
format entirely. Otherwise the user will have to also keep
On 5/13/20 11:28 AM, Stefan Berger wrote:
On 5/13/20 10:10 AM, Daniel Henrique Barboza wrote:
QEMU 4.1.0 introduced a new device type called TPM Proxy, currently
implemented by PPC64 guests via a new virtual device called
'spapr-tpm-proxy' (see QEMU 0fb6bd073230 for more info).
The TPM
On 5/12/20 11:52 AM, Michal Privoznik wrote:
In a way, libvirt already uses -numa memdev= in a few cases. In fact, in
as few cases as possible - only configurations which can not be
configured with -numa mem=, because these two ways are incompatible when
it comes to migration.
My approach to
capabilities for this device again inside
qemu_command.c.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_alias.c | 16
src/qemu/qemu_command.c | 21 +
2 files changed, 37 insertions(+)
diff --git a/src/qemu/qemu_alias.c b/src/qemu/qemu_alias.c
index
are valid:
- a single TPM device
- a single TPM Proxy device
- a single TPM + single TPM Proxy devices
These combinations in the same domain are NOT allowed:
- 2 or more TPM devices
- 2 or more TPM Proxy devices
Signed-off-by: Daniel Henrique Barboza
---
src/conf/domain_conf.c | 47
shouldn't
- more descriptive commit messages to make it clearer the
intention/use case of the TPM Proxy device and how it interacts with
the existing TPM models.
v1 link: https://www.redhat.com/archives/libvir-list/2020-May/msg00351.html
Daniel Henrique Barboza (8):
docs: documentation and schema
' backend.
An example of a TPM Proxy device connected to a TPM Resource Manager
'/dev/tpmrm0' will look like this:
Signed-off-by: Daniel Henrique Barboza
---
docs/formatdomain.html.in | 16 +++-
docs/schemas/domaincommon.rng | 1 +
2 files changed, 16 insertions(+), 1
Signed-off-by: Daniel Henrique Barboza
---
docs/news.xml | 15 +++
1 file changed, 15 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 4cef804aac..452f73479e 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -44,6 +44,21 @@
+
+
+ qemu
with the H_TPM_COMM
hypercall to connect with the TPM Resource Manager, enabling
the guest to open and close TPM sessions with the host TPM.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_capabilities.c| 4
src/qemu/qemu_capabilities.h| 3 +++
tests
This tests aims to exercise how a TPM Proxy device can be
added in the domain, either alone or with a regular TPM
device. It also ensures that we do not allow bogus scenarios
to slip by.
Signed-off-by: Daniel Henrique Barboza
---
tests/qemuxml2argvdata/ppc64-tpm-double.xml | 34
Add tests for both supported scenarios: a single TPM Proxy and
a TPM Proxy with a regular TPM device in the same domain.
Signed-off-by: Daniel Henrique Barboza
---
.../ppc64-tpmproxy-single.ppc64-latest.args | 34 +
.../ppc64-tpmproxy-with-tpm.ppc64-latest.args | 37
.
Signed-off-by: Daniel Henrique Barboza
---
src/conf/domain_audit.c | 3 +++
src/conf/domain_conf.c | 18 ++
src/conf/domain_conf.h | 2 ++
src/qemu/qemu_cgroup.c | 12 +---
src/qemu/qemu_domain.c | 9 +
src/qemu
On 5/12/20 1:44 PM, Daniel P. Berrangé wrote:
On Tue, May 12, 2020 at 01:21:40PM -0300, Daniel Henrique Barboza wrote:
On 5/12/20 12:53 PM, Daniel P. Berrangé wrote:
On Tue, May 12, 2020 at 11:21:52AM -0400, Stefan Berger wrote:
On 5/11/20 7:28 AM, Daniel P. Berrangé wrote:
On Mon, May
On 5/11/20 8:50 AM, Daniel Henrique Barboza wrote:
On 5/11/20 8:28 AM, Daniel P. Berrangé wrote:
On Mon, May 11, 2020 at 08:26:53AM -0300, Daniel Henrique Barboza wrote:
On 5/11/20 6:57 AM, Daniel P. Berrangé wrote:
On Mon, May 11, 2020 at 11:22:57AM +1000, David Gibson wrote
On 5/12/20 12:53 PM, Daniel P. Berrangé wrote:
On Tue, May 12, 2020 at 11:21:52AM -0400, Stefan Berger wrote:
On 5/11/20 7:28 AM, Daniel P. Berrangé wrote:
On Mon, May 11, 2020 at 08:26:53AM -0300, Daniel Henrique Barboza wrote:
On 5/11/20 6:57 AM, Daniel P. Berrangé wrote:
On Mon, May
process, because
the swtmp_ioctl command can lock up::
https://bugzilla.redhat.com/show_bug.cgi?id=1822523
Remove the first call and only leave the one in qemuProcessStop,
which is called after the QEMU process is killed.
Signed-off-by: Ján Tomko
---
Reviewed-by: Daniel Henrique Barboza
On 5/12/20 10:48 AM, Daniel Henrique Barboza wrote:
On 5/12/20 8:23 AM, Ján Tomko wrote:
A failure in qemuProcessLaunch would lead to qemuExtStopDevices
being called twice - once in the cleanup section and then again
in qemuProcessStop.
However, the first one is called while the QEMU
On 5/12/20 8:23 AM, Ján Tomko wrote:
A failure in qemuProcessLaunch would lead to qemuExtStopDevices
being called twice - once in the cleanup section and then again
in qemuProcessStop.
However, the first one is called while the QEMU process is
still running, which is too soon for the swtpm
On 5/11/20 8:28 AM, Daniel P. Berrangé wrote:
On Mon, May 11, 2020 at 08:26:53AM -0300, Daniel Henrique Barboza wrote:
On 5/11/20 6:57 AM, Daniel P. Berrangé wrote:
On Mon, May 11, 2020 at 11:22:57AM +1000, David Gibson wrote:
[...]
It's a different guest side interface, the H_TPM_COMM
On 5/11/20 6:57 AM, Daniel P. Berrangé wrote:
On Mon, May 11, 2020 at 11:22:57AM +1000, David Gibson wrote:
[...]
It's a different guest side interface, the H_TPM_COMM hypercall
instead of the other PAPR TPM interface. To which "why?" is a very
good question, but it's there now, so there's
(CCing Mike Roth since he implemented the QEMU support for this device)
On 5/8/20 5:18 PM, Stefan Berger wrote:
On 5/8/20 8:06 AM, Daniel Henrique Barboza wrote:
Hello,
This series implements a new device type for Libvirt called
"TPM Proxy". This device acts as a proxy for TPM re
Signed-off-by: Daniel Henrique Barboza
---
docs/news.xml | 14 ++
1 file changed, 14 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 4cef804aac..21ee98c45b 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -44,6 +44,20 @@
+
+
+ qemu
Expose the TPM Proxy support for PPC64 guests by creating a new
cap called QEMU_CAPS_DEVICE_SPAPR_TPM_PROXY.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_capabilities.c| 2 ++
src/qemu/qemu_capabilities.h| 1 +
tests/qemucapabilitiesdata
capabilities for
this device again in qemu_command.c
Signed-off-by: Daniel Henrique Barboza
---
src/libvirt_private.syms | 2 ++
src/qemu/qemu_alias.c| 16
src/qemu/qemu_command.c | 20
3 files changed, 38 insertions(+)
diff --git a/src/libvirt_private.syms
Add virDomainTPMProxyDefParseXML() and virDomainTPMProxyDefFormat()
to handle the creating of the TPM Proxy device via its XML
description.
Signed-off-by: Daniel Henrique Barboza
---
src/conf/domain_conf.c | 94 +-
1 file changed, 93 insertions(+), 1
Add a new test to assert the QEMU command line being built
for the TPM Proxy device.
Signed-off-by: Daniel Henrique Barboza
---
tests/qemuxml2argvdata/ppc64-tpmproxy.args | 28 ++
tests/qemuxml2argvtest.c | 4
2 files changed, 32 insertions(+)
create
this:
Signed-off-by: Daniel Henrique Barboza
---
docs/formatdomain.html.in | 42 +++
docs/schemas/domaincommon.rng | 18 +++
2 files changed, 60 insertions(+)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 23eb029234
This new device will be used to represent a single instance of a
TPM Proxy for the domain.
XML functions to parse and format the device from the XML definition
will be added in the next patch.
Signed-off-by: Daniel Henrique Barboza
---
src/conf/domain_capabilities.c | 1 +
src/conf
Update qemuxml2xmltest.c to add tests to validate the XML parsing
of the new TPM Proxy device type.
Signed-off-by: Daniel Henrique Barboza
---
tests/qemuxml2argvdata/ppc64-tpmproxy.xml | 31 +
tests/qemuxml2xmloutdata/ppc64-tpmproxy.xml | 37 +
tests
t the same time,
but only one TPM Proxy is allowed per guest.
At this moment, this device exists only for QEMU pSeries guests.
A "model" field was added device to allow more models to be added
when/if other architectures implements it.
Daniel Henrique Barboza (8):
docs: docu
On 5/1/20 7:40 AM, Daniel P. Berrangé wrote:
On Thu, Apr 30, 2020 at 09:00:51PM -0300, Daniel Henrique Barboza wrote:
My initial plan is to get the logic/APIs design from Libvirt, rename
them in a Gopher fashion, re-code it with Go and call it a day :)
That is really not a way I would
On 4/30/20 4:14 PM, Laine Stump wrote:
On 4/30/20 2:20 PM, Daniel Henrique Barboza wrote:
On 3/19/20 4:00 PM, Laine Stump wrote:
TL;DR - I'm not as anti-XML as the proposal seems to be, but also not pro-XML.
I also (after thinking about it) understand the advantage of putting
On 3/19/20 4:00 PM, Laine Stump wrote:
TL;DR - I'm not as anti-XML as the proposal seems to be, but also not pro-XML.
I also (after thinking about it) understand the advantage of putting this in a
separate library. So yeah, let's go it!
[...]
Anyway, in the end I think my opinion is we
On 4/28/20 12:58 PM, Boris Fiuczynski wrote:
From: Viktor Mihajlovski
[...]
+
+If the check fails despite the host system actually supporting
+protected virtualization guests, this can be caused by a stale
+libvirt capabilities cache. To recover, run the following
+commands
+
+::
+
+ $
quired to handle
it since it's not a regular tristate capability.
This is the XML format for the cap:
Signed-off-by: Daniel Henrique Barboza
---
docs/formatdomain.html.in | 11 +
docs/schemas/domaincommon.rng | 15 +++
src/conf/domain_conf
This is the XML format for the cap:
Signed-off-by: Daniel Henrique Barboza
---
docs/formatdomain.html.in | 14 ++
docs/schemas/domaincommon.rng | 17 +++
src/conf/domain_conf.c| 46 +++
src/conf/dom
values in a cleaner way, instead of hacking parameters in
elements.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml | 1 +
tests
a regular tristate
capability.
This is the XML format for the cap:
Signed-off-by: Daniel Henrique Barboza
---
docs/formatdomain.html.in | 11 +
docs/schemas/domaincommon.rng | 15 +++
src/conf/domain_conf.c| 44 +
Update news.xml to inform about the availability of CFPC, SBBC and
IBS features.
Signed-off-by: Daniel Henrique Barboza
---
docs/news.xml | 10 ++
1 file changed, 10 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 5835013c19..80819aec23 100644
--- a/docs/news.xml
+++ b
OS requirements, and it's better to do it
so in a proper Libvirt feature than to put QEMU arguments
in the middle of the domain XML.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
tests
or trying to run AIX guests/guests with older
kernels, however, will need to fine tune these options because
QEMU defaults won't work.
Instead of making users rely on elements to
hardcode the options in the XML, let's support them in Libvirt.
Daniel Henrique Barboza (7):
qemu: Add capability
with the now
implemented CFPC, exposing this feature in the XML allows for
a cleaner way for users to tune the SBBC accordingly, given
that not all hypervisor and guest setups supports this
Spectre mitigation.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_capabilities.c
-grained tests are a nice touch too.
All patches:
Reviewed-by: Daniel Henrique Barboza
Ping
On 4/16/20 6:24 PM, Daniel Henrique Barboza wrote:
Hi,
This series implements 3 Spectre related PowerPC features that
were added back in QEMU 2.12:
- CFPC: Cache Flush on Privilege Change
- SBBC: Speculation Barrier Bounds Checking
- IBS: Indirect Branch Speculation
These options
On 4/22/20 9:22 AM, Julio Faracco wrote:
Hi Daniel,
Thanks for reviewing. :-)
Np, glad to be of assistance
IMHO, I don't like to join them in one single patch because it is hard
to review.
Hmm, reading this I believe that the tests would pass after applying patch
2/2 then (didn't
On 4/21/20 1:03 AM, Julio Faracco wrote:
If an user is trying to configure a dhcp neetwork settings, it is not
s/neetwork/network
This patch failed to compile in my box on top of master at 9a13704818e:
CCLD libvirdeterministichashmock.la
../../tests/networkxml2conftest.c: In
a regular tristate
capability.
This is the XML format for the cap:
Signed-off-by: Daniel Henrique Barboza
---
docs/formatdomain.html.in | 11 +
docs/schemas/domaincommon.rng | 15 +++
src/conf/domain_conf.c| 45 +
Update news.xml to inform about the availability of CFPC, SBBC and
IBS features.
Signed-off-by: Daniel Henrique Barboza
---
docs/news.xml | 10 ++
1 file changed, 10 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 4d0efd4219..2066f0eef3 100644
--- a/docs/news.xml
+++ b
This is the XML format for the cap:
Signed-off-by: Daniel Henrique Barboza
---
docs/formatdomain.html.in | 14 ++
docs/schemas/domaincommon.rng | 17 +++
src/conf/domain_conf.c| 46 +++
src/conf/dom
values in a cleaner way, instead of hacking parameters in
elements.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml | 1 +
tests
OS requirements, and it's better to do it
so in a proper Libvirt feature than to put QEMU arguments
in the middle of the domain XML.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_capabilities.c | 4
src/qemu/qemu_capabilities.h | 3
quired to handle
it since it's not a regular tristate capability.
This is the XML format for the cap:
Signed-off-by: Daniel Henrique Barboza
---
docs/formatdomain.html.in | 11 +
docs/schemas/domaincommon.rng | 15 +++
src/conf/domain_conf
them in Libvirt.
Daniel Henrique Barboza (7):
qemu: Add capability for CFPC pSeries feature
qemu: Implement the CFPC pSeries feature
qemu: Add capability for SBBC pSeries feature
qemu: Implement the SBBC pSeries feature
qemu: Add capability for IBS pSeries feature
qemu: Implement the IBS
with the now
implemented CFPC, exposing this feature in the XML allows for
a cleaner way for users to tune the SBBC accordingly, given
that not all hypervisor and guest setups supports this
Spectre mitigation.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_capabilities.c
finish of the
blockcopy operation. But, if something fails then we need to
explicitly revoke the access to the mirror image (and thus
reattach NVMe disk back to the host).
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1822538
Signed-off-by: Michal Privoznik
---
Reviewed-by: Daniel Henrique
On 4/13/20 11:18 AM, Nikolay Shirokovskiy wrote:
getaddrinfo returns linked list. Fix iteration accordingly.
Signed-off-by: Nikolay Shirokovskiy
---
Reviewed-by: Daniel Henrique Barboza
src/util/virsocketaddr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src
.
Let's document this behavior, which is explained in detail in
Libvirt commit v5.0.0-199-gf136b83139, in the cputune section
of formatdomain.html.in.
Signed-off-by: Daniel Henrique Barboza
---
docs/formatdomain.html.in | 7 +++
1 file changed, 7 insertions(+)
diff --git a/docs
On 4/3/20 10:21 AM, Ján Tomko wrote:
Moving the first functions seems more important than the fact that
we are introducing a new file.
qemu: move qemuDomainDefValidateFeatures to qemu_validate
On a Thursday in 2020, Daniel Henrique Barboza wrote:
While moving validations from qemu_command
Ping
On 3/26/20 6:31 PM, Daniel Henrique Barboza wrote:
This is a suggestion made by Peter in [1], in the review
discussion of a series in which I started moving qemuCaps
validation from qemu_command.c to qemu_domain.c [2]. I'll
quote here what he said back then:
"My only sugge
On 4/1/20 11:10 AM, Han Han wrote:
Signed-off-by: Han Han
---
Looks good. I'd just rename the commit to "domainsnapshot.rng: Support
encryption
and slices element" because prefixing the commit with "rng" can be misleading
with commits related to the "rng" virtio backend.
DHB
NUMA node.
Signed-off-by: Daniel Henrique Barboza
---
docs/formatdomain.html.in | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index aaeb05961f..7940d6ace5 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdoma
On 3/31/20 12:44 PM, Seeteena Thoufeek wrote:
Signed-off-by: Seeteena Thoufeek
---
Reviewed-by: Daniel Henrique Barboza
Just noticed that the commit title here is mentioning the new name of the
function
instead of the original name, qemuDomainDeviceDefValidateController().
I'll fix it in the next spin after getting some reviews.
DHB
On 3/26/20 6:31 PM, Daniel Henrique Barboza wrote:
Move the function and all
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c | 383 +--
src/qemu/qemu_validate.c | 373 ++
src/qemu/qemu_validate.h | 11 ++
3 files changed, 389 insertions(+), 378 deletions(-)
diff --git a/src/qemu
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c | 146 +--
src/qemu/qemu_validate.c | 144 ++
src/qemu/qemu_validate.h | 2 +
3 files changed, 147 insertions(+), 145 deletions(-)
diff --git a/src/qemu
This function will remain public due to its usage in qemublocktest.c
even after moving qemuDomainDeviceDefValidate(). The position of its
header in qemu_validate.h is no accident.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c | 100
The next big task is to move qemuDomainDeviceDefValidate() to
qemu_validation.c, which is a function that calls a lot of
other static helper functions. This patch starts it by moving
qemuDomainDeviceDefValidateAddress().
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c | 74
qemuDomainDefValidateFeatures() to this new file.
Signed-off-by: Daniel Henrique Barboza
---
po/POTFILES.in | 1 +
src/qemu/Makefile.inc.am | 2 +
src/qemu/qemu_domain.c | 286 +---
src/qemu/qemu_validate.c | 310 +++
src
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c | 76 +---
src/qemu/qemu_validate.c | 76
src/qemu/qemu_validate.h | 2 ++
3 files changed, 79 insertions(+), 75 deletions(-)
diff --git a/src/qemu
rted
in [2], but using qemu_validate.c instead of qemu_domain.c as
destination.
[1] https://www.redhat.com/archives/libvir-list/2019-December/msg00608.html
[2] https://www.redhat.com/archives/libvir-list/2019-December/msg00570.html
Daniel Henrique Barboza (15):
qemu: introducing qemu_validate.c/h
Move the function and all its static helper functions.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c | 804 +--
src/qemu/qemu_validate.c | 804 +++
src/qemu/qemu_validate.h | 3 +
3 files changed
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c | 119 +--
src/qemu/qemu_validate.c | 119 +++
src/qemu/qemu_validate.h | 4 ++
3 files changed, 124 insertions(+), 118 deletions(-)
diff --git a/src
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c | 98 +---
src/qemu/qemu_validate.c | 96 +++
src/qemu/qemu_validate.h | 2 +
3 files changed, 99 insertions(+), 97 deletions(-)
diff --git a/src/qemu
Now that all its helper functions are in qemu_validate.c, we can
move the function itself. The helpers can become static again since
they're all in the same file.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c | 128 +
src/qemu/qemu_validate.c
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c | 177 +--
src/qemu/qemu_validate.c | 175 ++
src/qemu/qemu_validate.h | 5 ++
3 files changed, 181 insertions(+), 176 deletions(-)
diff --git a/src/qemu
This will allow to move qemuDomainDeviceDefValidate() itself in
the next patch in a cleaner way.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c | 392 +--
src/qemu/qemu_validate.c | 376 +
src/qemu
After moving most of static functions qemuDomainValidateDef() uses,
move the last remaining static and qemuDomainValidateDef() itself
to qemu_validation.c.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c | 254 +---
src/qemu/qemu_validate.c
This function alone requires other 3 static functions to be
moved as well, thus let's move it in its own patch.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c | 190 +--
src/qemu/qemu_validate.c | 188
We're going to move qemuDomainDefValidate() to qemu_validate.c in
two steps. First steps is to finish up moving all static functions
qemuDomainDefValidate() uses, then in the next patch we can
move the function itself.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c | 394
On 3/26/20 12:47 PM, Daniel P. Berrangé wrote:
On Thu, Mar 26, 2020 at 11:22:11AM -0300, Daniel Henrique Barboza wrote:
On 3/26/20 10:10 AM, Peter Krempa wrote:
On Fri, Mar 06, 2020 at 11:44:07 +, Daniel Berrange wrote:
[...]
FYI, every time you post to this list
On 3/26/20 10:10 AM, Peter Krempa wrote:
On Fri, Mar 06, 2020 at 11:44:07 +, Daniel Berrange wrote:
We've discussed the idea of replacing our mailing list review workflow with
a merge request workflow in various places, over the last 6 months or so,
One thing I feel the need to voice
iewed-by: Daniel Henrique Barboza
equal to ppc64AlignSize.
Fixes: 5540acb9a2bd33fb97a7446a610b602c9e8629a3
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 2c9fb47d17..2c52778515 100644
--- a/src/qemu
901 - 1000 of 1918 matches
Mail list logo
