On Wed, Jan 24, 2018 at 04:14:54PM +0100, Jiri Denemark wrote:
> pushed. In other words, having Reviewed-by in the commit message is nice
> for generating statistics for KVM Forum keynotes, once the patch gets
> out of our git repository (i.e., is backported to a downstream), or when
BTW, when gen
On Wed, Jan 24, 2018 at 02:59:17PM +0100, Ján Tomko wrote:
> > > + a "Signed-off-by" line to every commit message. The presence
>
> "line containing the contributor's name and e-mail" maybe?
> I presume just 'Signed-off-by' is not enough for the "legal snake oil",
> even though it's all t
The libxl driver calls a couple of xenstorage APIs, so it must
explicitly link to this library rather than rely on indirect linkage via
libxl or other xen libraries.
Signed-off-by: Daniel P. Berrange
---
m4/virt-driver-libxl.m4 | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
Add a virtlogd-admin-sock can serves the admin protocol for the virtlogd
daemon and define a virtlogd:///{system,session} URI scheme for
connecting to it.
Signed-off-by: Daniel P. Berrange
---
src/Makefile.am | 1 +
src/libvirt-admin.c | 20 +++--
src
found int he JSON state doc.
Signed-off-by: Daniel P. Berrange
---
src/libvirt_remote.syms | 1 -
src/locking/lock_daemon.c | 41 +
src/logging/log_daemon.c | 41 +
src/rpc/virnetdaemon.c| 151 --
src/rpc/virnetdae
We don't have any per-client private data we need to persist, but the
RPC infrastructure requires that we provide the callbacks and serialize
an empty JSON object. This makes us future proof going forwards.
Signed-off-by: Daniel P. Berrange
---
src/admin/admin_server_dispatch.c
When receiving multiple socket FDs from systemd, it is critical to know
what socket address each corresponds to so we can setup the right
protocols on each.
Signed-off-by: Daniel P. Berrange
---
src/libvirt_private.syms | 1 +
src/util/virutil.c | 45
Signed-off-by: Daniel P. Berrange
---
daemon/libvirtd.c | 8
daemon/remote.c | 6 +++---
daemon/remote.h | 6 +++---
src/admin/admin_server_dispatch.c | 6 +++---
src/admin/admin_server_dispatch.h | 4 ++--
5 files changed, 15
The admin server functionality is a generic concept that should be wired
up into all libvirt daemons, but is currently integrated with the
libvirtd code. Move it all into the src/admin directory to prepare for
broader reuse.
Signed-off-by: Daniel P. Berrange
---
.gitignore
The initial admin protocol support was only integrated into libvirtd.
This series extracts that code so that it is reusable with all the
daemons we have (and more than we'll get).
In v2:
- Fixed completely broken post-exec restart support for admin servers
- Misc fixes from v1 review
Dan
Add a virtlockd-admin-sock can serves the admin protocol for the virtlockd
daemon and define a virtlockd:///{system,session} URI scheme for
connecting to it.
Signed-off-by: Daniel P. Berrange
---
cfg.mk| 1 -
src/Makefile.am | 1 +
src
rameter passing, removing the confusion of passing two
distinct 'void *' pointers to one method.
Signed-off-by: Daniel P. Berrange
---
src/rpc/virnetserver.c| 6 +++---
src/rpc/virnetserverclient.c | 14 +++---
src/rpc/virnetserverclient.h | 9 ++---
src/rpc/virnetse
The server name and client data callbacks need to be non-NULL or the
system will crash at various times. This is particularly bad when some
of the crashes only occur post-exec restart.
Signed-off-by: Daniel P. Berrange
---
src/rpc/virnetserver.h | 7 +--
src/rpc/virnetserverclient.h
It is not possible to blindly call virNetDaemonGetServer()
because in a post-exec restart scenario, some servers may
not exist and this method will pollute the error logs.
Signed-off-by: Daniel P. Berrange
---
src/libvirt_remote.syms | 1 +
src/rpc/virnetdaemon.c | 13 +
src/rpc
Signed-off-by: Daniel P. Berrange
---
src/rpc/virnetserverclient.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/src/rpc/virnetserverclient.h b/src/rpc/virnetserverclient.h
index 0fa8745191..14ace9e522 100644
--- a/src/rpc/virnetserverclient.h
+++ b/src/rpc/virnetserverclient.h
;openvz:///system", "/org/libvirt/OpenVZ" },
> +{ "qemu:///system", "/org/libvirt/QEMU" },
> +{ "test:///default","/org/libvirt/Test" },
> +{ "uml:///system", "/org/libvir
On Tue, Jan 23, 2018 at 12:37:53PM +0100, Pavel Hrdina wrote:
> On Tue, Jan 23, 2018 at 10:12:26AM +0000, Daniel P. Berrange wrote:
> > On Mon, Jan 22, 2018 at 06:16:09PM +0100, Pavel Hrdina wrote:
> > > Signed-off-by: Pavel Hrdina
> > >
On Mon, Jan 22, 2018 at 06:15:58PM +0100, Pavel Hrdina wrote:
> This patch series is a proposal to how to implement libvirt connections
> in the libvirt D-Bus binding. The design is based on a discussion with
> Daniel and it should follow D-Bus convention.
>
> Each connection is represented as ex
On Mon, Jan 22, 2018 at 06:16:09PM +0100, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> src/main.c | 26 ++
> 1 file changed, 22 insertions(+), 4 deletions(-)
>
> diff --git a/src/main.c b/src/main.c
> index 14c7c18..6421919 100644
> --- a/src/main.c
> +++ b/s
vel Hrdina
> ---
> src/connect.c | 17 +++--
> src/connect.h | 4 +++-
> src/main.c | 55
> ++---
> test/libvirttest.py | 4 ++--
> 4 files changed, 55 insertions(+), 25 deletions(-)
Reviewed-by: Daniel
> 6 files changed, 68 insertions(+), 35 deletions(-)
Reviewed-by: Daniel P. Berrange
Regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org
On Mon, Jan 22, 2018 at 06:16:05PM +0100, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> src/connect.c | 7 ++-
> src/connect.h | 2 ++
> src/domain.c | 7 +++
> 3 files changed, 11 insertions(+), 5 deletions(-)
Reviewed-by: Daniel P. Berrange
rc/events.c | 2 +-
> 3 files changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrange
Regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https
to
virConnectOpen(), so people only need to use OpenAuth() when they have
a genuine callback to provide
> Signed-off-by: Pavel Hrdina
> ---
> src/connect.c | 32 +++-
> 1 file changed, 31 insertions(+), 1 deletion(-)
Reviewed-by: Daniel P
mainEventDeregisterAny(connect->connection,
> connect->callback_ids[i]);
> -}
> -
> -virConnectClose(connect->connection);
> -}
> +if (connect->connection)
> +virtDBusConnectClose(connect, true);
>
> free(connect);
With the 1
tions(+), 6 deletions(-)
Reviewed-by: Daniel P. Berrange
Regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.in
gt; rename src/{manager.h => connect.h} (53%)
> rename test/{test_manager.py => test_connect.py} (79%)
Reviewed-by: Daniel P. Berrange
Regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fst
gt; @@ -8,6 +8,8 @@
> #define _cleanup_(_x) __attribute__((__cleanup__(_x)))
> #define VIR_ATTR_UNUSED __attribute__((__unused__))
>
> +#define VIRT_ARRAY_CARDINALITY(array) (sizeof(array) / sizeof(*(array)))
> +
>
> int
> virtDBusUtilMessageAppendTypedParameters(sd_
On Mon, Jan 22, 2018 at 06:16:00PM +0100, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> src/util.c | 7 +++
> src/util.h | 4
> 2 files changed, 11 insertions(+)
Reviewed-by: Daniel P. Berrange
Regards,
Daniel
--
|: https://berrange.com -o-https:/
could also just
> say ACK, but the R-b seems so much more authoritative.
FWIW, in emacs I have some macros that make it quick to type the long
statements, since it is so commonly needed in QEMU
(define-abbrev-table 'global-abbrev-table
'(
("8rev" "Reviewed-by: Dan
On Mon, Jan 22, 2018 at 10:25:38AM -0700, Jim Fehlig wrote:
> On 01/17/2018 08:34 AM, Guido Günther wrote:
> > Otherwise stopping domains with qemu://session fails like
> >
> > [164012.338157] audit: type=1400 audit(1516202208.784:99):
> > apparmor="DENIED" operation="signal" profile="/usr/sbin/l
On Mon, Jan 22, 2018 at 04:44:10PM +0100, Michal Privoznik wrote:
> On 01/19/2018 06:09 PM, Daniel P. Berrange wrote:
> > The initial admin protocol support was only integrated into libvirtd.
> > This series extracts that code so that it is reusable with all the
> > daemons w
On Mon, Jan 22, 2018 at 04:44:13PM +0100, Michal Privoznik wrote:
> On 01/19/2018 06:09 PM, Daniel P. Berrange wrote:
> > Add a virtlogd-admin-sock can serves the admin protocol for the virtlogd
> > daemon and define a virtlogd:///{system,session} URI scheme for
>
On Mon, Jan 22, 2018 at 03:12:46PM +0100, Jiri Denemark wrote:
> On Mon, Jan 22, 2018 at 14:01:26 +0000, Daniel P. Berrange wrote:
> > On Mon, Jan 22, 2018 at 02:54:42PM +0100, Jiri Denemark wrote:
> > > It breaks the build and it is not really useful for anything.
> >
>
On Mon, Jan 22, 2018 at 02:54:42PM +0100, Jiri Denemark wrote:
> It breaks the build and it is not really useful for anything.
Why does that break the build ? "{ 0 }" is a valid initializer for
any struct according to the C standards.
>
> Signed-off-by: Jiri Denemark
> ---
>
> Pushed under t
; This extends the update hook so that it enforces a requirement to have a
> > > > Signed-off-by line in every commit message. This can be optionally
> > > > turned off in individual repos by setting the "hooks.allowmissingsob"
> > >
On Mon, Jan 22, 2018 at 02:24:40PM +0100, Ján Tomko wrote:
> On Mon, Jan 22, 2018 at 12:42:47PM +0000, Daniel P. Berrange wrote:
> > On Mon, Jan 22, 2018 at 01:22:01PM +0100, Ján Tomko wrote:
> > > On Mon, Jan 22, 2018 at 12:05:19PM +, Daniel P. Berrange wrote:
> > >
On Mon, Jan 22, 2018 at 02:28:42PM +0100, Martin Kletzander wrote:
> On Mon, Jan 22, 2018 at 12:57:31PM +0000, Daniel P. Berrange wrote:
> > On Mon, Jan 22, 2018 at 01:54:28PM +0100, Martin Kletzander wrote:
> > > On Mon, Jan 22, 2018 at 01:47:24PM +0100, Michal Privoznik wrote
t; > turned off in individual repos by setting the "hooks.allowmissingsob"
> > git config variable.
> >
> > Signed-off-by: Daniel P. Berrange
> > ---
> > update | 16 +++-
> > 1 file changed, 15 insertions(+), 1 deletion(-)
>
> NACK, I
On Mon, Jan 22, 2018 at 01:54:28PM +0100, Martin Kletzander wrote:
> On Mon, Jan 22, 2018 at 01:47:24PM +0100, Michal Privoznik wrote:
> > On 01/22/2018 01:22 PM, Daniel P. Berrange wrote:
> > > On Mon, Jan 22, 2018 at 12:49:12PM +0100, Martin Kletzander wrote:
> > > &
contribution. This puts the project in a stronger position
should any questions around contributions be raised going forward in the
future.
Signed-off-by: Daniel P. Berrange
---
docs/hacking.html.in | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/docs/hacking.html.in b
On Mon, Jan 22, 2018 at 01:31:21PM +0100, Jiri Denemark wrote:
> On Mon, Jan 22, 2018 at 10:57:57 +0000, Daniel P. Berrange wrote:
> > On Mon, Jan 22, 2018 at 11:46:14AM +0100, Jiri Denemark wrote:
> > > Whenever a different kernel is booted, some capabilities related to KVM
&g
On Mon, Jan 22, 2018 at 01:22:01PM +0100, Ján Tomko wrote:
> On Mon, Jan 22, 2018 at 12:05:19PM +0000, Daniel P. Berrange wrote:
> > This extends the update hook so that it enforces a requirement to have a
> > Signed-off-by line in every commit message. This can be optionally
&g
On Mon, Jan 22, 2018 at 12:49:12PM +0100, Martin Kletzander wrote:
> On Thu, Jan 18, 2018 at 10:16:55AM +0100, Ján Tomko wrote:
> > After the latest CPU additions, the build fails with clang:
> > cputest.c:905:1: error: stack frame size of 26136 bytes
> > in function 'mymain' [-Werror,-Wframe-larg
This extends the update hook so that it enforces a requirement to have a
Signed-off-by line in every commit message. This can be optionally
turned off in individual repos by setting the "hooks.allowmissingsob"
git config variable.
Signed-off-by: Daniel P. Berrange
---
u
repository that contains the original git repository
update hook Eric provided years back. This commit then augments that
hook to add the Signed-off-by check. The updated hook gets automatically
installed on the server when we push to this repo.
Daniel P. Berrange (1):
Add check for Signed-off-by in
222f3368e3 100644
> --- a/src/qemu/qemu_capspriv.h
> +++ b/src/qemu/qemu_capspriv.h
> @@ -37,6 +37,7 @@ virQEMUCapsNewForBinaryInternal(virArch hostArch,
> uid_t runUid,
> gid_t runGid,
> un
The admin server functionality is a generic concept that should be wired
up into all libvirt daemons, but is currently integrated with the
libvirtd code. Move it all into the src/admin directory to prepare for
broader reuse.
Signed-off-by: Daniel P. Berrange
---
.gitignore
When receiving multiple socket FDs from systemd, it is critical to know
what socket address each corresponds to so we can setup the right
protocols on each.
Signed-off-by: Daniel P. Berrange
---
src/util/virutil.c | 45 +
src/util/virutil.h | 1 +
2
Add a virtlockd-admin-sock can serves the admin protocol for the virtlockd
daemon and define a virtlockd:///{system,session} URI scheme for
connecting to it.
Signed-off-by: Daniel P. Berrange
---
cfg.mk| 1 -
src/Makefile.am | 1 +
src
Add a virtlogd-admin-sock can serves the admin protocol for the virtlogd
daemon and define a virtlogd:///{system,session} URI scheme for
connecting to it.
Signed-off-by: Daniel P. Berrange
---
src/Makefile.am | 1 +
src/libvirt-admin.c | 20 --
src
The initial admin protocol support was only integrated into libvirtd.
This series extracts that code so that it is reusable with all the
daemons we have (and more than we'll get).
Daniel P. Berrange (4):
admin: move admins server impl/dispatch into src/admin directory
util
s/images/otubo.png | Bin 0 -> 10597 bytes
> 2 files changed, 6 insertions(+)
> create mode 100644 updater/virt-tools/images/otubo.png
Reviewed-by: Daniel P. Berrange
> diff --git a/updater/virt-tools/config.ini b/updater/virt-tools/config.ini
> index 988e572..d47e82f 100644
>
This wires up the previously added OEM strings XML schema to be able to
generate comamnd line args for QEMU. This requires QEMU >= 2.12 release
containing this patch:
commit 2d6dcbf93fb01b4a7f45a93d276d4d74b16392dd
Author: Daniel P. Berrange
Date: Sat Oct 28 21:51:36 2017 +0
A followup to
https://www.redhat.com/archives/libvir-list/2017-November/msg00720.html
The QEMU patch is now merged (for next 2.12 release).
Since v2:
- Remove redundant error message report
- Split QEMU from XML parts of patch
Daniel P. Berrange (2):
conf: add support for setting OEM
of a application specific prefix as illustrated above is
recommended, but not mandated, so that an app can reliably identify
which of the many OEM strings are targetted at it.
Signed-off-by: Daniel P. Berrange
---
docs/formatdomain.html.in | 13
docs/schemas/domaincommon.rng
On Wed, Jan 17, 2018 at 05:13:06PM +0100, Michal Privoznik wrote:
> On 01/16/2018 06:01 PM, Daniel P. Berrange wrote:
> > We read from QEMU until seeing a \r\n pair to indicate a completed reply
> > or event. To avoid memory denial-of-service though, we must have a size
> > li
On Wed, Jan 17, 2018 at 02:43:17PM +, Daniel P. Berrange wrote:
> Latest version of glib uses typeof() magic to cast the
> return value of g_object_ref to match its argument,
> instead of returning a 'void *'. A few places in the
> code were casting the arg to G_O
casts were always redundant so just
remove them.
Signed-off-by: Daniel P. Berrange
---
libvirt-gconfig/libvirt-gconfig-object.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libvirt-gconfig/libvirt-gconfig-object.c
b/libvirt-gconfig/libvirt-gconfig-object.c
index 851e35
Hi Folks,
Just let you all know that I've moved various libvirt related websites over
to hosting on Red Hat's OpenShift v3 infrastructure. With the new v3 that
is based on Kubernetes, I'm able to publish the GIT repos containing the
core content & software setup.
For wiki.libvirt.org:
https:/
On Wed, Jan 17, 2018 at 10:40:19AM +0100, Pavel Hrdina wrote:
> RHEL-6 doesn't have bash-completion package by default, it has to be
> installed from EPEL.
>
> Signed-off-by: Pavel Hrdina
> ---
> libvirt.spec.in | 10 ++
> 1 file changed, 10 insertions
guests/vars/projects/libvirt.yml | 1 +
> 2 files changed, 5 insertions(+)
Reviewed-by: Daniel P. Berrange
Regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://
uming unreasonable mem.
Signed-off-by: Daniel P. Berrange
---
src/qemu/qemu_monitor.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c
index 046caf001c..85c7d68a13 100644
--- a/src/qemu/qemu_monitor.c
+++ b/src/qemu/qemu_monitor.c
@@
On Mon, Jan 15, 2018 at 07:50:10PM +0200, Ville Skyttä wrote:
> When virDomainBlockStatsFlags with NULL params fails, the returned
> read and write requests hash keys are said to be backwards compatible
> with the key names success case. However, they were rd_reqs and
> wr_reqs (in plural) as oppos
On Mon, Jan 15, 2018 at 07:29:59PM +0200, Ville Skyttä wrote:
> ---
> Changes | 4 ++--
> HACKING | 4 ++--
> lib/Sys/Virt.pm | 6 +++---
> lib/Sys/Virt/Domain.pm | 14 +++---
> lib/Sys/Virt/Interface.pm | 2 +-
> lib/Sys/Virt/
On Mon, Jan 15, 2018 at 05:51:28PM +0100, Erik Skultety wrote:
> On Wed, Jan 10, 2018 at 12:23:29PM -0500, John Ferlan wrote:
> > Split up virThreadPoolFree to create a Drain function which will
> > be called from virNetServerClose in order to ensure the various
> > worker threads are removed durin
On Mon, Jan 15, 2018 at 02:20:01PM +0100, Andrea Bolognani wrote:
> On Mon, 2018-01-15 at 13:31 +0100, Michal Privoznik wrote:
> > > So, one way to solve this once and for all would be to:
> > >
> > > * try looking up readline through pkg-config. If that works,
> > > then we already know we'
guests/vars/mappings.yml | 4
> guests/vars/projects/libvirt.yml | 1 +
> 2 files changed, 5 insertions(+)
Reviewed-by: Daniel P. Berrange
Regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-
On Fri, Jan 12, 2018 at 05:32:32PM +0100, Pavel Hrdina wrote:
> On Fri, Jan 12, 2018 at 03:43:55PM +0000, Daniel P. Berrange wrote:
> > On Fri, Jan 12, 2018 at 12:36:23PM +0100, Pavel Hrdina wrote:
> > > On Thu, Jan 11, 2018 at 04:43:35PM +, Daniel P. Berrange wrote:
>
Note we use python_sitearch not python2_sitearch, since the former
is more portable.
Signed-off-by: Daniel P. Berrange
---
libvirt-python.spec.in | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/libvirt-python.spec.in b/libvirt-python.spec.in
er than the
python binding, since the generator may incorrectly handle new APIs. So use
== instead of >= too.
Signed-off-by: Daniel P. Berrange
---
libvirt-python.spec.in | 2 +-
setup.py | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/libvirt-pyt
Signed-off-by: Daniel P. Berrange
---
libvirt-python.spec.in | 5 +
1 file changed, 5 insertions(+)
diff --git a/libvirt-python.spec.in b/libvirt-python.spec.in
index 2dfc84a..f658496 100644
--- a/libvirt-python.spec.in
+++ b/libvirt-python.spec.in
@@ -54,7 +54,12 @@ BuildRequires: python3
It is expected that future RHEL-8 will have python3 by default, so enable that.
It is unclear whether python2 will still be available, so leave that enabled
for now.
Reviewed-by: Pavel Hrdina
Signed-off-by: Daniel P. Berrange
---
libvirt-python.spec.in | 2 +-
1 file changed, 1 insertion(+), 1
Reviewed-by: Pavel Hrdina
Signed-off-by: Daniel P. Berrange
---
libvirt-python.spec.in | 12
1 file changed, 12 insertions(+)
diff --git a/libvirt-python.spec.in b/libvirt-python.spec.in
index b667ebe..b13e961 100644
--- a/libvirt-python.spec.in
+++ b/libvirt-python.spec.in
Be clear about which distros we aim to support with the specfile, so we know
what we can cleanup in the spec later.
Signed-off-by: Daniel P. Berrange
---
libvirt-python.spec.in | 16
1 file changed, 16 insertions(+)
diff --git a/libvirt-python.spec.in b/libvirt-python.spec.in
Allow using
rpmbuild --define "with_python2 0"
to override the default logic about which python sub-RPMs to build
Reviewed-by: Pavel Hrdina
Signed-off-by: Daniel P. Berrange
---
libvirt-python.spec.in | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git
.
Signed-off-by: Daniel P. Berrange
---
libvirt-python.spec.in | 13 +
1 file changed, 13 insertions(+)
diff --git a/libvirt-python.spec.in b/libvirt-python.spec.in
index 4d0262d..5bbebeb 100644
--- a/libvirt-python.spec.in
+++ b/libvirt-python.spec.in
@@ -1,4 +1,5 @@
+%define
Daniel P. Berrange (9):
Allow disabling of python2 RPM build
Allow override of which sub-RPMs to build
Add checks for min supported distros
Add emacs mode marker to activate rpm-spec highlighting
Adapt to rename of py2 RPMs from python- to python2- prefix
Turn on python3 sub-RPMs for
Reviewed-by: Pavel Hrdina
Signed-off-by: Daniel P. Berrange
---
libvirt-python.spec.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libvirt-python.spec.in b/libvirt-python.spec.in
index a98b902..b667ebe 100644
--- a/libvirt-python.spec.in
+++ b/libvirt-python.spec.in
@@ -1,3 +1,5
On Fri, Jan 12, 2018 at 12:31:46PM +0100, Pavel Hrdina wrote:
> On Thu, Jan 11, 2018 at 04:43:37PM +0000, Daniel P. Berrange wrote:
> > Signed-off-by: Daniel P. Berrange
> > ---
> > libvirt-python.spec.in | 12
> > 1 file changed, 12 insertions(+)
>
On Fri, Jan 12, 2018 at 03:42:57PM +, Daniel P. Berrange wrote:
> On Fri, Jan 12, 2018 at 12:15:19PM +0100, Pavel Hrdina wrote:
> > On Thu, Jan 11, 2018 at 04:43:33PM +0000, Daniel P. Berrange wrote:
> > > With Fedora modularity, it is possible to have add-on repos for multi
On Fri, Jan 12, 2018 at 12:36:23PM +0100, Pavel Hrdina wrote:
> On Thu, Jan 11, 2018 at 04:43:35PM +0000, Daniel P. Berrange wrote:
> > Be clear about which distros we aim to support with the specfile, so we know
> > what we can cleanup in the spec later.
>
> Do we rea
On Fri, Jan 12, 2018 at 12:15:19PM +0100, Pavel Hrdina wrote:
> On Thu, Jan 11, 2018 at 04:43:33PM +0000, Daniel P. Berrange wrote:
> > With Fedora modularity, it is possible to have add-on repos for multiple
> > versions of python3. It is thus desirable to be able to build libvir
;
> Andrea Bolognani (2):
> guests: Fix package name for rpcgen
> guests: Make rpcgen mapping more future-proof
>
> guests/vars/mappings.yml | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrange
Seeing latest build failures thoug
On Fri, Jan 12, 2018 at 01:31:22PM +0100, Andrea Bolognani wrote:
> Since whatever is in Fedora Rawhide will end up in future Fedora
> releases, it makes sense to use the newer package as default and
> override it for existing releases (as well as CentOS), so that
> no tweaking will be needed when
On Fri, Jan 12, 2018 at 12:43:58PM +0100, Andrea Bolognani wrote:
> It would be nice to have all greens before the release :)
>
> Andrea Bolognani (2):
> travis: Sync packages with libvirt-jenkins-ci
> travis: Skip nfs-common installation
Reviewed-by: Daniel P. Berrange
On Thu, Jan 11, 2018 at 06:00:34PM +0100, Jiri Denemark wrote:
> On Thu, Jan 11, 2018 at 16:43:39 +0000, Daniel P. Berrange wrote:
> > Although we're capable of building against any libvirt >= 0.9.11, 99% of the
> > time we want RPM builds to be done against m
On Thu, Jan 11, 2018 at 04:43:37PM +, Daniel P. Berrange wrote:
> Signed-off-by: Daniel P. Berrange
> ---
> libvirt-python.spec.in | 12
> 1 file changed, 12 insertions(+)
>
> diff --git a/libvirt-python.spec.in b/libvirt-python.spec.in
> index b667ebe..c
Signed-off-by: Daniel P. Berrange
---
libvirt-python.spec.in | 12
1 file changed, 12 insertions(+)
diff --git a/libvirt-python.spec.in b/libvirt-python.spec.in
index b667ebe..cc5a5a5 100644
--- a/libvirt-python.spec.in
+++ b/libvirt-python.spec.in
@@ -18,6 +18,12 @@
%define
Although we're capable of building against any libvirt >= 0.9.11, 99% of the
time we want RPM builds to be done against matching libvirt version, otherwise
we might silently build against an unexpected/wrong version.
Signed-off-by: Daniel P. Berrange
---
libvirt-python.spec.in | 2 +-
It is expected that future RHEL-8 will have python3 by default, so enable that.
It is unclear whether python2 will still be available, so leave that enabled
for now.
Signed-off-by: Daniel P. Berrange
---
libvirt-python.spec.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
Signed-off-by: Daniel P. Berrange
---
libvirt-python.spec.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libvirt-python.spec.in b/libvirt-python.spec.in
index a98b902..b667ebe 100644
--- a/libvirt-python.spec.in
+++ b/libvirt-python.spec.in
@@ -1,3 +1,5 @@
+# -*- rpm-spec -*-
+
# This
.
Signed-off-by: Daniel P. Berrange
---
libvirt-python.spec.in | 13 +
1 file changed, 13 insertions(+)
diff --git a/libvirt-python.spec.in b/libvirt-python.spec.in
index 4d0262d..5bbebeb 100644
--- a/libvirt-python.spec.in
+++ b/libvirt-python.spec.in
@@ -1,4 +1,5 @@
+%define
Be clear about which distros we aim to support with the specfile, so we know
what we can cleanup in the spec later.
Signed-off-by: Daniel P. Berrange
---
libvirt-python.spec.in | 16
1 file changed, 16 insertions(+)
diff --git a/libvirt-python.spec.in b/libvirt-python.spec.in
Allow using
rpmbuild --define "with_python2 0"
to override the default logic about which python sub-RPMs to build
Signed-off-by: Daniel P. Berrange
---
libvirt-python.spec.in | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/libvirt-python.spec.in
Various improvements to the RPM spec to help future Fedora/RHEL maint
Daniel P. Berrange (7):
Allow disabling of python2 RPM build
Allow override of which sub-RPMs to build
Add checks for min supported distros
Add emacs mode marker to activate rpm-spec highlighting
Adapt to rename of
Update the min fedora to 25. Use a macro to record the min versions so that the
later error message is always in sync with the earlier version check. Clarify
the comment that refers to guessing of dist which does not actually happen.
Signed-off-by: Daniel P. Berrange
---
libvirt.spec.in | 12
On Thu, Jan 11, 2018 at 01:24:57PM +0100, Michal Privoznik wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1461214
>
> Since fec8f9c49af we try to use predictable file names for
> 'memory-backend-file' objects. But that made us provide full path
> to qemu when hot plugging the object while pr
On Tue, Jan 09, 2018 at 03:13:41PM +0100, Martin Kletzander wrote:
> On Wed, Dec 20, 2017 at 04:47:50PM +0000, Daniel P. Berrange wrote:
> > This introduces a new binary 'libvirt_qemu' which can be used to launch
> > guests externally from libvirtd. eg
> >
>
On Thu, Jan 11, 2018 at 12:14:21PM +, Daniel P. Berrange wrote:
> On Tue, Jan 09, 2018 at 01:43:39PM +0100, Martin Kletzander wrote:
> > I'm so sorry for not getting to this earlier. I though I'll get to this
> > over
> > the holidays, but they were ver
1 - 100 of 20618 matches
Mail list logo