[libvirt] [PATCH v2 2/2] perf: get rid of pointless virPerfGetEvent() method

The virPerfGetEvent method pointlessly checks for a NULL parameter and the range of an enum value. The whole point of using an enum is that we can avoid such checks. Just replace calls to virPerfGetEvent, with perf->events[type] array access. Signed-off-by: Daniel P. Berrange <berra...@redh

[libvirt] [PATCH v2 0/2] Simplify perf events handling a little

This was previously posted & acked here: https://www.redhat.com/archives/libvir-list/2016-December/msg00795.html but then i forgot to push it and also notice a bug in the first place. There were conflicts against current master too, so I'm reposting for new ACK.. Daniel P. Berrange (2):

Re: [libvirt] [PATCH] qemu: Fix mdev checking for VFIO support

On Wed, Apr 12, 2017 at 12:26:35PM +0200, Erik Skultety wrote: > Commit a4a39d90 added a check that checks for VFIO support with mediated > devices. The problem is that the hostdev preparing functions behave like > a fallthrough if device of that specific type doesn't exist. However, > the check

Re: [libvirt] [PATCH v4 09/14] hostdev: Maintain a driver list of active mediated devices

On Wed, Mar 22, 2017 at 04:27:37PM +0100, Erik Skultety wrote: > Keep track of the assigned mediated devices the same way we do it for > the rest of hostdevs. Methods like 'Prepare', 'Update', and 'ReAttach' > are introduced by this patch. > > Signed-off-by: Erik Skultety >

Re: [libvirt] Question about virsh domifaddr

On Tue, Apr 11, 2017 at 06:48:05AM -0700, Vinod Chegu wrote: > Hi, > > In one of our test env. the virsh domifaddr --full doesn't > provide any info about the interfaces of a live VM when the interfaces were > configured on linux bridges (DHCP is being used to IPs). This command does > return

Re: [libvirt] Determining domain job kind from job stats?

On Tue, Apr 11, 2017 at 09:49:42AM +0200, Jiri Denemark wrote: > On Mon, Apr 10, 2017 at 12:01:43 +0100, Daniel P. Berrange wrote: > > On Mon, Apr 10, 2017 at 12:58:09PM +0200, Milan Zamazal wrote: > > > I looked how the change could be implemented. Could you please help me

Re: [libvirt] [PATCH] tests: link virpcimock with utils

On Mon, Apr 10, 2017 at 01:18:05PM +0200, Michal Privoznik wrote: > On 04/10/2017 01:04 PM, Daniel P. Berrange wrote: > > On Mon, Apr 10, 2017 at 01:00:58PM +0200, Michal Privoznik wrote: > >> On 04/10/2017 09:52 AM, Pavel Hrdina wrote: > >>> In virpcimock we use s

Re: [libvirt] [PATCH] tests: link virpcimock with utils

On Mon, Apr 10, 2017 at 01:00:58PM +0200, Michal Privoznik wrote: > On 04/10/2017 09:52 AM, Pavel Hrdina wrote: > > In virpcimock we use some functions from utils so we should link > > utils library to provide required symbols. > > > > Signed-off-by: Pavel Hrdina > > --- > >

Re: [libvirt] Determining domain job kind from job stats?

On Mon, Apr 10, 2017 at 12:58:09PM +0200, Milan Zamazal wrote: > Jiri Denemark writes: > > > On Tue, Feb 21, 2017 at 15:38:22 +0100, Milan Zamazal wrote: > >> [Starting to move to the development list.] > >> > >> Milan Zamazal writes: > >> > >> > Jiri

Re: [libvirt] [PATCH v3 0/7] Provide an standard asyncio event loop impl

On Fri, Apr 07, 2017 at 06:35:54PM +0200, Wojtek Porczyk wrote: > On Fri, Apr 07, 2017 at 02:53:52PM +0200, Marek Marczykowski-Górecki wrote: > > On Fri, Apr 07, 2017 at 01:46:12PM +0200, Wojtek Porczyk wrote: > > > On Fri, Apr 07, 2017 at 10:22:38AM +0100, Daniel P. Berrange wro

Re: [libvirt] [PATCH v2 1/2] util: switch over to use keycodemapdb GIT submodule

On Fri, Apr 07, 2017 at 05:52:50PM +0200, Andrea Bolognani wrote: > On Fri, 2017-03-03 at 16:54 +0000, Daniel P. Berrange wrote: > [...] > > @@ -1,3 +1,6 @@ > >  [submodule "gnulib"] > >   path = .gnulib > >   url = git://git.sv.gnu.org/gnul

[libvirt] [PATCH 5/5] Add travis build configuration

: /bin/sh: /usr/bin/grep: Argument list too long Presumably their grep impl isn't as good as the GNU one, so this test config skips syntax-check on OS-X for now. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- .travis.ym

[libvirt] [PATCH 3/5] Fix detection of required RBD version

-off-by: Daniel P. Berrange <berra...@redhat.com> --- m4/virt-storage-rbd.m4 | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/m4/virt-storage-rbd.m4 b/m4/virt-storage-rbd.m4 index 48522a6..727bd71 100644 --- a/m4/virt-storage-rbd.m4 +++ b/m4/virt-storage-

[libvirt] [PATCH 1/5] annotate all mocked functions with noinline

a 'ATTRIBUTE_NOINLINE' annotation. This should prevent use from bit-rotting in future. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- build-aux/mock-noinline.pl | 72 + cfg.mk | 6 +++- src/internal.h

[libvirt] [PATCH 2/5] Prevent test failures with ebtables/iptables/ip6tables are missing

When running tests in a restricted container (as opposed to a full OS install), we can't assume ebtables/iptbles/ip6tables are going to be installed. We must check this and mark the tests as skipped. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- tests/networkxml2firewall

[libvirt] [PATCH 4/5] Ignore SASL deprecation warnings on OS-X

Apple have annotated all SASL functions as deprecated for unknown reasons. Since they still work, lets just ignore the warnings. If Apple finally delete the SASL functions our configure check should already catch that Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- src/inte

[libvirt] [PATCH 0/5] Enable CI build testing with Travis

the OS. So this uses Travis to get us automated testing of Ubuntu Precise & Trusty, with GCC and CLang, and OS-X with CLang. Daniel P. Berrange (5): annotate all mocked functions with noinline Prevent test failures with ebtables/iptables/ip6tables are missing Fix detection of required

Re: [libvirt] [PATCH v2 3/3] disk: Force clearing of the first 2048 bytes of device prior to mklabel

On Fri, Apr 07, 2017 at 04:27:40PM +0200, Peter Krempa wrote: > On Fri, Apr 07, 2017 at 09:52:09 -0400, John Ferlan wrote: > > https://bugzilla.redhat.com/show_bug.cgi?id=1439132 > > > > During 'matrix' testing of all possible combinations I found that if > > device is formated with "gpt" first,

Re: [libvirt] [PATCH V3] Expose resource control capabilites on cache bank

On Fri, Apr 07, 2017 at 08:07:23PM +0800, Eli Qiao wrote: > > > On Friday, 7 April 2017 at 7:06 PM, Daniel P. Berrange wrote: > > > On Fri, Apr 07, 2017 at 01:04:57PM +0200, Martin Kletzander wrote: > > > On Fri, Apr 07, 2017 at 05:47:54PM +0800, Eli Qiao wrote: >

Re: [libvirt] [PATCH v3 0/7] Provide an standard asyncio event loop impl

On Thu, Apr 06, 2017 at 10:47:48PM +0200, Wojtek Porczyk wrote: > On Tue, Apr 04, 2017 at 03:31:27PM +0100, Daniel P. Berrange wrote: > > $ python3 ./examples/event-test.py --loop=asyncio --timeout=30 > > qemu:///session > > Thank you for this update. I tested it backpor

Re: [libvirt] [PATCH v2 0/2] Use the shared keycodemap database

ping again On Fri, Mar 10, 2017 at 10:32:24AM +, Daniel P. Berrange wrote: > On Fri, Mar 03, 2017 at 04:54:33PM +0000, Daniel P. Berrange wrote: > > Changed in v2: > > > > - Fixed make syntax-check errors > > - Auto-generate man pages list

Re: [libvirt] [PATCH V3] Expose resource control capabilites on cache bank

On Fri, Apr 07, 2017 at 01:04:57PM +0200, Martin Kletzander wrote: > On Fri, Apr 07, 2017 at 05:47:54PM +0800, Eli Qiao wrote: > > > > > > The name doesn't really matter that much, 'scope' makes a bit more > > > sense, 'type' is consistent with the cache bank specification, I'm fine > > > with

Re: [libvirt] [PATCH v3 0/7] Provide an standard asyncio event loop impl

On Fri, Apr 07, 2017 at 09:31:45AM +0200, Michal Privoznik wrote: > On 04/06/2017 10:47 PM, Wojtek Porczyk wrote: > > On Tue, Apr 04, 2017 at 03:31:27PM +0100, Daniel P. Berrange wrote: > > > $ python3 ./examples/event-test.py --loop=asyncio --timeout=30 > > > qemu://

Re: [libvirt] [PATCH v3 0/7] Provide an standard asyncio event loop impl

On Thu, Apr 06, 2017 at 10:47:48PM +0200, Wojtek Porczyk wrote: > On Tue, Apr 04, 2017 at 03:31:27PM +0100, Daniel P. Berrange wrote: > > $ python3 ./examples/event-test.py --loop=asyncio --timeout=30 > > qemu:///session > > Thank you for this update. I tested it backpor

Re: [libvirt] [PATCH (RFC?)] Remove usage of __attribute__((nonnull))

On Thu, Apr 06, 2017 at 05:40:09PM +0200, Martin Kletzander wrote: > On Thu, Apr 06, 2017 at 04:27:25PM +0200, Andrea Bolognani wrote: > > On Wed, 2017-04-05 at 06:53 -0400, John Ferlan wrote: > > > > I thought that John still had a nightly coverity job running that > > > > would trigger the

Re: [libvirt] [PATCH V3] Expose resource control capabilites on cache bank

On Thu, Apr 06, 2017 at 02:46:10PM +0200, Martin Kletzander wrote: > On Thu, Apr 06, 2017 at 08:20:56PM +0800, Eli Qiao wrote: > > This patch is based on Martin's cache branch. > > > > This patch amends the cache bank capability as follow: > > > > It helps a lot if you wait for a conclusion on

Re: [libvirt] [PATCH V3] Expose resource control capabilites on cache bank

On Thu, Apr 06, 2017 at 08:20:56PM +0800, Eli Qiao wrote: > This patch is based on Martin's cache branch. > > This patch amends the cache bank capability as follow: > > > > > Why do we need to report 'type' on both bank & control elements. Are they really expected to have different

Re: [libvirt] creating stream

On Thu, Apr 06, 2017 at 03:16:44PM +0300, Vasiliy Tolstov wrote: > 2017-04-06 15:09 GMT+03:00 Daniel P. Berrange <berra...@redhat.com>: > > Hiding multiple hosts behind the libvirt API doesn't really work for the > > majority of our API objects, as the object model is designe

Re: [libvirt] creating stream

On Thu, Apr 06, 2017 at 03:09:12PM +0300, Vasiliy Tolstov wrote: > 2017-04-06 15:06 GMT+03:00 Vasiliy Tolstov : > >> We already have a fine grained access control system that can be used to > >> restrict feature access... > > > Also i don't think that libvirt access control

Re: [libvirt] creating stream

On Thu, Apr 06, 2017 at 03:06:49PM +0300, Vasiliy Tolstov wrote: > 2017-04-06 15:05 GMT+03:00 Daniel P. Berrange <berra...@redhat.com>: > > We already have a fine grained access control system that can be used to > > restrict feature access... > > > I know, but

Re: [libvirt] [PATCH V2] Expose resource control capabilites on cache bank

On Thu, Apr 06, 2017 at 08:09:35PM +0800, Eli Qiao wrote: > > > On Thursday, 6 April 2017 at 7:56 PM, Daniel P. Berrange wrote: > > > On Thu, Apr 06, 2017 at 07:32:59PM +0800, Eli Qiao wrote: > > > This patch is based on Martin's cache branch. > > > &g

Re: [libvirt] creating stream

On Thu, Apr 06, 2017 at 03:01:40PM +0300, Vasiliy Tolstov wrote: > 2017-04-06 14:59 GMT+03:00 Michal Privoznik : > > That is not going to be enough. The RPC protocol is spread among other files > > too. You really should not hook into our RPC protocol. > > > My question is

Re: [libvirt] [PATCH V2] Expose resource control capabilites on cache bank

On Thu, Apr 06, 2017 at 07:32:59PM +0800, Eli Qiao wrote: > This patch is based on Martin's cache branch. > > This patch amends the cache bank capability as follow: > > > > > > > This is still wrong per my previous comments. Regards, Daniel -- |: http://berrange.com

Re: [libvirt] [PATCH] Expose resource control capabilites on cache bank

On Thu, Apr 06, 2017 at 07:31:00PM +0800, Eli Qiao wrote: > > > On Thursday, 6 April 2017 at 5:51 PM, Daniel P. Berrange wrote: > > > On Thu, Apr 06, 2017 at 11:49:14AM +0200, Martin Kletzander wrote: > > > On Thu, Apr 06, 2017 at 04:20:06PM +0800, Eli Qiao wrote:

Re: [libvirt] [PATCH] Expose resource control capabilites on cache bank

On Thu, Apr 06, 2017 at 06:29:47PM +0800, Eli Qiao wrote: > > > On Thursday, 6 April 2017 at 6:10 PM, Daniel P. Berrange wrote: > > > On Thu, Apr 06, 2017 at 12:05:54PM +0200, Martin Kletzander wrote: > > > On Thu, Apr 06, 2017 at 10:51:44AM +0100, Daniel P. Berrange

Re: [libvirt] [PATCH] leasetime support per and

Sorry, we missed this 2nd patch posting. FYI, when sending updated versions of patches, we generally recommend to send them as a new top level thread, with 'PATCH v2' in the subject line, not as reply to the v1 patch. We find that makes it less likely to miss the second version when processing

Re: [libvirt] [PATCH] Expose resource control capabilites on cache bank

On Thu, Apr 06, 2017 at 12:05:54PM +0200, Martin Kletzander wrote: > On Thu, Apr 06, 2017 at 10:51:44AM +0100, Daniel P. Berrange wrote: > > On Thu, Apr 06, 2017 at 11:49:14AM +0200, Martin Kletzander wrote: > > > On Thu, Apr 06, 2017 at 04:20:06PM +0800, Eli Qiao wrote:

Re: [libvirt] [PATCH] Expose resource control capabilites on cache bank

On Thu, Apr 06, 2017 at 11:49:14AM +0200, Martin Kletzander wrote: > On Thu, Apr 06, 2017 at 04:20:06PM +0800, Eli Qiao wrote: > > This patch is based on Martin's cache branch. > > > > This patch amends the cache bank capability as follow: > > > > > > > > > > Either the XML is malformed,

Re: [libvirt] [PATCH (RFC?)] Remove usage of __attribute__((nonnull))

On Wed, Apr 05, 2017 at 12:38:23PM +0200, Martin Kletzander wrote: > On Wed, Apr 05, 2017 at 10:06:22AM +0100, Daniel P. Berrange wrote: > > On Tue, Apr 04, 2017 at 09:51:47PM +0200, Martin Kletzander wrote: > > > On Tue, Apr 04, 2017 at 04:10:59PM +0100, Daniel P. Berrange wro

Re: [libvirt] [PATCH (RFC?)] Remove usage of __attribute__((nonnull))

On Tue, Apr 04, 2017 at 09:51:47PM +0200, Martin Kletzander wrote: > On Tue, Apr 04, 2017 at 04:10:59PM +0100, Daniel P. Berrange wrote: > > On Tue, Mar 28, 2017 at 01:46:31PM +0200, Martin Kletzander wrote: > > > The attribute (defined as ATTRIBUTE_NONNULL) was added long ti

Re: [libvirt] [RFC PATCH 00/11] Add mdev reporting capability to the nodedev driver

On Wed, Apr 05, 2017 at 08:12:31AM +0200, Erik Skultety wrote: > On Tue, Apr 04, 2017 at 04:23:18PM +0100, Daniel P. Berrange wrote: > > On Wed, Mar 29, 2017 at 02:51:10PM +0200, Erik Skultety wrote: > > > This series enables the node device driver to report information about

Re: [libvirt] [PATCH] docs: Move news.rng out of docs/schemas

On Wed, Apr 05, 2017 at 09:56:13AM +0200, Peter Krempa wrote: > docs/schemas directory is meant for schemas which are installed on the > system. The schema for the news file does not need to be installed. > Store it along with the file it describes for simplicity. > --- > Patch for the alternative

[libvirt] [PATCH] docs: don't install news.rng file

that users of libvirt ever care about, since it is purely an internal thing to validate our website content. So rather than add news.rng to the RPM file list, this changes the make rules so that we don't install news.rng at all. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- Techn

Re: [libvirt] [RFC PATCH 00/11] Add mdev reporting capability to the nodedev driver

On Wed, Mar 29, 2017 at 02:51:10PM +0200, Erik Skultety wrote: > This series enables the node device driver to report information about the > existing mediated devices on the host. There is no device creation involved > yet. The information reported by the node device driver is split into two >

Re: [libvirt] [PATCH (RFC?)] Remove usage of __attribute__((nonnull))

On Tue, Apr 04, 2017 at 04:10:59PM +0100, Daniel P. Berrange wrote: > On Tue, Mar 28, 2017 at 01:46:31PM +0200, Martin Kletzander wrote: > > The attribute (defined as ATTRIBUTE_NONNULL) was added long time > > ago (2009), but in 2012 (commit eefb881d4683) it was disabled for &

Re: [libvirt] [PATCH (RFC?)] Remove usage of __attribute__((nonnull))

On Tue, Mar 28, 2017 at 01:46:31PM +0200, Martin Kletzander wrote: > The attribute (defined as ATTRIBUTE_NONNULL) was added long time > ago (2009), but in 2012 (commit eefb881d4683) it was disabled for > normal build, making it used only when coverity was building libvirt > or on special request.

[libvirt] [PATCH v3 0/7] Provide an standard asyncio event loop impl

using: $ python3 ./examples/event-test.py --loop=asyncio --timeout=30 qemu:///session Daniel P. Berrange (5): event-test: free opaque data when removing callbacks event-test: add timeout to exit event loop event-test: unregister callbacks & close conn on exit event-test: rename example e

[libvirt] [PATCH v3 6/7] event-test: rename example event loop impl

Use the name 'Poll' instead of 'Pure' for the event loop demo, since there's now a second pure python loop impl available. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- examples/event-test.py | 30 +++--- 1 file changed, 15 insertions(+), 15 del

[libvirt] [PATCH v3 3/7] event-test: free opaque data when removing callbacks

The pure python event loop impl has to call libvirt.virEventInvokeFreeCallback to free the event opaque data from a clean stack context Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- examples/event-test.py | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-)

[libvirt] [PATCH v3 7/7] event-test: add ability to run the asyncio event loop

The event test program '--loop' arg is modified to take the name of an event loop impl to run. eg 'event-test.py --loop asyncio' Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- examples/event-test.py | 50 +++--- 1 file chang

[libvirt] [PATCH v3 1/7] Allow for ff callbacks to be called by custom event implementations

lbacks are invoked directly from the virEventRemoveHandleFunc they > will likely deadlock in libvirt. And they did deadlock. In removeTimeout too. Now we supply a custom function to pick it from the opaque blob and fire. Signed-off-by: Wojtek Porczyk <w...@invisiblethingslab.com> Signed

[libvirt] [PATCH v3 2/7] Add asyncio event loop implementation

From: Wojtek Porczyk This is usable only on python >= 3.4 (or 3.3 with out-of-tree asyncio), however it should be harmless for anyone with older python versions. In simplest case, to have the callbacks queued on the default loop: >>> import libvirtaio >>>

[libvirt] [PATCH v3 4/7] event-test: add timeout to exit event loop

Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- examples/event-test.py | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/examples/event-test.py b/examples/event-test.py index 851c09b..751a140 100755 --- a/examples/event-test.py +++ b/examples/event-t

[libvirt] [PATCH v3 5/7] event-test: unregister callbacks & close conn on exit

In order to test cleanup code paths we must unregister all callbacks and close the connection on shutdown. Since cleanup happens in the background, we do a short sleep to allow the main loop to run its cleanup too. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- examples

Re: [libvirt] [PATCH v2 2/2] Add asyncio event loop implementation

On Fri, Mar 17, 2017 at 02:35:53PM +0100, Wojtek Porczyk wrote: > This is usable only on python >= 3.4 (or 3.3 with out-of-tree asyncio), > however it should be harmless for anyone with older python versions. > > In simplest case, to have the callbacks queued on the default loop: > > >>>

Re: [libvirt] [PATCH v3.2-maint 0/2] Maintenance branch details

On Tue, Apr 04, 2017 at 03:46:36PM +0200, Martin Kletzander wrote: > So I just created v3.2-maint with one rather important back-port. > This is what I would've pushed with it, but I'd rather know the > opinions on whether one or both ideas are stupid. Thanks. So, the website only publishes

Re: [libvirt] [PATCH] libvirt_public.syms: Fix virDomainSetBlockThreshold placement

On Tue, Apr 04, 2017 at 11:59:20AM +0200, Michal Privoznik wrote: > On 04/04/2017 11:56 AM, Daniel P. Berrange wrote: > > On Tue, Apr 04, 2017 at 09:42:47AM +0200, Michal Privoznik wrote: > > > On 04/04/2017 09:27 AM, Jiri Denemark wrote: > > > > On Tue, Apr 04,

Re: [libvirt] [PATCH v2 2/2] Add asyncio event loop implementation

On Fri, Mar 17, 2017 at 02:35:53PM +0100, Wojtek Porczyk wrote: > +class Callback(object): > +'''Base class for holding callback > + > +:param virEventAsyncIOImpl impl: the implementation in which we run > +:param cb: the callback itself > +:param opaque: the opaque tuple passed

Re: [libvirt] [PATCH v2 0/2] libvirt-python: libvirtaio

On Fri, Mar 24, 2017 at 09:25:11PM +0100, Wojtek Porczyk wrote: > On Fri, Mar 17, 2017 at 02:35:15PM +0100, Wojtek Porczyk wrote: > > This is second attempt at merging libvirtaio, an event loop implementation > > which dispatches the callbacks via asyncio's event loop. > > Hi, libvirt-list, > >

Re: [libvirt] [PATCH 2/2] Split out -Wframe-larger-than warning from WARN_CLFAGS

On Tue, Apr 04, 2017 at 12:57:59PM +0200, Ján Tomko wrote: > Introduce STRICT_FRAME_LIMIT_CFLAGS that will be used for > the library code and RELAXED_FRAME_LIMIT_CFLAGS for daemon code > and the test code. > > Raising the limit for tests allows building them with clang > with optimizations

Re: [libvirt] [PATCH] libvirt_public.syms: Fix virDomainSetBlockThreshold placement

On Tue, Apr 04, 2017 at 09:42:47AM +0200, Michal Privoznik wrote: > On 04/04/2017 09:27 AM, Jiri Denemark wrote: > > On Tue, Apr 04, 2017 at 09:24:41 +0200, Michal Privoznik wrote: > > > The symbol was introduced in the 3.2.0 release (bb09798fbeb5f) > > > and not 3.1.0 release as its current

Re: [libvirt] [PATCH] libvirt_public.syms: Fix virDomainSetBlockThreshold placement

On Tue, Apr 04, 2017 at 09:27:42AM +0200, Jiri Denemark wrote: > On Tue, Apr 04, 2017 at 09:24:41 +0200, Michal Privoznik wrote: > > The symbol was introduced in the 3.2.0 release (bb09798fbeb5f) > > and not 3.1.0 release as its current placement in the file > > suggests. > > > > Signed-off-by:

Re: [libvirt] [PATCH] news.rng: work around a bug in old libxml2

On Tue, Apr 04, 2017 at 09:12:11AM +0200, Peter Krempa wrote: > On Tue, Apr 04, 2017 at 09:05:58 +0200, Ján Tomko wrote: > > Similar to commit c3c2cc6, use a literal newsline instead of \n > > inside the brackets. > > --- > > Pushed as a build fix. > > This is ugly. How about dropping support for

Re: [libvirt] [PATCH 2/2] news: Allow empty elements

On Thu, Mar 30, 2017 at 03:45:27PM +0200, Andrea Bolognani wrote: > Creating dummy elements was a workaround for the > HTML DTD not allowing empty elements, but we can do > better by tweaking the the XSLT stylesheet. > --- > docs/news-html.xsl| 8 +--- > docs/news.xml | 9

Re: [libvirt] [libvirt-perl][PATCH 2/3] Add virDomainSetBlockThreshold API

On Wed, Mar 29, 2017 at 03:56:28PM +0200, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > Changes| 1 + > Virt.xs| 12 > lib/Sys/Virt/Domain.pm | 9 + > 3 files changed, 22 insertions(+) > > diff --git

Re: [libvirt] [libvirt-perl][PATCH 3/3] Add VIR_MIGRATE_TLS constant

On Wed, Mar 29, 2017 at 03:56:29PM +0200, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > Changes| 1 + > Virt.xs| 1 + > lib/Sys/Virt/Domain.pm | 7 +++ > 3 files changed, 9 insertions(+) ACK Regards, Daniel -- |:

Re: [libvirt] [libvirt-perl][PATCH 1/3] Add block threshold event

On Wed, Mar 29, 2017 at 03:56:27PM +0200, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > Changes| 1 + > Virt.xs| 48 > lib/Sys/Virt/Domain.pm | 6 ++ >

Re: [libvirt] [PATCH] storage: Fix capacity value for LUKS encrypted volumes

On Fri, Mar 24, 2017 at 10:56:38AM -0400, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1371892 > > The 'capacity' value (e.g. guest logical size) for a LUKS volume is > smaller than the 'physical' value of the file in the file system, so > we need to account for that. > >

Re: [libvirt] [PATCH 00/11] storage: modularize the storage driver backends

On Wed, Feb 08, 2017 at 05:27:00PM +0100, Peter Krempa wrote: > Split up the storage driver backends into loadable modules so that > binary distributions don't have to compromise on shipping the storage > driver with all backends which may pull in too many dependencies. BTW, it has been 9 years

Re: [libvirt] [RFC] finegrained disk driver options control

On Mon, Mar 20, 2017 at 11:11:42AM +0300, Denis V. Lunev wrote: > On 03/18/2017 12:59 PM, Daniel P. Berrange wrote: > > On Thu, Mar 16, 2017 at 08:31:08PM +0300, Denis V. Lunev wrote: > >> On 03/16/2017 05:45 PM, Daniel P. Berrange wrote: > >>> On Thu, Mar 16, 201

Re: [libvirt] [RFC] finegrained disk driver options control

On Thu, Mar 16, 2017 at 08:31:08PM +0300, Denis V. Lunev wrote: > On 03/16/2017 05:45 PM, Daniel P. Berrange wrote: > > On Thu, Mar 16, 2017 at 05:08:57PM +0300, Denis V. Lunev wrote: > >> Hello, All! > >> > >> There is a problem in the current libvirt im

Re: [libvirt] [RFC] finegrained disk driver options control

On Thu, Mar 16, 2017 at 05:26:26PM +0100, Kevin Wolf wrote: > Am 16.03.2017 um 16:52 hat Daniel P. Berrange geschrieben: > If you don't care about that at all, the optimal configuration in terms > of performance is to give qemu a cache large enough that the metadata of > the whol

Re: [libvirt] [PATCH 0/3] log|lock daemon: Don't spam logs with IO error messages after client disconnects

On Fri, Mar 17, 2017 at 04:48:48PM +0100, Peter Krempa wrote: > See patch 3 for explanation > > Peter Krempa (3): > rpc: socket: Add possibility to suppress errors on read hangup > rpc: serverclient: Add option to suppress errors on EOF > (log|lock)daemon: Don't spam logs with IO error

Re: [libvirt] [PATCH 3/3] (log|lock)daemon: Don't spam logs with IO error messages after client disconnects

On Fri, Mar 17, 2017 at 04:48:51PM +0100, Peter Krempa wrote: > The log and lock protocol don't have an extra handshake to close the > connection. Instead they just close the socket. Unfortunately that > resulted into a lot of spurious garbage logged to the system log files: > > 2017-03-17

Re: [libvirt] [PATCH 1/3] rpc: socket: Add possibility to suppress errors on read hangup

On Fri, Mar 17, 2017 at 04:48:49PM +0100, Peter Krempa wrote: > In some cases a read error due to connection hangup is expected. This > patch adds a flag that removes the logging of a virError in such case. > --- > src/rpc/virnetsocket.c | 33 +++-- >

Re: [libvirt] [PATCH 11/19] util: new functions virNetDev(Save|Read|Set)NetConfig()

On Fri, Mar 17, 2017 at 03:40:33PM +0100, Michal Privoznik wrote: > On 03/17/2017 02:58 PM, Laine Stump wrote: > > > > Why JSON rather than XML though? I don't have a real preference over one > > or the other, but libvirt lore is *steeped* in XML, and all the other > > libvirt config files are

Re: [libvirt] [PATCH v1 2/2] Add asyncio event loop implementation

On Fri, Mar 17, 2017 at 02:16:37AM +0100, Wojtek Porczyk wrote: > This is usable only on python >= 3.4 (or 3.3 with out-of-tree asyncio), > however it should be harmless for anyone with older python versions. > > In simplest case, to have the callbacks queued on the default loop: > > >>>

Re: [libvirt] libvirtaio: libvirt-python asyncio event impl

On Thu, Mar 16, 2017 at 06:24:46PM +0100, Wojtek Porczyk wrote: > On Thu, Mar 16, 2017 at 04:38:23PM +0000, Daniel P. Berrange wrote: > > On Thu, Mar 16, 2017 at 05:30:40PM +0100, Wojtek Porczyk wrote: > > > Hello, libvirt-list, > > > > > > I wrote an even

Re: [libvirt] limit cpu speed in domain xml

On Thu, Mar 16, 2017 at 08:41:48PM +0300, Vasiliy Tolstov wrote: > Thanks! Next question, does it possible to provide constant speed for vps > in case of cloud service? For example user buy vps with 500mhz or 1ghz and > pay for guaranteed resource? IMHO that's a pretty poor way to

Re: [libvirt] [GSOC] project libvirt fuzzing

On Tue, Mar 07, 2017 at 12:27:58AM -0500, D L wrote: > On Sun, Mar 5, 2017 at 2:47 AM, Michal Privoznik wrote: > Regarding fuzzing, I think we can try several fuzzing tools to run in > parallel, as different > fuzzers tend to find different kinds of bugs. Thus, AFL (American

Re: [libvirt] [PATCH v2] apparmor: allow /usr/lib/qemu/qemu-bridge-helper

On Thu, Mar 16, 2017 at 05:48:47PM +0100, Guido Günther wrote: > This is where e.g. Debian puts it. > --- > This adds lib64 as Dan suggested and also adds these two dirs to the > second invocations to make things actually work. > > examples/apparmor/usr.sbin.libvirtd | 4 ++-- > 1 file changed,

Re: [libvirt] libvirtaio: libvirt-python asyncio event impl

On Thu, Mar 16, 2017 at 05:30:40PM +0100, Wojtek Porczyk wrote: > Hello, libvirt-list, > > I wrote an event implementation wrapping an asyncio event loop [1]. > I would like to contribute it back to libvirt-python, to be offered > alongside the Default Impl in C. > > [1]

Re: [libvirt] [PATCH] apparmor: allow /usr/lib/qemu/qemu-bridge-helper

On Thu, Mar 16, 2017 at 04:53:28PM +0100, Guido Günther wrote: > This is where e.g. Debian puts it. > --- > examples/apparmor/usr.sbin.libvirtd | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/examples/apparmor/usr.sbin.libvirtd > b/examples/apparmor/usr.sbin.libvirtd >

Re: [libvirt] [RFC] finegrained disk driver options control

On Thu, Mar 16, 2017 at 04:35:36PM +0100, Kevin Wolf wrote: > Am 16.03.2017 um 16:08 hat Daniel P. Berrange geschrieben: > > On Thu, Mar 16, 2017 at 06:00:46PM +0300, Denis V. Lunev wrote: > > > On 03/16/2017 05:45 PM, Daniel P. Berrange wrote: > > > > On Thu, Ma

Re: [libvirt] [RFC] finegrained disk driver options control

On Thu, Mar 16, 2017 at 06:15:27PM +0300, Denis V. Lunev wrote: > On 03/16/2017 06:08 PM, Daniel P. Berrange wrote: > > On Thu, Mar 16, 2017 at 06:00:46PM +0300, Denis V. Lunev wrote: > >> On 03/16/2017 05:45 PM, Daniel P. Berrange wrote: > >>> On Thu, Mar 16, 201

Re: [libvirt] [RFC] finegrained disk driver options control

On Thu, Mar 16, 2017 at 06:00:46PM +0300, Denis V. Lunev wrote: > On 03/16/2017 05:45 PM, Daniel P. Berrange wrote: > > On Thu, Mar 16, 2017 at 05:08:57PM +0300, Denis V. Lunev wrote: > >> Hello, All! > >> > >> There is a problem in the current libvirt im

Re: [libvirt] [RFC] finegrained disk driver options control

On Thu, Mar 16, 2017 at 05:08:57PM +0300, Denis V. Lunev wrote: > Hello, All! > > There is a problem in the current libvirt implementation. domain.xml > allows to specify only basic set of options, especially in the case > of QEMU, when there are really a lot of tweaks in format drivers. > Most

Re: [libvirt] [PATCH v3 14/15] docs: Document the new hostdev and address type 'mdev'

On Thu, Mar 16, 2017 at 01:21:18PM +0100, Erik Skultety wrote: > Signed-off-by: Erik Skultety > --- > docs/formatdomain.html.in | 46 -- > 1 file changed, 40 insertions(+), 6 deletions(-) We need some docs somewhere decsribing how

Re: [libvirt] [PATCH] Report what TLS priority string we use for a session

On Thu, Mar 16, 2017 at 11:30:16AM +0100, Michal Privoznik wrote: > On 03/15/2017 07:05 PM, Daniel P. Berrange wrote: > > Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > > --- > > src/rpc/virnettlscontext.c | 1 + > > 1 file changed, 1 insertion

Re: [libvirt] [PATCH] remote: Make Upper limit on list of memory parameters to 64

On Thu, Mar 16, 2017 at 04:23:51PM +0530, Nitesh Konkar wrote: > 'virsh perf domain' errors out as the number of perf > events now exceeds the previous memory parameter limit > of 16. The fix is to set it to 64, as the upper limit > on list of perf events, is also set to the same. This makes no

Re: [libvirt] [PATCH] Increase default file handle limits for daemons

On Wed, Mar 15, 2017 at 07:34:04PM +0100, Guido Günther wrote: > Hi, > On Wed, Mar 15, 2017 at 04:55:04PM +, Daniel P. Berrange wrote: > > Linux still defaults to a 1024 open file handle limit. This causes > > scalability problems for libvirtd / virtlockd / virtlogd on lar

Re: [libvirt] limit cpu speed in domain xml

On Thu, Mar 16, 2017 at 12:14:31AM +0300, Vasiliy Tolstov wrote: > Hi. Does it possible to limit vm cpu speed for example to 1Ghz or 500Mhz ? > I need to simulate some hardware with specific cpu speed and test my > application inside this vm , i want to measure results from each test > and need

Re: [libvirt] Failure to probe cpu definitions for e.g. qemu-system-mips

On Wed, Mar 15, 2017 at 06:48:56PM +0100, Guido Günther wrote: > Hi, > while looking into a regression failing to start any mips qemu systems > (http://bugs.debian.org/854125) I noticed that querying cpu definition > does not work for lots of non intel architectures like mips due to lack > of

[libvirt] [PATCH] Short circuit SASL auth when no mechanisms are available

If the SASL config does not have any mechanisms we currently just report an empty list to the client which will then fail to identify a usable mechanism. This is a server config error, so we should fail immediately on the server side. Signed-off-by: Daniel P. Berrange <berra...@redhat.

[libvirt] [PATCH] Report what TLS priority string we use for a session

Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- src/rpc/virnettlscontext.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/rpc/virnettlscontext.c b/src/rpc/virnettlscontext.c index 847d457..0d5928e 100644 --- a/src/rpc/virnettlscontext.c +++ b/src/rpc/virnettlscon

[libvirt] [PATCH] Sanity check explicit TLS file paths

When providing explicit x509 cert/key paths in libvirtd.conf, the user must provide all three. If one or more is missed, this leads to obscure errors at runtime when negotiating the TLS session Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- daemon/libvirtd.c | 16 +

[libvirt] [PATCH] Increase default file handle limits for daemons

Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- daemon/libvirtd.service.in | 7 +-- src/locking/virtlockd.service.in | 4 src/logging/virtlogd.service.in | 5 + 3 files changed, 14 insertions(+), 2 deletions(-) diff --git a/daemon/libvirtd.service.in b/daemon/libvirtd.

Re: [libvirt] [PATCH v3 17/18] util: Alter virNodeDevice{Create|Delete}Vport to use nodedev APIs

On Fri, Mar 10, 2017 at 04:10:49PM -0500, John Ferlan wrote: > If we have a connection pointer there's no sense walking through the > sysfs in order to create/destroy the vHBA. Instead, let's make use of > the node device create/destroy API's. In general we should *not* call out to the public API

Re: [libvirt] [PATCH resend V10 03/12] Resctrl: Add new xml element to support cache tune

On Wed, Mar 15, 2017 at 03:11:26PM +0100, Martin Kletzander wrote: > On Mon, Mar 06, 2017 at 06:06:32PM +0800, Eli Qiao wrote: > > This patch adds new xml element to support cache tune as: > > > > > > ... > > > Again, this was already discussed, probably, I just can't find the > source of

Re: [libvirt] [BUG] mlock support breakage

On Mon, Mar 13, 2017 at 02:08:30PM -0400, Luiz Capitulino wrote: > On Mon, 13 Mar 2017 13:53:33 -0400 > Luiz Capitulino wrote: > > > OK, you're right. I personally don't like we're putting a random cap > > on QEMU memory allocations, but if it's large enough it shouldn't

<    4   5   6   7   8   9   10   11   12   13   >