Re: [libvirt] [PATCH v2 2/2] tools: do not report unknown guests in print_guests_shutdown

2018-04-23 Thread Dariusz Gadomski
check what guest_name > returned and only print a report on valid content. > > Signed-off-by: Christian Ehrhardt <christian.ehrha...@canonical.com> > --- > tools/libvirt-guests.sh.in | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > Reviewed-by: Dariusz Gadom

Re: [libvirt] [PATCH] tools: fix check_guests_shutdown loop

2018-04-17 Thread Dariusz Gadomski
xes: 7e476356 "tools: fix variable scope in in check_guests_shutdown" > Fixes: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1764668 > > Signed-off-by: Christian Ehrhardt <christian.ehrha...@canonical.com> > --- > tools/libvirt-guests.sh.in | 4 ++-- > 1 fi

[libvirt] [PATCH] tools: avoid text spilling into variables

2018-01-16 Thread Dariusz Gadomski
From: Christian Ehrhardt While libvirt-guests.sh is running cases can let guest_is_on fail which causes check_guests_shutdown to print output. That output shall not spill into the users of function check_guests_shutdown which is therefore now returning values in