Re: [PATCH v2 3/5] qemu_passt: Make passt report errors to stderr whenever possible

2023-02-16 Thread David Gibson
m logger. But we are > >> interested > >> + * into errors too. Make it print errors onto stderr. */ > > > > s/into/in the/ ? > > Honestly, I have no idea. I'm not a native speaker. I am, and "in the" definitely seems more correct here. > Ma

Re: [PATCH RFC v2 00/13] IOMMUFD Generic interface

2022-09-26 Thread David Gibson
t > can't be restricted from creating multiple containers. Thanks, .. and it absolutely will create multiple containers (i.e. open /dev/vfio/vfio multiple times) if there are multiple guest-side vIOMMU domains. It can, however, open each /dev/vfio/NN group file only once each, since they are exclusive acce

Re: [PATCH] target/ppc: Remove "compat" property of server class POWER CPUs

2020-12-01 Thread David Gibson
mily_class(PowerPCCPUClass *pcc) > { > ObjectClass *oc = OBJECT_CLASS(pcc); > @@ -10905,8 +10848,6 @@ static void ppc_cpu_class_init(ObjectClass *oc, void > *data) > device_class_set_parent_reset(dc, ppc_cpu_reset, >parent_reset); > > cc->class_by_name = ppc

Re: [PATCH] pci: Refuse to hotplug PCI Devices when the Guest OS is not ready

2020-10-26 Thread David Gibson
epared to handle errors on PCI hotplug path. There can be unarguable reasons for PCI hotplug to fail as well (attempting to plug to a bus that can't support it for one). The difference here is that it's a failure that we expect to be transitory. -- David Gibson Principal Software Engineer, Virtualization, Red Hat pgpnAv0PoDCpt.pgp Description: OpenPGP digital signature

Re: [RFC PATCH] docs/system/deprecated: mark ppc64abi32-linux-user for deprecation

2020-09-05 Thread David Gibson
On Fri, Sep 04, 2020 at 05:51:40PM +0100, Alex Bennée wrote: > It's buggy and we are not sure anyone uses it. > > Cc: David Gibson > Cc: Richard Henderson > Signed-off-by: Alex Bennée Acked-by: David Gibson > --- > docs/system/deprecated.rst | 9 + > 1 fi

Re: [PATCH v5] numa: forbid '-numa node,mem' for 5.1 and newer machine types

2020-06-09 Thread David Gibson
be used instead of disabled option > with new machine types. > > Signed-off-by: Igor Mammedov > Reviewed-by: Michal Privoznik > Reviewed-by: Michael S. Tsirkin > Reviewed-by: Greg Kurz ppc parts Acked-b: David Gibson > --- > v1: > - rebased on top of current master

Re: [PATCH v1 1/8] docs: documentation and schema for the new TPM Proxy device

2020-05-12 Thread David Gibson
On Wed, May 13, 2020 at 10:06:23AM +1000, David Gibson wrote: > On Tue, May 12, 2020 at 01:29:43PM -0300, Daniel Henrique Barboza wrote: > > > > > > On 5/11/20 8:50 AM, Daniel Henrique Barboza wrote: > > > > > > > > > On 5/11/20 8:28 AM, Daniel

Re: [PATCH v1 1/8] docs: documentation and schema for the new TPM Proxy device

2020-05-12 Thread David Gibson
-0300, Daniel Henrique Barboza wrote: > > > > > > > > > > > > On 5/11/20 6:57 AM, Daniel P. Berrangé wrote: > > > > > On Mon, May 11, 2020 at 11:22:57AM +1000, David Gibson wrote: > > > > [...] > [...] > > > > > > Currently libvirt only allow

Re: [PATCH v1 2/8] qemu: Extend QEMU capabilities with 'spapr-tpm-proxy'

2020-05-10 Thread David Gibson
esdata/caps_4.2.0.ppc64.xml > > +++ b/tests/qemucapabilitiesdata/caps_4.2.0.ppc64.xml > > @@ -184,6 +184,7 @@ > > > > > > > > + > > 4001050 > > 0 > > 42900242 > > diff --git a/tests/qemucapabilitiesdata/caps_

Re: [PATCH v1 1/8] docs: documentation and schema for the new TPM Proxy device

2020-05-10 Thread David Gibson
going on by the tpm-proxy device? If not, why not use > passthrough with /dev/tpmrm0? It's a different guest side interface, the H_TPM_COMM hypercall instead of the other PAPR TPM interface. To which "why?" is a very good question, but it's there now, so there's not much we

Re: [PATCH v1 1/8] docs: documentation and schema for the new TPM Proxy device

2020-05-10 Thread David Gibson
; > diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng > > index 9d60b090f3..44bbd92244 100644 > > --- a/docs/schemas/domaincommon.rng > > +++ b/docs/schemas/domaincommon.rng > > @@ -4676,6 +4676,23 @@ > > > > > > + > > + > > + > > + > > +

Re: [PATCH v1 3/4] qemu_domain.c: do not launch ppc64 guests with 'pmu' setting

2020-03-23 Thread David Gibson
already. > > David, what's your opinion on the matter? You're correct. The difference originates at the hardware level. On x86 the host always "owns" the PMU, and it requires explicit work in KVM to make it available to the guest. On POWER, the guest owns t

Re: [libvirt] [PATCH v2 82/86] numa: forbid '-numa node, mem' for 5.0 and newer machine types

2020-01-16 Thread David Gibson
On Wed, Jan 15, 2020 at 04:07:37PM +0100, Igor Mammedov wrote: > Deprecation period is ran out and it's a time to flip the switch > introduced by cd5ff8333a. > Disable legacy option for new machine types and amend documentation. > > Signed-off-by: Igor Mammedov ppc parts Acked-b

Re: [libvirt] [PATCH] SpaprVio addresses are 32-bit, not 64-bit

2019-06-30 Thread David Gibson
On Fri, Jun 14, 2019 at 01:45:24PM +0200, Andrea Bolognani wrote: > On Tue, 2019-06-04 at 11:38 +1000, David Gibson wrote: > > spapr-vio addresses are used on POWER platform qemu guests, which are based > > on the PAPR specification. PAPR specifies a number of virtual devices (but

[libvirt] [PATCH] SpaprVio addresses are 32-bit, not 64-bit

2019-06-03 Thread David Gibson
, any attempt to use a value here > 0x would always have failed in any case, this will just make it fail earlier and more clearly. Signed-off-by: David Gibson --- src/conf/device_conf.c | 2 +- src/conf/device_conf.h | 2 +- src/conf/domain_conf.c | 2 +- src/q

Re: [libvirt] [PATCH v4 1/2] qemu_domain: NVLink2 bridge detection function for PPC64

2019-04-03 Thread David Gibson
ink2 > > + * bridge. > > + */ > > +static bool > > +ppc64VFIODeviceIsNV2Bridge(const char *device) > > +{ > > +const char *nvlink2Files[] = {"ibm,gpu", "ibm,nvlink", > > + "ibm,nvlink-speed"

Re: [libvirt] [PULL v2 05/43] hw/timer/sun4v-rtc: Convert from DPRINTF() macro to trace events

2018-10-25 Thread David Gibson
> "CMSDK APB dualtimer write: offset 0x%" PRIx64 " data 0x%" PRIx64 " size %u" > cmsdk_apb_dualtimer_reset(void) "CMSDK APB dualtimer: reset" > > +# hw/timer/sun4v-rtc.c > +sun4v_rtc_read(uint64_t addr, uint64_t value) "read: addr 0x%" P

Re: [libvirt] [PULL 45/45] numa: Clean up error reporting in parse_numa()

2018-10-23 Thread David Gibson
oid parse_numa_opts(MachineState *ms) > { > -if (qemu_opts_foreach(qemu_find_opts("numa"), parse_numa, ms, NULL)) { > -exit(1); > -} > +qemu_opts_foreach(qemu_find_opts("numa"), parse_numa, ms, _fatal); > } >

Re: [libvirt] [PULL 12/45] hw/mips/gt64xxx_pci: Mark as bridge device

2018-10-23 Thread David Gibson
wed-by: Cédric Le Goater > Message-Id: <20181002212522.23303-9-f4...@amsat.org> > Signed-off-by: Eduardo Habkost Reviewed-by: David Gibson > --- > hw/mips/gt64xxx_pci.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/mips/gt64xxx_pci.c b/hw/mips/gt64xxx_pci

Re: [libvirt] [PULL 15/45] hw/hppa/dino: Remove unuseful code

2018-10-23 Thread David Gibson
On Thu, Oct 18, 2018 at 05:03:52PM -0300, Eduardo Habkost wrote: > From: Philippe Mathieu-Daudé > > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Thomas Huth > Message-Id: <20181002212522.23303-12-f4...@amsat.org> > Signed-off-by: Eduardo Habkost R

Re: [libvirt] [PULL 08/45] hw/ssi/xilinx_spi: Use DeviceState::realize rather than SysBusDevice::init

2018-10-23 Thread David Gibson
Goater > Message-Id: <20181002212522.23303-5-f4...@amsat.org> > Signed-off-by: Eduardo Habkost Reviewed-by: David Gibson > --- > hw/ssi/xilinx_spi.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/hw/ssi/xilinx_spi.c b/hw/ssi/xi

Re: [libvirt] [PULL 14/45] hw/alpha/typhoon: Remove unuseful code

2018-10-23 Thread David Gibson
On Thu, Oct 18, 2018 at 05:03:51PM -0300, Eduardo Habkost wrote: > From: Philippe Mathieu-Daudé > > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Thomas Huth > Message-Id: <20181002212522.23303-11-f4...@amsat.org> > Signed-off-by: Eduardo Habkost R

Re: [libvirt] [PULL 42/45] net: stellaris_enet: convert SysBus init method to a realize method

2018-10-23 Thread David Gibson
63803.22330-10-...@kaod.org> > Signed-off-by: Eduardo Habkost Reviewed-by: David Gibson > --- > hw/net/stellaris_enet.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/hw/net/stellaris_enet.c b/hw/net/stellaris_enet.c > index 165562d788

Re: [libvirt] [PULL 40/45] net: opencores_eth: convert SysBus init method to a realize method

2018-10-23 Thread David Gibson
t; > Acked-by: Max Filippov > Signed-off-by: Eduardo Habkost Reviewed-by: David Gibson > --- > hw/net/opencores_eth.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/hw/net/opencores_eth.c b/hw/net/opencores_eth.c > index d42b79c08c..d6f54

Re: [libvirt] [PULL 09/45] hw/sh4/sh_pci: Use DeviceState::realize rather than SysBusDevice::init

2018-10-23 Thread David Gibson
amsat.org> > Reviewed-by: Peter Maydell > Signed-off-by: Eduardo Habkost Reviewed-by: David Gibson > --- > hw/sh4/sh_pci.c | 20 +--- > 1 file changed, 9 insertions(+), 11 deletions(-) > > diff --git a/hw/sh4/sh_pci.c b/hw/sh4/sh_pci.c > index 4ec2e35500..3

Re: [libvirt] [PULL 10/45] hw/pci-host/bonito: Use DeviceState::realize rather than SysBusDevice::init

2018-10-23 Thread David Gibson
amsat.org> > Reviewed-by: Peter Maydell > Signed-off-by: Eduardo Habkost Reviewed-by: David Gibson > --- > hw/pci-host/bonito.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/hw/pci-host/bonito.c b/hw/pci-host/bonito.c > index 9868e2eccc

Re: [libvirt] [PULL 41/45] net: smc91c111: convert SysBus init method to a realize method

2018-10-23 Thread David Gibson
On Thu, Oct 18, 2018 at 05:04:18PM -0300, Eduardo Habkost wrote: > From: Cédric Le Goater > > Signed-off-by: Cédric Le Goater > Message-Id: <20181001063803.22330-9-...@kaod.org> > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Eduardo Habkost Reviewed-by: David

Re: [libvirt] [PULL 38/45] net: milkymist_minimac2: convert SysBus init method to a realize method

2018-10-23 Thread David Gibson
; > Acked-by: Michael Walle > Signed-off-by: Eduardo Habkost Reviewed-by: David Gibson > --- > hw/net/milkymist-minimac2.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/hw/net/milkymist-minimac2.c b/hw/net/milkymist-minimac2.c >

Re: [libvirt] [PULL 34/45] net: etraxfs_eth: convert SysBus init method to a realize method

2018-10-23 Thread David Gibson
Mathieu-Daudé > Signed-off-by: Eduardo Habkost Reviewed-by: David Gibson > --- > hw/net/etraxfs_eth.c | 13 ++--- > 1 file changed, 6 insertions(+), 7 deletions(-) > > diff --git a/hw/net/etraxfs_eth.c b/hw/net/etraxfs_eth.c > index a6932432b1..64ab3df1ae 100644 > ---

Re: [libvirt] [PULL 39/45] net: mipsnet: convert SysBus init method to a realize method

2018-10-23 Thread David Gibson
.@kaod.org> > Signed-off-by: Eduardo Habkost Reviewed-by: David Gibson > --- > hw/net/mipsnet.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/hw/net/mipsnet.c b/hw/net/mipsnet.c > index 5a63df7ccb..03b3104278 100644 > --- a/hw/net/mi

Re: [libvirt] [PULL 44/45] net: xgmac: convert SysBus init method to a realize method

2018-10-23 Thread David Gibson
hieu-Daudé > Message-Id: <20181001063803.22330-12-...@kaod.org> > Signed-off-by: Eduardo Habkost Reviewed-by: David Gibson > --- > hw/net/xgmac.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/hw/net/xgmac.c b/hw/net/xgmac.c > index fa001563d3..6

Re: [libvirt] [PULL 18/45] memory-device: fix alignment error message

2018-10-23 Thread David Gibson
On Thu, Oct 18, 2018 at 05:03:55PM -0300, Eduardo Habkost wrote: > From: David Hildenbrand > > We're missing "x" after the leading 0. > > Reviewed-by: David Gibson > Reviewed-by: Igor Mammedov > Signed-off-by: David Hildenbrand > Message-Id: <201810050920

Re: [libvirt] [PULL 36/45] net: lan9118: convert SysBus init method to a realize method

2018-10-23 Thread David Gibson
On Thu, Oct 18, 2018 at 05:04:13PM -0300, Eduardo Habkost wrote: > From: Cédric Le Goater > > Signed-off-by: Cédric Le Goater > Message-Id: <20181001063803.22330-4-...@kaod.org> > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Eduardo Habkost Reviewed-by: David

Re: [libvirt] [PULL 07/45] hw/timer/sun4v-rtc: Use DeviceState::realize rather than SysBusDevice::init

2018-10-23 Thread David Gibson
Goater > Message-Id: <20181002212522.23303-4-f4...@amsat.org> > Signed-off-by: Eduardo Habkost Reviewed-by: David Gibson > --- > hw/timer/sun4v-rtc.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/hw/timer/sun4v-rtc.c b/hw/

Re: [libvirt] [PULL 16/45] hw/mips/malta: Remove unuseful code

2018-10-23 Thread David Gibson
On Thu, Oct 18, 2018 at 05:03:53PM -0300, Eduardo Habkost wrote: > From: Philippe Mathieu-Daudé > > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Thomas Huth > Message-Id: <20181002212522.23303-13-f4...@amsat.org> > Signed-off-by: Eduardo Habkost R

Re: [libvirt] [PULL 17/45] machine: fix a typo

2018-10-23 Thread David Gibson
On Thu, Oct 18, 2018 at 05:03:54PM -0300, Eduardo Habkost wrote: > From: Li Qiang > > Cc: qemu-triv...@nongnu.org > Signed-off-by: Li Qiang > Message-Id: <20181010161025.34796-1-liq...@163.com> > Reviewed-by: Stefano Garzarella > Signed-off-by: Eduardo Habkost

Re: [libvirt] [PULL 05/45] trace-events: Fix copy/paste typo

2018-10-23 Thread David Gibson
522.23303-2-f4...@amsat.org> > Signed-off-by: Eduardo Habkost Reviewed-by: David Gibson > --- > hw/timer/trace-events | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/timer/trace-events b/hw/timer/trace-events > index fa4213df5b..ca9ad6321a 10

Re: [libvirt] [PULL 37/45] net: lance: convert SysBus init method to a realize method

2018-10-23 Thread David Gibson
Eduardo Habkost Reviewed-by: David Gibson > --- > hw/net/lance.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/hw/net/lance.c b/hw/net/lance.c > index a08d5ac6a8..f987b2fd18 100644 > --- a/hw/net/lance.c > +++ b/hw/net/lance.c

Re: [libvirt] [PULL 04/45] numa: Fix QMP command set-numa-node error handling

2018-10-23 Thread David Gibson
's other caller > numa_complete_configuration(): since it ignores errors, the "NUMA is > not supported by this machine-type" is now ignored, too. But that > error is as unexpected there as any other. Change it to abort on > error instead. > > Fixes: f3be67812c226162f86ce92634bd913714445420 > Cc: Igor Ma

Re: [libvirt] [PULL 06/45] hw/timer/sun4v-rtc: Convert from DPRINTF() macro to trace events

2018-10-23 Thread David Gibson
r write: offset 0x%" PRIx64 " data 0x%" PRIx64 " size %u" > cmsdk_apb_dualtimer_reset(void) "CMSDK APB dualtimer: reset" > > +# hw/timer/sun4v-rtc.c > +sun4v_rtc_read(uint64_t addr, uint64_t value) "read: addr 0x%" PRIx64 " > value 0x

Re: [libvirt] [PULL 03/45] vl:c: make sure that sockets are calculated correctly in '-smp X' case

2018-10-23 Thread David Gibson
rning back sockets calculation if it's omitted on CLI. > > Signed-off-by: Igor Mammedov > Reviewed-by: Andrew Jones > Message-Id: <1536836762-273036-3-git-send-email-imamm...@redhat.com> > Signed-off-by: Eduardo Habkost Reviewed-by: David Gibson > --- > vl.c |

Re: [libvirt] [PULL 01/45] hostmem-file: fixed the memory leak while get pmem path.

2018-10-21 Thread David Gibson
: Zhang Yi > Message-Id: > <7328fb16c394eaf5d65437d11c2a9343647b6d3d.1535471899.git.yi.z.zh...@linux.intel.com> > Reviewed-by: Eduardo Habkost > Signed-off-by: Eduardo Habkost Reviewed-by: David Gibson > --- > backends/hostmem-file.c | 10 -- > 1 file chang

Re: [libvirt] [PULL 02/45] vl.c deprecate incorrect CPUs topology

2018-10-21 Thread David Gibson
-by: Eric Blake > Signed-off-by: Eduardo Habkost Reviewed-by: David Gibson > --- > vl.c | 7 +++ > qemu-deprecated.texi | 12 > 2 files changed, 19 insertions(+) > > diff --git a/vl.c b/vl.c > index 4e25c78bff..027d04c7ca 100644 >

Re: [libvirt] [PATCH] ppc: Remove deprecated ppcemb target

2018-08-22 Thread David Gibson
-9950,10 +9933,6 @@ static gint > ppc_cpu_compare_class_pvr_mask(gconstpointer a, gconstpointer b) > return -1; > } > > -if (!ppc_cpu_is_valid(pcc)) { > -return -1; > -} > - > if (pcc->pvr_match(pcc, pvr)) { > return 0; >

Re: [libvirt] [PATCH] qemu-doc: mark ppc/prep machine as deprecated

2018-08-12 Thread David Gibson
ad. > + > @section Device options > > @subsection Block device options Applied to ppc-for-3.1, thanks. -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_

Re: [libvirt] [RFC PATCH 6/6] qemu: Format pseries.cap-hpt-mps on the command line

2018-06-05 Thread David Gibson
On Tue, Jun 05, 2018 at 04:05:38PM +0200, Andrea Bolognani wrote: > On Mon, 2018-06-04 at 11:33 +1000, David Gibson wrote: > > On Thu, May 24, 2018 at 07:34:25AM +0200, Peter Krempa wrote: > > > On Wed, May 23, 2018 at 19:09:59 +0200, Andrea Bolognani wrote: > > > >

Re: [libvirt] [RFC PATCH 6/6] qemu: Format pseries.cap-hpt-mps on the command line

2018-06-04 Thread David Gibson
rs of two make sense for this knob then this gives > you input validation for free. On the other hand, specifying a big > number can overflow internally if it is ever used in the non-exponent > form. I think the format does not matter much, since libvirt's job is to > shield users f

Re: [libvirt] [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

2018-04-22 Thread David Gibson
end up just being a file in docs/specs, > rather than directly part of our existnig qapi schema, I suggest we just > ignore whats there. Just define an arch enum in your spec which is right, > and let someone else worry about fixing the mess Trouble is, for these "biarch" cases, I

Re: [libvirt] [qemu RFC v2] qapi: add "firmware.json"

2018-04-19 Thread David Gibson
On Thu, 19 Apr 2018 10:09:30 +0200 Laszlo Ersek <ler...@redhat.com> wrote: > On 04/19/18 02:09, David Gibson wrote: > [...] > [...] > [...] > [...] > [...] > [...] > [...] > [...] > [...] > > Thank you -- I will replace SLOF w

Re: [libvirt] [qemu RFC v2] qapi: add "firmware.json"

2018-04-18 Thread David Gibson
. But SLOF is a specific implementation of Open Firmware (of which we have a couple of other partial implementations used for other qemu platforms). U-Boot is somewhere in between the two, a specific implementation that defines a fair bunch of its own interfaces. -- David Gibson <dgib...@redhat.com&

Re: [libvirt] [PATCH] spapr: make default PHB optionnal

2017-07-18 Thread David Gibson
On Wed, Jul 12, 2017 at 05:09:37PM +0530, Shivaprasad G Bhat wrote: > > > On 07/12/2017 04:25 PM, Andrea Bolognani wrote: > > [libvir-list added to the loop] > > > > On Tue, 2017-07-04 at 10:47 +0200, Greg Kurz wrote: > > > On Tue, 4 Jul 2017 17

Re: [libvirt] [PATCH v3 25/26] qemu: Isolate hostdevs on pSeries guests

2017-07-04 Thread David Gibson
-one is working on it. > > [...] > [...] > > I don't think PCIe Root Ports provide any isolation; not of > the kind we're talking about here, at least. So the concepts > implemented here don't apply AFAICT. > > --  > Andrea Bolognani / Red Hat / Virtu

Re: [libvirt] [PATCH] cpu_ppc64: Add support for host-model on POWER9

2017-06-12 Thread David Gibson
e is pretty misleading. Yes, that does look like a bug. > Last but not least, using an unsupported compatibility mode > results in QEMU abort()ing, which seems a bit excessive for > a very reasonable guest configuration error. Ah, yes. Probably just an _abort where we should have an _fa

Re: [libvirt] [PATCH] cpu_ppc64: Add support for host-model on POWER9

2017-06-08 Thread David Gibson
On Thu, Jun 08, 2017 at 10:21:44AM +0200, Andrea Bolognani wrote: > On Thu, 2017-06-08 at 14:12 +1000, David Gibson wrote: > > > David, are these known issues in QEMU? Are they being tracked? > >  > > It's not an issue in qemu, it's an issue in the hardware. > >

Re: [libvirt] [PATCH] cpu_ppc64: Add support for host-model on POWER9

2017-06-07 Thread David Gibson
nel not to turn on some vital DD1 workarounds, which makes it break horribly. > I don't see much point in updating libvirt to cope with these > new compat modes when QEMU itself doesn't. Try TCG, it should work there. -- David Gibson| I'll have my music baroque, and m

Re: [libvirt] [PATCH 3/3] qemu: use qemu-xhci USB controller by default for ppc64 and aarch64

2017-04-26 Thread David Gibson
o QE know what to test (they've already asked about testing nec-xhci versus qemu-xhci). -- David Gibson <dgib...@redhat.com> Principal Software Engineer, Virtualization, Red Hat pgpv9uwIEM_Cn.pgp Description: OpenPGP digital signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [RFC PATCH 00/12] Support multiple PHBs on pSeries guests

2017-03-06 Thread David Gibson
On Fri, 03 Mar 2017 09:07:53 +0100 Andrea Bolognani <abolo...@redhat.com> wrote: > On Fri, 2017-03-03 at 12:37 +1100, David Gibson wrote: > [...] > [...] > > Sorry for not keeping you up to date, here's the situation: > I got the code working with the current

Re: [libvirt] [RFC PATCH 00/12] Support multiple PHBs on pSeries guests

2017-03-02 Thread David Gibson
be to teach PCI devices about the quirkiness in > bus naming when it comes to PHBs. An update: I'm intending to squeeze the device tree fix to advertise extended config space into qemu-2.9. I'm not going to include the naming change - I'll see how your investigation here turns out before proceeding w

Re: [libvirt] [Qemu-ppc] Proposal PCI/PCIe device placement on PAPR guests

2017-02-23 Thread David Gibson
On Thu, Feb 23, 2017 at 08:23:50AM +0100, Greg Kurz wrote: > On Thu, 23 Feb 2017 13:11:52 +1100 > David Gibson <da...@gibson.dropbear.id.au> wrote: > > > On Wed, Feb 22, 2017 at 12:08:25PM +0100, Greg Kurz wrote: > > > David, > > > > > > I don

Re: [libvirt] [Qemu-ppc] Proposal PCI/PCIe device placement on PAPR guests

2017-02-22 Thread David Gibson
rent approach for PCIe support. -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson signature.asc Description: P

Re: [libvirt] Proposal PCI/PCIe device placement on PAPR guests

2017-01-12 Thread David Gibson
On Thu, Jan 12, 2017 at 10:09:03AM +0100, Greg Kurz wrote: > On Thu, 12 Jan 2017 17:19:40 +1100 > Alexey Kardashevskiy <a...@ozlabs.ru> wrote: > > > On 12/01/17 14:52, David Gibson wrote: > > > On Fri, Jan 06, 2017 at 12:57:58PM +0100, Greg Kurz wrote: > >

Re: [libvirt] Proposal PCI/PCIe device placement on PAPR guests

2017-01-12 Thread David Gibson
On Thu, Jan 12, 2017 at 11:31:35AM +0100, Andrea Bolognani wrote: > On Mon, 2017-01-09 at 10:46 +1100, David Gibson wrote: > > > >* To allow for hotplugged devices, libvirt should also add a number > > > >  of additional, empty vPHBs (the PAPR spec allows for h

Re: [libvirt] Proposal PCI/PCIe device placement on PAPR guests

2017-01-12 Thread David Gibson
On Thu, Jan 12, 2017 at 12:53:28PM -0500, Laine Stump wrote: > On 01/12/2017 11:35 AM, Michael Roth wrote: > > Quoting Laine Stump (2017-01-12 08:52:10) > > > On 01/12/2017 05:31 AM, Andrea Bolognani wrote: > > > > On Mon, 2017-01-09 at 10:46 +1100, David Gibson wrote

Re: [libvirt] Proposal PCI/PCIe device placement on PAPR guests

2017-01-12 Thread David Gibson
On Thu, Jan 12, 2017 at 11:03:05AM -0500, Laine Stump wrote: > On 01/05/2017 12:46 AM, David Gibson wrote: > > There was a discussion back in November on the qemu list which spilled > > onto the libvirt list about how to add support for PCIe devices to > > POWER VMs, specifica

Re: [libvirt] Proposal PCI/PCIe device placement on PAPR guests

2017-01-11 Thread David Gibson
On Fri, Jan 06, 2017 at 12:57:58PM +0100, Greg Kurz wrote: > On Thu, 5 Jan 2017 16:46:18 +1100 > David Gibson <da...@gibson.dropbear.id.au> wrote: > > > There was a discussion back in November on the qemu list which spilled > > onto the libvirt list about how to a

Re: [libvirt] Proposal PCI/PCIe device placement on PAPR guests

2017-01-08 Thread David Gibson
On Fri, Jan 06, 2017 at 12:57:58PM +0100, Greg Kurz wrote: > On Thu, 5 Jan 2017 16:46:18 +1100 > David Gibson <da...@gibson.dropbear.id.au> wrote: > > > There was a discussion back in November on the qemu list which spilled > > onto the libvirt list about how to a

Re: [libvirt] Proposal PCI/PCIe device placement on PAPR guests

2017-01-08 Thread David Gibson
On Fri, Jan 06, 2017 at 06:34:29PM +0100, Andrea Bolognani wrote: > [Added Laine to CC, fixed qemu-devel address] > > On Thu, 2017-01-05 at 16:46 +1100, David Gibson wrote: > [...] > >   * To allow for hotplugged devices, libvirt should also add a number > > of

[libvirt] Proposal PCI/PCIe device placement on PAPR guests

2017-01-04 Thread David Gibson
node assignment of devices PAPR does not (and can't reasonably) use the pxb device. Instead to allocate devices to different guest NUMA nodes they should be placed on different vPHBs. Placing them on different PHBs by default allows NUMA node to be assigned to those PHBs in a straightforward man

Re: [libvirt] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

2016-12-13 Thread David Gibson
On Tue, Dec 13, 2016 at 02:25:44PM +0200, Marcel Apfelbaum wrote: > On 12/07/2016 06:42 PM, Andrea Bolognani wrote: > > [Added Marcel to CC] > > > > > Hi, > > Sorry for the late reply. > > > On Wed, 2016-12-07 at 15:11 +1100, David Gibson wrote

Re: [libvirt] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

2016-12-13 Thread David Gibson
VM/qemu. Alas, no, we only have 3 on KVM/qemu. Well, possibly you could do (2) by plugging a bridge device using (3) then a device onto the bridge. Whole PHB hotplug has never been implemented for qemu/KVM.. but we probably want to. -- David Gibson| I'll have my music baroque, and

Re: [libvirt] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

2016-12-06 Thread David Gibson
On Tue, Dec 06, 2016 at 06:30:47PM +0100, Andrea Bolognani wrote: > On Fri, 2016-12-02 at 15:18 +1100, David Gibson wrote: > > > So, would the PCIe Root Bus in a pseries guest behave > > > differently than the one in a q35 or mach-virt guest? > >  > > Yes.  

Re: [libvirt] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

2016-12-06 Thread David Gibson
On Mon, Dec 05, 2016 at 03:54:49PM -0500, Laine Stump wrote: > (Sorry for any duplicates. I sent it from the wrong address the first time) > > On 12/01/2016 11:18 PM, David Gibson wrote: > > On Fri, Nov 25, 2016 at 02:46:21PM +0100, Andrea Bolognani wrote: > > > On Wed, 2

Re: [libvirt] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

2016-12-02 Thread David Gibson
On Fri, Dec 02, 2016 at 04:17:50PM +1100, Benjamin Herrenschmidt wrote: > On Fri, 2016-12-02 at 15:18 +1100, David Gibson wrote: > > But if you pass through multiple groups, things get weird.  On q35, > > you'd generally expect physically separate (different slot) devices to &

Re: [libvirt] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

2016-12-01 Thread David Gibson
On Fri, Nov 25, 2016 at 03:36:25PM +0100, Andrea Bolognani wrote: > On Wed, 2016-11-23 at 16:02 +1100, David Gibson wrote: > > > > The change from OHCI to XHCI only affected the *default* USB > > > > controller, which libvirt tries its best not to use anyway: > > &

Re: [libvirt] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

2016-12-01 Thread David Gibson
On Fri, Nov 25, 2016 at 02:46:21PM +0100, Andrea Bolognani wrote: > On Wed, 2016-11-23 at 16:00 +1100, David Gibson wrote: > > > Existing libvirt versions assume that pseries guests have > > > a legacy PCI root bus, and will base their PCI address > > > alloc

Re: [libvirt] -nodefaults and available buses (was Re: [Qemu-devel] [RFC 00/15] qmp: Report supported device types on 'query-machines')

2016-11-24 Thread David Gibson
t; > > > Some machines will make QEMU exit, some of them simply segfault. > > I am looking for ways to work around it so we can still validate > > -nodefaults-based info on the test code. > > The following machines won't work with -nodefaults: > > Thes

Re: [libvirt] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

2016-11-22 Thread David Gibson
ith > > '-device ...' and set both the controller model and its PCI > > address explicitly, partially to shield its users from such > > changes in QEMU. > > > Ok. Always likes this approach really. We should start moving to this > direction with PHB - stop

Re: [libvirt] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

2016-11-22 Thread David Gibson
easons to keep both updated. For pseries we have neither the impetus nor the resources to maintain two different machine type variant, where the only difference is between legacy PCI and weirdly presented PCI-E. > Even if no newer pseries-x.y were to be added after > introducing pseries-pcie

Re: [libvirt] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

2016-11-18 Thread David Gibson
On Thu, Nov 17, 2016 at 01:02:57PM +1100, Alexey Kardashevskiy wrote: > On 16/11/16 01:02, Andrea Bolognani wrote: > > On Tue, 2016-11-01 at 13:46 +1100, David Gibson wrote: > >> On Mon, Oct 31, 2016 at 03:10:23PM +1100, Alexey Kardashevskiy wrote: > >>> > &g

Re: [libvirt] [RFC PATCH 0/2] nodeinfo: PPC64: Fix topology and siblings info on capabilities and nodeinfo

2016-06-16 Thread David Gibson
On Fri, 10 Jun 2016 17:52:47 +0200 Andrea Bolognani <abolo...@redhat.com> wrote: > On Tue, 2016-05-31 at 16:08 +1000, David Gibson wrote: > > > QEMU fails with errors like > > >  > > >   qemu-kvm: Cannot support more than 8 threads on PPC with KVM > >

Re: [libvirt] [RFC PATCH 0/2] nodeinfo: PPC64: Fix topology and siblings info on capabilities and nodeinfo

2016-05-31 Thread David Gibson
seful or just confusing. > >  > > IMO it seems like something worth adding since it is a pertinent piece of > > the > > topology, even if there isn't a clear programmatic use for it yet. > > It is a piece of information that we would not be reporting, > that m

[libvirt] Fw: [RFC PATCH 0/2] nodeinfo: PPC64: Fix topology and siblings info on capabilities and nodeinfo

2016-02-22 Thread David Gibson
Sorry, accidentally sent to just Andrea the first time around, resending... Begin forwarded message: Date: Mon, 22 Feb 2016 16:53:15 +1100 From: David Gibson <dgib...@redhat.com> To: Andrea Bolognani <abolo...@redhat.com> Subject: Re: [libvirt] [RFC PATCH 0/2] nodeinfo: PPC64:

Re: [libvirt] [RFC PATCH 0/2] nodeinfo: PPC64: Fix topology and siblings info on capabilities and nodeinfo

2016-02-15 Thread David Gibson
siblings='32-39'/> > siblings='32-39'/> > siblings='32-39'/> > siblings='32-39'/> > siblings='32-39'/> > siblings='32-39'/> > siblings='32-39'/> > siblings='32-39'/> >  

Re: [libvirt] [PATCH 6/6] qemu: Add ppc64-specific math to qemuDomainGetMlockLimitBytes()

2015-11-19 Thread David Gibson
es which have been completely swamped by horrible cache behaviour for most of the last 15 years. It also requires a big slab of physically contiguous memory for the hash table, which is a bit of a pain for us. Linux actually treats the hash page table as though it were an enormous TLB, reloa

Re: [libvirt] [PATCH] conf/qemu: enforce NUMA nodes only for x86 memory hotplug

2015-08-18 Thread David Gibson
most of our Power / libvirt work here at Red Hat. -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson