Re: [libvirt] [PATCH 0/1] update copyright notice

2019-02-25 Thread David Kiarie
On Mon, Feb 25, 2019 at 8:04 PM Jim Fehlig wrote: > On 2/22/19 2:06 AM, David Kiarie wrote: > > > i did this as part of GSoC. there was no contract. > > > > I'm not entirely sure, but we might want to ask the SuSE folks > whether > > they agre

[libvirt] [PATCH 1/1] src/xenconfig: update copyright notice

2019-02-22 Thread David Kiarie
Signed-off-by: David Kiarie --- src/xenconfig/xen_xl.c | 1 + src/xenconfig/xen_xl.h | 1 + tests/xlconfigtest.c | 1 + 3 files changed, 3 insertions(+) diff --git a/src/xenconfig/xen_xl.c b/src/xenconfig/xen_xl.c index accfc3a..64a5ddf 100644 --- a/src/xenconfig/xen_xl.c +++ b/src/xenconfig

[libvirt] [PATCH 0/1] update copyright notice

2019-02-22 Thread David Kiarie
these patche follows up a very co-operative review on a preview patch or lack of thereof. i have updated this to reflect the exact name i use in person. David Kiarie (1): src/xenconfig: update copyright notice src/xenconfig/xen_xl.c | 1 + src/xenconfig/xen_xl.h | 1 + tests/xlconfigtest.c

Re: [libvirt] [PATCH 1/1] src/xenconfig: update copyright notice

2019-02-22 Thread David Kiarie
On Fri, Feb 22, 2019 at 12:08 PM Michal Privoznik wrote: > On 2/21/19 7:44 PM, David Kiarie wrote: > > Signed-off-by: David Kiarie > > --- > > src/xenconfig/xen_xl.c | 1 + > > src/xenconfig/xen_xl.h | 1 + > > tests/xlconfigtest.c | 1 + > > 3 file

Re: [libvirt] [PATCH 1/1] src/xenconfig: update copyright notice

2019-02-22 Thread David Kiarie
> > Frankly, I find theese lines useless. Git blame tells you who wrote >> which lines of code. I'm no laywer, but the way I understand copyrights >> in GPL projects is that it comes important only if project wants to >> change the licence (e.g. to BSD). Then it has to have confirmation from >> al

[libvirt] [PATCH 0/1] update copyright notice

2019-02-22 Thread David Kiarie
this updates the patch to use a full legal name on the copyright notice. David Kiarie (1): src/xenconfig: update copyright notice src/xenconfig/xen_xl.c | 1 + src/xenconfig/xen_xl.h | 1 + tests/xlconfigtest.c | 1 + 3 files changed, 3 insertions(+) -- 2.20.1 -- libvir-list mailing list

[libvirt] [PATCH 1/1] src/xenconfig: update copyright notice

2019-02-22 Thread David Kiarie
Signed-off-by: David Kiarie --- src/xenconfig/xen_xl.c | 1 + src/xenconfig/xen_xl.h | 1 + tests/xlconfigtest.c | 1 + 3 files changed, 3 insertions(+) diff --git a/src/xenconfig/xen_xl.c b/src/xenconfig/xen_xl.c index accfc3a..2796749 100644 --- a/src/xenconfig/xen_xl.c +++ b/src/xenconfig

Re: [libvirt] [PATCH 1/1] src/xenconfig: update copyright notice

2019-02-22 Thread David Kiarie
> > > * > > * This library is free software; you can redistribute it and/or > > * modify it under the terms of the GNU Lesser General Public > > This is fine, assuming you're still happy to have this version > committed - we don't want to re-visit this for a 3rd third. > i don't think you'll

Re: [libvirt] [PATCH 1/1] src/xenconfig: update copyright notice

2019-02-22 Thread David Kiarie
On Fri, Feb 22, 2019 at 2:19 PM Daniel P. Berrangé wrote: > On Fri, Feb 22, 2019 at 12:36:36PM +0300, David Kiarie wrote: > > Signed-off-by: David Kiarie > > --- > > src/xenconfig/xen_xl.c | 1 + > > src/xenconfig/xen_xl.h | 1 + > > tests/xlconfigtest.

Re: [libvirt] [PATCH 0/1] update copyright notice

2019-02-22 Thread David Kiarie
On Fri, Feb 22, 2019 at 2:03 PM Daniel P. Berrangé wrote: > On Fri, Feb 22, 2019 at 11:42:04AM +0300, David Kiarie wrote: > > On Fri, Feb 22, 2019 at 11:09 AM Jiri Denemark > wrote: > > > > > On Fri, Feb 22, 2019 at 08:50:55 +0100, Peter Krempa wrote: > > >

Re: [libvirt] [PATCH 0/1] update copyright notice

2019-02-22 Thread David Kiarie
> > > as you can see, this request was fulfilled within minutes, mostly because > > Daniel is bitter that i tried to use a pseudonym on the code but he > > strangely has nothing to say to say this time round. > > I think that any attempt to convert this conversation to personal matters > involving

Re: [libvirt] [PATCH 0/1] update copyright notice

2019-02-22 Thread David Kiarie
> > > > > > > > > > > > > Did you change your mind? > > > > > > > yes, i will actually share the copyright, if possible. > > Given our previous experience I'm worried that you might change your > mind again. > > I'd like you to pledge that it's your final decision and you will > not attempt to dele

Re: [libvirt] [PATCH 0/1] update copyright notice

2019-02-22 Thread David Kiarie
On Fri, Feb 22, 2019 at 11:42 AM David Kiarie wrote: > > > On Fri, Feb 22, 2019 at 11:09 AM Jiri Denemark > wrote: > >> On Fri, Feb 22, 2019 at 08:50:55 +0100, Peter Krempa wrote: >> > On Thu, Feb 21, 2019 at 21:44:34 +0300, David Kiarie wrote: >> > > i

Re: [libvirt] [PATCH 0/1] update copyright notice

2019-02-22 Thread David Kiarie
On Fri, Feb 22, 2019 at 11:09 AM Jiri Denemark wrote: > On Fri, Feb 22, 2019 at 08:50:55 +0100, Peter Krempa wrote: > > On Thu, Feb 21, 2019 at 21:44:34 +0300, David Kiarie wrote: > > > it looks sensible that the copyright notice on the affected files in > > > update

[libvirt] [PATCH 1/1] src/xenconfig: update copyright notice

2019-02-21 Thread David Kiarie
Signed-off-by: David Kiarie --- src/xenconfig/xen_xl.c | 1 + src/xenconfig/xen_xl.h | 1 + tests/xlconfigtest.c | 1 + 3 files changed, 3 insertions(+) diff --git a/src/xenconfig/xen_xl.c b/src/xenconfig/xen_xl.c index accfc3a..8029579 100644 --- a/src/xenconfig/xen_xl.c +++ b/src/xenconfig

[libvirt] [PATCH 0/1] update copyright notice

2019-02-21 Thread David Kiarie
it looks sensible that the copyright notice on the affected files in updated as in this patch so as to also cover another party who hugely participated in writing the code. David Kiarie (1): src/xenconfig: update copyright notice src/xenconfig/xen_xl.c | 1 + src/xenconfig/xen_xl.h | 1

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-10 Thread David Kiarie
On Wed, May 9, 2018 at 5:27 PM, Oneko wrote: > > > On Wed, May 9, 2018 at 3:24 PM, Michal Privoznik > wrote: > >> On 05/09/2018 01:51 PM, David Kiarie wrote: >> > On Wed, May 9, 2018 at 2:29 PM, David Kiarie >> wrote: >> > >> >> >>

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-09 Thread David Kiarie
On Wed, May 9, 2018 at 5:09 PM, Fabian Freyer < fabian.fre...@physik.tu-berlin.de> wrote: > On Wed, May 09, 2018 at 02:29:35PM +0300, David Kiarie wrote: > > We don't have a new company here. We have an almost four year old cat. > > IANAL, but I think there's a p

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-09 Thread David Kiarie
On Wed, May 9, 2018 at 2:29 PM, David Kiarie wrote: > > > On Wed, May 9, 2018 at 1:56 PM, John Ferlan wrote: > >> [...] >> >> >> > > >> Suse copyright notice has been on this file since the day this >> > file got >> >

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-09 Thread David Kiarie
On Wed, May 9, 2018 at 1:56 PM, John Ferlan wrote: > [...] > > > > > >> Suse copyright notice has been on this file since the day this > > file got > > > >> merged. To be honest, I did most of the original work so why > > should Suse > > > >> copyright appear here while me doe

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-09 Thread David Kiarie
On Wed, May 9, 2018 at 2:14 PM, David Kiarie wrote: > > > On Wed, May 9, 2018 at 2:10 PM, David Kiarie > wrote: > >> >> >> On Wed, May 9, 2018 at 2:08 PM, Daniel P. Berrangé >> wrote: >> >>> On Wed, May 09, 2018 at 02:05:54PM +0300, Da

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-09 Thread David Kiarie
On Wed, May 9, 2018 at 2:10 PM, David Kiarie wrote: > > > On Wed, May 9, 2018 at 2:08 PM, Daniel P. Berrangé > wrote: > >> On Wed, May 09, 2018 at 02:05:54PM +0300, David Kiarie wrote: >> > On Wed, May 9, 2018 at 2:01 PM, Daniel P. Berrangé > > >> >

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-09 Thread David Kiarie
On Wed, May 9, 2018 at 2:08 PM, Daniel P. Berrangé wrote: > On Wed, May 09, 2018 at 02:05:54PM +0300, David Kiarie wrote: > > On Wed, May 9, 2018 at 2:01 PM, Daniel P. Berrangé > > wrote: > > > > > On Wed, May 09, 2018 at 01:47:26PM +0300, David Kiarie wrote: >

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-09 Thread David Kiarie
On Wed, May 9, 2018 at 2:01 PM, Daniel P. Berrangé wrote: > On Wed, May 09, 2018 at 01:47:26PM +0300, David Kiarie wrote: > > On Wed, May 9, 2018 at 1:43 PM, Daniel P. Berrangé > > wrote: > > > > > On Wed, May 09, 2018 at 01:36:35PM +0300, David Kiarie wrote: >

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-09 Thread David Kiarie
On Wed, May 9, 2018 at 1:43 PM, Daniel P. Berrangé wrote: > On Wed, May 09, 2018 at 01:36:35PM +0300, David Kiarie wrote: > > On Wed, May 9, 2018 at 1:18 PM, David Kiarie > wrote: > > > > > > > > > > > On Wed, May 9, 2018 at 1:15 PM, David Kiarie &

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-09 Thread David Kiarie
On Wed, May 9, 2018 at 1:18 PM, David Kiarie wrote: > > > On Wed, May 9, 2018 at 1:15 PM, David Kiarie > wrote: > >> >> >> On Wed, May 9, 2018 at 12:02 PM, Daniel P. Berrangé >> wrote: >> >>> On Wed, May 09, 2018 at 10:38:59AM +0200, Pete

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-09 Thread David Kiarie
On Wed, May 9, 2018 at 1:15 PM, David Kiarie wrote: > > > On Wed, May 9, 2018 at 12:02 PM, Daniel P. Berrangé > wrote: > >> On Wed, May 09, 2018 at 10:38:59AM +0200, Peter Krempa wrote: >> > On Wed, May 09, 2018 at 08:51:01 +0100, Daniel Berrange wrote: >> &g

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-09 Thread David Kiarie
On Wed, May 9, 2018 at 12:02 PM, Daniel P. Berrangé wrote: > On Wed, May 09, 2018 at 10:38:59AM +0200, Peter Krempa wrote: > > On Wed, May 09, 2018 at 08:51:01 +0100, Daniel Berrange wrote: > > > On Wed, May 09, 2018 at 09:14:29AM +0300, David Kiarie wrote: > > > >

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-08 Thread David Kiarie
On Tue, May 8, 2018 at 6:09 PM, Jim Fehlig wrote: > On 05/08/2018 03:22 AM, David Kiarie wrote: > >> >> >> On Tue, May 8, 2018 at 2:11 AM, Jim Fehlig > jfeh...@suse.com>> wrote: >> >> On 05/07/2018 08:57 AM, David Kiarie wrote: >> >> &

Re: [libvirt] [PATCH] xenconfig: remove my name and email from files

2018-05-08 Thread David Kiarie
On Tue, May 8, 2018 at 3:45 PM, Daniel P. Berrangé wrote: > On Tue, May 08, 2018 at 03:40:00PM +0300, David Kiarie wrote: > > Remove my name and email from these files > > > > Signed-off-by: David Kiarie > > --- > > src/xenconfig/xen_xl.c | 1 - > >

[libvirt] [PATCH] xenconfig: remove my name and email from files

2018-05-08 Thread David Kiarie
Remove my name and email from these files Signed-off-by: David Kiarie --- src/xenconfig/xen_xl.c | 1 - src/xenconfig/xen_xl.h | 1 - tests/xlconfigtest.c | 1 - 3 files changed, 3 deletions(-) diff --git a/src/xenconfig/xen_xl.c b/src/xenconfig/xen_xl.c index 35d52f8a..f0d9177c 100644 --- a

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-08 Thread David Kiarie
On Tue, May 8, 2018 at 2:21 PM, Daniel P. Berrangé wrote: > On Mon, May 07, 2018 at 05:55:51PM +0300, David Kiarie wrote: > > On Mon, May 7, 2018 at 10:29 AM, Peter Krempa > wrote: > > > > > On Sat, May 05, 2018 at 12:17:05 +0300, David Kiarie wrote: > > &g

[libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-08 Thread David Kiarie
Replace references to my name and email with a pseudonym Signed-off-by: David Kiarie --- src/xenconfig/xen_xl.c | 2 +- src/xenconfig/xen_xl.h | 2 +- tests/xlconfigtest.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/xenconfig/xen_xl.c b/src/xenconfig/xen_xl.c

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-08 Thread David Kiarie
On Tue, May 8, 2018 at 12:22 PM, David Kiarie wrote: > > > On Tue, May 8, 2018 at 2:11 AM, Jim Fehlig wrote: > >> On 05/07/2018 08:57 AM, David Kiarie wrote: >> >>> >>> >>> On Mon, May 7, 2018 at 5:55 PM, David Kiarie >> <mailto:david

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-08 Thread David Kiarie
On Tue, May 8, 2018 at 2:11 AM, Jim Fehlig wrote: > On 05/07/2018 08:57 AM, David Kiarie wrote: > >> >> >> On Mon, May 7, 2018 at 5:55 PM, David Kiarie > <mailto:davidkiar...@gmail.com>> wrote: >> >> >> >> On Mon, May 7, 2018 at 10:

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-07 Thread David Kiarie
On Mon, May 7, 2018 at 5:55 PM, David Kiarie wrote: > > > On Mon, May 7, 2018 at 10:29 AM, Peter Krempa wrote: > >> On Sat, May 05, 2018 at 12:17:05 +0300, David Kiarie wrote: >> > On Sat, May 5, 2018 at 12:15 PM, David Kiarie >> > wrote: >> > &

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-07 Thread David Kiarie
On Mon, May 7, 2018 at 10:29 AM, Peter Krempa wrote: > On Sat, May 05, 2018 at 12:17:05 +0300, David Kiarie wrote: > > On Sat, May 5, 2018 at 12:15 PM, David Kiarie > > wrote: > > > > > Replace references to my name and email with a pseudonym > > > >

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-05 Thread David Kiarie
On Sat, May 5, 2018 at 12:15 PM, David Kiarie wrote: > Replace references to my name and email with a pseudonym > Sorry, I just want my real name and email off these files and I keep making silly mistakes. > > Signed-off-by: David Kiarie > --- > src/xenconfig/xen_

[libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-05 Thread David Kiarie
Replace references to my name and email with a pseudonym Signed-off-by: David Kiarie --- src/xenconfig/xen_xl.c | 2 +- src/xenconfig/xen_xl.h | 2 +- tests/xlconfigtest.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/xenconfig/xen_xl.c b/src/xenconfig/xen_xl.c

[libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-05 Thread David Kiarie
Replace references to my name and email with a pseudonym Signed-off-by: David Kiarie --- src/xenconfig/xen_xl.c | 2 +- src/xenconfig/xen_xl.h | 2 +- tests/xlconfigtest.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/xenconfig/xen_xl.c b/src/xenconfig/xen_xl.c

Re: [libvirt] [PATCH] snip my name and email

2018-03-28 Thread David Kiarie
On Wed, Mar 28, 2018 at 7:52 PM, Daniel P. Berrangé wrote: > On Wed, Mar 28, 2018 at 07:49:09PM +0300, David Kiarie wrote: > > On Wed, Mar 28, 2018 at 7:46 PM, David Kiarie > > wrote: > > > > > > > > > > > On Wed, Mar 28, 2018 at 7:43 PM, Daniel

Re: [libvirt] [PATCH] snip my name and email

2018-03-28 Thread David Kiarie
On Wed, Mar 28, 2018 at 7:46 PM, David Kiarie wrote: > > > On Wed, Mar 28, 2018 at 7:43 PM, Daniel P. Berrangé > wrote: > >> On Wed, Mar 28, 2018 at 07:33:11PM +0300, David Kiarie wrote: >> > On Wed, Mar 28, 2018 at 5:32 PM, Daniel P. Berrangé < &

Re: [libvirt] [PATCH] snip my name and email

2018-03-28 Thread David Kiarie
On Wed, Mar 28, 2018 at 7:33 PM, David Kiarie wrote: > > > On Wed, Mar 28, 2018 at 5:32 PM, Daniel P. Berrangé > wrote: > >> On Mon, Mar 26, 2018 at 10:29:06AM +0300, David Kiarie wrote: >> > I'd like to snip my name and email from these files >> >>

Re: [libvirt] [PATCH] snip my name and email

2018-03-28 Thread David Kiarie
On Wed, Mar 28, 2018 at 5:32 PM, Daniel P. Berrangé wrote: > On Mon, Mar 26, 2018 at 10:29:06AM +0300, David Kiarie wrote: > > I'd like to snip my name and email from these files > > Any particular reason why ? > > Yes, I do have a particular reason why but it'

Re: [libvirt] [PATCH] snip my name and email

2018-03-28 Thread David Kiarie
On Wed, Mar 28, 2018 at 7:43 PM, Daniel P. Berrangé wrote: > On Wed, Mar 28, 2018 at 07:33:11PM +0300, David Kiarie wrote: > > On Wed, Mar 28, 2018 at 5:32 PM, Daniel P. Berrangé > > > wrote: > > > > > On Mon, Mar 26, 2018 at 10:29:06AM +0300, David Kiarie w

Re: [libvirt] [PATCH V3 2/4] src/xenconfig: Xen-xl parser

2015-01-06 Thread David kiarie
On Sun, Jan 4, 2015 at 9:00 PM, Jim Fehlig wrote: > Michal Privoznik wrote: > > On 16.12.2014 05:30, Jim Fehlig wrote: > >> diff --git a/src/xenconfig/xen_xl_disk.l b/src/xenconfig/xen_xl_disk.l > >> new file mode 100644 > >> index 000..164aa32 > >> --- /dev/null > >> +++ b/src/xenconfig/xen_

Re: [libvirt] [PATCH V2 2/4] src/xenconfig: Xen-xl parser

2014-10-02 Thread David kiarie
Hmm, any consensus on this? On Fri, Sep 12, 2014 at 4:17 PM, Eric Blake wrote: > On 09/11/2014 06:14 PM, Jim Fehlig wrote: > >> But also as mentioned before, I can't figure out how to convince >> automake to tell flex to generate the header file as well as the .c file. >> >> Eric, do you have an

Re: [libvirt] [PATCH V2 2/4] src/xenconfig: Xen-xl parser

2014-09-12 Thread David Kiarie
On Thu, Sep 11, 2014 at 06:14:12PM -0600, Jim Fehlig wrote: > Kiarie Kahurani wrote: > > Introduce a xen xl parser > > > > [...] > > > > > diff --git a/configure.ac b/configure.ac > > index f93c6c2..0daf411 100644 > > --- a/configure.ac > > +++ b/configure.ac > > @@ -2177,6 +2177,13 @@ if test

Re: [libvirt] [PATCH V2 0/4] Xen-xl parser

2014-09-10 Thread David kiarie
Aah, just noticed the tests are not working On Thu, Sep 11, 2014 at 7:10 AM, Kiarie Kahurani wrote: > Kiarie Kahurani (4): > src/xenconfig: Export helper functions > src/xenconfig: Xen-xl parser > src/xenconfig: Introduce xen-xl on virsh command line > tests: Tests for the xen-xl parser >

Re: [libvirt] Libvirtd not initializing after 65b7d553

2014-08-21 Thread David kiarie
wrote: > On Thu, Aug 21, 2014 at 11:48:15AM +0200, Michal Privoznik wrote: >> On 21.08.2014 11:40, David kiarie wrote: >> >Ooh forgot to say that this happens on a Xen system >> > >> >On Thu, Aug 21, 2014 at 12:36 PM, David Kiarie >> >wrote: >>

Re: [libvirt] Libvirtd not initializing after 65b7d553

2014-08-21 Thread David kiarie
Ooh forgot to say that this happens on a Xen system On Thu, Aug 21, 2014 at 12:36 PM, David Kiarie wrote: > > For some I cannot be able able to use virsh after 65b7d553. > > Libvirtd initializes without errors but I guess something is going > unreported > > $libvirtd -d

[libvirt] Libvirtd not initializing after 65b7d553

2014-08-21 Thread David Kiarie
For some I cannot be able able to use virsh after 65b7d553. Libvirtd initializes without errors but I guess something is going unreported $libvirtd -d 2014-08-21 09:29:22.748+: 468: info : libvirt version: 1.2.8 2014-08-21 09:29:22.748+: 468: warning : virGetHostname:665 : get

Re: [libvirt] [PATCH V5 09/12] src/xenxs: Refactor code formating OS config

2014-08-14 Thread David Kiarie
On Thu, Aug 14, 2014 at 12:15:32AM -0600, Jim Fehlig wrote: > Kiarie Kahurani wrote: > > introduce function > >xenFormatXMOS(virConfPtr conf,); > > > > I split this into three functions: > > - xenFormatXMEmulator > - xenFormatXMCDROM > - xenFormatXMOS > > Formating of emulator and

Re: [libvirt] [PATCH V5 08/12] src/xenxs: Refactor code formating CPU features config

2014-08-14 Thread David Kiarie
On Wed, Aug 13, 2014 at 05:35:52PM -0600, Jim Fehlig wrote: > Kiarie Kahurani wrote: > > introduce functions > > xenFormatXMCPUFeatures(virConfPtr conf, ..); > > which formats CPU features config instead > > > > Signed-off-by: Kiarie Kahurani > > --- > > src/xenxs/xen_xm.c

Re: [libvirt] [PATCH V5 04/12] src/xenxs: Refactor code formating virtual time config

2014-08-14 Thread David Kiarie
On Wed, Aug 13, 2014 at 05:15:58PM -0600, Jim Fehlig wrote: > Kiarie Kahurani wrote: > > introduce function > > xenFormatXMTimeOffset(virConfPtr conf,); > > which formats time config instead > > > > Signed-off-by: Kiarie Kahurani > > --- > > src/xenxs/xen_xm.c | 153 > > +++

Re: [libvirt] Initializing qemu driver

2014-08-12 Thread David kiarie
Ooh got something on the list, I build without qemu as I only care about Xen. On Wed, Aug 13, 2014 at 1:00 AM, David kiarie wrote: > Hi there, > > I get this errors trying to intialialize libvirtd > > $libvirtd -vvv > 2014-08-12 21:57:47.887+: 6449: info : libvirt version:

[libvirt] Initializing qemu driver

2014-08-12 Thread David kiarie
Hi there, I get this errors trying to intialialize libvirtd $libvirtd -vvv 2014-08-12 21:57:47.887+: 6449: info : libvirt version: 1.2.8 2014-08-12 21:57:47.887+: 6449: warning : virGetHostname:665 : getaddrinfo failed for 'linux-xzc4': Name or service not known 2014-08-12 21:57:48.034+00

Re: [libvirt] [PATCH V5 01/12] src/xenxs: Export code for reuse

2014-08-11 Thread David kiarie
On Tue, Aug 12, 2014 at 12:21 AM, Kiarie Kahurani wrote: > wrap code tagged for resuse into one function and export it > > Signed-off-by: Kiarie Kahurani > --- > src/xenxs/xen_xm.c | 73 > +++--- > src/xenxs/xen_xm.h | 2 ++ > 2 files changed, 44

Re: [libvirt] [PATCH 12/24] src/xenxs: Refactor code parsing OS config

2014-08-09 Thread David Kiarie
On Fri, Aug 08, 2014 at 03:50:44PM -0600, Jim Fehlig wrote: > Kiarie Kahurani wrote: > > introduce function > > xenParseXMOS(virConfPtr conf,...); > > which parses the OS config instead > > > > signed-off-by: Kiarie Kahurani > > Signed-off-by: Kiarie Kahurani > > --- > > src/xenxs/xen_

[libvirt] [PATCH V3 11/24] src/xenxs:Refactor code parsing general config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani introduce function xenParseXMGeneralMeta(virConfPtr conf, ...); which parses general metadata instead signed-off-by: David Kiarie --- src/xenxs/xen_xm.c | 58 -- 1 file changed, 35 insertions(+), 23 deletions

[libvirt] [PATCH V3 24/24] src/xenxs:Export code

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani export code for reuse and some formating fix signed-off-by:David Kiarie --- src/xenxs/xen_xm.c | 59 +- src/xenxs/xen_xm.h | 4 +- tests/xmconfigdata/test-escape-paths.cfg | 2 +

[libvirt] [PATCH V3 16/24] src/xenxs:Refactor code formating virtual time config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani introduce function xenFormatXMTimeOffset(virConfPtr conf,); which formats time config instead signed-off-by: David Kiarie --- src/xenxs/xen_xm.c | 153 - 1 file changed, 82 insertions(+), 71 deletions(-) diff

[libvirt] [PATCH V3 22/24] src/xenxs:Refactor code formating Vfb config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani introduce function xenFormatXMVfb(virConfPtr conf,.); which formats Vfb config instead signed-off-by: David Kiarie --- src/xenxs/xen_xm.c | 171 ++--- 1 file changed, 97 insertions(+), 74 deletions(-) diff --git

[libvirt] [PATCH V3 09/24] src/xenxs:Refactor code parsing Vif config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani introduce function xenParseXMVif(virConfPtr conf,); which parses Vfb config instead signed-off-by: David Kiarie --- src/xenxs/xen_xm.c | 283 +++-- 1 file changed, 143 insertions(+), 140 deletions(-) diff --git a

[libvirt] [PATCH V3 23/24] src/xenxs:Refactor code formating emulated devices config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani introduce function xenFormatXMEmulatedHardware(virConfPtr conf,); which formats emulated hardware config instead signed-off-by: David Kiarie --- src/xenxs/xen_xm.c | 150 + tests/xmconfigdata/test-escape-paths.cfg

[libvirt] [PATCH V3 21/24] src/xenxs:Refactor code formating OS config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani introduce function xenFormatXMOS(virConfPtr conf,); which formats OS config instead signed-off-by: David Kiarie --- src/xenxs/xen_xm.c | 95 -- tests/xmconfigdata/test-escape-paths.cfg | 2 +- tests

[libvirt] [PATCH V3 14/24] src/xenxs:Refactor code formating general VM config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani introduce function xenFormatXMGeneralMeta(virConfPtr conf,..); which parses uuid and name instead signed-off-by:David Kiarie --- src/xenxs/xen_xm.c | 53 - 1 file changed, 32 insertions(+), 21 deletions(-) diff --g

[libvirt] [PATCH V3 20/24] src/xenxs:Refactor code formating CPU features config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani introduce functions xenFormatXMCPUFeatures(virConfPtr conf, ..); which formats CPU features config instead signed-off-by: David Kiarie --- src/xenxs/xen_xm.c | 118 - tests/xmconfigdata/test-escape-paths.cfg

[libvirt] [PATCH V3 18/24] src/xenxs:Refactor code formating Char devices config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani introduce function xenFormatXMCharDev(virConfPtr conf,); which formats Char devices config instead signed-off-by: David Kiarie --- src/xenxs/xen_xm.c | 163 ++--- 1 file changed, 91 insertions(+), 72 deletions

[libvirt] [PATCH V3 15/24] src/xenxs:Refactor code formating memory config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani introduce fucntion xenFormatXMMem(virConfPtr conf,...); which parses memory config instead signed-off-by: David Kiarie --- src/xenxs/xen_xm.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/src/xenxs/xen_xm.c b/src

[libvirt] [PATCH V3 19/24] src/xenxs:Refactor code formating xm disk config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani introduce function xenFormatXMDomainDisks(virConfPtr conf,.); which formats domain disks config instead signed-off-by: David Kiarie --- src/xenxs/xen_xm.c | 72 +- 1 file changed, 44 insertions(+), 28 deletions

[libvirt] [PATCH V3 07/24] src/xenxs:Refactor code parsing Vfb config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani introduce function xenParseXMVfb(virConfPtr conf,..); which parses Vfb config instead signed-off-by: David Kiarie --- src/xenxs/xen_xm.c | 301 +++-- 1 file changed, 155 insertions(+), 146 deletions(-) diff --git a

[libvirt] [PATCH V3 17/24] src/xenxs:Refactor code formating event actions config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani introduce function xenFormatXMEventActions(virConfPtr conf,.); which formats event actions instead signed-off-by: David Kiarie --- src/xenxs/xen_xm.c | 63 +++--- 1 file changed, 36 insertions(+), 27 deletions

[libvirt] [PATCH V3 13/24] src/xenxs:Export code for reuse

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani wrap code tagged for resuse into onef function and export it signed-off-by: David Kiarie --- src/xenxs/xen_xm.c | 71 -- src/xenxs/xen_xm.h | 2 ++ 2 files changed, 44 insertions(+), 29 deletions(-) diff --git a/src

[libvirt] [PATCH V3 08/24] src/xenxs:Refactor code parsing Char devices config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani introduce function xenParseXMCharDev(virConfPtr conf,.); which parses Char devices config instead signed-off-by: David Kiarie --- src/xenxs/xen_xm.c | 174 - 1 file changed, 93 insertions(+), 81 deletions

[libvirt] [PATCH V3 12/24] src/xenxs:Refactor code parsing OS config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani introduce function xenParseXMOS(virConfPtr conf,...); which parses the OS config instead signed-off-by: David Kiarie --- src/xenxs/xen_xm.c | 80 ++ 1 file changed, 50 insertions(+), 30 deletions(-) diff --git

[libvirt] [PATCH V3 10/24] src/xenxs:Refactor code parsing emulated hardware config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani introduce function xenParseXMEmulatedHardware(virConfPtr conf,.); which parses emulated devices config instead signed-off-by: David Kiarie --- src/xenxs/xen_xm.c | 82 -- 1 file changed, 48 insertions(+), 34

[libvirt] [PATCH V3 05/24] src/xenxs:Refactor code parsing CPU features

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani introduce function xenParseXMCPUFeatures(virConfPtr conf,.); which parses CPU features instead signed-off-by: David Kiarie --- src/xenxs/xen_xm.c | 127 +++-- 1 file changed, 74 insertions(+), 53 deletions(-) diff

[libvirt] [PATCH V3 01/24] src/xenxs:Refactor code parsing memory config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani introduce function xenParseXMMem(virConfPtr conf,.); which parses memory config instead signed-off-by: David Kiarie --- src/xenxs/xen_xm.c | 83 +- 1 file changed, 45 insertions(+), 38 deletions(-) diff --git

[libvirt] [PATCH V3 04/24] src/xenxs:Refactor code parsing PCI config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani introduce funtion xenParseXMPCI(virConfPtr conf, ); which parses PCI config instead signed-off-by: David Kiarie --- src/xenxs/xen_xm.c | 185 +++-- 1 file changed, 95 insertions(+), 90 deletions(-) diff --git a

[libvirt] [PATCH V3 03/24] src/xenxs:Refactor code parsing event actions

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani introduce function xenParseXMEventActions(virConfPtr conf,) which parses events leading to certain actions signed-off-by: David Kiarie --- src/xenxs/xen_xm.c | 61 +- 1 file changed, 37 insertions(+), 24

[libvirt] [PATCH V3 02/24] src/xenxs:Refactor code parsing virtual time config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani introduce function xenParseXMTimeOffset(virConfPtr conf,...); which parses time offset config instead signed-off-by: David Kiarie --- src/xenxs/xen_xm.c | 71 +- 1 file changed, 43 insertions(+), 28 deletions

[libvirt] [PATCH V3 06/24] src/xenxs:Refactor code parsing xm disk config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani introduce function xenParseXMDisk(virConfPtr conf, ); which parses xm disk config instead signed-off-by: David Kiarie --- src/xenxs/xen_xm.c | 322 - 1 file changed, 168 insertions(+), 154 deletions(-) diff

[libvirt] [PATCH V3 00/24] xen_xm parsing code refactor

2014-08-06 Thread David Kiarie
Kiarie Kahurani (24): src/xenxs:Refactor code parsing memory config src/xenxs:Refactor code parsing virtual time config src/xenxs:Refactor code parsing event actions src/xenxs:Refactor code parsing PCI config src/xenxs:Refactor code parsing CPU features src/xenxs:Refactor code parsing x

[libvirt] [PATCH v2 25/25] src/xenxs:Export code to be reused

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani Introduce function xenFormatConfigCommon( ); which wraps code to be reused.Again I have being forced to make changes on the layout of the tests signed-off-by: David Kiarie --- src/xenxs/xen_xm.c | 56 +++--- src/xenxs

[libvirt] [PATCH v2 21/25] src/xenxs:Refactor code formating disk list

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani introduce function xenFormatXMDiskList(virConfPtr conf, .); which formats xm disk config instead signed-off-by: David Kiarie --- src/xenxs/xen_xm.c | 73 ++ 1 file changed, 46 insertions(+), 27 deletions(-) diff

[libvirt] [PATCH v2 23/25] src/xenxs:Refactor char devices formating code

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani introduce function xenFormatXMCharDev(virConfPtr conf,.); which formats char devices related config signed-off-by: David Kiarie --- src/xenxs/xen_xm.c | 163 + 1 file changed, 90 insertions(+), 73 deletions

[libvirt] [PATCH v2 18/25] src/xenxs:Refactor code formating Vif config

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani introduce function xenFormatXMVif(virConfPtr conf, ); which formats Vif config instead signed-off-by: David Kiarie --- src/xenxs/xen_xm.c | 60 ++ 1 file changed, 38 insertions(+), 22 deletions(-) diff --git a

[libvirt] [PATCH v2 24/25] src/xenxs:Refactor code formating OS config

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani introduce function xenFormatXMOS( ); which formats config options related to OS signed-off-by:David Kiarie --- src/xenxs/xen_xm.c | 72 -- tests/xmconfigdata/test-escape-paths.cfg | 2 +- tests/xmconfigdata/

[libvirt] [PATCH v2 20/25] src/xenxs:Refactor code formating CPU config and features

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani introduce function xenFormatXMCPUFeatures(virConfPtr conf,.); which formats the config instead. I have also made a few changes on the layout of the tests to enable grouping of the code into a function. --- src/xenxs/xen_xm.c | 119

[libvirt] [PATCH v2 22/25] src/xenxs:Refactor code formating emulated devices config

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani introduce function xenFormatXMEmulatedDevices(virConfPtr conf,...) which formats emulated devices config instead signed-off-by: David Kiarie --- src/xenxs/xen_xm.c | 86 +- tests/xmconfigdata/test-escape

[libvirt] [PATCH v2 11/25] src/xenxs:Refactor code parsing emulated hardware config

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani introduce function xenParseXMEmulatedDevices(virConfPtr conf,...) which parses the emulated hardware instead signed-off-by: David Kiarie --- src/xenxs/xen_xm.c | 93 +++--- 1 file changed, 47 insertions(+), 46

[libvirt] [PATCH v2 16/25] src/xenxs:Reafactor code formating virtual time config

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani introduce function xenFormatXMTimeOffset(virConfPtr conf, ...); which formats time offset config instead signed-off-by: David Kiarie --- src/xenxs/xen_xm.c | 156 - 1 file changed, 84 insertions(+), 72 deletions

[libvirt] [PATCH v2 19/25] src/xenxs:Refactor code formating Vfb config

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani introduce function xenFormatXMVfb(virConfPtr conf, ); which formats Vfb config instead signed-off-by: David Kiarie --- src/xenxs/xen_xm.c | 218 + 1 file changed, 119 insertions(+), 99 deletions(-) diff --git a

[libvirt] [PATCH v2 13/25] src/xenxs:Organise functions to avoid duplication

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani In the refactored code I have wrapped common code in one function that I will use latter signed-off-by: David Kiarie --- src/xenxs/xen_xm.c | 60 +- src/xenxs/xen_xm.h | 2 ++ 2 files changed, 43 insertions(+), 19

[libvirt] [PATCH v2 17/25] src/xenxs:Refactor code formating event actions config

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani introduce function xenFormatXMEventActions(virConfPtr conf, ...); which formats event actions config instead signed-off-by: David Kiarie --- src/xenxs/xen_xm.c | 64 ++ 1 file changed, 36 insertions(+), 28

[libvirt] [PATCH v2 12/25] src/xenxs:Refactor code parsing general config

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani introduce function xenParseXMGeneralMeta(virConfPtr conf,..) which parses features like hvm= ?, builder and sets the default machine type incase its not specified signed-off-by: David Kiarie --- src/xenxs/xen_xm.c | 43 --- 1

[libvirt] [PATCH v2 04/25] src/xenxs:Refactor code parsing PCI devices config

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani Introduce function xenParseXMPCI(virConfPtr conf,..); which parses PCI config instead signed-off-by: David Kiarie --- src/xenxs/xen_xm.c | 185 +++-- 1 file changed, 94 insertions(+), 91 deletions(-) diff --git a/src

[libvirt] [PATCH v2 05/25] src/xenxs:Refactor code parsing CPU features config

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani Introduce function xenParseXMPCI(virConfPtr conf,..); which parses CPU Features and allocation config instead signed-off-by: David Kiarie --- src/xenxs/xen_xm.c | 126 +++-- 1 file changed, 73 insertions(+), 53

[libvirt] [PATCH v2 08/25] src/xenxs:Refactor code parsing OS related config

2014-07-26 Thread David Kiarie
From: Kiarie Kahurani introduce function xenParseXMOS(virConfPtr conf,...) which parses OS config instead signed-off-by: David Kiarie --- src/xenxs/xen_xm.c | 132 ++--- 1 file changed, 75 insertions(+), 57 deletions(-) diff --git a/src

  1   2   >