[libvirt] [libvirt PATCHv8 1/1] add DHCP snooping

2012-03-30 Thread David L Stevens
ive leases are saved in a lease file and reloaded on restart or HUP. Changes since v7: - renamed functions as suggested - collected local state into "virNWFilterSnoopState" struct - cleaned up include file list - misc code cleanups per review comments Signed-off-by: David L Stevens --- d

[libvirt] [libvirt PATCHv7 1/1] add DHCP snooping

2012-03-26 Thread David L Stevens
ive leases are saved in a lease file and reloaded on restart or HUP. Changes since v6: - replace pthread_cancel() with synchronous cancelation method Signed-off-by: David L Stevens --- docs/formatnwfilter.html.in| 17 + src/Makefile.am|2 + src/n

[libvirt] [libvirt PATCHv6 1/1] add DHCP snooping

2012-03-22 Thread David L Stevens
ive leases are saved in a lease file and reloaded on restart or HUP. Changes since v5: - use VMUUID+MAC to identify interfaces for leases - use direct pthread_cancel to kill snooper threads to avoid races with re-used host interfaces Signed-off-by: David L Stevens --- docs/formatnwfilter.html

[libvirt] [libvirt PATCHv5 2/2] add leasefile support

2011-11-10 Thread David L Stevens
This patch adds support for saving DHCP snooping leases to an on-disk file and restoring saved leases that are still active on restart. Signed-off-by: David L Stevens --- src/nwfilter/nwfilter_dhcpsnoop.c | 270 + 1 files changed, 243 insertions

[libvirt] [libvirt PATCHv5 0/2] add DHCP Snooping support for libvirt

2011-11-10 Thread David L Stevens
). Differences from v4: - added documentation of "ip_learning" - added support for kill -HUP reloading - simplified lease file handling David L Stevens (2): add DHCP snooping add leasefile support docs/formatnwfilter.html.in | 17 + examples/xml/nwf

[libvirt] [libvirt PATCHv5 1/2] add DHCP snooping

2011-11-10 Thread David L Stevens
This patch adds DHCP Snooping support to libvirt. Signed-off-by: David L Stevens --- docs/formatnwfilter.html.in | 17 + examples/xml/nwfilter/no-ip-spoofing.xml |5 + src/Makefile.am |2 + src/nwfilter/nwfilter_dhcpsnoop.c| 745

[libvirt] [libvirt PATCHv4 0/2] DHCP Snooping support for libvirt

2011-10-24 Thread David L Stevens
Differences from v3: removed support for multiple IP addresses. This version, like this existing code, allows only one IP address per interface. David L Stevens (2): add DHCP snooping add leasefile support examples/xml/nwfilter/no-ip-spoofing.xml |5 + src/Makefile.am

[libvirt] [libvirt PATCHv4 1/2] add DHCP snooping

2011-10-24 Thread David L Stevens
This patch adds DHCP Snooping support to libvirt. Signed-off-by: David L Stevens --- examples/xml/nwfilter/no-ip-spoofing.xml |5 + src/Makefile.am |2 + src/nwfilter/nwfilter_dhcpsnoop.c| 705 ++ src/nwfilter

[libvirt] [libvirt PATCHv4 2/2] add leasefile support

2011-10-24 Thread David L Stevens
This patch adds support for saving DHCP snooping leases to an on-disk file and restoring saved leases that are still active on restart. Signed-off-by: David L Stevens --- src/nwfilter/nwfilter_dhcpsnoop.c | 312 - 1 files changed, 306 insertions

[libvirt] [libvirt PATCH] support continue/return targets in nwfilter

2011-10-18 Thread David L Stevens
This patch adds support for "continue" and "return" actions in filter rules. Signed-off-by: David L Stevens diff --git a/src/conf/nwfilter_conf.c b/src/conf/nwfilter_conf.c index 04bfa22..3e28806 100644 --- a/src/conf/nwfilter_conf.c +++ b/src/conf/nwfilter_con

[libvirt] [libvirt PATCHv3 02/10] allow required ARP packets

2011-10-12 Thread David L Stevens
removes the unnecessary check for arpop of request or reply. Signed-off-by: David L Stevens --- examples/xml/nwfilter/no-arp-spoofing.xml | 23 ++- 1 files changed, 2 insertions(+), 21 deletions(-) diff --git a/examples/xml/nwfilter/no-arp-spoofing.xml b/examples/xml

[libvirt] [libvirt PATCHv3 03/10] reverse sense of address matching

2011-10-12 Thread David L Stevens
chains that can check multiple MAC or IP addresses in any combination. This patch itself does not support multiple addresses via the MAC and IP variables, but only changes the form of the rules to allow multiple addresses in the future. Signed-off-by: David L Stevens --- examples/xml/nwfilter/Makefil

[libvirt] [libvirt PATCHv3 09/10] add leasefile support

2011-10-12 Thread David L Stevens
This patch adds support for saving DHCP snooping leases to an on-disk file and restoring saved leases that are still active on restart. Signed-off-by: David L Stevens --- src/nwfilter/nwfilter_dhcpsnoop.c | 370 +++-- 1 files changed, 353 insertions

[libvirt] [libvirt PATCHv3 00/10] DHCP snooping support for libvirt

2011-10-12 Thread David L Stevens
Differences from v2: added support for multiple static IP addresses using a comma-separated list. David L Stevens (10): support continue/return allow required ARP packets reverse sense of address matching make default chain policy "DROP" allow chain modifi

[libvirt] [libvirt PATCHv3 06/10] support addRules

2011-10-12 Thread David L Stevens
This patch adds the capability of adding individual rules to existing chains. Signed-off-by: David L Stevens --- src/conf/nwfilter_conf.h |6 ++ src/nwfilter/nwfilter_ebiptables_driver.c | 73 + 2 files changed, 79 insertions(+), 0 deletions

[libvirt] [libvirt PATCHv3 10/10] support multiple static IP addresses

2011-10-12 Thread David L Stevens
This patch adds support for multiple static IP addresses in a comma-separated list. For example: ... Signed-off-by: David L Stevens --- src/nwfilter/nwfilter_gentech_driver.c | 26 ++ 1 files changed, 26 insertions

[libvirt] [libvirt PATCHv3 05/10] allow chain modification

2011-10-12 Thread David L Stevens
., instantiate only when a given variable is present in a filter, or only when it is not). Signed-off-by: David L Stevens --- src/conf/nwfilter_conf.h |4 +- src/nwfilter/nwfilter_ebiptables_driver.c | 93 + src/nwfilter/nwfilter_gentech_driver.c

[libvirt] [libvirt PATCHv3 04/10] make default chain policy "DROP"

2011-10-12 Thread David L Stevens
This patch simplifies the table rules by setting the protocol chains policy to be "DROP" and removes the explicit "-j DROP" entries that the protocol rules had previously. It also makes "no-other-rarp-traffic.xml" obsolete. Signed-off-by: David L Steve

[libvirt] [libvirt PATCHv3 07/10] support variable value changing

2011-10-12 Thread David L Stevens
ach of the different values. These rules can later be removed by calling this function with the same variable and value and "delete" argument set to "1". Signed-off-by: David L Stevens --- src/nwfilter/nwfilter_gentech_driver.c | 86 src/nwfi

[libvirt] [libvirt PATCHv3 01/10] support continue/return

2011-10-12 Thread David L Stevens
This patch adds support for "continue" and "return" actions in filter rules. Signed-off-by: David L Stevens --- src/conf/nwfilter_conf.c |8 ++-- src/conf/nwfilter_conf.h |2 ++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/conf/n

[libvirt] [libvirt PATCHv3 08/10] add DHCP snooping

2011-10-12 Thread David L Stevens
This patch adds DHCP Snooping support to libvirt. Signed-off-by: David L Stevens --- examples/xml/nwfilter/no-ip-spoofing.xml |5 + src/Makefile.am |2 + src/nwfilter/nwfilter_dhcpsnoop.c| 602 ++ src/nwfilter

[libvirt] [RFC PATCHv2 9/9] add leasefile support

2011-10-05 Thread David L Stevens
This patch adds support for saving DHCP snooping leases to an on-disk file and restoring saved leases that are still active on restart. Signed-off-by: David L Stevens --- src/nwfilter/nwfilter_dhcpsnoop.c | 370 +++-- 1 files changed, 353 insertions

[libvirt] [RFC PATCHv2 6/9] support addRules

2011-10-05 Thread David L Stevens
This patch adds the capability of adding individual rules to existing chains. Signed-off-by: David L Stevens --- src/conf/nwfilter_conf.h |6 ++ src/nwfilter/nwfilter_ebiptables_driver.c | 73 + 2 files changed, 79 insertions(+), 0 deletions

[libvirt] [RFC PATCHv2 5/9] allow chain modification

2011-10-05 Thread David L Stevens
., instantiate only when a given variable is present in a filter, or only when it is not). Signed-off-by: David L Stevens --- src/conf/nwfilter_conf.h |4 +- src/nwfilter/nwfilter_ebiptables_driver.c | 93 + src/nwfilter/nwfilter_gentech_driver.c

[libvirt] [RFC PATCHv2 1/9] support continue/return

2011-10-05 Thread David L Stevens
This patch adds support for "continue" and "return" actions in filter rules. Signed-off-by: David L Stevens --- src/conf/nwfilter_conf.c |8 ++-- src/conf/nwfilter_conf.h |2 ++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/conf/n

[libvirt] [RFC PATCHv2 7/9] support variable value changing

2011-10-05 Thread David L Stevens
ach of the different values. These rules can later be removed by calling this function with the same variable and value and "delete" argument set to "1". Signed-off-by: David L Stevens --- src/nwfilter/nwfilter_gentech_driver.c | 86 src/nwfi

[libvirt] [RFC PATCHv2 8/9] add DHCP snooping

2011-10-05 Thread David L Stevens
This patch adds DHCP Snooping support to libvirt. Signed-off-by: David L Stevens --- examples/xml/nwfilter/no-ip-spoofing.xml |5 + src/Makefile.am |2 + src/nwfilter/nwfilter_dhcpsnoop.c| 602 ++ src/nwfilter

[libvirt] [RFC PATCHv2 2/9] allow required ARP packets

2011-10-05 Thread David L Stevens
removes the unnecessary check for arpop of request or reply. Signed-off-by: David L Stevens --- examples/xml/nwfilter/no-arp-spoofing.xml | 23 ++- 1 files changed, 2 insertions(+), 21 deletions(-) diff --git a/examples/xml/nwfilter/no-arp-spoofing.xml b/examples/xml

[libvirt] [RFC PATCHv2 4/9] make default chain policy "DROP"

2011-10-05 Thread David L Stevens
This patch simplifies the table rules by setting the protocol chains policy to be "DROP" and removes the explicit "-j DROP" entries that the protocol rules had previously. It also makes "no-other-rarp-traffic.xml" obsolete. Signed-off-by: David L Steve

[libvirt] [RFC PATCHv2 3/9] reverse sense of address matching

2011-10-05 Thread David L Stevens
chains that can check multiple MAC or IP addresses in any combination. This patch itself does not support multiple addresses via the MAC and IP variables, but only changes the form of the rules to allow multiple addresses in the future. Signed-off-by: David L Stevens --- examples/xml/nwfilter/Makefil

[libvirt] [RFC PATCHv2 0/9] DHCP snooping support for libvirt.

2011-10-05 Thread David L Stevens
"none" (static only addresses) or "DHCP" (DHCP Snooping). This code does not (yet) support passing lease information across a migration. A migrated guest requires a DHCP ACK (e.g., via ifdown/ifup on the guest) to send/receive traffic for DHCP-learned addresses after a mi

[libvirt] [PATCH 8/9] add DHCP snooping support to nwfilter

2011-05-09 Thread David L Stevens
This patch adds DHCP Snooping support to libvirt. Signed-off-by: David L Stevens diff --git a/examples/xml/nwfilter/no-ip-spoofing.xml b/examples/xml/nwfilter/no-ip-spoofing.xml index 2fccd12..2ae9500 100644 --- a/examples/xml/nwfilter/no-ip-spoofing.xml +++ b/examples/xml/nwfilter/no-ip

[libvirt] [PATCH 9/9] add DHCP snooping support to nwfilter

2011-05-09 Thread David L Stevens
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 7/9] add DHCP snooping support to nwfilter

2011-05-09 Thread David L Stevens
ach of the different values. These rules can later be removed by calling this function with the same variable and value and "delete" argument set to "1". Signed-off-by: David L Stevens diff --git a/src/nwfilter/nwfilter_gentech_driver.c b/src/nwfilter/nwfilter_gentech_driver.c

[libvirt] [PATCH 9/9] add DHCP snooping support to nwfilter

2011-05-09 Thread David L Stevens
This patch removes remaining pieces of IP address learning. diff --git a/src/Makefile.am b/src/Makefile.am index 3da0797..53cdc00 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -389,9 +389,7 @@ NWFILTER_DRIVER_SOURCES = \ nwfilter/nwfilter_

[libvirt] [PATCH 7/9] add DHCP snooping support to nwfilter

2011-05-09 Thread David L Stevens
ach of the different values. These rules can later be removed by calling this function with the same variable and value and "delete" argument set to "1". Signed-off-by: David L Stevens diff --git a/src/nwfilter/nwfilter_gentech_driver.c b/src/nwfilter/nwfilter_gentech_driver.c

[libvirt] [PATCH 8/9] add DHCP snooping support to nwfilter

2011-05-09 Thread David L Stevens
This patch adds DHCP Snooping support to libvirt. Signed-off-by: David L Stevens diff --git a/examples/xml/nwfilter/no-ip-spoofing.xml b/examples/xml/nwfilter/no-ip-spoofing.xml index 2fccd12..2ae9500 100644 --- a/examples/xml/nwfilter/no-ip-spoofing.xml +++ b/examples/xml/nwfilter/no-ip

[libvirt] [PATCH 6/9] add DHCP snooping support to nwfilter

2011-05-09 Thread David L Stevens
This patch adds the capability of adding individual rules to existing chains. Signed-off-by: David L Stevens diff --git a/src/conf/nwfilter_conf.h b/src/conf/nwfilter_conf.h index 25f7b60..4b6759a 100644 --- a/src/conf/nwfilter_conf.h +++ b/src/conf/nwfilter_conf.h @@ -532,6 +532,11 @@ typedef

[libvirt] [PATCH 6/9] add DHCP snooping support to nwfilter

2011-05-09 Thread David L Stevens
This patch adds the capability of adding individual rules to existing chains. Signed-off-by: David L Stevens diff --git a/src/conf/nwfilter_conf.h b/src/conf/nwfilter_conf.h index 25f7b60..4b6759a 100644 --- a/src/conf/nwfilter_conf.h +++ b/src/conf/nwfilter_conf.h @@ -532,6 +532,11 @@ typedef

[libvirt] [PATCH 4/9] add DHCP snooping support to nwfilter

2011-05-09 Thread David L Stevens
This patch simplifies the table rules by setting the protocol chains policy to be "DROP" and removes the explicit "-j DROP" entries that the protocol rules had previously. It also makes "no-other-rarp-traffic.xml" obsolete. Signed-off-by: David L Stevens diff

[libvirt] [PATCH 5/9] add DHCP snooping support to nwfilter

2011-05-09 Thread David L Stevens
only when a given variable is present in a filter, or only when it is not). Signed-off-by: David L Stevens diff --git a/src/conf/nwfilter_conf.h b/src/conf/nwfilter_conf.h index 72bdade..25f7b60 100644 --- a/src/conf/nwfilter_conf.h +++ b/src/conf/nwfilter_conf.h @@ -517,7 +517,9 @@ typedef int

[libvirt] [PATCH 4/9] add DHCP snooping support to nwfilter

2011-05-09 Thread David L Stevens
This patch simplifies the table rules by setting the protocol chains policy to be "DROP" and removes the explicit "-j DROP" entries that the protocol rules had previously. It also makes "no-other-rarp-traffic.xml" obsolete. Signed-off-by: David L Stevens diff

[libvirt] [PATCH 5/9] add DHCP snooping support to nwfilter

2011-05-09 Thread David L Stevens
only when a given variable is present in a filter, or only when it is not). Signed-off-by: David L Stevens diff --git a/src/conf/nwfilter_conf.h b/src/conf/nwfilter_conf.h index 72bdade..25f7b60 100644 --- a/src/conf/nwfilter_conf.h +++ b/src/conf/nwfilter_conf.h @@ -517,7 +517,9 @@ typedef int

[libvirt] [PATCH 3/9] add DHCP snooping support to nwfilter

2011-05-09 Thread David L Stevens
chains that can check multiple MAC or IP addresses in any combination. This patch itself does not support multiple addresses via the MAC and IP variables, but only changes the form of the rules to allow multiple addresses in the future. Signed-off-by: David L Stevens diff --git a/examples/xml/nwfil

[libvirt] [PATCH 3/9] add DHCP snooping support to nwfilter

2011-05-09 Thread David L Stevens
chains that can check multiple MAC or IP addresses in any combination. This patch itself does not support multiple addresses via the MAC and IP variables, but only changes the form of the rules to allow multiple addresses in the future. Signed-off-by: David L Stevens diff --git a/examples/xml/nwfil

[libvirt] [PATCH 2/9] add DHCP snooping support to nwfilter

2011-05-09 Thread David L Stevens
arpop of request or reply. Signed-off-by: David L Stevens diff --git a/examples/xml/nwfilter/no-arp-spoofing.xml b/examples/xml/nwfilter/no-arp-spoofing.xml index c6c858d..fdd4e60 100644 --- a/examples/xml/nwfilter/no-arp-spoofing.xml +++ b/examples/xml/nwfilter/no-arp-spoofing.xml @@ -12,21

[libvirt] [PATCH 0/9] add DHCP snooping support to nwfilter

2011-05-09 Thread David L Stevens
The following series of patches replaces IP address learning in network filtering with DHCP snooping. The existing address learning capability does not provide security since it relies on addresses used in initial packets sent by the guest to determine an IP address. A spoofing guest can s

[libvirt] [PATCH 1/9] add DHCP snooping support to nwfilter

2011-05-09 Thread David L Stevens
This patch adds support for "continue" and "return" actions in filter rules. Signed-off-by: David L Stevens diff --git a/src/conf/nwfilter_conf.c b/src/conf/nwfilter_conf.c index 13b5b38..6a15f04 100644 --- a/src/conf/nwfilter_conf.c +++ b/src/conf/nwfilter_con