Re: [libvirt] [PATCH] libxl: Avoid a variable named 'stat'

2017-08-24 Thread George Dunlap
> On Aug 24, 2017, at 3:24 PM, Andrea Bolognani <abolo...@redhat.com> wrote: > > On Thu, 2017-08-24 at 12:34 +0100, George Dunlap wrote: >> @@ -5401,12 +5401,12 @@ libxlDomainBlockStatsVBD(virDomainObjPtr vm, >> # define LIBXL_SET_VBDSTAT(FIELD, VAR, MUL)

[libvirt] [PATCH] libxl: Avoid a variable named 'stat'

2017-08-24 Thread George Dunlap
/stat.h:455: error: shadowed declaration is here [-Wshadow] Signed-off-by: George Dunlap <george.dun...@citrix.com> --- CC: Daniel P. Berrange <berra...@redhat.com> CC: Jim Fehlig <jfeh...@suse.com> CC: xen-de...@xenproject.org CC: libvir-list@redhat.com --- src/libxl/libxl_driver.c

Re: [libvirt] Questions about virtlogd

2016-06-08 Thread George Dunlap
On 07/06/16 16:57, Wei Liu wrote: >> I must admit I'm not familiar with the division of responsibility >> for managing QEMU between the Xen provided libxl library(s) and >> the libvirt libxl driver code. Naively I would expect the libvirt >> libxl driver code to deal with virtlogd and then

Re: [libvirt] [Xen-devel] [PATCH] libxl: use LIBXL_API_VERSION 0x040200

2016-04-14 Thread George Dunlap
On Thu, Apr 14, 2016 at 12:37 AM, Jim Fehlig wrote: > To ensure the libvirt libxl driver will build with future versions > of Xen where the libxl API may change in incompatible ways, > explicitly use LIBXL_API_VERSION 0x040200. The libxl driver > does use new libxl APIs that

Re: [libvirt] [Xen-devel] Fixing libvirt's libxl driver breakage -- where to define LIBXL_API_VERSION?

2016-04-13 Thread George Dunlap
On 13/04/16 10:26, Daniel P. Berrange wrote: > On Wed, Apr 13, 2016 at 10:09:16AM +0100, George Dunlap wrote: >> On Tue, Apr 12, 2016 at 10:31 PM, Jim Fehlig <jfeh...@suse.com> wrote: >>> Wei Liu wrote: >>>> Hi libvirt maintainers, >>> >>>

Re: [libvirt] [Xen-devel] Fixing libvirt's libxl driver breakage -- where to define LIBXL_API_VERSION?

2016-04-13 Thread George Dunlap
On Tue, Apr 12, 2016 at 10:31 PM, Jim Fehlig wrote: > Wei Liu wrote: >> Hi libvirt maintainers, > > Sorry for the delay. Slowly catching up on mail after vacation... > >> >> Xen's control library libxenlight (libxl) requires application >> (libvirt in this case) to explictily

Re: [libvirt] [PATCH v7 RFC 0/2] libxl USB prototype and design discussion

2014-06-18 Thread George Dunlap
On 06/18/2014 01:57 PM, Ian Campbell wrote: * Is it possible for the toolstack to tell if domU has a working and connected PVUSB front-end? It can observe the state variable being 4 I suppose. Why do you need to know? It might be nice to be able to create both a pv and an emulated controller

Re: [libvirt] [PATCH v7 RFC 0/2] libxl USB prototype and design discussion

2014-06-18 Thread George Dunlap
On 06/18/2014 01:57 PM, Ian Campbell wrote: * Is it possible to connect a USB 1.1 device to a PVUSB controller which has been specified 2.0, or would there have to be a separate virtual controller for each? I'm a bit surprised that PVUSB exposes the concept of a version to the FE at all. I

Re: [libvirt] [Xen-devel] [PATCH v7 RFC 0/2] libxl USB prototype and design discussion

2014-06-05 Thread George Dunlap
On Thu, Jun 5, 2014 at 11:14 AM, Daniel P. Berrange berra...@redhat.com wrote: On Mon, Jun 02, 2014 at 02:44:16PM +0100, George Dunlap wrote: == Libvirt's interface == I've had a brief look at libvirt's USB interface, and learned a bit about libvirt's general approach to things at the Xen

[libvirt] libvirt / libxl testing emails

2014-06-03 Thread George Dunlap
Ian / Ian, Daniel V. was lurking on a recent CentOS Virt SIG IRC meetings, and asked about testing the libvirt git repo against libxl. I mentioned that we already had some basic tests to do that, and he asked whether it would make sense to have the push gate e-mail the libvirt list. I have

Re: [libvirt] libvirt / libxl testing emails

2014-06-03 Thread George Dunlap
On 06/03/2014 03:30 PM, Daniel P. Berrange wrote: On Tue, Jun 03, 2014 at 03:16:49PM +0100, George Dunlap wrote: Ian / Ian, Daniel V. was lurking on a recent CentOS Virt SIG IRC meetings, and asked about testing the libvirt git repo against libxl. I mentioned that we already had some basic

[libvirt] [PATCH v7 RFC 0/2] libxl USB prototype and design discussion

2014-06-02 Thread George Dunlap
Hey all! So here I finally have a rebased the HVM USB hotplug series from last year. I went through and addressed all of IanC's technical comments that I could; so it should be in much better shape than it was. However, one of the unfinished threads of the conversation at that time was about

Re: [libvirt] [Xen-devel] [PATCH] Convert libxl driver to Xen 4.2

2012-11-27 Thread George Dunlap
On Mon, Nov 26, 2012 at 10:28 PM, Jim Fehlig jfeh...@suse.com wrote: Based on a patch originally authored by Daniel De Graaf http://lists.xen.org/archives/html/xen-devel/2012-05/msg00565.html This patch converts the Xen libxl driver to support only Xen = 4.2. Support for Xen 4.1 libxl is