Re: [libvirt] libvirt-guests.sh without or with failing ACPI support

2019-12-10 Thread Henning Schild
Am Tue, 10 Dec 2019 12:01:24 +0100 schrieb Christian Ehrhardt : > On Tue, Dec 10, 2019 at 10:46 AM Henning Schild > wrote: > > > Hi all, > > > > the systemd shutdown scripts work sequentially with a 300s timeout > > (seen on Debian). If a VM does not have ACPI

[libvirt] libvirt-guests.sh without or with failing ACPI support

2019-12-10 Thread Henning Schild
Hi all, the systemd shutdown scripts work sequentially with a 300s timeout (seen on Debian). If a VM does not have ACPI support, or the ACPI support failed for some reason, you are looking at a 300s timeout per instance for a host shutdown/reboot. i.e. 10 instances without working ACPI = 3000s to

[libvirt] libvirt-guests.sh stop

2019-12-10 Thread Henning Schild
Hi all, the shellscript causing VMs to eventually stop when the host shuts down/reboots has a window where it can loose ACPI shutdown events. I have seen VMs not shutting down before they become ACPI aware, causing the systemd magic to time out for a couple of minutes and eventually killing the V

Re: [libvirt] [Qemu-devel] pci-assign fails with read error on config-space file

2016-11-02 Thread Henning Schild
Am Wed, 2 Nov 2016 09:54:16 + schrieb "Daniel P. Berrange" : > On Fri, Oct 28, 2016 at 01:28:19PM +0200, Henning Schild wrote: > > Hey, > > > > i am running an unusual setup where i assign pci devices behind the > > back of libvirt. I have two options to

Re: [libvirt] [libvirt-users] pci-assign fails with read error on config-space file

2016-11-02 Thread Henning Schild
Am Fri, 28 Oct 2016 11:25:55 -0400 schrieb Laine Stump : > On 10/28/2016 07:28 AM, Henning Schild wrote: > > Hey, > > > > i am running an unusual setup where i assign pci devices behind the > > back of libvirt. I have two options to do that: > > 1. a wrapper s

Re: [libvirt] [Qemu-devel] pci-assign fails with read error on config-space file

2016-11-02 Thread Henning Schild
Am Fri, 28 Oct 2016 17:22:41 +0200 schrieb Laszlo Ersek : > On 10/28/16 13:28, Henning Schild wrote: > > Hey, > > > > i am running an unusual setup where i assign pci devices behind the > > back of libvirt. I have two options to do that: > > 1. a wrapper script

[libvirt] pci-assign fails with read error on config-space file

2016-10-30 Thread Henning Schild
Hey, i am running an unusual setup where i assign pci devices behind the back of libvirt. I have two options to do that: 1. a wrapper script for qemu that takes care of suid-root and appends arguments for pci-assign 2. virsh qemu-monitor-command ... 'device_add pci-assign...' I know i should prob

[libvirt] [PATCH] qemu: rename QEMU_CAPS_MLOCK to QEMU_CAPS_REALTIME_MLOCK

2016-07-25 Thread Henning Schild
Purely cosmetic change to be consistent with the other names. Signed-off-by: Henning Schild --- Something i found in an old staging queue and that might be considered useful. src/qemu/qemu_capabilities.c | 2 +- src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c | 4 ++-- tests

[libvirt] github and gitlab mirrors are far behind

2016-03-14 Thread Henning Schild
Hey, as the title says the mirrors are pretty far behind, probably something is broken there. Henning -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv2 2/3] qemu_cgroup: put qemu right into emulator sub-cgroup

2016-03-01 Thread Henning Schild
On Tue, 1 Mar 2016 12:34:44 +0100 Peter Krempa wrote: > On Tue, Mar 01, 2016 at 11:20:18 +, Daniel Berrange wrote: > > On Fri, Feb 26, 2016 at 04:34:23PM +0100, Henning Schild wrote: > > > Move qemuProcessSetupEmulator up under qemuSetupCgroup. That way > > >

Re: [libvirt] [PATCHv2 2/3] qemu_cgroup: put qemu right into emulator sub-cgroup

2016-03-01 Thread Henning Schild
On Tue, 1 Mar 2016 11:20:18 + "Daniel P. Berrange" wrote: > On Fri, Feb 26, 2016 at 04:34:23PM +0100, Henning Schild wrote: > > Move qemuProcessSetupEmulator up under qemuSetupCgroup. That way > > we move the one main thread right into the emulator cgroup, inste

[libvirt] [PATCHv2 1/3] vircgroup: one central point for adding tasks to cgroups

2016-02-26 Thread Henning Schild
Use virCgroupAddTaskController in virCgroupAddTask so we have one single point where we add tasks to cgroups. Signed-off-by: Henning Schild --- src/util/vircgroup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index 6ce208e

[libvirt] [PATCHv2 0/3] reorder qemu cgroups operations

2016-02-26 Thread Henning Schild
s based on 92ec2e5e9b79b7df4d575040224bd606ab0b6dd8 with these two patches on top: http://www.redhat.com/archives/libvir-list/2016-February/msg01211.html Henning Schild (3): vircgroup: one central point for adding tasks to cgroups qemu_cgroup: put qemu right into emulator sub-cgroup qemu_cgroup: use virCgr

[libvirt] [PATCHv2 3/3] qemu_cgroup: use virCgroupAddTask instead of virCgroupMoveTask

2016-02-26 Thread Henning Schild
qemuProcessSetupEmulator runs at a point in time where there is only the qemu main thread. Use virCgroupAddTask to put just that one task into the emulator cgroup. That patch makes virCgroupMoveTask and virCgroupAddTaskStrController obsolete. Signed-off-by: Henning Schild --- src

[libvirt] [PATCHv2 2/3] qemu_cgroup: put qemu right into emulator sub-cgroup

2016-02-26 Thread Henning Schild
Move qemuProcessSetupEmulator up under qemuSetupCgroup. That way we move the one main thread right into the emulator cgroup, instead of moving multiple threads later on. And we do not actually want any threads running in the parent cgroups (cpu cpuacct cpuset). Signed-off-by: Henning Schild

Re: [libvirt] [PATCH 5/9] qemu_cgroup: put qemu right into emulator sub-cgroup

2016-02-26 Thread Henning Schild
On Thu, 25 Feb 2016 17:53:30 -0500 John Ferlan wrote: > On 02/23/2016 10:58 AM, Henning Schild wrote: > > Move qemuSetupCgroupForEmulator up under qemuSetupCgroup. That way > > we move the one main thread right into the emulator cgroup, instead > > of moving multiple thread

Re: [libvirt] [PATCH 4/9] util: cgroups do not implicitly add task to new machine cgroup

2016-02-26 Thread Henning Schild
On Fri, 26 Feb 2016 13:26:36 + "Daniel P. Berrange" wrote: > On Fri, Feb 26, 2016 at 02:17:35PM +0100, Henning Schild wrote: > > On Fri, 26 Feb 2016 13:00:04 + > > "Daniel P. Berrange" wrote: > > > > > On Fri, Feb 26, 2016 at 01:43

Re: [libvirt] [PATCH 4/9] util: cgroups do not implicitly add task to new machine cgroup

2016-02-26 Thread Henning Schild
On Fri, 26 Feb 2016 13:00:04 + "Daniel P. Berrange" wrote: > On Fri, Feb 26, 2016 at 01:43:05PM +0100, Henning Schild wrote: > > On Fri, 26 Feb 2016 12:21:02 + > > "Daniel P. Berrange" wrote: > > > > > On Fri, Feb 26, 2016 at 01:16:

Re: [libvirt] [PATCH 5/9] qemu_cgroup: put qemu right into emulator sub-cgroup

2016-02-26 Thread Henning Schild
On Thu, 25 Feb 2016 17:53:30 -0500 John Ferlan wrote: > On 02/23/2016 10:58 AM, Henning Schild wrote: > > Move qemuSetupCgroupForEmulator up under qemuSetupCgroup. That way > > we move the one main thread right into the emulator cgroup, instead > > of moving multiple thread

Re: [libvirt] [PATCH 4/9] util: cgroups do not implicitly add task to new machine cgroup

2016-02-26 Thread Henning Schild
On Fri, 26 Feb 2016 12:21:02 + "Daniel P. Berrange" wrote: > On Fri, Feb 26, 2016 at 01:16:15PM +0100, Henning Schild wrote: > > On Fri, 26 Feb 2016 11:13:13 + > > "Daniel P. Berrange" wrote: > > > > > On Tue, Feb

Re: [libvirt] [PATCH 9/9] qemu_cgroup: assert threading cgroup layout for machine cgroup

2016-02-26 Thread Henning Schild
On Fri, 26 Feb 2016 12:02:52 + "Daniel P. Berrange" wrote: > On Fri, Feb 26, 2016 at 12:57:38PM +0100, Henning Schild wrote: > > On Fri, 26 Feb 2016 11:22:07 + > > "Daniel P. Berrange" wrote: > > > > > On Tue, Feb 23, 2016 at 04:5

Re: [libvirt] [PATCH 4/9] util: cgroups do not implicitly add task to new machine cgroup

2016-02-26 Thread Henning Schild
On Fri, 26 Feb 2016 11:13:13 + "Daniel P. Berrange" wrote: > On Tue, Feb 23, 2016 at 04:58:39PM +0100, Henning Schild wrote: > > virCgroupNewMachine used to add the pidleader to the newly created > > machine cgroup. Do not do this implicit anymore. > > &g

Re: [libvirt] [PATCH 9/9] qemu_cgroup: assert threading cgroup layout for machine cgroup

2016-02-26 Thread Henning Schild
On Fri, 26 Feb 2016 11:22:07 + "Daniel P. Berrange" wrote: > On Tue, Feb 23, 2016 at 04:58:44PM +0100, Henning Schild wrote: > > Make sure the thread related controls of the machine cgroup never > > get any tasks assigned. > > > > Signed-off-by:

Re: [libvirt] [PATCH 5/9] qemu_cgroup: put qemu right into emulator sub-cgroup

2016-02-26 Thread Henning Schild
On Fri, 26 Feb 2016 11:14:31 + "Daniel P. Berrange" wrote: > On Tue, Feb 23, 2016 at 04:58:40PM +0100, Henning Schild wrote: > > Move qemuSetupCgroupForEmulator up under qemuSetupCgroup. That way > > we move the one main thread right into the emulator cgroup, inste

Re: [libvirt] [PATCH 6/9] qemu_cgroup: use virCgroupAddTask instead of virCgroupMoveTask

2016-02-26 Thread Henning Schild
Is it ok do drop unused code in the same patch that makes the code obsolete, or should i split that up? On Tue, 23 Feb 2016 16:58:41 +0100 Henning Schild wrote: > qemuSetupCgroupForEmulator runs at a point in time where there is only > the qemu main thread. Use virCgroupAddTask to put jus

Re: [libvirt] [PATCH 0/9] fix thread related controllers in cgroups

2016-02-26 Thread Henning Schild
the complexity of the "bringup" and the importance > of getting that right, i think they should go in as well! > > The tricky bits are in patches 5 and 8, i kept them as simple as > possible. > > The series is based on v1.3.1. > > Henning Schild (9): > v

Re: [libvirt] [PATCH 2/9] vircgroup: add assertion to allow cgroup controllers to stay empty

2016-02-26 Thread Henning Schild
Ok i will reorder, fix style and docs etc. On Thu, 25 Feb 2016 17:52:55 -0500 John Ferlan wrote: > On 02/23/2016 10:58 AM, Henning Schild wrote: > > When using a hierarchy of cgroups we might want to add tasks just to > > the children cgroups but never to the parent. To make

Re: [libvirt] [PATCH 3/9] vircgroup: introduce controller mask for threads

2016-02-26 Thread Henning Schild
On Thu, 25 Feb 2016 17:53:07 -0500 John Ferlan wrote: > On 02/23/2016 10:58 AM, Henning Schild wrote: > > When using a cgroups hierarchy threads have child cgroups for > > certain controllers. Introduce an enum for later reuse. > > > > Signed-off-by: Henning Sc

Re: [libvirt] [PATCH] make-kpkg: add support for "make olddefconfig"

2016-02-23 Thread Henning Schild
Sorry that one is unrelated. Ignore it. On Tue, 23 Feb 2016 16:58:35 +0100 Henning Schild wrote: > Signed-off-by: Henning Schild > --- > make-kpkg | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/make-kpkg b/make-kpkg > index 5cb8ec3..ba663c

Re: [libvirt] [PATCH] add support for "make olddefconfig"

2016-02-23 Thread Henning Schild
Sorry that one is unrelated. Ignore it. On Tue, 23 Feb 2016 16:58:34 +0100 Henning Schild wrote: > Signed-off-by: Henning Schild > --- > make-kpkg | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/make-kpkg b/make-kpkg > index 5cb8ec3..ba663c

[libvirt] [PATCH 8/9] qemu_cgroup: dont put qemu main thread into wrong cgroup

2016-02-23 Thread Henning Schild
not put the task into the machine cgroup controllers just to move it out to the emulator subgroup later. Signed-off-by: Henning Schild --- src/qemu/qemu_cgroup.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index 41a583c

[libvirt] [PATCH 4/9] util: cgroups do not implicitly add task to new machine cgroup

2016-02-23 Thread Henning Schild
virCgroupNewMachine used to add the pidleader to the newly created machine cgroup. Do not do this implicit anymore. Signed-off-by: Henning Schild --- src/lxc/lxc_cgroup.c | 11 +++ src/qemu/qemu_cgroup.c | 11 +++ src/util/vircgroup.c | 22 -- 3 files

[libvirt] [PATCH 6/9] qemu_cgroup: use virCgroupAddTask instead of virCgroupMoveTask

2016-02-23 Thread Henning Schild
qemuSetupCgroupForEmulator runs at a point in time where there is only the qemu main thread. Use virCgroupAddTask to put just that one task into the emulator cgroup. That patch makes virCgroupMoveTask and virCgroupAddTaskStrController obsolete. Signed-off-by: Henning Schild --- src

[libvirt] [PATCH 7/9] vircgroup: add controller mask to virCgroupAddTask

2016-02-23 Thread Henning Schild
Add a way to exclude controllers from virCgroupAddTask. In a cgroup hierarchy the parent might have controllers just to allow children cgroups to inherit them, not necessarily to put any tasks in them. Signed-off-by: Henning Schild --- src/lxc/lxc_cgroup.c | 2 +- src/lxc/lxc_controller.c

[libvirt] [PATCH 9/9] qemu_cgroup: assert threading cgroup layout for machine cgroup

2016-02-23 Thread Henning Schild
Make sure the thread related controls of the machine cgroup never get any tasks assigned. Signed-off-by: Henning Schild --- src/qemu/qemu_cgroup.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index 99fb5bf

[libvirt] [PATCH 3/9] vircgroup: introduce controller mask for threads

2016-02-23 Thread Henning Schild
When using a cgroups hierarchy threads have child cgroups for certain controllers. Introduce an enum for later reuse. Signed-off-by: Henning Schild --- src/util/vircgroup.c | 12 +++- src/util/vircgroup.h | 7 +++ 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/src

[libvirt] [PATCH 1/9] vircgroup: one central point for adding tasks to cgroups

2016-02-23 Thread Henning Schild
Use virCgroupAddTaskController in virCgroupAddTask so we have one single point where we add tasks to cgroups. Signed-off-by: Henning Schild --- src/util/vircgroup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index 7584ee4

[libvirt] [PATCH 2/9] vircgroup: add assertion to allow cgroup controllers to stay empty

2016-02-23 Thread Henning Schild
all tasks in /vcpuX or /emulator, not in /. Signed-off-by: Henning Schild --- src/libvirt_private.syms | 2 ++ src/util/vircgroup.c | 19 +++ src/util/vircgroup.h | 3 +++ src/util/vircgrouppriv.h | 1 + 4 files changed, 25 insertions(+) diff --git a/src

[libvirt] [PATCH 5/9] qemu_cgroup: put qemu right into emulator sub-cgroup

2016-02-23 Thread Henning Schild
Move qemuSetupCgroupForEmulator up under qemuSetupCgroup. That way we move the one main thread right into the emulator cgroup, instead of moving multiple threads later on. And we do not actually want any threads running in the parent cgroups (cpu cpuacct cpuset). Signed-off-by: Henning Schild

[libvirt] [PATCH] make-kpkg: add support for "make olddefconfig"

2016-02-23 Thread Henning Schild
Signed-off-by: Henning Schild --- make-kpkg | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/make-kpkg b/make-kpkg index 5cb8ec3..ba663c9 100755 --- a/make-kpkg +++ b/make-kpkg @@ -662,9 +662,10 @@ sub main () { } if ( $config_target -!~ /^(?:|silentold|old

[libvirt] [PATCH 0/9] fix thread related controllers in cgroups

2016-02-23 Thread Henning Schild
well! The tricky bits are in patches 5 and 8, i kept them as simple as possible. The series is based on v1.3.1. Henning Schild (9): vircgroup: one central point for adding tasks to cgroups vircgroup: add assertion to allow cgroup controllers to stay empty vircgroup: introduce controller mask f

[libvirt] [PATCH] add support for "make olddefconfig"

2016-02-23 Thread Henning Schild
Signed-off-by: Henning Schild --- make-kpkg | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/make-kpkg b/make-kpkg index 5cb8ec3..ba663c9 100755 --- a/make-kpkg +++ b/make-kpkg @@ -662,9 +662,10 @@ sub main () { } if ( $config_target -!~ /^(?:|silentold|old

Re: [libvirt] [PATCH v2 0/4] Adjustment to recent cgroup/cpuset changes (for 1.3.1)

2016-01-15 Thread Henning Schild
On Thu, 14 Jan 2016 17:20:04 + "Daniel P. Berrange" wrote: > On Thu, Jan 14, 2016 at 06:14:45PM +0100, Henning Schild wrote: > > On Thu, 14 Jan 2016 16:42:12 + > > "Daniel P. Berrange" wrote: > > > > > On Thu, Jan 14, 2016 at

Re: [libvirt] [PATCH v2 0/4] Adjustment to recent cgroup/cpuset changes (for 1.3.1)

2016-01-14 Thread Henning Schild
On Thu, 14 Jan 2016 16:42:12 + "Daniel P. Berrange" wrote: > On Thu, Jan 14, 2016 at 11:21:25AM -0500, John Ferlan wrote: > > v1: > > http://www.redhat.com/archives/libvir-list/2016-January/msg00511.html > > > > As discussed during the replies of the v1 - revert Henning's first > > two patch

Re: [libvirt] [REPOST 0/4] Adjustment to recent cgroup/cpuset changes (for 1.3.1)

2016-01-14 Thread Henning Schild
On Thu, 14 Jan 2016 12:37:18 + "Daniel P. Berrange" wrote: > On Thu, Jan 14, 2016 at 11:57:44AM +, Daniel P. Berrange wrote: > > Since this has been puzzelling us for a while, let me recap on the > > cgroup setup in general. > > > > First, I'll describe how it used to work *before* Henni

Re: [libvirt] [REPOST 0/4] Adjustment to recent cgroup/cpuset changes (for 1.3.1)

2016-01-14 Thread Henning Schild
partially because I originally forgot to CC the author (Henning > > Schild) of the original series for which these patch fix a couple > > of issues discovered during regression testing (virt-test memtune > > failures in Red Hat regression environment), but also to bring them > &

Re: [libvirt] [REPOST 0/4] Adjustment to recent cgroup/cpuset changes (for 1.3.1)

2016-01-14 Thread Henning Schild
ttp://www.redhat.com/archives/libvir-list/2016-January/msg00236.html > > > > > >partially because I originally forgot to CC the author (Henning > > >Schild) of the original series for which these patch fix a couple > > >of issues discovered during regression tes

Re: [libvirt] [PATCH 1/4] cgroup: Fix possible bug as a result of code motion for vcpu cgroup setup

2016-01-12 Thread Henning Schild
On Mon, 11 Jan 2016 13:50:32 -0500 John Ferlan wrote: > Commit id '90b721e43' moved where the virCgroupAddTask was made until > after the check for the vcpupin checks. However, in doing so it missed > an option where if the cpumap didn't exist, then the code would > continue back to the top of th

Re: [libvirt] [PATCH 0/3] several cgroups/cpuset fixes

2016-01-11 Thread Henning Schild
On Mon, 11 Jan 2016 07:05:11 -0500 John Ferlan wrote: > > > On 01/11/2016 06:38 AM, Henning Schild wrote: > > On Fri, 8 Jan 2016 11:05:59 -0500 > > John Ferlan wrote: > > > >> > >>>> > >>>> I'm leaning towards somethi

Re: [libvirt] [PATCH 0/3] several cgroups/cpuset fixes

2016-01-11 Thread Henning Schild
On Fri, 8 Jan 2016 11:05:59 -0500 John Ferlan wrote: > > >> > >> I'm leaning towards something in the test. I'll check if reverting > >> these changes alters the results. I don't imagine it will. > > > > The real question is which thread it fails on and at what point in > > time. My patches onl

Re: [libvirt] [PATCH 0/3] several cgroups/cpuset fixes

2016-01-08 Thread Henning Schild
On Thu, 7 Jan 2016 19:56:33 -0500 John Ferlan wrote: > > > On 01/07/2016 02:01 PM, Henning Schild wrote: > > On Thu, 7 Jan 2016 11:20:23 -0500 > > John Ferlan wrote: > > > >> > >> [...] > >> > >>>> No problem - although i

Re: [libvirt] [PATCH 0/3] several cgroups/cpuset fixes

2016-01-07 Thread Henning Schild
On Thu, 7 Jan 2016 11:20:23 -0500 John Ferlan wrote: > > [...] > > >> No problem - although it seems they've generated a regression in > >> the virttest memtune test suite. I'm 'technically' on vacation > >> for the next couple of weeks; however, I think/perhaps the problem > >> is a result of

Re: [libvirt] [PATCH 0/3] several cgroups/cpuset fixes

2015-12-21 Thread Henning Schild
On Mon, 21 Dec 2015 12:44:32 -0500 John Ferlan wrote: > > > On 12/21/2015 03:36 AM, Henning Schild wrote: > > On Mon, 14 Dec 2015 16:27:54 -0500 > > John Ferlan wrote: > > > >> > >> > >> On 11/13/2015 11:56 AM, Henning Schild wrote:

Re: [libvirt] [PATCH 0/3] several cgroups/cpuset fixes

2015-12-21 Thread Henning Schild
On Mon, 14 Dec 2015 16:27:54 -0500 John Ferlan wrote: > > > On 11/13/2015 11:56 AM, Henning Schild wrote: > > Hi, > > > > i already explained some of the cgroup problems in some detail so i > > will not do that again. > > https://www.redhat.com/archives

[libvirt] [PATCHv2 1/3] util: cgroups do not implicitly add task to new machine cgroup

2015-12-13 Thread Henning Schild
virCgroupNewMachine used to add the pidleader to the newly created machine cgroup. Do not do this implicit anymore. Signed-off-by: Henning Schild --- src/lxc/lxc_cgroup.c | 11 +++ src/qemu/qemu_cgroup.c | 11 +++ src/util/vircgroup.c | 22 -- 3 files

Re: [libvirt] [PATCH 2/3] qemu: do not put a task into machine cgroup

2015-12-13 Thread Henning Schild
On Tue, 8 Dec 2015 12:23:19 -0500 John Ferlan wrote: > > > On 11/13/2015 11:57 AM, Henning Schild wrote: > > The machine cgroup is a superset, a parent to the emulator and vcpuX > > cgroups. The parent cgroup should never have any tasks directly in > > it. In f

[libvirt] [PATCHv2 2/3] qemu: do not put a task into machine cgroup

2015-12-09 Thread Henning Schild
outside of . Signed-off-by: Henning Schild --- src/qemu/qemu_cgroup.c | 15 --- src/qemu/qemu_process.c | 12 ++-- 2 files changed, 10 insertions(+), 17 deletions(-) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index 7320046..85b8e4e 100644 --- a/src/qemu

Re: [libvirt] [PATCH 1/3] util: cgroups do not implicitly add task to new machine cgroup

2015-12-09 Thread Henning Schild
On Tue, 8 Dec 2015 12:23:14 -0500 John Ferlan wrote: > > > On 11/13/2015 11:56 AM, Henning Schild wrote: > > virCgroupNewMachine used to add the pidleader to the newly created > > machine cgroup. Do not do this implicit anymore. > > > > Signed-off-by: Hen

[libvirt] [PATCH 1/3] util: cgroups do not implicitly add task to new machine cgroup

2015-11-13 Thread Henning Schild
virCgroupNewMachine used to add the pidleader to the newly created machine cgroup. Do not do this implicit anymore. Signed-off-by: Henning Schild --- src/lxc/lxc_cgroup.c | 6 ++ src/qemu/qemu_cgroup.c | 6 ++ src/util/vircgroup.c | 22 -- 3 files changed, 12

[libvirt] [PATCH 0/3] several cgroups/cpuset fixes

2015-11-13 Thread Henning Schild
Henning Schild (3): util: cgroups do not implicitly add task to new machine cgroup qemu: do not put a task into machine cgroup qemu cgroups: move new threads to new cgroup after cpuset is set up src/lxc/lxc_cgroup.c | 6 ++ src/qemu/qemu_cgroup.c | 23 ++- src/util

[libvirt] [PATCH 3/3] qemu cgroups: move new threads to new cgroup after cpuset is set up

2015-11-13 Thread Henning Schild
Moving tasks to cgroups implied sched_setaffinity. Changing the cpus in a set implies the same for all tasks in the group. The old code put the the thread into the cpuset inherited from the machine cgroup, which allowed it to run outside of vcpupin for a short while. Signed-off-by: Henning Schild

[libvirt] [PATCH 2/3] qemu: do not put a task into machine cgroup

2015-11-13 Thread Henning Schild
outside of . Signed-off-by: Henning Schild --- src/qemu/qemu_cgroup.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index 28d2ca2..2c74a22 100644 --- a/src/qemu/qemu_cgroup.c +++ b/src/qemu/qemu_cgroup.c @@ -769,12 +769,6

[libvirt] Again cgroups and isolcpus

2015-10-29 Thread Henning Schild
Hi folks, i already started a discussion on the interaction of cgroups and isolcpus a while ago. But now i believe i have got a better understanding of how the two interact and i can describe problems that arise from that. The scenario: A machine that runs realtime tasks on pcpus reserved with is

Re: [libvirt] cpu affinity, isolcpus and cgroups

2015-10-14 Thread Henning Schild
On Thu, 2 Jul 2015 17:27:21 +0100 "Daniel P. Berrange" wrote: > On Thu, Jul 02, 2015 at 04:42:47PM +0200, Henning Schild wrote: > > On Thu, 2 Jul 2015 15:18:46 +0100 > > "Daniel P. Berrange" wrote: > > > > > On Thu, Jul 02, 2015 at

Re: [libvirt] cpu affinity, isolcpus and cgroups

2015-07-02 Thread Henning Schild
On Thu, 2 Jul 2015 15:18:46 +0100 "Daniel P. Berrange" wrote: > On Thu, Jul 02, 2015 at 04:02:58PM +0200, Henning Schild wrote: > > Hi, > > > > i am currently looking into realtime VMs using libvirt. My first > > starting point was reserving a couple of core

[libvirt] cpu affinity, isolcpus and cgroups

2015-07-02 Thread Henning Schild
Hi, i am currently looking into realtime VMs using libvirt. My first starting point was reserving a couple of cores using isolcpus and later tuning the affinity to place my vcpus on the reserved pcpus. My first observation was that libvirt ignores isolcpus. Affinity masks of new qemus will defaul