Re: [libvirt] [PATCH] Pass syntax check for block devices to XenD.

2008-06-16 Thread Hiroyuki Kaguchi
On 2008/06/04 14:17, Hiroyuki Kaguchi wrote: > Hi, > > libvirt doesn't pass disk information that the device type isn't specified to > XenD and doesn't show the error message either. > However, the error message should be displayed, and XenD should show it. >

[libvirt] [PATCH] Pass syntax check for block devices to XenD.

2008-06-03 Thread Hiroyuki Kaguchi
that the device type isn't specified to XenD and XenD shows error message. The related patch: After Xen Cset17617, XenD check the syntax of the device type of the disk information. Thanks, Signed-off-by: Hiroyuki Kaguchi <[EMAIL PROTECTED]>

[libvirt] [PATCH] Add error message when the invalid XML file is defined.

2008-05-30 Thread Hiroyuki Kaguchi
Hi, When cpuset that is the attribute of vcpu tag of the XML file is the invalid string, "virsh define" succeeds. (Ex. 4 4 4 ) The patch changes policy that the definition is failed and shows error message. Thanks, Signed-off-by: Hiroyuki Kaguchi <[EMAIL PROTECTED]

Re: [Libvir] [PATCH] Fix MAC address parsing for 1-digit case

2008-03-20 Thread Hiroyuki Kaguchi
Hi, Jim Thank you very much for your comments. Regards Hiroyuki Kaguchi On 2008/03/19 19:55, Jim Meyering wrote: Hiroyuki Kaguchi <[EMAIL PROTECTED]> wrote: Thank you for your suggestions. I apply the following changes to the patch. 1) Initialize errno to 0 before the loop. 2) Use is

Re: [Libvir] [PATCH] Fix MAC address parsing for 1-digit case

2008-03-19 Thread Hiroyuki Kaguchi
/util.c. Thanks, Signed-off-by: Hiroyuki Kaguchi <[EMAIL PROTECTED]> Index: src/util.c === RCS file: /data/cvs/libvirt/src/util.c,v retrieving revision 1.25 diff -u -r1.25 util.c --- src/util.c 3 Mar 2008 20:39:52 -

[Libvir] [PATCH] Fix MAC address parsing for 1-digit case

2008-03-17 Thread Hiroyuki Kaguchi
ing in the MAC address against virt-inst Cset:316 Thanks Signed-off-by: Hiroyuki Kaguchi <[EMAIL PROTECTED]> ? parse_macaddr.patch Index: src/xml.c === RCS file: /data/cvs/libvirt/src/xml.c,v retrieving revision 1.113 diff

Re: [Libvir] [PATCH] Fix the function that remove the element of the hash table.

2008-02-06 Thread Hiroyuki Kaguchi
st --all" command. 4. undefine the defined domains on another session. 5. execute "list --all" command. A domain is not removed from the list during the fixed time(10sec). On 2008/02/06 17:38, Jim Meyering wrote: Hiroyuki Kaguchi <[EMAIL PROTECTED]> wrote: Though this pa

Re: [Libvir] [PATCH] Fix the function that remove the element of the hash table.

2008-02-06 Thread Hiroyuki Kaguchi
Though this patch has not been applied yet, are there any problems in this patch? If there is no problem, could you apply this patch ? (2008/01/29 23:45), Daniel P. Berrange wrote: On Tue, Jan 29, 2008 at 11:32:04AM +0900, Hiroyuki Kaguchi wrote: There are two logic error and a unnecessary

Re: [Libvir] [PATCH] Fix USB device name mis-conversion from S-Expr to XML

2008-01-29 Thread Hiroyuki Kaguchi
> If a USB device is attached by virt-manager, > the USB device is not seen from virt-manager. > > This patch fixes expected value of libvirt > > Thanks, > Hiroyuki Kaguchi > > Index: xend_internal.c > =

[Libvir] [PATCH] Fix the function that remove the element of the hash table.

2008-01-28 Thread Hiroyuki Kaguchi
---+ 3. remove "element-B" The removing cursor point to "element-D". "element-C" is skipped. +-hash table---+ | +--+ | +--+ | |element-B'|-|-->|element-C | | +--+ | +--+ | |element-D | | | +--+ | | . | | .

[Libvir] [PATCH] Fix USB device name mis-conversion from S-Expr to XML

2008-01-23 Thread Hiroyuki Kaguchi
ger. This patch fixes expected value of libvirt Thanks, Hiroyuki Kaguchi Index: xend_internal.c === RCS file: /data/cvs/libvirt/src/xend_internal.c,v retrieving revision 1.162 diff -u -r1.162 xend_internal.c --- xend_internal.c

[Libvir] [PATCH] NIC should define in order

2008-01-16 Thread Hiroyuki Kaguchi
-off-by: Hiroyuki Kaguchi <[EMAIL PROTECTED]> Index: xm_internal.c === RCS file: /data/cvs/libvirt/src/xm_internal.c,v retrieving revision 1.53 diff -u -p -r1.53 xm_internal.c --- xm_internal.c 14 Dec 2007 15:51:42