Re: [libvirt] [PATCH] util : fix compile error on fedora14 Add src/util/virnetdevbandwidth.h, src/util/virnetdevveth.h, src/util/virnetdevvportprofile.h to private symbols.

2011-11-15 Thread Hong Xiang
irNetDevVethDelete; > + > + > +# virnetdevvportprofile.h > +virNetDevVPortProfileEqual; > + > + > # virnetmessage.h > virNetMessageClear; > virNetMessageDecodeNumFDs; -- Thanks. Hong Xiang -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] "make rpm" failing with git head on RHEL6

2011-11-08 Thread Hong Xiang
MMON = README $(am__configure_deps) $(srcdir)/Makefile.am \ > $(srcdir)/Makefile.in $(srcdir)/config.h.in \ > $(srcdir)/libvirt.pc.in $(srcdir)/libvirt.spec.in \ > $(srcdir)/mingw32-libvirt.spec.in $(top_srcdir)/configure \ > ABOUT-NLS AUTHORS COPYING COPYING.LIB ChangeLog

Re: [libvirt] "make rpm" failing with git head on RHEL6

2011-11-08 Thread Hong Xiang
Please follow Congyang's suggestion to install systemtap-sdt-devel package and redo configure. On 11/08/2011 05:40 PM, Wenyi Gao wrote: > On 2011年11月08日 17:33, Hong Xiang wrote: >> I believe it's due to missing xsltproc binary? Wenyi, same as your >> earlier "

[libvirt] [PATCH 1/4] new public APIs for managed core dump

2011-11-03 Thread Hong Xiang
bvirt/libvirt.h.in: API declarations. * src/driver.h: driver data structure extension. * src/libvirt.c: API implementation. * src/libvirt_public.syms: public symbols. Signed-off-by: Hong Xiang --- include/libvirt/libvirt.h.in | 13 +++ src/driver.h | 18 src/libv

[libvirt] [PATCH 3/4] qemu driver implementation

2011-11-03 Thread Hong Xiang
* src/qemu/qemu_conf.h: qemud_driver data structure extension. * src/qemu/qemu_driver.c: qemu driver API extension. Signed-off-by: Hong Xiang --- src/qemu/qemu_conf.h |2 + src/qemu/qemu_driver.c | 176 +++- 2 files changed, 176 insertions

[libvirt] [PATCH 4/4] New virsh commands for managed core dump

2011-11-03 Thread Hong Xiang
New commands: . manageddump . manageddump-remove . manageddump-download * tools/virsh.c: new commands. Signed-off-by: Hong Xiang --- tools/virsh.c | 200 + 1 files changed, 200 insertions(+), 0 deletions(-) diff --git a/tools/virsh.c b

[libvirt] [PATCH 0/4] new APIs/commands for managed core dump

2011-11-03 Thread Hong Xiang
o the generate/check-existence/remove APIs/commands, there's also a download API/command to get the managed core dump of a domain for local use. Currently the new functionality has only been implemented for qemu hypervisor driver. Hong Xiang (4): new public APIs for managed core dump remote

[libvirt] [PATCH 2/4] remote driver implementation

2011-11-03 Thread Hong Xiang
* src/remote/remote_driver.c: remote_driver data structure extension. * src/remote/remote_protocol.x: remote protocol extension. Signed-off-by: Hong Xiang --- src/remote/remote_driver.c |4 src/remote/remote_protocol.x | 31 ++- 2 files changed, 34

Re: [libvirt] [PATCH 1/4] New APIs to manage saved-state & core-dump files.

2011-10-25 Thread Hong Xiang
eDumpExt(virDomainPtr dom, int flags, char * id); To support more than one core dump files. Similar for managed save. IMHO, existing functionality is a little buggy, and there's already a bug for this: https://bugzilla.redhat.com/show_bug.cgi?id=746072 Thanks. Hong Xiang -- libvir-list maili

[libvirt] [PATCH 2/3] Remove virFileAbsPath() from virDomainSave*() and virDomainCoreDump() calls

2011-10-25 Thread Hong Xiang
Change the semantics of '--file' parameter user provides in cmdline from a relative/absolute filesystem path to an id which is to be converted in driver to form a filesystem path. * src/libvirt.c: remove virFileAbsPath() calls Signed-off-by: Hong Xiang --- src/libvir

[libvirt] [PATCH 4/4] New virsh commands to manage saved-state and core-dump files

2011-10-25 Thread Hong Xiang
New virsh commands: . save-image-list . save-image-remove . save-image-download . dump-list . dump-remove . dump-download * tools/virsh.c: new commands implementations Signed-off-by: Hong Xiang --- tools/virsh.c | 309 + 1 files

[libvirt] [PATCH 1/4] New APIs to manage saved-state & core-dump files.

2011-10-25 Thread Hong Xiang
APIs * src/libvirt.c, src/libvirt_public.syms: entry points for new APIs * python/generator.py, python/libvirt-override-api.xml, python/libvirt-override.c: overridden python binding Signed-off-by: Hong Xiang --- include/libvirt/libvirt.h.in| 18 +++ python/generator.py |2

[libvirt] [PATCH 0/3] Restrict saved-state and core-dump files in controlled directories

2011-10-25 Thread Hong Xiang
virDomainCoreDump, is interpreted as an ID; . The file ID is later translated to a real filesystem pathname by corresponding drivers; . The real file system paths are under controlled directories, different for saved-state-files and core-dumps, respectively; Hong Xiang (3): New util API

[libvirt] [PATCH 2/4] qemu driver for new APIs to manage saved-state & core-dump files

2011-10-25 Thread Hong Xiang
qemu driver implementation of new APIs. * src/qemu/qemu_driver.c: qemu driver implementation Signed-off-by: Hong Xiang --- src/qemu/qemu_driver.c | 253 1 files changed, 253 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b

[libvirt] [PATCH 3/4] remote driver for new APIs to manage saved-state & core-dump files

2011-10-25 Thread Hong Xiang
remote driver implementation of new APIs. * src/remote/remote_driver.c: new fields for remote_driver * src/remote/remote_protocol.x: remote protocol definition * src/rpc/gendispatch.pl: special case priv_name for (SavedImage|CoreDump) Signed-off-by: Hong Xiang --- src/remote/remote_driver.c

[libvirt] [PATCH 0/4] New APIs and virsh commands to manage saved-state & core-dump files

2011-10-25 Thread Hong Xiang
This patch series is a followup of "[PATCH 0/3] Restrict saved-state and core-dump files in controlled directories". A few new APIs and virsh commands are added to manage saved-state & core-dump files. Hong Xiang (4): New APIs to manage saved-state & core-dump files. qemu d

[libvirt] [PATCH 1/3] New util API virBase64EncodePathname/virBase64DecodePathname

2011-10-25 Thread Hong Xiang
Base64 en/decode a string and '/' in standard base64 is replaced with '_', so that encoded string can be safely used as a filesystem path component; * src/util/util.c: implementation * src/util/util.h: declaration * src/libvirt_private.syms: private symbols Signed-off-by:

[libvirt] [PATCH 3/3] Encode input file id in qemuDomainSave/Restore and qemudDomainCoreDump

2011-10-25 Thread Hong Xiang
c/qemu/qemu_conf.h: add 2 fields to struct qemud_driver * src/qemu/qemu_driver.c: base64 encoding file id and id->path translation Signed-off-by: Hong Xiang --- src/qemu/qemu_conf.h |3 + src/qemu/qemu_driver.c | 98 +-- 2 files changed, 96 inserti

Re: [libvirt] [PATCH v2] support setting bandwidth from virsh attach-interface(was Re: [PATCH] support setting bandwidth from virsh attach-interface)

2011-10-13 Thread Hong Xiang
On 10/14/2011 10:49 AM, Hu Tao wrote: +/* parse inbound and outbound which are in the format of + * 'average,peak,burst', in which peak and burst are optional, + * thus 'average,,burst' and 'average,peak' are also legal. */ +static int parseRateStr(const char *rateStr, virRatePtr rate) +{ +ch

Re: [libvirt] [PATCH] support setting bandwidth from virsh attach-interface

2011-10-13 Thread Hong Xiang
On 10/14/2011 09:06 AM, Hu Tao wrote: On Thu, Oct 13, 2011 at 05:17:34PM +0800, Hong Xiang wrote: On 10/13/2011 02:52 PM, Hu Tao wrote: Adds two options, inbound and outbound, to attach-interface to set bandwidth when attaching interfaces --- tools/virsh.c | 96

Re: [libvirt] [PATCH] support setting bandwidth from virsh attach-interface

2011-10-13 Thread Hong Xiang
On 10/13/2011 02:52 PM, Hu Tao wrote: Adds two options, inbound and outbound, to attach-interface to set bandwidth when attaching interfaces --- tools/virsh.c | 96 +- tools/virsh.pod |5 ++- 2 files changed, 98 insertions(+), 3 del

Re: [libvirt] Possible security hole? unprivileged user can use virsh to overwrite sensitive system file

2011-10-12 Thread Hong Xiang
Daniel P. Berrange wrote: On Wed, Oct 12, 2011 at 11:57:25AM +0800, Hong Xiang wrote: I found there's a way for a unprivileged user to overwrite sensitive system file with virsh, here's how: 1. (as an unprivileged user) start virsh and connect to the r/w socket of libvirtd: virsh -c

[libvirt] Possible security hole? unprivileged user can use virsh to overwrite sensitive system file

2011-10-11 Thread Hong Xiang
irt code shows the same symptom. BTW, virsh expands the parameter in step to an absolute path if user-provided is not, and libvirtd interprets it as a local file. IMHO it does not look quite right, especially when the virsh-to-libvirtd connection is remote. -- Thanks. Hong Xiang [hxiang@T420 ~]

Re: [libvirt] [PATCHv2] security: properly chown/label bidirectional and unidirectional fifos

2011-09-28 Thread Hong Xiang
reSecurityFileLabel(out)< 0) || +(SELinuxRestoreSecurityFileLabel(in)< 0)) { +goto done; + } +} else if (SELinuxRestoreSecurityFileLabel(dev->data.file.path)< 0) { goto done; +} ret = 0; break; That bug got me a bit crazy, I would like to get it fixed :) ACK conditionned on the above four || replaced by&& Daniel -- Thanks. Hong Xiang -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list