Re: [PATCH] network: Only check kernel added routes in virNetDevIPCheckIPv6Forwarding

2020-09-11 Thread Ian Wienand
Please ignore this version, sorry, as I forgot to commit the removal of the old functions in the patch. On Fri, Sep 11, 2020 at 09:30:30PM +1000, Ian Wienand wrote: > The original motivation for adding virNetDevIPCheckIPv6Forwarding > (00d28a78b5d1f6eaf79f06ac59e31c568af9da37) was that netw

[PATCH v2] network: Only check kernel added routes in virNetDevIPCheckIPv6Forwarding

2020-09-11 Thread Ian Wienand
using NetworkManager and the like, having false warnings when enabling IPv6, but retain the error check for users relying on kernel-based IPv6 interface auto-configuration. Signed-off-by: Ian Wienand --- src/util/virnetdevip.c | 323 - 1 file changed, 12

[PATCH] network: Only check kernel added routes in virNetDevIPCheckIPv6Forwarding

2020-09-11 Thread Ian Wienand
using NetworkManager and the like, having false warnings when enabling IPv6, but retain the error check for users relying on kernel-based IPv6 interface auto-configuration. Signed-off-by: Ian Wienand --- src/util/virnetdevip.c | 108 - 1 file changed,

Re: [PATCH] network: allow accept_ra == 0 when enabling ipv6 forwarding

2020-09-09 Thread Ian Wienand
On Wed, Sep 09, 2020 at 06:38:04AM +, Cedric Bosdonnat wrote: > The check didn't involve any NetworkManager at all, but a network with > RA route for the default route. Completely removing the check is rather > likely to introduce a regression on that side. Thanks for putting up with my

Re: [PATCH] network: allow accept_ra == 0 when enabling ipv6 forwarding

2020-09-08 Thread Ian Wienand
On Tue, Sep 01, 2020 at 08:27:47AM +, Cedric Bosdonnat wrote: > So the hypervisor has at least one (Router Advertised) RA route. > After defining a network like the following, the RA route is removed if > accept_ra isn't set to 2. > > > test5 > > > > family="ipv6" >

Re: [PATCH] doc: add some examples for IPv6 NAT configuration

2020-09-08 Thread Ian Wienand
Gentle ping on this; thanks -i On Wed, Aug 12, 2020 at 11:21:47AM +1000, Ian Wienand wrote: > Add some expanded examples for the nat ipv6 introduced with > 927acaedec7effbe67a154d8bfa0e67f7d08e6c7. > > Unfortunately while for IPv4 it's well-known what addresses ranges are >

Re: [PATCH] network: allow accept_ra == 0 when enabling ipv6 forwarding

2020-08-12 Thread Ian Wienand
On Wed, Aug 12, 2020 at 07:21:14PM -0400, Laine Stump wrote: > Yay! A user who follows up their conversation on the libvirt-users list with > a patch! :-) Heh, ipv6 in my work VM is my white whale, so, call me Ishmael :) > Unfortunately, on my Fedora 32 machine that has NetworkManager enabled,

[PATCH] doc: add some examples for IPv6 NAT configuration

2020-08-11 Thread Ian Wienand
and the meaning of the word "site" it's generally much less obvious. I've tried to add some details on choosing a range inline with RFC 4193 and then some pointers for when it maybe doesn't work in the guest as you first expect despite you doing what the RFC's say! Signed-off-by: Ian Wienand

[PATCH] network: allow accept_ra == 0 when enabling ipv6 forwarding

2020-08-11 Thread Ian Wienand
and start a libvirt network with and and it seems to "just work" for guests. Signed-off-by: Ian Wienand --- src/util/virnetdevip.c | 41 +++-- 1 file changed, 27 insertions(+), 14 deletions(-) diff --git a/src/util/virnetdevip.c b/src/util/virnetdevi