Re: [PATCH v2] Deprecate the "-no-acpi" command line switch

2023-02-24 Thread Igor Mammedov
On Fri, 24 Feb 2023 10:05:43 +0100 Thomas Huth wrote: > Similar to "-no-hpet", the "-no-acpi" switch is a legacy command > line option that should be replaced with the "acpi" machine parameter > nowadays. > > Signed-off-by: Thomas Huth Reviewed-

Re: [PATCH] tests: qemucapabilities: Update qemu caps dump for the qemu-7.0.0 release on x86_64

2022-04-20 Thread Igor Mammedov
On Wed, 20 Apr 2022 14:13:00 +0200 Peter Krempa wrote: > On Wed, Apr 20, 2022 at 14:00:52 +0200, Igor Mammedov wrote: > > On Wed, 20 Apr 2022 12:21:03 +0100 > > Daniel P. Berrangé wrote: > > > > > On Wed, Apr 20, 2022 at 01:15:43PM +0200, Igor Mammedov wrote:

Re: [PATCH] tests: qemucapabilities: Update qemu caps dump for the qemu-7.0.0 release on x86_64

2022-04-20 Thread Igor Mammedov
On Wed, 20 Apr 2022 12:21:03 +0100 Daniel P. Berrangé wrote: > On Wed, Apr 20, 2022 at 01:15:43PM +0200, Igor Mammedov wrote: > > On Wed, 20 Apr 2022 13:02:12 +0200 > > Peter Krempa wrote: > > > > > Few minor changes in qemu since the last update: > > &g

Re: [PATCH] tests: qemucapabilities: Update qemu caps dump for the qemu-7.0.0 release on x86_64

2022-04-20 Thread Igor Mammedov
On Wed, 20 Apr 2022 13:02:12 +0200 Peter Krempa wrote: > Few minor changes in qemu since the last update: > - PIIX4_PM gained 'x-not-migrate-acpi-index' property do you do this for just for every new property? (nothing outside of QEMU needs to know about x-not-migrate-acpi-index, unless one

Re: [PATCH v4 2/4] hw/i386: Attach CPUs to machine

2022-02-08 Thread Igor Mammedov
On Mon, 7 Feb 2022 11:48:27 + Daniel P. Berrangé wrote: > On Mon, Feb 07, 2022 at 12:22:22PM +0100, Igor Mammedov wrote: > > On Mon, 7 Feb 2022 10:36:42 +0100 > > Peter Krempa wrote: > > > > > On Mon, Feb 07, 2022 at 10:18:43 +0100, Igor Mammedov wrote: &g

Re: [PATCH v4 2/4] hw/i386: Attach CPUs to machine

2022-02-08 Thread Igor Mammedov
On Mon, 7 Feb 2022 10:36:42 +0100 Peter Krempa wrote: > On Mon, Feb 07, 2022 at 10:18:43 +0100, Igor Mammedov wrote: > > On Mon, 7 Feb 2022 09:14:37 +0100 > > Igor Mammedov wrote: > > > > > On Sat, 5 Feb 2022 13:45:24 +0100 > > > Philippe Mathieu-Da

Re: [PATCH v4 2/4] hw/i386: Attach CPUs to machine

2022-02-07 Thread Igor Mammedov
On Mon, 7 Feb 2022 09:14:37 +0100 Igor Mammedov wrote: > On Sat, 5 Feb 2022 13:45:24 +0100 > Philippe Mathieu-Daudé wrote: > > > Previously CPUs were exposed in the QOM tree at a path > > > > /machine/unattached/device[nn] > > > > where the 'n

Re: [PATCH v4 2/4] hw/i386: Attach CPUs to machine

2022-02-07 Thread Igor Mammedov
On Sat, 5 Feb 2022 13:45:24 +0100 Philippe Mathieu-Daudé wrote: > Previously CPUs were exposed in the QOM tree at a path > > /machine/unattached/device[nn] > > where the 'nn' of the first CPU is usually zero, but can > vary depending on what devices were already created. > > With this chang

Re: [PATCH 5/5] qemu: Prefer -numa cpu over -numa node,cpus=

2021-10-21 Thread Igor Mammedov
On Wed, 20 Oct 2021 16:15:29 +0200 Michal Prívozník wrote: > On 10/20/21 1:18 PM, Peter Krempa wrote: > > On Wed, Oct 20, 2021 at 13:07:59 +0200, Michal Prívozník wrote: > >> On 10/6/21 3:32 PM, Igor Mammedov wrote: > >>> On Thu, 30 Sep 2021 14:08:34 +

Re: [PATCH 5/5] qemu: Prefer -numa cpu over -numa node,cpus=

2021-10-21 Thread Igor Mammedov
On Wed, 20 Oct 2021 13:07:59 +0200 Michal Prívozník wrote: > On 10/6/21 3:32 PM, Igor Mammedov wrote: > > On Thu, 30 Sep 2021 14:08:34 +0200 > > Peter Krempa wrote: > > > >> On Tue, Sep 21, 2021 at 16:50:31 +0200, Michal Privoznik wrote: > >>>

Re: [PATCH 4/5] qemuBuildNumaCommandLine: Separate out building of CPU list

2021-10-06 Thread Igor Mammedov
On Thu, 30 Sep 2021 13:33:24 +0200 Peter Krempa wrote: > On Tue, Sep 21, 2021 at 16:50:30 +0200, Michal Privoznik wrote: > > Signed-off-by: Michal Privoznik > > --- > > src/qemu/qemu_command.c | 43 ++--- > > 1 file changed, 27 insertions(+), 16 deletions(-)

Re: [PATCH 5/5] qemu: Prefer -numa cpu over -numa node,cpus=

2021-10-06 Thread Igor Mammedov
On Thu, 30 Sep 2021 14:08:34 +0200 Peter Krempa wrote: > On Tue, Sep 21, 2021 at 16:50:31 +0200, Michal Privoznik wrote: > > QEMU is trying to obsolete -numa node,cpus= because that uses > > ambiguous vCPU id to [socket, die, core, thread] mapping. The new > > form is: > > > > -numa cpu,node-i

Re: [PATCH v3 3/5] conf: introduce acpi-hotplug-bridge and acpi-root-hotplug pm options

2021-09-29 Thread Igor Mammedov
On Tue, 28 Sep 2021 11:47:26 +0100 Daniel P. Berrangé wrote: > On Tue, Sep 28, 2021 at 03:28:04PM +0530, Ani Sinha wrote: > > > > > > On Tue, 28 Sep 2021, Daniel P. Berrangé wrote: > > > > > On Tue, Sep 28, 2021 at 02:35:47PM +0530, Ani Sinha wrote: > > > > > > > > > > > > On Tue, 28 Sep 2

Re: [PATCH v3 3/5] conf: introduce acpi-hotplug-bridge and acpi-root-hotplug pm options

2021-09-29 Thread Igor Mammedov
On Tue, 28 Sep 2021 11:59:42 +0100 Daniel P. Berrangé wrote: > On Tue, Sep 28, 2021 at 11:47:26AM +0100, Daniel P. Berrangé wrote: > > On Tue, Sep 28, 2021 at 03:28:04PM +0530, Ani Sinha wrote: > > > > > > > > > On Tue, 28 Sep 2021, Daniel P. Berrangé wrote: > > > > > > > On Tue, Sep 28, 2

Re: [PATCH] Deprecate pmem=on with non-DAX capable backend file

2021-05-03 Thread Igor Mammedov
On Wed, 28 Apr 2021 12:29:30 -0400 Eduardo Habkost wrote: > On Tue, Apr 27, 2021 at 04:48:48PM -0400, Eduardo Habkost wrote: > > On Mon, Jan 11, 2021 at 03:33:32PM -0500, Igor Mammedov wrote: > > > It is not safe to pretend that emulated NVDIMM supports > > > persist

Re: [libvirt PATCH 1/6] conf: add support for for PCI devices

2021-04-08 Thread Igor Mammedov
On Thu, 8 Apr 2021 09:39:43 +0100 Daniel P. Berrangé wrote: > On Wed, Apr 07, 2021 at 10:23:37PM +0200, Igor Mammedov wrote: > > On Wed, 7 Apr 2021 13:40:03 +0100 > > Daniel P. Berrangé wrote: > > > > > On Wed, Apr 07, 2021 at 09:17:36AM +0200, Peter Krempa w

Re: [libvirt PATCH 1/6] conf: add support for for PCI devices

2021-04-07 Thread Igor Mammedov
On Wed, 7 Apr 2021 13:40:03 +0100 Daniel P. Berrangé wrote: > On Wed, Apr 07, 2021 at 09:17:36AM +0200, Peter Krempa wrote: > > On Tue, Apr 06, 2021 at 16:31:32 +0100, Daniel Berrange wrote: > > > PCI devices can be associated with a unique integer index that is > > > exposed via ACPI. In Linux

Re: [libvirt PATCH 5/6] qemu: probe for "acpi-index" property

2021-04-06 Thread Igor Mammedov
On Tue, 6 Apr 2021 16:31:36 +0100 Daniel P. Berrangé wrote: > This property is exposed by QEMU on any PCI device, but we have to pick > some specific device(s) to probe it against. We expect that at least one > of the virtio devices will be present, so probe against them. Would it be useful to

Re: Ways to deal with broken machine types

2021-03-29 Thread Igor Mammedov
On Mon, 29 Mar 2021 15:46:53 +0100 "Dr. David Alan Gilbert" wrote: > * Igor Mammedov (imamm...@redhat.com) wrote: > > On Tue, 23 Mar 2021 17:40:36 + > > Daniel P. Berrangé wrote: > > > > > On Tue, Mar 23, 2021 at 05:54:47PM +0100, Igor Mammedov wr

Re: Ways to deal with broken machine types

2021-03-25 Thread Igor Mammedov
On Tue, 23 Mar 2021 17:40:36 + Daniel P. Berrangé wrote: > On Tue, Mar 23, 2021 at 05:54:47PM +0100, Igor Mammedov wrote: > > Let me hijack this thread for beyond this case scope. > > > > I agree that for this particular bug we've done all we could, but > > t

Ways to deal with broken machine types

2021-03-23 Thread Igor Mammedov
On Tue, 23 Mar 2021 16:04:11 +0100 Thomas Lamprecht wrote: > On 23.03.21 15:55, Vitaly Cheptsov wrote: > >> 23 марта 2021 г., в 17:48, Michael S. Tsirkin написал(а): > >> > >> The issue is with people who installed a VM using 5.1 qemu, > >> migrated to 5.2, booted there and set a config on a dev

Re: [PATCH] Deprecate pmem=on with non-DAX capable backend file

2021-01-20 Thread Igor Mammedov
On Mon, 11 Jan 2021 15:33:32 -0500 Igor Mammedov wrote: > It is not safe to pretend that emulated NVDIMM supports > persistence while backend actually failed to enable it > and used non-persistent mapping as fall back. > Instead of falling-back, QEMU should be more strict and >

Re: [PATCH 1/2] qemu_capabilities: Introduce QEMU_CAPS_X_USE_CANONICAL_PATH_FOR_RAMBLOCK_ID

2021-01-14 Thread Igor Mammedov
On Tue, 12 Jan 2021 20:59:11 +0100 Peter Krempa wrote: > On Tue, Jan 12, 2021 at 20:24:44 +0100, Igor Mammedov wrote: > > On Tue, 12 Jan 2021 18:41:38 + > > Daniel P. Berrangé wrote: > > > > > On Tue, Jan 12, 2021 at 07:28:45PM +0100, Peter Krempa wrote: &

Re: [PATCH 1/2] qemu_capabilities: Introduce QEMU_CAPS_X_USE_CANONICAL_PATH_FOR_RAMBLOCK_ID

2021-01-12 Thread Igor Mammedov
On Tue, 12 Jan 2021 18:41:38 + Daniel P. Berrangé wrote: > On Tue, Jan 12, 2021 at 07:28:45PM +0100, Peter Krempa wrote: > > On Tue, Jan 12, 2021 at 19:20:58 +0100, Igor Mammedov wrote: > > > On Tue, 12 Jan 2021 12:35:19 +0100 > > > Peter Krempa wrote: >

Re: [PATCH 2/2] qemu: Do not Use canonical path for system memory

2021-01-12 Thread Igor Mammedov
On Tue, 12 Jan 2021 09:29:50 +0100 Michal Privoznik wrote: > In commit v6.9.0-rc1~450 I've adapted libvirt to QEMU's deprecation of > -mem-path and -mem-prealloc and switched to memory-backend-* even for > system memory. My claim was that that's what QEMU does under the hood > anyway. And indeed

Re: [PATCH 1/2] qemu_capabilities: Introduce QEMU_CAPS_X_USE_CANONICAL_PATH_FOR_RAMBLOCK_ID

2021-01-12 Thread Igor Mammedov
On Tue, 12 Jan 2021 12:35:19 +0100 Peter Krempa wrote: > On Tue, Jan 12, 2021 at 12:29:58 +0100, Michal Privoznik wrote: > > On 1/12/21 12:19 PM, Peter Krempa wrote: > > > On Tue, Jan 12, 2021 at 09:29:49 +0100, Michal Privoznik wrote: > > > > This capability tracks whether memory-backend-fil

[PATCH] Deprecate pmem=on with non-DAX capable backend file

2021-01-11 Thread Igor Mammedov
tence (pmem=on), they should store backing file on NVDIMM. Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé --- v2: rephrase deprecation comment andwarning message (Philippe Mathieu-Daudé ) --- docs/system/deprecated.rst | 17 + util/mmap-alloc.c

Re: [PATCH] Deprecate pmem=on with non-DAX capable backend file

2020-12-29 Thread Igor Mammedov
On Tue, 29 Dec 2020 19:04:58 +0100 Philippe Mathieu-Daudé wrote: > On 12/29/20 6:29 PM, Igor Mammedov wrote: > > It is not safe to pretend that emulated NVDIMM supports > > persistence while backend actually failed to enable it > > and used non-persistent mapping as fall

[PATCH] Deprecate pmem=on with non-DAX capable backend file

2020-12-29 Thread Igor Mammedov
tence (pmem=on), they should store backing file on NVDIMM. Signed-off-by: Igor Mammedov --- docs/system/deprecated.rst | 14 ++ util/mmap-alloc.c | 3 +++ 2 files changed, 17 insertions(+) diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst index bacd7

[RFC 3/5] pci: introduce apci-index property for PCI device

2020-12-22 Thread Igor Mammedov
on. this patch adds, 'acpi-index'* property and wires up (abuses) unused pci hotplug registers to pass index value to AML code at runtime. Following patch will add corresponding _DSM code and wire it up to PCI devices described in ACPI. *) name comes from linux kernel terminology Sig

Re: [PATCH] qemu: Relax memory pre-allocation rules

2020-12-14 Thread Igor Mammedov
On Mon, 30 Nov 2020 11:14:20 + Daniel P. Berrangé wrote: > On Mon, Nov 30, 2020 at 11:48:28AM +0100, Michal Privoznik wrote: > > On 11/30/20 11:16 AM, Daniel P. Berrangé wrote: > > > On Mon, Nov 30, 2020 at 11:06:14AM +0100, Michal Privoznik wrote: > > > > Currently, we configure QEMU to

Re: [PATCH] pci: Refuse to hotplug PCI Devices when the Guest OS is not ready

2020-10-23 Thread Igor Mammedov
On Fri, 23 Oct 2020 11:54:40 -0400 "Michael S. Tsirkin" wrote: > On Fri, Oct 23, 2020 at 09:47:14AM +0300, Marcel Apfelbaum wrote: > > Hi David, > > > > On Fri, Oct 23, 2020 at 6:49 AM David Gibson wrote: > > > > On Thu, 22 Oct 2020 11:01:04 -0400 > > "Michael S. Tsirkin" wrote: > >

Re: [PATCH REBASE 7/7] qemu: Use memory-backend-* for regular guest memory

2020-09-15 Thread Igor Mammedov
On Tue, 15 Sep 2020 10:59:04 +0100 Daniel P. Berrangé wrote: > On Tue, Sep 15, 2020 at 11:53:56AM +0200, Igor Mammedov wrote: > > On Tue, 15 Sep 2020 10:54:46 +0200 > > Michal Privoznik wrote: > > > > > On 9/8/20 3:55 PM, Ján Tomko wrote: > > > &

[PATCH v3] cphp: remove deprecated cpu-add command(s)

2020-09-15 Thread Igor Mammedov
These were deprecated since 4.0, remove both HMP and QMP variants. Users should use device_add command instead. To get list of possible CPUs and options, use 'info hotpluggable-cpus' HMP or query-hotpluggable-cpus QMP command. Signed-off-by: Igor Mammedov Reviewed-by: Thomas Huth Ac

Re: [PATCH REBASE 7/7] qemu: Use memory-backend-* for regular guest memory

2020-09-15 Thread Igor Mammedov
On Tue, 15 Sep 2020 10:54:46 +0200 Michal Privoznik wrote: > On 9/8/20 3:55 PM, Ján Tomko wrote: > > On a Tuesday in 2020, Michal Privoznik wrote: > > >> diff --git > >> a/tests/qemuxml2argvdata/memfd-memory-default-hugepage.x86_64-latest.args > >> b/tests/qemuxml2argvdata/memfd-memory-defau

Re: [PATCH v2] cphp: remove deprecated cpu-add command(s)

2020-09-14 Thread Igor Mammedov
On Mon, 14 Sep 2020 10:07:36 +0200 Michal Privoznik wrote: > On 9/14/20 9:46 AM, Igor Mammedov wrote: > > theses were deprecated since 4.0, remove both HMP and QMP variants. > > > > Users should use device_add command instead. To get list of > > possible CPUs and opti

[PATCH v2] cphp: remove deprecated cpu-add command(s)

2020-09-14 Thread Igor Mammedov
theses were deprecated since 4.0, remove both HMP and QMP variants. Users should use device_add command instead. To get list of possible CPUs and options, use 'info hotpluggable-cpus' HMP or query-hotpluggable-cpus QMP command. Signed-off-by: Igor Mammedov Reviewed-by: Thomas Huth Ac

Re: [PATCH] smp: drop support for deprecated (invalid topologies)

2020-09-14 Thread Igor Mammedov
On Fri, 11 Sep 2020 11:04:47 -0400 "Michael S. Tsirkin" wrote: > On Fri, Sep 11, 2020 at 09:32:02AM -0400, Igor Mammedov wrote: > > it's was deprecated since 3.1 > > > > Support for invalid topologies is removed, the user must ensure > > that topologie

[PATCH] smp: drop support for deprecated (invalid topologies)

2020-09-11 Thread Igor Mammedov
it's was deprecated since 3.1 Support for invalid topologies is removed, the user must ensure that topologies described with -smp include all possible cpus, i.e. (sockets * cores * threads) == maxcpus or QEMU will exit with error. Signed-off-by: Igor Mammedov --- docs/system/deprecate

[PATCH] cphp: remove deprecated cpu-add command(s)

2020-09-11 Thread Igor Mammedov
theses were deprecatedince since 4.0, remove both HMP and QMP variants. Users should use device_add commnad instead. To get list of possible CPUs and options, use 'info hotpluggable-cpus' HMP or query-hotpluggable-cpus QMP command. Signed-off-by: Igor Mammedov --- include/h

[PATCH 2/3] doc: Cleanup "'-mem-path' fallback to RAM" deprecation text

2020-09-11 Thread Igor Mammedov
it was actually removed in 5.0, commit 68a86dc15c (numa: remove deprecated -mem-path fallback to anonymous RAM) clean up forgotten remnants in docs. Signed-off-by: Igor Mammedov --- docs/system/deprecated.rst | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff

[PATCH 3/3] numa: remove fixup numa_state->num_nodes to MAX_NODES

2020-09-11 Thread Igor Mammedov
current code permits only nodeids in [0..MAX_NODES) range due to nodeid check in parse_numa_node() if (nodenr >= MAX_NODES) { error_setg(errp, "Max number of NUMA nodes reached: %" so subj fixup is not reachable, drop it. Signed-off-by: Igor Mammedov --- hw/co

[PATCH 1/3] numa: drop support for '-numa node' (without memory specified)

2020-09-11 Thread Igor Mammedov
command `info numa` and if separate memory devices (pc|nv-dimm) are present use `info memory-device` and subtract device memory from output of `info numa`. Signed-off-by: Igor Mammedov --- include/hw/boards.h| 2 -- include/sysemu/numa.h | 4 --- docs/system/deprecated.rst | 23

[PATCH 0/3] numa: cleanups for 5.2

2020-09-11 Thread Igor Mammedov
Remove deprecated default RAM splitting beween numa nodes that was deprecated since 4.1, and a couple of minor numa clean ups. Igor Mammedov (3): numa: drop support for '-numa node' (without memory specified) doc: Cleanup "'-mem-path' fallback to RAM" depreca

[PATCH v5] numa: forbid '-numa node, mem' for 5.1 and newer machine types

2020-06-09 Thread Igor Mammedov
Deprecation period is run out and it's a time to flip the switch introduced by cd5ff8333a. Disable legacy option for new machine types (since 5.1) and amend documentation. '-numa node,memdev' shall be used instead of disabled option with new machine types. Signed-off-by: Igor Mam

Re: [PATCH v4] numa: forbid '-numa node,mem' for 5.1 and newer machine types

2020-06-08 Thread Igor Mammedov
On Mon, 8 Jun 2020 08:55:08 -0400 "Michael S. Tsirkin" wrote: > On Mon, Jun 08, 2020 at 08:03:44AM -0400, Igor Mammedov wrote: > > Deprecation period is run out and it's a time to flip the switch > > introduced by cd5ff8333a. Disable legacy option for new machine &

[PATCH v4] numa: forbid '-numa node, mem' for 5.1 and newer machine types

2020-06-08 Thread Igor Mammedov
Deprecation period is run out and it's a time to flip the switch introduced by cd5ff8333a. Disable legacy option for new machine types (since 5.1) and amend documentation. '-numa node,memdev' shall be used instead of disabled option with new machine types. Signed-off-by: Igor Mam

Re: [PATCH v3] numa: forbid '-numa node, mem' for 5.1 and newer machine types

2020-06-08 Thread Igor Mammedov
On Fri, 5 Jun 2020 18:47:58 +0200 Greg Kurz wrote: > On Fri, 5 Jun 2020 12:03:21 -0400 > Igor Mammedov wrote: > > > Deprecation period is run out and it's a time to flip the switch > > introduced by cd5ff8333a. Disable legacy option for new machine >

Re: [PATCH] numa: forbid '-numa node, mem' for 5.1 and newer machine types

2020-06-05 Thread Igor Mammedov
On Thu, 4 Jun 2020 07:22:51 -0500 Eric Blake wrote: > On 6/2/20 3:41 AM, Igor Mammedov wrote: > > Deprecation period is run out and it's a time to flip the switch > > introduced by cd5ff8333a. Disable legacy option for new machine > > types (since 5.1) and amend docu

[PATCH v2] numa: forbid '-numa node, mem' for 5.1 and newer machine types

2020-06-05 Thread Igor Mammedov
Deprecation period is run out and it's a time to flip the switch introduced by cd5ff8333a. Disable legacy option for new machine types (since 5.1) and amend documentation. '-numa node,memdev' shall be used instead of disabled option with new machine types. Signed-off-by: Igor Mam

[PATCH v3] numa: forbid '-numa node, mem' for 5.1 and newer machine types

2020-06-05 Thread Igor Mammedov
Deprecation period is run out and it's a time to flip the switch introduced by cd5ff8333a. Disable legacy option for new machine types (since 5.1) and amend documentation. '-numa node,memdev' shall be used instead of disabled option with new machine types. Signed-off-by: Igor Mam

Re: [PATCH 4/5] qemu: Prefer -numa cpu over -numa node,cpus=

2020-06-05 Thread Igor Mammedov
On Thu, 4 Jun 2020 10:58:01 +0200 Michal Privoznik wrote: > On 5/27/20 3:58 PM, Igor Mammedov wrote: > > On Tue, 26 May 2020 17:31:09 +0200 > > Michal Privoznik wrote: > > > >> On 5/26/20 4:51 PM, Igor Mammedov wrote: > >>> On Mon, 25 May 2020 10

Re: [PATCH 5/5] qemu_validate.c: revert NUMA CPU range user warning

2020-06-02 Thread Igor Mammedov
On Mon, 1 Jun 2020 17:14:20 -0300 Daniel Henrique Barboza wrote: > On 6/1/20 4:40 PM, Peter Krempa wrote: > > On Mon, Jun 01, 2020 at 14:50:41 -0300, Daniel Henrique Barboza wrote: > >> Now that we have the auto-fill code in place, and with proper documentation > >> to let the user know that (1

[PATCH] numa: forbid '-numa node, mem' for 5.1 and newer machine types

2020-06-02 Thread Igor Mammedov
Deprecation period is run out and it's a time to flip the switch introduced by cd5ff8333a. Disable legacy option for new machine types (since 5.1) and amend documentation. '-numa node,memdev' shall be used instead of disabled option with new machine types. Signed-off-by

Re: [PATCH 4/5] qemu: Prefer -numa cpu over -numa node,cpus=

2020-05-27 Thread Igor Mammedov
On Tue, 26 May 2020 17:31:09 +0200 Michal Privoznik wrote: > On 5/26/20 4:51 PM, Igor Mammedov wrote: > > On Mon, 25 May 2020 10:05:08 +0200 > > Michal Privoznik wrote: > > > >> > >> This is a problem. The domain XML that is provided can't be chan

Re: [PATCH 4/5] qemu: Prefer -numa cpu over -numa node,cpus=

2020-05-26 Thread Igor Mammedov
On Mon, 25 May 2020 10:05:08 +0200 Michal Privoznik wrote: > On 5/22/20 7:18 PM, Igor Mammedov wrote: > > On Fri, 22 May 2020 18:28:31 +0200 > > Michal Privoznik wrote: > > > >> On 5/22/20 6:07 PM, Igor Mammedov wrote: > >>> On Fri, 22 May 2020 16

Re: [PATCH 4/5] qemu: Prefer -numa cpu over -numa node,cpus=

2020-05-22 Thread Igor Mammedov
On Fri, 22 May 2020 18:28:31 +0200 Michal Privoznik wrote: > On 5/22/20 6:07 PM, Igor Mammedov wrote: > > On Fri, 22 May 2020 16:14:14 +0200 > > Michal Privoznik wrote: > > > >> QEMU is trying to obsolete -numa node,cpus= because that uses > >> ambiguou

Re: [PATCH 4/5] qemu: Prefer -numa cpu over -numa node,cpus=

2020-05-22 Thread Igor Mammedov
On Fri, 22 May 2020 16:14:14 +0200 Michal Privoznik wrote: > QEMU is trying to obsolete -numa node,cpus= because that uses > ambiguous vCPU id to [socket, die, core, thread] mapping. The new > form is: > > -numa cpu,node-id=N,socket-id=S,die-id=D,core-id=C,thread-id=T > > which is repeated fo

Re: [libvirt] [PATCH v2 82/86] numa: forbid '-numa node, mem' for 5.0 and newer machine types

2020-01-16 Thread Igor Mammedov
On Thu, 16 Jan 2020 13:06:28 + Daniel P. Berrangé wrote: > On Thu, Jan 16, 2020 at 01:37:03PM +0100, Igor Mammedov wrote: > > On Thu, 16 Jan 2020 11:42:09 +0100 > > Michal Privoznik wrote: > > > > > On 1/15/20 5:52 PM, Igor Mammedov wrote: > > &g

Re: [libvirt] [PATCH v2 82/86] numa: forbid '-numa node, mem' for 5.0 and newer machine types

2020-01-16 Thread Igor Mammedov
On Thu, 16 Jan 2020 14:03:12 +0100 Michal Privoznik wrote: > On 1/16/20 1:37 PM, Igor Mammedov wrote: > > On Thu, 16 Jan 2020 11:42:09 +0100 > > Michal Privoznik wrote: > > > >> On 1/15/20 5:52 PM, Igor Mammedov wrote: > >>> On Wed, 15 Jan 202

Re: [libvirt] [PATCH v2 82/86] numa: forbid '-numa node, mem' for 5.0 and newer machine types

2020-01-16 Thread Igor Mammedov
On Thu, 16 Jan 2020 11:42:09 +0100 Michal Privoznik wrote: > On 1/15/20 5:52 PM, Igor Mammedov wrote: > > On Wed, 15 Jan 2020 16:34:53 +0100 > > Peter Krempa wrote: > > > >> On Wed, Jan 15, 2020 at 16:07:37 +0100, Igor Mammedov wrote: > >>> Deprec

Re: [libvirt] [PATCH v2 82/86] numa: forbid '-numa node, mem' for 5.0 and newer machine types

2020-01-15 Thread Igor Mammedov
On Wed, 15 Jan 2020 16:34:53 +0100 Peter Krempa wrote: > On Wed, Jan 15, 2020 at 16:07:37 +0100, Igor Mammedov wrote: > > Deprecation period is ran out and it's a time to flip the switch > > introduced by cd5ff8333a. > > Disable legacy option for new machine typ

[libvirt] [PATCH v2 86/86] numa: remove deprecated implicit RAM distribution between nodes

2020-01-15 Thread Igor Mammedov
m (4.2 and older machine types) It's recommended to use "memdev" variant for new virtual machines and use "mem" only when it's necessary to migrate already existing virtual machine started with implicit RAM distribution. Signed-off-by: Igor Mammedov --- C

[libvirt] [PATCH v2 82/86] numa: forbid '-numa node, mem' for 5.0 and newer machine types

2020-01-15 Thread Igor Mammedov
Deprecation period is ran out and it's a time to flip the switch introduced by cd5ff8333a. Disable legacy option for new machine types and amend documentation. Signed-off-by: Igor Mammedov --- CC: peter.mayd...@linaro.org CC: ehabk...@redhat.com CC: marcel.apfelb...@gmail.com CC: m...@redha

Re: [libvirt] [PATCH 2/2] Add -mem-shared option

2019-12-10 Thread Igor Mammedov
On Tue, 10 Dec 2019 11:34:32 +0100 Markus Armbruster wrote: > Eduardo Habkost writes: > > > +Markus > > > > On Tue, Dec 03, 2019 at 03:43:03PM +0100, Igor Mammedov wrote: > >> On Tue, 3 Dec 2019 09:56:15 +0100 > >> Thomas Huth wrote: > >>

Re: [libvirt] [PATCH 2/2] Add -mem-shared option

2019-12-03 Thread Igor Mammedov
On Tue, 3 Dec 2019 09:56:15 +0100 Thomas Huth wrote: > On 02/12/2019 22.00, Eduardo Habkost wrote: > > On Mon, Dec 02, 2019 at 08:39:48AM +0100, Igor Mammedov wrote: > >> On Fri, 29 Nov 2019 18:46:12 +0100 > >> Paolo Bonzini wrote: > >> > >

[libvirt] [PATCH v2] deprecate -mem-path fallback to anonymous RAM

2019-06-25 Thread Igor Mammedov
vided backing file. Signed-off-by: Igor Mammedov --- v2: * improve text language (Markus Armbruster ) numa.c | 6 -- qemu-deprecated.texi | 9 + 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/numa.c b/numa.c index 91a29138a2..c15e53e92d 100644

Re: [libvirt] [Qemu-devel] [PATCH] deprecate -mem-path fallback to anonymous RAM

2019-06-25 Thread Igor Mammedov
On Mon, 24 Jun 2019 16:01:49 +0200 Markus Armbruster wrote: > Igor Mammedov writes: > > > On Mon, 24 Jun 2019 10:17:33 +0200 > > Markus Armbruster wrote: > > > >> Igor Mammedov writes: > >> > >> > Fallback might affect guest or w

Re: [libvirt] [Qemu-devel] [PATCH] deprecate -mem-path fallback to anonymous RAM

2019-06-24 Thread Igor Mammedov
On Mon, 24 Jun 2019 10:36:55 +0100 Daniel P. Berrangé wrote: > On Mon, Jun 24, 2019 at 10:17:33AM +0200, Markus Armbruster wrote: > > Igor Mammedov writes: > > > > > Fallback might affect guest or worse whole host performance > > > or functionality if back

Re: [libvirt] [Qemu-devel] [PATCH] deprecate -mem-path fallback to anonymous RAM

2019-06-24 Thread Igor Mammedov
On Mon, 24 Jun 2019 10:17:33 +0200 Markus Armbruster wrote: > Igor Mammedov writes: > > > Fallback might affect guest or worse whole host performance > > or functionality if backing file were used to share guest RAM > > with another process. > > > > Patch

[libvirt] [PATCH] deprecate -mem-path fallback to anonymous RAM

2019-06-20 Thread Igor Mammedov
vided backing file. Signed-off-by: Igor Mammedov --- PS: Patch is written on top of [PATCH v4 0/3] numa: deprecate '-numa node, mem' and default memory distribution to avoid conflicts in qemu-deprecated.texi numa.c | 4 ++-- qemu-deprecated.texi | 8 2 fi

Re: [libvirt] [Qemu-devel] [PATCH v4 0/3] numa: deprecate '-numa node, mem' and default memory distribution

2019-06-17 Thread Igor Mammedov
On Thu, 30 May 2019 10:33:16 +0200 Igor Mammedov wrote: > Changes since v3: > - simplify series by dropping idea of showing property values in > "qom-list-properties" > and use MachineInfo in QAPI schema instead > > Changes since v2: > - taking in accou

[libvirt] [PATCH v5 1/3] machine: show if CLI option '-numa node, mem' is supported in QAPI schema

2019-06-10 Thread Igor Mammedov
27;true' for machines that currently support NUMA, but it will be flipped to 'false' later on, once deprecation period expires and kept 'true' only for old machine types that used to support the legacy option so it won't break existing configuration that are using it. S

Re: [libvirt] [Qemu-devel] [PATCH v4 1/3] machine: show if CLI option '-numa node, mem' is supported in QAPI schema

2019-06-10 Thread Igor Mammedov
On Fri, 07 Jun 2019 19:39:17 +0200 Markus Armbruster wrote: > Igor Mammedov writes: > > > Legacy '-numa node,mem' option has a number of issues and mgmt often > > defaults to it. Unfortunately it's no possible to replace it with > > an alternative &#

Re: [libvirt] [Qemu-devel] [PATCH v4 0/3] numa: deprecate '-numa node, mem' and default memory distribution

2019-06-10 Thread Igor Mammedov
On Fri, 07 Jun 2019 19:28:58 +0200 Markus Armbruster wrote: > Igor Mammedov writes: > > > Changes since v3: > > - simplify series by dropping idea of showing property values in > > "qom-list-properties" > > and use MachineInfo in QAPI schema ins

[libvirt] [PATCH v4 3/3] numa: deprecate implict memory distribution between nodes

2019-05-30 Thread Igor Mammedov
we could consolidate guest RAM allocation using memory backends making it consistent and possibly later on transition to using memory devices instead of adhoc memory mapping for the initial RAM. Signed-off-by: Igor Mammedov --- numa.c | 3 +++ qemu-deprecated.texi | 8 2

[libvirt] [PATCH v4 1/3] machine: show if CLI option '-numa node, mem' is supported in QAPI schema

2019-05-30 Thread Igor Mammedov
set to 'true' for machines that currently support NUMA, but it will be flipped to 'false' later on, once deprecation period expires and kept 'true' only for old machine types that used to support the legacy option so it won't break existing configuration that are

[libvirt] [PATCH v4 0/3] numa: deprecate '-numa node, mem' and default memory distribution

2019-05-30 Thread Igor Mammedov
w.mail-archive.com/qemu-devel@nongnu.org/msg617694.html CC: libvir-list@redhat.com CC: ehabk...@redhat.com CC: pbonz...@redhat.com CC: berra...@redhat.com CC: arm...@redhat.com Igor Mammedov (3): machine: show if CLI option '-numa node,mem' is supported in QAPI schema numa: d

[libvirt] [PATCH v4 2/3] numa: deprecate 'mem' parameter of '-numa node' option

2019-05-30 Thread Igor Mammedov
in compatible manner (migration wise). Later down the road that will allow to consolidate means of how guest RAM is allocated and would permit us to clean up quite a bit memory allocations and numa code, leaving only 'memdev' implementation in place. Signed-off-by: Igor Mammedov ---

Re: [libvirt] [Qemu-devel] [PATCH v3 1/6] pc: fix possible NULL pointer dereference in pc_machine_get_device_memory_region_size()

2019-05-28 Thread Igor Mammedov
On Mon, 27 May 2019 18:36:25 +0200 Markus Armbruster wrote: > Igor Mammedov writes: > > > QEMU will crash when device-memory-region-size property is read if > > ms->device_memory > > wasn't initialized yet (ex: property being inspected during preconf

Re: [libvirt] [Qemu-devel] [PATCH v3 4/6] numa: introduce "numa-mem-supported" machine property

2019-05-28 Thread Igor Mammedov
On Mon, 27 May 2019 20:38:57 +0200 Markus Armbruster wrote: > Igor Mammedov writes: > > > '-numa mem' option has a number of issues and mgmt often defaults > > to it. Unfortunately it's no possible to replace it with an alternative > > '-numa memd

[libvirt] [PATCH v3 3/6] qmp: qmp_qom_list_properties(): ignore empty string options

2019-05-17 Thread Igor Mammedov
Current QAPI semantics return empty "" string in case string property value hasn't been set (i.e. NULL). Do not show initial value in this case in "qom-list-properties" command output to reduce clutter. Signed-off-by: Igor Mammedov --- qmp.c | 12 +++- 1 fi

[libvirt] [PATCH v3 4/6] numa: introduce "numa-mem-supported" machine property

2019-05-17 Thread Igor Mammedov
(when probing for supported machine types with '-machine none') or at runtime at preconfig time before numa mapping is configured and decide if they should used legacy '-numa mem' or alternative '-numa memdev' option. Signed-off-by: Igor Mammedov --- include/hw/boards.h

[libvirt] [PATCH v3 6/6] numa: deprecate implict memory distribution between nodes

2019-05-17 Thread Igor Mammedov
used to provide explicit memory distribution for old machine types Signed-off-by: Igor Mammedov --- numa.c | 3 +++ qemu-deprecated.texi | 8 2 files changed, 11 insertions(+) diff --git a/numa.c b/numa.c index 2205773..6d45a1f 100644 --- a/numa.c +++ b/numa.c @@ -

[libvirt] [PATCH v3 5/6] numa: deprecate 'mem' parameter of '-numa node' option

2019-05-17 Thread Igor Mammedov
so allow to clean up a bit our numa code, leaving only 'memdev' impl. in place and several boards that use node_mem to generate FDT/ACPI description from it. Signed-off-by: Igor Mammedov --- v3: * mention "numa-mem-supported" machine property in deprecation documentation. ---

[libvirt] [PATCH v3 1/6] pc: fix possible NULL pointer dereference in pc_machine_get_device_memory_region_size()

2019-05-17 Thread Igor Mammedov
QEMU will crash when device-memory-region-size property is read if ms->device_memory wasn't initialized yet (ex: property being inspected during preconfig time). Instead of crashing return 0 if ms->device_memory hasn't been initialized. Signed-off-by: Igor Mammedov ---

[libvirt] [PATCH v3 0/6] numa: deprecate '-numa node, mem' and default memory distribution

2019-05-17 Thread Igor Mammedov
g180917.html CC: libvir-list@redhat.com CC: ehabk...@redhat.com CC: pbonz...@redhat.com CC: berra...@redhat.com CC: arm...@redhat.com Igor Mammedov (6): pc: fix possible NULL pointer dereference in pc_machine_get_device_memory_region_size() qmp: make "qom-list-properties" show in

[libvirt] [PATCH v3 2/6] qmp: make "qom-list-properties" show initial property values

2019-05-17 Thread Igor Mammedov
support legacy "-numa mem=FOO" CLI option and which don't and require alternative '-numa memdev' option being used. Signed-off-by: Igor Mammedov --- qapi/misc.json | 5 - qmp.c | 5 + 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/qapi/misc.json

Re: [libvirt] [Qemu-devel] [PATCH v2] numa: warn if numa 'mem' option or default RAM splitting between nodes is used.

2019-03-20 Thread Igor Mammedov
On Wed, 20 Mar 2019 15:24:42 + Daniel P. Berrangé wrote: > On Wed, Mar 20, 2019 at 04:20:19PM +0100, Igor Mammedov wrote: > > > This could be solved if QEMU has some machine type based property > > > that indicates whether "memdev" is required for a given mac

Re: [libvirt] [Qemu-devel] [PATCH v2] numa: warn if numa 'mem' option or default RAM splitting between nodes is used.

2019-03-20 Thread Igor Mammedov
On Wed, 20 Mar 2019 13:46:59 + Daniel P. Berrangé wrote: > On Wed, Mar 20, 2019 at 10:32:53AM -0300, Eduardo Habkost wrote: > > On Wed, Mar 20, 2019 at 11:51:51AM +, Daniel P. Berrangé wrote: > > > On Wed, Mar 20, 2019 at 11:26:34AM +0100, I

Re: [libvirt] [Qemu-devel] [PATCH v2] numa: warn if numa 'mem' option or default RAM splitting between nodes is used.

2019-03-20 Thread Igor Mammedov
On Wed, 20 Mar 2019 11:51:51 + Daniel P. Berrangé wrote: > On Wed, Mar 20, 2019 at 11:26:34AM +0100, Igor Mammedov wrote: > > On Tue, 19 Mar 2019 14:51:07 + > > Daniel P. Berrangé wrote: > > > > > On Tue, Mar 19, 2019 at 02:08:01PM +0100, Igor Mammedov

Re: [libvirt] [Qemu-devel] [PATCH v2] numa: warn if numa 'mem' option or default RAM splitting between nodes is used.

2019-03-20 Thread Igor Mammedov
On Tue, 19 Mar 2019 14:51:07 + Daniel P. Berrangé wrote: > On Tue, Mar 19, 2019 at 02:08:01PM +0100, Igor Mammedov wrote: > > On Thu, 7 Mar 2019 10:07:05 + > > Daniel P. Berrangé wrote: > > > > > On Wed, Mar 06, 2019 at 07:54:17PM +0100, Igor Mammedov

Re: [libvirt] [Qemu-devel] [PATCH 1/2] numa: deprecate 'mem' parameter of '-numa node' option

2019-03-19 Thread Igor Mammedov
On Sun, 10 Mar 2019 11:14:08 +0100 Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Mon, Mar 04, 2019 at 12:45:14PM +0100, Markus Armbruster wrote: > >> Daniel P. Berrangé writes: > >> > >> > On Mon, Mar 04, 2019 at 08:13:53AM +0100, Markus Armbruster wrote: > >> >> If we

Re: [libvirt] [PATCH v2] numa: warn if numa 'mem' option or default RAM splitting between nodes is used.

2019-03-19 Thread Igor Mammedov
On Thu, 7 Mar 2019 10:07:05 + Daniel P. Berrangé wrote: > On Wed, Mar 06, 2019 at 07:54:17PM +0100, Igor Mammedov wrote: > > On Wed, 6 Mar 2019 18:16:08 + > > Daniel P. Berrangé wrote: > > > > > On Wed, Mar 06, 2019 at 06:33:25PM +0100, Igor Mammedo

Re: [libvirt] [Qemu-devel] [PATCH 1/2] numa: deprecate 'mem' parameter of '-numa node' option

2019-03-18 Thread Igor Mammedov
On Mon, 4 Mar 2019 14:52:30 +0100 Igor Mammedov wrote: > On Fri, 1 Mar 2019 18:01:52 + > "Dr. David Alan Gilbert" wrote: > > > * Igor Mammedov (imamm...@redhat.com) wrote: > > > On Fri, 1 Mar 2019 15:49:47 + > > > Daniel P. Berrangé wrote:

Re: [libvirt] [Qemu-devel] [PATCH 1/2] numa: deprecate 'mem' parameter of '-numa node' option

2019-03-14 Thread Igor Mammedov
On Sun, 10 Mar 2019 11:16:33 +0100 Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Wed, Mar 06, 2019 at 08:03:48PM +0100, Igor Mammedov wrote: > >> On Mon, 4 Mar 2019 16:35:16 + > >> Daniel P. Berrangé wrote: > >> > >> &g

Re: [libvirt] [PATCH] numa: warn if numa 'mem' option or default RAM splitting between nodes is used.

2019-03-07 Thread Igor Mammedov
On Thu, 7 Mar 2019 10:04:56 + Daniel P. Berrangé wrote: > On Wed, Mar 06, 2019 at 07:48:22PM +0100, Igor Mammedov wrote: > > On Wed, 6 Mar 2019 17:10:37 + > > Daniel P. Berrangé wrote: > > > > > On Wed, Mar 06, 2019 at 05:58:35PM +0100, Igor Mammedov

Re: [libvirt] [Qemu-devel] [PATCH 1/2] numa: deprecate 'mem' parameter of '-numa node' option

2019-03-06 Thread Igor Mammedov
On Mon, 4 Mar 2019 17:20:13 +0100 Michal Privoznik wrote: > On 3/4/19 3:24 PM, Daniel P. Berrangé wrote: > > On Mon, Mar 04, 2019 at 03:16:41PM +0100, Igor Mammedov wrote: > >> On Mon, 4 Mar 2019 12:39:08 + > >> Daniel P. Berrangé wrote: > >> > >&

Re: [libvirt] [Qemu-devel] [PATCH 1/2] numa: deprecate 'mem' parameter of '-numa node' option

2019-03-06 Thread Igor Mammedov
On Mon, 4 Mar 2019 16:35:16 + Daniel P. Berrangé wrote: > On Mon, Mar 04, 2019 at 05:20:13PM +0100, Michal Privoznik wrote: > > On 3/4/19 3:24 PM, Daniel P. Berrangé wrote: > > > On Mon, Mar 04, 2019 at 03:16:41PM +0100, Igor Mammedov wrote: > > > > On

Re: [libvirt] [PATCH v2] numa: warn if numa 'mem' option or default RAM splitting between nodes is used.

2019-03-06 Thread Igor Mammedov
On Wed, 6 Mar 2019 18:16:08 + Daniel P. Berrangé wrote: > On Wed, Mar 06, 2019 at 06:33:25PM +0100, Igor Mammedov wrote: > > Amend -numa option docs and print warnings if 'mem' option or default RAM > > splitting between nodes is used. It's intended to di

  1   2   >