Re: [libvirt] [PATCHv2] Do not keep empty log files for deleted domains

2019-07-09 Thread Jan Zerebecki
ome configurable "N". Not if time based rotation is already desired, then there is no need to know if the guest still exists. If its not desired, then this is as complicated as you say, but the existing logrotate config already doesn't fulfill that. -- Best regards, Jan Zerebecki -- lib

Re: [libvirt] [PATCHv2] Do not keep empty log files for deleted domains

2019-07-08 Thread Jan Zerebecki
On 08/07/2019 23.28, Jim Fehlig wrote: > On 7/8/19 12:28 PM, Jan Zerebecki wrote: >> With logrotates copytruncate when e.g. domain1 doesn't exist anymore >> /var/log/libvirt/qemu/domain1.log will still exist after rotation even >> though it will never be written to. When

[libvirt] [PATCHv2] Do not keep empty log files for deleted domains

2019-07-08 Thread Jan Zerebecki
fixes the issue for qemu domains, others still have the same problem unfixed. Signed-off-by: Jan Zerebecki --- v2: drop changes to other logrotate confis src/remote/libvirtd.qemu.logrotate.in | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/remote

Re: [libvirt] [PATCH] Do not keep empty log files for deleted domains

2019-07-03 Thread Jan Zerebecki
On 03/07/2019 08.55, Peter Krempa wrote: > On Wed, Jul 03, 2019 at 08:32:21 +0200, Jan Zerebecki wrote: >> On 03/07/2019 08.03, Peter Krempa wrote: >>> I'm not sure that this is the right thing to do. virtlogd has some >>> internal log rotation mechanisms >> &g

Re: [libvirt] [PATCH] Do not keep empty log files for deleted domains

2019-07-03 Thread Jan Zerebecki
3 08:06 /var/log/libvirt/qemu/foo.log -- Best regards, Jan Zerebecki -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] Do not keep empty log files for deleted domains

2019-07-02 Thread Jan Zerebecki
-by: Jan Zerebecki --- src/remote/libvirtd.libxl.logrotate.in | 4 +++- src/remote/libvirtd.logrotate.in | 4 +++- src/remote/libvirtd.lxc.logrotate.in | 4 +++- src/remote/libvirtd.qemu.logrotate.in | 4 +++- 4 files changed, 12 insertions(+), 4 deletions(-) diff --git a/src/remote