Re: [libvirt] [PATCH v2 2/7] internal: introduce macro helpers to check flag requirements

2015-03-27 Thread Jeff Nelson
On Fri, Mar 27, 2015 at 11:13:07AM -0500, Jeff Nelson wrote: > On Fri, Mar 27, 2015 at 11:01:23AM +0100, Pavel Hrdina wrote: > > Similar to VIR_EXLUSIVE_FLAGS, it will error out if flag requirement is > > not met. > > > > Signed-off-by: Pavel Hrdina >

Re: [libvirt] [PATCH v2 2/7] internal: introduce macro helpers to check flag requirements

2015-03-27 Thread Jeff Nelson
On Fri, Mar 27, 2015 at 11:01:23AM +0100, Pavel Hrdina wrote: > Similar to VIR_EXLUSIVE_FLAGS, it will error out if flag requirement is > not met. > > Signed-off-by: Pavel Hrdina > --- > src/internal.h | 43 +++ > 1 file changed, 43 insertions(+) > > diff

Re: [libvirt] [PATCH v2 1/7] internal: introduce macro helpers to reject exclusive flags

2015-03-27 Thread Jeff Nelson
On Fri, Mar 27, 2015 at 11:01:22AM +0100, Pavel Hrdina wrote: > Inspired by commit 7e437ee7 that introduced similar macros for virsh > commands so we don't have to repeat the same code all over. > > Signed-off-by: Pavel Hrdina > --- > src/internal.h | 44 +

Re: [libvirt] [PATCH v2 6/7] virsh: introduce new macros to help check flag requirements

2015-03-27 Thread Jeff Nelson
On Fri, Mar 27, 2015 at 11:01:27AM +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > tools/virsh.h | 52 > 1 file changed, 52 insertions(+) > > diff --git a/tools/virsh.h b/tools/virsh.h > index df2ea7f..fde20ef 100644 > --- a/t