[PATCH] conf: fix block type CDROM cannot support startupPolicy

block type CDROM also support startupPolicy in the past, so let us fix it. Signed-off-by: Jie Wang --- src/conf/domain_conf.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index f7025bffe4..dd374e8ab3 100644 --- a/src

[libvirt] [PATCH] qemu: distinguish pr disk before qemuHotplugRemoveManagedPR

when a disk without PR perform attach or detach operation, need not call qemuHotplugRemoveManagedPR, otherwise, it will print err log about PR, let us fix it. Signed-off-by: Jie Wang --- src/qemu/qemu_hotplug.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/qemu

[libvirt] [PATCH v2] qemu: fix pr-helper0 remain

the pr-helper process, so qemuProcessKillManagedPRDaemon could use the same treatment. Signed-off-by: Jie Wang --- src/qemu/qemu_hotplug.c | 3 +-- src/qemu/qemu_process.c | 3 --- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index

[libvirt] [PATCH] qemu: fix pr-helper0 remain

in qemuHotplugRemoveManagedPR. Signed-off-by: Jie Wang --- src/qemu/qemu_hotplug.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 34249bd030..5e4a929738 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c

[libvirt] [PATCH] qemu_command: fix double_close vhostfd in qemuBuildHostdevCommandLine

vhostfd passed to cmd->passfd in virCommandPassFD, virCommandFree will always close cmd->passfd when qemuBuildSCSIVHostHostdevDevStr failed. Signed-off-by: Jie Wang --- src/qemu/qemu_command.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_com

[libvirt] [PATCH] conf: Remove iothreads restriction in virDomainDefCheckABIStabilityFlags

The number of iothreads is not part of the vm state sent during migration, nor exposed to the guest ABI, so this restriction is a mistaken in libvirt. Let's remove that bit of code. Signed-off-by: Jie Wang --- src/conf/domain_conf.c | 8 1 file changed, 8 deletions(-) diff --git a/src

[libvirt] [PATCH] qemu: Fix IOThread pids lost after qemuProcessReconnect

>From fca1732c0e1f691fb25c614349d5486bbc73a109 Mon Sep 17 00:00:00 2001 From: Jie Wang Date: Wed, 17 Oct 2018 22:55:51 +0800 Subject: [PATCH] qemu: Fix IOThread pids lost after qemuProcessReconnect IOThread pids info will lost after libvirtd restart, then if we call pinIOThr

[libvirt] [PATCH] qemu: Fix IOThread pids lost after qemuProcessReconnect

>From fca1732c0e1f691fb25c614349d5486bbc73a109 Mon Sep 17 00:00:00 2001 From: Jie Wang Date: Wed, 17 Oct 2018 22:55:51 +0800 Subject: [PATCH] qemu: Fix IOThread pids lost after qemuProcessReconnect IOThread pids info will lost after libvirtd restart, then if we call pinIOThr

[libvirt] [PATCH] qemu: stop qemu progress when restore failed

>From 29482622218f525f0133be0b7db74835174035d9 Mon Sep 17 00:00:00 2001 From: Jie Wang Date: Thu, 5 Jul 2018 09:52:03 +0800 Subject: [PATCH] qemu: stop qemu progress when restore failed if qemuProcessStartCPUs perform failed in qemuDomainSaveImageStartVM, we need to stop qemu progress, otherw

[libvirt] [PATCH] conf: Introduce align for hostmem-file

QEMU has add the 'align' option to 'memory-backend-file'. Expose this option to users by new element align. Signed-off-by: Jie Wang --- docs/formatdomain.html.in | 18 +++ docs/schemas/domaincommon.rng | 7 +++ src/conf/domain_conf.c

[libvirt] [PATCH] blockjob: Fix a error checking of blockjob status in some case

offset and len can also be equal to 0 on failed if blockjob return status:"BLOCK_JOB_COMPLETED" with error:"File descriptor in bad state", this bug can be reproduced easily if you perform a async block job on read only filesystem, so it's very worthwhile for us to check 'error' in this case. ---

[libvirt] [PATCH V4] blockjob: Fix error checking of blockjob status

offset and len can also be equal to 0 on failed if blockjob return status:"BLOCK_JOB_COMPLETED" with error:"File descriptor in bad state", so we need to check 'error' in this case. --- src/qemu/qemu_monitor_json.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[libvirt] [PATCH V3] blockjob: Fix error checking of blockjob status

offset and len can also be equal to 0 on failed if blockjob return status:"BLOCK_JOB_COMPLETED" with error:"File descriptor in bad state", so it's better to make our decision based on whether 'error' is non-NULL. --- src/qemu/qemu_monitor_json.c | 3 +-- 1 file changed, 1 insertion(+), 2

[libvirt] [PATCH V2] blockjob: Fix error checking of blockjob status

offset and len can also be equal to 0 on failed if blockjob return status:"BLOCK_JOB_COMPLETED" with error:"File descriptor in bad state", so it's better to make our decision based on whether 'error' is non-NULL. --- src/qemu/qemu_monitor_json.c | 3 +-- 1 file changed, 1 insertion(+), 2

[libvirt] [PATCH] blockjob: Fix error checking of blockjob status

when the blockjob return status:"BLOCK_JOB_COMPLETED" with error: "File descriptor in bad state", "offset" and "len" are equal to zero, but the blockjob event should be "VIR_DOMAIN_BLOCK_JOB_FAILED" --- src/qemu/qemu_monitor_json.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[libvirt] [PATCH] blockjob: Fix error checking of blockjob status

when the blockjob return status:"BLOCK_JOB_COMPLETED" with error: "File descriptor in bad state", "offset" and "len" are equal to zero, but the blockjob event should be "VIR_DOMAIN_BLOCK_JOB_FAILED" --- src/qemu/qemu_monitor_json.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[libvirt] [PATCH] qemuDomainBlockCopyCommon: Fix the memory leak

When take the cleanup branch, will leads to the mirror memory leak --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 1e3c7fc..74cc2c4 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c

[libvirt] [PATCH] libvirt-override: fix flags mutually exclusize

-by: Jie Wang <wangji...@huawei.com> --- libvirt-override.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt-override.c b/libvirt-override.c index 9e40f00..7bdc09c 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -727,7

[libvirt] [PATCH] libvirt-override: fix flags mutually exclusize

-off-by: Jie Wang <wangji...@huawei.com> --- libvirt-override.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt-override.c b/libvirt-override.c index 9e40f00..7bdc09c 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -727,7

[libvirt] [PATCH] remove the dead code this patch is to remove the dead code Signed-off-by: JieWang <wangji...@huawei.com>

From: JieWang Signed-off-by: JieWang --- src/qemu/qemu_migration.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 6a683f7..759e15a 100644 --- a/src/qemu/qemu_migration.c +++