Re: [PATCH v2] selinux label: restore all labels when some labels fail to set

2020-11-20 Thread Jin Yan
On 2020/11/20 15:49, Michal Privoznik wrote: On 11/19/20 3:54 PM, Jin Yan wrote: On 2020/11/13 22:33, Michal Privoznik wrote: On 11/13/20 10:47 AM, Jin Yan wrote: Hi Michal, I found this problem while performing migration, based on       libvirt version: 6.2.0       SELinux mode

Re: [PATCH v2] selinux label: restore all labels when some labels fail to set

2020-11-19 Thread Jin Yan
On 2020/11/13 22:33, Michal Privoznik wrote: On 11/13/20 10:47 AM, Jin Yan wrote: Hi Michal, I found this problem while performing migration, based on     libvirt version: 6.2.0     SELinux mode: permissive Steps: 1. start a vm configured with pipe-type serial port

Re: [PATCH v2] selinux label: restore all labels when some labels fail to set

2020-11-13 Thread Jin Yan
On 2020/11/13 2:54, Michal Privoznik wrote: On 11/12/20 3:07 PM, Jin Yan wrote: When migration fails, qemuMigrationDstPrepareAny will call qemuProcessStop to restore labels only after all labels are successfully set. If some labels fail to set, the labels that have been set will not be restored

[PATCH v2] selinux label: restore all labels when some labels fail to set

2020-11-12 Thread Jin Yan
When migration fails, qemuMigrationDstPrepareAny will call qemuProcessStop to restore labels only after all labels are successfully set. If some labels fail to set, the labels that have been set will not be restored. Signed-off-by: Jin Yan --- src/qemu/qemu_security.c | 12 ++-- 1 file

[PATCH] selinux label: restore all labels when some labels fail to set

2020-11-11 Thread Jin Yan
When migration fails, qemuMigrationDstPrepareAny will call qemuProcessStop to restore labels only after all labels are successfully set. If some labels fail to set, the labels that have been set will not be restore. Signed-off-by: Jin Yan --- src/qemu/qemu_security.c | 11 +-- 1 file

[PATCH v2] virnetserver: fix some memory leaks in virNetTLSContextReloadForServer

2020-08-12 Thread Jin Yan
These leaks were introduced in commit 15d280fa97b0, use g_autofree for all cert_path pointers. Signed-off-by: Jin Yan --- src/rpc/virnettlscontext.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/rpc/virnettlscontext.c b/src/rpc/virnettlscontext.c index

Re: [PATCH] virnetserver: fix some memory leaks in virNetTLSContextReloadForServer

2020-08-09 Thread Jin Yan
Hi Daniel, I tried to apply this patch locally and there was no corruption. Now I regenerate it, please apply it again. Thanks, Yan From 0f667550dbe2e79e8d3c5881b9102c15149546ee Mon Sep 17 00:00:00 2001 From: Jin Yan Date: Fri, 7 Aug 2020 15:59:45 +0800 Subject: [PATCH] virnetserver

[PATCH] virnetserver: fix some memory leaks in virNetTLSContextReloadForServer

2020-08-07 Thread Jin Yan
From 55fce33e9cf2d5ea58ebc44b4d78f9c12122fdcb Mon Sep 17 00:00:00 2001 From: Jin Yan Date: Fri, 7 Aug 2020 15:59:45 +0800 Subject: [PATCH] virnetserver: fix some memory leaks in  virNetTLSContextReloadForServer These leaks were introduced in commit 15d280fa97b0, use g_autofree for all cert_path

[PATCH] qemu: fix memleaks in qemuDomainAttachDeviceLive()

2020-07-13 Thread Jin Yan
From e46e168f9767b8b291f23217fc7a62163c82eaf8 Mon Sep 17 00:00:00 2001 From: Jin Yan Date: Tue, 7 Jul 2020 21:58:52 +0800 Subject: [PATCH] qemu: fix memleaks in qemuDomainAttachDeviceLive() During disk hotplugging, qemuDomainAttachDeviceLive() add the new disk to the device list of the VM