Re: [libvirt] [PATCH] qemu: hotplug: fail when net device detach times out

2018-03-13 Thread Jonathan Davies
On 13/03/18 14:23, Daniel P. Berrangé wrote: On Tue, Mar 13, 2018 at 02:07:08PM +, Jonathan Davies wrote: qemuDomainDetachNetDevice should not treat a timeout in a call to qemuDomainWaitForDeviceRemoval as success. Instead, it should treat it as failure -- this is the intention behind

[libvirt] [PATCH] qemu: hotplug: fail when net device detach times out

2018-03-13 Thread Jonathan Davies
with a non-zero exit status, which is more appropriate. Signed-off-by: Jonathan Davies <jonathan.dav...@nutanix.com> --- src/qemu/qemu_hotplug.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 4be0f546c..d9a