Re: [PULL 00/39] Migration 20231024 patches

2023-10-26 Thread Juan Quintela
Stefan Hajnoczi wrote: > On Tue, 24 Oct 2023 at 23:45, Juan Quintela wrote: >> >> The following changes since commit a95260486aa7e78d7c7194eba65cf03311ad94ad: >> >> Merge tag 'pull-tcg-20231023' of https://gitlab.com/rth7680/qemu into >> staging (202

[PULL 32/39] migration: Use vmstate_register_any() for audio

2023-10-24 Thread Juan Quintela
We can have more than one audio backend. void audio_init_audiodevs(void) { AudiodevListEntry *e; QSIMPLEQ_FOREACH(e, &audiodevs, next) { audio_init(e->dev, &error_fatal); } } Reviewed-by: Stefan Berger Signed-off-by: Juan Quintela Message-ID: <20231020090731.

[PULL 39/39] migration: Deprecate old compression method

2023-10-24 Thread Juan Quintela
Acked-by: Stefan Hajnoczi Acked-by: Peter Xu Reviewed-by: Markus Armbruster Signed-off-by: Juan Quintela Message-ID: <20231018115513.2163-6-quint...@redhat.com> --- docs/about/deprecated.rst | 8 + qapi/migration.json | 63 ++- mig

[PULL 38/39] migration: Deprecate block migration

2023-10-24 Thread Juan Quintela
It is obsolete. It is better to use driver-mirror with NBD instead. CC: Kevin Wolf CC: Eric Blake CC: Stefan Hajnoczi CC: Hanna Czenczek Acked-by: Stefan Hajnoczi Reviewed-by: Markus Armbruster Signed-off-by: Juan Quintela Message-ID: <20231018115513.2163-5-quint...@redhat.com> ---

[PULL 37/39] migration: migrate 'blk' command option is deprecated.

2023-10-24 Thread Juan Quintela
Use blocked-mirror with NBD instead. Acked-by: Stefan Hajnoczi Reviewed-by: Thomas Huth Reviewed-by: Markus Armbruster Signed-off-by: Juan Quintela Message-ID: <20231018115513.2163-4-quint...@redhat.com> --- docs/about/deprecated.rst | 9 + qapi/migration.json

[PULL 36/39] migration: migrate 'inc' command option is deprecated.

2023-10-24 Thread Juan Quintela
Use blockdev-mirror with NBD instead. Reviewed-by: Thomas Huth Acked-by: Stefan Hajnoczi Reviewed-by: Markus Armbruster Signed-off-by: Juan Quintela Message-ID: <20231018115513.2163-3-quint...@redhat.com> --- docs/about/deprecated.rst | 8 qapi/migration.json

[PULL 33/39] migration: Use vmstate_register_any() for eeprom93xx

2023-10-24 Thread Juan Quintela
We can have more than one eeprom93xx. For instance: e100_nic_realize() -> eeprom93xx_new() Reviewed-by: Stefan Berger Signed-off-by: Juan Quintela Message-ID: <20231020090731.28701-13-quint...@redhat.com> --- hw/nvram/eeprom93xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PULL 35/39] qemu-iotests: Filter warnings about block migration being deprecated

2023-10-24 Thread Juan Quintela
Create a new filter that removes the two warnings for test 183. Reviewed-by: Hanna Czenczek Signed-off-by: Juan Quintela Message-ID: <20231018115513.2163-2-quint...@redhat.com> --- tests/qemu-iotests/183 | 2 +- tests/qemu-iotests/common.filter | 7 +++ 2 files chan

[PULL 34/39] migration: Use vmstate_register_any() for vmware_vga

2023-10-24 Thread Juan Quintela
I have no idea if we can have more than one vmware_vga device, so play it safe. Reviewed-by: Stefan Berger Reviewed-by: Thomas Huth Signed-off-by: Juan Quintela Message-ID: <20231020090731.28701-14-quint...@redhat.com> --- hw/display/vmware_vga.c | 2 +- 1 file changed, 1 insertion

[PULL 31/39] migration: Improve example and documentation of vmstate_register()

2023-10-24 Thread Juan Quintela
Reviewed-by: Stefan Berger Signed-off-by: Juan Quintela Message-ID: <20231020090731.28701-11-quint...@redhat.com> --- docs/devel/migration.rst | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/docs/devel/migration.rst b/docs/devel/migration.rst index be91

[PULL 30/39] migration: Check in savevm_state_handler_insert for dups

2023-10-24 Thread Juan Quintela
ned-off-by: Peter Xu Reviewed-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Juan Quintela Message-ID: <20231020090731.28701-10-quint...@redhat.com> --- migration/savevm.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/migration/savevm.c b/migratio

[PULL 29/39] migration: Hack to maintain backwards compatibility for ppc

2023-10-24 Thread Juan Quintela
e_hack_for_ppc() with warnings left and right that it is a hack. CC: Cedric Le Goater CC: Daniel Henrique Barboza CC: David Gibson CC: Greg Kurz Reviewed-by: Nicholas Piggin Signed-off-by: Juan Quintela Message-ID: <20231020090731.28701-8-quint...@redhat.com> --- include/migration/v

[PULL 28/39] migration: Use VMSTATE_INSTANCE_ID_ANY for slirp

2023-10-24 Thread Juan Quintela
/qtest/libqtest.c:195: kill_qemu() tried to terminate QEMU process but encountered exit status 1 (expected 0) Aborted (core dumped) Reviewed-by: Stefan Berger Signed-off-by: Juan Quintela Message-ID: <20231020090731.28701-6-quint...@redhat.com> --- net/slirp.c | 5 +++-- 1 file chan

[PULL 27/39] migration: Use vmstate_register_any() for isa-ide

2023-10-24 Thread Juan Quintela
exit status 1 (expected 0) Aborted (core dumped) $ Reviewed-by: Stefan Berger Signed-off-by: Juan Quintela Message-ID: <20231020090731.28701-4-quint...@redhat.com> --- hw/ide/isa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ide/isa.c b/hw/ide/isa.c index 9505

[PULL 26/39] migration: Use vmstate_register_any()

2023-10-24 Thread Juan Quintela
This are the easiest cases, where we were already using VMSTATE_INSTANCE_ID_ANY. Reviewed-by: Stefan Berger Signed-off-by: Juan Quintela Message-ID: <20231020090731.28701-3-quint...@redhat.com> --- backends/dbus-vmstate.c | 3 +-- backends/tpm/tpm_emulator.c | 3 +-- hw/i2c/

[PULL 25/39] migration: Create vmstate_register_any()

2023-10-24 Thread Juan Quintela
-by: Stefan Berger Signed-off-by: Juan Quintela Message-ID: <20231020090731.28701-2-quint...@redhat.com> --- include/migration/vmstate.h | 17 + 1 file changed, 17 insertions(+) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 1af181877c..1ea9

[PULL 24/39] migration: set file error on subsection loading

2023-10-24 Thread Juan Quintela
From: Marc-André Lureau commit 13cde50889237 ("vmstate: Return error in case of error") sets QemuFile error to stop reading from it and report to the caller (checked by unit tests). We should do the same on subsection loading error. Signed-off-by: Marc-André Lureau Reviewed-by: Jua

[PULL 23/39] migration: rename vmstate_save_needed->vmstate_section_needed

2023-10-24 Thread Juan Quintela
From: Marc-André Lureau The function is used on save at this point. The following commits will use it on load. Signed-off-by: Marc-André Lureau Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID: <20231024084043.2926316-5-marcandre.lur...@redhat.com> --- include/mig

[PULL 22/39] migration/ram: Fix compilation with -Wshadow=local

2023-10-24 Thread Juan Quintela
From: Thomas Huth Rename the variable here to avoid that it shadows a variable from the beginning of the function scope. With this change the code now successfully compiles with -Wshadow=local. Signed-off-by: Thomas Huth Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID

[PULL 21/39] hw/s390x/s390-stattrib: Don't call register_savevm_live() during instance_init()

2023-10-24 Thread Juan Quintela
From: Thomas Huth We must not call register_savevm_live() from an instance_init() function (since this could be called multiple times during device introspection). Move this to the realize() function instead. Acked-by: David Hildenbrand Reviewed-by: Eric Farman Signed-off-by: Juan Quintela

[PULL 20/39] hw/s390x/s390-stattrib: Simplify handling of the "migration-enabled" property

2023-10-24 Thread Juan Quintela
From: Thomas Huth There's no need for dedicated handlers here if they don't do anything special. Acked-by: David Hildenbrand Reviewed-by: Eric Farman Acked-by: Juan Quintela Signed-off-by: Thomas Huth Signed-off-by: Juan Quintela Message-ID: <20231020150554.664422-3-th.

[PULL 18/39] hw/ipmi: Don't call vmstate_register() from instance_init() functions

2023-10-24 Thread Juan Quintela
From: Thomas Huth instance_init() can be called multiple times, e.g. during introspection of the device. We should not install the vmstate handlers here. Do it in the realize() function instead. Signed-off-by: Thomas Huth Reviewed-by: Juan Quintela Acked-by: Corey Minyard Signed-off-by: Juan

[PULL 19/39] hw/s390x/s390-skeys: Don't call register_savevm_live() during instance_init()

2023-10-24 Thread Juan Quintela
e way quite a bit. Acked-by: David Hildenbrand Reviewed-by: Eric Farman Acked-by: Juan Quintela Signed-off-by: Thomas Huth Signed-off-by: Juan Quintela Message-ID: <20231020150554.664422-2-th...@redhat.com> --- hw/s390x/s390-skeys.c | 35 --- 1 fi

[PULL 17/39] migration: Rename ram_compressed_pages() to compress_ram_pages()

2023-10-24 Thread Juan Quintela
We are moving to have all functions exported from ram-compress.c to start with compress_. Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231019110724.15324-12-quint...@redhat.com> --- migration/ram-compress.h | 2 +- migration/ram-compress.c | 2 +- migration

[PULL 14/39] migration: Export send_queued_data()

2023-10-24 Thread Juan Quintela
This function is only used for compression. So we rename it as compress_send_queued_data(). We put it on ram-compress.h because we are moving it later to ram-compress.c. Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231019110724.15324-9-quint...@redhat.

[PULL 16/39] migration: Merge flush_compressed_data() and compress_flush_data()

2023-10-24 Thread Juan Quintela
Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231019110724.15324-11-quint...@redhat.com> --- migration/ram-compress.h | 1 - migration/ram-compress.c | 17 ++--- 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/migration/ram-compre

[PULL 12/39] migration: Move busy++ to migrate_with_multithread

2023-10-24 Thread Juan Quintela
And now we can simplify save_compress_page(). Reviewed-by: Lukas Straub Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231019110724.15324-7-quint...@redhat.com> --- migration/ram-compress.c | 1 + migration/ram.c | 8 ++-- 2 files changed, 3 inse

[PULL 15/39] migration: Move ram_flush_compressed_data() to ram-compress.c

2023-10-24 Thread Juan Quintela
As we export it, rename it compress_flush_data(). Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231019110724.15324-10-quint...@redhat.com> --- migration/ram-compress.h | 1 + migration/ram-compress.c | 9 + migration/ram.c | 17 --

[PULL 13/39] migration: Create compress_update_rates()

2023-10-24 Thread Juan Quintela
So we can move more compression_counters stuff to ram-compress.c. Create compression_counters struct to add the stuff that was on MigrationState. Reviewed-by: Lukas Straub Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231019110724.15324-8-quint...@redhat.

[PULL 11/39] migration: Simplify compress_page_with_multithread()

2023-10-24 Thread Juan Quintela
Move the goto to a while true. Reviewed-by: Lukas Straub Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231019110724.15324-6-quint...@redhat.com> --- migration/ram-compress.c | 48 1 file changed, 24 insertions(+), 24 del

[PULL 10/39] migration: Make compress_data_with_multithreads return bool

2023-10-24 Thread Juan Quintela
Reviewed-by: Lukas Straub Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231019110724.15324-5-quint...@redhat.com> --- migration/ram-compress.h | 4 ++-- migration/ram-compress.c | 17 ++--- migration/ram.c | 3 +-- 3 files changed, 13 inse

[PULL 09/39] migration: Remove save_page_use_compression()

2023-10-24 Thread Juan Quintela
After previous patch, we disable the posiblity that we use compression together with xbzrle. So we can use directly migrate_compress(). Once there, now we don't need the rs parameter, so remove it. Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231019110724

[PULL 08/39] migration: Give one error if trying to set COMPRESSION and XBZRLE

2023-10-24 Thread Juan Quintela
Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231019110724.15324-3-quint...@redhat.com> --- migration/options.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/migration/options.c b/migration/options.c index b8c3c3218d..37fa1cfe74 100644 --- a/mig

[PULL 07/39] migration: Give one error if trying to set MULTIFD and XBZRLE

2023-10-24 Thread Juan Quintela
Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231019110724.15324-2-quint...@redhat.com> --- migration/options.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/migration/options.c b/migration/options.c index 42fb818956..b8c3c3218d 100644 --- a/mig

[PULL 06/39] migration: Rename ram_handle_compressed() to ram_handle_zero()

2023-10-24 Thread Juan Quintela
Now that we know it only handles zero, we can remove the ch parameter. Reviewed-by: Fabiano Rosas Reviewed-by: Peter Xu Signed-off-by: Juan Quintela Message-ID: <20231019085259.13307-3-quint...@redhat.com> --- migration/ram.h | 2 +- migration/ram.c | 10 +- migration/rdma.

[PULL 05/39] migration: Receiving a zero page non zero is an error

2023-10-24 Thread Juan Quintela
e: commit a1febc4950f2c6232c002f401d7cd409f6fa6a88 Author: Richard Henderson Date: Mon Aug 29 11:46:14 2016 -0700 cutils: Export only buffer_is_zero Reviewed-by: Fabiano Rosas Reviewed-by: Peter Xu Signed-off-by: Juan Quintela Message-ID: <20231019085259.13307-2-quint...@redhat.com> ---

[PULL 04/39] migration/doc: We broke backwards compatibility

2023-10-24 Thread Juan Quintela
it does a hard reboot. Acked-by: Peter Xu Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231018112827.1325-5-quint...@redhat.com> --- docs/devel/migration.rst | 202 +++ 1 file changed, 202 insertions(+) diff --git a/docs/devel

[PULL 03/39] migration/doc: How to migrate when hosts have different features

2023-10-24 Thread Juan Quintela
Sometimes devices have different features depending of things outside of qemu. For instance the kernel. Document how to handle that cases. Acked-by: Peter Xu Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231018112827.1325-4-quint...@redhat.com> --- docs

[PULL 02/39] migration/doc: Add documentation for backwards compatiblity

2023-10-24 Thread Juan Quintela
State what are the requeriments to get migration working between qemu versions. And once there explain how one is supposed to implement a new feature/default value and not break migration. Reviewed-by: Vladimir Sementsov-Ogievskiy Acked-by: Peter Xu Signed-off-by: Juan Quintela Message-ID

[PULL 00/39] Migration 20231024 patches

2023-10-24 Thread Juan Quintela
- vmstate registration fixes (thomas, juan) - start merging vmstate_section_needed changes (marc) - migration depreactions (juan) - migration documentation for backwards compatibility (juan) Please apply. ---- Juan Quintela (31): migratio

[PULL 01/39] migration/doc: Add contents

2023-10-24 Thread Juan Quintela
Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231018112827.1325-2-quint...@redhat.com> --- docs/devel/migration.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/devel/migration.rst b/docs/devel/migration.rst index c3e1400c0c..4d6a98ae58 100644 ---

Re: [PATCH v8 1/5] qemu-iotests: Filter warnings about block migration being deprecated

2023-10-24 Thread Juan Quintela
Hanna Czenczek wrote: > On 18.10.23 13:55, Juan Quintela wrote: >> Create a new filter that removes the two warnings for test 183. >> >> Signed-off-by: Juan Quintela >> --- >> tests/qemu-iotests/183 | 2 +- >> tests/qemu-iotests/common.fil

[PATCH v8 4/5] migration: Deprecate block migration

2023-10-18 Thread Juan Quintela
It is obsolete. It is better to use driver-mirror with NBD instead. CC: Kevin Wolf CC: Eric Blake CC: Stefan Hajnoczi CC: Hanna Czenczek Acked-by: Stefan Hajnoczi Reviewed-by: Markus Armbruster Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 10 ++ qapi

[PATCH v8 5/5] migration: Deprecate old compression method

2023-10-18 Thread Juan Quintela
Acked-by: Stefan Hajnoczi Acked-by: Peter Xu Reviewed-by: Markus Armbruster Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 8 + qapi/migration.json | 63 ++- migration/options.c | 13 3 files changed, 64 insertions

[PATCH v8 3/5] migration: migrate 'blk' command option is deprecated.

2023-10-18 Thread Juan Quintela
Use blocked-mirror with NBD instead. Acked-by: Stefan Hajnoczi Reviewed-by: Thomas Huth Reviewed-by: Markus Armbruster Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 9 + qapi/migration.json| 7 --- migration/migration-hmp-cmds.c | 5

[PATCH v8 0/5] Migration deprecated parts

2023-10-18 Thread Juan Quintela
plifacation if we remove it is not so big. So we can leave it until 9.0 or whatever we think fit. What do you think? Later, Juan. Juan Quintela (5): qemu-iotests: Filter warnings about block migration being deprecated migration: migrate 'inc' command option is deprecated

[PATCH v8 1/5] qemu-iotests: Filter warnings about block migration being deprecated

2023-10-18 Thread Juan Quintela
Create a new filter that removes the two warnings for test 183. Signed-off-by: Juan Quintela --- tests/qemu-iotests/183 | 2 +- tests/qemu-iotests/common.filter | 7 +++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/183 b/tests/qemu-iotests/183

[PATCH v8 2/5] migration: migrate 'inc' command option is deprecated.

2023-10-18 Thread Juan Quintela
Use blockdev-mirror with NBD instead. Reviewed-by: Thomas Huth Acked-by: Stefan Hajnoczi Reviewed-by: Markus Armbruster Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 8 qapi/migration.json| 8 +++- migration/migration-hmp-cmds.c | 5

Re: [PATCH v7 0/4] Migration deprecated parts

2023-10-18 Thread Juan Quintela
Daniel P. Berrangé wrote: > On Wed, Oct 18, 2023 at 12:38:10PM +0200, Juan Quintela wrote: >> Juan Quintela wrote: >> > Based on: Message-ID: <20231018100651.32674-1-quint...@redhat.com> >> > [PULL 00/11] Migration 20231018 patches >> > >

[PATCH v7 3/4] migration: Deprecate block migration

2023-10-18 Thread Juan Quintela
It is obsolete. It is better to use driver-mirror with NBD instead. CC: Kevin Wolf CC: Eric Blake CC: Stefan Hajnoczi CC: Hanna Czenczek Acked-by: Stefan Hajnoczi Reviewed-by: Markus Armbruster Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 10 ++ qapi

[PATCH v7 2/4] migration: migrate 'blk' command option is deprecated.

2023-10-18 Thread Juan Quintela
Use blocked-mirror with NBD instead. Acked-by: Stefan Hajnoczi Reviewed-by: Thomas Huth Reviewed-by: Markus Armbruster Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 9 + qapi/migration.json| 7 --- migration/migration-hmp-cmds.c | 5

[PATCH v7 1/4] migration: migrate 'inc' command option is deprecated.

2023-10-18 Thread Juan Quintela
Use blockdev-mirror with NBD instead. Reviewed-by: Thomas Huth Acked-by: Stefan Hajnoczi Reviewed-by: Markus Armbruster Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 8 qapi/migration.json| 8 +++- migration/migration-hmp-cmds.c | 5

Re: [PATCH v7 0/4] Migration deprecated parts

2023-10-18 Thread Juan Quintela
Juan Quintela wrote: > Based on: Message-ID: <20231018100651.32674-1-quint...@redhat.com> > [PULL 00/11] Migration 20231018 patches > > And here we are, at v7: > - drop black line at the end of deprecated.rst > - change qemu-iotest output due to warnings for d

[PATCH v7 0/4] Migration deprecated parts

2023-10-18 Thread Juan Quintela
part is not urget, because management apps have a working option that are already using "defer", and the code simplifacation if we remove it is not so big. So we can leave it until 9.0 or whatever we think fit. What do you think? Later, Juan. Juan Quintela (4): migration: migrat

Re: [PATCH v6 2/5] migration: migrate 'inc' command option is deprecated.

2023-10-18 Thread Juan Quintela
Markus Armbruster wrote: > Juan Quintela writes: > >> Use blockdev-mirror with NBD instead. >> >> Reviewed-by: Thomas Huth >> Acked-by: Stefan Hajnoczi >> Reviewed-by: Markus Armbruster >> Signed-off-by: Juan Quintela >> --- >>

[PATCH v7 4/4] migration: Deprecate old compression method

2023-10-18 Thread Juan Quintela
Acked-by: Stefan Hajnoczi Acked-by: Peter Xu Reviewed-by: Markus Armbruster Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 8 + qapi/migration.json | 63 ++- migration/options.c | 13 3 files changed, 64 insertions

Re: [PATCH v6 3/5] migration: migrate 'blk' command option is deprecated.

2023-10-17 Thread Juan Quintela
Juan Quintela wrote: > Use blocked-mirror with NBD instead. > > Signed-off-by: Juan Quintela > Acked-by: Stefan Hajnoczi > Reviewed-by: Thomas Huth > Reviewed-by: Markus Armbruster Hi Kevin and Stefan Can we change the iotest output to fix this? https://gitlab.com/juan.qu

[PATCH v6 4/5] migration: Deprecate block migration

2023-10-17 Thread Juan Quintela
It is obsolete. It is better to use driver-mirror with NBD instead. CC: Kevin Wolf CC: Eric Blake CC: Stefan Hajnoczi CC: Hanna Czenczek Signed-off-by: Juan Quintela Acked-by: Stefan Hajnoczi Reviewed-by: Markus Armbruster --- docs/about/deprecated.rst | 10 ++ qapi

[PATCH v6 5/5] migration: Deprecate old compression method

2023-10-17 Thread Juan Quintela
Signed-off-by: Juan Quintela Acked-by: Stefan Hajnoczi Acked-by: Peter Xu Reviewed-by: Markus Armbruster --- docs/about/deprecated.rst | 8 + qapi/migration.json | 63 ++- migration/options.c | 13 3 files changed, 64 insertions

[PATCH v6 2/5] migration: migrate 'inc' command option is deprecated.

2023-10-17 Thread Juan Quintela
Use blockdev-mirror with NBD instead. Reviewed-by: Thomas Huth Acked-by: Stefan Hajnoczi Reviewed-by: Markus Armbruster Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 9 + qapi/migration.json| 8 +++- migration/migration-hmp-cmds.c | 5

[PATCH v6 1/5] migration: Print block status when needed

2023-10-17 Thread Juan Quintela
The new line was only printed when command options were used. When we used migration parameters and capabilities, it wasn't. Signed-off-by: Juan Quintela Reviewed-by: Fabiano Rosas --- migration/migration-hmp-cmds.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --

[PATCH v6 3/5] migration: migrate 'blk' command option is deprecated.

2023-10-17 Thread Juan Quintela
Use blocked-mirror with NBD instead. Signed-off-by: Juan Quintela Acked-by: Stefan Hajnoczi Reviewed-by: Thomas Huth Reviewed-by: Markus Armbruster --- docs/about/deprecated.rst | 9 + qapi/migration.json| 7 --- migration/migration-hmp-cmds.c | 5

[PATCH v6 0/5] Migration deprecated parts

2023-10-17 Thread Juan Quintela
ps have a working option that are already using "defer", and the code simplifacation if we remove it is not so big. So we can leave it until 9.0 or whatever we think fit. What do you think? Later, Juan. Juan Quintela (5): migration: Print block status when needed migrat

Re: [PATCH v5 5/7] migration: Deprecate old compression method

2023-10-17 Thread Juan Quintela
Markus Armbruster wrote: > Juan Quintela writes: > >> Signed-off-by: Juan Quintela >> Acked-by: Stefan Hajnoczi >> Acked-by: Peter Xu >> # @deprecated: Member @disk is deprecated because block migration is. >> +# Member @compression is dep

Re: [PATCH v5 4/7] migration: Deprecate block migration

2023-10-17 Thread Juan Quintela
Markus Armbruster wrote: > Juan Quintela writes: > >> # >> +# @deprecated: Member @block-incremental is deprecated. Use > > Two spaces between sentences for consistency, please. Done. At least here I did the copy and paste right. >> diff --git a/migration/block.

Re: [PATCH v5 3/7] migration: migrate 'blk' command option is deprecated.

2023-10-17 Thread Juan Quintela
Markus Armbruster wrote: > Juan Quintela writes: > >> Use blocked-mirror with NBD instead. >> >> Signed-off-by: Juan Quintela >> Acked-by: Stefan Hajnoczi >> Reviewed-by: Thomas Huth >> >> --- >> >> Improve documentation and s

Re: [PATCH v5 2/7] migration: migrate 'inc' command option is deprecated.

2023-10-17 Thread Juan Quintela
Markus Armbruster wrote: > Juan Quintela writes: > >> Use blockdev-mirror with NBD instead. >> >> Reviewed-by: Thomas Huth >> Acked-by: Stefan Hajnoczi >> Signed-off-by: Juan Quintela >> >> --- >> >> Improve documentation and style (

[PATCH v5 0/7] Migration deprecated parts

2023-10-17 Thread Juan Quintela
f we remove it is not so big. So we can leave it until 9.0 or whatever we think fit. What do you think? Later, Juan. Juan Quintela (7): migration: Print block status when needed migration: migrate 'inc' command option is deprecated. migration: migrate 'blk' co

[PATCH v5 6/7] [RFC] migration: Make -i/-b an error for hmp and qmp

2023-10-17 Thread Juan Quintela
[DON'T MERGE] Block migration is obsolete, users should use blockdev-mirror instead. Make it one error to set them. Signed-off-by: Juan Quintela --- migration/migration-hmp-cmds.c | 13 +++-- migration/migration.c | 33 ++--- 2 files change

[PATCH v5 2/7] migration: migrate 'inc' command option is deprecated.

2023-10-17 Thread Juan Quintela
Use blockdev-mirror with NBD instead. Reviewed-by: Thomas Huth Acked-by: Stefan Hajnoczi Signed-off-by: Juan Quintela --- Improve documentation and style (thanks Markus) --- docs/about/deprecated.rst | 8 qapi/migration.json| 8 +++- migration/migration-hmp

[PATCH v5 4/7] migration: Deprecate block migration

2023-10-17 Thread Juan Quintela
It is obsolete. It is better to use driver-mirror with NBD instead. CC: Kevin Wolf CC: Eric Blake CC: Stefan Hajnoczi CC: Hanna Czenczek Signed-off-by: Juan Quintela Acked-by: Stefan Hajnoczi --- docs/about/deprecated.rst | 10 ++ qapi/migration.json | 29

[PATCH v5 7/7] [RFC] migration: Remove helpers needed for -i/-b migrate options

2023-10-17 Thread Juan Quintela
[DON'T MERGE] We were abusing capabilities and parameters to implement -i/-b. Previous patch convert that options into one error. Remove all the helpers needed to implement them. Signed-off-by: Juan Quintela --- migration/migration.h | 4 migration/options.h | 6 -- migr

[PATCH v5 5/7] migration: Deprecate old compression method

2023-10-17 Thread Juan Quintela
Signed-off-by: Juan Quintela Acked-by: Stefan Hajnoczi Acked-by: Peter Xu --- docs/about/deprecated.rst | 8 qapi/migration.json | 79 +-- migration/options.c | 13 +++ 3 files changed, 72 insertions(+), 28 deletions(-) diff --git a

[PATCH v5 3/7] migration: migrate 'blk' command option is deprecated.

2023-10-17 Thread Juan Quintela
Use blocked-mirror with NBD instead. Signed-off-by: Juan Quintela Acked-by: Stefan Hajnoczi Reviewed-by: Thomas Huth --- Improve documentation and style (markus) --- docs/about/deprecated.rst | 10 ++ qapi/migration.json| 6 -- migration/migration-hmp-cmds.c

[PATCH v5 1/7] migration: Print block status when needed

2023-10-17 Thread Juan Quintela
The new line was only printed when command options were used. When we used migration parameters and capabilities, it wasn't. Signed-off-by: Juan Quintela --- migration/migration-hmp-cmds.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/migration/migration-hmp-cmd

Re: [PATCH v4 03/10] migration: migrate 'inc' command option is deprecated.

2023-10-16 Thread Juan Quintela
Markus Armbruster wrote: > Juan Quintela writes: > >> Markus Armbruster wrote: >>> Juan Quintela writes: >> So what I want, I want to remove -i/-b in the next version (9.0?). For >> the other, I want to remove it, but I don't care if the code is aroun

Re: [PATCH v4 03/10] migration: migrate 'inc' command option is deprecated.

2023-10-16 Thread Juan Quintela
Markus Armbruster wrote: > Juan Quintela writes: > >> Set the 'block_incremental' migration parameter to 'true' instead. >> >> Reviewed-by: Thomas Huth >> Acked-by: Stefan Hajnoczi >> Signed-off-by: Juan Quintela >> >> --- &

[PATCH v4 03/10] migration: migrate 'inc' command option is deprecated.

2023-10-13 Thread Juan Quintela
Set the 'block_incremental' migration parameter to 'true' instead. Reviewed-by: Thomas Huth Acked-by: Stefan Hajnoczi Signed-off-by: Juan Quintela --- Improve documentation and style (thanks Markus) --- docs/about/deprecated.rst | 7 +++ qapi/migration.json | 8

[PATCH v4 06/10] migration: Deprecate old compression method

2023-10-13 Thread Juan Quintela
Signed-off-by: Juan Quintela Acked-by: Stefan Hajnoczi Acked-by: Peter Xu --- docs/about/deprecated.rst | 8 qapi/migration.json | 79 +-- migration/options.c | 13 +++ 3 files changed, 72 insertions(+), 28 deletions(-) diff --git a

[PATCH v4 05/10] migration: Deprecate block migration

2023-10-13 Thread Juan Quintela
It is obsolete. It is better to use driver-mirror with NBD instead. CC: Kevin Wolf CC: Eric Blake CC: Stefan Hajnoczi CC: Hanna Czenczek Signed-off-by: Juan Quintela Acked-by: Stefan Hajnoczi --- docs/about/deprecated.rst | 10 ++ qapi/migration.json | 29

[PATCH v4 07/10] [RFC] migration: Make -i/-b an error for hmp and qmp

2023-10-13 Thread Juan Quintela
[DON'T MERGE] Block migration is obsolete, users should use blockdev-mirror instead. Make it one error to set them. Signed-off-by: Juan Quintela --- migration/migration-hmp-cmds.c | 15 ++- migration/migration.c | 35 +++--- 2 files change

[PATCH v4 08/10] [RFC] migration: Remove helpers needed for -i/-b migrate options

2023-10-13 Thread Juan Quintela
[DON'T MERGE] We were abusing capabilities and parameters to implement -i/-b. Previous patch convert that options into one error. Remove all the helpers needed to implement them. Signed-off-by: Juan Quintela --- migration/migration.h | 4 migration/options.h | 6 -- migr

[PATCH v4 10/10] [RFC] migration: Remove block migration support

2023-10-13 Thread Juan Quintela
[DON'T MERGE] Signed-off-by: Juan Quintela --- meson.build|2 - qapi/migration.json| 31 +- include/migration/misc.h |8 - migration/block.h | 52 -- migration/options.h|1 - migration/block.c |

[PATCH v4 09/10] [RFC] migration: Remove support for block_incremental

2023-10-13 Thread Juan Quintela
[DON'T MERGE] Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 7 - qapi/migration.json| 55 +++--- migration/options.h| 1 - migration/block.c | 2 +- migration/migration-hmp-cmds.c

[PATCH v4 04/10] migration: migrate 'blk' command option is deprecated.

2023-10-13 Thread Juan Quintela
Set the 'block' migration capability to 'true' instead. Signed-off-by: Juan Quintela Acked-by: Stefan Hajnoczi Reviewed-by: Thomas Huth --- Improve documentation and style (markus) --- docs/about/deprecated.rst | 7 +++ qapi/migration.json | 6 -- migration

[PATCH v4 02/10] migration: Print block status when needed

2023-10-13 Thread Juan Quintela
The new line was only printed when command options were used. When we used migration parameters and capabilities, it wasn't. Signed-off-by: Juan Quintela --- migration/migration-hmp-cmds.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/migration/migration-hmp-cmd

[PATCH v4 01/10] migration: Improve json and formatting

2023-10-13 Thread Juan Quintela
Signed-off-by: Juan Quintela --- qapi/migration.json | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/qapi/migration.json b/qapi/migration.json index d7dfaa5db9..6865fea3c5 100644 --- a/qapi/migration.json +++ b/qapi/migration.json @@ -73,7 +73,7 @@ { 's

[PATCH v4 00/10] Migration deprecated parts

2023-10-13 Thread Juan Quintela
s not so big. So we can leave it until 9.0 or whatever we think fit. What do you think? Later, Juan. Juan Quintela (10): migration: Improve json and formatting migration: Print block status when needed migration: migrate 'inc' command option is deprecated. migration: mi

Re: [PATCH v3 4/4] migration: Deprecate old compression method

2023-10-12 Thread Juan Quintela
Markus Armbruster wrote: > Juan Quintela writes: > >> -# @deprecated: @disk migration is deprecated. Use driver-mirror >> -# with NBD instead. >> +# @deprecated: @disk migration is deprecated. Use driver-mirror with >> +# NBD instead. @compression is

Re: [PATCH v3 3/4] migration: Deprecate block migration

2023-10-12 Thread Juan Quintela
Markus Armbruster wrote: > Juan Quintela writes: > >> It is obsolete. It is better to use driver-mirror with NBD instead. > > drive-mirror > > Several more below. Done. >> +# Features: >> +# >> +# @deprecated: @disk migration is deprecated. Us

Re: [PATCH v3 1/4] migration: migrate 'inc' command option is deprecated.

2023-10-12 Thread Juan Quintela
Markus Armbruster wrote: > Juan Quintela writes: > >> Set the 'block_incremental' migration parameter to 'true' instead. >> >> # @blk: do block migration (full disk copy) >> # >> -# @inc: incremental disk copy migration >> +# @in

[PATCH v3 2/4] migration: migrate 'blk' command option is deprecated.

2023-10-11 Thread Juan Quintela
Set the 'block' migration capability to 'true' instead. Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth --- docs/about/deprecated.rst | 7 +++ qapi/migration.json | 10 +++--- migration/migration.c | 5 + 3 files changed, 19 insertions(+),

[PATCH v3 4/4] migration: Deprecate old compression method

2023-10-11 Thread Juan Quintela
Signed-off-by: Juan Quintela Acked-by: Peter Xu --- docs/about/deprecated.rst | 8 +++ qapi/migration.json | 102 -- migration/options.c | 13 + 3 files changed, 86 insertions(+), 37 deletions(-) diff --git a/docs/about/deprecated.rst b

[PATCH v3 3/4] migration: Deprecate block migration

2023-10-11 Thread Juan Quintela
It is obsolete. It is better to use driver-mirror with NBD instead. CC: Kevin Wolf CC: Eric Blake CC: Stefan Hajnoczi CC: Hanna Czenczek Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 10 ++ qapi/migration.json | 30 +- migration

[PATCH v3 1/4] migration: migrate 'inc' command option is deprecated.

2023-10-11 Thread Juan Quintela
Set the 'block_incremental' migration parameter to 'true' instead. Reviewed-by: Thomas Huth Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 7 +++ qapi/migration.json | 12 ++-- migration/migration.c | 6 ++ 3 files changed,

Re: [PATCH] hw/rdma: Deprecate the pvrdma device and the rdma subsystem

2023-10-04 Thread Juan Quintela
g/qemu-devel/1054981c-e8ae-c676-3b04-eeb030e11...@tls.msk.ru/ > [4] > https://lore.kernel.org/qemu-devel/20230301142926.18686-1-yuval.shaia...@gmail.com/ > [5] https://lore.kernel.org/qemu-devel/8734z9f086@pond.sub.org/ > > Signed-off-by: Thomas Huth Acked-by: Juan Quintela

Re: [PATCH 00/26] Migration PULL 2023-07-24

2023-07-30 Thread Juan Quintela
Thomas Huth wrote: > On 24/07/2023 15.06, Juan Quintela wrote: >> Hi >> This is the migration PULL request. > > Maybe it would better to use "PULL" instead of "PATCH" in the subject? G. Resending. Thanks. >> Now a not on CI, thas has been re

[PULL 13/25] migration-test: Create arch_opts

2023-07-26 Thread Juan Quintela
This will contain the options needed for both source and target. Reviewed-by: Peter Xu Message-ID: <20230608224943.3877-6-quint...@redhat.com> Signed-off-by: Juan Quintela --- tests/qtest/migration-test.c | 30 +++--- 1 file changed, 15 insertions(+), 15 del

[PULL 00/25] Migration 20230726 patches

2023-07-26 Thread Juan Quintela
Implement dirty-limit convergence algo migration: Extend query-migrate to provide dirty page limit info Juan Quintela (11): migration-test: Be consistent for ppc migration-test: Make machine_opts regular with other options migration-test: Create arch_opts migration-test: machine_opts is r

[PULL 19/25] qtest/migration-tests.c: use "-incoming defer" for postcopy tests

2023-07-26 Thread Juan Quintela
expected usage. Signed-off-by: Wei Wang Reviewed-by: Peter Xu Reviewed-by: Juan Quintela Message-ID: <20230606101910.20456-3-wei.w.w...@intel.com> Signed-off-by: Juan Quintela --- tests/qtest/migration-test.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/t

  1   2   >