Em seg., 24 de out. de 2022 às 20:09, escreveu:
>
> From: Julio Faracco
My apologies folks. I simply configured a new machine today and I
forgot to remove some predefined settings I have.
If someone could suppress this section I would be glad. :-)
>
> The function nodedevRegist
Some people from Red Hat does not use 'redhat.com' domain emails.
They use personal or other domains.
Signed-off-by: Julio Faracco
---
docs/gitdm/companies/ibm| 1 -
docs/gitdm/companies/redhat | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/gitdm/companies/ibm b
.
Unless you have another opinion.
--
Julio Faracco
Em qui., 1 de abr. de 2021 às 07:33, Michal Privoznik
escreveu:
>
> On 4/1/21 12:01 AM, Martin Kletzander wrote:
> > On Sat, Feb 27, 2021 at 01:14:29AM -0300, Julio Faracco wrote:
> >> Hi guys,
> >>
> >
>
Cesar Faracco
Em sáb., 27 de fev. de 2021 às 01:06, Julio Faracco
escreveu:
>
> This patch series implements a way to do checkpoint/restore to LXC driver
> using
> CRIU operations. This respects the other methods to save and restore processes
> states: using a file with a h
This patch introduces the hability to restore a saved container using CRIU.
It should be possible to start it using traditional methods: a simple container
start; or from a saved state.
Signed-off-by: Julio Faracco
---
src/lxc/lxc_conf.c | 3 +
src/lxc/lxc_conf.h | 2 +
src/lxc
by CRIU. CRIU generates
a lots of 'img' files and it is compresses using TAR to fit into the libvirt
state file.
Julio Faracco (3):
meson: Add support to CRIU binary into meson
lxc: Including CRIU functions and functions to support C/R.
lxc: Adding support to LXC driver to restore a container
to
inserted in a unique file using a type of compression. Using TAR for
instance.
Signed-off-by: Julio Faracco
---
src/lxc/lxc_criu.c | 405
src/lxc/lxc_criu.h | 50 ++
src/lxc/meson.build | 2 +
3 files changed, 457 insertions(+)
create mode 100644
This patch includes CRIU binary checks into meson files to support
checkpoint/restore for LXC driver.
Signed-off-by: Julio Faracco
---
meson.build | 10 ++
meson_options.txt | 1 +
2 files changed, 11 insertions(+)
diff --git a/meson.build b/meson.build
index 369548f127
Function to compare CPU on 64-bits PowerPC is ignoring the flag to avoid failure
in case of CPUs (host and guest) are incompatible. Basically, the function is
returning -1 even if it is set to continue.
Signed-off-by: Julio Faracco
---
src/cpu/cpu_ppc64.c | 8
1 file changed, 4
Hi Jano,
Your suggestion makes more sense.
Let me send a V2 then.
Tks :-)
--
Julio Cesar Faracco
Em ter., 27 de out. de 2020 às 12:24, Ján Tomko escreveu:
>
> On a Tuesday in 2020, Julio Faracco wrote:
> >Function to compare CPU on 64-bit PowerPC is ignoring the flag to avoi
Function to compare CPU on 64-bit PowerPC is ignoring the flag to avoid
failure in case of CPUs (host and guest) are incompatible. Basically, the
function is returning -1 even if it is set to continue.
Signed-off-by: Julio Faracco
---
src/cpu/cpu_ppc64.c | 4 ++--
1 file changed, 2 insertions
There is no support to use TPM for passthrough for LXC libvirt driver
this commit adds the option to use host TPM inside containers.
Signed-off-by: Julio Faracco
---
src/lxc/lxc_cgroup.c | 27 +++
src/lxc/lxc_controller.c | 56
2
improvements also.
Signed-off-by: Julio Faracco
---
src/conf/network_conf.c | 38 ++---
src/network/bridge_driver.c | 8 ++--
2 files changed, 21 insertions(+), 25 deletions(-)
diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c
index cd60ee7548
This commit includes an entry for new network DHCP lease time
information inside news.xml.
Signed-off-by: Julio Faracco
---
docs/news.xml | 10 ++
1 file changed, 10 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 956018b512..9c36f3bd51 100644
--- a/docs/news.xml
+++ b
Em qui., 23 de abr. de 2020 às 11:10, Michal Privoznik
escreveu:
>
> On 4/23/20 3:19 PM, Julio Faracco wrote:
> > This commit includes an entry for new network DHCP lease time
> > information inside news.xml.
> >
> > Signed-off-by: Julio Faracco
&g
This commit includes an entry for new network DHCP lease time
information inside news.xml.
Signed-off-by: Julio Faracco
---
docs/news.xml | 12
1 file changed, 12 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 956018b512..3a013ffbbd 100644
--- a/docs/news.xml
+++ b
/22/20 10:05 PM, Julio Faracco wrote:
> > This series is based on latest series from Nehal. It includes a new
> > entry called under and from scope.
> > This was implemented to include independent lease time for each line and
> > dnsmasq option. So, users are able to de
. They can be defined under that settings:
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=913446
Signed-off-by: Julio Faracco
---
docs/schemas/basictypes.rng | 8 ++
docs/schemas/network.rng| 20 +
src/conf/network_conf.c
New tests are required to cover some new XML syntax entry for
option. This includes schema testing and other features
like unit attribute and lease value. This commit includes hostsfile
checks adding new files for each test case that is manipulating
tag.
Signed-off-by: Julio Faracco
includes some test cases to cover lease time XML syntax
also. Now, each test case requires a hostsfile to test this specific
setting.
- v1-v2: Change XML syntax according Daniel's suggestion.
- v2-v3: Fix memory leak and test dependency issue.
Julio Faracco (2):
conf: Add option for settings
Em qua., 22 de abr. de 2020 às 10:45, Daniel Henrique Barboza
escreveu:
>
>
>
> On 4/22/20 9:22 AM, Julio Faracco wrote:
> > Hi Daniel,
> >
> > Thanks for reviewing. :-)
>
>
> Np, glad to be of assistance
>
>
> > IMHO, I don't like to join them i
Barboza
escreveu:
>
>
>
> On 4/21/20 1:03 AM, Julio Faracco wrote:
> > If an user is trying to configure a dhcp neetwork settings, it is not
>
> s/neetwork/network
>
>
>
> This patch failed to compile in my box on top of master at 9a13704818e:
>
>
&g
New tests are required to cover some new XML syntax entry for
option. This includes schema testing and other features
like unit attribute and lease value. This commit includes hostsfile
checks adding new files for each test case that is manipulating
tag.
Signed-off-by: Julio Faracco
. They can be defined under that settings:
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=913446
Signed-off-by: Julio Faracco
---
docs/schemas/basictypes.rng | 8 ++
docs/schemas/network.rng| 20 +
src/conf/network_conf.c
includes some test cases to cover lease time XML syntax
also. Now, each test case requires a hostsfile to test this specific
setting.
Julio Faracco (2):
conf: Add option for settings
tests: Add tests for to cover dnsmasq settings
docs/schemas/basictypes.rng | 8 +
docs
2020 às 13:19, Julio Faracco
escreveu:
>
> This series is based on latest series from Alberto. It includes a new
> entry called under scope to add a default lease
> time for range and host options for dnsmasq. There is no point to
> configure both separately. If they are defined (ra
New tests are required to cover some new XML syntax entry for
option. This includes schema testing and other features
like unit attribute and leasetime value.
Signed-off-by: Julio Faracco
---
tests/networkxml2confdata/leasetime-hours.conf | 16
tests/networkxml2confdata
. If this XML entry is defined, it applies leasetime
for each range or host defined under DHCP scope.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=913446
Signed-off-by: Julio Faracco
---
docs/schemas/basictypes.rng | 9 ++
docs/schemas/network.rng| 11 +++
src/conf/network_conf.c
.
This series includes some test cases to cover lease time XML syntax
also.
Julio Faracco (2):
conf: Add option for settings
tests: Add tests for to cover dnsmasq settings
docs/schemas/basictypes.rng | 9 +++
docs/schemas/network.rng | 11
src
I'm good with that.
I verified other resources that use rtc... they are checking for rtc0.
Thanks, Michal
--
Julio Cesar Faracco
Em ter., 17 de mar. de 2020 às 12:32, Michal Prívozník
escreveu:
>
> On 17. 3. 2020 14:41, Julio Faracco wrote:
> > Hi Michal,
> >
> > /de
Hi Michal,
/dev/rtc symlink is created by udev default rules.
Maybe we can check for both: /dev/rtc and /dev/rtc0.
--
Julio Cesar Faracco
Em seg., 16 de mar. de 2020 às 15:16, Michal Prívozník
escreveu:
>
> On 2. 3. 2020 1:54, Julio Faracco wrote:
> > This commit share host Rea
This series add support for two timers in LXC containers. It enables
sharing some timer devices between host and LXC guest using `timer`
settings in XML definition. This series add RTC and HPET timers.
Julio Faracco (2):
lxc: Add Real Time Clock device into allowed devices
lxc: Add HPET
any known method.
Now:
root# hwclock
2020-02-16 18:23:55.374134+00:00
root# hwclock -w
hwclock: ioctl(RTC_SET_TIME) to /dev/rtc to set the time failed:
Permission denied
Signed-off-by: Julio Faracco
---
docs/formatdomain.html.in | 2 +-
src/lxc/lxc_cgroup.c | 33
This commit is related to RTC timer device too. HPET is being shared
from host device through `localtime` clock. This timer is available
creating a new timer using `hpet` name.
Signed-off-by: Julio Faracco
---
docs/formatdomain.html.in | 2 +-
src/lxc/lxc_cgroup.c | 11 ++-
src
There are a lots of strings being handled inside some LXC functions.
They can be moved to g_autofree to avoid declaring a return value to get
proper code cleanups. This commit is changing functions from
lxc_{controller,cgroup,fuse} only.
Signed-off-by: Julio Faracco
---
src/lxc/lxc_cgroup.c
Native config files sometimes can setup cpuset.cpus to pin some CPUs.
Before this, LXC was using a fixed number of 1 VCPU. After this commit,
XML definition will generate a dynamic number of VCPUs based on that
cgroup attribute.
Signed-off-by: Julio Faracco
---
src/lxc/lxc_container.c
This commit is related to RTC timer device too. HPET is being shared
from host device through `localtime` clock. This timer is available
creating a new timer using `hpet` name.
Signed-off-by: Julio Faracco
---
docs/formatdomain.html.in | 2 +-
src/lxc/lxc_cgroup.c | 17
CPU 0 and 1 have 100% usage.
Signed-off-by: Julio Faracco
---
src/lxc/lxc_cgroup.c| 31 ++
src/lxc/lxc_container.c | 39 ++---
src/lxc/lxc_fuse.c | 95 ++---
3 files changed, 145 insertions(+), 20 deletions(-)
diff --git a/src
any known method.
Now:
root# hwclock
2020-02-16 18:23:55.374134+00:00
root# hwclock -w
hwclock: ioctl(RTC_SET_TIME) to /dev/rtc to set the time failed:
Permission denied
Signed-off-by: Julio Faracco
---
docs/formatdomain.html.in | 2 +-
src/lxc/lxc_cgroup.c | 36
patch has the description of the problem and what
it is trying to fix.
v1-v2: Add Daniel's comments and some cleanups.
v2-v3: Remove dependency from patch 4 and 5.
v3-v4: Missing cpuinfo file from Fuse Getattr handler.
Julio Faracco (5):
lxc: Add Real Time Clock device into allowed devices
lxc
Native config files sometimes can setup cpuset.cpus to pin some CPUs.
Before this, LXC was using a fixed number of 1 VCPU. After this commit,
XML definition will generate a dynamic number of VCPUs based on that
cgroup attribute.
Signed-off-by: Julio Faracco
---
src/lxc/lxc_container.c
CPU 0 and 1 have 100% usage.
Signed-off-by: Julio Faracco
---
src/lxc/lxc_cgroup.c| 31 +++
src/lxc/lxc_container.c | 39 +++---
src/lxc/lxc_fuse.c | 88 +++--
3 files changed, 139 insertions(+), 19 deletions(-)
diff --git a/src
patch has the description of the problem and what
it is trying to fix.
v1-v2: Add Daniel's comments and some cleanups.
v2-v3: Remove dependency from patch 4 and 5.
Julio Faracco (5):
lxc: Add Real Time Clock device into allowed devices
lxc: Add HPET device into allowed devices
lxc: Replacing
There are a lots of strings being handled inside some LXC functions.
They can be moved to g_autofree to avoid declaring a return value to get
proper code cleanups. This commit is changing functions from
lxc_{controller,cgroup,fuse} only.
Signed-off-by: Julio Faracco
---
src/lxc/lxc_cgroup.c
This commit is related to RTC timer device too. HPET is being shared
from host device through `localtime` clock. This timer is available
creating a new timer using `hpet` name.
Signed-off-by: Julio Faracco
---
docs/formatdomain.html.in | 2 +-
src/lxc/lxc_cgroup.c | 17
any known method.
Now:
root# hwclock
2020-02-16 18:23:55.374134+00:00
root# hwclock -w
hwclock: ioctl(RTC_SET_TIME) to /dev/rtc to set the time failed:
Permission denied
Signed-off-by: Julio Faracco
---
docs/formatdomain.html.in | 2 +-
src/lxc/lxc_cgroup.c | 36
CPU 0 and 1 have 100% usage.
Signed-off-by: Julio Faracco
---
src/lxc/lxc_cgroup.c| 31 +++
src/lxc/lxc_container.c | 37 +++---
src/lxc/lxc_fuse.c | 86 +++--
3 files changed, 137 insertions(+), 17 deletions(-)
diff --git a/src
Native config files sometimes can setup cpuset.cpus to pin some CPUs.
Before this, LXC was using a fixed number of 1 VCPU. After this commit,
XML definition will generate a dynamic number of VCPUs based on that
cgroup attribute.
Signed-off-by: Julio Faracco
---
src/lxc/lxc_container.c
any known method.
Now:
root# hwclock
2020-02-16 18:23:55.374134+00:00
root# hwclock -w
hwclock: ioctl(RTC_SET_TIME) to /dev/rtc to set the time failed:
Permission denied
Signed-off-by: Julio Faracco
---
docs/formatdomain.html.in | 2 +-
src/lxc/lxc_cgroup.c | 36
patch has the description of the problem and what
it is trying to fix.
v1-v2: Add Daniel's comments and some cleanups.
Julio Faracco (5):
lxc: Add Real Time Clock device into allowed devices
lxc: Add HPET device into allowed devices
lxc: Replacing default strings definitions by g_autofree
There are a lots of strings being handled inside some LXC functions.
They can be moved to g_autofree to avoid declaring a return value to get
proper code cleanups. This commit is changing functions from
lxc_{controller,cgroup,fuse} only.
Signed-off-by: Julio Faracco
---
src/lxc/lxc_cgroup.c
This commit is related to RTC timer device too. HPET is being shared
from host device through `localtime` clock. This timer is available
creating a new timer using `hpet` name.
Signed-off-by: Julio Faracco
---
docs/formatdomain.html.in | 2 +-
src/lxc/lxc_cgroup.c | 17
Hi Jano!
Em qui., 20 de fev. de 2020 às 12:57, Ján Tomko escreveu:
>
> On Wed, Feb 19, 2020 at 05:51:44PM -0300, Julio Faracco wrote:
> >This commit add more features to storages that supports setuid, setgid
> >and sticky bit. This extend some permission levels of volum
Em qua., 19 de fev. de 2020 às 09:27, Daniel Henrique Barboza
escreveu:
>
>
>
> On 2/16/20 2:11 PM, Julio Faracco wrote:
> > This commit tries to fix a lots of issues related to LXC VCPUs. One of
>
> Extra 'a' there. "tries to fix lots of issues ..."
>
&
-by: Julio Faracco
---
src/conf/storage_conf.c| 11 ---
src/storage/storage_util.c | 12
2 files changed, 16 insertions(+), 7 deletions(-)
diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
index 252d28cbfb..54e4a60ded 100644
--- a/src/conf/storage_conf.c
+++ b
Native config files sometimes can setup cpuset.cpus to pin som CPUs.
Before this, LXC was using a fixed number of 1 VCPU. After this commit,
XML definition will generate a dynamic number of VCPUs based on that
cgroup attribute.
Signed-off-by: Julio Faracco
---
src/lxc/lxc_container.c
patch has the description of the problem and what
it is trying to fix.
Julio Faracco (4):
lxc: Add Real Time Clock device into allowed devices
lxc: Add HPET device into allowed devices
lxc: Implement virtual /proc/cpuinfo via LXC fuse
lxc: Count max VCPUs based on cpuset.cpus in native config
This commit is related to RTC timer device too. HPET is being shared
from host device through `localtime` clock. This timer is available
creating a new timer using `hpet` name.
Signed-off-by: Julio Faracco
---
docs/formatdomain.html.in | 2 +-
src/lxc/lxc_cgroup.c | 17
any known method.
Now:
root# hwclock
2020-02-16 18:23:55.374134+00:00
root# hwclock -w
hwclock: ioctl(RTC_SET_TIME) to /dev/rtc to set the time failed:
Permission denied
Signed-off-by: Julio Faracco
---
docs/formatdomain.html.in | 2 +-
src/lxc/lxc_cgroup.c | 36
and 1 have 100% usage.
Signed-off-by: Julio Faracco
---
src/lxc/lxc_cgroup.c| 31
src/lxc/lxc_container.c | 15
src/lxc/lxc_fuse.c | 78 ++---
3 files changed, 120 insertions(+), 4 deletions(-)
diff --git a/src/lxc
Hi Michal,
The first one looks cleaner.
You can go ahead.
Thanks again!
Em qui., 6 de fev. de 2020 às 05:51, Michal Privoznik
escreveu:
>
> On 2/6/20 3:12 AM, Julio Faracco wrote:
> > To configure network settings using config file, legacy LXC settings
> > req
` to specify the same thing. Same for IPv6.
Signed-off-by: Julio Faracco
---
For further details:
https://discuss.linuxcontainers.org/t/lxc-2-1-has-been-released/487
---
---
src/lxc/lxc_native.c | 12
src/lxc/lxc_native.h | 2
:
lxc.network.link = eth0
lxc.network.type = phys
lxc.network.name = eth1
lxc.network.ipv4 = 192.168.122.2/24
lxc.network.ipv4.gateway = 192.168.122.1
Now, libvirt only see error without segmentation fault.
Signed-off-by: Julio Faracco
---
src/lxc/lxc_native.c | 6 +-
1 file changed, 5 insertions(+), 1
Em dom., 2 de fev. de 2020 às 22:28, Julio Faracco
escreveu:
>
> Struct lxcNetworkParseData is being used as a single pointer which
> iterates through LXC config lines. It means that it will be applied as a
> network each time that a new type appears. After, the same struct is
> u
I agree, Michal.
I reviewed the logic and it is impossible to get a NULL pointer using
both approaches.
Thanks!
--
Julio Cesar Faracco
Em seg., 3 de fev. de 2020 às 07:06, Michal Privoznik
escreveu:
>
> On 2/3/20 2:28 AM, Julio Faracco wrote:
> > Domain definition is useless now in
LXC version 3 config files are still using network old style definition.
So, as LXC supports it now, they can be converted to use this new
definition.
Signed-off-by: Julio Faracco
---
.../lxcconf2xml-ethernet-v3.config| 16 -
.../lxcconf2xml-fstab-v3.config
be handle together each interface pointer.
Signed-off-by: Julio Faracco
---
src/lxc/lxc_native.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/src/lxc/lxc_native.c b/src/lxc/lxc_native.c
index 8bbe205659..99539a0205 100644
--- a/src/lxc/lxc_native.c
+++ b/src
LXC version 3 or higher introduced indexes for network interfaces.
Libvirt should be able to parse entries like `lxc.net.2.KEY`. This
commit adds functions to parse this type of field. That's why array
structures are so important this time.
Signed-off-by: Julio Faracco
---
src/lxc/lxc_native.c
g_autofree inserted above and adding some missing free
functions. See Daniel's test results/comments.
Julio Faracco (4):
lxc: refactor lxcNetworkParseData pointers to use new structures
lxc: add LXC version 3 network parser
lxc: remove domain definition from lxc network struct
tests: update
lxcNetworkParseData to move this strcuture to an array. It
makes more sense if we are using indexes to fill interface settings.
This is better to improve code clarity.
This commit still introduces *Legacy() functions to keep support of
network old style definitions.
Signed-off-by: Julio Faracco
Em qua., 29 de jan. de 2020 às 08:38, Daniel P. Berrangé
escreveu:
>
> On Tue, Jan 28, 2020 at 10:54:08PM -0300, Julio Faracco wrote:
> > Struct lxcNetworkParseData is being used as a single pointer which
> > iterates through LXC config lines. It means that it will be applie
lxcNetworkParseData to move this strcuture to an array. It
makes more sense if we are using indexes to fill interface settings.
This is better to improve code clarity.
This commit still introduces *Legacy() functions to keep support of
network old style definitions.
Signed-off-by: Julio Faracco
LXC version 3 or higher introduced indexes for network interfaces.
Libvirt should be able to parse entries like `lxc.net.2.KEY`. This
commit adds functions to parse this type of field. That's why array
structures are so important this time.
Signed-off-by: Julio Faracco
---
src/lxc/lxc_native.c
be handle together each interface pointer.
Signed-off-by: Julio Faracco
---
src/lxc/lxc_native.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/src/lxc/lxc_native.c b/src/lxc/lxc_native.c
index 35ac05f702..16dd0c1f5c 100644
--- a/src/lxc/lxc_native.c
+++ b/src
LXC version 3 config files are still using network old style definition.
So, as LXC supports it now, they can be converted to use this new
definition.
Signed-off-by: Julio Faracco
---
.../lxcconf2xml-ethernet-v3.config | 16
.../lxcconf2xml-fstab-v3.config
missing g_autofree from `suffix` variable.
Julio Faracco (4):
lxc: refactor lxcNetworkParseData pointers to use new structures
lxc: add LXC version 3 network parser
lxc: remove domain definition from lxc network struct
tests: update LXC config dataset to support V3 indexes
src/lxc/lxc_native.c
be handle together each interface pointer.
Signed-off-by: Julio Faracco
---
src/lxc/lxc_native.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/src/lxc/lxc_native.c b/src/lxc/lxc_native.c
index 15be33c9f1..b90fb6f40d 100644
--- a/src/lxc/lxc_native.c
+++ b/src
LXC version 3 config files are still using network old style definition.
So, as LXC supports it now, they can be converted to use this new
definition.
Signed-off-by: Julio Faracco
---
.../lxcconf2xml-ethernet-v3.config | 16
.../lxcconf2xml-fstab-v3.config
lxcNetworkParseData to move this strcuture to an array. It
makes more sense if we are using indexes to fill interface settings.
This is better to improve code clarity.
This commit still introduces *Legacy() functions to keep support of
network old style definitions.
Signed-off-by: Julio Faracco
interfaces are a single array with interface
pointers.
Old:
lxc.network.type = veth
lxc.network.flags = up
lxc.network.link = virbr0
New:
lxc.net.0.type = veth
lxc.net.0.flags = up
lxc.net.0.link = virbr0
v1-v2: Moving sscanf to virStrToLong_ull according Daniel's suggestion.
Julio Faracco (4
LXC version 3 or higher introduced indexes for network interfaces.
Libvirt should be able to parse entries like `lxc.net.2.KEY`. This
commit adds functions to parse this type of field. That's why array
structures are so important this time.
Signed-off-by: Julio Faracco
---
src/lxc/lxc_native.c
Op...
You are right! Let me send a V2.
Thanks to point it out, Daniel.
--
Julio Cesar Faracco
Em ter., 28 de jan. de 2020 às 11:44, Daniel P. Berrangé
escreveu:
>
> On Mon, Jan 27, 2020 at 11:25:47AM -0300, Julio Faracco wrote:
> > LXC version 3 or higher introduced indexes
LXC version 3 config files are still using network old style definition.
So, as LXC supports it now, they can be converted to use this new
definition.
Signed-off-by: Julio Faracco
---
.../lxcconf2xml-ethernet-v3.config | 16
.../lxcconf2xml-fstab-v3.config
lxcNetworkParseData to move this strcuture to an array. It
makes more sense if we are using indexes to fill interface settings.
This is better to improve code clarity.
This commit still introduces *Legacy() functions to keep support of
network old style definitions.
Signed-off-by: Julio Faracco
LXC version 3 or higher introduced indexes for network interfaces.
Libvirt should be able to parse entries like `lxc.net.2.KEY`. This
commit adds functions to parse this type of field. That's why array
structures are so important this time.
Signed-off-by: Julio Faracco
---
src/lxc/lxc_native.c
be handle together each interface pointer.
Signed-off-by: Julio Faracco
---
src/lxc/lxc_native.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/src/lxc/lxc_native.c b/src/lxc/lxc_native.c
index ae8d3cb85d..4af1b62817 100644
--- a/src/lxc/lxc_native.c
+++ b/src
interfaces are a single array with interface
pointers.
Old:
lxc.network.type = veth
lxc.network.flags = up
lxc.network.link = virbr0
New:
lxc.net.0.type = veth
lxc.net.0.flags = up
lxc.net.0.link = virbr0
Julio Faracco (4):
lxc: refactor lxcNetworkParseData pointers to use new structures.
lxc
QEMU driver has two functions: qemuGetDHCPInterfaces() and
qemuARPGetInterfaces() that are being used inside only one single
function. They can be turned into generic functions that other drivers
can use. This commit move both from QEMU driver tree to domain conf
tree.
Signed-off-by: Julio
, to make them available for other drivers. The only source
that LXC does not support is agent which is a specific source from QEMU.
Julio Faracco (2):
qemu: Converting DHCP and ARP functions to domain conf
lxc: Add support to lxcDomainInterfaceAddresses() function
src/conf/domain_conf.c | 134
LXC driver is not able to retrieve IP addresses from domains. This
function was not implemented yet. It can be done using DHCP lease and
ARP table. Different from QEMU, LXC does not have an agent to fetch
this info, but other sources can be used.
Signed-off-by: Julio Faracco
---
src/lxc
This is only 2 simple typo fixes for wrong documentation wording.
Signed-off-by: Julio Faracco
---
docs/apps.html.in | 2 +-
docs/auditlog.html.in | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/apps.html.in b/docs/apps.html.in
index 41dd26f7ff..629d740c28 100644
Em sex., 3 de jan. de 2020 às 12:45, Michal Prívozník
escreveu:
>
> On 1/2/20 4:07 PM, Julio Faracco wrote:
> > The command `domifaddr` can use three different sources to grab IP
> > address of a Virtual Machine: lease, agent and arp. This parameter does
> > not have a comp
The command `domifaddr` can use three different sources to grab IP
address of a Virtual Machine: lease, agent and arp. This parameter does
not have a completer function to return source options.
Signed-off-by: Julio Faracco
---
tools/virsh-completer-domain.c | 17 +
tools/virsh
, virCheckFlags will handle this case.
Signed-off-by: Julio Faracco
---
v1-v2: Moving sources into flags.
v2-v3: Applying Michal's suggestions.
---
docs/manpages/virsh.rst | 7 ++-
include/libvirt/libvirt-domain.h | 5 ++
src/lxc/lxc_driver.c | 78
. It will get the first
hostname available from domain networks.
This case, every driver has a default section inside switch to keep
compatibility. So, if someone call 'domhostname' without specifying
source, it will get the default option.
Signed-off-by: Julio Faracco
---
include/libvirt/libvirt-domain.h
Thanks for your explanation, Peter!
I will focus on LXC side then...
Em dom., 24 de nov. de 2019 às 18:34, Peter Krempa
escreveu:
>
> On Sun, Nov 24, 2019 at 21:24:07 +0100, Peter Krempa wrote:
> > On Sun, Nov 24, 2019 at 17:19:48 -0300, jcfara...@gmail.com wrote:
> > >
by test driver, shouldn't it?
--
Julio Faracco
>
> unsupported configuration: QOS must be defined for network 'default'
>
> Coverity didn't see that the bandwidth == NULL it complained about in
> virNetDevBandwidthPlug was already checked properly in
> networkCheckBandwidth, thus causi
comment.
Thanks again!
--
Julio Cesar Faracco
Em qui., 14 de nov. de 2019 às 18:34, Cole Robinson
escreveu:
>
> On 10/20/19 11:54 PM, jcfara...@gmail.com wrote:
> > From: Julio Faracco
> >
>
> I think if you set your gitconfig correctly, you can avoid this 'Fro
At least, I need to fix the leak problem. ;-)
I can grab other problems too.
I will submit a fix/patch soon.
--
Julio Faracco
Em qui, 17 de out de 2019 às 17:33, Cole Robinson
escreveu:
>
> My apologies Jonathan, I saw your responses after I reviewed and pushed
> Julio's patche
I usually don't bother list with ordinary messages, but...
Thank you very much for your guidance and patience, Cole!
I appreciate it!
Em qui, 17 de out de 2019 às 17:25, Cole Robinson
escreveu:
>
> On 10/17/19 12:30 AM, jcfara...@gmail.com wrote:
> > From: Julio Faracco
> >
&
1 - 100 of 388 matches
Mail list logo
