Signed-off-by: Katerina Koukiou
---
data/system/libvirt-dbus.service.in| 21 +++
data/system/meson.build| 30 +-
data/system/org.libvirt-systemd.service.in | 5
libvirt-dbus.spec.in | 4 ++-
meson.build
See https://bugs.launchpad.net/ubuntu/+source/libvirt-dbus/+bug/1892756
Signed-off-by: Katerina Koukiou
---
data/system/libvirt-dbus.service.in | 1 +
1 file changed, 1 insertion(+)
diff --git data/system/libvirt-dbus.service.in
data/system/libvirt-dbus.service.in
index 862a366..aa46217
For distributions that are using systemd introduce a
libvirt-dbus.service and have 'libvirt' group as supplementary
group for the spawned libvirt-dbus process. This will allow ubuntu
users (SocketMode is 0660 in newer ubuntu), to use system connection
without extra configuration.
Kateri
We were facing such errors:
* error: unused function 'glib_slistautoptr_cleanup_virtDBusConnect
Moving the G_DEFINE_AUTOPTR_CLEANUP_FUNC macros in the header files
fixes the issue.
Signed-off-by: Katerina Koukiou
---
src/connect.c | 3 +--
src/connect.h | 5 +
src/network.c | 4 +---
=1599513
Signed-off-by: Katerina Koukiou
---
Changes from v3:
Adjusted to Jano's comments in v3; type and address are now checked together.
src/qemu/qemu_hotplug.c | 33 -
1 file changed, 24 insertions(+), 9 deletions(-)
diff --git a/src/qemu/qemu_hotplug.c
=1599513
Signed-off-by: Katerina Koukiou
---
Changes from v2:
* Added check for type element in info struct.
* Moved the addr checks at start the the section with info checks.
src/qemu/qemu_hotplug.c | 34 ++
1 file changed, 26 insertions(+), 8 deletions(-)
diff
On Thu, Aug 09, 2018 at 05:50:11PM +0200, Ján Tomko wrote:
> On Thu, Aug 09, 2018 at 11:21:52AM +0200, Katerina Koukiou wrote:
> > This patch ensures that changes in attributes of interfaces will be emit
> > errors accept if they are missing from the XML.
> > Previously we w
?id=1599513
Signed-off-by: Katerina Koukiou
---
src/qemu/qemu_hotplug.c | 42 +
1 file changed, 26 insertions(+), 16 deletions(-)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 1488f0a7c2..76ab56a479 100644
--- a/src/qemu/qemu_hotplug.c
All rest of blkiotune parameters are not updatable through UpdateDeviceFlags
API.
https://bugzilla.redhat.com/show_bug.cgi?id=1601677
Signed-off-by: Katerina Koukiou
---
The BZ was requesting to add support for updating the group_name for
blkdeviotune here, though, all the rest of
: Katerina Koukiou
---
src/qemu/qemu_hotplug.c | 43 ++---
1 file changed, 27 insertions(+), 16 deletions(-)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 1488f0a7c2..8d98c149e2 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu
On Tue, Jul 31, 2018 at 07:24:00PM +0200, Ján Tomko wrote:
> On Tue, Jul 31, 2018 at 05:32:51PM +0200, Katerina Koukiou wrote:
> > On Tue, Jul 31, 2018 at 05:15:51PM +0200, Ján Tomko wrote:
> > > On Tue, Jul 31, 2018 at 04:34:39PM +0200, Katerina Koukiou wrote:
> > >
On Tue, Jul 31, 2018 at 05:15:51PM +0200, Ján Tomko wrote:
> On Tue, Jul 31, 2018 at 04:34:39PM +0200, Katerina Koukiou wrote:
> > When trying to update an interface's rom settings with an device XML
> > that is missing the PCI addr element, all new rom settings wh
When trying to update an interface's rom settings with an device XML
that is missing the PCI addr element, all new rom settings where not applied.
https://bugzilla.redhat.com/show_bug.cgi?id=1599513
Signed-off-by: Katerina Koukiou
---
Not sure why we chose to overwrite the whole info b
gt;
> --
> 2.17.1
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
Please remove the second patch moving the test file - see reasoning there.
So the third patch should be adjusted but in the original file, te
On Fri, Jul 27, 2018 at 02:37:39PM +0200, Andrea Bolognani wrote:
> For whatever reason, a few nodedev-related test cases
> have ended up in test_connect instead of the more
> appropriate test_nodedev. Move them.
>
> Signed-off-by: Andrea Bolognani
> ---
https://www.redhat.com/mailman/listinfo/l
For now syntax checking is performed only on the python
files using flake8.
E501: (line too long) warning is ignored.
Signed-off-by: Katerina Koukiou
---
HACKING.md | 9 -
Makefile.am | 6 ++
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/HACKING.md b/HACKING.md
Signed-off-by: Katerina Koukiou
---
tests/libvirttest.py| 9 +
tests/test_connect.py | 2 +-
tests/test_domain.py| 5 +++--
tests/test_interface.py | 12 +++-
tests/test_network.py | 8
tests/test_storage.py | 1 +
6 files changed, 21 insertions(+), 16
diff from v1:
* fixtures patch merged
* fixed reminder flake8 issues
* added patch introducing syntax-check target in the Makefile
Katerina Koukiou (2):
tests: fix all coding style issues to comply with flake8
Add syntax-check target in Makefile.am
HACKING.md | 9
On Thu, Jul 26, 2018 at 02:39:37PM +0200, Ján Tomko wrote:
> On Thu, Jul 26, 2018 at 02:09:58PM +0200, Katerina Koukiou wrote:
>
> Is there nothing that could be said here in the commit message?
>
> Also, it might be a good time to introduce a 'syntax-check' target
&g
Signed-off-by: Katerina Koukiou
---
tests/test_connect.py | 2 +-
tests/test_domain.py| 5 +++--
tests/test_interface.py | 11 ++-
tests/test_network.py | 8
tests/test_storage.py | 1 +
5 files changed, 15 insertions(+), 12 deletions(-)
diff --git a/tests
* node_device_create was a fixture but we were calling it as normal function,
thus it got triggered twice.
* interface_create was not a fixture.
This patch makes sure that the setup work these two functions are doing, will
run before the actual test call phase.
Signed-off-by: Katerina Koukiou
Katerina Koukiou (2):
tests: {interface, node_device}_create should be used as setup
fixtures
tests: fix all coding style issues to comply with pep8
tests/libvirttest.py| 1 +
tests/test_connect.py | 9 +
tests/test_domain.py| 5 +++--
tests/test_interface.py | 23
ns(+)
Reviewed-by: Katerina Koukiou
signature.asc
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
ged, 47 insertions(+)
Fixture issues will be fixed in seperate patch.
Reviewed-by: Katerina Koukiou
signature.asc
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Fri, Jul 20, 2018 at 02:34:59PM -0400, Anya Harter wrote:
> Signed-off-by: Anya Harter
> ---
> data/org.libvirt.Connect.xml | 5 +
> src/connect.c| 22 ++
> 2 files changed, 27 insertions(+)
Reviewed-by: Katerina Koukiou
signature.
On Fri, Jul 20, 2018 at 02:34:58PM -0400, Anya Harter wrote:
> Signed-off-by: Anya Harter
> ---
> data/org.libvirt.Connect.xml | 5 +
> src/connect.c| 22 ++
> 2 files changed, 27 insertions(+)
Reviewed-by: Katerina Koukiou
signature.
On Fri, Jul 20, 2018 at 02:34:57PM -0400, Anya Harter wrote:
> Signed-off-by: Anya Harter
> ---
> data/org.libvirt.Connect.xml | 5 +
> src/connect.c| 22 ++
> 2 files changed, 27 insertions(+)
Reviewed-by: Katerina Koukiou
signature.
On Fri, Jul 20, 2018 at 02:34:56PM -0400, Anya Harter wrote:
> Signed-off-by: Anya Harter
> ---
> data/org.libvirt.Connect.xml | 6 ++
> src/connect.c| 38
> 2 files changed, 44 insertions(+)
Reviewed-by: K
ns(+)
Reviewed-by: Katerina Koukiou
signature.asc
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
ns(+)
Reviewed-by: Katerina Koukiou
signature.asc
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
tions(+)
Reviewed-by: Katerina Koukiou
signature.asc
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
ged, 38 insertions(+)
Reviewed-by: Katerina Koukiou
signature.asc
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
take any flags.
> +
> def test_interface_destroy(self):
> _,interface_obj = self.interface_create()
> interface_obj.Destroy(0)
> --
> 2.17.1
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
With the flag argument removed:
Reviewed-by: Katerina Koukiou
signature.asc
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
_,interface_obj = self.interface_create()
> interface_obj.Destroy(0)
> --
> 2.17.1
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
Reviewed-by: Katerina Koukiou
signature.asc
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
interface_create(self, test_interface):
_,interface_obj = test_interface
interface_obj.Destroy(0)
interface_obj.Create(0)
> +
> +def test_interface_create(self):
> +_,interface_obj = self.interface_create()
> +interface_obj.Destroy(0)
> + i
tributions
> run at least part of their package build steps with pretend
> root privileges (eg. fakeroot), so we have to make sure it
> works in that scenario too.
>
> Signed-off-by: Andrea Bolognani
> ---
> tests/libvirttest.py | 2 +-
> 1 file changed, 1 inse
CPU is an acronym and should be written in uppercase
when part of plain text and not refering to an element.
Signed-off-by: Katerina Koukiou
---
As asked in the review here
https://www.redhat.com/archives/libvir-list/2018-July/msg01093.html
docs/formatdomain.html.in | 84
On Wed, Jul 18, 2018 at 10:05:30AM +0200, Ján Tomko wrote:
> On Tue, Jul 17, 2018 at 05:47:32PM +0200, Katerina Koukiou wrote:
> > Although the name of the element is not self-explanatory,
> > it's affecting only the vcpu threads.
> >
> > Signed-off-by: Ka
l
> create mode 100644 guests/host_vars/libvirt-fedora-28/docker.yml
> create mode 100644 guests/host_vars/libvirt-fedora-rawhide/docker.yml
> create mode 100644 guests/host_vars/libvirt-ubuntu-16/docker.yml
> create mode 100644 guests/host_vars/libvirt-ubuntu-18/docker.yml
>
On Tue, Jul 17, 2018 at 04:44:24PM +0200, Andrea Bolognani wrote:
> On Tue, 2018-07-17 at 15:04 +0200, Katerina Koukiou wrote:
> > On Thu, Jul 12, 2018 at 05:19:27PM +0200, Andrea Bolognani wrote:
> > > +class Projects:
> > > +
> > > +de
On Tue, Jul 17, 2018 at 04:45:39PM +0200, Andrea Bolognani wrote:
> On Tue, 2018-07-17 at 14:57 +0200, Katerina Koukiou wrote:
> > On Thu, Jul 12, 2018 at 05:19:24PM +0200, Andrea Bolognani wrote:
> > > +cmd = [ "ansible-playbook" ]
> >
> > IMO this
On Tue, Jul 17, 2018 at 02:51:47PM +0200, Andrea Bolognani wrote:
> On Tue, 2018-07-17 at 11:57 +0200, Katerina Koukiou wrote:
> > On Thu, Jul 12, 2018 at 05:19:21PM +0200, Andrea Bolognani wrote:
> > > +import yaml
> >
> > Since you have to install yaml to actu
Patch series
https://www.redhat.com/archives/libvir-list/2016-January/msg00482.html
introduced the parameters but didn't update the docs.
Signed-off-by: Katerina Koukiou
---
docs/formatdomain.html.in | 21 +
1 file changed, 21 insertions(+)
diff --git a
Katerina Koukiou (2):
docs: formatdomain: add info about global_period and global_quota for
cputune
docs: formatdomain: clarify period cputune subelement
docs/formatdomain.html.in | 31 ++-
1 file changed, 26 insertions(+), 5 deletions(-)
--
2.17.1
Although the name of the element is not self-explanatory,
it's affecting only the vcpu threads.
Signed-off-by: Katerina Koukiou
---
docs/formatdomain.html.in | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.ht
On Thu, Jul 12, 2018 at 05:19:29PM +0200, Andrea Bolognani wrote:
> This is basically the exact same algorithm used by the
> Ansible playbooks to process package mappings, implemented
> in pure Python.
>
> Signed-off-by: Andrea Bolognani
> ---
> guests/lcitool | 86 ++
On Thu, Jul 12, 2018 at 05:19:27PM +0200, Andrea Bolognani wrote:
> The original tool's limited scope meant loadins this
> information was not needed, but we're going to start
> making use of it pretty soon.
>
> Signed-off-by: Andrea Bolognani
> ---
> guests/lcitool | 47
On Thu, Jul 12, 2018 at 05:19:24PM +0200, Andrea Bolognani wrote:
> The 'prepare' alias was kinda redundant and offered
> dubious value, so it has been dropped.
>
> Signed-off-by: Andrea Bolognani
> ---
> guests/lcitool | 30 ++
> 1 file changed, 30 insertions(+)
>
>
On Thu, Jul 12, 2018 at 05:19:23PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> guests/lcitool | 74 --
> 1 file changed, 72 insertions(+), 2 deletions(-)
>
> diff --git a/guests/lcitool b/guests/lcitool
> index f11b92e.
On Thu, Jul 12, 2018 at 05:19:21PM +0200, Andrea Bolognani wrote:
> We use an actual YAML parser this time around, and bring
> the behavior more in line with what Ansible is doing, so
> interoperability should be more solid overall.
>
> New in this implementation is more flexibility in defining
>
On Thu, Jul 12, 2018 at 05:19:20PM +0200, Andrea Bolognani wrote:
> The on-disk configuration format and its behavior
> are fully backwards compatible with the previous
> implementation.
>
> Signed-off-by: Andrea Bolognani
> ---
> guests/lcitool | 112
On Thu, Jul 12, 2018 at 05:19:19PM +0200, Andrea Bolognani wrote:
> Doesn't do much right now, but it's a start :)
>
> Signed-off-by: Andrea Bolognani
> ---
> guests/lcitool | 69 ++
> 1 file changed, 69 insertions(+)
> create mode 100755 guests/l
When VIR_DOMAIN_SCHEDULER_GLOBAL_PERIOD is matched "cputune.global_period"
should be updated and not "cputune.period".
Signed-off-by: Katerina Koukiou
---
src/qemu/qemu_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_driver.c b/sr
Signed-off-by: Katerina Koukiou
---
src/qemu/qemu_hotplug.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 3dfa51b0a0..2e13cab233 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -793,6 +793,7
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1599513
Signed-off-by: Katerina Koukiou
---
src/qemu/qemu_hotplug.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 3dfa51b0a0..bb50d19c85 100644
--- a/src/qemu/qemu_hotplug.c
onnectNetworkEventDeregisterAny(connect->connection,
> +virConnectNodeDeviceEventDeregisterAny(connect->connection,
>
> connect->nodeDevCallbackIds[i]);
Indentation is off here. Oth
Signed-off-by: Katerina Koukiou
---
src/connect.c | 12 ++--
src/domain.c | 2 +-
src/events.c | 24
src/network.c | 2 +-
src/util.c| 6 +++---
src/util.h| 4 ++--
6 files changed, 25 insertions(+), 25 deletions(-)
diff --git a/src/connect.c b/src
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.NodeDevice.xml | 6 ++
src/nodedev.c | 28
tests/test_nodedev.py | 6 ++
3 files changed, 40 insertions(+)
diff --git a/data/org.libvirt.NodeDevice.xml b/data
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Connect.xml | 8
src/connect.c| 32
2 files changed, 40 insertions(+)
diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml
index a030d57..7014a09 100644
--- a/data
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Connect.xml | 6 ++
src/connect.c| 29 +
tests/test_connect.py| 13 +
3 files changed, 48 insertions(+)
diff --git a/data/org.libvirt.Connect.xml b/data
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.NodeDevice.xml | 4
src/nodedev.c | 21 +
2 files changed, 25 insertions(+)
diff --git a/data/org.libvirt.NodeDevice.xml b/data/org.libvirt.NodeDevice.xml
index bf85958..56deee3 100644
--- a/data
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.NodeDevice.xml | 5 +
src/nodedev.c | 37 +
tests/test_nodedev.py | 6 ++
3 files changed, 48 insertions(+)
diff --git a/data/org.libvirt.NodeDevice.xml b/data
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Connect.xml | 7 +++
src/connect.c| 13 +
src/connect.h| 1 +
src/events.c | 42 ++
4 files changed, 63 insertions(+)
diff --git a/data
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.NodeDevice.xml | 5 +
src/nodedev.c | 22 ++
tests/test_nodedev.py | 8
3 files changed, 35 insertions(+)
diff --git a/data/org.libvirt.NodeDevice.xml b/data
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.NodeDevice.xml | 5 +
src/nodedev.c | 22 ++
tests/test_nodedev.py | 1 +
3 files changed, 28 insertions(+)
diff --git a/data/org.libvirt.NodeDevice.xml b/data/org.libvirt.NodeDevice.xml
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.NodeDevice.xml | 5 +
src/nodedev.c | 25 +
2 files changed, 30 insertions(+)
diff --git a/data/org.libvirt.NodeDevice.xml b/data/org.libvirt.NodeDevice.xml
index 4ca2e11..ea9bd7c 100644
--- a
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.NodeDevice.xml | 4
src/nodedev.c | 21 +
2 files changed, 25 insertions(+)
diff --git a/data/org.libvirt.NodeDevice.xml b/data/org.libvirt.NodeDevice.xml
index 56deee3..5464c9a 100644
--- a/data
Signed-off-by: Katerina Koukiou
---
Some note about the test:
1: The previous test should not use the node_device_create fixture introduced
here
for the following reason:
The fixture is creating the device in the setup of the test since the
device creation is not supposed to be tested in
Signed-off-by: Katerina Koukiou
---
data/Makefile.am| 1 +
data/org.libvirt.NodeDevice.xml | 7 +
src/Makefile.am | 1 +
src/connect.c | 6
src/connect.h | 1 +
src/nodedev.c | 65
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Connect.xml | 6 ++
src/connect.c| 38 ++
2 files changed, 44 insertions(+)
diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml
index 37daed0..137e67b 100644
--- a
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Connect.xml | 7 +++
src/connect.c| 30 ++
tests/libvirttest.py | 3 +++
tests/test_connect.py| 14 ++
tests/xmldata.py | 16
5 files
Katerina Koukiou (14):
Introduce NodeDevice Interface
Implement ListNodeDevices method for Connect Interface
Register NodeDevice Lifecycle Events
Implement NodeDeviceCreateXML method for Connect Interface
Implement Destroy method for NodeDevice Interface
Implement Detach method for
Signed-off-by: Katerina Koukiou
Reviewed-by: Ján Tomko
---
data/org.libvirt.StorageVol.xml | 5 +
src/storagevol.c| 25 +
tests/test_storage.py | 6 ++
3 files changed, 36 insertions(+)
diff --git a/data/org.libvirt.StorageVol.xml b
Signed-off-by: Katerina Koukiou
Reviewed-by: Ján Tomko
---
data/org.libvirt.Connect.xml | 6 ++
src/connect.c| 30 ++
tests/test_connect.py| 15 +++
3 files changed, 51 insertions(+)
diff --git a/data/org.libvirt.Connect.xml
Signed-off-by: Katerina Koukiou
Reviewed-by: Ján Tomko
---
data/org.libvirt.StorageVol.xml | 6 ++
src/storagevol.c| 29 +
2 files changed, 35 insertions(+)
diff --git a/data/org.libvirt.StorageVol.xml b/data/org.libvirt.StorageVol.xml
index
Signed-off-by: Katerina Koukiou
Reviewed-by: Ján Tomko
---
data/org.libvirt.StorageVol.xml | 5 +
src/storagevol.c| 23 +++
tests/test_storage.py | 1 +
3 files changed, 29 insertions(+)
diff --git a/data/org.libvirt.StorageVol.xml b/data
Signed-off-by: Katerina Koukiou
Reviewed-by: Ján Tomko
---
data/org.libvirt.StorageVol.xml | 5 +
src/storagevol.c| 44 +
tests/test_storage.py | 11 +++
3 files changed, 60 insertions(+)
diff --git a/data
Signed-off-by: Katerina Koukiou
Reviewed-by: Ján Tomko
---
data/org.libvirt.StorageVol.xml | 6 ++
src/storagevol.c| 26 ++
2 files changed, 32 insertions(+)
diff --git a/data/org.libvirt.StorageVol.xml b/data/org.libvirt.StorageVol.xml
index
: Katerina Koukiou
---
tests/libvirttest.py | 6 +++---
tests/test_connect.py | 6 +++---
tests/test_domain.py | 20 ++--
tests/test_network.py | 14 +++---
tests/test_storage.py | 22 +++---
5 files changed, 34 insertions(+), 34 deletions(-)
diff --git
Signed-off-by: Katerina Koukiou
Reviewed-by: Ján Tomko
---
data/org.libvirt.StoragePool.xml | 9 +
src/storagepool.c| 41
tests/test_storage.py| 22 +
3 files changed, 72 insertions(+)
diff --git
Signed-off-by: Katerina Koukiou
---
tests/test_connect.py | 47 +++
tests/xmldata.py | 37 +
2 files changed, 44 insertions(+), 40 deletions(-)
create mode 100644 tests/xmldata.py
diff --git a/tests
Signed-off-by: Katerina Koukiou
Reviewed-by: Ján Tomko
---
data/org.libvirt.StorageVol.xml | 6 ++
src/storagevol.c| 29 +
tests/test_storage.py | 7 +++
3 files changed, 42 insertions(+)
diff --git a/data
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.StoragePool.xml | 7 +++
src/storagepool.c| 34 ++
tests/libvirttest.py | 31 +++
tests/test_storage.py| 3 +++
tests/xmldata.py
Signed-off-by: Katerina Koukiou
Reviewed-by: Ján Tomko
---
data/org.libvirt.StorageVol.xml | 6 ++
src/storagevol.c| 26 ++
2 files changed, 32 insertions(+)
diff --git a/data/org.libvirt.StorageVol.xml b/data/org.libvirt.StorageVol.xml
index
Signed-off-by: Katerina Koukiou
Reviewed-by: Ján Tomko
---
data/org.libvirt.Connect.xml | 6 ++
src/connect.c| 30 ++
tests/test_connect.py| 1 +
3 files changed, 37 insertions(+)
diff --git a/data/org.libvirt.Connect.xml b/data
Signed-off-by: Katerina Koukiou
Reviewed-by: Ján Tomko
---
data/org.libvirt.StorageVol.xml | 5 +
src/storagevol.c| 23 +++
tests/test_storage.py | 1 +
3 files changed, 29 insertions(+)
diff --git a/data/org.libvirt.StorageVol.xml b/data
Signed-off-by: Katerina Koukiou
Reviewed-by: Ján Tomko
---
data/org.libvirt.StoragePool.xml | 6 ++
src/storagepool.c| 43
tests/test_storage.py| 8
3 files changed, 57 insertions(+)
diff --git a/data
Signed-off-by: Katerina Koukiou
Reviewed-by: Ján Tomko
---
data/org.libvirt.StoragePool.xml | 6 ++
src/storagepool.c| 34 ++
2 files changed, 40 insertions(+)
diff --git a/data/org.libvirt.StoragePool.xml b/data/org.libvirt.StoragePool.xml
In this way, the get_test_storage_volume function remained same to
the similar purpose functions as suggested in the previous review.
Katerina Koukiou (17):
Introduce StorageVol Interface
Implement ListStorageVolumes for StoragePool Interface
test: move XML definition of entities t
Signed-off-by: Katerina Koukiou
---
data/Makefile.am| 4 ++-
data/org.libvirt.StorageVol.xml | 7
src/Makefile.am | 4 ++-
src/connect.c | 6
src/connect.h | 1 +
src/storagevol.c| 77
Replace name with id attribute in headers to fix the links.
Signed-off-by: Katerina Koukiou
---
docs/api_extension.html.in | 12 ++--
docs/dbus.html.in | 6 +++---
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/docs/api_extension.html.in b/docs
ject
> guests: Drop CentOS 6 support
I can't review the vault file since I don't have the password but
otherwise they look good.
Reviewed-by: Katerina Koukiou
signature.asc
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.StorageVol.xml | 6 ++
src/storagevol.c| 26 ++
2 files changed, 32 insertions(+)
diff --git a/data/org.libvirt.StorageVol.xml b/data/org.libvirt.StorageVol.xml
index c1fecf3..fdde430 100644
--- a
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.StorageVol.xml | 6 ++
src/storagevol.c| 29 +
2 files changed, 35 insertions(+)
diff --git a/data/org.libvirt.StorageVol.xml b/data/org.libvirt.StorageVol.xml
index aed3f7a..8a4eab2 100644
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Connect.xml | 6 ++
src/connect.c| 29 +
tests/test_connect.py| 1 +
3 files changed, 36 insertions(+)
diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml
index
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.StorageVol.xml | 5 +
src/storagevol.c| 44 +
tests/test_storage.py | 9 +
3 files changed, 58 insertions(+)
diff --git a/data/org.libvirt.StorageVol.xml b/data
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.StorageVol.xml | 5 +
src/storagevol.c| 23 +++
tests/test_storage.py | 1 +
3 files changed, 29 insertions(+)
diff --git a/data/org.libvirt.StorageVol.xml b/data/org.libvirt.StorageVol.xml
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Connect.xml | 6 ++
src/connect.c| 30 ++
tests/test_connect.py| 14 ++
3 files changed, 50 insertions(+)
diff --git a/data/org.libvirt.Connect.xml b/data
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.StorageVol.xml | 5 +
src/storagevol.c| 25 +
tests/test_storage.py | 6 ++
3 files changed, 36 insertions(+)
diff --git a/data/org.libvirt.StorageVol.xml b/data
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.StorageVol.xml | 6 ++
src/storagevol.c| 26 ++
2 files changed, 32 insertions(+)
diff --git a/data/org.libvirt.StorageVol.xml b/data/org.libvirt.StorageVol.xml
index fdde430..aed3f7a 100644
--- a
1 - 100 of 578 matches
Mail list logo
