Re: [libvirt] [PATCH v4 0/8] Virtio-crypto device support

On 2018/11/16 23:34, Marc Hartmayer wrote: > On Thu, Oct 26, 2017 at 03:31 AM +0200, "Longpeng (Mike)" > wrote: >> On 2017/10/25 23:14, Matthew Rosato wrote: >> >>> On 07/07/2017 04:07 AM, Longpeng(Mike) wrote: >>>> As virtio-crypto has been s

Re: [libvirt] [PATCH v4 0/8] Virtio-crypto device support

On 2017/10/25 23:14, Matthew Rosato wrote: > On 07/07/2017 04:07 AM, Longpeng(Mike) wrote: >> As virtio-crypto has been supported in QEMU 2.8 and the frontend >> driver has been merged in linux 4.10, so it's necessary to support >> virtio-crypto in libvirt. >> >

Re: [libvirt] [PATCH v4 0/8] Virtio-crypto device support

Ping... On 2017/7/7 16:07, Longpeng(Mike) wrote: > As virtio-crypto has been supported in QEMU 2.8 and the frontend > driver has been merged in linux 4.10, so it's necessary to support > virtio-crypto in libvirt. > > --- > Changes since v3: > - spilt the capabilities

[libvirt] [PATCH v4 7/8] tests: Add testcase for virtio-crypto parsing

Adds XML parsing and qemu commandline tests for the virtio-crypto device support. Signed-off-by: Longpeng(Mike) <longpe...@huawei.com> --- .../qemuxml2argv-virtio-crypto-builtin.xml | 26 ++ .../qemuxml2argv-virtio-crypto.args

[libvirt] [PATCH v4 5/8] qemu: Implement support for 'builtin' backend for virtio-crypto

,cryptodev=objcrypto0,id=crypto0 Signed-off-by: Longpeng(Mike) <longpe...@huawei.com> --- src/qemu/qemu_alias.c | 20 +++ src/qemu/qemu_alias.h | 3 + src/qemu/qemu_command.c| 126 + src/qemu/qemu_command.h| 3

[libvirt] [PATCH v4 3/8] conf: Parse virtio-crypto in the domain XML

This patch parse the domain XML with virtio-crypto support, the virtio-crypto XML looks like this: Signed-off-by: Longpeng(Mike) <longpe...@huawei.com> --- src/conf/domain_conf.c | 213 - src/conf/domain_conf.h

[libvirt] [PATCH v4 4/8] caps: Add qemu capabilities about virtio-crypto

Two capabilities bits are added to track support for those: QEMU_CAPS_DEVICE_VIRTIO_CRYPTO - for the device support and QEMU_CAPS_OBJECT_CRYPTO_BUILTIN - for the backend support. Signed-off-by: Longpeng(Mike) <longpe...@huawei.com> --- src/qemu/qemu_capabilities.c

[libvirt] [PATCH v4 1/8] docs: schema: Add basic documentation for the virtual

This patch documents XML elements used for support of virtual crypto devices. In the devices section in the domain XML users may specify: to enable the crypto device for guests. Signed-off-by: Longpeng(Mike) <longpe...@huawei.com> --- docs/formatdomain.html.in

[libvirt] [PATCH v4 6/8] qemu: virtio-crypto: add ccw support

From: Boris Fiuczynski Add device address type ccw which is supported since qemu 2.9.0. Signed-off-by: Boris Fiuczynski Reviewed-by: Marc Hartmayer --- src/qemu/qemu_command.c | 8 ++-- 1 file changed, 6

[libvirt] [PATCH v4 2/8] docs: news: Add virtio-crypto devices

Signed-off-by: Longpeng(Mike) <longpe...@huawei.com> --- docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index a886e2c..b766984 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -35,6

[libvirt] [PATCH v4 0/8] Virtio-crypto device support

] --- Boris Fiuczynski (2): qemu: virtio-crypto: add ccw support qemu: virtio-crypto: add test for ccw support Longpeng(Mike) (6): docs: schema: Add basic documentation for the virtual docs: news: Add virtio-crypto devices conf: Parse virtio-crypto in the domain XML caps: Add qemu capabilities

[libvirt] [PATCH v4 8/8] qemu: virtio-crypto: add test for ccw support

From: Boris Fiuczynski Add qemu command line tests for virtio-crypto ccw support. Signed-off-by: Boris Fiuczynski Reviewed-by: Marc Hartmayer --- .../qemuxml2argv-virtio-crypto-ccw.args| 22

Re: [libvirt] [PATCH v3 0/4] Virtio-crypto device support

Hi Boris, On 2017/7/6 23:01, Boris Fiuczynski wrote: > On 07/06/2017 03:47 PM, Longpeng (Mike) wrote: >> Hi Boris, >> >> On 2017/7/6 20:28, Boris Fiuczynski wrote: >> >>> Hi Mike, >>> I am going to send a set of patches based on your series adding ccw

Re: [libvirt] [PATCH v3 2/4] conf: Parse virtio-crypto in the domain XML

Hi Marc, On 2017/7/6 21:19, Marc Hartmayer wrote: > On Wed, Jul 05, 2017 at 01:17 PM +0200, "Longpeng(Mike)" > <longpe...@huawei.com> wrote: >> This patch parse the domain XML with virtio-crypto >> support, the virtio-crypto XML looks like this: >> [...]

Re: [libvirt] [PATCH v3 0/4] Virtio-crypto device support

sdata/caps_2.8.0.s390x.xml (located in patch 4) > I'll add the missing part :) > I suggest to put the introduction of the capabilities "cryptodev- > backend-builtin" and "virtio-crypto" including the changes in tests in a > separate patch. > Sorry, I don't

[libvirt] [PATCH v3 2/4] conf: Parse virtio-crypto in the domain XML

This patch parse the domain XML with virtio-crypto support, the virtio-crypto XML looks like this: Signed-off-by: Longpeng(Mike) <longpe...@huawei.com> --- src/conf/domain_conf.c | 213 - src/conf/domain_conf.h

[libvirt] [PATCH v3 1/4] docs: schema: Add basic documentation for the virtual

This patch documents XML elements used for support of virtual crypto devices. In the devices section in the domain XML users may specify: to enable the crypto device for guests. Signed-off-by: Longpeng(Mike) <longpe...@huawei.com> --- docs/formatdomain.html.in

[libvirt] [PATCH v3 4/4] tests: Add testcase for virtio-crypto XML parsing

Adds XML parsing and qemu commandline tests for the virtio-crypto device support. Signed-off-by: Longpeng(Mike) <longpe...@huawei.com> --- tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml| 2 ++ tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml | 2 ++ .../qemuxml2argv-virtio-

[libvirt] [PATCH v3 3/4] qemu: Implement support for 'builtin' backend for virtio-crypto

with these additional parameters if the device id enabled: (to add the backend) -object cryptodev-backend-builtin,id=objcrypto0,queues=1 (to add the device) -device virtio-crypto-pci,cryptodev=objcrypto0,id=crypto0 Signed-off-by: Longpeng(Mike) <longpe...@huawei.com> --- src/qemu/qemu_a

[libvirt] [PATCH v3 0/4] Virtio-crypto device support

cs/tests/schema [Martin] - fix typos [Gonglei] --- Longpeng(Mike) (4): docs: schema: Add basic documentation for the virtual conf: Parse virtio-crypto in the domain XML qemu: Implement support for 'builtin' backend for virtio-crypto tests: Add testcase for virtio-crypto XML parsin

Re: [libvirt] [PATCH v2 2/4] conf: Parse virtio-crypto in the domain XML

Hi Martin, On 2017/2/7 20:15, Martin Kletzander wrote: > On Wed, Jan 11, 2017 at 04:28:24PM +0800, Longpeng(Mike) wrote: >> This patch parse the domain XML with virtio-crypto >> support, the virtio-crypto XML looks like this: >> >> >> >> >

Re: [libvirt] [PATCH v2 1/4] docs: schema: Add basic documentation for the virtual crypto device support

Hi Martin, On 2017/2/7 19:11, Martin Kletzander wrote: > On Wed, Jan 11, 2017 at 04:28:23PM +0800, Longpeng(Mike) wrote: >> This patch documents XML elements used for support of virtual ... >> + type >> + >> + >> +Th

Re: [libvirt] [PATCH v2 0/4] Virtio-crypto device support

Hi guys, Does anyone have any comments ? :) -- Regards, Longpeng(Mike) On 2017/1/11 16:28, Longpeng(Mike) wrote: > As virtio-crypto has been supported in QEMU 2.8 and the frontend > driver has been merged in linux 4.10, so it's necessary to support > virtio-crypto i

Re: [libvirt] [PATCH v2 0/4] Virtio-crypto device support

Hi, Ping... :) Regards, Longpeng(Mike) On 2017/1/11 16:28, Longpeng(Mike) wrote: > As virtio-crypto has been supported in QEMU 2.8 and the frontend > driver has been merged in linux 4.10, so it's necessary to support > virtio-crypto in libvirt. > > --- > Changes since v1:

[libvirt] [PATCH v2 0/4] Virtio-crypto device support

] --- Longpeng(Mike) (4): docs: schema: Add basic documentation for the virtual crypto device support conf: Parse virtio-crypto in the domain XML qemu: Implement support for 'builtin' backend for virtio-crypto tests: Add testcase for virtio-crypto XML parsing docs/formatdomain.html.in

[libvirt] [PATCH v2 4/4] tests: Add testcase for virtio-crypto XML parsing

Adds XML parsing and qemu commandline tests for the virtio-crypto device support. Signed-off-by: Longpeng(Mike) <longpe...@huawei.com> --- tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml| 2 ++ tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml | 2 ++ .../qemuxml2argv-virtio-

[libvirt] [PATCH v2 2/4] conf: Parse virtio-crypto in the domain XML

This patch parse the domain XML with virtio-crypto support, the virtio-crypto XML looks like this: Signed-off-by: Longpeng(Mike) <longpe...@huawei.com> --- src/conf/domain_conf.c | 213 - src/conf/domain_conf.h

[libvirt] [PATCH v2 3/4] qemu: Implement support for 'builtin' backend for virtio-crypto

with these additional parameters if the device id enabled: (to add the backend) -object cryptodev-backend-builtin,id=objcrypto0,queues=1 (to add the device) -device virtio-crypto-pci,cryptodev=objcrypto0,id=crypto0 Signed-off-by: Longpeng(Mike) <longpe...@huawei.com> --- src/conf/domain_

[libvirt] [PATCH v2 1/4] docs: schema: Add basic documentation for the virtual crypto device support

This patch documents XML elements used for support of virtual crypto devices. In the devices section in the domain XML users may specify: to enable the crypto device for guests. Signed-off-by: Longpeng(Mike) <longpe...@huawei.com> --- docs/formatdomain.html.in

Re: [libvirt] [PATCH] conf: Parse virtio-crypto in the domain XML

Hi Martin, On 2017/1/9 16:44, Martin Kletzander wrote: > On Mon, Jan 09, 2017 at 10:15:25AM +0800, Longpeng(Mike) wrote: >> As virtio-crypto has been supported in QEMU 2.9 and >> the frontend driver has been merged in linux 4.10, >> so it's necessary to support virtio-cr

[libvirt] [PATCH] conf: Parse virtio-crypto in the domain XML

-by: Longpeng(Mike) <longpe...@huawei.com> --- src/conf/domain_conf.c | 212 + src/conf/domain_conf.h | 32 +++ src/qemu/qemu_alias.c | 20 src/qemu/qemu_alias.h | 4 + src/qemu/qemu_capabilities.c | 4 + sr