[libvirt] [libvirt-php 1/1] Make doc package noarch

2011-04-19 Thread Lyre
--- libvirt-php.spec.in |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/libvirt-php.spec.in b/libvirt-php.spec.in index 07e11a1..41408a2 100644 --- a/libvirt-php.spec.in +++ b/libvirt-php.spec.in @@ -46,6 +46,7 @@ For more details see: http://www.libvirt.org/php/

[libvirt] [libvirt-php] Add libvirt_storagepool_build() function

2011-04-19 Thread Lyre
also add flags for this function, currently not used. --- src/libvirt-php.c | 31 +++ src/libvirt-php.h |1 + 2 files changed, 32 insertions(+), 0 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index d436e1c..54331bb 100644 ---

[libvirt] [libvirt-php 1/2] Add CFLAGS for compiler

2011-04-14 Thread Lyre
The defualt CFLAGS is `-g -Wall'. We can change it with ./configure CFLAGS=your option. The `-g' options also make it able to build debugsource debuginfo packages. --- src/Makefile.am |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am

[libvirt] [libvirt-php 2/2] Fix possible uninitialized variable

2011-04-14 Thread Lyre
--- src/libvirt-php.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 020da4e..d436e1c 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -1204,7 +1204,8 @@ char *get_string_from_xpath(char *xml, char *xpath, zval

Re: [libvirt] [libvirt-php] Fix get_xml when xpath is null

2011-04-13 Thread Lyre
于 2011年04月13日 15:32, Michal Novotny 写道: On 04/13/2011 06:10 AM, Lyre wrote: Hi all: To my surprise, it seems that passing null to php as a string parameter, will set the pointer which retrive it to an empty string , but not NULL. get_xml_from_xpath() doesn't work correctly since

[libvirt] [libvirt-php 1/2] Fix memory leak when connection failed

2011-04-12 Thread Lyre
--- src/libvirt-php.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 9998fc8..e6a780a 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -788,7 +788,11 @@ PHP_FUNCTION(libvirt_connect) efree(creds);

[libvirt] [libvirt-php 2/2] Fix memory leak when releasing connection domain

2011-04-12 Thread Lyre
--- src/libvirt-php.c | 30 ++ 1 files changed, 22 insertions(+), 8 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index e6a780a..ce9d0b9 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -291,10 +291,17 @@ static void

[libvirt] [libvirt-php 0/2] Fixed some memory leaks

2011-04-12 Thread Lyre
Hi all: This patch fixed some memory leaks Lyre (2): Fix memory leak when connection failed Fix memory leak when releasing connection domain src/libvirt-php.c | 36 +++- 1 files changed, 27 insertions(+), 9 deletions(-) -- 1.7.3.4 C -- libvir-list

[libvirt] [libvirt-php] Fix get_xml when xpath is null

2011-04-12 Thread Lyre
Hi all: To my surprise, it seems that passing null to php as a string parameter, will set the pointer which retrive it to an empty string , but not NULL. get_xml_from_xpath() doesn't work correctly since an empty string is passed as the xpath argument, and libxml will complain Invalid

[libvirt] [libvirt-php] Fixed minor memory leak

2011-04-06 Thread Lyre
--- src/libvirt-php.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index b6a848f..7870fcf 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -222,8 +222,8 @@ PHP_MINFO_FUNCTION(libvirt) if

Re: [libvirt] [libvirt-php] Remove strip from installation

2011-04-01 Thread Lyre
于 2011年04月01日 16:33, Michal Novotny 写道: On 04/01/2011 07:25 AM, Lyre wrote: Make it able to generate debuginfo package. Thanks, pushed now! I don't know why this is not there but maybe I added this to f14 branch only since it's necessary to generate debuginfo packages for Fedora. However I

[libvirt] [libvirt-php] Fixed set_error when argument is NULL

2011-04-01 Thread Lyre
Avoid freeing a NULL pointer --- src/libvirt-php.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 6a76f45..66b1de9 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -237,12 +237,16 @@ PHP_MINFO_FUNCTION(libvirt)

[libvirt] [libvirt-php] Remove strip from installation

2011-03-31 Thread Lyre
Make it able to generate debuginfo package. --- configure.ac|1 - src/Makefile.am |2 +- 2 files changed, 1 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 8149349..5ebe416 100644 --- a/configure.ac +++ b/configure.ac @@ -11,7 +11,6 @@ AC_LANG([C])

Re: [libvirt] [libvirt-php] Add volume clone support

2011-03-28 Thread Lyre
于 2011年03月28日 17:19, Michal Novotny 写道: Hi Lyre, I'm having some (inline) comments to consider... - struct _virDomainMemoryStat stats[VIR_DOMAIN_MEMORY_STAT_NR]; + + struct _virDomainMemoryStat stats[VIR_DOMAIN_MEMORY_STAT_NR

[libvirt] [libvirt-php PATCH v2 3/4] Volume: add clone support

2011-03-28 Thread Lyre
New API: libvirt_storagevolume_create_xml_from() It may need some asynchronous mechanism to use this fuction, since it may taks a long long time. --- src/libvirt-php.c | 42 ++ src/libvirt-php.h |1 + 2 files changed, 43 insertions(+), 0 deletions(-)

[libvirt] [libvirt-php PATCH v2 2/4] Storagepool: make flag for pool refresh optional

2011-03-28 Thread Lyre
--- src/libvirt-php.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index b43da7a..4835e59 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -3058,7 +3058,7 @@ PHP_FUNCTION(libvirt_storagepool_refresh) zval *zpool;

[libvirt] [libvirt-php PATCH v2 0/4] new API for storage

2011-03-28 Thread Lyre
Hi all: Those patches fixed some minor mistakes, and added 3 functions for storage. Lyre (4): Comment: fix typo Storagepool: make flag for pool refresh optional Volume: add clone support Storage: add lookup functions src/libvirt-php.c | 110

[libvirt] [libvirt-php PATCH v2 1/4] Comment: fix typo

2011-03-28 Thread Lyre
--- src/libvirt-php.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 890b447..b43da7a 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -2704,7 +2704,7 @@ PHP_FUNCTION(libvirt_storagevolume_get_name) } /* -

[libvirt] [libvirt-php PATCH v2 4/4] Storage: add lookup functions

2011-03-28 Thread Lyre
--- src/libvirt-php.c | 64 + src/libvirt-php.h |2 + 2 files changed, 66 insertions(+), 0 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 6e8dea8..6ca7c50 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@

[libvirt] [libvirt-php] Add volume clone support

2011-03-26 Thread Lyre
New API: libvirt_storagevolume_create_xml_from () --- src/libvirt-php.c | 59 +++- src/libvirt-php.h |1 + 2 files changed, 58 insertions(+), 2 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 890b447..3179271 100644 ---

[libvirt] [libvirt-php] Add lookup function for pool volume

2011-03-26 Thread Lyre
--- src/libvirt-php.c | 66 + src/libvirt-php.h |2 + 2 files changed, 68 insertions(+), 0 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 3179271..5737163 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@

[libvirt] [libvirt-php] add get name and path for storage volume

2011-03-21 Thread Lyre
--- src/libvirt.c | 44 src/libvirt_php.h |2 ++ 2 files changed, 46 insertions(+), 0 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 1608774..3678974 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -90,6 +90,8 @@ static

Re: [libvirt] Question about PHP licencing for libvirt-php (php-libvirt for Fedora)

2011-03-10 Thread Lyre
On 03/10/2011 07:12 PM, Michal Novotny wrote: Well, I agree that LGPLv2+ license would be better. We need to wait for Lyre's and Radek's reply then. I agree with Radek: I prefer to use license that will allow widespread use of the project and ensure that if someone needs some additional

Re: [libvirt] [libvirt-php] docs: fixed uninitial private function name

2011-02-25 Thread Lyre
于 2011年02月25日 17:08, Michal Novotny 写道: On 02/25/2011 07:23 AM, Lyre wrote: * tools/generate-api-docs.c: add initialize for private function names --- tools/generate-api-docs.c | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/tools/generate-api-docs.c b/tools

Re: [libvirt] [libvirt-php] docs: fixed uninitial private function name

2011-02-25 Thread Lyre
Michal you may remvoe libvirt-php.spec form git, since it will be generated. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [libvirt-php 1/3] build: add error message

2011-02-25 Thread Lyre
* configure.ac: issue an error message when tools not found * libvirt-php.spec.in: add BuildRequires: libxslt --- configure.ac| 18 +++--- libvirt-php.spec.in |1 + 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index

Re: [libvirt] [libvirt-php 1/3] build: add error message

2011-02-25 Thread Lyre
oops! Just one patch, the other two are commit and revert. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [libvirt-php] docs: fixed uninitial private function name

2011-02-24 Thread Lyre
* tools/generate-api-docs.c: add initialize for private function names --- tools/generate-api-docs.c | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/tools/generate-api-docs.c b/tools/generate-api-docs.c index 322f3ef..8a16e22 100644 ---

[libvirt] Invitation to connect on LinkedIn

2011-02-23 Thread Lyre Li
LinkedIn I'd like to add you to my professional network on LinkedIn. - Lyre Lyre Li Engineer at Skybility China Confirm that you know Lyre Li https://www.linkedin.com/e/k4zv0-gkj412ae-3z/isd/2389916274/QzDJLaNZ/ -- (c) 2011, LinkedIn Corporation-- libvir-list mailing

[libvirt] [libvirt-php] add list function for storagepool

2011-02-23 Thread Lyre
* add libvirt_list_active_storagepools libvirt_list_inactive_storagepools * modified EXTRA_DIST for necessary files * generate libvirt-php.spec from .in file * bug fix for memeory leak --- Makefile.am |2 +- configure.ac|1 + libvirt-php.spec| 82

Re: [libvirt] [libvirt-php] About the inconsistency in libvirt-php

2011-02-22 Thread Lyre
From my understanding virConnectListActiveDomains() is listing all the active (running) domains and virConnectListDefinedDomains() is listing all the inactive domains that are defined since if we create a domain directly from XML, i.e. non-persistent, we have the domain in active domains list

[libvirt] [libvirt-php 1/1] storagepool: added apis for control and query

2011-02-22 Thread Lyre
Added the following functions for storagepool: * string libvirt_storagepool_get_uuid_string (resource $connection) return the uuid string or false on failure. * string libvirt_storagepool_get_name (resource $pool) return the name or false on failure. * resource

[libvirt] [libvirt-php 0/1] Added many apis for storagepool

2011-02-22 Thread Lyre
with some adjustment. Lyre (1): storagepool: added apis for control and query src/libvirt.c | 226 + src/php_libvirt.h | 13 +++ 2 files changed, 239 insertions(+), 0 deletions(-) -- libvir-list mailing list libvir-list@redhat.com https

Re: [libvirt] [libvirt-php 1/1] storagepool: added apis for control and query

2011-02-22 Thread Lyre
于 2011年02月22日 16:39, Michal Novotny 写道: On 02/22/2011 09:05 AM, Lyre wrote: Added the following functions for storagepool: * string libvirt_storagepool_get_uuid_string (resource $connection) return the uuid string or false on failure. * string libvirt_storagepool_get_name (resource $pool

Re: [libvirt] [libvirt-php] rewrite checking for libxml2

2011-02-21 Thread Lyre
I don't think you're supposed to inline pkg.m4 within aclocal... I didn't check it carefully. But it was generated by autoreconf -fi, I'm not quite sure what exactly it did. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [libvirt-php] rewrite checking for libxml2

2011-02-21 Thread Lyre
Right Daniel, thanks. I already did that. Noticed, please just ignore this patch. I'm adding prerequisite checks for awk pkg-config. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [libvirt-php] Fixed checking for libxml2 and prerequisites

2011-02-21 Thread Lyre
Repalced AM_PATH_XML2 with with the script borrowed from libvirt, which was borrowed from xmlsec. modified: configure.ac modified: src/Makefile.am --- configure.ac| 50 -- src/Makefile.am |4 ++-- 2 files changed, 50

Re: [libvirt] [libvirt-php] About the inconsistency in libvirt-php

2011-02-21 Thread Lyre
WARNING: In previous releases of libvirt-php, the function libvirt_list_defined_domains() was returning the wrong kind of information. It *should* have been showing all persistent domains, both active and inactive. However it was instead showing just

[libvirt] [libvirt-php] rewrite checking for libxml2

2011-02-20 Thread Lyre
Dropped the complex macro AM_PATH_XML2. * configure.ac: repalce the AM_PATH_XML2 with the script borrowed from libvirt, which was borrowed from xmlsec. * src/Makefile.am: changed XML_CPPFLAGS to XML_CFLAGS --- aclocal.m4 | 347 +--

[libvirt] [libvirt-php] About the inconsistency in libvirt-php

2011-02-20 Thread Lyre
Hi all: I noticed that there's some inconsistent behaviors in libvirt-php, and wondering what's the best way to handle them. In libvirt-php: libvirt_list_domains() returns an array of all domain resource; libvirt_list_active_domains() returns an array of running domain ids;

Re: [libvirt] [libvirt-php] About the inconsistency in libvirt-php

2011-02-20 Thread Lyre
On Mon, Feb 21, 2011 at 1:23 PM, Osier Yang jy...@redhat.com wrote: 于 2011年02月21日 10:50, Lyre 写道: Hi all: I noticed that there's some inconsistent behaviors in libvirt-php, and wondering what's the best way to handle them. In libvirt-php: libvirt_list_domains() returns an array of all

[libvirt] [libvirt-php 1/2] spec file cleanup

2011-02-18 Thread Lyre
From: Lyre 417...@gmail.com * libvirt-php.spec: removed unnecessary macro 0{%sles_version} --- libvirt-php.spec |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libvirt-php.spec b/libvirt-php.spec index 2c6292e..51a9add 100644 --- a/libvirt-php.spec +++ b/libvirt

[libvirt] [libvirt-php 0/2] Another update for building system

2011-02-17 Thread Lyre
Hi all: This patch updeted the building system. * Added necessary checkings in configure.ac * Cleared up libvirt-php.spec and src/Makefile.am BTW, I've changed my email to business address. Lyre (2): spec file cleanup Added checkings for tools and libraries aclocal.m4 | 189

[libvirt] [libvirt-php 2/2] Added checkings for tools and libraries

2011-02-17 Thread Lyre
* configure.ac: Added checkings for compiler, sed, install, and so on; Added AM_PATH_XML2 to check libxml2. * src/Makefile.am: dropped needless macros since it is done by autoconf; Use $INSTALL to install files rather than cp. --- aclocal.m4 | 189

Re: [libvirt] Mails rejected by mailist?

2011-02-15 Thread Lyre
Hi all: I've solved it, add those line in gitconfig: [sendemail] smtpencryption = tls smtpserver = smtp.gmail.com smtpuser = yourn...@gmail.com smtpserverport = 587 Thus git use gmail smtp to send the patches. -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [libvirt-php 0/3] Eliminated complilation warnings

2011-02-15 Thread Lyre
Hi all: These patch added the -Wall option for compiler, and eliminated all warnings. Lyre (3): Added -Wall option Fixed some compilation warnings Eliminated ununsed variables src/Makefile.am |4 +- src/libvirt.c | 65 +- 2

[libvirt] [libvirt-php 1/3] Added -Wall option

2011-02-15 Thread Lyre
* src/Makefile.am: added -Wall option in compling linking. --- src/Makefile.am |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 059de2c..67a0192 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -14,8 +14,8 @@ EXTRA_DIST =

[libvirt] [libvirt-php 3/3] Eliminated ununsed variables

2011-02-15 Thread Lyre
* src/libvirt.c: Eliminated unused variables. --- src/libvirt.c | 54 -- 1 files changed, 4 insertions(+), 50 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 524bb6f..54b1342 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@

Re: [libvirt] [libvirt-php 2/2] Added libvirt-php.obs.spec

2011-02-15 Thread Lyre
On Tue, Feb 15, 2011 at 6:42 PM, Daniel P. Berrange berra...@redhat.comwrote: On Tue, Feb 15, 2011 at 03:03:52PM +0800, Lyre wrote: * libvirt-php.obs.spec: this file should works for Fedora 14, openSuSE 11.3, and SLES 11 SP1 on openSuSE Build Service or localhost. * Makefile.am

Re: [libvirt] [libvirt-php 2/2] Added libvirt-php.obs.spec

2011-02-15 Thread Lyre
On Tue, Feb 15, 2011 at 7:48 PM, Justin Clift jcl...@redhat.com wrote: On 15/02/2011, at 10:35 PM, Lyre wrote: snip The problem was, I'm not quite sure what to do with this spec file. Currently, It may be better to name the spec file libvirt-php.spec. This spec file contains many

[libvirt] [libvirt-php] Merge rpm spec files

2011-02-15 Thread Lyre
Merge php-libvirt.spec libvirt-php.obs.spec to libvirt-php.spec, which will pack libvirt-php into two packages: libvirt-php: the extension itself with the configuration file. libvirt-php-doc: document package for libvirt-php This spec file should works for Fedora 14, RHEL 6,

[libvirt] Mails rejected by mailist?

2011-02-14 Thread Lyre
Hi all: I've tried to send a patch for libvirt-php using git send-email yesterday. My user.email is configured as a gmail address, that is this one. But git sent patches from local postfix. git CC the patchs to my gmail and I can revice it, but not listed on the maillist. Is it rejected by

Re: [libvirt] Mails rejected by mailist?

2011-02-14 Thread Lyre
On Tue, Feb 15, 2011 at 12:05 PM, Daniel Veillard veill...@redhat.comwrote: On Tue, Feb 15, 2011 at 11:36:44AM +0800, Lyre wrote: Hi all: I've tried to send a patch for libvirt-php using git send-email yesterday. My user.email is configured as a gmail address, that is this one

[libvirt] [libvirt-php 2/2] Added libvirt-php.obs.spec

2011-02-14 Thread Lyre
* libvirt-php.obs.spec: this file should works for Fedora 14, openSuSE 11.3, and SLES 11 SP1 on openSuSE Build Service or localhost. * Makefile.am: added EXTRA_DIST = libvirt-php.obs.spec --- Makefile.am |2 + aclocal.m4 |4 +- libvirt-php.obs.spec | 80

[libvirt] [libvirt-php 0/2] Updated building system

2011-02-14 Thread Lyre
Fixed the install location of libvirt-php.ini; Added an spec file for openSuSE Build Service. Lyre (2): Fixed the php configuration file Added libvirt-php.obs.spec Makefile.am |2 + aclocal.m4 |4 +- libvirt-php.obs.spec | 80

[libvirt] [libvirt-php 1/2] Fixed the php configuration file

2011-02-14 Thread Lyre
Install the libvirt-php.ini to a appropriate location. * src/Makefile.am: Set $PHPCDIR to the php configuration file directory, and replace $sysconfdir/php.d with $PHPCDIR. Added suffix .so in libvirt-php.ini. --- src/Makefile.am |7 --- 1 files changed, 4 insertions(+), 3

Re: [libvirt] fork of php-libvirt

2011-01-26 Thread Lyre
Hi all: I've added the documentation for the new APIs several days ago, but I've been busy these days and forget to inform Radek. So Radek, you may need to rebuild the documents. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] fork of php-libvirt

2011-01-26 Thread Lyre
On Thu, Jan 27, 2011 at 10:05 AM, Lyre 417...@gmail.com wrote: Hi all: I've added the documentation for the new APIs several days ago, but I've been busy these days and forget to inform Radek. So Radek, you may need to rebuild the documents. One more thing, I've deprecated the persistent

[libvirt] fork of php-libvirt

2010-12-28 Thread Lyre
I've added many APIs to php-libvirt, including network, node device, interface, and snapshot support. Unfortunately, I wasn't able to contact original author Radek, I really hope he can see this. So I forked it, the address is: https://github.com/4179e1/php-libvirt But there's something