Re: [Libvir] Question about specifications of virsh start

Thanks for answering. I understand as follows. - Libvirt cannot support a domain installed Para Virtualized Driver on Xen 3.0.3 . (because of the breakdown of Xen 3.0.3) Thanks, Masayuki Sunou In message [EMAIL PROTECTED] Re: [Libvir] Question about specifications of virsh start

Re: [Libvir] Question about specifications of virsh start

are installed in a domain. I think that there is only a method of changing XML to fix it, if libvirt supports starting of a domain which installed PV drivers. However, it is not a proper idea. Thanks, Masayuki Sunou In message [EMAIL PROTECTED] Re: [Libvir] Question about specifications of virsh

[Libvir] Question about specifications of virsh start

. Therefore virsh start cannot start correctly HVM domain installed Para Virtualized Driver. Could you teach why does libvirt disregard setting of configuration file and set type=ioemu ? Thanks, Masayuki Sunou. -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo

[Libvir] [PATCH] Fix parameter validation of virsh schedinfo

-- This patch fixes to become error when character string is set. Signed-off-by: Masayuki Sunou [EMAIL PROTECTED] Thanks, Masayuki Sunou. Index: src/virsh.c

[Libvir] [PATCH] Fix failure of virsh attach-disk (BZ346281)

given)') -- BZ346281 : https://bugzilla.redhat.com/show_bug.cgi?id=346281 This problem occurs because search of device ID of disk doesn't operate correctly. This patch fixes it. And this fixes a little comment too. Signed-off-by: Masayuki Sunou [EMAIL PROTECTED] Thanks, Masayuki Sunou. attach

Re: [Libvir] [PATCH] Fix failure of HVM domain definition on Xen 3.0.3 or earlier(BZ328841)

. Signed-off-by: Masayuki Sunou [EMAIL PROTECTED] Again this seems to change parsing of S-Expr input to accept an empty value. Could you explain what this patch does, i.e. what kind of input is being targetted and what is changed by the patch. This patch fixes to accept the following

Re: [Libvir] [PATCH] Fix failure of HVM domain definition on Xen 3.0.3or earlier(BZ328841)

Hi Would you give me a comment on this? Thanks, Masayuki Sunou In message [EMAIL PROTECTED] [Libvir] [PATCH] Fix failure of HVM domain definition on Xen 3.0.3or earlier(BZ328841) Masayuki Sunou [EMAIL PROTECTED] wrote: Hi VirDomainDefineXML() fails, when HVM domain using CD-ROM

[Libvir] [PATCH] Fix failure of HVM domain definition on Xen 3.0.3 or earlier(BZ328841)

by fixing this, the problem that the CD-ROM device is missed occurs. So, another patch (start.patch) fixes this problem. Signed-off-by: Masayuki Sunou [EMAIL PROTECTED] Thanks, Masayuki Sunou. define.patch Description: Binary data start.patch Description: Binary data -- Libvir-list mailing list

[Libvir] [PATCH] Fix return value of virsh vncdisplay

Hi Virsh vncdisplay always returns 1, because return value is not set in the case of normal end. # virsh vncdisplay test :0 # echo $? 1 This patch fixes it. Signed-off-by: Masayuki Sunou [EMAIL PROTECTED] Thanks

[Libvir] [PATCH] Delete a harmful variable in xend_parse_sexp_desc()

refers to an address unlike buf.contents As a result, a segmentation fault occurs. This patch fixes so that xend_parse_sexp_desc() uses buf.contents not ret. Signed-off-by: Masayuki Sunou [EMAIL PROTECTED] Thanks, Masayuki Sunou

[Libvir] [PATCH] Fix endless loop of VirBufferVSprintf()

())) So, virBufferEscapeString() has the same problem. This patch sets to virBufferGrow() the size of the data which VirBufferVSprintf()(virBufferEscapeString()) received when it is over 1000 bytes. Signed-off-by: Masayuki Sunou [EMAIL PROTECTED] Thanks, Masayuki Sunou

[Libvir] [PATCH] Cleanup xs_internal.c

Hi Blanks and Tabs coexist in xs_internal.c. This patch replaces a tab by blanks in xs_internal.c. Signed-off-by: Masayuki Sunou [EMAIL PROTECTED] Thanks, Masayuki Sunou. tab_to_space.patch Description: Binary data -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com

[Libvir] [PATCH] Fix some memory leaks in xs_internal.c

Hi Some memory releases is missed in xs_internal.c. This patch fixes it. Signed-off-by: Masayuki Sunou [EMAIL PROTECTED] Thanks, Masayuki Sunou. -- Index: src/xs_internal.c

[Libvir] [PATCH] Check a value in vshCommandOptInt()

the value in vshCommandOptInt(). Signed-off-by: Masayuki Sunou [EMAIL PROTECTED] Thanks, Masayuki Sunou. -- Index: src/virsh.c === RCS file: /data/cvs/libvirt/src

Re: [Libvir] [PATCH] Add the check of the format of MAC address on virsh attach-interface

. Thanks a lot for your fixing. Masayuki Sunou In message [EMAIL PROTECTED] Re: [Libvir] [PATCH] Add the check of the format of MAC address on virsh attach-interface Daniel Veillard [EMAIL PROTECTED] wrote: On Fri, Jul 13, 2007 at 02:24:01PM +0900, Masayuki Sunou wrote: Hi Even

Re: [Libvir] [PATCH] Add the check of the device source

Hi Dan Thank you for a reviewing. I understand your suggestion. - Libvirt should not check the device source path. - The device source path should be checked by the Xen hotplug scripts. I consider a fixing of Xen. Thefore, I decline applying this patch. Thanks, Masayuki Sunou. In message

[Libvir] [PATCH] Add the check of the format of MAC address on virsh attach-interface

Hi Even if specified MAC address is invalid, network interface is attached to the guest. And attached network interface cannot communicate. This patch checks the format of MAC address, and virsh become error when it is invalid. Signed-off-by: Masayuki Sunou [EMAIL PROTECTED] Thanks, Masayuki

[Libvir] [PATCH] Fix strange message on virsh attach-device

to attach device from test.xml -- This patch fixes it by not calling Xen in this case. Signed-off-by: Masayuki Sunou [EMAIL PROTECTED] Thanks, Masayuki Sunou

[Libvir] [PATCH] Fix memory leak on virDomainParseXMLDiskDesc()

Hi I found some memory leaks in xml.c -- Missing release of drvType and drvName in virDomainParseXMLDiskDesc(). This patch fixes it. Signed-off-by: Masayuki Sunou [EMAIL PROTECTED] Thanks, Masayuki Sunou. Index

[Libvir] [PATCH] Add the check of the device source

not be connected. Hotplug scripts not working.') -- This patch checks the existence of the device source path, and correct message is displayed in case of error. Signed-off-by: Masayuki Sunou [EMAIL PROTECTED] Thanks, Masayuki Sunou

Re: [Libvir] [PATCH] Do check the UUID in __virGetDomain()

(). This patch fixes virDomainFree() and virNetworkFree() which virsh.c misses the call. However, I detect the problem that resembles this happens in virt-manager, and I can not fix it. Therefore I register it to Bugziila. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246198 Thanks, Masayuki Sunou

Re: [Libvir] [PATCH] Do check the UUID in __virGetDomain()

that is called only from hash.c. Thanks Masayuki Sunou Index: src/hash.c === RCS file: /data/cvs/libvirt/src/hash.c,v retrieving revision 1.22 diff -u -p -r1.22

Re: [Libvir] [PATCH] Device attach/detach on virsh (command optionversion)

Hi Would you give me a comment on this patch? Thanks, Masayuki Sunou. In message [EMAIL PROTECTED] [Libvir] [PATCH] Device attach/detach on virsh (command optionversion) Masayuki Sunou [EMAIL PROTECTED] wrote: Hi This patch adds virsh attach-device/detach-device. This supports

[Libvir] [PATCH] Fix the check of cpumap in virsh vcpupin

Hi Because virsh vcpupin does not check a form of cpumap, when non-numerical letters are set, it does not become an error. This patch fixes it so that it become an error when non-numerical letters are set. Signed-off-by: Masayuki Sunou [EMAIL PROTECTED] Thanks, Masayuki Sunou

Re: [Libvir] [PATCH] Do check the UUID in __virGetDomain()

the missing of freeing the object one by one. Thanks, Masayuki Sunou In message [EMAIL PROTECTED] Re: [Libvir] [PATCH] Do check the UUID in __virGetDomain() Daniel P. Berrange [EMAIL PROTECTED] wrote: On Thu, Jun 07, 2007 at 03:03:11PM +0900, Masayuki Sunou wrote: Hi This patch adds

[Libvir] [PATCH] Do check the UUID in __virGetDomain()

as the domain that executed undefine. 5. Execute domuuid for the new domain This patch can fix it. Signed-off-by: Masayuki Sunou [EMAIL PROTECTED] Thanks, Masayuki Sunou. Index: src/hash.c

Re: [Libvir] [PATCH] Fix strange error message in virsh attach-device

the data with buf.content[0] = 0. use buf-use instead of strlen(buf.content) 2. This patch checks the data size with buf-use. Thanks, Masayuki Sunou. --- Index: src/xml.c

Re: [Libvir] [PATCH] Fix strange error message in virsh attach-device

Hi Daniel can you provide floppy.xml content too to test the problem ? I attach the XML file which I used by the test. Thanks, Masayuki Sunou. In message [EMAIL PROTECTED] Re: [Libvir] [PATCH] Fix strange error message in virsh attach-device Daniel Veillard [EMAIL PROTECTED] wrote

Re: [Libvir] [PATCH] Device attach/detach on virsh (command optionversion)

Hi Would you give me a comment on this patch? Thanks, Masayuki Sunou. In message [EMAIL PROTECTED] [Libvir] [PATCH] Device attach/detach on virsh (command optionversion) Masayuki Sunou [EMAIL PROTECTED] wrote: Hi This patch adds virsh attach-device/detach-device. This supports

Re: [Libvir] [PATCH] Fix value of XEN_V2_OP_SETMAXMEM

Hi Applied and commited, thanks ! This patch is not applied when I confirm the latest revision. (xen_internal.c 1.68) Please apply this? Thanks, Masayuki Sunou. In message [EMAIL PROTECTED] Re: [Libvir] [PATCH] Fix value of XEN_V2_OP_SETMAXMEM Daniel Veillard [EMAIL PROTECTED] wrote

[Libvir] [PATCH] Fix value of XEN_V2_OP_SETMAXMEM

. # virsh setmaxmem 0 921600 libvir: Xen error : failed Xen syscall ioctl 8518692 This patch sets the right value to XEN_V2_OP_SETMAXMEM. Signed-off-by: Masayuki Sunou [EMAIL PROTECTED] Thanks, Masayuki

[Libvir] [PATCH] Add the message when a little memory is set with setmaxmem.

. Signed-off-by: Masayuki Sunou [EMAIL PROTECTED] Thanks, Masayuki Sunou. Index: libvirt/src/virsh.c === RCS file: /data/cvs/libvirt/src/virsh.c,v

[Libvir] [PATCH] virsh vcpupin guards CPU not existing.

-by: Masayuki Sunou [EMAIL PROTECTED] Thanks, Masayuki Sunou. Index: src/virsh.c === RCS file: /data/cvs/libvirt/src/virsh.c,v retrieving revision 1.67 diff -u -p

[Libvir] [PATCH] Add error message to virsh setmem/setmaxmem

Hi Virsh setmem/setmaxmem doesn't output an error message when an invalid value is set to bytes. This patch outputs an error message, when an invalid value is set as bytes of virsh setmem/setmaxmem. Signed-off-by: Masayuki Sunou [EMAIL PROTECTED] Thanks, Masayuki Sunou. Index: src/virsh.c

Re: [Libvir] [PATCH] Enable USB device setting information handling on virsh.

Hi Daniel I contribute some corrected patches. 1. strtok() -- strtok_r() -- Add tok_buf for strtok_r() 2. Correct the first argument of strtok_r() 3. Add a version of XML -- So that the format of XML may change in the future Signed-off-by: Masayuki Sunou [EMAIL PROTECTED] Thanks

[Libvir] [PATCH] Enable USB device setting information handling on virsh.

Hi When domHVM started by virsh create, the information of USB setting is not saved by vish dumpxml. The reason is that USB setting is defined by Xen itself, not virsh. This patch enables USB device setting information handling on virsh create/virsh dumpxml. Signed-off-by: Masayuki Sunou

Re: [Libvir] [PATCH] check the maximum of virtual CPU

as a command of virsh? Or, is it used from virsh create and virsh start? Signed-off-by: Masayuki Sunou [EMAIL PROTECTED] Thanks -- In message [EMAIL PROTECTED] Re: [Libvir] [PATCH] check the maximum of virtual CPU Daniel P

Re: [Libvir] [RFC] Check host's minimum memory.

setmem 0 4096 --When I execute virsh setmem 0 256, the host doesn't stop. The setting is not effective in Xend. So, after investigating Xend, I report again. Thanks, Masayuki Sunou In message [EMAIL PROTECTED] Re: [Libvir] [RFC] Check host's minimum memory. Daniel P. Berrange [EMAIL

[Libvir] [RFC] Check host's minimum memory.

Hi The minimum value of the memory guarded with virsh setmem is 4096KB(4MB). In general, when host's memory is set to 4MB, the host stops. Therefore, I propose the patch to which host's minimum value of the memory is guarded by 256MB. Signed-off-by: Masayuki Sunou [EMAIL PROTECTED] Thanks

Re: [Libvir] [PATCH] check the maximum of virtual CPU

I removed a needless part from the former patch. Add check the maxmum of virtual CPU. Signed-off-by: Masayuki Sunou [EMAIL PROTECTED] Thanks --- Index: libvirt/include/libvirt/libvirt.h

Re: [Libvir] [PATCH] check the maximum of virtual CPU

. If you request, I am ready to repost it with split this patch. Signed-off-by: Masayuki Sunou [EMAIL PROTECTED] Thanks, Masayuki Sunou. libvirt-0.2.0 -- diff -uprN a/include/libvirt/libvirt.h b/include/libvirt/libvirt.h

Re: [Libvir] [PATCH] check the maximum of virtual CPU

in the future. Thanks, Masayuki Sunou. In message [EMAIL PROTECTED] Re: [Libvir] [PATCH] check the maximum of virtual CPU Richard W.M. Jones [EMAIL PROTECTED] wrote: Masayuki Sunou wrote: Hi The maximum of virtual CPU is not guarded in virsh setvcpus now. Then, when 32767 was set