The original implementation of the VMX config parser assumed that the
virtualHW.version would have more influence on the content of the VMX
file than it actually seems to have. It started with accepting only
version 4. Additonal versions were added later without any additional
changes in the
not that important. It should have
been that way from the beginning. Here's a patch for that:
https://www.redhat.com/archives/libvir-list/2014-May/msg00313.html
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
and fixing this problem. I've changed the two
mentioned things and pushed the patch.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
, send a patch for this.
To get your patch in, you need to send it to this list for review.
After a successful review it'll be pushed to the git repo by someone
with commit access.
See http://libvirt.org/hacking.html for more details about working on
the source and submitting patches.
--
Matthias
.
Although we're currently in feature freeze for the upcoming release
this week I pushed this one now as it cannot break anything and I
don't won't to hold back 5.5 support for another release cycle.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
I had the code in these two patches bascially sitting around since 2012,
yes 2012! But I never managed to get the code properly split into patches
and touched up good enough to post it here. This was also hindered by the
fact that I had no ESX test system at hand for the last year or so.
Dawid
..7b6b1a0 100644
--- a/src/esx/esx_driver.c
+++ b/src/esx/esx_driver.c
@@ -2,7 +2,7 @@
* esx_driver.c: core driver functions for managing VMware ESX hosts
*
* Copyright (C) 2010-2014 Red Hat, Inc.
- * Copyright (C) 2009-2013 Matthias Bolte matthias.bo...@googlemail.com
+ * Copyright (C) 2009
+++ b/src/esx/esx_stream.c
@@ -0,0 +1,478 @@
+/*
+ * esx_stream.c: libcurl based stream driver
+ *
+ * Copyright (C) 2012-2014 Matthias Bolte matthias.bo...@googlemail.com
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
that of which header list is currently in
use. Then esxVI_Context_Execute would only have to change the used
header list if the API version is different from the last call. The
header lists for the different API version would be created beforehand
and not in esxVI_Context_Execute.
--
Matthias
Using any of these chars [:*?|] in a filename is forbidden on
Windows and breaks git operations on Windows as git is not able
to create those files/directories on clone or pull.
Because some of them can be used in UNIX filenames they tend to
creep into filenames, especially : in PCI/SCSI device
After I fixed the first problem with a : in a filename a second
instance occured shortly afterwards. The first patch fixes this
problem and the second patch adds a syntax-check rule to prohibit
such Windows special chars in filenames.
Matthias
--
libvir-list mailing list
libvir-list@redhat.com
Windows doesn't allow : in filenames.
Commit 6fdece9a332fc668a89bde96af94e7b7cbf6750d added files with a : in
their names. This broke git operations on Windows as git is not able to
create those files on clone or pull.
Replace : with - in the offending filenames and adapt the test case.
As the
2014-03-29 15:09 GMT+01:00 Eric Blake ebl...@redhat.com:
On 03/29/2014 05:23 AM, Matthias Bolte wrote:
After I fixed the first problem with a : in a filename a second
instance occured shortly afterwards. The first patch fixes this
problem and the second patch adds a syntax-check rule
2014/1/22 Eric Blake ebl...@redhat.com:
On 01/22/2014 02:56 PM, Matthias Bolte wrote:
Windows doesn't allow : in filenames.
Neither does Linux, when targeting FAT file systems (although I pity
anyone trying to use git on a FAT mount point).
Commit 21685c955e546676a5b2a01f7b788d222e0ee0f5
for the
VirtualBox, HyperV ans Parallels hypervisor driver. Today those are
bundled under the URI of their hypervisor drivers: esx://, vbox://,
hyperv:// and parallels://. How does this workout with a URI per
subdriver?
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list
Windows doesn't allow : in filenames.
Commit 21685c955e546676a5b2a01f7b788d222e0ee0f5 added files with a : in
their names. This broke git operations on Windows as git is not able to
create those files on clone or pull.
Replace : with - in the offending filenames and adapt the test case.
---
with the
vbox_CAPI_v4_2.h
and vbox_CAPI_v4_3.h files which are bundled in libvirt source code. This is
why the
following patch adds vbox_CAPI_v4_2_20.h and vbox_CAPI_v4_3_4.h.
As stated by Matthias Bolte, the actual underlying problem here is that
libvirt assumes that VirtualBox API can only change
with the
vbox_CAPI_v4_2.h
and vbox_CAPI_v4_3.h files which are bundled in libvirt source code. This is
why the
following patch adds vbox_CAPI_v4_2_20.h and vbox_CAPI_v4_3_4.h.
As stated by Matthias Bolte, the actual underlying problem here is that
libvirt assumes that VirtualBox API can only change
correct solution would be to make VBOX_API_VERSION represent
the full API version number, instead of just the major and minor part.
This would fix the incorrect assumption in libvirt.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https
)))
+driver-type = i;
As a micro optimization you could break the loop once the type is found.
+}
+
ACK.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
to that message.
ACK.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
2013/9/20 Doug Goldstein car...@gentoo.org:
On Thu, Sep 19, 2013 at 1:48 PM, Matthias Bolte
matthias.bo...@googlemail.com wrote:
2013/9/19 Eric Blake ebl...@redhat.com:
On 09/19/2013 11:11 AM, varun bhatnagar wrote:
Hi,
I have started a virtual machine on my ESXi server. I was trying
to fix them first.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
2013/9/3 John Ferlan jfer...@redhat.com:
New coverity installation determined that the muliple if condition for
*Alloc and *AppendToList could fail during AppendToList thus leaking
memory.
---
src/esx/esx_vi.c | 14 ++
1 file changed, 14 insertions(+)
ACK.
--
Matthias Bolte
2013/9/3 John Ferlan jfer...@redhat.com:
New Coverity release found a couple of error paths where memory would be
leaked in an error/goto path before being properly handled.
---
src/esx/esx_driver.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
ACK.
--
Matthias Bolte
in addition to the existing checks.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
2013/8/9 Daniel P. Berrange berra...@redhat.com:
On Fri, Aug 09, 2013 at 06:08:38PM +0200, Matthias Bolte wrote:
2013/8/9 surf...@me.is-a-linux-user.org:
On Fri, Aug 09, 2013 at 10:13:03AM +0200, surf...@me.is-a-linux-user.org
wrote:
Hello
The version function is not supported
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/hyperv/hyperv_driver.c | 4 ++--
src/hyperv/hyperv_util.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
ACK.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https
, 42 insertions(+), 40 deletions(-)
ACK.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
as there is no VBoxXPCOMC.dll on
Windows and the XPCOM glue will never be compiled on Windows using the
Microsoft compiler. I have no clue about the __OS2__ check there.
The correct approach (assuming Cygwin comes with the required WinAPI
headers) would be to use src/vbox/vbox_MSCOMCGlue.c for Cygwin.
--
Matthias
2013/5/20 Eric Blake ebl...@redhat.com:
On 05/18/2013 04:03 PM, Matthias Bolte wrote:
VI objects support inheritance with subtype polymorphism. For example the
FileInfo object type is extended by FloppyImageFileInfo, FolderFileInfo
etc. Then SearchDatastore_Task returns an array of FileInfo
2013/5/19 Michal Privoznik mpriv...@redhat.com:
On 19.05.2013 00:01, Matthias Bolte wrote:
Got lost in commit e6ab10098066dd04794ff2ee5d10bc9b1db93327.
---
src/vmware/vmware_conf.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/vmware/vmware_conf.c b/src/vmware
2013/5/20 Daniel P. Berrange berra...@redhat.com:
On Sun, May 19, 2013 at 12:02:49AM +0200, Matthias Bolte wrote:
---
src/esx/esx_driver.c|8
src/esx/esx_network_driver.c|6 ++
src/esx/esx_storage_backend_iscsi.c |2 +-
src/esx
---
src/esx/esx_driver.c | 47 +++
1 file changed, 47 insertions(+)
diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c
index b23e7f6..f53b9c4 100644
--- a/src/esx/esx_driver.c
+++ b/src/esx/esx_driver.c
@@ -5211,6 +5211,52 @@ no_memory:
#undef
Got lost in commit e6ab10098066dd04794ff2ee5d10bc9b1db93327.
---
src/vmware/vmware_conf.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/vmware/vmware_conf.c b/src/vmware/vmware_conf.c
index 4b61a9c..6c24187 100644
--- a/src/vmware/vmware_conf.c
+++
Basically autotranslate VIR_DOMAIN_AFFECT_CURRENT to VIR_DOMAIN_AFFECT_LIVE.
Modification impact is handled lax anyway. There is no distinction between
a live and a stored config in the VMware world. A strict modification impact
handling would require to check the virtual machine state each time
---
src/esx/esx_driver.c|8
src/esx/esx_network_driver.c|6 ++
src/esx/esx_storage_backend_iscsi.c |2 +-
src/esx/esx_storage_backend_vmfs.c |4 ++--
src/esx/esx_util.c | 11 ---
src/esx/esx_vi.c|
VI objects support inheritance with subtype polymorphism. For example the
FileInfo object type is extended by FloppyImageFileInfo, FolderFileInfo
etc. Then SearchDatastore_Task returns an array of FileInfo objects and
depending on the represented file the FileInfo is actually a FolderFileInfo
or
---
src/esx/esx_driver.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c
index b55ef45..3962bf1 100644
--- a/src/esx/esx_driver.c
+++ b/src/esx/esx_driver.c
@@ -2187,6 +2187,27 @@ esxDomainSetMemory(virDomainPtr domain,
2013/5/16 Eric Blake ebl...@redhat.com:
On 05/15/2013 03:44 PM, Matthias Bolte wrote:
As the name parameter can be NULL the error message can only contain it
conditionally.
---
src/esx/esx_vi.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
ACK
Thanks, pushed
) {
-virReportOOMError();
-return NULL;
-}
+char *path;
+ignore_value(VIR_STRDUP_QUIET(path, datastorePath));
return path;
}
Why did you remove the OOM reporting here?
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https
As the name parameter can be NULL the error message can only contain it
conditionally.
---
src/esx/esx_vi.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/src/esx/esx_vi.c b/src/esx/esx_vi.c
index 5fd0693..d0df13d 100644
--- a/src/esx/esx_vi.c
+++
2013/5/2 Daniel P. Berrange berra...@redhat.com:
On Thu, May 02, 2013 at 04:03:33PM +0200, Christophe Fergeau wrote:
On Thu, May 02, 2013 at 03:29:47PM +0200, Matthias Bolte wrote:
The last time (like a year ago) I tried the Fedora MinGW build of
libvirt it just crashed on me and I
2013/5/2 Eric Blake ebl...@redhat.com:
On 05/01/2013 12:44 PM, Matthias Bolte wrote:
---
src/esx/esx_vi_generator.py | 430
---
1 file changed, 118 insertions(+), 312 deletions(-)
My python is weak, so I reviewed this by comparing the generated
:)
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
2013/5/2 Eric Blake ebl...@redhat.com:
On 05/02/2013 07:56 AM, Eric Blake wrote:
On 05/02/2013 07:09 AM, Matthias Bolte wrote:
2013/5/2 Eric Blake ebl...@redhat.com:
On 05/01/2013 12:44 PM, Matthias Bolte wrote:
---
src/esx/esx_vi_generator.py | 430
#
# Copyright (C) 2010-2012 Matthias Bolte matthias.bo...@googlemail.com
+# Copyright (C) 2013 Ata E Husain Bohra ata.hus...@hotmail.com
#
# This library is free software; you can redistribute it and/or
# modify it under the terms of the GNU Lesser General Public
@@ -785,9 +786,7
://libvirt.org/git/?p=libvirt.git;a=commit;h=466b306b3966f764ccce69c0315990ba44b544a6
So you are working with a code base that is at least 9 months old. I
suggest that you update your libvirt code base.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https
libvirtd is autospawned, but that should not be too much impact.
This will break Virtual Box support on Windows, because libvirtd
doesn't work on Windows yet.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo
---
src/esx/esx_vi_generator.py | 430 ---
1 file changed, 118 insertions(+), 312 deletions(-)
diff --git a/src/esx/esx_vi_generator.py b/src/esx/esx_vi_generator.py
index 7130624..547eef6 100755
--- a/src/esx/esx_vi_generator.py
+++
the issue.
Also see: https://communities.coverity.com/thread/2655
John
Thanks for figuring out the real cause.
But I still like the code simplification in my patch. So I changed the
commit message and pushed it.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list
2013/1/10 Eric Blake ebl...@redhat.com:
On 01/10/2013 02:48 PM, Matthias Bolte wrote:
Coverity tagged the esxhypervPrivate pointer a potentially leaked
You already fixed this typo..
because of the conditional free call. But this is a false positive,
there is not actual leak.
Avoid
://libvirt.org])
the second argument is the latest released version.
You can also use
git describe --abbrev=0
to get the latest tag, as released versions and release candidates are tagged.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https
of your suggestion.
I'll me come up with a patch for this later today.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
);
hypervFreeObject(priv, (hypervObject *)computerSystem);
+if (priv !conn-privateData)
+hypervFreePrivate(priv);
return result;
}
The same comment as for the ESX driver in this series applies here.
I'll come up with a patch for this later today.
--
Matthias Bolte
http
Coverity tagged the esxhypervPrivate pointer a potentially leaked
because of the conditional free call. But this is a false positive,
there is not actual leak.
Avoid the conditial code to make this more obvious to Coverity.
---
This patch is meant as a replacement for this patch
Commit 4445e16bfa8056980ac643fabf17186f9e685925 changed the signature
of esxConnectToHost and esxConnectToVCenter by replacing the esxPrivate
pointer with virConnectPtr. The esxPrivate pointer was then retrieved
again from virConnectPtr's privateData. This resulted in a NULL pointer
dereference,
2013/1/10 John Ferlan jfer...@redhat.com:
On 01/10/2013 10:49 AM, Matthias Bolte wrote:
2013/1/10 Eric Blake ebl...@redhat.com:
On 01/09/2013 07:54 AM, John Ferlan wrote:
Because result was used to determine whether or not to free 'priv'
resources Coverity tagged the code as having a resource
2013/1/10 Matthias Bolte matthias.bo...@googlemail.com:
2013/1/9 John Ferlan jfer...@redhat.com:
Because result was used to determine whether or not to free 'priv'
resources Coverity tagged the code as having a resource leak. This
change addresses that concern.
---
src/hyperv
2013/1/10 Matthias Bolte matthias.bo...@googlemail.com:
Coverity tagged the esxhypervPrivate pointer a potentially leaked
because of the conditional free call. But this is a false positive,
there is not actual leak.
I've fix the s/esxhypervPrivate/hypervPrivate/ typo in my local repo
??dcPath=ha-datacenter?dsName=xxx
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
are you trying to that
requires to serialize an AnyType directly instead of the specific
types?
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
/libvir-list
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
problems left. I fixed the minor things I mentioned,
made make syntax-check pass and pushed the result. Thanks!
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
mode 100644 src/esx/esx_storage_backend_vmfs.h
--
1.7.9.5
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com
complains about this.
Finally, ACK and to save yet another round trip I fixed all my
comments and pushed the result.
Sorry, for taking soo long to get progress on this and thanks for
keeping up with it :)
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
and path (if applicable).
iSCSI pools does not support operations such as: Create / remove pools
and volumes.
I don't have time for this one today anymore. I'll definitely come
back to it later this week.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list
2012/10/24 Eric Blake ebl...@redhat.com:
On 10/24/2012 01:33 PM, Matthias Bolte wrote:
Also remove warnings for upcoming versions. There hadn't been any
compatibility problems with new ESX version over the whole lifetime
of the ESX driver, so I don't expect any in the future.
Update
that is used in multiple
places in libvirt.
You're correct, in case of the ESX storage driver the free function
can be NULL because we don't need to cleanup the backend driver
pointer stored there when a _virStoragePool/Vol struct is free.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list
first API call.
+ *
+ * Returns 0 in case of success, -1 in case of error
+ */
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Currently virNetSocketNew fails because virSetCloseExec fails as there
is no proper implementation for it on Windows at the moment. Workaround
this by pretending that setting close-on-exec on the fd works. This can
be done because libvirt currently lacks the ability to create child
processes on
2012/10/9 Eric Blake ebl...@redhat.com:
On 10/06/2012 10:32 AM, Matthias Bolte wrote:
Traverse the whole inheritance hierarchy for dynamic dispatch as it is
already done for the dynamic cast.
Also make AnyType cast errors more verbose.
Reported by Ata Bohra.
---
src/esx
2012/10/9 Eric Blake ebl...@redhat.com:
On 10/09/2012 02:56 PM, Matthias Bolte wrote:
Currently virNetSocketNew fails because virSetCloseExec fails as there
is no proper implementation for it on Windows at the moment. Workaround
this by pretending that setting close-on-exec on the fd works
2012/10/8 Benjamin Wang (gendwang) gendw...@cisco.com:
-Original Message-
From: Matthias Bolte [mailto:matthias.bo...@googlemail.com]
Sent: 2012年10月7日 2:14
To: Benjamin Wang (gendwang)
Cc: Daniel P. Berrange; libvir-list@redhat.com; Yang Zhou (yangzho)
Subject: Re: [libvirt] Core
2012/10/8 Daniel P. Berrange berra...@redhat.com:
On Sat, Oct 06, 2012 at 08:10:07PM +0200, Matthias Bolte wrote:
curl_global_init is not thread-safe. curl_easy_init might call
curl_global_init when it was no called before. But curl_easy_init
can be called from different threads by the ESX
2012/10/1 Michal Privoznik mpriv...@redhat.com:
On 29.09.2012 22:17, Matthias Bolte wrote:
libcurl uses a SIGALRM in combination with sigsetjmp/siglongjmp to be
able to abort a DNS lookup when it takes too long. The problem with this
in a multi-threaded application is that the signal handler
didn't find the similar
core again. And it seems that everything works well. What do you mean stuck
in a DNS lookup?
B.R.
Benjamin Wang
-Original Message-
From: Matthias Bolte [mailto:matthias.bo...@googlemail.com]
Sent: 2012年9月30日 4:20
To: Benjamin Wang (gendwang)
Cc: libvir-list
Until now at least one tag subelement was required for a vlan element.
An optional trunk='yes' attribute can be used to indicate trunking of the
given tags.
This is not how VLAN tagging works with ESX. One can either specify a
single VLAN tag per virtual network or enable trunking for all
---
v2:
Utilize tag-less VLAN trunk mode:
https://www.redhat.com/archives/libvir-list/2012-October/msg00214.html
src/esx/esx_network_driver.c | 64 ++---
1 files changed, 59 insertions(+), 5 deletions(-)
diff --git a/src/esx/esx_network_driver.c
2012/9/30 Laine Stump la...@laine.org:
On 09/09/2012 04:44 AM, Matthias Bolte wrote:
---
v2: Use network level VLAN config if there is no portgroup specific VLAN
config given.
v3: Add ESX_VLAN_TRUNK define for magic number 4095
src/esx/esx_network_driver.c | 70
and
privateDataFreeFunc as given by the caller. virStoragePoolDispose and
virStorageVolDispose would call privateDataFreeFunc if set.
Comments?
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Traverse the whole inheritance hierarchy for dynamic dispatch as it is
already done for the dynamic cast.
Also make AnyType cast errors more verbose.
Reported by Ata Bohra.
---
src/esx/esx_vi_generator.py | 36
src/esx/esx_vi_types.c | 12
syntax-check and ensure that it passes.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
in a multithreaded
program. You must call curl_global_init explicitly.
And here's is a patch that does this.
https://www.redhat.com/archives/libvir-list/2012-October/msg00199.html
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https
curl_global_init is not thread-safe. curl_easy_init might call
curl_global_init when it was no called before. But curl_easy_init
can be called from different threads by the ESX driver. Therefore,
call curl_global_init from virInitialize to stop curl_easy_init from
calling it.
Reported by Benjamin
to detect this first.
Also, wasn't there a license problem with OpenSSL and the (L)GPL? Can
libvirt legally be used with a libcurl that is linked with OpenSSL?
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo
2012/9/10 Peter Krempa pkre...@redhat.com:
On 09/09/12 17:55, Matthias Bolte wrote:
Avoid requesting information such as identity or power state when it
is not necessary.
Lookup virtual machine list with the required fields (configStatus,
name, and config.uuid) to make
2012/9/9 Matthias Bolte matthias.bo...@googlemail.com:
---
v2: Use network level VLAN config if there is no portgroup specific VLAN
config given.
v3: Add ESX_VLAN_TRUNK define for magic number 4095
src/esx/esx_network_driver.c | 70
+++---
1
2012/9/10 Michal Privoznik mpriv...@redhat.com:
On 09.09.2012 17:42, Matthias Bolte wrote:
Use MATCH for all flags checks.
hypervMsvmComputerSystemToDomain expects the domain pointer to the
initialized to NULL.
All items in doms up to the count-th one are valid, no need to double
check
libcurl uses a SIGALRM in combination with sigsetjmp/siglongjmp to be
able to abort a DNS lookup when it takes too long. The problem with this
in a multi-threaded application is that the signal handler for SIGALRM
and the call to siglongjmp can be executed on a thread that is different
from the
handling might occur on the wrong thread.
But with CURLOPT_NOSIGNAL set to 1 the segfault is avoided but libcurl
might get stuck in a DNS lookup.
Are you able to reproduce this problem and can you confirm that
setting CURLOPT_NOSIGNAL to 1 fixes it?
--
Matthias Bolte
http://photron.blogspot.com
---
v2: Use network level VLAN config if there is no portgroup specific VLAN
config given.
v3: Add ESX_VLAN_TRUNK define for magic number 4095
src/esx/esx_network_driver.c | 70 +++---
1 files changed, 65 insertions(+), 5 deletions(-)
diff --git
Avoid requesting information such as identity or power state when it
is not necessary.
Lookup virtual machine list with the required fields (configStatus,
name, and config.uuid) to make esxVI_GetVirtualMachineIdentity work.
No need to call esxVI_GetNumberOfSnapshotTrees. rootSnapshotTreeList
can
---
I've pushed this one under the trivial rule.
src/esx/esx_driver.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c
index 28e2c65..991f03c 100644
--- a/src/esx/esx_driver.c
+++ b/src/esx/esx_driver.c
@@ -3363,7 +3363,6 @@
Use MATCH for all flags checks.
hypervMsvmComputerSystemToDomain expects the domain pointer to the
initialized to NULL.
All items in doms up to the count-th one are valid, no need to double
check before freeing them.
---
I could no runtime-test this because I've have trouble getting my
Hyper-V
2012/9/9 Matthias Bolte matthias.bo...@googlemail.com:
Avoid requesting information such as identity or power state when it
is not necessary.
Lookup virtual machine list with the required fields (configStatus,
name, and config.uuid) to make esxVI_GetVirtualMachineIdentity work.
No need
Avoid requesting information such as identity or power state when it
is not necessary.
Lookup virtual machine list with the required fields (configStatus,
name, and config.uuid) to make esxVI_GetVirtualMachineIdentity work.
No need to call esxVI_GetNumberOfSnapshotTrees. rootSnapshotTreeList
can
.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
.
+ * Copyright (C) 2010 Matthias Bolte matthias.bo...@googlemail.com
Put your copyright line here in the form of
Copyright (C) 2012 Ata E Husain Bohra your email address
instead of an author list on the end of the license statement.
+#include string.h
+#include stdio.h
+#include unistd.h
+#include
101 - 200 of 2383 matches
Mail list logo
