the backend structure to the storage
driver and moving the current driver code to its own backend. The
second patch for adding the new iSCSI backend.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
it to make it more clear.
Ah, okay. I wasn't aware of that. I don't have an iSCSI setup at hand
at the moment. So I cannot test how things work and need to rely on
your knowledge in this aspect.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https
aspects as
once :)
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
2012/8/20 Laine Stump la...@laine.org:
On 08/18/2012 07:46 AM, Matthias Bolte wrote:
---
src/esx/esx_network_driver.c | 38 +-
1 files changed, 33 insertions(+), 5 deletions(-)
diff --git a/src/esx/esx_network_driver.c b/src/esx/esx_network_driver.c
---
v2: Use network level VLAN config if there is no portgroup specific VLAN
config given.
src/esx/esx_network_driver.c | 65 ++---
1 files changed, 60 insertions(+), 5 deletions(-)
diff --git a/src/esx/esx_network_driver.c
---
src/esx/esx_network_driver.c | 38 +-
1 files changed, 33 insertions(+), 5 deletions(-)
diff --git a/src/esx/esx_network_driver.c b/src/esx/esx_network_driver.c
index 09d46d3..2f5f1ab 100644
--- a/src/esx/esx_network_driver.c
+++
?
Does it differ from the current code at all? If it differs is it that
different that we really need this radical split?
--
Matthias Bolte
http://photron.blogspot.com
Hi Matthias,
Below is my understanding as per the iSCSI operations mapping of vSphere
APIs and libvirt.
Storage Pool
2012/8/6 Michal Privoznik mpriv...@redhat.com:
On 05.08.2012 10:38, Matthias Bolte wrote:
The static deep copy allocates storage for the copy. The dynamic
version injected the dynamic dispatch after the allocation. This
triggered the invalid argument check in the dynamically dispatched
deep
2012/8/6 Michal Privoznik mpriv...@redhat.com:
On 05.08.2012 22:10, Matthias Bolte wrote:
Lists available PhysicalNic devices. A PhysicalNic is always active
and can neither be defined nor undefined.
A PhysicalNic is used to bridge a HostVirtualSwitch to the physical
network
2012/8/6 Michal Privoznik mpriv...@redhat.com:
On 05.08.2012 13:48, Matthias Bolte wrote:
esxVI_LookupHostSystemProperties guarantees that hostSystem is non-NULL.
Remove redundant NULL checks from callers.
Also prefer esxVI_GetStringValue over open-coding the logic.
---
src/esx
.
* src/xenxs/xenxs_private.h: Likewise.
* tests/storagebackendsheepdogtest.c: Likewise.
Reported by Matthias Bolte.
---
Almost qualifies for the build-breaker rule, except that I didn't
reproduce the particular configure settings that Matthias was
experiencing on IRC.
Fixes the problem, ACK
...@hotmail.com
CC: libvir-list@redhat.com
2012/8/5 Matthias Bolte matthias.bo...@googlemail.com:
2012/8/2 Ata E Husain Bohra ata.hus...@hotmail.com:
Add following routines to esx_interface_driver:
esxNumOfInterfaces,
esxNumOfDefinedInterfaces,
esxListInterfaces
of a libvirt network.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
The static deep copy allocates storage for the copy. The dynamic
version injected the dynamic dispatch after the allocation. This
triggered the invalid argument check in the dynamically dispatched
deep copy call. The deep copy function expects its dest parameter
to be a pointer to a NULL-pointer.
VMware ESX hosts
*
* Copyright (C) 2010-2012 Red Hat, Inc.
- * Copyright (C) 2009-2011 Matthias Bolte matthias.bo...@googlemail.com
+ * Copyright (C) 2009-2012 Matthias Bolte matthias.bo...@googlemail.com
* Copyright (C) 2009 Maximilian Wilhelm m...@rfc2324.org
*
* This library is free software
(C) 2010-2011 Red Hat, Inc.
- * Copyright (C) 2010 Matthias Bolte matthias.bo...@googlemail.com
+ * Copyright (C) 2010-2012 Matthias Bolte matthias.bo...@googlemail.com
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
/esx_network_driver.c
index 2e0e40b..b42f1d8 100644
--- a/src/esx/esx_network_driver.c
+++ b/src/esx/esx_network_driver.c
@@ -4,7 +4,7 @@
* host networks
*
* Copyright (C) 2010-2011 Red Hat, Inc.
- * Copyright (C) 2010 Matthias Bolte matthias.bo...@googlemail.com
+ * Copyright
network is
best represented by a HostVirtualSwitch and the HostPortGroups are
mapped to the portgroups of a libvirt virtual switch.
I'm sorry that I let you wait for quite a while now until I came to
this understanding that is contrary to your proposed interface driver.
--
Matthias Bolte
http
2012/8/5 Matthias Bolte matthias.bo...@googlemail.com:
2012/8/2 Ata E Husain Bohra ata.hus...@hotmail.com:
Add following routines to esx_interface_driver:
esxNumOfInterfaces,
esxNumOfDefinedInterfaces,
esxListInterfaces,
esxListDefinedInterfaces
with iSCSI?
Does it differ from the current code at all? If it differs is it that
different that we really need this radical split?
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
/esx/esx_vi_types.h | 29 ++
3 files changed, 87 insertions(+)
ACK, pushed, thanks.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
of a number. %d should be used here.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
and
esxVI_LookupPhysicalNicFromPortGroup) you're reporting an extra error
overwriting the original. probably more detailed error. You should
avoid this.
I still need to review this patch on the conceptual side, I'll
probably have time for this later this week.
--
Matthias Bolte
http
2012/7/24 Eric Blake ebl...@redhat.com:
On 07/21/2012 02:51 PM, Matthias Bolte wrote:
Print the actual unknown type name instead of other for AnyType objects.
---
src/esx/esx_vi.c |2 +-
src/esx/esx_vi_types.c | 36 +---
src/esx/esx_vi_types.h
in the vSphere API otherwise there will be
much more confusion.
Therefore,
esxVI_HostVirtualNic *virtualNicList = NULL;
should be
esxVI_HostVirtualNic *hostVirtualNicList = NULL;
Apart from that I'll do a more detailed review soon.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list
be check for NULL. But there is no need to
strdup it here as hostPath can just be stolen:
(*def)-src = hostPath;
hostPath = NULL;
ACK and pushed with the mentioned changes.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https
to avoid a warning about shadowing
a global before pushing.
ACK and pushed.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Print the actual unknown type name instead of other for AnyType objects.
---
src/esx/esx_vi.c |2 +-
src/esx/esx_vi_types.c | 36 +---
src/esx/esx_vi_types.h |1 +
3 files changed, 27 insertions(+), 12 deletions(-)
diff --git a/src/esx/esx_vi.c
improved this to report the actual type:
Call to esxVI_HostHostBusAdapter_CastFromAnyType for unexpected type
'HostBlockHba'
Here's the patch for this
https://www.redhat.com/archives/libvir-list/2012-July/msg01148.html
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
(_actual_type));
\
+return _error_return;
\
+}
+
No need for this extra copy of the ESX_VI__TEMPLATE__DISPATCH macro,
I'll remove it before pushing.
ACK and pushed, thanks.
--
Matthias Bolte
http
Hi,
do you have a patch that allows me to reproduce this problem? So I can
improve the error reporting here?
Regards,
Matthias
2012/7/18 Ata E Husain Bohra ata.hus...@hotmail.com:
Just want to drop this note, so no one else gets bother with my query. I was
able to find the reason and its
2012/6/17 Matthias Bolte matthias.bo...@googlemail.com:
I get the following error on Ubuntu 11.04 with current libvirt git HEAD:
$ make check
[...]
CC test-binary-io.o
test-binary-io.c: In function 'main':
test-binary-io.c:54:7: warning: implicit declaration of function
2012/7/18 Daniel P. Berrange berra...@redhat.com:
On Fri, Jul 13, 2012 at 02:00:19AM +0200, Matthias Bolte wrote:
Also ensure that the virBuffer used to store the downloaded data
does not overflow.
---
v3:
- Fix virBuffer limit checks.
v2:
- Ensure that the used virBuffer dos
It was broken since forever as it expected a libxml2
XML_ELEMENT_NODE containing a XML_TEXT_NODE instead of
just a XML_TEXT_NODE.
This problem was not discovered for so long because
esxVI_String_Deserialize was not used until now.
Reported by Ata Bohra
---
src/esx/esx_vi_types.c | 23
2012/7/19 Eric Blake ebl...@redhat.com:
On 07/18/2012 04:48 PM, Matthias Bolte wrote:
It was broken since forever as it expected a libxml2
XML_ELEMENT_NODE containing a XML_TEXT_NODE instead of
just a XML_TEXT_NODE.
This problem was not discovered for so long because
Also ensure that the virBuffer used to store the downloaded data
does not overflow.
---
v3:
- Fix virBuffer limit checks.
v2:
- Ensure that the used virBuffer dos not overflow.
src/esx/esx_driver.c |2 +-
src/esx/esx_vi.c | 62 +++--
2012/7/8 Doug Goldstein car...@gentoo.org:
On Sun, Jul 8, 2012 at 5:44 AM, Matthias Bolte
matthias.bo...@googlemail.com wrote:
Also ensure that the virBuffer used to store the downloaded data
does not overflow.
---
v2:
- Ensure that the used virBuffer dos not overflow.
src/esx
2012/7/3 Doug Goldstein car...@gentoo.org:
On Tue, Jul 3, 2012 at 3:17 PM, Matthias Bolte
matthias.bo...@googlemail.com wrote:
2012/7/3 Doug Goldstein car...@gentoo.org:
On Mon, Jul 2, 2012 at 4:44 PM, Matthias Bolte
matthias.bo...@googlemail.com wrote:
---
src/esx/esx_vi.c | 111
Also ensure that the virBuffer used to store the downloaded data
does not overflow.
---
v2:
- Ensure that the used virBuffer dos not overflow.
src/esx/esx_driver.c |2 +-
src/esx/esx_vi.c | 62 +++--
src/esx/esx_vi.h |3 +-
3 files
2012/7/3 Doug Goldstein car...@gentoo.org:
On Mon, Jul 2, 2012 at 4:44 PM, Matthias Bolte
matthias.bo...@googlemail.com wrote:
I started the download part and the stream driver quite a while ago
but stopped and put it aside as I realized that the storage volume
API up- and download functions
2012/7/3 Doug Goldstein car...@gentoo.org:
On Mon, Jul 2, 2012 at 4:44 PM, Matthias Bolte
matthias.bo...@googlemail.com wrote:
---
src/esx/esx_vi.c | 111
++
src/esx/esx_vi.h | 18 +
2 files changed, 129 insertions(+), 0
2012/7/3 Doug Goldstein car...@gentoo.org:
On Mon, Jul 2, 2012 at 4:44 PM, Matthias Bolte
matthias.bo...@googlemail.com wrote:
---
src/esx/esx_driver.c |2 +-
src/esx/esx_vi.c | 27 +--
src/esx/esx_vi.h |3 ++-
3 files changed, 28 insertions(+), 4
2012/7/3 Daniel P. Berrange berra...@redhat.com:
On Tue, Jul 03, 2012 at 09:51:52PM +0200, Matthias Bolte wrote:
2012/7/3 Doug Goldstein car...@gentoo.org:
On Mon, Jul 2, 2012 at 4:44 PM, Matthias Bolte
matthias.bo...@googlemail.com wrote:
I started the download part and the stream driver
---
src/esx/esx_vi.c | 111 ++
src/esx/esx_vi.h | 18 +
2 files changed, 129 insertions(+), 0 deletions(-)
diff --git a/src/esx/esx_vi.c b/src/esx/esx_vi.c
index 5b5ab69..48718b6 100644
--- a/src/esx/esx_vi.c
+++ b/src/esx/esx_vi.c
---
src/esx/esx_driver.c |2 +-
src/esx/esx_vi.c | 27 +--
src/esx/esx_vi.h |3 ++-
3 files changed, 28 insertions(+), 4 deletions(-)
diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c
index db2144c..95b9286 100644
--- a/src/esx/esx_driver.c
+++
--- /dev/null
+++ b/src/esx/esx_stream.c
@@ -0,0 +1,610 @@
+
+/*
+ * esx_stream.c: libcurl based stream driver
+ *
+ * Copyright (C) 2012 Matthias Bolte matthias.bo...@googlemail.com
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser
I started the download part and the stream driver quite a while ago
but stopped and put it aside as I realized that the storage volume
API up- and download functions assume one file per volume. This is a
problem with ESX as a VMDK can consist of two files. To solve this
now I added two new flags:
2012/6/30 Ata Bohra ata.hus...@hotmail.com:
Patch to add API to upload Volume contents using ESX driver. As stream
driver is not supported for ESX, I have used libcurl to transfer the volume,
second, using flags here to pass
file descriptor of the source file.
This might work for your testing
`main':
[...]/test-binary-io.c:54: undefined reference to `set_binary_mode'
collect2: ld returned 1 exit status
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
); is missing here.
+ VBOX_RELEASE(machine);
+ vboxIIDUnalloc(iid);
+ return ret;
+}
Tested and works. ACK.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
++
src/vbox/vbox_tmpl.c | 73
++
2 files changed, 123 insertions(+)
ACK, to this one to as it is just a short version of variant 1, so you
got to choose :)
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
2012/5/7 Michal Privoznik mpriv...@redhat.com:
On 06.05.2012 19:39, Matthias Bolte wrote:
Appending an item to a list transfers ownership of that item to the
list owner. But an error can occur in between item allocation and
appending it to the list. In this case the item has to be freed
Appending an item to a list transfers ownership of that item to the
list owner. But an error can occur in between item allocation and
appending it to the list. In this case the item has to be freed
explicitly. This was not done in some special cases resulting in
possible memory leaks.
Reported by
on
to fix the possible leak in the special error path.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Am 23. April 2012 18:48 schrieb Eric Blake ebl...@redhat.com:
On 04/23/2012 02:29 AM, Jean-Baptiste Rouault wrote:
On Sunday 22 April 2012 10:35:59 Matthias Bolte wrote:
vboxArray is not castable to a COM item type. vboxArray is a
wrapper around the XPCOM and MSCOM specific array handling
Am 22. April 2012 04:32 schrieb Eric Blake ebl...@redhat.com:
On 04/21/2012 11:11 AM, Matthias Bolte wrote:
virThreadSelf tries to access the virThreadPtr stored in TLS for the
current thread via TlsGetValue. When virThreadSelf is called on a thread
that was not created via virThreadCreate
vboxArray is not castable to a COM item type. vboxArray is a
wrapper around the XPCOM and MSCOM specific array handling.
In this case we can avoid passing NULL as an empty array to
IMachine::Delete by passing a dummy IMedium* array with a single
NULL item.
---
Jean-Baptiste, I can not reproduce
for the delayed response.
Thanks for debugging and reporting this problem.
ACK, I applied and pushed your patch.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
virThreadSelf tries to access the virThreadPtr stored in TLS for the
current thread via TlsGetValue. When virThreadSelf is called on a thread
that was not created via virThreadCreate (e.g. the main thread) then
TlsGetValue returns NULL as TlsAlloc initializes TLS slots to NULL.
virThreadSelf can
time to take care of this tomorrow, if nobody fixed it
before then.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
work by
accident on XPCOM because VirtualBox might not touch the pointer
beyond checking it for being non-NULL because the 0 tells it that it's
an empty array. But still this is wrong and might crash on MSCOM.
I might come up with a proper solution tomorrow.
--
Matthias Bolte
http
Am 19. April 2012 12:51 schrieb Jean-Baptiste Rouault
jean-baptiste.roua...@diateam.net:
On Wednesday 04 April 2012 17:56:12 Jean-Baptiste Rouault wrote:
On Monday 16 January 2012 11:34:53 Matthias Bolte wrote:
Okay, without looking deeper into this here are some ideas:
The XPCOM API
.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
---
ACK and pushed, thanks.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
decide to name the attribute units
(plural) instead of unit? As a value can only have one unit the
attribute name units is misleading.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
in the vmx2xml and xml2vmx tests to
cover this additions to the VMX parser before I can ACK it.
A good start but it needs a v2.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
2012/2/22 Jean-Baptiste Rouault jean-baptiste.roua...@diateam.net:
---
src/vmware/vmware_driver.c | 31 +++
1 files changed, 31 insertions(+), 0 deletions(-)
ACK.
This one is good and independent from the second patch, so I push it now.
--
Matthias Bolte
http
2012/2/22 Matthias Bolte matthias.bo...@googlemail.com:
And this needs extra testcases in the vmx2xml and xml2vmx tests to
cover this additions to the VMX parser before I can ACK it.
The test suite already has some actual in-the-wild ESX and GSX VMX
config files. I suggest you add some actual
2012/2/20 Eric Blake ebl...@redhat.com:
On 02/20/2012 02:38 PM, Matthias Bolte wrote:
Adding Expect: to the header list stops libcurl from sending a
Expect header at all.
Before, a dummy Expect header was added that might confuse HTTP
proxies and result in HTTP error code 417 being reported
Adding Expect: to the header list stops libcurl from sending a
Expect header at all.
Before, a dummy Expect header was added that might confuse HTTP
proxies and result in HTTP error code 417 being reported.
---
src/esx/esx_vi.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff
information?
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
for ESX and Hyper-V (assume the
drivers would support node devices yet) that might use different OUIs?
Or do I misunderstand this?
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
for information and cache nothing.
I'm not sure what's the best approach here.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
connection.
Try this instead
virsh -c hyperv://192.168.58.231/?transport=http
This sets the transport to HTTP and the port to 5985.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
can find libvirt-0.dll at all. It
needs to be in the PATH or in the working directory of you
application.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
of
libvirt.open(). openAuth() allows to pass credentials via a callback
mechanism.
There is a Python example in the libvirt codebase that does this, see
http://libvirt.org/git/?p=libvirt.git;a=blob;f=examples/python/esxlist.py
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list
on declaration, or put ret = 0
in an else branch here instead?
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
of caps.
I tested it with that fixed and it works.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
(pipe): '--dryrun -r -u
libvirt-----0123456789ab':
FAIL: virt-aa-helper-test
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
)
(xenDaemonSetSchedulerParameters): Likewise.
* src/lxc/lxc_driver.c (lxcSetSchedulerParametersFlags)
(lxcGetSchedulerParametersFlags): Likewise.
---
You missed the ESX allocation scheduler with reservation, limit and
shares parameters.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
some
uninitialized warnings only with -O2, while it doesn't warn with -O0.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Allow the datacenter and compute resource parts of the path
to be prefixed with folders. Therefore, the way the path is
parsed has changed. Before, it was split in 2 or 3 items and
the items' meanings were determined by their positions. Now
the path can have 2 or more items and the the vCenter
2011/11/1 Eric Blake ebl...@redhat.com:
On 11/01/2011 10:21 AM, Matthias Bolte wrote:
Allow the datacenter and compute resource parts of the path
to be prefixed with folders. Therefore, the way the path is
parsed has changed. Before, it was split in 2 or 3 items and
the items' meanings were
),
virtualHW_version);
goto cleanup;
Actually we're currently in feature freeze for libvirt 0.9.7, but as
this is a pure addition patch, that will not break existing code I
pushed it now. Also because I don't want to delay this for another
release cycle.
ACK, thanks.
--
Matthias
,
Daniel
Compiles fine on MinGW. I also did a quick test with VirtualBox 4.1 on
Windows and that works as well.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
This was fixed in be757a3f7baf93b for libvirt.c.
---
I'm pushing this one under the trivial rule.
python/libvirt-override-virStream.py |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/python/libvirt-override-virStream.py
b/python/libvirt-override-virStream.py
index
2011/7/21 Eric Blake ebl...@redhat.com:
On 07/21/2011 07:17 AM, Matthias Bolte wrote:
privP-session-error_description is a list and in order to get the
complete error message all parts of the list should be concatenated.
xenapiSessionErrorHandler does this when its third parameter is NULL
2011/6/14 Eric Blake ebl...@redhat.com:
On 06/07/2011 05:38 AM, Matthias Bolte wrote:
Shared folders are handled as filesystems and can also be hotplugged.
---
Currently this just maps shared folder to a filesystem element with type
mount. The filesystem element has an accessmode attribute
2011/10/25 Eric Blake ebl...@redhat.com:
On 10/23/2011 08:10 AM, Matthias Bolte wrote:
Deal with the incompatible changes in the VirtualBox 4.1 API.
INetworkAdapter has its different AttachTo* method replaced by
a settable attachmentType property.
The maximum number of network adapters
the same from the NWFilter's point-of-view then this needs to
be fixed to have NWFilter preserve the exact order of elements.
If it's the same then there's no problem here.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com
there is at least the
possibility to configure the different firewalls of different
hypervisors via libvirt.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
2011/10/19 David Stevens dlstev...@us.ibm.com:
-Matthias Bolte matthias.bo...@googlemail.com wrote: -
Well, you miss the point that nwfilters is meant as a general
firewall
interface. ebtables/iptables just happens to be an implementation of
this interface. Using ebtables/iptables
case, the function will return true
+ * even though the connection is not alive.
+ */
+ if (priv-client)
+ return 1;
+ else
+ return 0;
+}
This one is okay as is, I don't have a better suggestion at hand right now.
--
Matthias Bolte
http://photron.blogspot.com
2011/10/18 Matthias Bolte matthias.bo...@googlemail.com:
2011/10/12 Jiri Denemark jdene...@redhat.com:
---
Notes:
Version 3:
- no changes
Version 2:
- new patch
src/esx/esx_driver.c | 18 ++
src/hyperv/hyperv_driver.c | 18 ++
src
/esx_driver.c (esxDomainSnapshotNum)
(esxDomainSnapshotListNames, esxDomainSnapshotNumChildren)
(esxDomainSnapshotListChildrenNames): Pass new flag through.
---
Tested, works, ACK.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https
probably have a look at your pending ESX (and VBox?)
snapshot patches tomorrow.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
behavior.
Beyond that, anything you can add to automate regression testing would
probably be appreciated.
The website has a list about the different test suites
http://libvirt.org/testsuites.html
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
of a domain with many snapshots that we need to avoid
a recursive solution?
You already implemented vboxCountDescendants recursively, I'd suggest
to do the same here too.
I attached a patch to be applied on top of this one that does this and
works for me.
ACK with the attached patch applied.
--
Matthias
--
src/esx/esx_vi.h | 6 --
3 files changed, 33 insertions(+), 16 deletions(-)
Tested, works, ACK.
I also tested the case of deleting a root snapshot with multiple
children. Works as expected when you delete the root you got multiple
new roots.
--
Matthias Bolte
http
201 - 300 of 2383 matches
Mail list logo
