Re: [libvirt] [PATCHv2 18/27] xen: reject unknown flags

2011/7/14 Eric Blake ebl...@redhat.com: On 07/13/2011 06:59 AM, Matthias Bolte wrote: 2011/7/8 Eric Blake ebl...@redhat.com: @@ -1629,8 +1633,10 @@ xenDaemonDomainSave(virDomainPtr domain, const char *filename)  */  static int  xenDaemonDomainCoreDump(virDomainPtr domain, const char

Re: [libvirt] [PATCH 1/5] hyperv: Add configure check for OpenWSMAN

2011/7/13 Eric Blake ebl...@redhat.com: On 07/13/2011 01:01 PM, Matthias Bolte wrote: ---  configure.ac |   38 ++  1 files changed, 38 insertions(+), 0 deletions(-) I'd like to see the libvirt.spec.in changes from patch 2/5 squashed back into this patch

Re: [libvirt] [PATCH 2/5] hyperv: Add driver skeleton

2011/7/13 Eric Blake ebl...@redhat.com: On 07/13/2011 01:01 PM, Matthias Bolte wrote: ---  cfg.mk                               |    1 +  include/libvirt/virterror.h          |    1 +  libvirt.spec.in                      |    9 +++ +++ b/src/hyperv/hyperv_driver.h @@ -0,0 +1,29

[libvirt] [PATCH] xenapi: Improve error reporting in xenapiOpen

Use better suited error code and avoid NULL in error messsage as *privP-session-error_description can be NULL. --- src/xenapi/xenapi_driver.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/xenapi/xenapi_driver.c b/src/xenapi/xenapi_driver.c index

Re: [libvirt] [PATCH] build: check for virnetprotocol on-the-wire stability

mode 100644 src/virnetprotocol-structs Tested, works, ACK. -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] RFC: Implement virDomainGetIPAddress()

*devmac); First of all you're missing the unsigned int flags parameter. Also did you consider that the MAC to IP(v4|v6) mapping isn't necessarily a 1:1 mapping, but the signature of your function requires this? -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list

Re: [libvirt] [PATCH] xenapi: Improve error reporting in xenapiOpen

2011/7/14 Eric Blake ebl...@redhat.com: On 07/14/2011 08:59 AM, Matthias Bolte wrote: Use better suited error code and avoid NULL in error messsage as *privP-session-error_description can be NULL. ---  src/xenapi/xenapi_driver.c |    6 --  1 files changed, 4 insertions(+), 2 deletions

Re: [libvirt] [PATCH 1/3] command: introduce virPidWait, virPidAbort

            |   28  4 files changed, 146 insertions(+), 41 deletions(-) ACK. -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 3/3] virnetsocket: use new API for uniform child cleanup

+  1 files changed, 1 insertions(+), 12 deletions(-) ACK. -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 2/3] fdstream: avoid child process leak on error

2011/7/14 Eric Blake ebl...@redhat.com: On 07/14/2011 11:42 AM, Matthias Bolte wrote: 2011/7/12 Eric Blake ebl...@redhat.com: By requesting the pid in virCommandRunAsync, fdstream was claiming that it would manually wait for the process.  But on the failure path, the child process was being

Re: [libvirt] RFC: Implement virDomainGetIPAddress()

the difference between /proc/{PID}/net/arp and /proc/net/arp. Also as it's ARP it'll only work for IPv4. -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv2 01/27] maint: exclude more files from syntax check

patch  cfg.mk |   19 +--  1 files changed, 9 insertions(+), 10 deletions(-) Looks good and make syntax-check still passes, ACK. -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv2 02/27] maint: print flags in hex during debug

+-  9 files changed, 39 insertions(+), 24 deletions(-) flags_debug src/libvirt-qemu.c:117:VIR_DEBUG(conn=%p, pid=%u, flags=%u, conn, pid, flags); maint.mk: debug flag values with %x Dan commited this after you posted your series. So ACK with that new offender fix too. -- Matthias Bolte http

Re: [libvirt] [PATCHv2 04/27] libvirt-qemu: use unsigned flags

/qemu_protocol.x |    4 ++--  2 files changed, 3 insertions(+), 3 deletions(-) Should we have a syntax-check rule to enforce unsigned int flags in the RPC protocol like you added a rule to do this in the public API. ACK. -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list

Re: [libvirt] [PATCHv2 06/27] node_device: reject unknown flags

(udevNodeDrvOpen): Likewise. ---  src/node_device/node_device_driver.c |   18 +-  src/node_device/node_device_hal.c    |    4 +++-  src/node_device/node_device_udev.c   |    4 +++-  3 files changed, 19 insertions(+), 7 deletions(-) ACK. -- Matthias Bolte http://photron.blogspot.com

Re: [libvirt] [PATCHv2 05/27] util: reject unknown flags, and prefer unsigned flags

(virExecWithHook): Likewise. --- ACK. -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv2 07/27] storage: reject unknown flags

insertions(+), 27 deletions(-) ACK. -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv2 08/27] esx: reject unknown flags

if the domain is running ESX does a live migration always, so VIR_MIGRATE_LIVE has to passed too. ESX supports migration of inactive domains. It seems that migration in libvirt is only meant for active domains, but this isn't documented well. -- Matthias Bolte http://photron.blogspot.com -- libvir

Re: [libvirt] [PATCHv2 09/27] libxl: reject unknown flags

(+), 5 deletions(-) ACK. -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv2 10/27] lxc: reject unknown flags

that takes int, so rename this to cflags (in line with oflags and fflags) and keep it as int. ACK, with the clone flags as int. -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv2 11/27] openvz: reject unknown flags

2011/7/8 Eric Blake ebl...@redhat.com: * src/openvz/openvz_driver.c (openvzDomainReboot, openvzOpen): Reject unknown flags. ---  src/openvz/openvz_driver.c |    9 +++--  1 files changed, 7 insertions(+), 2 deletions(-) ACK. -- Matthias Bolte http://photron.blogspot.com -- libvir-list

Re: [libvirt] [PATCHv2 12/27] phyp: reject unknown flags

2011/7/8 Eric Blake ebl...@redhat.com: * src/phyp/phyp_driver.c (phypOpen, phypDomainReboot) (phypVIOSDriverOpen): Reject unknown flags. ---  src/phyp/phyp_driver.c |   12 +---  1 files changed, 9 insertions(+), 3 deletions(-) ACK. -- Matthias Bolte http://photron.blogspot.com

Re: [libvirt] [PATCHv2 13/27] qemu: reject unknown flags

|   16 +---  4 files changed, 45 insertions(+), 26 deletions(-) ACK. -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv2 14/27] test: reject unknown flags

; +    virCheckFlags(0, -1); testDomainCoreDump understands VIR_DUMP_CRASH. Don't get fooled by the ATTRIBUTE_UNUSED :) ACK, with testDomainCoreDump fixed. -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo

Re: [libvirt] [PATCHv2 15/27] uml: reject unknown flags

series for this pattern, here it's just the first time that I notice it. ACK, with that virCheckFlags loosened correctly. -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv2 16/27] vbox: reject unknown flags

, vboxDomainScreenshot): Likewise. ---  src/vbox/vbox_driver.c |    5 -  src/vbox/vbox_tmpl.c   |   44 +++-  2 files changed, 39 insertions(+), 10 deletions(-) ACK. -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list

Re: [libvirt] [PATCHv2 17/27] vmware: reject unknown flags

. -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv2 18/27] xen: reject unknown flags

VIR_MIGRATE_PAUSED -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv2 19/27] xenapi: reject unknown flags

, VIR_ERR_INTERNAL_ERROR, You found a bug, but made it worse instead of fixing it. xenapiDomainGetXMLDesc should pass the flags to virDomainDefFormat instead of passing 0. ACK, with passing flags to virDomainDefFormat instead of ignoring it. -- Matthias Bolte http://photron.blogspot.com -- libvir

Re: [libvirt] [PATCHv2 23/27] conf: prefer unsigned flags

, _virStream): Likewise. --- v2: new patch  src/conf/cpu_conf.c     |    6 +++---  src/conf/cpu_conf.h     |    6 +++---  src/conf/storage_conf.c |    4 ++--  src/datatypes.h         |    4 ++--  4 files changed, 10 insertions(+), 10 deletions(-) ACK. -- Matthias Bolte http://photron.blogspot.com

Re: [libvirt] [PATCHv2 20/27] virsh, daemon: prefer unsigned flags

2011/7/8 Eric Blake ebl...@redhat.com: * tools/virsh.c (vshCmdDef): Change flags type. * daemon/remote.c (remoteDispatchOpen): Likewise. --- v2: new patch  daemon/remote.c |    2 +-  tools/virsh.c   |    2 +-  2 files changed, 2 insertions(+), 2 deletions(-) ACK. -- Matthias Bolte http

Re: [libvirt] [PATCHv2 22/27] python: prefer unsigned flags

deletions(-) ACK. -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv2 21/27] node_device: avoid implicit int

+-  1 files changed, 29 insertions(+), 29 deletions(-) ACK. -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv2 25/27] conf: delete unused flags arguments

. -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv2 24/27] build: don't hand-roll cloexec code

with ifr.ifr_flags that is signed (actually it's a short). So I'd prefer renaming it to ifflags and keep it as int. ACK, with that questions/comments answered/addressed. -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo

Re: [libvirt] [PATCHv2 26/27] remote: prefer unsigned flags

2011/7/8 Eric Blake ebl...@redhat.com: * src/remote/remote_driver.c (call, remoteOpenSecondaryDriver): Prefer unsigned flags. --- v2: new patch  src/remote/remote_driver.c |    6 +++---  1 files changed, 3 insertions(+), 3 deletions(-) ACK. -- Matthias Bolte http://photron.blogspot.com

Re: [libvirt] [PATCHv2 27/27] build: add syntax check for proper flags use

?         virCommandAddArgFormat(cmd, %d, mode); Same comment applies here about mode and switching from %d to %o. ACK. -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv2 28/27] build: avoid ATTRIBUTE_UNUSED in headers

/xend_internal.c       |   12 +---  src/xenxs/xen_sxpr.c          |    5 ++---  src/xenxs/xen_sxpr.h          |    3 +--  7 files changed, 23 insertions(+), 19 deletions(-) ACK. -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https

[libvirt] [PATCH 4/5] hyperv: Add basic driver for Microsoft Hyper-V

/hyperv_util.c @@ -0,0 +1,129 @@ + +/* + * hyperv_util.c: utility functions for the Microsoft Hyper-V driver + * + * Copyright (C) 2011 Matthias Bolte matthias.bo...@googlemail.com + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General

[libvirt] [PATCH 0/5] Add basic driver for Microsoft Hyper-V (series version)

This is the series version of this patch https://www.redhat.com/archives/libvir-list/2011-July/msg00668.html Daniel suggested to split it for easier review. This series includes some small fixes for problem I noticed while splitting the original patch. Matthias -- libvir-list mailing list

[libvirt] [PATCH 1/5] hyperv: Add configure check for OpenWSMAN

--- configure.ac | 38 ++ 1 files changed, 38 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac index e9d5be4..d7ebe79 100644 --- a/configure.ac +++ b/configure.ac @@ -66,6 +66,7 @@ XMLRPC_REQUIRED=1.14.0 HAL_REQUIRED=0.5.0

[libvirt] [PATCH 5/5] hyperv: Add basic documentation

--- docs/drivers.html.in |1 + docs/drvhyperv.html.in | 103 docs/index.html.in |3 + docs/sitemap.html.in |4 ++ src/README |3 +- 5 files changed, 113 insertions(+), 1 deletions(-) create mode 100644

Re: [libvirt] [PATCH] Add basic driver for Microsoft Hyper-V

2011/7/12 Matthias Bolte matthias.bo...@googlemail.com: Domain listing, basic information retrieval and domain life cycle management is implemented. But currently the domian XML output lacks the complete devices section. The driver uses OpenWSMAN to directly communicate with an Hyper-V

[libvirt] [PATCH 3/5] hyperv: Add OpenWSMAN based client for the Hyper-V WMI API

--- /dev/null +++ b/src/hyperv/hyperv_wmi.c @@ -0,0 +1,684 @@ + +/* + * hyperv_wmi.h: general WMI over WSMAN related functions and structures for + * managing Microsoft Hyper-V hosts + * + * Copyright (C) 2011 Matthias Bolte matthias.bo...@googlemail.com + * Copyright (C) 2009 Michael

[libvirt] [PATCH 2/5] hyperv: Add driver skeleton

+ * Microsoft Hyper-V host devices + * + * Copyright (C) 2011 Matthias Bolte matthias.bo...@googlemail.com + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation

Re: [libvirt] [PATCH] esx: Fix a potential crash

. -- Matthias Bolte http://photron.blogspot.com From 556aa276640a8d562e953209e611747f62fd6713 Mon Sep 17 00:00:00 2001 From: Matthias Bolte matthias.bo...@googlemail.com Date: Tue, 12 Jul 2011 11:34:55 +0200 Subject: [PATCH] esx: Initialize all instances of esxVMX_Data to zero To avoid using

Re: [libvirt] [PATCHv2] remote/ssh: support for no_verify.

) ret = -1; #endif I'm also adding you to the authors list. -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] rpc: Fix compile error due to potentially unused parameter

connectDBus is only used if HAVE_DBUS is set. Therefore mark it as potentially unused. --- Pushed under the build-break rule. src/rpc/virnetserver.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/rpc/virnetserver.c b/src/rpc/virnetserver.c index 94d46f6..66edd11

Re: [libvirt] [PATCH] esx: Fix a potential crash

2011/7/12 Osier Yang jy...@redhat.com: 于 2011年07月12日 17:50, Matthias Bolte 写道: 2011/7/12 Osier Yangjy...@redhat.com: 于 2011年07月12日 16:58, Daniel Veillard 写道: On Tue, Jul 12, 2011 at 05:05:16PM +0800, Osier Yang wrote: Initialize ptr data.datastorePathWithoutFileName as NULL, otherwise

Re: [libvirt] Disk snapshot mode proposal: patch for storing the snapshot mode from .vmx to .xml

://libvirt.org/formatdomain.html#elementsDisks. I can do that as well. Best regards Oleh Paliy On 07/09/2011 09:52 AM, Matthias Bolte wrote: Anyway, you decided to add an snapshot_mode attribute to the disk element and exposed the VMX values there. I'm not sure that this is a good idea as scsi0:0

Re: [libvirt] [PATCH] Add domain type checking

2011/7/11 Daniel Veillard veill...@redhat.com: On Sat, Jul 09, 2011 at 03:38:32PM +0200, Matthias Bolte wrote: 2011/7/8 Eric Blake ebl...@redhat.com: On 07/08/2011 02:13 AM, Matthias Bolte wrote: The drivers were accepting domain configs without checking if those were actually meant

Re: [libvirt] [PATCH] Add domain type checking

2011/7/11 Eric Blake ebl...@redhat.com: On 07/11/2011 10:16 AM, Matthias Bolte wrote: My only regret here is that we can't really suggest the value expected because QEmu accepts more than one, but for other drivers we should be able to provide what type is expected. Yes, we can do

Re: [libvirt] 3/3 testsuite formatting bugs [was: [PATCH] Skip some xen tests if xend is not running]

2011/7/9 Eric Blake ebl...@redhat.com: On 07/08/2011 05:28 PM, Matthias Bolte wrote: From 79e8a7e876722a67c37d930762e7a8b32701c6ca Mon Sep 17 00:00:00 2001 From: Matthias Bolte matthias.bo...@googlemail.com Date: Sat, 9 Jul 2011 01:24:44 +0200 Subject: [PATCH] tests: Use EXIT_AM_SKIP instead

Re: [libvirt] 1/3 testsuite formatting bugs [was: [PATCH] Skip some xen tests if xend is not running]

; then +      for i in `seq $mod 39`       do         printf can portably be replaced by: printf %${len}s with len computed via expr. Yes, that approach is nicer and also the logic it a bit simpler. Here's a v2. -- Matthias Bolte http://photron.blogspot.com From

Re: [libvirt] testsuite formatting bugs [was: [PATCH] Skip some xen tests if xend is not running]

2011/7/9 Eric Blake ebl...@redhat.com: On 07/08/2011 05:28 PM, Matthias Bolte wrote: TEST: virsh-all       40       80       120

Re: [libvirt] [PATCH] Add domain type checking

2011/7/8 Eric Blake ebl...@redhat.com: On 07/08/2011 02:13 AM, Matthias Bolte wrote: The drivers were accepting domain configs without checking if those were actually meant for them. For example the LXC driver happily accepts configs with type QEMU. For convenience add an optional check

Re: [libvirt] 1/3 testsuite formatting bugs [was: [PATCH] Skip some xen tests if xend is not running]

2011/7/9 Eric Blake ebl...@redhat.com: On 07/09/2011 02:44 AM, Matthias Bolte wrote: Yes, that approach is nicer and also the logic it a bit simpler. Here's a v2. -- Matthias Bolte http://photron.blogspot.com Subject: [PATCH] tests: Fix compressed test output padding logic The current

Re: [libvirt] 2/3 testsuite formatting bugs [was: [PATCH] Skip some xen tests if xend is not running]

2011/7/9 Eric Blake ebl...@redhat.com: On 07/09/2011 03:51 AM, Matthias Bolte wrote: Here's a v2 that does this. -- Matthias Bolte http://photron.blogspot.com Subject: [PATCH] tests: Improve output of tests that decide to skip at runtime Don't print OK/FAIL for test that decide

Re: [libvirt] [PATCH] vbox: Fix logic in storage driver open function

2011/7/7 Eric Blake ebl...@redhat.com: On 07/07/2011 01:24 AM, Matthias Bolte wrote: If the main driver is the vbox driver, then the open function has to return an error if the private data is invalid. ---  src/vbox/vbox_tmpl.c |    7 ++-  1 files changed, 2 insertions(+), 5 deletions

Re: [libvirt] 1/3 testsuite formatting bugs [was: [PATCH] Skip some xen tests if xend is not running]

ACK, to you're equation (but without special casing 0) as I already pushed my patch. -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Disk snapshot mode proposal: patch for storing the snapshot mode from .vmx to .xml

-persistent. -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH V2] Do not drop kernel cmdline for xen pv domains

=8,1280,1024 /cmdline Are the leading and trailing spaces essential? If not I'd suggest to remove them. -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] Add domain type checking

The drivers were accepting domain configs without checking if those were actually meant for them. For example the LXC driver happily accepts configs with type QEMU. For convenience add an optional check for the domain type for the virDomainDefParse* functions. It's optional because in some places

Re: [libvirt] [PATCH] Define remote wire protocol impls for virDomainQemuAttach

+--  3 files changed, 22 insertions(+), 3 deletions(-) ACK. -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Don't exist if the libvirtd config does not exist

again. -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] rpc: Fix whitespace problem in generated code

Add missing line break and fix indention level. Reported by Cole Robinson. --- Pushing this under the trivial rule. src/rpc/gendispatch.pl |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/rpc/gendispatch.pl b/src/rpc/gendispatch.pl index 027560c..c69c5a2

Re: [libvirt] [PATCH 00/20] flags cleanup

connection as you made esxOpen reject VIR_CONNECT_RO. Yes, the ESX driver has no means to support a truly read-only connection as you always need to provide credentials, so one can consider this a bugfix or a regression depending on the point-of-view. -- Matthias Bolte http://photron.blogspot.com

[libvirt] [PATCH] python: Fix bogus label placement

--- python/libvirt-override.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/python/libvirt-override.c b/python/libvirt-override.c index 8be9af7..2b88796 100644 --- a/python/libvirt-override.c +++ b/python/libvirt-override.c @@ -1489,13 +1489,12 @@

[libvirt] [PATCH] vbox: Fix logic in storage driver open function

If the main driver is the vbox driver, then the open function has to return an error if the private data is invalid. --- src/vbox/vbox_tmpl.c |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c index 37fe248..dfa676e 100644

[libvirt] [PATCH] Remove duplicate empty lines and correct indentation and style

No functional change included. --- python/libvirt-override.c |1 - src/conf/domain_conf.c|1 - src/conf/interface_conf.c |1 - src/conf/network_conf.c |1 - src/conf/node_device_conf.c |4 -

Re: [libvirt] [PATCHv3] build: fix virBufferVasprintf on mingw

that the snprintf module will always guarantee the constraints needed by libintl. Also, we want to guarantee that strdup sets errno on failure. * .gnulib: Update to latest, for vsnprintf fix. * bootstrap.conf (gnulib_modules): Add vsnprintf, strdup-posix. Reported by Matthias Bolte. --- v3: more gnulib

Re: [libvirt] [PATCH 03/20] drivers: prefer unsigned int for flags

of several functions at the time I wrote the driver. -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Fix compilation error when SASL support is disabled

virnetsaslcontext.h unconditional. So this patch is correct and necessary. I've pushed it. -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] libvirt 0.9.3, missing header

/a/ports/devel/libvirt/work/libvirt-0.9.3' gmake: *** [all] Error 2 *** Error code 1 Any ideas? Thanks, Jason I think this patch, that I've just pushed, from Jean-Baptiste will fix your problem https://www.redhat.com/archives/libvir-list/2011-July/msg00188.html -- Matthias Bolte http

Re: [libvirt] [PATCH] nodedev: Let check_fc_host_linux report errors to the caller

2011/7/6 Eric Blake ebl...@redhat.com: On 07/05/2011 03:59 PM, Matthias Bolte wrote: ---  src/node_device/node_device_linux_sysfs.c |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/node_device/node_device_linux_sysfs.c b/src/node_device/node_device_linux_sysfs.c

Re: [libvirt] [PATCH] Fix return value semantic of virFileMakePath

2011/7/6 Eric Blake ebl...@redhat.com: On 07/05/2011 03:04 PM, Matthias Bolte wrote: Some callers expected virFileMakePath to set errno, some expected it to return an errno value. Unify this to return 0 on success and -1 on error. Set errno to report detailed error information. Also Make

Re: [libvirt] [PATCH] util: close the ioctl socket at the end of if(Get|Set)MacAddress

) == 0 ? 0 : errno; + +err_exit: +    VIR_FORCE_CLOSE(fd); +    return rc;  } HACKING suggests to call the label cleanup instead of err_exit in both functions. ACK, with the labels renamed. -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH] apparmor: Finish incomplete renaming of relabel to norelabel

Commit 693eac388f1759d was incomplete here. --- Pushing this under the build-breaker rule. src/security/security_apparmor.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/security/security_apparmor.c b/src/security/security_apparmor.c index 76c6e3d..6dfe8c9 100644

[libvirt] [PATCH] Reduce code duplication in virFileMakePath(Helper)

Move stat and mkdir to virFileMakePathHelper. Also use the stat result to detect whether the existing path is a directory and set errno accordingly if it's not. --- src/util/util.c | 44 ++-- 1 files changed, 14 insertions(+), 30 deletions(-) diff --git

Re: [libvirt] [PATCH] util: rename err_exit to cleanup in interface.c

2011/7/6 Laine Stump la...@laine.org: This brings it in line with the recommendations in HACKING. ---  src/util/interface.c |   36 ++--  1 files changed, 18 insertions(+), 18 deletions(-) ACK. -- Matthias Bolte http://photron.blogspot.com -- libvir-list

Re: [libvirt] [PATCH] Reduce code duplication in virFileMakePath(Helper)

2011/7/6 Eric Blake ebl...@redhat.com: On 07/06/2011 07:47 AM, Matthias Bolte wrote: Move stat and mkdir to virFileMakePathHelper. Also use the stat result to detect whether the existing path is a directory and set errno accordingly if it's not. ---  src/util/util.c |   44

Re: [libvirt] Duplicate symbol error with 0.9.3 on OSX

2011/7/5 Justin Clift jcl...@redhat.com: On 05/07/2011, at 1:23 AM, Matthias Bolte wrote: 2011/7/4 Justin Clift jcl...@redhat.com: Just went to update the OSX libvirt build for 0.9.3, but it's giving a duplicate symbol error:  ld: duplicate symbol _virNetworkDNSHostsDef in ./.libs

Re: [libvirt] [PATCH] qemu: Fix virFileMakePath error handling in snapshot creation

2011/7/4 Osier Yang jy...@redhat.com: 于 2011年07月04日 16:50, Matthias Bolte 写道: virFileMakePath returns an errno value on error, that will never be negative. So a virFileMakePath error whould have been ignored here. s/whould/should/ No. Actually the typo is s/whould/would/, because an error

Re: [libvirt] networkxml2argvtest fails to compile

The attached patch fixes this. -- Matthias Bolte http://photron.blogspot.com 0001-tests-Disable-networkxml2argvtest-when-configured-wi.patch Description: application/mbox -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 2/8] Define remote wire protocol impls for virDomainQemuAttach

= {     .domainRevertToSnapshot = remoteDomainRevertToSnapshot, /* 0.8.0 */     .domainSnapshotDelete = remoteDomainSnapshotDelete, /* 0.8.0 */     .qemuDomainMonitorCommand = remoteQemuDomainMonitorCommand, /* 0.8.3 */ +    .qemuDomainAttach = remoteQemuDomainAttach, /* 0.9.3 */ s/0.9.3/0.9.4/ -- Matthias Bolte http

Re: [libvirt] [PATCH 3/8] Add a new 'virsh qemu-attach' command.

/tools/virsh.c @@ -11611,6 +11611,52 @@ cleanup:     return ret;  } +/* + * qemu-attach command + */ +static const vshCmdInfo info_qemu_attach[] = { +    {help, N_(Qemu Attach)}, +    {desc, N_(Qemu Attach)}, Below you replaced Qemu with QEMU, but here you use Qemu. ACK. -- Matthias

Re: [libvirt] [PATCH 4/8] Keep pidfile path in qemuDomainObjPrivate struct

++---  src/util/util.h          |    2 ++  5 files changed, 49 insertions(+), 27 deletions(-) ACK. -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 5/8] Change extract pidfile monitor config from QEMU command line

); ACK. -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 6/8] Add a method for extracting QEMU argv from /proc

QEMU config from  argv in /proc, given a PID number ---  src/qemu/qemu_command.c |  106 +++  src/qemu/qemu_command.h |    5 ++  2 files changed, 111 insertions(+), 0 deletions(-) ACK. -- Matthias Bolte http://photron.blogspot.com -- libvir-list

Re: [libvirt] [PATCH 8/8] Implement code to attach to external QEMU instances.

. -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] networkxml2argvtest fails to compile

2011/7/5 Osier Yang jy...@redhat.com: On 07/05/2011 06:45 PM, Matthias Bolte wrote: 2011/7/5 Ruben Kerkhof ru...@rubenkerkhof.com: Hi all, Building libvirt 0.9.3 from source with --without-network, make check fails with: CC     networkxml2xmltest.o  CCLD   networkxml2xmltest  CC

[libvirt] [PATCH] Fix usage of virFileMakePath, it doesn't set errno but returns it

Also be explicity about the != 0 check in the few places that weren't. --- src/conf/domain_conf.c |6 +++--- src/conf/network_conf.c |2 +- src/conf/nwfilter_conf.c |4 ++-- src/conf/storage_conf.c |2 +- src/libxl/libxl_driver.c | 20 ++--

[libvirt] [PATCH] Fix return value semantic of virFileMakePath

Some callers expected virFileMakePath to set errno, some expected it to return an errno value. Unify this to return 0 on success and -1 on error. Set errno to report detailed error information. Also Make virFileMakePath report an error when stat fails with an errno different from ENOENT. ---

Re: [libvirt] [PATCH] Fix usage of virFileMakePath, it doesn't set errno but returns it

2011/7/5 Eric Blake ebl...@redhat.com: On 07/05/2011 08:00 AM, Matthias Bolte wrote: Also be explicity about the != 0 check in the few places that weren't. s/explicity/explicit/ ---  src/conf/domain_conf.c       |    6 +++---  src/conf/network_conf.c      |    2 +-  src/conf

[libvirt] [PATCH] nodedev: Let check_fc_host_linux report errors to the caller

--- src/node_device/node_device_linux_sysfs.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/node_device/node_device_linux_sysfs.c b/src/node_device/node_device_linux_sysfs.c index 4f4acc7..34e4501 100644 --- a/src/node_device/node_device_linux_sysfs.c +++

Re: [libvirt] [PATCH] build: work around older systemtap header

VIR_ADD_CAST(a) ((void *)(intptr_t)(a)) Is this really true? What about a long long value (64bit) on a 32bit platform? intptr_t and void* are only 32bit on a 32bit platform, aren't they? -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https

Re: [libvirt] [PATCH] storage: Do not override the exact error of createRawFile

also fixing the usage of the wrong value for the errno parameter of virReportSystemError by removing that call. It should have been -ret instead of -fd, that's why you see this large number in the overwriting error that is the result of an overflow. ACK. -- Matthias Bolte http

[libvirt] [PATCH] qemu: Fix virFileMakePath error handling in snapshot creation

virFileMakePath returns an errno value on error, that will never be negative. So a virFileMakePath error whould have been ignored here. --- src/qemu/qemu_driver.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index

Re: [libvirt] [PATCH] Quieten build ensure API build scripts exit with non-zero status

. -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] remote/ssh: support for no_verify.

of the noTTY option. The patch looks okay, but is incomplete. It needs to mention that no_verify now works for ssh too in docs/remote.html.in and virnetsockettest.c needs an additional test case for ssh+no_verify like the test case for shh+no_tty (SSH test 2). -- Matthias Bolte http

<    1   2   3   4   5   6   7   8   9   10   >