2011/6/6 Eric Blake ebl...@redhat.com:
Detected by Coverity. Bug introduced in commit 9d73efd (v0.8.8).
* src/qemu/qemu_hotplug.c (qemuDomainChangeGraphics): Don't report
error on success.
ACK.
Matthias
--
libvir-list mailing list
libvir-list@redhat.com
2011/6/6 Eric Blake ebl...@redhat.com:
As long as I was already touching the function...
* src/qemu/qemu_hotplug.c (qemuDomainChangeGraphics): Line wrap.
---
src/qemu/qemu_hotplug.c | 46 ++
1 files changed, 30 insertions(+), 16 deletions(-)
2011/6/6 Eric Blake ebl...@redhat.com:
Detected by Coverity. Commit ef21beda was incomplete; it solved
a leak one one path, but not on the other.
* daemon/libvirtd.c (qemudSetLogging): Avoid leak on success.
---
How embarrassing that I was just barely fixing a leak of the
same variable in
@@
/*
* esx_vi.c: client for the VMware VI API 2.5 to manage ESX hosts
*
- * Copyright (C) 2010 Red Hat, Inc.
+ * Copyright (C) 2010-2011 Red Hat, Inc.
* Copyright (C) 2009-2011 Matthias Bolte matthias.bo...@googlemail.com
*
* This library is free software; you can redistribute
2011/6/7 Ruben Kerkhof ru...@rubenkerkhof.com:
Hi all,
./configure --without-vbox
make
make check
produces on my F-13 and F-15 machines.
make[1]: Entering directory `/home/ruben/src/libvirt/tests'
make virshtest conftest sockettest nodeinfotest qparamtest virbuftest
commandtest
2011/6/6 Daniel P. Berrange berra...@redhat.com:
On Sun, Jun 05, 2011 at 10:10:08AM +0200, Matthias Bolte wrote:
Annotate the ESX device driver dummy.
Refactor the udev and hal device driver strcuts to match the
common annotation pattern.
---
This is post-0.9.2.
docs/hvsupport.pl
virGetVersion itself doesn't take a virConnectPtr, but in order to obtain
the hypervisor version against which libvirt was compiled it is used in
combination with virConnectGetType like this:
hvType = virConnectGetType(conn)
virGetVersion(libVer, hvType, typeVer)
When virConnectGetType is called
---
src/esx/esx_interface_driver.c |6 +++---
src/esx/esx_network_driver.c |6 +++---
src/esx/esx_nwfilter_driver.c |6 +++---
src/esx/esx_secret_driver.c|6 +++---
src/esx/esx_storage_driver.c |2 +-
5 files changed, 13 insertions(+), 13 deletions(-)
diff --git
Annotate the ESX device driver dummy.
Refactor the udev and hal device driver strcuts to match the
common annotation pattern.
---
This is post-0.9.2.
docs/hvsupport.pl| 22 +
src/esx/esx_device_monitor.c | 15 ++-
2011/6/4 Daniel Veillard veill...@redhat.com:
On Fri, Jun 03, 2011 at 10:10:58AM -0600, Eric Blake wrote:
This commit is safe precisely because there has been no release
for any of the enum values being deleted (they were added post-0.9.1).
After the 0.9.2 release, we can then take advantage
2011/6/4 Richard Laager rlaa...@wiktel.com:
On Fri, 2011-06-03 at 22:06 +0200, Ruben Kerkhof wrote:
If I don't have the VirtualBox GUI running, virsh fails to connect:
/usr/local/bin/virsh -c vbox:///session
... hangs for 10 or so seconds ...
error: internal error nsIEventQueue object
: glue to the MSCOM based VirtualBox API
*
- * Copyright (C) 2010 Matthias Bolte matthias.bo...@googlemail.com
+ * Copyright (C) 2010-2011 Matthias Bolte matthias.bo...@googlemail.com
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser
2011/6/4 Daniel Veillard veill...@redhat.com:
On Sat, Jun 04, 2011 at 10:53:06AM +0200, Matthias Bolte wrote:
VirtualBox 4.0.8 changed the registry key layout. Before the version
number was in a Version key. Now the Version key contains %VER% and
the actual version number is in VersionExt now
2011/6/4 Daniel P. Berrange berra...@redhat.com:
The error code for virKillProcess is returned in the errno variable
not the return value. THis mistake caused the logs to be filled with
errors when shutting down QEMU processes
* src/qemu/qemu_process.c: Fix process kill check.
---
2011/6/4 Daniel P. Berrange berra...@redhat.com:
The v2 migration protocol doesn't use cookies, so we should not
be raising an error if the cookie parameters are NULL.
* src/qemu/qemu_migration.c: Don't raise error if cookie is NULL
---
src/qemu/qemu_migration.c | 7 ++-
1 files
2011/6/4 Ruben Kerkhof ru...@rubenkerkhof.com:
On Sat, Jun 4, 2011 at 10:40, Matthias Bolte
matthias.bo...@googlemail.com wrote:
Okay VirtualBox 4.0.8 work with libvirt on Windows too. So this seems
to be a Solaris specific problem. Does an earlier version of
VirtualBox work, for example
---
I'm pushing this under the trivial rule.
src/vbox/vbox_XPCOMCGlue.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/vbox/vbox_XPCOMCGlue.c b/src/vbox/vbox_XPCOMCGlue.c
index 0caeef9..e7e9c37 100644
--- a/src/vbox/vbox_XPCOMCGlue.c
+++
2011/6/3 Ruben Kerkhof ru...@rubenkerkhof.com:
On Mon, May 30, 2011 at 08:52, Matthias Bolte
matthias.bo...@googlemail.com wrote:
2011/5/30 Ruben Kerkhof ru...@rubenkerkhof.com:
On Sun, May 29, 2011 at 19:45, Matthias Bolte
matthias.bo...@googlemail.com wrote:
2011/5/29 Richard Laager rlaa
2011/6/3 Osier Yang jy...@redhat.com:
Qemu once supported following memory stats which will returned by
query_balloon:
stat_put(dict, actual, actual);
stat_put(dict, mem_swapped_in, dev-stats[VIRTIO_BALLOON_S_SWAP_IN]);
stat_put(dict, mem_swapped_out,
, 2011 at 10:31, Matthias Bolte
matthias.bo...@googlemail.com wrote:
Works on Ubuntu 10.04, Windows (MinGW) and FreeBSD.
Matthias
Works on OSX 10.7.0, tested with VirtualBox 4.08
Excellent news, thanks !
I hope we didn't introduced regressions in portability with the latest
API additions
2011/6/3 Daniel P. Berrange berra...@redhat.com:
On Fri, Jun 03, 2011 at 01:27:04PM +0200, Matthias Bolte wrote:
2011/6/2 Daniel Veillard veill...@redhat.com:
I just pushed a second release candidate
ftp://libvirt.org/libvirt/libvirt-0.9.2-rc2.tar.gz
with corresponding rpm builds
2011/6/3 Richard Laager rlaa...@wiktel.com:
On Fri, 2011-06-03 at 09:11 +0200, Matthias Bolte wrote:
It has probably something to do with this piece of code, in
daemon/libvirtd.c:
I finally got back to looking at this, and that's what I discovered as
well. (I hadn't checked my email
2011/5/29 Daniel Veillard veill...@redhat.com:
So we are entering the week freeze for the new version.
I have made an rc1 tarball available at:
ftp://libvirt.org/libvirt/libvirt-0.9.2-rc1.tar.gz
I also made rpms too for those interested.
I didn't included the locking patches from Dan
Otherwise virsh dumpxml will report domain type='qemu' instead
of the expected domain type='openvz'.
---
I pushed this one as Eric already ACK'ed it as part of another patch [1]
where I accientially included it and Jean-Baptiste confirmed that the
problem exists [2].
[1]
2011/5/31 Jean-Baptiste Rouault jean-baptiste.roua...@diateam.net:
On Tuesday 31 May 2011 14:41:55 Matthias Bolte wrote:
I also added a testcase and looked at the other config parsing code in
the OpenVZ driver. I thing that openvzLoadDomains is missing this
line:
dom-def-virtType
2011/6/1 Anthony Fox a.podava...@gmail.com:
Hi all!
I wanna try to get help with C# bindings.
I ask Arnaud Champion to get me git write access.
He wrote that I should write to the mailing list.
Can someone get me access?
As already state in IRC you should just work on the C# bindings if you
2011/5/31 Eric Blake ebl...@redhat.com:
On 05/30/2011 12:33 PM, Matthias Bolte wrote:
We commonly use value, length order, let's stick to this.
---
daemon/remote.c | 40
src/remote/remote_driver.c | 40
2011/5/31 Eric Blake ebl...@redhat.com:
On 05/30/2011 07:03 AM, Matthias Bolte wrote:
From 726dae7b4c21d4c17ac19808c06d7fc978b36778 Mon Sep 17 00:00:00 2001
From: Matthias Bolte matthias.bo...@googlemail.com
Date: Mon, 30 May 2011 12:58:57 +0200
Subject: [PATCH] remote generator: Legacy
2011/5/31 Eric Blake ebl...@redhat.com:
On 05/30/2011 07:03 AM, Matthias Bolte wrote:
From 3bb05f7543f86e3b47772f0fabecbda4f167b3bc Mon Sep 17 00:00:00 2001
From: Matthias Bolte matthias.bo...@googlemail.com
Date: Mon, 30 May 2011 14:36:41 +0200
Subject: [PATCH] apibuild: Restrict long usage
The test used an emulator that is not supported in testutilsqemu.c.
Swicth from qemu-kvm to kvm to fix this.
---
This patch addresses the problem discussed here:
https://www.redhat.com/archives/libvir-list/2011-May/msg01914.html
.../qemuxml2argv-graphics-spice-timeout.args |2 +-
2011/6/1 Adam Litke a...@us.ibm.com:
This commit has a pretty long summary line.
* src/remote/remote_protocol.x: provide defines for the new entry points
* src/remote/remote_driver.c daemon/remote.c: implement the client and
server side
* daemon/remote_generator.pl: Specify the
2011/5/31 Eric Blake ebl...@redhat.com:
On 05/30/2011 12:34 PM, Matthias Bolte wrote:
This doesn't cover the getters that allow to query nparams yet.
---
This patch depends on
https://www.redhat.com/archives/libvir-list/2011-May/msg01856.html
daemon/remote.c | 182
2011/6/1 Adam Litke a...@us.ibm.com:
* src/remote/remote_protocol.x: provide defines for the new entry points
* src/remote/remote_driver.c daemon/remote.c: implement the client and
server side
* daemon/remote_generator.pl: Specify the manually-written functions
Signed-off-by: Adam Litke
2011/6/1 Eric Blake ebl...@redhat.com:
On 06/01/2011 10:13 AM, Matthias Bolte wrote:
The test used an emulator that is not supported in testutilsqemu.c.
Swicth from qemu-kvm to kvm to fix this.
s/Swicth/Switch/
My typo rate is quite high recently.
---
This patch addresses the problem
2011/6/1 Adam Litke a...@us.ibm.com:
Set up the types for the block pull functions and insert them into the
virDriver structure definition. Because of static initializers, update every
driver and set the new fields to NULL.
* include/libvirt/libvirt.h.in: new API
* src/driver.h
2011/6/1 Adam Litke a...@us.ibm.com:
On 06/01/2011 12:13 PM, Matthias Bolte wrote:
2011/6/1 Adam Litke a...@us.ibm.com:
This commit has a pretty long summary line.
Fixed.
* src/remote/remote_protocol.x: provide defines for the new entry points
* src/remote/remote_driver.c daemon/remote.c
2011/6/1 Adam Litke a...@us.ibm.com:
On 06/01/2011 12:27 PM, Matthias Bolte wrote:
2011/6/1 Adam Litke a...@us.ibm.com:
* src/remote/remote_protocol.x: provide defines for the new entry points
* src/remote/remote_driver.c daemon/remote.c: implement the client and
server side
* daemon
2011/6/1 Eric Blake ebl...@redhat.com:
Regression introduced in commit d6623003 (v0.8.8) - using the
wrong sizeof operand meant that security manager private data
was overlaying the allowDiskFOrmatProbing member of struct
s/FOrmat/Format/
_virSecurityManager. This reopens disk probing,
2011/6/2 Eric Blake ebl...@redhat.com:
On 05/31/2011 05:35 PM, Eric Blake wrote:
Regression introduced in commit d6623003 (v0.8.8) - using the
wrong sizeof operand meant that security manager private data
was overlaying the allowDiskFOrmatProbing member of struct
_virSecurityManager. This
2011/5/31 Daniel Veillard veill...@redhat.com:
On Sun, May 29, 2011 at 05:12:57PM +0200, Matthias Bolte wrote:
As OpenVZ is Linux specific.
---
configure.ac | 20 +++-
1 files changed, 19 insertions(+), 1 deletions(-)
diff --git a/configure.ac b/configure.ac
index
2011/5/31 Daniel Veillard veill...@redhat.com:
On Sun, May 29, 2011 at 05:14:25PM +0200, Matthias Bolte wrote:
Remove the Domain prefix from the comments.
---
include/libvirt/libvirt.h.in | 18 +-
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/include
2011/5/31 Daniel Veillard veill...@redhat.com:
On Sun, May 29, 2011 at 05:14:46PM +0200, Matthias Bolte wrote:
Parsing ./../include/libvirt/libvirt.h
Misformatted macro comment for _virSchedParameter
Expecting '* _virSchedParameter:' got '* virSchedParameter:'
Misformatted macro comment
2011/5/27 Daniel P. Berrange berra...@redhat.com:
Update the qemuDomainMigrateBegin method so that it accepts
an optional incoming XML document. This will be validated
for ABI compatibility against the current domain config,
and if this check passes, will be passed back out for use
by the
2011/5/27 Daniel P. Berrange berra...@redhat.com:
To allow a client app to pass in custom XML during migration
of a guest it is neccessary to ensure the guest ABI remains
unchanged. The virDomainDefCheckABIStablity method accepts
two virDomainDefPtr structs and compares everything in them
2011/5/27 Daniel P. Berrange berra...@redhat.com:
Switch virsh migrate over to use virDomainMigrate2 and
virDomainMigrateToURI2. This is still compatible with
older libvirts, because these methods dynamically choose
whether to perform v1, v2 or v3 migration based on declared
RPC support from
2011/5/24 Michal Prívozník mpriv...@redhat.com:
On 24.05.2011 13:43, Michal Privoznik wrote:
If spice graphics has no channel elements, the output graphics XML
is messed up. To prevent this, we need to end the graphics element
By messing up I mean something like this:
..
graphics
2011/5/31 Jean-Baptiste Rouault jean-baptiste.roua...@diateam.net:
strchrnul() was called on the wrong string so it returned
the same result for each iteration.
---
src/openvz/openvz_conf.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/openvz/openvz_conf.c
Convert openvzLocateConfFile to a replaceable callback to allow
testing the config file parsing without rewriting the whole OpenVZ
config parsing to a more testable structure.
Also ignore the openvzutilstest binary.
---
src/openvz/openvz_conf.c | 28 +++
src/openvz/openvz_conf.h
2011/5/31 Daniel Veillard veill...@redhat.com:
On Tue, May 31, 2011 at 10:43:16AM +0200, Matthias Bolte wrote:
2011/5/31 Daniel Veillard veill...@redhat.com:
On Sun, May 29, 2011 at 05:14:46PM +0200, Matthias Bolte wrote:
Parsing ./../include/libvirt/libvirt.h
Misformatted macro comment
2011/5/31 Michal Privoznik mpriv...@redhat.com:
and check regression
---
.../qemuxml2argv-graphics-spice-compression.args | 9 +
.../qemuxml2argv-graphics-spice-compression.xml | 39
tests/qemuxml2argvtest.c | 3 ++
2011/5/31 Eric Blake ebl...@redhat.com:
On 05/27/2011 04:37 AM, Matthias Bolte wrote:
The regression fix in 3aab7f2d6b068f0 altered the error handling.
getline returns -1 on failure to read a line (including EOF). The
original openvzReadConfigParam function using openvz_readline only
treated
2011/5/31 Eric Blake ebl...@redhat.com:
On 05/27/2011 09:47 AM, Matthias Bolte wrote:
This function is also affected by getline conversion. But this
didn't result in a regression in general, because the difference
whould only affect the behavior of the function when the line in
/proc/vz
2011/5/31 Eric Blake ebl...@redhat.com:
* daemon/THREADING.txt: Rename...
* daemon/THREADS.txt: ...to match qemu thread notes.
* daemon/Makefile.am (EXTRA_DIST): Reflect rename.
---
First suggested here:
https://www.redhat.com/archives/libvir-list/2011-May/msg01730.html
2011/5/31 Osier Yang jy...@redhat.com:
Substitute VIR_ERR_NO_SUPPORT with VIR_ERR_INTERNAL_ERROR. Error
like following is not what user want to see.
error : pciDeviceIsAssignable:1487 : this function is not supported
by the connection driver: Device :07:10.0 is behind a switch
lacking
AM_GNU_GETTEXT calls AM_ICONV_LINK. AM_ICONV_LINK saves and alters
CPPFLAGS, but doesn't restore it when it finds libiconv. This
results in /usr/local/include ending up in the gcc command line
before the include path for the local include directory. This makes
gcc pick a previous installed
virsh version does basically this
hvType = virConnectGetType(...)
virGetVersion(..., hvType, ...)
[...]
Assuming a remote connection virConnectGetType calls the remote driver
that returns the type of the underlying driver on the server side, for
example QEMU. Then virGetVersion compares hvType
2011/5/30 Ruben Kerkhof ru...@rubenkerkhof.com:
On Sun, May 29, 2011 at 19:45, Matthias Bolte
matthias.bo...@googlemail.com wrote:
2011/5/29 Richard Laager rlaa...@wiktel.com:
On Sun, 2011-05-29 at 12:34 +0200, Matthias Bolte wrote:
So I tried building libvirt on Solaris 11 Express
2011/5/30 Michal Privoznik mpriv...@redhat.com:
This option accepts 3 values:
-keep, to keep current client connected (Spice+VNC)
-disconnect, to disconnect client (Spice)
-fail, to fail setting password if there is a client connected (Spice)
---
docs/schemas/domain.rng | 16
We commonly use value, length order, let's stick to this.
---
daemon/remote.c| 40
src/remote/remote_driver.c | 40
2 files changed, 40 insertions(+), 40 deletions(-)
diff --git a/daemon/remote.c
This doesn't cover the getters that allow to query nparams yet.
---
This patch depends on
https://www.redhat.com/archives/libvir-list/2011-May/msg01856.html
daemon/remote.c | 182 ---
daemon/remote_generator.pl | 58 +++-
2011/5/29 Richard Laager rlaa...@wiktel.com:
I would really like to use ZFS's zvols as storage for my guests. I
really like ZFS's snapshots, send/receive, and checksumming features.
(Compression and deduplication might be useful as well.)
I'm roughly about half-way done writing a ZFS storage
As OpenVZ is Linux specific.
---
configure.ac | 20 +++-
1 files changed, 19 insertions(+), 1 deletions(-)
diff --git a/configure.ac b/configure.ac
index 55ae791..b2ba930 100644
--- a/configure.ac
+++ b/configure.ac
@@ -255,7 +255,7 @@ AC_ARG_WITH([qemu],
AC_ARG_WITH([uml],
Remove the Domain prefix from the comments.
---
include/libvirt/libvirt.h.in | 18 +-
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in
index cbd8dbb..8058229 100644
--- a/include/libvirt/libvirt.h.in
+++
Parsing ./../include/libvirt/libvirt.h
Misformatted macro comment for _virSchedParameter
Expecting '* _virSchedParameter:' got '* virSchedParameter:'
Misformatted macro comment for _virBlkioParameter
Expecting '* _virBlkioParameter:' got '* virBlkioParameter:'
Misformatted macro comment for
2011/5/29 Richard Laager rlaa...@wiktel.com:
On Sun, 2011-05-29 at 12:34 +0200, Matthias Bolte wrote:
So I tried building libvirt on Solaris 11 Express. The following
outlines the trouble (and successes) I've had so far.
I assume your building from up-to-date git here?
I was using 0.9.1
2011/5/27 Daniel Veillard veill...@redhat.com:
On Thu, May 26, 2011 at 11:32:09PM +0200, Matthias Bolte wrote:
Export a bunch of missing symbols and link the remote driver to gnulib.
---
src/Makefile.am | 8 +++-
src/libvirt_private.syms | 3 +++
src/libvirt_xenxs.syms
The regression fix in 3aab7f2d6b068f0 altered the error handling.
getline returns -1 on failure to read a line (including EOF). The
original openvzReadConfigParam function using openvz_readline only
treated EOF as not-found. The current getline version treats all
getline failures as not-found.
://www.redhat.com/archives/libvir-list/2011-May/msg01788.html
Matthias
From 553610ca59753d036d75792ff5900280a1296c37 Mon Sep 17 00:00:00 2001
From: Matthias Bolte matthias.bo...@googlemail.com
Date: Fri, 27 May 2011 13:50:13 +0200
Subject: [PATCH] openvz: Fix regression in openvzGetVPSUUID
Commit
---
src/util/sexpr.c | 12 +---
1 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/src/util/sexpr.c b/src/util/sexpr.c
index d8d4c2d..0e30087 100644
--- a/src/util/sexpr.c
+++ b/src/util/sexpr.c
@@ -215,7 +215,7 @@ sexpr2string(const struct sexpr *sexpr, virBufferPtr buffer)
2011/5/27 Daniel P. Berrange berra...@redhat.com:
On Fri, May 27, 2011 at 03:09:36PM +0200, Matthias Bolte wrote:
---
src/util/sexpr.c | 12 +---
1 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/src/util/sexpr.c b/src/util/sexpr.c
index d8d4c2d..0e30087 100644
2011/5/27 Daniel Veillard veill...@redhat.com:
On Fri, May 27, 2011 at 03:12:26PM +0200, Jean-Baptiste Rouault wrote:
On Friday 27 May 2011 13:51:05 Matthias Bolte wrote:
We need distinguish between getline returning -1 because of EOF and
because of another error. I missed this problem
2011/5/27 Jean-Baptiste Rouault jean-baptiste.roua...@diateam.net:
On Friday 27 May 2011 16:01:32 Matthias Bolte wrote:
Thanks, pushed then.
There are other usages of getline in the OpenVZ driver, but they
should all be safe because they don't distinguish between 0 and -1,
except
This function is also affected by getline conversion. But this
didn't result in a regression in general, because the difference
whould only affect the behavior of the function when the line in
/proc/vz/vestat for the given vpsid wasn't found. Under normal
conditions this should not happen.
---
Before commit 145d6cb05c45f4 (in August 2010) absolute file names
in VMX and domain XML configs were handled correctly. But this got
lost during the refactoring. The test cases didn't highlight this
problem because they have their own set of file name handling
functions. The actual ones require a
2011/5/18 Taisuke Yamada t...@rakugaki.org:
Hi.
As reported by Diego Blanco in
- https://bugzilla.redhat.com/show_bug.cgi?id=702602
commit f0443765 which replaced openvz_readline to getline(3)
broke OpenVZ driver as it changed semantics of EOF-handling
when parsing OpenVZ configuration.
This testcase passes before the regression is added in f0443765, fails
after that commit and passes again after the regression was fixed.
---
src/openvz/openvz_conf.c |2 +-
src/openvz/openvz_conf.h |1 +
tests/Makefile.am | 18 +
tests/openvzutilstest.c| 91
2011/5/26 Matthias Bolte matthias.bo...@googlemail.com:
This testcase passes before the regression is added in f0443765, fails
after that commit and passes again after the regression was fixed.
I should have referenced the patch that fixes the regression:
https://www.redhat.com/archives
2011/5/26 Eric Blake ebl...@redhat.com:
On 05/26/2011 12:06 PM, Matthias Bolte wrote:
This testcase passes before the regression is added in f0443765, fails
after that commit and passes again after the regression was fixed.
---
src/openvz/openvz_conf.c | 2 +-
src/openvz/openvz_conf.h
Export a bunch of missing symbols and link the remote driver to gnulib.
---
src/Makefile.am |8 +++-
src/libvirt_private.syms |3 +++
src/libvirt_xenxs.syms | 21 +
3 files changed, 31 insertions(+), 1 deletions(-)
create mode 100644
2011/5/26 Eric Blake ebl...@redhat.com:
On 05/26/2011 09:45 AM, Matthias Bolte wrote:
- if (datastorePath == NULL) {
+ /* If it's an absolute path outside of a datastore just use it as
is */
+ if (result == NULL *fileName == '/') {
+ /* FIXME: need to deal
2011/5/24 Daniel P. Berrange berra...@redhat.com:
The virDomainMigratePerform3 currently has a single URI parameter
whose meaning varies. It is either
- A QEMU migration URI (normal migration)
- A libvirtd connection URI (peer2peer migration)
Unfortunately when using peer2peer migration,
2011/5/24 Daniel P. Berrange berra...@redhat.com:
This extends the v3 migration protocol such that the
virDomainMigrateBegin3 and virDomainMigratePerform3
methods accept an application supplied XML config for
the target VM.
If the 'xmlin' parameter is NULL, then Begin3 uses the
current
2011/5/24 Daniel P. Berrange berra...@redhat.com:
There are two pieces of information which are desirable for
migration, which cannot be supplied by applications
- The explicit QEMU migration URI, while using Peer2Peer
migration
- An override for the target VM XML
This introduces two
2011/5/24 Daniel P. Berrange berra...@redhat.com:
Before running perform in peer-2-peer migration, the current
guest state must be recorded, so that non-live migration can
currently unpause a running guest on completion.
* src/qemu/qemu_migration.c: Move check for offline guest
to fix
2011/5/24 Daniel P. Berrange berra...@redhat.com:
---
src/qemu/qemu_migration.c | 34 --
1 files changed, 20 insertions(+), 14 deletions(-)
@@ -434,26 +437,29 @@ qemuMigrationCookieXMLParse(qemuMigrationCookiePtr mig,
VIR_FREE(tmp);
/* Check
2011/5/24 Daniel P. Berrange berra...@redhat.com:
Even when failing to start CPUs, the finish method was returning
a success result. Fix this so that the QEMU process is killed
off when finish fails under v3 protocol. Also rename the
killOnFinish boolean to 'v3proto' to make it clearer that
2011/5/24 YAO yffbr...@gmail.com:
2011/5/24 Matthias Bolte matthias.bo...@googlemail.com
2011/5/24 YAO yffbr...@gmail.com:
Hi,
I cloned the latest libvirt from git and compiled as follows:
cd libvirt
./autogen.sh
make
sudo make install
when installing, it reported /usr/bin/install
2011/5/24 Daniel P. Berrange berra...@redhat.com:
When doing migration, if an error occurs in Perform, it must not
be overwritten during Finish/Confirm steps. If an error occurs
in Finish, it must not be overwritten in Confirm.
Previous commit a9d12c2444e43a0d3e5135eb15b4b62a7c011427 added
2011/5/24 Daniel P. Berrange berra...@redhat.com:
The current virDomainMigrateFinish3 method signature attempts to
distinguish two types of errors, by allowing return with ret== 0,
but ddomain == NULL, to indicate a failure to start the guest.
This is flawed, because when ret == 0, there is no
2011/5/24 Daniel P. Berrange berra...@redhat.com:
* src/libvirt.c: Add further debug lines in helper APIs for
migration
* src/qemu/qemu_migration.c: Add debug lines for all internal
migration API parameters
---
src/libvirt.c | 19 -
src/qemu/qemu_migration.c
2011/5/25 Daniel P. Berrange berra...@redhat.com:
On Wed, May 25, 2011 at 09:45:50AM +0200, Matthias Bolte wrote:
2011/5/24 Daniel P. Berrange berra...@redhat.com:
There are two pieces of information which are desirable for
migration, which cannot be supplied by applications
Otherwise an attempt to use virConnectOpen or virConnectOpenAuth without
auth pointer results in the driver declining the URI and libvirt falling
back to the remote driver for an esx:// URI.
---
src/esx/esx_driver.c | 15 ---
1 files changed, 12 insertions(+), 3 deletions(-)
diff
2011/5/25 Eric Blake ebl...@redhat.com:
On 05/25/2011 07:53 AM, Matthias Bolte wrote:
Otherwise an attempt to use virConnectOpen or virConnectOpenAuth without
auth pointer results in the driver declining the URI and libvirt falling
back to the remote driver for an esx:// URI.
---
src/esx
---
v2: switch internal type to long long instead of adding casts for time_t
src/conf/domain_conf.c |8
src/conf/domain_conf.h |2 +-
src/esx/esx_vi_types.c |2 +-
src/esx/esx_vi_types.h |2 +-
4 files changed, 7 insertions(+), 7 deletions(-)
diff --git
localtime_r expects time_t.
---
v2: add overflow check
tools/virsh.c | 14 ++
1 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index de49489..b43c167 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -10442,7 +10442,8 @@
2011/5/24 Daniel Veillard veill...@redhat.com:
On Tue, May 24, 2011 at 01:21:51PM +0200, Matthias Bolte wrote:
---
configure.ac | 7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
Okay, ACK,
Daniel
Thanks, pushed.
Matthias
--
libvir-list mailing list
libvir-list
2011/5/25 Eric Blake ebl...@redhat.com:
On 05/25/2011 09:05 AM, Matthias Bolte wrote:
---
v2: switch internal type to long long instead of adding casts for time_t
src/conf/domain_conf.c | 8
src/conf/domain_conf.h | 2 +-
src/esx/esx_vi_types.c | 2 +-
src/esx
2011/5/25 Eric Blake ebl...@redhat.com:
On 05/25/2011 09:06 AM, Matthias Bolte wrote:
localtime_r expects time_t.
---
v2: add overflow check
ACK.
- localtime_r(creation, time_info);
+ creation_time_t = creation_longlong;
+ if (creation_time_t
2011/5/23 Matthias Bolte matthias.bo...@googlemail.com:
This series removes special case code from the generator and moves
it to annotations in the .x files. There are also cleanups of sign
mismatches between the different API layers and additional moves of
functions to generated code
2011/5/25 Lai Jiangshan la...@cn.fujitsu.com:
Add public virDomainSendKey() and enum libvirt_keycode_set
for the @codeset.
Python version of virDomainSendKey() has not been implemented yet,
it will be done soon.
Signed-off-by: Lai Jiangshan la...@fujitsu.com
---
601 - 700 of 2383 matches
Mail list logo
