Re: [libvirt] [PATCH 08/13] send-key: Implementing the remote protocol

2011-05-25 Thread Matthias Bolte
2011/5/25 Lai Jiangshan la...@cn.fujitsu.com: Signed-off-by: Lai Jiangshan la...@fujitsu.com ---  src/remote/remote_driver.c   |    1 +  src/remote/remote_protocol.x |   19 ++-  src/remote_protocol-structs  |   11 +++  3 files changed, 30 insertions(+), 1 deletions(-)

Re: [libvirt] [PATCH 04/13] remote_generator: support general dynamic array

2011-05-25 Thread Matthias Bolte
the generic array case at that isn't useful, it just deals with [unsigned] int arrays. This patch assumes that keycodes and keycodeslen are reordered to the common pattern. Matthias From b48bfdf41e8b164877869e8590b60e8549bb53fd Mon Sep 17 00:00:00 2001 From: Matthias Bolte matthias.bo

Re: [libvirt] [PATCH 07/13] send-key: Implementing the public API

2011-05-25 Thread Matthias Bolte
2011/5/25 Lai Jiangshan la...@cn.fujitsu.com: Signed-off-by: Lai Jiangshan la...@fujitsu.com ---  src/libvirt.c |   54 ++  1 files changed, 54 insertions(+), 0 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index ff16c48..8246975

Re: [libvirt] [PATCH 7/7] remote generator: Annotate hyper with the actual C type

2011-05-25 Thread Matthias Bolte
2011/5/25 Eric Blake ebl...@redhat.com: On 05/25/2011 10:23 AM, Daniel P. Berrange wrote: On Mon, May 23, 2011 at 07:36:10PM +0200, Matthias Bolte wrote: Remove some special case code that took care of mapping hyper to the correct C types. Use macros for hyper to long assignments

Re: [libvirt] libvirt.so.0: cannot open shared object file: No such file or directory

2011-05-24 Thread Matthias Bolte
2011/5/24 YAO yffbr...@gmail.com: Hi, I cloned the latest libvirt from git and compiled as follows: cd libvirt ./autogen.sh make sudo make install when installing, it reported /usr/bin/install: cannot stat `./xxx.html': No such file or directory, is that normal? You are probably missing

Re: [libvirt] Git snapshot tar not working?

2011-05-24 Thread Matthias Bolte
2011/5/20 Neil Wilson n...@brightbox.co.uk: Hi, Has the git snapshot tar service stopped working? The file is dated 6th May and is very out of date compared to git head. Rgs Neil I noticed this today too. Also the file from May 6th is broken gzip: stdin: invalid compressed data--crc

[libvirt] [PATCH] Allow to explicitly disable the secrets a directory storage driver

2011-05-24 Thread Matthias Bolte
--- configure.ac |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 412fdb8..7940ef0 100644 --- a/configure.ac +++ b/configure.ac @@ -1499,7 +1499,9 @@ AC_SUBST([NETCF_CFLAGS]) AC_SUBST([NETCF_LIBS]) -with_secrets=yes

Re: [libvirt] [PATCH] build: fix VIR_DEBUG on mingw

2011-05-24 Thread Matthias Bolte
. (virLogMessage): Inline a simpler version here. * src/util/virterror.c (VIR_GET_VAR_STR, virRaiseErrorFull): Likewise. Reported by Matthias Bolte. ---  src/util/logging.c   |   45 ++---  src/util/virterror.c |   44

Re: [libvirt] [PATCH] build: avoid strerror_r pitfalls

2011-05-24 Thread Matthias Bolte
2011/5/25 Eric Blake ebl...@redhat.com: In particular, this guarantees that virStrerror always gives a useful result. * .gnulib: Update to latest, for (lots of) strerror_r fixes. --- This patch removes the need for Daniel's proposal:

[libvirt] [PATCH 0/7] More remote generator work

2011-05-23 Thread Matthias Bolte
This series removes special case code from the generator and moves it to annotations in the .x files. There are also cleanups of sign mismatches between the different API layers and additional moves of functions to generated code. This series superseds patch 4/5 of the last series [1] and

[libvirt] [PATCH 3/7] remote generator: Make call-by-reference handling stricter

2011-05-23 Thread Matthias Bolte
Several functions return values by reference parameters. This is realized by passing the members of remote_CALL_ret by reference to the called function. The position of this parameters in the function signature follows some patterns with some exceptions. This patterns and exceptions are hardcoded

[libvirt] [PATCH 1/7] remote generator: Handle virDomainCreateWithFlags

2011-05-23 Thread Matthias Bolte
Add special case code for updating a given domain object instead of returning a new one. --- daemon/remote.c | 30 --- daemon/remote_generator.pl | 55 + src/remote/remote_driver.c | 32

[libvirt] [PATCH 2/7] remote generator: Rename virNodeGetCellsFreeMemory parameters to common pattern

2011-05-23 Thread Matthias Bolte
This allows to remove some special case code from the generator. --- daemon/remote_generator.pl |3 +-- src/remote/remote_driver.c |8 src/remote/remote_protocol.x |4 ++-- src/remote_protocol-structs |8 4 files changed, 11 insertions(+), 12 deletions(-)

[libvirt] [PATCH 7/7] remote generator: Annotate hyper with the actual C type

2011-05-23 Thread Matthias Bolte
Remove some special case code that took care of mapping hyper to the correct C types. Use macros for hyper to long assignments that perform overflow checks when long is smaller than hyper. Also use such macros for the safe hyper to longlong assignemts as this allows to keep the generator a bit

[libvirt] [PATCH 6/7] Fix sign mismatches between public API, driver API and XDR protocol

2011-05-23 Thread Matthias Bolte
In most cases this affects flags parameters that are unsigned in the public and driver API but signed in the XDR protocol. Switch the XDR protocol to unsigned for those. A counterexample is virNWFilterGetXMLDesc. Its flags parameter is signed in the public API and XDR protocol, but unsigned in

Re: [libvirt] [PATCH 4/5] remote generator: Handle stream-using functions

2011-05-23 Thread Matthias Bolte
2011/5/16 Eric Blake ebl...@redhat.com: On 05/15/2011 12:23 AM, Matthias Bolte wrote: Reorder signature of virDrvDomainOpenConsole to match the common pattern. Add special case code to handle deviation in the public API version. Adds a missing remoteStreamRelease to remoteDomainScreenshot

Re: [libvirt] [PATCHv5 1/6] virNodeGetCPUTimeParameters: Expose new API

2011-05-20 Thread Matthias Bolte
2011/5/20 Daniel P. Berrange berra...@redhat.com: On Tue, May 17, 2011 at 04:01:36PM +0900, Minoru Usui wrote: virNodeGetCPUTimeParameters: Expose new API Signed-off-by: Minoru Usui u...@mxm.nes.nec.co.jp ---  include/libvirt/libvirt.h.in |   65 ++  

Re: [libvirt] [PATCH 5/5] remote generator: Don't rely on $_ being stable over a large function

2011-05-20 Thread Matthias Bolte
2011/5/16 Eric Blake ebl...@redhat.com: On 05/15/2011 12:23 AM, Matthias Bolte wrote: Replace $calls{$_} with $call in the dispatch bodies generator function. No functional change included. ---  daemon/remote_generator.pl |  100 ++-  1 files changed

Re: [libvirt] [PATCH] remote generator: Add special case for virConnectGetType

2011-05-20 Thread Matthias Bolte
2011/5/16 Eric Blake ebl...@redhat.com: On 05/16/2011 12:14 PM, Matthias Bolte wrote: This patch depends on this unapplied series: https://www.redhat.com/archives/libvir-list/2011-May/msg00987.html which is now reviewed. Subject: [PATCH] remote generator: Add special case

Re: [libvirt] [PATCHv2 1/6] build: update to latest gnulib

2011-05-18 Thread Matthias Bolte
2011/5/18 Eric Blake ebl...@redhat.com: * .gnulib: Update, for bootstrap and other fixes. * bootstrap: Resynchronize with gnulib. --- v2: not sure I've sent a v1 on list, so this is a new patch * .gnulib 64a5e38...a2b658c (23):   intprops: add doc   verify: add doc to gnulib manual and

Re: [libvirt] [PATCH] Improve invalid argument checks for the public API

2011-05-18 Thread Matthias Bolte
2011/5/18 Daniel Veillard veill...@redhat.com: On Tue, May 17, 2011 at 09:46:34AM -0600, Eric Blake wrote: On 05/17/2011 07:14 AM, Daniel Veillard wrote: On Tue, May 17, 2011 at 02:45:44PM +0200, Matthias Bolte wrote: ---  src/libvirt.c |  100

[libvirt] [PATCH 0/6] Clarify semantic of virDomain(G|S)et*Parameters functions

2011-05-18 Thread Matthias Bolte
This series was inspired by the discusion about invalid argument checking in the public API and the unclear semantic of this functions. https://www.redhat.com/archives/libvir-list/2011-May/msg01105.html Clarify that the getter functions don't allow to obtain a subset of the parameters. You can

[libvirt] [PATCH 4/6] Clarify that virDomainSet(Memory|Blkio)Parameters can take parameter subsets

2011-05-18 Thread Matthias Bolte
--- src/libvirt.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 2c2866e..3b41f1d 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -2992,11 +2992,11 @@ error: * virDomainSetMemoryParameters: * @domain: pointer to domain

[libvirt] [PATCH 2/6] Clarify the semantic of virDomainGetSchedulerParameters arguments

2011-05-18 Thread Matthias Bolte
params and nparams are essential and cannot be NULL. Check this in libvirt.c and remove redundant checks from the drivers (e.g. xend). Instead of enforcing that nparams must point to exact same value as returned by virDomainGetSchedulerType relax this to a lower bound check. This is what some

[libvirt] [PATCH 1/6] Clarify semantic of nparams argument of virDomainGetSchedulerType

2011-05-18 Thread Matthias Bolte
Some drivers assumed it can be NULL (e.g. qemu and lxc) and check it before assigning to it, other drivers assumed it must be non-NULL (e.g. test and esx) and just assigned to it. Unify this to nparams being optional and document it. --- src/esx/esx_driver.c |4 +++- src/libvirt.c

[libvirt] [PATCH 3/6] Clarify that virDomainSetSchedulerParameters(Flags) can take subset

2011-05-18 Thread Matthias Bolte
Add invalid argument checks for params and nparams to the public API and remove the from the drivers (e.g. xend). Add subset handling to libxl and test drivers. --- src/libvirt.c| 24 ++-- src/libxl/libxl_driver.c |6 -- src/test/test_driver.c | 27

[libvirt] [PATCH 6/6] Improve invalid argument checks for the public API

2011-05-18 Thread Matthias Bolte
--- src/libvirt.c | 82 1 files changed, 76 insertions(+), 6 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index d6e222e..a423e77 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -1390,7 +1390,7 @@ int

[libvirt] [PATCH 5/6] Clarify that virDomainGet(Memory|Blkio)Parameters doesn't support subsets

2011-05-18 Thread Matthias Bolte
Improve invalid argument checks in the size query case. The drivers already relied on this unchecked behavior. Relax the implementation of virDomainGet(Memory|Blkio)MemoryParameters in the drivers and allow to pass more memory than necessary for all parameters. --- src/libvirt.c | 13

Re: [libvirt] [PATCHv2 3/6] virsh: optimize creation of default connection

2011-05-18 Thread Matthias Bolte
2011/5/18 Eric Blake ebl...@redhat.com: Ramon de Carvalho Valle reported a problem with: virsh connect qemu:///system as a non-root user.  The real root problem appears to be a regression in libvirtd being auto-started on the default qemu:///session URI; however, the symptom points to an

Re: [libvirt] [PATCHv2 4/6] build: make python optional at configure time

2011-05-18 Thread Matthias Bolte
2011/5/18 Eric Blake ebl...@redhat.com: Regression introduced in commit 53cb23f4. * configure.ac: Let --with-python default to check. --- v2: no change from v1 v1: https://www.redhat.com/archives/libvir-list/2011-May/msg00412.html  configure.ac |   29 -  1

Re: [libvirt] [PATCHv2 5/6] build: silence clang false positive

2011-05-18 Thread Matthias Bolte
2011/5/18 Eric Blake ebl...@redhat.com: Clang couldn't quite see that the same condition of (flags VIR_DOMAIN_MEM_CONFIG) is used twice, such that the second block is guaranteed that def was assigned in the first block. * src/libxl/libxl_driver.c (libxlDomainSetMemoryFlags): Add a hint for

Re: [libvirt] [PATCH 0/6] Clarify semantic of virDomain(G|S)et*Parameters functions

2011-05-18 Thread Matthias Bolte
2011/5/18 Daniel Veillard veill...@redhat.com: On Wed, May 18, 2011 at 12:21:07PM +0200, Matthias Bolte wrote: This series was inspired by the discusion about invalid argument checking in the public API and the unclear semantic of this functions. https://www.redhat.com/archives/libvir-list

Re: [libvirt] [PATCH 2/6] Clarify the semantic of virDomainGetSchedulerParameters arguments

2011-05-18 Thread Matthias Bolte
2011/5/18 Daniel Veillard veill...@redhat.com: On Wed, May 18, 2011 at 12:21:09PM +0200, Matthias Bolte wrote: params and nparams are essential and cannot be NULL. Check this in libvirt.c and remove redundant checks from the drivers (e.g. xend). Instead of enforcing that nparams must point

Re: [libvirt] [PATCH] Improve invalid argument checks for the public API

2011-05-18 Thread Matthias Bolte
2011/5/18 Matthias Bolte matthias.bo...@googlemail.com: 2011/5/18 Daniel Veillard veill...@redhat.com: On Tue, May 17, 2011 at 09:46:34AM -0600, Eric Blake wrote: On 05/17/2011 07:14 AM, Daniel Veillard wrote: On Tue, May 17, 2011 at 02:45:44PM +0200, Matthias Bolte wrote: ---  src

Re: [libvirt] [PATCH 3/6] Clarify that virDomainSetSchedulerParameters(Flags) can take subset

2011-05-18 Thread Matthias Bolte
2011/5/18 Eric Blake ebl...@redhat.com: On 05/18/2011 04:21 AM, Matthias Bolte wrote: Add invalid argument checks for params and nparams to the public API and remove the from the drivers (e.g. xend). Add subset handling to libxl and test drivers. @@ -5092,6 +5092,12

Re: [libvirt] [PATCH] Ensure virStrerror always sets an error string

2011-05-18 Thread Matthias Bolte
2011/5/18 Daniel P. Berrange berra...@redhat.com: strerror_r() is free to not set any error string, if the passed errno is not valid. It may, however, still return a pointer to the original passed in buffer. This resulting in random garbage from the stack being present as the error string.

Re: [libvirt] [PATCHv2 6/6] remote: remove special case for getting version

2011-05-18 Thread Matthias Bolte
2011/5/18 Eric Blake ebl...@redhat.com: The on-the-wire protocol is identical; XDR guarantees that both 'hyper' and 'unsigned hyper' are transmitted as 8 bytes. * src/remote/remote_protocol.x (remote_get_version_ret) (remote_get_lib_version_ret): Match public API. *

Re: [libvirt] [PATCH] esx: Whitespace cleanup in the generator

2011-05-17 Thread Matthias Bolte
2011/5/16 Eric Blake ebl...@redhat.com: On 05/01/2011 01:57 PM, Matthias Bolte wrote: Break long lines and change spacing of keyword arguments to match Python style standards better. No functional change included. ---  src/esx/esx_vi_generator.py |  369

Re: [libvirt] [PATCH] esx: Fix race condition in esxVI_EnsureSession

2011-05-17 Thread Matthias Bolte
2011/5/16 Eric Blake ebl...@redhat.com: On 05/01/2011 01:57 PM, Matthias Bolte wrote: When the session has expired then multiple threads can race while reestablishing it. This race condition is not that critical as it requires a special usage pattern to be triggerd. It can only happen when

Re: [libvirt] [PATCH] esx: Convert autoAnswer from esxVI_Boolean to a simple bool

2011-05-17 Thread Matthias Bolte
2011/5/16 Eric Blake ebl...@redhat.com: On 05/01/2011 01:57 PM, Matthias Bolte wrote: Just true/false is good enough for it. Also use it directly from the parsed URI instead of caching it in esxPrivate. ---  src/esx/esx_driver.c         |   52 -  src

Re: [libvirt] [PATCH] esx: Simplify some esxVI_Boolean to bool

2011-05-17 Thread Matthias Bolte
2011/5/16 Eric Blake ebl...@redhat.com: On 05/01/2011 01:57 PM, Matthias Bolte wrote: ---  src/esx/esx_driver.c |    6 ++  src/esx/esx_vi.c     |   34 +++---  src/esx/esx_vi.h     |   12 +---  3 files changed, 22 insertions(+), 30 deletions(-) I got

[libvirt] [PATCH] Improve invalid argument checks for the public API

2011-05-17 Thread Matthias Bolte
--- src/libvirt.c | 100 +--- 1 files changed, 94 insertions(+), 6 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 787908e..87391c6 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -1390,7 +1390,7 @@ int

Re: [libvirt] [PATCH 1/5] remote generator, client: Handle functions that return an optional string

2011-05-17 Thread Matthias Bolte
2011/5/16 Eric Blake ebl...@redhat.com: On 05/15/2011 12:23 AM, Matthias Bolte wrote: ---  daemon/remote_generator.pl   |    5 +  src/remote/remote_driver.c   |   26 --  src/remote/remote_protocol.x |    2 +-  3 files changed, 6 insertions(+), 27 deletions

Re: [libvirt] [PATCH 2/5] remote generator, client: Add more special case handling

2011-05-17 Thread Matthias Bolte
2011/5/16 Eric Blake ebl...@redhat.com: On 05/15/2011 12:23 AM, Matthias Bolte wrote: For virDomainDestroy and virDrvSupportsFeature. ---  daemon/remote_generator.pl   |   14 ++  src/remote/remote_driver.c   |   55 --  src/remote

Re: [libvirt] [PATCH 3/5] Fix error reporting in stream creation code

2011-05-17 Thread Matthias Bolte
2011/5/16 Eric Blake ebl...@redhat.com: On 05/15/2011 12:23 AM, Matthias Bolte wrote: virStreamNew needs to dispatch the error that virGetStream reports on failure. remoteCreateClientStream can fail due to virStreamNew or due to VIR_ALLOC. Report OOM error for VIR_ALLOC failure to report

Re: [libvirt] [PATCH] Improve invalid argument checks for the public API

2011-05-17 Thread Matthias Bolte
2011/5/17 Eric Blake ebl...@redhat.com: On 05/17/2011 07:14 AM, Daniel Veillard wrote: On Tue, May 17, 2011 at 02:45:44PM +0200, Matthias Bolte wrote: ---  src/libvirt.c |  100 +---  1 files changed, 94 insertions(+), 6 deletions

Re: [libvirt] [PATCH 1/7] libvirt.h: consolidate typed parameter handling

2011-05-17 Thread Matthias Bolte
2011/5/18 Hu Tao hu...@cn.fujitsu.com: On Tue, May 17, 2011 at 04:42:09PM -0600, Eric Blake wrote: * include/libvirt/libvirt.h.in (virTypedParameterType) (VIR_TYPED_PARAM_FIELD_LENGTH, _virTypedParameter): New enum, macro, and type. (virSchedParameter, virBlkioParameter, virMemoryParameter):

Re: [libvirt] [PATCH] virsh: Report an error when virGetUserDirectory fails

2011-05-16 Thread Matthias Bolte
2011/5/16 Laine Stump la...@laine.org: On 05/15/2011 01:31 AM, Matthias Bolte wrote: Otherwise virsh shows the interactive greeting and the silently exists instead of enterting interactive mode. ---  tools/virsh.c |    4 +++-  1 files changed, 3 insertions(+), 1 deletions(-) diff --git

[libvirt] [PATCH] remote generator: Add special case for virConnectGetType

2011-05-16 Thread Matthias Bolte
This patch depends on this unapplied series: https://www.redhat.com/archives/libvir-list/2011-May/msg00987.html Matthias From 33fbe44130aa055d4164f4cc1ace3dabdcfaa7d5 Mon Sep 17 00:00:00 2001 From: Matthias Bolte matthias.bo...@googlemail.com Date: Mon, 16 May 2011 20:10:06 +0200 Subject: [PATCH

Re: [libvirt] [PATCH] esx: Change generated method parameter autobinding

2011-05-16 Thread Matthias Bolte
2011/5/16 Eric Blake ebl...@redhat.com: On 05/14/2011 04:31 AM, Matthias Bolte wrote: 2011/5/13 Eric Blake ebl...@redhat.com: On 05/01/2011 01:57 PM, Matthias Bolte wrote: Instead of specifing the type of the managed object directly specify the ServiceContent member name. This way the mapping

Re: [libvirt] [PATCH] esx: Change some alignments in the input file

2011-05-16 Thread Matthias Bolte
2011/5/16 Eric Blake ebl...@redhat.com: On 05/14/2011 04:34 AM, Matthias Bolte wrote: 2011/5/1 Matthias Bolte matthias.bo...@googlemail.com: No functional change included. ---  src/esx/esx_vi_generator.input |  122  1 files changed, 61 insertions

[libvirt] [PATCH 2/5] remote generator, client: Add more special case handling

2011-05-15 Thread Matthias Bolte
For virDomainDestroy and virDrvSupportsFeature. --- daemon/remote_generator.pl | 14 ++ src/remote/remote_driver.c | 55 -- src/remote/remote_protocol.x |4 +- 3 files changed, 16 insertions(+), 57 deletions(-) diff --git

[libvirt] [PATCH 0/5] remote generator: Cover more functions

2011-05-15 Thread Matthias Bolte
Move more functions to the generator and cover stream-using functions. As the stream-usage is not detectable from the .x file directly add additional annotations. daemon/remote.c | 185 --- daemon/remote_generator.pl | 211 +++

[libvirt] [PATCH 1/5] remote generator, client: Handle functions that return an optional string

2011-05-15 Thread Matthias Bolte
--- daemon/remote_generator.pl |5 + src/remote/remote_driver.c | 26 -- src/remote/remote_protocol.x |2 +- 3 files changed, 6 insertions(+), 27 deletions(-) diff --git a/daemon/remote_generator.pl b/daemon/remote_generator.pl index c53ebc8..dd5d482

[libvirt] [PATCH 3/5] Fix error reporting in stream creation code

2011-05-15 Thread Matthias Bolte
virStreamNew needs to dispatch the error that virGetStream reports on failure. remoteCreateClientStream can fail due to virStreamNew or due to VIR_ALLOC. Report OOM error for VIR_ALLOC failure to report errors in all error cases. Remove OOM error reporting from remoteCreateClientStream callers.

[libvirt] [PATCH 4/5] remote generator: Handle stream-using functions

2011-05-15 Thread Matthias Bolte
Reorder signature of virDrvDomainOpenConsole to match the common pattern. Add special case code to handle deviation in the public API version. Adds a missing remoteStreamRelease to remoteDomainScreenshot error path. --- daemon/remote.c | 181

[libvirt] [PATCH 5/5] remote generator: Don't rely on $_ being stable over a large function

2011-05-15 Thread Matthias Bolte
Replace $calls{$_} with $call in the dispatch bodies generator function. No functional change included. --- daemon/remote_generator.pl | 100 ++- 1 files changed, 51 insertions(+), 49 deletions(-) diff --git a/daemon/remote_generator.pl

Re: [libvirt] libvirt, FreeBSD portability inquiry

2011-05-14 Thread Matthias Bolte
2011/5/14 Jason Helfman jhelf...@e-e.com: On Fri, May 13, 2011 at 08:38:58AM +0200, Matthias Bolte thus spake: 2011/5/12 Jason Helfman jhelf...@e-e.com: Hi, I am interested in porting libvirt to FreeBSD, and am curious if there may be anything that may not be possible at this point

Re: [libvirt] [PATCH] command: Fix compilation on FreeBSD

2011-05-14 Thread Matthias Bolte
2011/5/14 Jason Helfman jhelf...@e-e.com: On Sat, May 14, 2011 at 07:01:06AM +0200, Matthias Bolte thus spake: 2011/5/13 Eric Blake ebl...@redhat.com: On 05/12/2011 11:53 PM, Matthias Bolte wrote: kill, SIGTERM and SIGKILL require additional headers. ---  src/util/command.c |    2 ++  1

Re: [libvirt] libvirt, FreeBSD portability inquiry

2011-05-14 Thread Matthias Bolte
2011/5/14 Jason Helfman jhelf...@e-e.com: On Sat, May 14, 2011 at 08:25:13AM +0200, Matthias Bolte thus spake: 2011/5/14 Jason Helfman jhelf...@e-e.com: On Fri, May 13, 2011 at 08:38:58AM +0200, Matthias Bolte thus spake: 2011/5/12 Jason Helfman jhelf...@e-e.com: Hi, I am interested

Re: [libvirt] libvirt, FreeBSD portability inquiry

2011-05-14 Thread Matthias Bolte
2011/5/14 Jason Helfman jhelf...@e-e.com: On Sat, May 14, 2011 at 08:45:41AM +0200, Matthias Bolte thus spake: 2011/5/14 Jason Helfman jhelf...@e-e.com: On Sat, May 14, 2011 at 08:25:13AM +0200, Matthias Bolte thus spake: 2011/5/14 Jason Helfman jhelf...@e-e.com: On Fri, May 13, 2011

Re: [libvirt] [PATCH] phyp: avoid a crash

2011-05-14 Thread Matthias Bolte
2011/5/12 Eric Blake ebl...@redhat.com: This has been present since the introduction of phypAttachDevice in commit 444fd07a. * src/phyp/phyp_driver.c (phypAttachDevice): Don't dereference NULL. --- Found by clang, but the NULL dereference is very blatant. However, I'm worried that this

Re: [libvirt] [PATCH] stream: avoid use-after-free

2011-05-14 Thread Matthias Bolte
2011/5/13 Eric Blake ebl...@redhat.com: virFDStreamClose used a mutex after it was freed, and failed to destroy that mutex on its last use. * src/fdstream.c (virFDStreamFree): Inline into sole caller... (virFDStreamClose): ...to avoid use-after-free and leak. Reported by Matthias Bolte

Re: [libvirt] [PATCH] time_t is not a long on FreeBSD, need to add casts

2011-05-14 Thread Matthias Bolte
2011/5/13 Eric Blake ebl...@redhat.com: On 05/12/2011 11:53 PM, Matthias Bolte wrote: ---  src/conf/domain_conf.c |    6 +++---  1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d3efec6..875f90e 100644 --- a/src/conf

Re: [libvirt] [PATCH] esx: Move the Event type from the VI generator to manually written code

2011-05-14 Thread Matthias Bolte
2011/5/13 Eric Blake ebl...@redhat.com: On 05/01/2011 01:57 PM, Matthias Bolte wrote: Accept all types on deserialization in order to accept all Event subtypes. This will be used for the upcoming domain event support. ---  src/esx/esx_vi_generator.input |   21  src/esx

Re: [libvirt] [PATCH] esx: Generate implicit _this macros

2011-05-14 Thread Matthias Bolte
2011/5/13 Eric Blake ebl...@redhat.com: On 05/01/2011 01:57 PM, Matthias Bolte wrote: ---  src/Makefile.am             |    1 +  src/esx/esx_vi_generator.py |   48 --  src/esx/esx_vi_methods.c    |   40 +++  3 files

Re: [libvirt] [PATCH] esx: Remove 1000 lines of generated but unused code

2011-05-14 Thread Matthias Bolte
2011/5/13 Eric Blake ebl...@redhat.com: On 05/01/2011 01:57 PM, Matthias Bolte wrote: Don't make all object and enum types (de)serializable by default. Detect this from the input file instead. ---  src/esx/esx_vi_generator.py |  167 +++---  1 files

Re: [libvirt] [PATCH] esx: Improve list usage detection in the generator

2011-05-14 Thread Matthias Bolte
2011/5/13 Eric Blake ebl...@redhat.com: On 05/01/2011 01:57 PM, Matthias Bolte wrote: Detect it based on usage as parameter and return type too. ---  src/esx/esx_vi_generator.py |   41 +++--  1 files changed, 31 insertions(+), 10 deletions(-) Again, my

Re: [libvirt] [PATCH] esx: Improve dynamic cast detection in the generator

2011-05-14 Thread Matthias Bolte
2011/5/13 Eric Blake ebl...@redhat.com: On 05/01/2011 01:57 PM, Matthias Bolte wrote: Detect it based on usage as parameter, return type and member of other object types. ---  src/esx/esx_vi_generator.py |   32 ++--  1 files changed, 18 insertions(+), 14 deletions

Re: [libvirt] [PATCH] esx: Refactor common code in the generator

2011-05-14 Thread Matthias Bolte
2011/5/13 Eric Blake ebl...@redhat.com: On 05/01/2011 01:57 PM, Matthias Bolte wrote: Move common code from Property and Paramater into new Member class. s/Paramater/Parameter/ That's one of my common typos. It seems impossible for me to get it right in the first attempt :) Rename

Re: [libvirt] [PATCH] esx: Change generated method parameter autobinding

2011-05-14 Thread Matthias Bolte
2011/5/13 Eric Blake ebl...@redhat.com: On 05/01/2011 01:57 PM, Matthias Bolte wrote: Instead of specifing the type of the managed object directly specify s/specifing/specifying/ the ServiceContent member name. This way the mapping dictionary can be removed. ---  src/esx

Re: [libvirt] [PATCH] esx: Change some alignments in the input file

2011-05-14 Thread Matthias Bolte
2011/5/1 Matthias Bolte matthias.bo...@googlemail.com: No functional change included. ---  src/esx/esx_vi_generator.input |  122  1 files changed, 61 insertions(+), 61 deletions(-) -method RetrieveProperties returns ObjectContent ol

Re: [libvirt] libvirt, FreeBSD portability inquiry

2011-05-14 Thread Matthias Bolte
2011/5/14 Jason Helfman jhelf...@e-e.com: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On Sat, May 14, 2011 at 09:36:17AM +0200, Matthias Bolte thus spake: 2011/5/14 Jason Helfman jhelf...@e-e.com: On Sat, May 14, 2011 at 08:45:41AM +0200, Matthias Bolte thus spake: 2011/5/14 Jason

[libvirt] FreeBSD and sys/syslimits.h

2011-05-14 Thread Matthias Bolte
libvirtd.h includes sys/syslimits.h if available. On FreeBSD the header contains this warning: In file included from libvirtd.h:42, from dispatch.h:28, from dispatch.c:30: /usr/include/sys/syslimits.h:41:2: warning: #warning No user-serviceable parts inside.

[libvirt] FreeBSD and sysconf(_SC_GETPW_R_SIZE_MAX)

2011-05-14 Thread Matthias Bolte
On FreeBSD virsh fails to enter interactive mode because vshReadlineInit fails, because virGetUserDirectory fails, because virGetUserEnt fails, because sysconf(_SC_GETPW_R_SIZE_MAX) returns -1 and sets errno to EINVAL. Is this something that gnulib should/could deal with, Eric? Or should we work

Re: [libvirt] libvirt, FreeBSD portability inquiry

2011-05-14 Thread Matthias Bolte
2011/5/14 Jason Helfman jhelf...@e-e.com: 2011/5/14 Jason Helfman jhelf...@e-e.com: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On Sat, May 14, 2011 at 09:36:17AM +0200, Matthias Bolte thus spake: 2011/5/14 Jason Helfman jhelf...@e-e.com: On Sat, May 14, 2011 at 08:45:41AM +0200

[libvirt] [PATCH] virsh: Report an error when virGetUserDirectory fails

2011-05-14 Thread Matthias Bolte
Otherwise virsh shows the interactive greeting and the silently exists instead of enterting interactive mode. --- tools/virsh.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 3baa015..356e0ae 100644 --- a/tools/virsh.c +++

[libvirt] [PATCH] time_t is not a long on FreeBSD, need to add casts

2011-05-13 Thread Matthias Bolte
--- src/conf/domain_conf.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d3efec6..875f90e 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -9115,7 +9115,7 @@ virDomainSnapshotDefPtr

[libvirt] [PATCH] virsh: Fix uninitialized variable warning

2011-05-13 Thread Matthias Bolte
Reported on FreeBSD only. --- tools/virsh.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index fbeb7c8..3baa015 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -11131,7 +11131,7 @@ vshCmddefHelp(vshControl *ctl, const char *cmdname)

[libvirt] [PATCH] virsh: time_t is not a long on FreeBSD

2011-05-13 Thread Matthias Bolte
localtime_r expects time_t. --- tools/virsh.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 3baa015..93a504e 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -10406,7 +10406,8 @@ cmdSnapshotList(vshControl *ctl, const vshCmd

Re: [libvirt] libvirt, FreeBSD portability inquiry

2011-05-13 Thread Matthias Bolte
2011/5/12 Jason Helfman jhelf...@e-e.com: Hi, I am interested in porting libvirt to FreeBSD, and am curious if there may be anything that may not be possible at this point in respect to the libvirt source code to be aware of. Here is the log of the build of the software: I know it has been

Re: [libvirt] [PATCH] configure: Fix mpath check on non-Linux systems

2011-05-13 Thread Matthias Bolte
2011/5/13 Daniel P. Berrange berra...@redhat.com: On Fri, May 13, 2011 at 07:51:24AM +0200, Matthias Bolte wrote: ---  configure.ac |   14 +-  1 files changed, 9 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index a2ce97e..4f5c2d7 100644

[libvirt] [PATCH] apparmor: Fix compilation by removing remains from virCommand conversion

2011-05-13 Thread Matthias Bolte
Commit aaf20355b87d3bfda7579a7f6a4a978e848635c3 was incomplete here and missed to remove some parts. --- Pushing this one under the build breaker rule. src/security/security_apparmor.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/src/security/security_apparmor.c

Re: [libvirt] [PATCH] virsh: Fix uninitialized variable warning

2011-05-13 Thread Matthias Bolte
2011/5/13 Daniel P. Berrange berra...@redhat.com: On Fri, May 13, 2011 at 08:29:00AM +0200, Matthias Bolte wrote: Reported on FreeBSD only. ---  tools/virsh.c |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index fbeb7c8..3baa015

Re: [libvirt] [PATCH] command: Fix compilation on FreeBSD

2011-05-13 Thread Matthias Bolte
2011/5/13 Eric Blake ebl...@redhat.com: On 05/12/2011 11:53 PM, Matthias Bolte wrote: kill, SIGTERM and SIGKILL require additional headers. ---  src/util/command.c |    2 ++  1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/util/command.c b/src/util/command.c index b488d55

Re: [libvirt] [PATCH] remote generator: Add skipgen/autogen flags to .x files

2011-05-12 Thread Matthias Bolte
2011/5/12 Eric Blake ebl...@redhat.com: On 05/11/2011 01:28 PM, Matthias Bolte wrote: Make procedure parsing more robust, by allowing arbitrary amounts of whitespaces. Also make some error messages more verbose. ---  cfg.mk                       |    2 +-  daemon/remote_generator.pl

[libvirt] [PATCH] configure: Fix mpath check on non-Linux systems

2011-05-12 Thread Matthias Bolte
--- configure.ac | 14 +- 1 files changed, 9 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index a2ce97e..4f5c2d7 100644 --- a/configure.ac +++ b/configure.ac @@ -1667,11 +1667,15 @@ if test $with_storage_scsi = check; then fi

[libvirt] [PATCH] command: Fix compilation on FreeBSD

2011-05-12 Thread Matthias Bolte
kill, SIGTERM and SIGKILL require additional headers. --- src/util/command.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/util/command.c b/src/util/command.c index b488d55..b2a873b 100644 --- a/src/util/command.c +++ b/src/util/command.c @@ -22,9 +22,11 @@

[libvirt] [PATCH] remote generator: Add skipgen/autogen flags to .x files

2011-05-11 Thread Matthias Bolte
Make procedure parsing more robust, by allowing arbitrary amounts of whitespaces. Also make some error messages more verbose. --- cfg.mk |2 +- daemon/remote_generator.pl | 165 --- src/remote/qemu_protocol.x |5 +- src/remote/remote_protocol.x |

Re: [libvirt] [PATCH] apparmor: Fix uninitalized variable warning in virt-aa-helper

2011-05-10 Thread Matthias Bolte
2011/5/8 Jamie Strandboge ja...@strandboge.com: On Sat, 7 May 2011 13:13:41 +0200, Matthias Bolte matthias.bo...@googlemail.com wrote: ---  src/security/virt-aa-helper.c |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/security/virt-aa-helper.c b/src/security

Re: [libvirt] [PATCH 5/5] remote generator: Move blacklist to a file and add explicit whitelist

2011-05-10 Thread Matthias Bolte
2011/5/9 Eric Blake ebl...@redhat.com: On 05/07/2011 06:28 AM, Matthias Bolte wrote: ---  daemon/Makefile.am                 |   20 -  daemon/qemu_dispatch.blacklist     |    3 +  daemon/qemu_dispatch.whitelist     |    1 +  daemon/remote_dispatch.blacklist   |   37  daemon

[libvirt] [PATCH] Fix two uninitialized variable warnings

2011-05-10 Thread Matthias Bolte
gcc only reports them when compiling with -O3. --- src/util/interface.c |2 +- tools/virsh.c|2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/interface.c b/src/util/interface.c index 5e1987a..04a922c 100644 --- a/src/util/interface.c +++

Re: [libvirt] [PATCH v3 1/8] screenshot: Defining the public API

2011-05-10 Thread Matthias Bolte
2011/5/10 Michal Privoznik mpriv...@redhat.com: Add public API for taking screenshots of current domain console. * include/libvirt/libvirt.h.in: add virDomainScreenshot * src/libvirt_public.syms: Export new symbol ---  include/libvirt/libvirt.h.in |    7 +++  src/libvirt_public.syms    

Re: [libvirt] [PATCH] Fix two uninitialized variable warnings

2011-05-10 Thread Matthias Bolte
2011/5/10 Wen Congyang we...@cn.fujitsu.com: At 05/10/2011 02:40 PM, Matthias Bolte Write: gcc only reports them when compiling with -O3. I compile libvirt with -O3, and recieve the same warnings. ACK. Thanks, pushed. Matthias -- libvir-list mailing list libvir-list@redhat.com https

Re: [libvirt] [PATCH 5/5] remote generator: Move blacklist to a file and add explicit whitelist

2011-05-10 Thread Matthias Bolte
2011/5/10 Daniel P. Berrange berra...@redhat.com: On Mon, May 09, 2011 at 03:45:29PM -0600, Eric Blake wrote: On 05/07/2011 06:28 AM, Matthias Bolte wrote: ---  daemon/Makefile.am                 |   20 -  daemon/qemu_dispatch.blacklist     |    3 +  daemon/qemu_dispatch.whitelist

Re: [libvirt] [PATCH 00/12] esx: Generator improvments and general cleanups

2011-05-10 Thread Matthias Bolte
2011/5/1 Matthias Bolte matthias.bo...@googlemail.com: As we're currently in feature freeze, this series is meant for 0.9.2. It includes mostly generator improvments and general cleanups. 10/12 is a race condition fix, but it's not critical because it's not that simple to trigger. Matthias

Re: [libvirt] [PATCH 5/5] remote generator: Move blacklist to a file and add explicit whitelist

2011-05-10 Thread Matthias Bolte
2011/5/10 Daniel P. Berrange berra...@redhat.com: On Tue, May 10, 2011 at 05:23:23PM +0200, Matthias Bolte wrote: 2011/5/10 Daniel P. Berrange berra...@redhat.com: On Mon, May 09, 2011 at 03:45:29PM -0600, Eric Blake wrote: On 05/07/2011 06:28 AM, Matthias Bolte wrote: ---  daemon

Re: [libvirt] [PATCH 1/5] Rename internal DumpXML functions to GetXMLDesc

2011-05-10 Thread Matthias Bolte
2011/5/9 Eric Blake ebl...@redhat.com: On 05/07/2011 06:28 AM, Matthias Bolte wrote: This matches the public API and helps to get rid of some speical case s/speical/special/ code in the remote generator. Rename driver API functions and XDR protocol structs. No functional change included

Re: [libvirt] [PATCH 2/5] remote generator: Fix comment ignoring regex

2011-05-10 Thread Matthias Bolte
2011/5/9 Eric Blake ebl...@redhat.com: On 05/07/2011 06:28 AM, Matthias Bolte wrote: ---  daemon/remote_generator.pl |    4 ++--  1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/daemon/remote_generator.pl b/daemon/remote_generator.pl index b06e51a..8d62c37 100755 --- a/daemon

Re: [libvirt] [PATCH 3/5] remote generator: Unify unsigned int notation in .x files

2011-05-10 Thread Matthias Bolte
2011/5/9 Eric Blake ebl...@redhat.com: On 05/07/2011 06:28 AM, Matthias Bolte wrote: Rename u_int and unsigned to unsigned int. This gets rid of some special case code in the generator. ---  daemon/remote_generator.pl   |   10 +++---  src/remote/remote_protocol.x |   72

<    3   4   5   6   7   8   9   10   11   12   >