2011/4/16 Eric Blake ebl...@redhat.com:
On 04/16/2011 03:31 AM, Matthias Bolte wrote:
Also mark error messages in block_stats.c for translation, add the
new macro to the msg_gen functions in cfg.mk and add block_stats.c
to po/POTFILES.in
---
cfg.mk | 1 +
po/POTFILES.in
Inspired by Eric Blake
---
cfg.mk | 45 ++---
src/interface/netcf_driver.c | 43 ++-
src/nodeinfo.c |2 +-
src/phyp/phyp_driver.c | 18
2011/4/17 Richard Laager rlaa...@wiktel.com:
I think this change is pretty self-explanatory.
Richard
ACK.
I added you to the authors list and applied the patch, thanks.
Matthias
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
2011/4/14 Eric Blake ebl...@redhat.com:
Rather than copying and pasting lots of code, factor it into a
single helper function.
* src/phyp/phyp_driver.c (phypExecInt): New function.
(phypGetVIOSPartitionID, phypNumDomainsGeneric, phypGetLparID)
(phypGetLparMem, phypGetLparCPUGeneric,
2011/4/15 Eric Blake ebl...@redhat.com:
On 04/15/2011 03:01 PM, Matthias Bolte wrote:
+ str = phypExecBuffer(session, buf, ret, conn, true);
+ if (!str || ret) {
+ VIR_FREE(str);
+ return -1;
+ }
+ ret = virStrToLong_i(str, NULL, 10, result);
You made the parsing
And from all related macros and functions.
---
I posted v1 a year ago :)
https://www.redhat.com/archives/libvir-list/2010-April/msg00164.html
src/conf/cpu_conf.c |2 +-
src/conf/domain_conf.c |2 +-
src/conf/domain_event.c |2 +-
Also mark error messages in block_stats.c for translation, add the
new macro to the msg_gen functions in cfg.mk and add block_stats.c
to po/POTFILES.in
---
cfg.mk|1 +
po/POTFILES.in|1 +
src/xen/block_stats.c | 79 ++--
Accept all types on deserialization in order to accept all Event subtypes.
This will be used for the upcoming domain event support.
---
src/esx/esx_vi_generator.input | 21
src/esx/esx_vi_generator.py|1 -
src/esx/esx_vi_types.c | 100
2011/4/15 Wen Congyang we...@cn.fujitsu.com:
commit d4601696 introduces two more generated files: esx_vi.generated.h
and esx_vi.generated.h. But we do not include them into dist file.
It will break building if using dist file to build.
---
src/Makefile.am | 4 +++-
1 files changed, 3
2011/4/15 KAMEZAWA Hiroyuki kamezawa.hir...@jp.fujitsu.com:
Per (host) cpu activity of VMs are very insterested numbers
when running VMs on large SMPs. virt-top -1 mode tries to
provide the information. (But it's not implemented.)
This patch adds a libvirt interface to get per cpu statistics
2011/4/14 Eric Blake ebl...@redhat.com:
It costs quite a few processor cycles to go through printf parsing
just to determine that we only meant to append.
- virBufferVSprintf(buf, %s, k);
- virBufferVSprintf(buf, %s, =);
- virBufferVSprintf(buf, %s, v);
+
2011/4/14 Eric Blake ebl...@redhat.com:
Ever since commit ebc46f, the destroy function built two command
variants but only used one. I went with the variant that matches
the idiom used in the counterpart of phypBuildStoragePool.
* src/phyp/phyp_driver.c (phypDestroyStoragePool): Avoid
2011/4/14 Eric Blake ebl...@redhat.com:
* src/phyp/phyp_driver.c (phypUUIDTable_Init): Avoid memory leak
on error.
---
src/phyp/phyp_driver.c | 46 +++---
1 files changed, 27 insertions(+), 19 deletions(-)
ACK.
Matthias
--
libvir-list mailing
2011/4/14 Eric Blake ebl...@redhat.com:
* src/phyp/phyp_driver.c (phypInterfaceDestroy)
(phypInterfaceDefineXML, phypInterfaceLookupByName)
(phypInterfaceIsActive, phypListInterfaces, phypNumOfInterfaces):
Clean up return handling of recent additions.
---
src/phyp/phyp_driver.c | 130
2011/4/14 Eric Blake ebl...@redhat.com:
* src/phyp/phyp_driver.c: Match label style of rest of project.
(phypExec, phypUUIDTable_Pull): Drop an extra label.
---
src/phyp/phyp_driver.c | 129
+++-
1 files changed, 62 insertions(+), 67
2011/4/14 Eric Blake ebl...@redhat.com:
* src/phyp/phyp_driver.c (phypUUIDTable_AddLpar)
(phypGetLparUUID, phypGetStoragePoolUUID, phypVolumeGetXMLDesc)
(phypGetStoragePoolXMLDesc): Use faster method.
---
src/phyp/phyp_driver.c | 10 +-
1 files changed, 5 insertions(+), 5
2011/4/14 Eric Blake ebl...@redhat.com:
Use the name 'ret' for all phypExec results, to make it easier
to wrap phypExec. Don't allow a possibly NULL ret through printf.
* src/phyp/phyp_driver.c (phypBuildVolume, phypDestroyStoragePool)
(phypBuildStoragePool, phypBuildLpar): Avoid NULL
2011/4/14 Eric Blake ebl...@redhat.com:
* src/phyp/phyp_driver.c (phypExecBuffer): New function. Use it
throughout file for less code, and for plugging a few leaks.
---
Amazing how much copy-and-paste code this consolidated.
src/phyp/phyp_driver.c | 803
2011/4/14 Eric Blake ebl...@redhat.com:
Rather than copying and pasting lots of code, factor it into a
single helper function.
* src/phyp/phyp_driver.c (phypExecInt): New function.
(phypGetVIOSPartitionID, phypNumDomainsGeneric, phypGetLparID)
(phypGetLparMem, phypGetLparCPUGeneric,
2011/4/15 Matthias Bolte matthias.bo...@googlemail.com:
2011/4/15 Wen Congyang we...@cn.fujitsu.com:
commit d4601696 introduces two more generated files: esx_vi.generated.h
and esx_vi.generated.h. But we do not include them into dist file.
It will break building if using dist file to build
2011/4/11 Daniel Veillard veill...@redhat.com:
On Sat, Apr 09, 2011 at 11:59:07AM +0200, Matthias Bolte wrote:
Don't pre-allocate 4kb per key, make phypVolumeGetKey allocate the memory.
Make phypBuildVolume return the volume key instead of using pre-allocated
memory to store it.
Also fix
2011/4/11 Daniel Veillard veill...@redhat.com:
On Sat, Apr 09, 2011 at 11:59:08AM +0200, Matthias Bolte wrote:
Also fix memory leaks along the way in phypCreateServerSCSIAdapter and
phypAttachDevice.
---
src/phyp/phyp_driver.c | 592
+++-
1
2011/4/11 Daniel Veillard veill...@redhat.com:
On Sat, Apr 09, 2011 at 11:59:09AM +0200, Matthias Bolte wrote:
---
src/phyp/phyp_driver.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c
index f441261..24165fb 100644
2011/4/11 Daniel Veillard veill...@redhat.com:
On Sat, Apr 09, 2011 at 11:59:11AM +0200, Matthias Bolte wrote:
---
src/phyp/phyp_driver.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c
index 226946d..f36b357 100644
2011/4/11 Eric Blake ebl...@redhat.com:
On 04/10/2011 07:03 AM, Matthias Bolte wrote:
Reported by Igor Galić
---
docs/formatdomain.html.in | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 574fee5
2011/4/12 Daniel Veillard veill...@redhat.com:
On Sun, Apr 10, 2011 at 01:26:47PM +0200, Matthias Bolte wrote:
---
src/esx/esx_vi_generator.py | 177
+--
1 files changed, 71 insertions(+), 106 deletions(-)
diff --git a/src/esx/esx_vi_generator.py b
2011/4/12 Daniel Veillard veill...@redhat.com:
On Sun, Apr 10, 2011 at 01:27:19PM +0200, Matthias Bolte wrote:
Add CastFromAnyType functions for the String type.
---
src/esx/esx_vi_generator.py | 5 +--
src/esx/esx_vi_types.c | 64
+++---
src
2011/4/13 Daniel Veillard veill...@redhat.com:
On Sun, Apr 10, 2011 at 01:27:56PM +0200, Matthias Bolte wrote:
Generate lookup functions for managed object types.
---
src/esx/esx_vi.c | 414
+++-
src/esx/esx_vi.h | 2
2011/4/11 Eric Blake ebl...@redhat.com:
On 04/10/2011 05:28 AM, Matthias Bolte wrote:
---
src/esx/esx_vi_types.c | 20 ++--
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/src/esx/esx_vi_types.c b/src/esx/esx_vi_types.c
index 9e23030..29a3c39 100644
2011/4/11 Eric Blake ebl...@redhat.com:
On 04/10/2011 09:18 AM, Matthias Bolte wrote:
This will be used to make esxVI_Context clonable.
Also move cleanup code for esxPrivate to esxFreePrivate().
---
src/esx/esx_driver.c | 103
-
src/esx
2011/4/14 Eric Blake ebl...@redhat.com:
On 04/13/2011 04:07 PM, Eric Blake wrote:
Phyp still had several memory leaks and in general some bad
copy-and-paste design. This series consolidates some common
patterns into simpler helpers, avoiding leaks in the process.
Eric Blake (4):
phyp:
2011/4/14 Christophe Fergeau cferg...@redhat.com:
gcc 4.6 warns when a variable is initialized but isn't used afterwards:
vmware/vmware_driver.c:449:18: warning: variable 'vmxPath' set but not used
[-Wunused-but-set-variable]
This patch fixes these warnings. There are still 2 offending
2011/4/14 Eric Blake ebl...@redhat.com:
On 04/14/2011 06:00 AM, Matthias Bolte wrote:
ACK, we just need to make sure contains_specialcharacters() and
escape_specialcharacters() don't diverge on the charater set. Maybe
add a comment in escape_specialcharacters() to this effect.
Daniel
I
2011/4/14 Christophe Fergeau cferg...@redhat.com:
On Thu, Apr 14, 2011 at 06:44:25PM +0200, Matthias Bolte wrote:
I can take care of that and I'll post a speculative patch for it as I
don't have a gcc 4.6 at hand right now to test it my self.
I can easily test it, I'll let you know how
This is a speculative patch as I don't have gcc 4.6 at hand to test it.
Matthias
From ed18b790a1e0248f35f48d464f45c17b4f4d0cee Mon Sep 17 00:00:00 2001
From: Matthias Bolte matthias.bo...@googlemail.com
Date: Thu, 14 Apr 2011 19:14:38 +0200
Subject: [PATCH] esx: Fix gcc 4.6 warning about
2011/4/14 Christophe Fergeau cferg...@redhat.com:
---
src/vbox/vbox_tmpl.c | 11 ---
1 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c
index 0fbfba5..a7d78df 100644
--- a/src/vbox/vbox_tmpl.c
+++ b/src/vbox/vbox_tmpl.c
@@
Long summary line. You could reformat it like this:
esx: Support virsh net-list and net-info
Add mapping of Network object and implementation of select
networking functions.
This makes virsh net-list and net-info commands work for ESX.
2011/4/12 jbarkley james.bark...@gmail.com:
From:
---
src/esx/esx_vi_generator.py | 177 +--
1 files changed, 71 insertions(+), 106 deletions(-)
diff --git a/src/esx/esx_vi_generator.py b/src/esx/esx_vi_generator.py
index 3d068f3..622a34a 100755
--- a/src/esx/esx_vi_generator.py
+++
Add CastFromAnyType functions for the String type.
---
src/esx/esx_vi_generator.py |5 +--
src/esx/esx_vi_types.c | 64 +++---
src/esx/esx_vi_types.h |2 +
3 files changed, 51 insertions(+), 20 deletions(-)
diff --git
---
src/esx/esx_vi_types.c | 20 ++--
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/src/esx/esx_vi_types.c b/src/esx/esx_vi_types.c
index 9e23030..29a3c39 100644
--- a/src/esx/esx_vi_types.c
+++ b/src/esx/esx_vi_types.c
@@ -77,12 +77,12 @@
int
This options are shortcuts to set name and description of a snapshot.
Suggested by Elias Probst
---
I'm not sure if this is be best approach. In case of the vol-* commands there
is vol-create that takes and XML file and vol-create-as that takes a set of
arguments.
So, should there actually be a
2011/4/10 Daniel Veillard veill...@redhat.com:
On Sat, Apr 09, 2011 at 12:05:17PM +0200, Matthias Bolte wrote:
---
src/xen/block_stats.c | 51
+
1 files changed, 26 insertions(+), 25 deletions(-)
diff --git a/src/xen/block_stats.c b/src
Reported by Igor Galić
---
docs/formatdomain.html.in |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 574fee5..ea021e8 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -1807,7 +1807,7
---
src/esx/esx_driver.c |4 +-
src/esx/esx_vi.c | 348 ++
src/esx/esx_vi.h | 29 +++-
3 files changed, 205 insertions(+), 176 deletions(-)
diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c
index deda372..ef76350 100644
---
To be used to share a CURL handle between multiple threads in the
upcoming domain event support.
---
src/esx/esx_vi.c | 176 ++
src/esx/esx_vi.h | 19 ++
2 files changed, 195 insertions(+), 0 deletions(-)
diff --git a/src/esx/esx_vi.c
/esx/esx_driver.c b/src/esx/esx_driver.c
index ef76350..bfb3c16 100644
--- a/src/esx/esx_driver.c
+++ b/src/esx/esx_driver.c
@@ -3,7 +3,7 @@
* esx_driver.c: core driver functions for managing VMware ESX hosts
*
* Copyright (C) 2010-2011 Red Hat, Inc.
- * Copyright (C) 2009-2010 Matthias Bolte
This series covers several things I came across while improving the
semantic of phypVolumeGetKey.
Matthias
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
sizeof(domain-name) is the wrong thing. Instead of using strdup here
rewrite escape_specialcharacters to allocate the buffer itself.
Add a contains_specialcharacters to be used in phypOpen, as phypOpen is
not interested in the escaped version.
---
src/phyp/phyp_driver.c | 90
Don't pre-allocate 4kb per key, make phypVolumeGetKey allocate the memory.
Make phypBuildVolume return the volume key instead of using pre-allocated
memory to store it.
Also fix a memory leak in phypVolumeLookupByName when phypVolumeGetKey
fails. Fix another memory leak in phypVolumeLookupByPath
Also fix memory leaks along the way in phypCreateServerSCSIAdapter and
phypAttachDevice.
---
src/phyp/phyp_driver.c | 592 +++-
1 files changed, 289 insertions(+), 303 deletions(-)
diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c
index
---
src/phyp/phyp_driver.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c
index 226946d..f36b357 100644
--- a/src/phyp/phyp_driver.c
+++ b/src/phyp/phyp_driver.c
@@ -2000,7 +2000,6 @@ phypAttachDevice(virDomainPtr domain,
---
src/xen/block_stats.c | 51 +
1 files changed, 26 insertions(+), 25 deletions(-)
diff --git a/src/xen/block_stats.c b/src/xen/block_stats.c
index e7c80c9..1918257 100644
--- a/src/xen/block_stats.c
+++ b/src/xen/block_stats.c
@@ -113,34
---
src/phyp/phyp_driver.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c
index f441261..24165fb 100644
--- a/src/phyp/phyp_driver.c
+++ b/src/phyp/phyp_driver.c
@@ -210,7 +210,7 @@ phypGetSystemType(virConnectPtr conn)
2011/4/6 computern...@rambler.ru computern...@rambler.ru:
Hello,
I am trying to create the virtual disk over virsh. My target is the ESX
server that is a part of the vCenter. That is why I connect to it using the
vpx://-like URL. The connection itself is being established correctly.
Commands
at 2:37 AM, Matthias Bolte
matthias.bo...@googlemail.com wrote:
Sorry, I forgot to reply to your follow up question on the users list.
2011/4/6 James Barkley james.bark...@gmail.com:
Greetings:
I've added code to the ESX driver to support some basic network
functionality. I'm pretty new
Sorry, I forgot to reply to your follow up question on the users list.
2011/4/6 James Barkley james.bark...@gmail.com:
Greetings:
I've added code to the ESX driver to support some basic network
functionality. I'm pretty new to this list, so please tell me how to proceed
with code review and
2011/4/6 Wen Congyang we...@cn.fujitsu.com:
This bug was introduce by commit 57162db8, and it will cause libvirtd crashed.
---
src/util/pci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/util/pci.c b/src/util/pci.c
index 6ed96f4..a7b8caa 100644
---
2011/4/4 Eric Blake ebl...@redhat.com:
On 04/04/2011 12:28 AM, Matthias Bolte wrote:
2011/4/4 Daniel Veillard veill...@redhat.com:
On Sun, Apr 03, 2011 at 02:43:55PM +0200, Matthias Bolte wrote:
ACK, while nice, it may be a bit late for 0.9.0, okay to wait for the
next cycle ? We already
2011/4/4 Daniel Veillard veill...@redhat.com:
On Sun, Apr 03, 2011 at 02:19:14PM +0200, Matthias Bolte wrote:
---
src/vmx/vmx.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c
index 9f4d5fb..9a482ef 100644
--- a/src/vmx/vmx.c
2011/4/4 Daniel P. Berrange berra...@redhat.com:
On Sun, Apr 03, 2011 at 11:21:13AM +0200, Matthias Bolte wrote:
This is meant for post-0.9.0.
The series removes many large stack allocations from the code base and makes
it compile with -Wframe-larger-than=2500. This was inspired by Dan's
2011/4/4 Daniel Veillard veill...@redhat.com:
On Sun, Apr 03, 2011 at 02:43:55PM +0200, Matthias Bolte wrote:
---
src/vmx/vmx.c | 43
++
tests/vmx2xmldata/vmx2xml-case-insensitive-1.vmx | 2 +-
tests/vmx2xmldata/vmx2xml-case
2011/4/4 Daniel P. Berrange berra...@redhat.com:
On Mon, Apr 04, 2011 at 11:03:10AM +0900, Minoru Usui wrote:
Hi, Matthias.
On Fri, 1 Apr 2011 20:22:17 +0200
Matthias Bolte matthias.bo...@googlemail.com wrote:
2011/4/1 Eric Blake ebl...@redhat.com:
On 03/31/2011 07:55 PM, Minoru Usui
---
src/storage/storage_backend_iscsi.c | 11 ---
1 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/storage/storage_backend_iscsi.c
b/src/storage/storage_backend_iscsi.c
index 6eff5f5..2e2e99e 100644
--- a/src/storage/storage_backend_iscsi.c
+++
Removes multiple 4kb stack allocations.
---
src/libvirt.c | 113 +
1 files changed, 42 insertions(+), 71 deletions(-)
diff --git a/src/libvirt.c b/src/libvirt.c
index 8be18d4..25f8d41 100644
--- a/src/libvirt.c
+++ b/src/libvirt.c
@@
---
src/xenxs/xen_xm.c | 14 ++
1 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/src/xenxs/xen_xm.c b/src/xenxs/xen_xm.c
index 0acd120..22ad788 100644
--- a/src/xenxs/xen_xm.c
+++ b/src/xenxs/xen_xm.c
@@ -211,6 +211,7 @@ xenParseXM(virConfPtr conf, int
---
src/xen/xend_internal.c | 12 ++--
1 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/src/xen/xend_internal.c b/src/xen/xend_internal.c
index 8859373..8b07a8a 100644
--- a/src/xen/xend_internal.c
+++ b/src/xen/xend_internal.c
@@ -279,11 +279,17 @@ istartswith(const char
Replace openvz_readline with getline in several places to get rid of stack
allocated buffers to hold lines.
openvzReadConfigParam allocates memory for return values instead of
expecting a preexisting buffer.
---
src/openvz/openvz_conf.c | 141 +++-
Removing a 4kb stack allocation.
Reduce stack buffer for virStrerror to the common 1kb instead of 4kb.
---
src/qemu/qemu_process.c | 16
1 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 90fcea0..fc9fdae
---
src/phyp/phyp_driver.c | 13 +++--
1 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c
index fe2e99d..76207c2 100644
--- a/src/phyp/phyp_driver.c
+++ b/src/phyp/phyp_driver.c
@@ -2362,13 +2362,22 @@
---
src/xen/block_stats.c | 52 +---
1 files changed, 27 insertions(+), 25 deletions(-)
diff --git a/src/xen/block_stats.c b/src/xen/block_stats.c
index e7c80c9..6b4171d 100644
--- a/src/xen/block_stats.c
+++ b/src/xen/block_stats.c
@@ -113,34
---
src/uml/uml_driver.c | 10 +++---
1 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/src/uml/uml_driver.c b/src/uml/uml_driver.c
index e2bd5f2..33849a0 100644
--- a/src/uml/uml_driver.c
+++ b/src/uml/uml_driver.c
@@ -1036,21 +1036,25 @@ static char
---
tools/virsh.c | 23 +--
1 files changed, 17 insertions(+), 6 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index 19e3449..99da054 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -2052,7 +2052,7 @@ cmdDominfo(vshControl *ctl, const vshCmd *cmd)
---
src/qemu/qemu_command.c | 43 ++-
1 files changed, 30 insertions(+), 13 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 3138943..326a6b3 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -3318,7
Removes 4kb stack allocation in the XenD subdriver.
---
src/util/sexpr.c| 142 +++
src/util/sexpr.h|3 +-
src/xen/xend_internal.c | 17 +-
3 files changed, 86 insertions(+), 76 deletions(-)
diff --git a/src/util/sexpr.c
---
daemon/remote.c | 20 ++--
1 files changed, 14 insertions(+), 6 deletions(-)
diff --git a/daemon/remote.c b/daemon/remote.c
index 1700c2d..dd85ef1 100644
--- a/daemon/remote.c
+++ b/daemon/remote.c
@@ -1607,7 +1607,7 @@ remoteDispatchDomainGetSecurityLabel(struct
---
src/util/ebtables.c | 44 +---
1 files changed, 29 insertions(+), 15 deletions(-)
diff --git a/src/util/ebtables.c b/src/util/ebtables.c
index e3b8da4..27dce5d 100644
--- a/src/util/ebtables.c
+++ b/src/util/ebtables.c
@@ -266,29 +266,43 @@
Move the buffers to the heap allocated client/private data structs.
---
daemon/libvirtd.c | 10 ++
daemon/libvirtd.h |1 +
src/remote/remote_driver.c |8 +---
3 files changed, 12 insertions(+), 7 deletions(-)
diff --git a/daemon/libvirtd.c
Allocate on the heap instead.
---
src/phyp/phyp_driver.c | 13 +++--
1 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c
index 51f9ff6..fe2e99d 100644
--- a/src/phyp/phyp_driver.c
+++ b/src/phyp/phyp_driver.c
@@ -115,12 +115,18
Use virAsprintf instead of snprintf.
---
src/util/pci.c | 172 +---
1 files changed, 127 insertions(+), 45 deletions(-)
diff --git a/src/util/pci.c b/src/util/pci.c
index 8d2dbb0..6ed96f4 100644
--- a/src/util/pci.c
+++ b/src/util/pci.c
@@
Make virFileBuildPath operate on the heap instead of the stack. It
allocates a buffer instead of expecting a preexisting buffer.
---
src/conf/nwfilter_conf.c | 21 +++--
src/conf/storage_conf.c | 44 +++-
src/util/util.c | 29
---
src/security/virt-aa-helper.c | 46 +
1 files changed, 28 insertions(+), 18 deletions(-)
diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c
index 77df514..bb716e6 100644
--- a/src/security/virt-aa-helper.c
+++
---
src/util/util.c |9 -
1 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/src/util/util.c b/src/util/util.c
index 31feecc..c0391ad 100644
--- a/src/util/util.c
+++ b/src/util/util.c
@@ -1901,14 +1901,13 @@ int virFileOpenTtyAt(const char *ptmx,
}
if
This is meant for post-0.9.0.
The series removes many large stack allocations from the code base and makes
it compile with -Wframe-larger-than=2500. This was inspired by Dan's patch for
using gnulib's manywarnings warnings modules [1]. Where he mentioned that
currently -Wframe-larger-than=20480
---
src/vmx/vmx.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c
index 9f4d5fb..9a482ef 100644
--- a/src/vmx/vmx.c
+++ b/src/vmx/vmx.c
@@ -730,7 +730,7 @@ virVMXGetConfigLong(virConfPtr conf, const char *name, long
long *number,
---
src/vmx/vmx.c| 43 ++
tests/vmx2xmldata/vmx2xml-case-insensitive-1.vmx |2 +-
tests/vmx2xmldata/vmx2xml-case-insensitive-1.xml |3 ++
tests/vmx2xmldata/vmx2xml-case-insensitive-2.xml |3 ++
2011/4/1 Eric Blake ebl...@redhat.com:
Even with -Wuninitialized (which is part of autobuild.sh
--enable-compile-warnings=error), gcc does NOT catch this
use of an uninitialized variable:
{
if (cond)
goto error;
int a = 1;
error:
printf(%d, a);
}
which prints 0 (if the stack was
2011/3/31 Justin Clift jcl...@redhat.com:
On 01/04/2011, at 12:44 AM, Daniel P. Berrange wrote:
On Wed, Mar 30, 2011 at 02:16:28AM +1100, Justin Clift wrote:
snip
Same problem with virsh on OSX. Straight out hangs and never gets
to the prompt.
Please run virsh with LIBVIRT_DEBUG=1 set and
2011/4/1 Eric Blake ebl...@redhat.com:
On 03/15/2011 02:29 AM, Matthias Bolte wrote:
Commit 2ed6cc7bec41dd344d41ea1531f6760c93099128 Expose event loop
implementation as a public API turned a failure to initialize the
default event loop into a fatal error in virsh on Windows. Before
2011/4/1 Eric Blake ebl...@redhat.com:
On 03/31/2011 07:55 PM, Minoru Usui wrote:
virNodeGetCpuTime: Expose new API
include/libvirt/libvirt.h.in | 26 ++
src/libvirt_public.syms | 1 +
2 files changed, 27 insertions(+), 0 deletions(-)
+/**
+ *
2011/3/29 Daniel Veillard veill...@redhat.com:
On Tue, Mar 29, 2011 at 02:32:18PM +0800, Osier Yang wrote:
Example of cputune XML:
cputune
shares2048/shares
vcpupin vcpu='0' cpuset='0-4,^1'/
vcpupin vcpu='1' cpuset='1,3'/
vcpupin vcpu='2' cpuset='0,2'/
/cputune
shares
2011/3/29 Daniel Veillard veill...@redhat.com:
On Tue, Mar 29, 2011 at 02:32:19PM +0800, Osier Yang wrote:
Sample of cputune xml:
cputune
shares2048/shares
vcpupin vcpu='0' cpuset='0-4,^3'/
vcpupin vcpu='1' cpuset='1,2'/
/cputune
* docs/schemas/domain.rng
---
2011/3/28 Daniel Veillard veill...@redhat.com:
Okay, I pushed new localization updates around and generated a
first release candidate build for 0.9.0 at:
ftp://libvirt.org/libvirt/libvirt-0.9.0-rc1.tar.gz
I will regenerate a rc2 as soon as Eric pending patch queue and
outgoing fd patches
2011/3/26 Eric Blake ebl...@redhat.com:
Detected in this valgrind run:
https://bugzilla.redhat.com/show_bug.cgi?id=690734
==13864== 10 bytes in 1 blocks are definitely lost in loss record 10 of 34
==13864== at 0x4A05FDE: malloc (vg_replace_malloc.c:236)
==13864== by 0x308587FD91: strdup
---
Found while trying to reproduce another reported memory leak in doRemoteOpen.
This leaked 10kb per failing call to negotiate_gnutls_on_connection.
src/remote/remote_driver.c | 28 +++-
1 files changed, 19 insertions(+), 9 deletions(-)
diff --git
2011/3/26 Eric Blake ebl...@redhat.com:
On 03/26/2011 07:59 AM, Matthias Bolte wrote:
---
Found while trying to reproduce another reported memory leak in doRemoteOpen.
This leaked 10kb per failing call to negotiate_gnutls_on_connection.
src/remote/remote_driver.c | 28
2011/3/18 Eric Blake ebl...@redhat.com:
If virFileIsExecutable is to replace access(file,X_OK), then
errno must be usable on failure.
* src/util/util.c (virFileIsExecutable): Set errno on failure.
---
ACK.
Matthias
--
libvir-list mailing list
libvir-list@redhat.com
2011/3/18 Eric Blake ebl...@redhat.com:
The next patch will change reference counting idioms; consolidating
this pattern now makes the next patch smaller (touch only the new
macro rather than every caller).
* src/qemu/qemu_monitor.c (QEMU_MONITOR_CALLBACK): New helper.
Sorry for the late response.
2011/3/8 Jake Xu j...@demonwaremail.net:
On Tue, Mar 8, 2011 at 11:20 AM, Matthias Bolte
matthias.bo...@googlemail.com wrote:
2011/3/8 Jake Xu j...@demonwaremail.net:
Hi Cole,
Thanks for the wiki link. It would be so useful if the ESX driver
supported
The virCond of the remote_thread_call struct was leaked in some
places. This results in leaking the underlying mutex. Which in turn
leaks a handle on Windows.
Reported by Aliaksandr Chabatar and Ihar Smertsin.
---
See https://www.redhat.com/archives/libvir-list/2011-March/msg00789.html
for the
Quite a long mail, I'm skipping all but the original report here.
From: Ihar Smertsin i.smert...@sam-solutions.net
To: Aliaksandr Chabatar a.chaba...@sam-solutions.net
Date: Tue, 8 Feb 2011 15:05:59 +0200
Subject: Libvirt issues in windows
Hello Alexandr,
On the client version of the
901 - 1000 of 2383 matches
Mail list logo
