Re: [libvirt] [PATCH 4/4] qemu: add multiqueue vhost-user support

2015-06-04 Thread Maxime Leroy
On Thu, Jun 4, 2015 at 3:43 PM, Martin Kletzander mklet...@redhat.com wrote: From: Maxime Leroy maxime.le...@6wind.com This patch adds the support of queues attribute of the driver element for vhost-user interface type. Example: interface type='vhostuser' mac address='52:54:00:ee:96

Re: [libvirt] [PATCH 3/4] qemu: Add capability for vhost-user multiqueue

2015-06-04 Thread Maxime Leroy
On Thu, Jun 4, 2015 at 3:43 PM, Martin Kletzander mklet...@redhat.com wrote: The support for this was added in QEMU with commit 830d70db692e374b5f4407f96a1ceefdcc97. Unfortunately we have to do another ugly version-based capability check. The other option would be not to check for the

Re: [libvirt] [PATCH 0/4] Add support for vhost-user with multi-queue

2015-06-04 Thread Maxime Leroy
Hi Martin, On Thu, Jun 4, 2015 at 3:43 PM, Martin Kletzander mklet...@redhat.com wrote: Also some tiny clean-up. Martin Kletzander (2): conf: Ignore multiqueue with one queue. qemu: Add capability for vhost-user multiqueue Maxime Leroy (2): docs: Clarify that attribute name

[libvirt] [PATCH] tests: fix incorrect caps for shmem-invalid-size, shmem-small-size

2014-10-17 Thread Maxime Leroy
be at least 1 MiB OK This commit fixes the issue by providing QEMU_CAPS_DEVICE_IVSHMEM caps for shmem-invalid-size, shmem-small-size test. Signed-off-by: Maxime Leroy maxime.le...@6wind.com --- tests/qemuxml2argvtest.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests

[libvirt] [PATCH] conf: tests: fix virDomainNetDefFormat for vhost-user in client mode

2014-10-17 Thread Maxime Leroy
) to test this usecase. Signed-off-by: Maxime Leroy maxime.le...@6wind.com --- src/conf/domain_conf.c | 5 +++-- tests/qemuxml2argvdata/qemuxml2argv-net-vhostuser.args | 7 +-- tests/qemuxml2argvdata/qemuxml2argv-net-vhostuser.xml | 7 ++- 3 files changed, 14

Re: [libvirt] [PATCH v3 1/3] docs, conf, schema: add support for shmem device

2014-10-08 Thread Maxime Leroy
Hi Martin, On Fri, Oct 3, 2014 at 10:45 PM, Martin Kletzander mklet...@redhat.com wrote: On Thu, Oct 02, 2014 at 09:42:36AM +0200, Michal Privoznik wrote: On 26.09.2014 12:43, Martin Kletzander wrote: diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index b114737..51bdd31 100644

Re: [libvirt] [PATCH v2 1/3] docs, conf, schema: add support for shmem device

2014-09-26 Thread Maxime Leroy
On Thu, Sep 25, 2014 at 11:45 AM, Martin Kletzander mklet...@redhat.com wrote: This patch adds parsing/formatting code as well as documentation for shared memory devices. This will currently be only accessible in QEMU using it's ivshmem device, but is designed as generic as possible to allow

Re: [libvirt] [PATCH v2 0/3] Add support for shared memory devices

2014-09-26 Thread Maxime Leroy
Hi Martin, On Thu, Sep 25, 2014 at 11:45 AM, Martin Kletzander mklet...@redhat.com wrote: This is based on Maxime's patches, but leaving out the last one with server starting, the last version was here: https://www.redhat.com/archives/libvir-list/2014-August/msg01032.html As my original

Re: [libvirt] [PATCH v2 0/3] Add support for shared memory devices

2014-09-26 Thread Maxime Leroy
I will test this v3 instead. Please, wait for my feedback. Thank you. Maxime -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 1/3] docs, conf, schema: add support for shmem device

2014-09-25 Thread Maxime Leroy
Hi Martin, I am going to test it on my platform before to review/ack it. Maxime -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v1 0/6] ivshmem support

2014-09-03 Thread Maxime Leroy
Hello Martin, Let me summarize the points we need for the next patchset version: 1) merge patches - doc: schema, conf: Parse and format and tests ( for xml2xml ) into doc: schema: conf: Add shmem node - qemu: Build comand, qemu: Add cap flag CAPS_IVSHMEM, and tests (for xml2argv) into qemu:

Re: [libvirt] [PATCH v1 1/6] doc: schema: Add documentation for the shmem support

2014-08-27 Thread Maxime Leroy
On Tue, Aug 26, 2014 at 8:22 AM, Martin Kletzander mklet...@redhat.com wrote: On Fri, Aug 22, 2014 at 12:47:00PM +0200, Maxime Leroy wrote: [..] Considering there could be other shared memory related devices, this patch introduces a general device model, called shmem device. Currenly ivshmem

Re: [libvirt] [PATCH v1 2/6] conf: Parse and format shmem device XML

2014-08-27 Thread Maxime Leroy
On Tue, Aug 26, 2014 at 10:42 AM, Martin Kletzander mklet...@redhat.com wrote: On Fri, Aug 22, 2014 at 12:47:01PM +0200, Maxime Leroy wrote: This patch adds configuration support for the shmem device as described in the schema in the previous patch. [...] This parsing using loop over

Re: [libvirt] [PATCH v1 4/6] qemu: Build command line for ivshmem device

2014-08-27 Thread Maxime Leroy
On Tue, Aug 26, 2014 at 10:58 AM, Martin Kletzander mklet...@redhat.com wrote: On Fri, Aug 22, 2014 at 12:47:03PM +0200, Maxime Leroy wrote: [..] It will sometimes format the command-line parameter to size=0m, which will terribly fail. We should add it to the command-line with the smallest

Re: [libvirt] [PATCH v1 5/6] tests: Add tests for ivshmem device handling

2014-08-27 Thread Maxime Leroy
On Tue, Aug 26, 2014 at 11:02 AM, Martin Kletzander mklet...@redhat.com wrote: On Fri, Aug 22, 2014 at 12:47:04PM +0200, Maxime Leroy wrote: [...] +shmem name='shmem0' model='ivshmem' + server path='/tmp/socket-shmem0'/ + msi vectors='32' ioeventfd='on'/ +/shmem +shmem

Re: [libvirt] [PATCH v1 2/6] conf: Parse and format shmem device XML

2014-08-27 Thread Maxime Leroy
On Tue, Aug 26, 2014 at 11:02 AM, Wang Rui moon.wang...@huawei.com wrote: On 2014/8/22 18:47, Maxime Leroy wrote: This patch adds configuration support for the shmem device as described in the schema in the previous patch. [..] +if (model) { +if ((def-model

Re: [libvirt] [PATCH v1 4/6] qemu: Build command line for ivshmem device

2014-08-27 Thread Maxime Leroy
On Tue, Aug 26, 2014 at 11:23 AM, Wang Rui moon.wang...@huawei.com wrote: On 2014/8/22 18:47, Maxime Leroy wrote: [...] +if (!(devstr = qemuBuildIvshmemDevStr(def, dev, qemuCaps))) +return -1; +virCommandAddArg(cmd, devstr); +VIR_FREE(devstr); + +if (ivshmem

Re: [libvirt] [PATCH v1 6/6] ivshmem: add start param to server attribute

2014-08-27 Thread Maxime Leroy
On Tue, Aug 26, 2014 at 11:58 AM, Wang Rui moon.wang...@huawei.com wrote: On 2014/8/22 18:47, Maxime Leroy wrote: +# util/virivshmemserver.h +virStartIvshmemServer; +virStopIvshmemServer; I think function name virIvshmemStartServer is better. So is the stop function. What about

[libvirt] [PATCH v1 0/6] ivshmem support

2014-08-22 Thread Maxime Leroy
='on'/ /shmem Maxime Leroy (6): doc: schema: Add documentation for the shmem support conf: Parse and format shmem device XML qemu: Add cap flag QEMU_CAPS_IVSHMEM qemu: Build command line for ivshmem device tests: Add tests for ivshmem device handling ivshmem: add start param to server attribute

[libvirt] [PATCH v1 1/6] doc: schema: Add documentation for the shmem support

2014-08-22 Thread Maxime Leroy
-off-by: Maxime Leroy maxime.le...@6wind.com --- docs/formatdomain.html.in | 68 +++ docs/schemas/domaincommon.rng | 49 +++ 2 files changed, 117 insertions(+) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in

[libvirt] [PATCH v1 6/6] ivshmem: add start param to server attribute

2014-08-22 Thread Maxime Leroy
/bin/ivshmem-server -m ivshmem0 -S /tmp/ivshmem0.sock \ -p /var/run/libvirt/ivshmem-server/ivshd-ivshmem0.pid -n 32 Signed-off-by: Maxime Leroy maxime.le...@6wind.com --- configure.ac| 4 + docs/formatdomain.html.in | 5 +- docs

[libvirt] [PATCH v1 2/6] conf: Parse and format shmem device XML

2014-08-22 Thread Maxime Leroy
This patch adds configuration support for the shmem device as described in the schema in the previous patch. Signed-off-by: Maxime Leroy maxime.le...@6wind.com --- src/conf/domain_conf.c | 249 ++- src/conf/domain_conf.h | 41 src

[libvirt] [PATCH v1 4/6] qemu: Build command line for ivshmem device

2014-08-22 Thread Maxime Leroy
ivshmem,size=32m,vectors=32,chardev=charshmem0,msi=on, ioeventfd=on,role=master -chardev socket,path=/tmp/socket-ivshmem0,id=charshmem0 Note: PCI hotpluging is not implemented. Signed-off-by: Maxime Leroy maxime.le...@6wind.com --- src/qemu/qemu_command.c | 105

[libvirt] [PATCH v1 5/6] tests: Add tests for ivshmem device handling

2014-08-22 Thread Maxime Leroy
Add XML parsing and qemu command line tests for the ivshmem device support. Signed-off-by: Maxime Leroy maxime.le...@6wind.com --- tests/qemuxml2argvdata/qemuxml2argv-ivshmem.args | 10 +++ tests/qemuxml2argvdata/qemuxml2argv-ivshmem.xml | 35 tests

[libvirt] [PATCH v1 3/6] qemu: Add cap flag QEMU_CAPS_IVSHMEM

2014-08-22 Thread Maxime Leroy
Ivshmem is supported by QEMU since 0.13 release. Signed-off-by: Maxime Leroy maxime.le...@6wind.com --- src/qemu/qemu_capabilities.c | 3 +++ src/qemu/qemu_capabilities.h | 1 + tests/qemucapabilitiesdata/caps_1.2.2-1.caps | 1 + tests/qemucapabilitiesdata

Re: [libvirt] [RFC PATCH 1/5] doc: schema: Add basic documentation for the ivshmem support

2014-08-08 Thread Maxime Leroy
On Fri, Aug 8, 2014 at 11:21 AM, Martin Kletzander mklet...@redhat.com wrote: On Thu, Aug 07, 2014 at 05:34:35PM +0200, Maxime Leroy wrote: On Thu, Aug 7, 2014 at 12:33 PM, Martin Kletzander mklet...@redhat.com wrote: On Tue, Aug 05, 2014 at 06:48:01PM +0200, Maxime Leroy wrote

Re: [libvirt] [RFC PATCH 1/5] doc: schema: Add basic documentation for the ivshmem support

2014-08-07 Thread Maxime Leroy
On Wed, Aug 6, 2014 at 11:41 AM, Wang Rui moon.wang...@huawei.com wrote: On 2014/8/6 0:48, Maxime Leroy wrote: This patch documents XML elements used for support of ivshmem devices. About ivshmem, please see the following documentation: http://git.qemu.org/?p=qemu.git;a=blob;f=docs/specs

Re: [libvirt] [RFC PATCH 4/5] qemu: Build command line for ivshmem device

2014-08-07 Thread Maxime Leroy
On Wed, Aug 6, 2014 at 12:04 PM, Wang Rui moon.wang...@huawei.com wrote: On 2014/8/6 0:48, Maxime Leroy wrote: This patch implements support for the ivshmem device in QEMU. Example from this xml: ivshmem server='yes'' role='master'/ s/'yes''/'yes' [..] +virCommandAddArg(cmd

Re: [libvirt] [RFC PATCH 2/5] conf: Parse and format ivshmem device XML

2014-08-07 Thread Maxime Leroy
On Wed, Aug 6, 2014 at 11:30 AM, Wang Rui moon.wang...@huawei.com wrote: On 2014/8/6 0:48, Maxime Leroy wrote: [..] @@ -2805,6 +2841,7 @@ virDomainDeviceInfoIterateInternal(virDomainDefPtr def, case VIR_DOMAIN_DEVICE_NVRAM: case VIR_DOMAIN_DEVICE_LAST: case

Re: [libvirt] [RFC PATCH 1/5] doc: schema: Add basic documentation for the ivshmem support

2014-08-07 Thread Maxime Leroy
On Thu, Aug 7, 2014 at 12:33 PM, Martin Kletzander mklet...@redhat.com wrote: On Tue, Aug 05, 2014 at 06:48:01PM +0200, Maxime Leroy wrote: This patch documents XML elements used for support of ivshmem devices. At first, I'd like to thank you for the proposal. There were numerous requests

[libvirt] [RFC PATCH 0/5] ivshmem support

2014-08-05 Thread Maxime Leroy
The following patches are an implementation proposal for the ivshmem device support in libvirt. Any feedback is welcome. Note: SELinux is not supported (need to be done for the next patchset version) Maxime Leroy (5): doc: schema: Add basic documentation for the ivshmem support conf

[libvirt] [RFC PATCH 4/5] qemu: Build command line for ivshmem device

2014-08-05 Thread Maxime Leroy
ivshmem,size=32m,vectors=32,chardev=charivshmem0,msi=on, ioeventfd=on,role=master -chardev socket,path=/tmp/socket-ivshmem0,id=charivshmem0 Note: PCI hotpluging has not be implemented. Signed-off-by: Maxime Leroy maxime.le...@6wind.com --- src/qemu/qemu_command.c | 77

[libvirt] [RFC PATCH 2/5] conf: Parse and format ivshmem device XML

2014-08-05 Thread Maxime Leroy
This patch adds configuration support for the ivshmem device as described in the schema in the previous patch. Signed-off-by: Maxime Leroy maxime.le...@6wind.com --- src/conf/domain_conf.c | 234 ++- src/conf/domain_conf.h | 40 src

[libvirt] [RFC PATCH 3/5] qemu: Add cap flag QEMU_CAPS_IVSHMEM

2014-08-05 Thread Maxime Leroy
Ivshmem is supported by QEMU since 0.13 release. Signed-off-by: Maxime Leroy maxime.le...@6wind.com --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + tests/qemucapabilitiesdata/caps_1.2.2-1.caps | 1 + tests/qemucapabilitiesdata

[libvirt] [RFC PATCH 5/5] tests: Add tests for ivshmem device handling

2014-08-05 Thread Maxime Leroy
Add XML parsing and qemu command line tests for the ivshmem device support. Signed-off-by: Maxime Leroy maxime.le...@6wind.com --- tests/qemuxml2argvdata/qemuxml2argv-ivshmem.args | 10 +++ tests/qemuxml2argvdata/qemuxml2argv-ivshmem.xml | 36 tests

[libvirt] [RFC PATCH 1/5] doc: schema: Add basic documentation for the ivshmem support

2014-08-05 Thread Maxime Leroy
creating the VM. It's not done by libvirt. Signed-off-by: Maxime Leroy maxime.le...@6wind.com --- docs/formatdomain.html.in | 72 +++ docs/schemas/domaincommon.rng | 57 ++ 2 files changed, 129 insertions(+) diff

Re: [libvirt] [RFC] require for suggestions on support for ivshmem device

2014-07-28 Thread Maxime LEROY
Hi all, On 07/21/2014 04:38 AM, Wang Rui wrote: On 2014/7/17 17:37, Martin Kletzander wrote: On Tue, May 20, 2014 at 11:17:32AM +0200, Martin Kletzander wrote: On Wed, May 14, 2014 at 08:23:21AM +, Wangrui (K) wrote: Hi, Libvirt does not support ivshmem(Inter-VM Shared Memory) device