s to
choose the root name of XML. The former function became a tiny wrapper
to call the new function setting the correct parameters.
Signed-off-by: Maxiwell S. Garcia
---
src/conf/domain_conf.c | 35 ++-
src/conf/domain_conf.h | 6 ++
2 files changed,
This patchset store both config and live XML in the snapshot XML.
To avoid nest 'config' XML one level deeper ('inactive/domain'),
it was necessary to create a function that has a new rootname parameter.
V4:
- Create a new function to format the XML domain choosing the root name
Maxiwell S
, the in the snapshot XML is
not required to snapshot work, but it's useful to preserve the
config XML of running guests.
Signed-off-by: Maxiwell S. Garcia
---
src/conf/moment_conf.c | 1 +
src/conf/moment_conf.h | 11 +++
src/conf/snapshot_conf.c | 22 --
src/qemu/qemu_driver.c
iven by the new flag
VIR_DOMAIN_DEF_FORMAT_INACTIVE_NODE to choose the correct root name.
Signed-off-by: Maxiwell S. Garcia
---
src/conf/domain_conf.c | 13 ++---
src/conf/domain_conf.h | 1 +
2 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 03
This patchset store both config and live XML in the snapshot XML.
To avoid nest 'config' XML one level deeper ('inactive/domain'),
it was necessary change the virDomainDefFormatInternal() to use
'domain' or 'inactiveDomain' in the root node.
Maxiwell S. Garcia (2):
qemu: formatting XML from
, the in the snapshot XML is
not required to snapshot work, but it's useful to preserve the
config XML of running guests.
Signed-off-by: Maxiwell S. Garcia
---
src/conf/moment_conf.c | 1 +
src/conf/moment_conf.h | 11 +++
src/conf/snapshot_conf.c | 23 +--
src/qemu/qemu_driver.c
QEMU shows a warning message if partial NUMA mapping is set. This patch
adds a warning message in libvirt when editing the XML. It must be an
error in future, when QEMU remove this ability.
Signed-off-by: Maxiwell S. Garcia
---
src/qemu/qemu_domain.c | 19 ++-
1 file changed, 14
atch get a
> > pass because it didn't break anything else.
>
> What failures are you seeing? Those were just recently added, and if
> they are failing for you, it's worth getting them fixed. But I'm not
> seeing them fail on my end.
>
> > On 7/23/19 4:47 PM, Maxiwell S. Garci
, the in the snapshot XML is
not required to snapshot work, but it's useful to preserve the
config XML of running guests.
Signed-off-by: Maxiwell S. Garcia
---
src/conf/moment_conf.c | 1 +
src/conf/moment_conf.h | 11 +
src/conf/snapshot_conf.c | 48 +++-
src/qemu
If the XML doesn't have numa cells, this check is not necessary. But
if numa cells are present, it must match with cpu topology count.
Signed-off-by: Maxiwell S. Garcia
---
src/qemu/qemu_domain.c | 19 ++-
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/src/qemu
, the in the snapshot XML is
not required to snapshot work, but it's useful to preserve the
config XML of running guests.
Signed-off-by: Maxiwell S. Garcia
---
src/conf/moment_conf.c | 1 +
src/conf/moment_conf.h | 1 +
src/conf/snapshot_conf.c | 42
src/qemu
On Tue, May 14, 2019 at 09:38:12AM -0500, Eric Blake wrote:
> On 5/14/19 8:37 AM, Michal Privoznik wrote:
> > On 5/13/19 8:48 PM, Daniel Henrique Barboza wrote:
> >> Tried to reproduce the error using my x86 laptop but got hit by
> >> https://bugzilla.redhat.com/show_bug.cgi?id=1689216 when trying
On Tue, May 14, 2019 at 03:37:26PM +0200, Michal Privoznik wrote:
> On 5/13/19 8:48 PM, Daniel Henrique Barboza wrote:
> > Tried to reproduce the error using my x86 laptop but got hit by
> > https://bugzilla.redhat.com/show_bug.cgi?id=1689216 when trying
> > to create the snapshot using upstream
() to set the
snapshot definition in vm->newDef, if domain is active, or in vm->def
otherwise. But before that, it saves the old value to return to
caller. This return is used here to restore the config XML after
all snapshot startup process finish.
Signed-off-by: Maxiwell S. Garcia
14 matches
Mail list logo
