Thanks a lot for fixing my patch issue !
On Thu, Dec 22, 2016 at 10:45:15AM +0100, Michal Privoznik wrote:
Based on work of Mehdi Abaakouk <sil...@sileht.net>.
When parsing vhost-user interface XML and no ifname is found we
can try to fill it in in post parse callback. The way this works
This change adds a new helper function that
return a ifname from the vhostuser unix-socket path but only
if the interface is managed by openvswitch
This new function is issue to autodetect the ifname for openvswitch
managed vhostuser interface.
---
src/libvirt_private.syms| 1 +
Hi,
I have fixed the two remarks.
ifname is now set in qemuDomainDeviceDefPostParse().
Regards,
Mehdi Abaakouk (1):
qemu_domain: set default ovs vhostuser ifname
src/libvirt_private.syms| 1 +
src/qemu/qemu_domain.c | 21 +++--
src/util
Any comments on this ?
On Fri, Dec 09, 2016 at 01:24:52PM +0100, Mehdi Abaakouk wrote:
Hi,
This is the followup of '[PATCH v3 4/4] domain_conf: autodetect vhostuser
ifname'.
I have rewritten a better version that shouldn't have the same concern as
before.
I have isolated the code
This change adds a new helper function that
return a ifname from the vhostuser unix-socket path but only
if the interface is managed by openvswitch
This new function is issue to autodetect the ifname for openvswitch
managed vhostuser interface.
---
src/conf/domain_conf.c | 5 +
,
Mehdi Abaakouk (1):
domain_conf: set ifname for ovs vhostuser ifname
src/conf/domain_conf.c | 5 +
src/libvirt_private.syms| 1 +
src/util/virnetdevopenvswitch.c | 41 +
src/util/virnetdevopenvswitch.h | 3 +++
4 files changed, 50
.
Congratulations on your first libvirt contribution!
Thank you for the quick processing of the changes!
--
Mehdi Abaakouk
mail: sil...@sileht.net
irc: sileht
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
s
$ virsh domifstat dpdkvhostuser0
Cheers,
--
Mehdi Abaakouk
mail: sil...@sileht.net
irc: sileht
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Thu, Dec 08, 2016 at 01:51:10PM +0100, Michal Privoznik wrote:
On 18.11.2016 23:51, Mehdi Abaakouk wrote:
From: Mehdi Abaakouk <sil...@redhat.com>
I don't think this is a good idea. For instance, for the following XML:
this code would produce
Hi,
Sorry to bother you again, but I still have no comment about using
openvswitch statistics command to retrieve vhost-user interface
statistics.
Regards,
On Fri, Nov 18, 2016 at 11:51:12PM +0100, Mehdi Abaakouk wrote:
This new version removes the virstat.c from locale configuration
Hi,
Can I have any feedback of this ?
Thank in advance.
Le 2016-11-18 23:51, Mehdi Abaakouk a écrit :
This new version removes the virstat.c from locale configuration.
It also adds a new commit to autodected the ifname of the ovs
vhostuser.
Mehdi Abaakouk (4):
Gathering vhostuser
From: Mehdi Abaakouk <sil...@redhat.com>
When vhostuser interfaces are used, the interface statistics
are not available in /proc/net/dev.
This change looks at the openvswitch interfaces statistics
tables to provide this information for vhostuser interface.
Note that in openvswitch worl
From: Mehdi Abaakouk <sil...@redhat.com>
This is just a code move of virstat.c to virnetdevtap.c
---
po/POTFILES.in | 1 -
src/Makefile.am| 1 -
src/libvirt_private.syms | 4 +-
src/libxl/libxl_driver.c | 2 +-
src/lxc/lxc_driver.c | 1 -
src/
This new version removes the virstat.c from locale configuration.
It also adds a new commit to autodected the ifname of the ovs vhostuser.
Mehdi Abaakouk (4):
Gathering vhostuser interface stats with ovs
virstat: fix signature of virstat helper
Move virstat.c code to virnetdevtap.c
From: Mehdi Abaakouk <sil...@redhat.com>
This change puts the socket filename as ifname for vhostuser netwok
interface.
The filename is the name of the openvswitch interface, this allows the
qemuDomainInterfaceStats to work out of the box without having to
manually set the ifname.
---
sr
From: Mehdi Abaakouk <sil...@redhat.com>
In preparation to the code move to virnetdevtap.c, this change:
* renames virNetInterfaceStats to virNetDevTapInterfaceStats
* changes 'path' to 'ifname', to use the same vocable as other
method in virnetdevtap.c.
* Add the attributes checker
--
From: Mehdi Abaakouk <sil...@redhat.com>
When vhostuser interfaces are used, the interface statistics
are not available in /proc/net/dev.
This change looks at the openvswitch interfaces statistics
tables to provide this information for vhostuser interface.
Note that in openvswitch worl
From: Mehdi Abaakouk <sil...@redhat.com>
This is just a code move of virstat.c to virnetdevtap.c
---
src/Makefile.am| 1 -
src/libvirt_private.syms | 4 +-
src/libxl/libxl_driver.c | 2 +-
src/lxc/lxc_driver.c | 1 -
src/openvz/openvz_driver.c | 2 +-
sr
Hi,
The new code have been moved to virnetdevopenvswitch.c
I have also sent the refactoring of virstat.c
Regards,
Mehdi Abaakouk (3):
Gathering vhostuser interface stats with ovs
virstat: fix signature of virstat helper
Move virstat.c code to virnetdevtap.c
src/Makefile.am
From: Mehdi Abaakouk <sil...@redhat.com>
In preparation to the code move to virnetdevtap.c, this change:
* renames virNetInterfaceStats to virNetDevTapInterfaceStats
* changes 'path' to 'ifname', to use the same vocable as other
method in virnetdevtap.c.
* Add the attributes checker
--
When vhostuser or ovs interfaces are used, the interface statistics
are not always available in /proc/net/dev.
This change looks at the openvswitch interfaces statistics
tables to provide this information in additional to /proc/net/dev.
Note that in openvswitch world drop/error doesn't always
Hi,
To follow up, my question about vhostuser/ovs interfaces statistics.
This is my porposal to implement this feature.
Regards,
Mehdi Abaakouk (1):
virstats: Gathering net interface stats with ovs
src/util/virstats.c | 99 +++--
1 file
t;) ?
I have started to write a PoC code that fallback to OVS in
virNetInterfaceStats()
when we don't found the interface in /proc/net/dev.
Does this kind of contribution is welcome/match your plan ?
Regards,
--
Mehdi Abaakouk
mail: sil...@sileht.net
irc: sileht
--
libvir-list mailing lis
23 matches
Mail list logo
