Re: [libvirt] [PATCH] libvirt: virsh: Kill all uses of __FUNCTION__ in error messages

2015-04-04 Thread Noella Ashu
Thanks Michal, I will look at another introductory bug to work on. Any suggestions will help. Thanks, Noella On Fri, Apr 3, 2015 at 1:13 PM, Michal Privoznik mpriv...@redhat.com wrote: On 03.04.2015 12:33, Noella Ashu wrote: The error output of snapshot-revert should be more friendly

Re: [libvirt] [PATCH] libvirt: virsh: Kill all uses of __FUNCTION__ in error messages

2015-04-03 Thread Noella Ashu
Hello +Michal, I will make the corrections and re send the patch. Sorry for the errors. Thanks, Noella On Fri, Apr 3, 2015 at 10:19 AM, Michal Privoznik mpriv...@redhat.com wrote: On 01.04.2015 14:46, Noella Ashu wrote: The error output of snapshot-revert should be more friendly

[libvirt] [PATCH] libvirt: virsh: Kill all uses of __FUNCTION__ in error messages

2015-04-03 Thread Noella Ashu
The error output of snapshot-revert should be more friendly. There is no need to show up virDomainRevertToSnapshot to user. virError already includes __FUNCTION__ information in a separate member of the struct, so repeating it in the message is redundant and leads to situations where higher level

Re: [libvirt] [PATCH] libvirt: virsh: Kill all uses of __FUNCTION__ in error messages

2015-04-03 Thread Noella Ashu
Hello +Michal, I have sent a new patch to the mailing list with the whitespaces removed. This should work fine now. Please just let me know if you have any other issues. Thanks, Noella On Fri, Apr 3, 2015 at 11:04 AM, Noella Ashu ashu.noella...@gmail.com wrote: Hello +Michal, I will make

[libvirt] [PATCH] Bug 1086726: Reworked error messages in libvirt.c, libvirt-domain.c removing uses of __FUNCTION__, except one

2015-04-01 Thread Noella Ashu
--- src/libvirt-domain.c | 13 +++-- src/libvirt.c| 4 ++-- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index f1608dc..4a45b9e 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -2613,7 +2613,7 @@

[libvirt] [PATCH] libvirt: virsh: Kill all uses of __FUNCTION__ in error messages

2015-04-01 Thread Noella Ashu
The error output of snapshot-revert should be more friendly. There is no need to show up virDomainRevertToSnapshot to user. virError already includes __FUNCTION__ information in a separate member of the struct, so repeating it in the message is redundant and leads to situations where higher level

Re: [libvirt] [PATCH] Bug 1086726: Reworked error messages in libvirt.c, libvirt-domain.c removing uses of __FUNCTION__, except one

2015-04-01 Thread Noella Ashu
Hello, We tend to do different formatting of commit messages. If you do 'git log' you'll immediately get a picture. I see, forgot to check the previous commits first before doing mine. My bad, will do better next time. The idea of the bug report is to do something like this: diff

[libvirt] GSoC/OPW:Problems Compilling libvirt

2015-03-28 Thread Noella Ashu
Hello, I have been trying to compile libvirt, I have cloned the git repo, tried running ./configure but it looks like it's not executable. So when I try running ./autogen.sh script. I get the following errors: https://paste.kde.org/p8liujgxg I have tried installing autopoint, python-config.

Re: [libvirt] GSoC/OPW:Problems Compilling libvirt

2015-03-28 Thread Noella Ashu
Hello Yandong, (1)As I known, before compiling libvirt, some packages should be installed. sudo apt-get install gcc make pkg-config libxml2-dev libgnutils-dev libdevmapper-dev libcur l4-gnutls-dev python-dev libpciaccess-dev libxen-dev libnl-dev I just ran $yum builddep libvirt and it