Please look at.
On 13/07/2023 12:49, Oleg Vasilev wrote:
On 04/07/2023 13:10, Oleg Vasilev wrote:
Found by repeatedly created and destroyed channels with guest agent. More
details in the patch.
Oleg Vasilev (2):
net: add debug logs
remote: fix stream use-after-free
src/remote
On 04/07/2023 13:10, Oleg Vasilev wrote:
Found by repeatedly created and destroyed channels with guest agent. More
details in the patch.
Oleg Vasilev (2):
net: add debug logs
remote: fix stream use-after-free
src/remote/remote_daemon_stream.c | 13 +++--
src/rpc
Inside daemonStreamHandleWrite on stream completion (status=OK) we
reuse msg object to send confirmation.
Only after that, msg is poped from the queue and checked for continue.
By that time, msg might've already been processed for the confirmation
and freed.
Signed-off-by: Oleg Vasilev
---
Helped to debug next patch use-after-free.
Signed-off-by: Oleg Vasilev
---
src/remote/remote_daemon_stream.c | 4 ++--
src/rpc/virnetmessage.c | 5 +
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/src/remote/remote_daemon_stream.c
b/src/remote
Found by repeatedly created and destroyed channels with guest agent. More
details in the patch.
Oleg Vasilev (2):
net: add debug logs
remote: fix stream use-after-free
src/remote/remote_daemon_stream.c | 13 +++--
src/rpc/virnetmessage.c | 5 +
2 files changed, 12
If there are no parameters, there is nothing to validate.
If params == NULL, memcpy below results in memcpy(sorted, NULL, 0),
which is UB.
Found by UBSAN. Example of this codepath: virDomainBlockCopy()
(where nparams == 0 is valid) -> qemuDomainBlockCopy()
Signed-off-by: Oleg Vasilev
---
From: Nikolay Shirokovskiy
Unmap stats are useful for debugging how efficient qemu is in freeing host
disk space.
Signed-off-by: Oleg Vasilev
---
src/qemu/qemu_driver.c | 3 +++
src/qemu/qemu_monitor.h | 3 +++
src/qemu/qemu_monitor_json.c | 3 +++
3 files changed, 9 insertions
QEMU now supports multifd-compression=zstd for migration with enabled multifd.
Bring the support to libvirt as well.
Signed-off-by: Oleg Vasilev
---
include/libvirt/libvirt-domain.h | 10 ++
src/qemu/qemu_migration.h| 1 +
src/qemu/qemu_migration_params.c | 32
QEMU now supports multifd-compression=zstd for migration with enabled multifd.
Bring the support to libvirt as well.
Claudio Fontana (1):
qemu: migration: expose qemuMigrationParamsSetString
Oleg Vasilev (2):
qemu: migration: implement zstd compression
tests: qemumigparams: test for zstd
From: Claudio Fontana
change from static to external linkage, and move the
function close to the other similar ones, near
qemuMigrationParamsSetULL.
Signed-off-by: Claudio Fontana
Signed-off-by: Oleg Vasilev
---
src/qemu/qemu_migration_params.c | 47 +++-
src/qemu
Here we add one more way to test migration parameters, namely: from vir params.
This allows to test the logic of (libvirt) compression->(qemu)
multifd-compression
Signed-off-by: Oleg Vasilev
---
tests/qemumigparamsdata/zstd.json | 4 ++
tests/qemumigparamsdata/zstd.reply | 7 +++
te
On 03.02.2023 19:45, Martin Kletzander wrote:
On Mon, Jan 30, 2023 at 09:00:01PM +0600, Oleg Vasilev wrote:
Before, logs from deleted machines have been piling up, since there were
no garbage collection mechanism. Now, virtlogd can be configured to
periodically scan the log folder for orphan
On 25.01.2023 19:49, Martin Kletzander wrote:
On Fri, Jan 20, 2023 at 04:50:51PM +0600, Oleg Vasilev wrote:
On 09.01.2023 18:31, Martin Kletzander wrote:
On Thu, Dec 15, 2022 at 01:25:49AM +0600, Oleg Vasilev wrote:
Before, logs from deleted machines have been piling up, since there
were
Signed-off-by: Oleg Vasilev
---
src/logging/log_handler.c | 26 --
src/logging/log_handler.h | 31 ---
2 files changed, 28 insertions(+), 29 deletions(-)
diff --git a/src/logging/log_handler.c b/src/logging/log_handler.c
index 7342404b00
single transaction.
Signed-off-by: Oleg Vasilev
---
po/POTFILES | 1 +
src/logging/log_cleaner.c | 268 ++
src/logging/log_cleaner.h | 29 +
src/logging/log_handler.h | 2 +
src/logging/meson.build | 1 +
5 files changed, 301 insertions
We want to specify the folder to clean and how much time can a log
chain live.
Signed-off-by: Oleg Vasilev
---
src/logging/log_daemon_config.c | 9 +
src/logging/log_daemon_config.h | 3 +++
src/logging/test_virtlogd.aug.in | 2 ++
src/logging/virtlogd.aug | 2 ++
src
Actually use the log cleaner introduced by previous commit.
Signed-off-by: Oleg Vasilev
---
src/logging/log_handler.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/logging/log_handler.c b/src/logging/log_handler.c
index 8fc7e9b2a8..a739211c7c 100644
--- a/src/logging
https://listman.redhat.com/archives/libvir-list/2022-February/228149.html
[2]: https://listman.redhat.com/archives/libvir-list/2022-February/msg00865.html
CC: Martin Kletzander
Oleg Vasilev (5):
logging: refactor to store config inside log handler
logging: move virLogHandler to header
logging
Signed-off-by: Oleg Vasilev
---
src/logging/log_daemon.c | 6 ++
src/logging/log_handler.c | 29 -
src/logging/log_handler.h | 17 -
3 files changed, 22 insertions(+), 30 deletions(-)
diff --git a/src/logging/log_daemon.c b/src/logging
On 09.01.2023 18:31, Martin Kletzander wrote:
On Thu, Dec 15, 2022 at 01:25:49AM +0600, Oleg Vasilev wrote:
Before, logs from deleted machines have been piling up, since there were
no garbage collection mechanism. Now, virtlogd can be configured to
periodically scan the log folder for orphan
On 10.01.2023 16:35, Daniel P. Berrangé wrote:
On Tue, Jan 10, 2023 at 04:20:59PM +0600, Oleg Vasilev wrote:
On 10.01.2023 15:09, Martin Kletzander wrote:
On Tue, Jan 10, 2023 at 09:03:40AM +, Daniel P. Berrangé wrote:
On Tue, Jan 10, 2023 at 02:42:34PM +0600, Oleg Vasilev wrote
On 10.01.2023 15:09, Martin Kletzander wrote:
On Tue, Jan 10, 2023 at 09:03:40AM +, Daniel P. Berrangé wrote:
On Tue, Jan 10, 2023 at 02:42:34PM +0600, Oleg Vasilev wrote:
Serial log file contains lots of useful information for debugging
configuration problems. It makes sense to
On 05.01.2023 19:19, Martin Kletzander wrote:
On Tue, Nov 29, 2022 at 09:54:51PM +0600, Oleg Vasilev wrote:
Serial log file contains lots of useful information for debugging
configuration problems. It makes sense to preserve the log in between
restarts, so that one can later figure out what
.
Signed-off-by: Oleg Vasilev
---
src/qemu/libvirtd_qemu.aug| 3 ++
src/qemu/qemu.conf.in | 9
src/qemu/qemu_conf.c | 4 ++
src/qemu/qemu_conf.h | 2 +
src/qemu/qemu_domain.c
Ping
On 15.12.2022 01:25, Oleg Vasilev wrote:
Presently, logs from deleted domains remain forever. Particular motivation
comes from the case when libguestfs has repeatedly created transient VMs,
which in turn created plenty of logs. This takes up space and lots of files
troubles filesystem
Ping
On 29.11.2022 21:54, Oleg Vasilev wrote:
Serial log file contains lots of useful information for debugging
configuration problems. It makes sense to preserve the log in between
restarts, so that one can later figure out what was going on.
Oleg Vasilev (2):
qemu: add append mode config
ibvir-list/2022-February/msg00865.html
CC: Martin Kletzander
Oleg Vasilev (5):
logging: refactor to store config inside log handler
logging: move virLogHandler to header
logging: add configuration for future log cleaner
logging: add log cleanup for obsolete domains
logging: use the log cl
Actually use the log cleaner introduced by previous commit.
Signed-off-by: Oleg Vasilev
---
src/logging/log_handler.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/logging/log_handler.c b/src/logging/log_handler.c
index 8fc7e9b2a8..a739211c7c 100644
--- a/src/logging
We want to specify the folder to clean and how much time can a log
chain live.
Signed-off-by: Oleg Vasilev
---
src/logging/log_daemon_config.c | 9 +
src/logging/log_daemon_config.h | 3 +++
src/logging/test_virtlogd.aug.in | 2 ++
src/logging/virtlogd.aug | 2 ++
src
Signed-off-by: Oleg Vasilev
---
src/logging/log_handler.c | 26 --
src/logging/log_handler.h | 31 ---
2 files changed, 28 insertions(+), 29 deletions(-)
diff --git a/src/logging/log_handler.c b/src/logging/log_handler.c
index 7342404b00
single transaction.
Signed-off-by: Oleg Vasilev
---
po/POTFILES | 1 +
src/logging/log_cleaner.c | 276 ++
src/logging/log_cleaner.h | 29
src/logging/log_handler.h | 2 +
src/logging/meson.build | 1 +
5 files changed, 309 insertions
Signed-off-by: Oleg Vasilev
---
src/logging/log_daemon.c | 6 ++
src/logging/log_handler.c | 29 -
src/logging/log_handler.h | 17 -
3 files changed, 22 insertions(+), 30 deletions(-)
diff --git a/src/logging/log_daemon.c b/src/logging
On 30.11.2022 16:49, Martin Kletzander wrote:
On Mon, Nov 21, 2022 at 03:29:57PM +0600, Oleg Vasilev wrote:
Before, logs from deleted machines have been piling up, since there were
no garbadge collection mechanism. Now virtlogd can be configured to
periodically scan log folder for orphan logs
Kindly ping.
The previous attempt didn't get any attention, and I am not sure what
else to do.
On 21.11.2022 15:29, Oleg Vasilev wrote:
Motivation comes from the case when libguestfs has repeatedly created
transient VMs, which in turn created lots of logs without any mechanism
to dele
Previous commit has introduced the config option to enable append=on for
serial files. Here we test it.
Signed-off-by: Oleg Vasilev
---
tests/qemuxml2argvdata/serial-append.xml | 56 +++
.../serial-append.x86_64-latest.xml | 56 +++
tests
Serial log file contains lots of useful information for debugging
configuration problems. It makes sense to preserve the log in between
restarts, so that one can later figure out what was going on.
Signed-off-by: Oleg Vasilev
---
src/qemu/libvirtd_qemu.aug | 3 +++
src/qemu
Serial log file contains lots of useful information for debugging
configuration problems. It makes sense to preserve the log in between
restarts, so that one can later figure out what was going on.
Oleg Vasilev (2):
qemu: add append mode config for serial file
qemuxml2xmltest: add serial
'host view', meaning the TX/RX values must be
swapped. But that's not true.
An easy reproducer is to start a domain with two -s:
one type of network, the other of type ethernet and configure the
same for both. Reversed setting can then be observed
(e.g. via tc).
Reported-by: Oleg
On 24.11.2022 14:53, Michal Prívozník wrote:
On 11/23/22 15:12, Oleg Vasilev wrote:
Hi,
virDomainNetTypeSharesHostView[1] contains the logic where for some
interface types it swaps TX and RX values, because what TX from the
inside is RX on the outside and vice versa.
We observe a
Hi,
virDomainNetTypeSharesHostView[1] contains the logic where for some
interface types it swaps TX and RX values, because what TX from the
inside is RX on the outside and vice versa.
We observe a configuration where shows
swapped values in statistics, because, apparently, the values are
s
Before, logs from deleted machines have been piling up, since there were
no garbadge collection mechanism. Now virtlogd can be configured to
periodically scan log folder for orphan logs with no recent modfications
and delete it.
Signed-off-by: Oleg Vasilev
---
src/logging/log_daemon_config.c
.html
[2]: https://listman.redhat.com/archives/libvir-list/2022-February/msg00865.html
Oleg Vasilev (2):
logging: refactor to store config inside log handler
logging: add log cleanup for obsolete domains
src/logging/log_daemon.c | 6 +-
src/logging/log_daemon_config.c | 9 ++
src
Signed-off-by: Oleg Vasilev
---
src/logging/log_daemon.c | 6 ++
src/logging/log_handler.c | 29 -
src/logging/log_handler.h | 17 -
3 files changed, 22 insertions(+), 30 deletions(-)
diff --git a/src/logging/log_daemon.c b/src/logging
On 04.11.2022 20:19, Andrea Bolognani wrote:
On Fri, Nov 04, 2022 at 01:03:52PM +0100, Peter Krempa wrote:
On Fri, Nov 04, 2022 at 16:43:00 +0600, Oleg Vasilev wrote:
Hotplugging PCI devices on pc-i440fx machines is supported without
additional configuration. On q35, pcie-to-pci-bridge
to make it configurable
in the future.
Previously there was a pci-bridge present by default, but was removed in
d5fb8f4564 (qemu: don't add pci-bridge to Q35/arm domains unless it's needed,
2016-04-22)
[1]: https://libvirt.org/pci-hotplug.html
Signed-off-by: Oleg Vasilev
---
45 matches
Mail list logo
