Re: [libvirt] [PATCH 1/2] qemu: Add support for changing timeout value to open unix monitor socket

2014-01-23 Thread Pavel Fux
, Jan 09, 2014 at 09:22:05AM +0100, Martin Kletzander wrote: From: Pavel Fux pa...@stratoscale.com Adding an option to change monitor socket opening timeout the current default is 3 seconds and in some cases it's not enough Signed-off-by: Pavel Fux pa...@stratoscale.com

Re: [libvirt] [PATCH 1/2] qemu: Add support for changing timeout value to open unix monitor socket

2014-01-23 Thread Pavel Fux
is being read on boot so it takes only 5min anyway, one timeout won't solve all problems, why not 31? or 60? On Thu, Jan 23, 2014 at 4:44 PM, Daniel P. Berrange berra...@redhat.comwrote: On Thu, Jan 23, 2014 at 04:40:40PM +0200, Pavel Fux wrote: I agree, there is no harm in adding an option

Re: [libvirt] [PATCH 2/2] qemu: Change the default unix monitor timeout

2014-01-20 Thread Pavel Fux
at least in my case changing the value to 30 seconds is not enough, we had to change it to 5 minutes I suggest you let the user change it as he wishes. On Thu, Jan 16, 2014 at 6:21 PM, Martin Kletzander mklet...@redhat.comwrote: On Thu, Jan 16, 2014 at 04:11:07PM +, Daniel P. Berrange

[libvirt] [PATCHV2] qemu: Add support for changing timeout value to open unix monitor socket

2014-01-02 Thread Pavel Fux
Adding an option to change monitor socket opening timeout the current default is 3 seconds and in some cases it's not enough Signed-off-by: Pavel Fux pa...@stratoscale.com CC: Martin Kletzander mklet...@redhat.com --- src/qemu/qemu.conf | 7 +++ src/qemu/qemu_conf.c| 2 ++ src

[libvirt] [PATCH] qemu: Add support for changing timeout value to open unix monitor socket

2014-01-02 Thread Pavel Fux
I have fixed all comments except: We prefer passing the driver as an argument instead. I thought of it at first but I looked at the function call graph and it's not that easy. and you did the same in src/qemu/qemu_process.c:115 -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH] qemu: Add support for changing timeout value to open unix monitor socket

2013-12-30 Thread Pavel Fux
behavior stays the same, but a user can add a configuration variable to qemu.conf and change the timeout value. every system needs a different value according to their system configuration but anyway 3 seconds is not suitable for all cases. I am attaching my patch. Pavel Fux. From