Re: [PATCH v2] rpc: fix memory leak in virNetServerClientNew and virNetServerProgramDispatchCall

On 10/04/2022 19:43, Michal Prívozník wrote: On 10/4/22 12:24, Peng Liang wrote: On 10/03/2022 15:38, Michal Prívozník wrote: On 10/1/22 05:35, Peng Liang wrote: On 09/29/2022 21:31, Michal Prívozník wrote: On 9/27/22 17:38, Jiang Jiacheng wrote: From: jiangjiacheng

Re: [PATCH v2] rpc: fix memory leak in virNetServerClientNew and virNetServerProgramDispatchCall

On 10/03/2022 15:38, Michal Prívozník wrote: On 10/1/22 05:35, Peng Liang wrote: On 09/29/2022 21:31, Michal Prívozník wrote: On 9/27/22 17:38, Jiang Jiacheng wrote: From: jiangjiacheng In virNetServerProgramDispatchCall, The arg is passed as a void* and used to point to a certain

Re: [PATCH v2] rpc: fix memory leak in virNetServerClientNew and virNetServerProgramDispatchCall

On 09/29/2022 21:31, Michal Prívozník wrote: On 9/27/22 17:38, Jiang Jiacheng wrote: From: jiangjiacheng In virNetServerProgramDispatchCall, The arg is passed as a void* and used to point to a certain struct depended on the dispatcher, so I think it's the memory of the struct's member

Re: [PATCH 3/3] qemu: Fix memory leak fix memory leak in the condition of attaching cdrom

On 09/09/2022 14:10, Jiacheng Jiang wrote: From: jiangjiacheng The qemuDomainAttachDeviceLive interface is invoked for attaching cdrom in the same way as common disks. The difference is that attach cdrom only update the src of the original device while common disk will add new disk to vm's

Re: [PATCH 2/3] qemu: fix memory leak in qemu_driver.c

On 09/09/2022 14:10, Jiacheng Jiang wrote: From: jiangjiacheng Function virTypedParamsAddString may return -1 I don't think `virTypedParamsAddString` will return -1 in the code paths you touched. The only case where `virTypedParamsAddString` returns -1 is that the `name` you pass to it

Re: [PATCH 1/3] rpc: fix memory leak in virNetServerClientNew and virNetServerProgramDispatchCall

On 09/09/2022 14:10, Jiacheng Jiang wrote: From: jiangjiacheng In virNetServerClientNew, client->rx is be assigned by invoking virNetServerClientNew, but isn't freed if client->privateData's initialization failed, which leads to a memory leak. And in virNetServerProgramDispatchCall, the

[PATCH v3 16/26] remote: Remove unused includes

Signed-off-by: Peng Liang --- src/remote/remote_daemon.c | 3 --- src/remote/remote_daemon.h | 1 - src/remote/remote_daemon_config.c | 1 - src/remote/remote_daemon_dispatch.c | 5 - src/remote/remote_daemon_dispatch.h | 1 - src/remote/remote_daemon_stream.c | 1

[PATCH v3 19/26] util: Remove unused includes

Signed-off-by: Peng Liang --- src/util/iohelper.c | 3 --- src/util/virarptable.c| 2 -- src/util/virauth.c| 1 - src/util/virauthconfig.c | 1 - src/util/virbpf.c | 1 - src/util/virbuffer.c | 2 -- src/util/vircgroup.c | 3

[PATCH v3 15/26] qemu: Remove unused includes

Signed-off-by: Peng Liang --- src/qemu/qemu_agent.c| 2 -- src/qemu/qemu_alias.c| 1 - src/qemu/qemu_alias.h| 2 -- src/qemu/qemu_backup.c | 5 - src/qemu/qemu_block.c| 1 - src/qemu/qemu_block.h| 1 - src/qemu

[PATCH v3 10/26] locking: Remove unused includes

Signed-off-by: Peng Liang --- src/locking/domain_lock.c | 3 --- src/locking/domain_lock.h | 1 - src/locking/lock_daemon.c | 2 -- src/locking/lock_daemon_config.c | 4 src/locking/lock_daemon_dispatch.c | 1 - src/locking/lock_driver_lockd.c| 1 - src

[PATCH v3 03/26] ch: Remove unused includes

Signed-off-by: Peng Liang --- src/ch/ch_conf.c| 1 - src/ch/ch_domain.c | 1 - src/ch/ch_driver.c | 7 --- src/ch/ch_monitor.c | 2 -- src/ch/ch_process.c | 2 -- 5 files changed, 13 deletions(-) diff --git a/src/ch/ch_conf.c b/src/ch/ch_conf.c index bae245adf3..775596e9f5 100644

[PATCH v3 17/26] rpc: Remove unused includes

Signed-off-by: Peng Liang --- src/rpc/virkeepalive.c| 3 --- src/rpc/virnetclient.c| 1 - src/rpc/virnetclient.h| 1 - src/rpc/virnetclientprogram.h | 1 - src/rpc/virnetclientstream.c | 1 - src/rpc/virnetclientstream.h | 1 - src/rpc/virnetdaemon.c| 2 -- src

[PATCH v3 24/26] tools: Remove unused includes

Signed-off-by: Peng Liang --- tools/virsh-checkpoint.c | 2 -- tools/virsh-completer-checkpoint.c | 2 -- tools/virsh-completer-domain.c | 1 - tools/virsh-completer-host.c | 1 - tools/virsh-completer-interface.c | 2 -- tools/virsh-completer-network.c| 1 - tools/virsh

[PATCH v3 11/26] logging: Remove unused includes

Signed-off-by: Peng Liang --- src/logging/log_daemon.c | 5 - src/logging/log_daemon_config.c | 4 src/logging/log_daemon_dispatch.c | 1 - src/logging/log_handler.c | 1 - src/logging/log_manager.c | 1 - 5 files changed, 12 deletions(-) diff --git a/src

[PATCH v3 07/26] hyperv: Remove unused includes

Signed-off-by: Peng Liang --- src/hyperv/hyperv_private.h | 2 -- src/hyperv/hyperv_util.c| 3 --- 2 files changed, 5 deletions(-) diff --git a/src/hyperv/hyperv_private.h b/src/hyperv/hyperv_private.h index da37a8fd20..fb82cef046 100644 --- a/src/hyperv/hyperv_private.h +++ b/src/hyperv

[PATCH v3 05/26] cpu: Remove unused includes

Signed-off-by: Peng Liang --- src/cpu/cpu.c | 3 --- src/cpu/cpu.h | 1 - src/cpu/cpu_arm.c | 1 - src/cpu/cpu_map.c | 2 -- src/cpu/cpu_ppc64.c | 1 - src/cpu/cpu_s390.c | 2 -- src/cpu/cpu_x86.c | 1 - 7 files changed, 11 deletions(-) diff --git a/src/cpu/cpu.c b/src/cpu

[PATCH v3 06/26] esx: Remove unused includes

Signed-off-by: Peng Liang --- src/esx/esx_driver.c| 1 - src/esx/esx_interface_driver.c | 6 -- src/esx/esx_network_driver.c| 2 -- src/esx/esx_private.h | 2 -- src/esx/esx_storage_backend_iscsi.c | 2 -- src/esx/esx_storage_backend_vmfs.c | 2

[PATCH v3 22/26] vmx: Remove unused includes

Signed-off-by: Peng Liang --- src/vmx/vmx.c | 1 - src/vmx/vmx.h | 1 - 2 files changed, 2 deletions(-) diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index c391caa910..6581173187 100644 --- a/src/vmx/vmx.c +++ b/src/vmx/vmx.c @@ -24,7 +24,6 @@ #include "internal.h" #include &

[PATCH v3 20/26] vbox: Remove unused includes

Signed-off-by: Peng Liang --- src/vbox/vbox_XPCOMCGlue.c | 3 --- src/vbox/vbox_driver.c | 2 -- src/vbox/vbox_network.c| 2 -- src/vbox/vbox_storage.c| 3 --- src/vbox/vbox_tmpl.c | 1 - 5 files changed, 11 deletions(-) diff --git a/src/vbox/vbox_XPCOMCGlue.c b/src/vbox

[PATCH v3 04/26] conf: Remove unused includes

Signed-off-by: Peng Liang --- src/conf/backup_conf.c| 3 --- src/conf/capabilities.c | 1 - src/conf/capabilities.h | 2 -- src/conf/checkpoint_conf.c| 4 src/conf/cpu_conf.c | 2 -- src/conf/cpu_conf.h

[PATCH v3 00/26] Remove some unused includes

9, 15, 20, 21, and 23 of v2 since they have been merged; 3. Add Patch 26 (remove some unused includes in lxc); v1 -> v2: 1. Fix build failure on many plantforms; 2. Fix my name in 'From'; 3. Remove a few more unused includes; Peng Liang (26): access: Remove unused includes admin: Remove unus

[PATCH v3 02/26] admin: Remove unused includes

Signed-off-by: Peng Liang --- src/admin/admin_server.c | 4 src/admin/admin_server.h | 1 - src/admin/admin_server_dispatch.c | 3 --- src/admin/libvirt-admin.c | 2 -- 4 files changed, 10 deletions(-) diff --git a/src/admin/admin_server.c b/src/admin

[PATCH v3 14/26] openvz: Remove unused includes

Signed-off-by: Peng Liang --- src/openvz/openvz_conf.c | 1 - src/openvz/openvz_util.c | 1 - 2 files changed, 2 deletions(-) diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c index 79ab786355..c94f9b8577 100644 --- a/src/openvz/openvz_conf.c +++ b/src/openvz/openvz_conf.c

[PATCH v3 18/26] storage: Remove unused includes

Signed-off-by: Peng Liang --- src/storage/parthelper.c | 1 - src/storage/storage_backend.c | 3 --- src/storage/storage_backend_fs.c | 1 - src/storage/storage_backend_gluster.c | 1 - src/storage/storage_backend_iscsi.c| 4 src/storage

[PATCH v3 13/26] node_device: Remove unused includes

Signed-off-by: Peng Liang --- src/node_device/node_device_driver.c | 3 --- src/node_device/node_device_udev.c | 3 --- 2 files changed, 6 deletions(-) diff --git a/src/node_device/node_device_driver.c b/src/node_device/node_device_driver.c index 4b31cd5695..0178ae8b66 100644 --- a/src

[PATCH v3 26/26] lxc: Remove unused includes

Signed-off-by: Peng Liang --- src/lxc/lxc_cgroup.c | 3 --- src/lxc/lxc_cgroup.h | 1 - src/lxc/lxc_conf.c | 1 - src/lxc/lxc_conf.h | 4 src/lxc/lxc_container.c | 2 -- src/lxc/lxc_container.h | 1 - src/lxc/lxc_controller.c | 4 src/lxc/lxc_domain.c | 2

[PATCH v3 25/26] tests: Remove unused includes

Signed-off-by: Peng Liang --- tests/commandtest.c | 2 -- tests/cputest.c | 2 -- tests/domainconftest.c | 2 -- tests/esxutilstest.c| 1 - tests/eventtest.c | 2 -- tests/fchosttest.c

[PATCH v3 12/26] network: Remove unused includes

Signed-off-by: Peng Liang --- src/network/bridge_driver.c | 5 - src/network/bridge_driver.h | 2 -- src/network/bridge_driver_linux.c | 1 - src/network/leaseshelper.c| 3 --- 4 files changed, 11 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network

[PATCH v3 08/26] hypvervisor: Remove unused includes

Signed-off-by: Peng Liang --- src/hypervisor/domain_driver.h | 1 - src/hypervisor/virhostdev.c| 2 -- 2 files changed, 3 deletions(-) diff --git a/src/hypervisor/domain_driver.h b/src/hypervisor/domain_driver.h index 7b0fbae2fd..4241c86932 100644 --- a/src/hypervisor/domain_driver.h +++ b

[PATCH v3 01/26] access: Remove unused includes

Signed-off-by: Peng Liang --- src/access/viraccessdriver.h | 1 - src/access/viraccessdriverpolkit.c | 4 src/access/viraccessdriverstack.c | 1 - src/access/viraccessmanager.h | 1 - 4 files changed, 7 deletions(-) diff --git a/src/access/viraccessdriver.h b/src/access

[PATCH v3 21/26] vmware: Remove unused includes

Signed-off-by: Peng Liang --- src/vmware/vmware_conf.c | 1 - src/vmware/vmware_driver.c | 1 - 2 files changed, 2 deletions(-) diff --git a/src/vmware/vmware_conf.c b/src/vmware/vmware_conf.c index ebba435cc4..80a85f4d0f 100644 --- a/src/vmware/vmware_conf.c +++ b/src/vmware/vmware_conf.c

[PATCH v3 23/26] test_driver: Remove unused includes

Signed-off-by: Peng Liang --- src/test/test_driver.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index a824ef0186..24ff6e8967 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -31,7 +31,6 @@ #include "virer

[PATCH v3 09/26] libxl: Remove unused includes

Signed-off-by: Peng Liang --- src/libxl/libxl_capabilities.c | 1 - src/libxl/libxl_capabilities.h | 2 -- src/libxl/libxl_conf.c | 3 --- src/libxl/libxl_conf.h | 2 -- src/libxl/libxl_domain.c | 1 - src/libxl/libxl_domain.h | 2 -- src/libxl/libxl_driver.c

Re: [PATCH v2 01/30] access: Remove unused includes

On 6/7/2022 10:15 PM, Ján Tomko wrote: > On a Saturday in 2022, Peng Liang wrote: >> Signed-off-by: Peng Liang >> --- >> src/access/viraccessdriver.h   | 1 - >> src/access/viraccessdriverpolkit.c | 4 >> src/access/viraccessdriverstack.c  | 1 - >>

Re: [PATCH v2 00/30] Remove some unused includes

Ping? On 5/14/2022 4:05 PM, Peng Liang wrote: > This series are the v2 of: > https://listman.redhat.com/archives/libvir-list/2022-May/231132.html. > And this version passes the pipeline in GitLab :) > (https://gitlab.com/tcx4c70/libvirt/-/pipelines/539027618). > > v1 -&g

[PATCH v2 30/30] tests: Remove unused includes

Signed-off-by: Peng Liang --- tests/commandtest.c | 2 -- tests/cputest.c | 2 -- tests/domainconftest.c | 2 -- tests/esxutilstest.c| 1 - tests/eventtest.c | 2 -- tests/fchosttest.c

[PATCH v2 29/30] tools: Remove unused includes

Signed-off-by: Peng Liang --- tools/virsh-checkpoint.c | 2 -- tools/virsh-completer-checkpoint.c | 2 -- tools/virsh-completer-domain.c | 1 - tools/virsh-completer-host.c | 1 - tools/virsh-completer-interface.c | 2 -- tools/virsh-completer-network.c| 1 - tools/virsh

[PATCH v2 28/30] test_driver: Remove unused includes

Signed-off-by: Peng Liang --- src/test/test_driver.c | 2 -- src/test/test_driver.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index a824ef0186..24ff6e8967 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -31,7 +31,6

[PATCH v2 27/30] vmx: Remove unused includes

Signed-off-by: Peng Liang --- src/vmx/vmx.c | 1 - src/vmx/vmx.h | 2 -- 2 files changed, 3 deletions(-) diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index 8150bbfaa9..ac4f068a67 100644 --- a/src/vmx/vmx.c +++ b/src/vmx/vmx.c @@ -24,7 +24,6 @@ #include "internal.h" #include &

[PATCH v2 26/30] vmware: Remove unused includes

Signed-off-by: Peng Liang --- src/vmware/vmware_conf.c | 1 - src/vmware/vmware_conf.h | 1 - src/vmware/vmware_driver.c | 1 - 3 files changed, 3 deletions(-) diff --git a/src/vmware/vmware_conf.c b/src/vmware/vmware_conf.c index ebba435cc4..80a85f4d0f 100644 --- a/src/vmware/vmware_conf.c

[PATCH v2 24/30] util: Remove unused includes

Signed-off-by: Peng Liang --- src/util/iohelper.c | 3 --- src/util/virarch.h| 2 -- src/util/virarptable.c| 2 -- src/util/virarptable.h| 2 -- src/util/viraudit.h | 1 - src/util/virauth.c| 1 - src/util/virauth.h| 1

[PATCH v2 25/30] vbox: Remove unused includes

Signed-off-by: Peng Liang --- src/vbox/vbox_XPCOMCGlue.c| 3 --- src/vbox/vbox_common.h| 1 - src/vbox/vbox_driver.c| 2 -- src/vbox/vbox_driver.h| 2 -- src/vbox/vbox_get_driver.h| 2 -- src/vbox/vbox_network.c | 2 -- src/vbox/vbox_storage.c | 3

[PATCH v2 23/30] storage_file: Remove unused includes

Signed-off-by: Peng Liang --- src/storage_file/storage_file_backend.c | 2 -- src/storage_file/storage_file_backend_fs.c | 4 src/storage_file/storage_file_backend_gluster.c | 2 -- src/storage_file/storage_source.c | 2 -- 4 files changed, 10 deletions(-) diff

[PATCH v2 22/30] storage: Remove unused includes

Signed-off-by: Peng Liang --- src/storage/parthelper.c | 1 - src/storage/storage_backend.c | 3 --- src/storage/storage_backend.h | 1 - src/storage/storage_backend_fs.c | 1 - src/storage/storage_backend_gluster.c | 1 - src/storage

[PATCH v2 21/30] security: Remove unused includes

Signed-off-by: Peng Liang --- src/security/security_dac.c | 1 - src/security/security_manager.h | 1 - src/security/security_nop.c | 2 -- src/security/security_selinux.c | 2 -- src/security/security_stack.c | 1 - src/security/security_util.c| 1 - 6 files changed, 8 deletions

[PATCH v2 20/30] secret: Remove unused includes

Signed-off-by: Peng Liang --- src/secret/secret_driver.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/secret/secret_driver.c b/src/secret/secret_driver.c index 09782b38d3..080ed962a9 100644 --- a/src/secret/secret_driver.c +++ b/src/secret/secret_driver.c @@ -35,11 +35,9 @@ #include

[PATCH v2 17/30] qemu: Remove unused includes

Signed-off-by: Peng Liang --- src/qemu/qemu_agent.c| 2 -- src/qemu/qemu_agent.h| 1 - src/qemu/qemu_alias.c| 1 - src/qemu/qemu_alias.h| 2 -- src/qemu/qemu_backup.c | 5 - src/qemu/qemu_block.c| 1 - src/qemu

[PATCH v2 19/30] rpc: Remove unused includes

Signed-off-by: Peng Liang --- src/rpc/virkeepalive.c| 3 --- src/rpc/virnetclient.c| 1 - src/rpc/virnetclient.h| 1 - src/rpc/virnetclientprogram.h | 1 - src/rpc/virnetclientstream.c | 1 - src/rpc/virnetclientstream.h | 1 - src/rpc/virnetdaemon.c| 2 -- src

[PATCH v2 18/30] remote: Remove unused includes

Signed-off-by: Peng Liang --- src/remote/remote_daemon.c | 3 --- src/remote/remote_daemon.h | 1 - src/remote/remote_daemon_config.c | 1 - src/remote/remote_daemon_dispatch.c | 5 - src/remote/remote_daemon_dispatch.h | 1 - src/remote/remote_daemon_stream.c | 1

[PATCH v2 16/30] openvz: Remove unused includes

Signed-off-by: Peng Liang --- src/openvz/openvz_conf.c | 1 - src/openvz/openvz_conf.h | 1 - src/openvz/openvz_driver.h | 2 -- src/openvz/openvz_util.c | 1 - 4 files changed, 5 deletions(-) diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c index 191c79e1e2..2253796b2c

[PATCH v2 15/30] nwfilter: Remove unused includes

Signed-off-by: Peng Liang --- src/nwfilter/nwfilter_dhcpsnoop.c | 2 -- src/nwfilter/nwfilter_driver.c| 5 - src/nwfilter/nwfilter_driver.h| 3 --- src/nwfilter/nwfilter_ebiptables_driver.c | 4 src/nwfilter/nwfilter_gentech_driver.c| 4 src

[PATCH v2 12/30] logging: Remove unused includes

Signed-off-by: Peng Liang --- src/logging/log_daemon.c | 5 - src/logging/log_daemon_config.c | 4 src/logging/log_daemon_dispatch.c | 1 - src/logging/log_handler.c | 1 - src/logging/log_handler.h | 1 - src/logging/log_manager.c | 1 - 6 files

[PATCH v2 13/30] network: Remove unused includes

Signed-off-by: Peng Liang --- src/network/bridge_driver.c | 5 - src/network/bridge_driver.h | 3 --- src/network/bridge_driver_linux.c| 1 - src/network/bridge_driver_platform.h | 1 - src/network/leaseshelper.c | 3 --- 5 files changed, 13 deletions(-) diff

[PATCH v2 14/30] node_device: Remove unused includes

Signed-off-by: Peng Liang --- src/node_device/node_device_driver.c | 3 --- src/node_device/node_device_driver.h | 1 - src/node_device/node_device_udev.c | 3 --- 3 files changed, 7 deletions(-) diff --git a/src/node_device/node_device_driver.c b/src/node_device/node_device_driver.c index

[PATCH v2 10/30] libxl: Remove unused includes

Signed-off-by: Peng Liang --- src/libxl/libxl_capabilities.c | 1 - src/libxl/libxl_capabilities.h | 2 -- src/libxl/libxl_conf.c | 3 --- src/libxl/libxl_conf.h | 3 --- src/libxl/libxl_domain.c | 1 - src/libxl/libxl_domain.h | 2 -- src/libxl/libxl_driver.c

[PATCH v2 11/30] locking: Remove unused includes

Signed-off-by: Peng Liang --- src/locking/domain_lock.c | 3 --- src/locking/domain_lock.h | 2 -- src/locking/lock_daemon.c | 2 -- src/locking/lock_daemon_config.c | 4 src/locking/lock_daemon_dispatch.c | 1 - src/locking/lock_driver.h | 1 - src

[PATCH v2 08/30] hypvervisor: Remove unused includes

Signed-off-by: Peng Liang --- src/hypervisor/domain_driver.h | 1 - src/hypervisor/domain_job.h| 1 - src/hypervisor/virhostdev.c| 2 -- 3 files changed, 4 deletions(-) diff --git a/src/hypervisor/domain_driver.h b/src/hypervisor/domain_driver.h index 7b0fbae2fd..4241c86932 100644

[PATCH v2 02/30] admin: Remove unused includes

Signed-off-by: Peng Liang --- src/admin/admin_server.c | 4 src/admin/admin_server.h | 1 - src/admin/admin_server_dispatch.c | 3 --- src/admin/libvirt-admin.c | 2 -- 4 files changed, 10 deletions(-) diff --git a/src/admin/admin_server.c b/src/admin

[PATCH v2 09/30] interface: Remove unused includes

Signed-off-by: Peng Liang --- src/interface/interface_backend_netcf.c | 2 -- src/interface/interface_backend_udev.c | 1 - 2 files changed, 3 deletions(-) diff --git a/src/interface/interface_backend_netcf.c b/src/interface/interface_backend_netcf.c index d625964421..90514692e2 100644

[PATCH v2 07/30] hyperv: Remove unused includes

Signed-off-by: Peng Liang --- src/hyperv/hyperv_private.h | 3 --- src/hyperv/hyperv_util.c| 3 --- src/hyperv/hyperv_util.h| 1 - 3 files changed, 7 deletions(-) diff --git a/src/hyperv/hyperv_private.h b/src/hyperv/hyperv_private.h index da37a8fd20..3d0606bac3 100644 --- a/src/hyperv

[PATCH v2 04/30] conf: Remove unused includes

Signed-off-by: Peng Liang --- src/conf/backup_conf.c| 3 --- src/conf/capabilities.c | 1 - src/conf/capabilities.h | 3 --- src/conf/checkpoint_conf.c| 4 src/conf/checkpoint_conf.h| 1 - src/conf/cpu_conf.c

[PATCH v2 06/30] esx: Remove unused includes

Signed-off-by: Peng Liang --- src/esx/esx_driver.c| 1 - src/esx/esx_interface_driver.c | 6 -- src/esx/esx_network_driver.c| 2 -- src/esx/esx_private.h | 3 --- src/esx/esx_storage_backend_iscsi.c | 2 -- src/esx/esx_storage_backend_vmfs.c | 2

[PATCH v2 05/30] cpu: Remove unused includes

Signed-off-by: Peng Liang --- src/cpu/cpu.c | 3 --- src/cpu/cpu.h | 1 - src/cpu/cpu_arm.c | 1 - src/cpu/cpu_map.c | 2 -- src/cpu/cpu_ppc64.c | 1 - src/cpu/cpu_s390.c | 2 -- src/cpu/cpu_x86.c | 1 - 7 files changed, 11 deletions(-) diff --git a/src/cpu/cpu.c b/src/cpu

[PATCH v2 03/30] ch: Remove unused includes

Signed-off-by: Peng Liang --- src/ch/ch_conf.c| 1 - src/ch/ch_domain.c | 1 - src/ch/ch_driver.c | 7 --- src/ch/ch_monitor.c | 2 -- src/ch/ch_process.c | 2 -- src/ch/ch_process.h | 1 - 6 files changed, 14 deletions(-) diff --git a/src/ch/ch_conf.c b/src/ch/ch_conf.c index

[PATCH v2 00/30] Remove some unused includes

ove a few more unused includes; Peng Liang (30): access: Remove unused includes admin: Remove unused includes ch: Remove unused includes conf: Remove unused includes cpu: Remove unused includes esx: Remove unused includes hyperv: Remove unused includes hypvervisor: Remove unused inclu

[PATCH v2 01/30] access: Remove unused includes

Signed-off-by: Peng Liang --- src/access/viraccessdriver.h | 1 - src/access/viraccessdriverpolkit.c | 4 src/access/viraccessdriverstack.c | 1 - src/access/viraccessmanager.h | 1 - src/access/viraccessperm.h | 1 - 5 files changed, 8 deletions(-) diff --git a/src

Re: [PATCH 01/29] access: Remove unused includes

On 5/13/2022 11:13 PM, Ján Tomko wrote: > On a Wednesday in 2022, Peng Liang wrote: >> From: Adam Tao >> >> Signed-off-by: Peng Liang > > The name in 'From' does not match the one in the signoff. > The signoff needs to be from the author of the patch. Tha

[PATCH 28/29] tools: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- tools/virsh-checkpoint.c | 2 -- tools/virsh-completer-checkpoint.c | 2 -- tools/virsh-completer-domain.c | 1 - tools/virsh-completer-host.c | 1 - tools/virsh-completer-interface.c | 2 -- tools/virsh-completer-network.c

[PATCH 29/29] tests: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- tests/commandtest.c | 2 -- tests/cputest.c | 2 -- tests/domainconftest.c | 2 -- tests/esxutilstest.c| 1 - tests/eventtest.c | 2 -- tests

[PATCH 26/29] vmx: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/vmx/vmx.c | 1 - src/vmx/vmx.h | 2 -- 2 files changed, 3 deletions(-) diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index 8150bbfaa9..ac4f068a67 100644 --- a/src/vmx/vmx.c +++ b/src/vmx/vmx.c @@ -24,7 +24,6 @@ #include "internal.h"

[PATCH 21/29] storage: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/storage/parthelper.c | 1 - src/storage/storage_backend.c | 3 --- src/storage/storage_backend.h | 1 - src/storage/storage_backend_fs.c | 1 - src/storage/storage_backend_gluster.c | 1

[PATCH 27/29] test_driver: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/test/test_driver.c | 2 -- src/test/test_driver.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index a824ef0186..24ff6e8967 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[PATCH 24/29] vbox: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/vbox/vbox_XPCOMCGlue.c| 3 --- src/vbox/vbox_common.h| 1 - src/vbox/vbox_driver.c| 2 -- src/vbox/vbox_driver.h| 2 -- src/vbox/vbox_get_driver.h| 2 -- src/vbox/vbox_network.c | 2 -- src/vbox

[PATCH 25/29] vmware: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/vmware/vmware_conf.c | 1 - src/vmware/vmware_conf.h | 1 - src/vmware/vmware_driver.c | 1 - 3 files changed, 3 deletions(-) diff --git a/src/vmware/vmware_conf.c b/src/vmware/vmware_conf.c index ebba435cc4..80a85f4d0f 100644 --- a/src

[PATCH 22/29] storage_file: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/storage_file/storage_file_backend.c | 2 -- src/storage_file/storage_file_backend_fs.c | 5 - src/storage_file/storage_file_backend_gluster.c | 2 -- src/storage_file/storage_source.c | 3 --- 4 files changed, 12

[PATCH 23/29] util: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/util/iohelper.c | 3 --- src/util/virarch.h | 2 -- src/util/virarptable.c | 2 -- src/util/virarptable.h | 2 -- src/util/viraudit.h | 1 - src/util/virauth.c | 1 - src/util

[PATCH 19/29] secret: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/secret/secret_driver.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/secret/secret_driver.c b/src/secret/secret_driver.c index 09782b38d3..080ed962a9 100644 --- a/src/secret/secret_driver.c +++ b/src/secret/secret_driver.c @@ -35,11

[PATCH 14/29] nwfilter: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/nwfilter/nwfilter_dhcpsnoop.c | 3 --- src/nwfilter/nwfilter_driver.c| 5 - src/nwfilter/nwfilter_driver.h| 3 --- src/nwfilter/nwfilter_ebiptables_driver.c | 4 src/nwfilter/nwfilter_gentech_driver.c

[PATCH 13/29] node_device: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/node_device/node_device_driver.c | 3 --- src/node_device/node_device_driver.h | 1 - src/node_device/node_device_udev.c | 3 --- 3 files changed, 7 deletions(-) diff --git a/src/node_device/node_device_driver.c b/src/node_device

[PATCH 18/29] rpc: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/rpc/virkeepalive.c| 3 --- src/rpc/virnetclient.c| 1 - src/rpc/virnetclient.h| 1 - src/rpc/virnetclientprogram.h | 1 - src/rpc/virnetclientstream.c | 1 - src/rpc/virnetclientstream.h | 1 - src/rpc/virnetdaemon.c

[PATCH 17/29] remote: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/remote/remote_daemon.c | 3 --- src/remote/remote_daemon.h | 1 - src/remote/remote_daemon_config.c | 1 - src/remote/remote_daemon_dispatch.c | 5 - src/remote/remote_daemon_dispatch.h | 1 - src/remote

[PATCH 20/29] security: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/security/security_dac.c | 1 - src/security/security_manager.h | 1 - src/security/security_nop.c | 2 -- src/security/security_selinux.c | 2 -- src/security/security_stack.c | 1 - src/security/security_util.c| 1 - 6 files

[PATCH 16/29] qemu: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/qemu/qemu_agent.c| 2 -- src/qemu/qemu_agent.h| 1 - src/qemu/qemu_alias.c| 1 - src/qemu/qemu_alias.h| 2 -- src/qemu/qemu_backup.c | 5 - src/qemu/qemu_block.c| 1 - src

[PATCH 15/29] openvz: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/openvz/openvz_conf.c | 1 - src/openvz/openvz_conf.h | 1 - src/openvz/openvz_driver.h | 2 -- src/openvz/openvz_util.c | 1 - 4 files changed, 5 deletions(-) diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c index

[PATCH 10/29] locking: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/locking/domain_lock.c | 3 --- src/locking/domain_lock.h | 2 -- src/locking/lock_daemon.c | 2 -- src/locking/lock_daemon_config.c | 4 src/locking/lock_daemon_dispatch.c | 1 - src/locking/lock_driver.h

[PATCH 07/29] hyperv: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/hyperv/hyperv_private.h | 3 --- src/hyperv/hyperv_util.c| 3 --- src/hyperv/hyperv_util.h| 1 - 3 files changed, 7 deletions(-) diff --git a/src/hyperv/hyperv_private.h b/src/hyperv/hyperv_private.h index da37a8fd20..3d0606bac3 100644

[PATCH 04/29] conf: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/conf/backup_conf.c| 3 --- src/conf/capabilities.c | 1 - src/conf/capabilities.h | 3 --- src/conf/checkpoint_conf.c| 4 src/conf/checkpoint_conf.h| 1 - src/conf

[PATCH 11/29] logging: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/logging/log_daemon.c | 5 - src/logging/log_daemon_config.c | 4 src/logging/log_daemon_dispatch.c | 1 - src/logging/log_handler.c | 1 - src/logging/log_handler.h | 1 - src/logging/log_manager.c | 1

[PATCH 12/29] network: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/network/bridge_driver.c | 5 - src/network/bridge_driver.h | 3 --- src/network/bridge_driver_linux.c| 1 - src/network/bridge_driver_platform.h | 1 - src/network/leaseshelper.c | 4 5 files changed, 14

[PATCH 09/29] libxl: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/libxl/libxl_capabilities.c | 1 - src/libxl/libxl_capabilities.h | 2 -- src/libxl/libxl_conf.c | 3 --- src/libxl/libxl_conf.h | 3 --- src/libxl/libxl_domain.c | 1 - src/libxl/libxl_domain.h | 2 -- src/libxl

[PATCH 06/29] esx: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/esx/esx_driver.c| 1 - src/esx/esx_interface_driver.c | 6 -- src/esx/esx_network_driver.c| 2 -- src/esx/esx_private.h | 3 --- src/esx/esx_storage_backend_iscsi.c | 2 -- src/esx

[PATCH 08/29] interface: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/interface/interface_backend_netcf.c | 2 -- src/interface/interface_backend_udev.c | 1 - 2 files changed, 3 deletions(-) diff --git a/src/interface/interface_backend_netcf.c b/src/interface/interface_backend_netcf.c index d625964421

[PATCH 03/29] ch: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/ch/ch_conf.c| 1 - src/ch/ch_domain.c | 1 - src/ch/ch_driver.c | 7 --- src/ch/ch_monitor.c | 2 -- src/ch/ch_process.c | 2 -- src/ch/ch_process.h | 1 - 6 files changed, 14 deletions(-) diff --git a/src/ch/ch_conf.c b/src/ch

[PATCH 05/29] cpu: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/cpu/cpu.c | 3 --- src/cpu/cpu.h | 1 - src/cpu/cpu_arm.c | 1 - src/cpu/cpu_map.c | 2 -- src/cpu/cpu_ppc64.c | 1 - src/cpu/cpu_s390.c | 2 -- src/cpu/cpu_x86.c | 1 - 7 files changed, 11 deletions(-) diff --git a/src/cpu

[PATCH 02/29] admin: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/admin/admin_server.c | 4 src/admin/admin_server.h | 1 - src/admin/admin_server_dispatch.c | 4 src/admin/libvirt-admin.c | 2 -- 4 files changed, 11 deletions(-) diff --git a/src/admin/admin_server.c b/src

[PATCH 01/29] access: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/access/viraccessdriver.h | 1 - src/access/viraccessdriverpolkit.c | 4 src/access/viraccessdriverstack.c | 1 - src/access/viraccessmanager.h | 1 - src/access/viraccessperm.h | 1 - 5 files changed, 8 deletions

[PATCH 00/29] Remove some unused includes

Recently, I update the toolchain in my dev machine from LLVM13 to LLVM14, and I find that there are many unsed include headers in the libvirt. So I try to remove them in this series. Besides, I also find that: 1. some header files are not self-contained, which means if you want to include one

[PATCH v2 0/2] qemu: Move 2 pid files to stateDir

This is v2 of: https://listman.redhat.com/archives/libvir-list/2021-October/msg00535.html v1 -> v2: - Fix compatibility with old version libvirt [Michal] Peng Liang (2): qemu: Move pid file of pr-helper to stateDir qemu: Move pid file of virtiofsd to stateDir src/qemu/qemu_process.c |

[PATCH v2 2/2] qemu: Move pid file of virtiofsd to stateDir

-domain directory to stateDir. Signed-off-by: Peng Liang --- src/qemu/qemu_virtiofs.c | 25 ++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_virtiofs.c b/src/qemu/qemu_virtiofs.c index 3ca45457c16e..0c12c5ea22a6 100644 --- a/src/qemu

[PATCH v2 1/2] qemu: Move pid file of pr-helper to stateDir

-domain directory to stateDir. Signed-off-by: Peng Liang --- src/qemu/qemu_process.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index f95ed80fac43..6027b30405dc 100644 --- a/src/qemu/qemu_process.c

  1   2   >