[libvirt] [PATCH v2 3/4] xen: fix PyGrub device order using boot/@order

2011-11-01 Thread Philipp Hahn
disks and are marked as bootable. Explicitly mark the first disk as bootable for compatibility with Xends default behaviour. Add capability deviceboot to Xen-PV-domains. This is not 100% correct, since for example PyGrub only handles disk devices and not netboot. Signed-off-by: Philipp Hahn h

Re: [libvirt] [BUG] Fix order of disks and controllers

2011-10-31 Thread Philipp Hahn
section, using /domain/os/boot/ here does not work. Either that libvirt needs to explicitly support Xens bootable flag (via /domain/devices/disk/boot/@order?), or this patch should be reverted. Comments? Sincerely Philipp -- Philipp Hahn Open Source Software Engineer h

[libvirt] [PATCH] xen: fix PyGrub device order using boot/@order

2011-10-31 Thread Philipp Hahn
a boolean flag. If multiple disks are marked bootable, the behaviour is undefined. Adapt all Xen-sexpr tests to now contain the extra '(bootbale 0)' flag. It must be explicitly set, otherwise Xend remembers the old state and only ever adds the bootable indicator. Signed-off-by: Philipp Hahn h

Re: [libvirt] [PATCH] xen: fix PyGrub device order using boot/@order

2011-10-31 Thread Philipp Hahn
a look. Sincerely Philipp -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbHLinux for Your Businessfon: +49 421 22 232- 0 Mary-Somerville-Str.1 D-28359 Bremen fax: +49 421 22 232-99

Re: [libvirt] [PATCH] xen: fix PyGrub device order using boot/@order

2011-10-31 Thread Philipp Hahn
-- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbHLinux for Your Businessfon: +49 421 22 232- 0 Mary-Somerville-Str.1 D-28359 Bremen fax: +49 421 22 232-99 http

[libvirt] [FYI] Skript to extract qcow2 snapshot info to libvirt snapshot xml

2011-10-20 Thread Philipp Hahn
when the configuration was changed between snapshots, but at least I prefer a solution working 95% of the times instead of 0% ;-) And since I already wrote it, others might find it useful as well. Sincerely Philipp Hahn PS: An a drink of their reasonable choosing to the first one writing a qemu

[libvirt] [PATCH 1/2] qemu: Fix name-space handling

2011-10-18 Thread Philipp Hahn
/domain Remove the test for checking the name-space binding on the top-level domain element. Registering the name-space with XPath is enough. Signed-off-by: Philipp Hahn h...@univention.de --- src/qemu/qemu_domain.c | 30 -- 1 files changed, 12 insertions(+), 18

[libvirt] [PATCH 2/2] qemu: Test name-space handling

2011-10-18 Thread Philipp Hahn
to a name-space other than http://libvirt.org/schemas/domain/qemu/1.0 2. they break qemuxml2xml, because the xmlns:qemu binding is moved to the top-level domain element when converting from argv to xml. Signed-off-by: Philipp Hahn h...@univention.de --- tests/Makefile.am

[libvirt] [PATCH] documentation: trivial spelling fix

2011-10-18 Thread Philipp Hahn
Signed-off-by: Philipp Hahn h...@univention.de --- docs/formatdomain.html.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index c007dff..4a75026 100644 --- a/docs/formatdomain.html.in +++ b/docs

[libvirt] [BUG, RFC] Python generator: missing error_codes in generated libvirError exceptions

2011-10-17 Thread Philipp Hahn
? 3. Extend the generator to add additional information from annotations? 4. Replace the generated code with hand-extended code. Any ideas? Thanks for your input. Sincerely Philipp -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbHLinux for Your

[libvirt] [PATCH] Fix two comments related to error handling

2011-10-17 Thread Philipp Hahn
Signed-off-by: Philipp Hahn h...@univention.de --- include/libvirt/virterror.h |2 +- python/libvirt-override.py |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/libvirt/virterror.h b/include/libvirt/virterror.h index dfbe2bc..a8549b7 100644 --- a/include

[libvirt] [PATCH] Fix virt-sanlock-cleanup documentation

2011-10-17 Thread Philipp Hahn
The referenced page does not exist, but locking.html has a section about sanlock. Signed-off-by: Philipp Hahn h...@univention.de --- tools/virt-sanlock-cleanup.in |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/virt-sanlock-cleanup.in b/tools/virt-sanlock

[libvirt] [PATCH v2 0/2] Xen: skip xenHypervisor version init in tests

2011-10-14 Thread Philipp Hahn
and viridian, the xencapstest fails. v2: Skip initialization of static version variables for Xen Hypervisor and use provided values for unit test cases. Philipp Hahn (2): Xen: move versions to struct Xen: Fake versions in xencapstest src/xen/xen_driver.c |2 +- src/xen/xen_hypervisor.c

[libvirt] [PATCH v2 1/2] Xen: move versions to struct

2011-10-14 Thread Philipp Hahn
Calling virInitialize() → xenRegister() → xenhypervisorInit() directly opens a connection to the Xen Hypervisor, which breaks some unit tests. Move all static variables into a struct to make it easier to override them when testing. Signed-off-by: Philipp Hahn h...@univention.de --- src/xen

[libvirt] [PATCH v2 2/2] Xen: Fake versions in xencapstest

2011-10-14 Thread Philipp Hahn
to xenhypervisorInit() to disable automatic detection of the Hypervisor version. The passed in arguments are used instead. Signed-off-by: Philipp Hahn h...@univention.de --- src/xen/xen_driver.c |2 +- src/xen/xen_hypervisor.c | 14 -- src/xen/xen_hypervisor.h |2 +- tests

Re: [libvirt] [PATCH 2/3] Add virBufferEscapeShell

2011-10-13 Thread Philipp Hahn
/qemu_monitor.c:142 qemuMonitorEscapeShell() But it works on const char * and returns char * instead of virBuffer, so a merge with this new virBufferEscapeShell() is very much appreciated. Sincerely Philipp -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention

[libvirt] [PATCH 1/4] tests: Add support for skipping tests

2011-10-12 Thread Philipp Hahn
AM_TESTS has support for skipping tests, while the C-implementation virtTestRun() does not support that feature. Print _ or SKIP in verbose mode for tests returning EXIT_AM_SKIP=77. Signed-off-by: Philipp Hahn h...@univention.de --- tests/testutils.c |4 1 files changed, 4 insertions

[libvirt] [PATCH 0/4] Xen fixes

2011-10-12 Thread Philipp Hahn
Here are several patches relevant to Xen: The first two patches fix the test-suite when building as root in a Xen-dom0 domain. The other two patches fix problems when doing virsh edit on Xen domains. Philipp Hahn (4): tests: Add support for skipping tests tests: Skip Xen-HVM tests for root

[libvirt] [PATCH 2/4] tests: Skip Xen-HVM tests for root on dom0

2011-10-12 Thread Philipp Hahn
in testutils.c, since the merge strategy for compound tests heavily depends on the specific test cases being merged. Signed-off-by: Philipp Hahn h...@univention.de --- tests/xencapstest.c | 95 +++ 1 files changed, 65 insertions(+), 30 deletions(-) diff

[libvirt] [PATCH 4/4] xen: Return tap2 for tap2 disks

2011-10-12 Thread Philipp Hahn
For some versions of Xen the difference between tap and tap2 is important. When converting back from xen-sxpr to libvirt-xml, that information is lost, which breaks re-defining the domain using that data. Explicitly return tap2 for disks defines as device/tap2. Signed-off-by: Philipp Hahn h

[libvirt] [PATCH 3/4] xen: fix PyGrub boot device order

2011-10-12 Thread Philipp Hahn
to libvirt exactly one disk is marked as bootable. Signed-off-by: Philipp Hahn h...@univention.de --- valgrind might complain about an uninitialized read access when copying disks[0] to disks[0], but that is overwritten again with the following assignment. https://forge.univention.org/bugzilla

[libvirt] [PATCH 1/3] example: Fix argument handling

2011-10-12 Thread Philipp Hahn
will reveal the bug. Signed-off-by: Philipp Hahn h...@univention.de --- examples/domain-events/events-python/event-test.py |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/domain-events/events-python/event-test.py b/examples/domain-events/events-python/event

[libvirt] [PATCH 2/3] example: Redirect --help output to stdout/stderr

2011-10-12 Thread Philipp Hahn
When --help is requested, print usage() to stdout. When an illegal option is passed, print usage to stderr. Signed-off-by: Philipp Hahn h...@univention.de --- examples/domain-events/events-python/event-test.py |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git

[libvirt] [PATCH 0/3] example: event-test.py

2011-10-12 Thread Philipp Hahn
Some minor improvements to the event-test Python example. Philipp Hahn (3): example: Fix argument handling example: Redirect --help output to stdout/stderr example: Support debug output and loop switch examples/domain-events/events-python/event-test.py | 25 +-- 1 files

[libvirt] [PATCH 3/3] example: Support debug output and loop switch

2011-10-12 Thread Philipp Hahn
Add support for enabling debug output via command line option. Allow to toggle the loop implementation between pure-Python and native-C. Signed-off-by: Philipp Hahn h...@univention.de --- examples/domain-events/events-python/event-test.py | 13 +++-- 1 files changed, 11 insertions

Re: [libvirt] [BUG,RFC] directory traversal vulnerability / qemu: name→uuid

2011-09-08 Thread Philipp Hahn
Hello Eric, On Wednesday 07 September 2011 16:02:51 Eric Blake wrote: On 09/07/2011 11:12 AM, Philipp Hahn wrote: I just tried the following command with libvirt-0.9.5git: # virsh snapshot-create $VM /dev/stdin 'domainsnapshotname../../../../../../etc/passwd/name/domainsnap shot

[libvirt] [PATCH] Fix URL-escaping for domainDefine

2011-09-08 Thread Philipp Hahn
to virBufferURIEncodeString() and virBufferAddChar() because '=' is a reserved character, which would get escaped by virBufferURIEncodeString(), which - by the way - escapes anything not c_isalnum(). Signed-off-by: Philipp Hahn h...@univention.de --- src/xen/xend_internal.c | 62

[libvirt] [BUG,RFC] directory traversal vulnerability / qemu: name→uuid

2011-09-07 Thread Philipp Hahn
and directory naming? Sincerely Philipp -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbHLinux for Your Businessfon: +49 421 22 232- 0 Mary-Somerville-Str.1 D-28359 Bremen fax: +49 421 22 232-99

Re: [libvirt] [PATCHv4 00/51] shared snapshot meta-data

2011-09-02 Thread Philipp Hahn
me started to work on Fix memory leak while scanning snapshots, killall -SIGHUP libvirtd / virStateReload and Reload snapshots on SIGHUP. At leas our patched 0.8.7 is working fine with those changes. Sincerely Philipp -- Philipp Hahn Open Source Software Engineer h

Re: [libvirt] [PATCH 2/2] Reload snapshots on SIGHUP

2011-09-02 Thread Philipp Hahn
Hello Eric, Am Dienstag 30 August 2011 19:02:50 schrieb Eric Blake: On 08/30/2011 08:59 AM, Philipp Hahn wrote: On receiving SIGHUP, libvirtd currently only reloads all persistent configs for qemu domains, but fails to reload the associated snapshot data. ... Are you sure this is still

Re: [libvirt] [PATCH] Fix localtime handling for Xen-PV domains

2011-09-02 Thread Philipp Hahn
Ping? On Monday 15 August 2011 19:52:20 Philipp Hahn wrote: At least Xen-3.4.3 translates the /vm/localtime SXPR value to /domain/platform/localtime and /domain/image/{linux,hvm}/localtime when the domain is defined. When reading back that information libvirt only handles HVM domains

[libvirt] [PATCH 2/2] Reload snapshots on SIGHUP

2011-08-30 Thread Philipp Hahn
On receiving SIGHUP, libvirtd currently only reloads all persistent configs for qemu domains, but fails to reload the associated snapshot data. Copy code from qemudStartup() to qemudReload() to iterate over all domains and call qemuDomainSnapshotLoad() for every domain. Signed-off-by: Philipp

[libvirt] [PATCH] Fix localtime handling for Xen-PV domains

2011-08-30 Thread Philipp Hahn
clock offset=utc/ while Xend used (localtime 1). For PV domains use /domain/image/linux/localtime. Signed-off-by: Philipp Hahn h...@univention.de --- This is tracked at https://forge.univention.org/bugzilla/show_bug.cgi?id=22321 --- src/xenxs/xen_sxpr.c |3 +++ 1 files changed, 3 insertions

[libvirt] [PATCH 1/2] Fix error detection in device change

2011-08-30 Thread Philipp Hahn
-20110714145916-dvd-amd64.iso'/target dev='hda' bus='ide'/readonly/alias name='ide0-0-0'/address type='drive' controller='0' bus='0' unit='0'//disk Device updated successfully Signed-off-by: Philipp Hahn h...@univention.de --- src/qemu/qemu_monitor_text.c |2 +- 1 files changed, 1

Re: [libvirt] [PATCH 2/3] snapshot: save domain description with snapshot

2011-08-15 Thread Philipp Hahn
Hello Eric, Am Samstag 13 August 2011 00:08:11 schrieb Eric Blake: On 04/12/2011 12:16 AM, Philipp Hahn wrote: Save the domain description with the XML snapshot data. TODOs: - XML file is no longer nicely indented Cosmetic, and can be fixed later. - Fix esx driver - Fix vbox driver

Re: [libvirt] [PATCH] Fix domxml-from-native xen-sxpr for domain/clock/ @offset='localtime'

2011-08-15 Thread Philipp Hahn
Hello Eric, Am Freitag 12 August 2011 23:40:34 schrieb Eric Blake: On 04/27/2011 07:20 AM, Philipp Hahn wrote: At least Xen-3.4.3 translates the /vm/localtime SXPR value to /domain/platform/localtime and /domain/image/{linux,hvm}/localtime when the domain is defined. When reading back

Re: [libvirt] [PATCH 2/3] Improve tokenizing of linkable terms

2011-08-12 Thread Philipp Hahn
Am Donnerstag 11 August 2011 21:45:18 schrieb Eric Blake: On 08/11/2011 06:44 AM, Philipp Hahn wrote: Currently only tabs and blanks are used for tokenizing the description, which breaks when a term is at the end of a line or has () appended to it. 1. Use also other white space

Re: [libvirt] RFCv2: virDomainSnapshotCreateXML enhancements

2011-08-12 Thread Philipp Hahn
again; what may change you probably know better than me. For I thinks it's essential to store the VM consiguration with the snapshot, which would be the qemu command line arguments, which is equivalent to libvirts XML description. Sincerely Philipp -- Philipp Hahn Open Source Software

Re: [libvirt] RFCv2: virDomainSnapshotCreateXML enhancements

2011-08-12 Thread Philipp Hahn
Hello Kevin, Am Freitag 12 August 2011 10:04:07 schrieb Kevin Wolf: Am 12.08.2011 09:18, schrieb Philipp Hahn: On Thursday 11 August 2011 12:00:46 Kevin Wolf wrote: Am 11.08.2011 00:08, schrieb Eric Blake: Libvirt currently has a bug in that it only saves domain/uuid rather than the full

[libvirt] [BUG?] killall -SIGHUP libvirtd / virStateReload

2011-08-12 Thread Philipp Hahn
Philipp -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbHLinux for Your Businessfon: +49 421 22 232- 0 Mary-Somerville-Str.1 D-28359 Bremen fax: +49 421 22 232-99 http

Re: [libvirt] [PATCH] Bugfix: Check stdoutWatch before removing the handler.

2011-08-11 Thread Philipp Hahn
this? Is this normal? Sincerely Philipp Hahn -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbHLinux for Your Businessfon: +49 421 22 232- 0 Mary-Somerville-Str.1 D-28359 Bremen fax: +49 421 22 232-99

Re: [libvirt] [PATCH] Bugfix: Check stdoutWatch before removing the handler.

2011-08-11 Thread Philipp Hahn
Hello, On Thursday 11 August 2011 08:35:25 Philipp Hahn wrote: While testing it I noticed the following behaviour: 1. Start virsh 2. Do qemu-monitor-command $SOME_VM info\ chardev to get the path of the pty used for the console → /dev/pts/Y 3. Execute console $SOME_VM from within the same

[libvirt] [PATCH 2/3] Improve tokenizing of linkable terms

2011-08-11 Thread Philipp Hahn
the token before lookup. Signed-off-by: Philipp Hahn h...@univention.de --- docs/newapi.xsl |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/docs/newapi.xsl b/docs/newapi.xsl index 445a48c..6e1c646 100644 --- a/docs/newapi.xsl +++ b/docs/newapi.xsl @@ -54,10 +54,13

[libvirt] [PATCH 0/3] apibuild improvements

2011-08-11 Thread Philipp Hahn
While working with the documentation, I found some issues I'd like to improve. Philipp Hahn (3): Align table cells on top Improve tokenizing of linkable terms Fix references to self.warning() docs/apibuild.py | 48 ++-- docs/libvirt.css |4

[libvirt] [PATCH 3/3] Fix references to self.warning()

2011-08-11 Thread Philipp Hahn
Only the class CParser declares a method warning(), but the other classes still try to call their self.warning() method, which fails. Move the warning() functions to its own base classe and inherit from that in all other classes. Signed-off-by: Philipp Hahn h...@univention.de --- docs

[libvirt] [PATCH 1/3] Align table cells on top

2011-08-11 Thread Philipp Hahn
of a row on top. Signed-off-by: Philipp Hahn h...@univention.de --- docs/libvirt.css |4 1 files changed, 4 insertions(+), 0 deletions(-) --- See http://libvirt.org/html/libvirt-libvirt.html#virDomainMemoryStatTags for example. diff --git a/docs/libvirt.css b/docs/libvirt.css index

Re: [libvirt] [PATCH 5/4] qemu: properly revert to offline snapshots

2011-08-10 Thread Philipp Hahn
patch also have to change qemuBuildCommandLine() to not add -loadvm, since qemu then will refuse to start.              goto endjob;      } Sincerely Philipp -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbHLinux for Your Businessfon

Re: [libvirt] [PATCH 5/4] qemu: properly revert to offline snapshots

2011-08-10 Thread Philipp Hahn
looks fine. Sincerely Philipp Hahn -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbHLinux for Your Businessfon: +49 421 22 232- 0 Mary-Somerville-Str.1 D-28359 Bremen fax: +49 421 22 232-99

[libvirt] [PATCH] Fix memory leak while scanning snapshots

2011-08-09 Thread Philipp Hahn
If a snapshot with the name already exists, virDomainSnapshotAssignDef() just returns NULL, in which case the snapshot definition is leaked. Currently this leak is not a big problem, since qemuDomainSnapshotLoad() is only called once during initial startup of libvirtd. Signed-off-by: Philipp Hahn

Re: [libvirt] [PATCH 0/4] snapshot improvements

2011-08-08 Thread Philipp Hahn
. Thanks. Sincerely Philipp -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbHLinux for Your Businessfon: +49 421 22 232- 0 Mary-Somerville-Str.1 D-28359 Bremen fax: +49 421 22 232-99

[libvirt] [BUG] Xen-libvirt: localtime reported as UTC

2011-04-27 Thread Philipp Hahn
offset='utc'/ # gfind localtime ./85664d3f-68dd-a4c2-4d2f-be7f276b95f0/config.sxp:(platform ((device_model /usr/lib64/xen/bin/qemu-dm) (localtime 1))) ./85664d3f-68dd-a4c2-4d2f-be7f276b95f0/config.sxp:(localtime 1) BYtE Philipp -- Philipp Hahn Open Source Software Engineer

[libvirt] [PATCH] Fix domxml-from-native xen-sxpr for domain/clock/@offset='localtime'

2011-04-27 Thread Philipp Hahn
should read back /domain/platform/localtime. This is tracked at https://forge.univention.org/bugzilla/show_bug.cgi?id=22321 Signed-off-by: Philipp Hahn h...@univention.de --- src/xenxs/xen_sxpr.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/xenxs/xen_sxpr.c b

[libvirt] [BUG] Re: [2/6] loadvm: improve tests before bdrv_snapshot_goto()

2011-04-14 Thread Philipp Hahn
be adapted to this new behavior. I found the Bug also reported with Ubuntu and created a Bug in our own German bugtracker: https://bugs.launchpad.net/qemu/+bug/726619 https://forge.univention.org/bugzilla/show_bug.cgi?id=1 Sincerely Philipp Hahn -- Philipp Hahn Open Source Software

[libvirt] [PATCH 0/3] [PoC] snapshot += xml

2011-04-12 Thread Philipp Hahn
be restarted. The implementation currently works very well for me, but I noticed some memory leak, which might be related to this patch (or some other, since my version of libvirt contains several other patches as well). Philipp Hahn (3): Swap virDomain / virFomainSnapshot declaration snapshot: save

[libvirt] [PATCH 3/3] Snapshot: restore domain description from snapshot

2011-04-12 Thread Philipp Hahn
Restore the domain description from the snapshot information. TODOs: - Only restart the KVM process when the snapshot is incompatible with loadvm. This would have the benefir of being able to switch saved states very fast and also doesn't disconnect any VNC viewer. Signed-off-by: Philipp Hahn

[libvirt] [PATCH 1/3] Swap virDomain / virFomainSnapshot declaration

2011-04-12 Thread Philipp Hahn
In preparation for storing the domain description with the snapshot, swap the order of declaration. Signed-off-by: Philipp Hahn h...@univention.de --- src/conf/domain_conf.h | 100 1 files changed, 50 insertions(+), 50 deletions(-) diff --git

[libvirt] [PATCH 2/3] snapshot: save domain description with snapshot

2011-04-12 Thread Philipp Hahn
Save the domain description with the XML snapshot data. TODOs: - XML file is no longer nicely indented - Fix esx driver - Fix vbox driver Signed-off-by: Philipp Hahn h...@univention.de --- src/conf/domain_conf.c | 27 +++ src/conf/domain_conf.h |4 +++- src/esx

Re: [libvirt] snapshots += domain description?

2011-04-12 Thread Philipp Hahn
of commands. Indeed, there's probably quite a bit of work to do in that code to make it more reliable. See my proof-of-concept implementation, which I just posted for comments. BYtE Philipp -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbH

[libvirt] qemu-namespace handling?

2011-04-12 Thread Philipp Hahn
with others, so they don't do the same mistake. Sincerely Philipp Hahn -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbHLinux for Your Businessfon: +49 421 22 232- 0 Mary-Somerville-Str.1 D-28359 Bremen fax: +49 421 22

[libvirt] [BUG] qemu: snapshots no longer shown after migration^2

2011-04-04 Thread Philipp Hahn
, e.g. offline-migration) No patch yet, but this is tracked at our German bugzilla at https://forge.univention.org/bugzilla/show_bug.cgi?id=22072 Sincerely Philipp Hahn -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbHLinux for Your Business

[libvirt] [BUG] Managed save qemu state gets deleted after failed resume

2011-03-30 Thread Philipp Hahn
chardev info in qemu with 'info chardev' This issue is tracked in our (German) bug-tracker at https://forge.univention.org/bugzilla/show_bug.cgi?id=22021 Sincerely Philipp Hahn -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbHLinux for Your

Re: [libvirt] How to get the IP address of a Domain?

2011-03-30 Thread Philipp Hahn
assignment, or use external services like DHCP, but is completely independent from the hardware. So from libvirts point of view, your domain does not have an IP address. Sincerely Philipp Hahn -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbH

Re: [libvirt] cont command failing via JSON monitor on restore

2011-03-29 Thread Philipp Hahn
: qemuMonitorCommandWithHandler:231 : Send command 'cont' for write with FD -1 17:50:19.911: 29813: debug : qemuMonitorCommandWithHandler:236 : Receive command reply ret=0 errno=0 71 bytes 'An incoming migration is expected before this command can be executed ' Sincerely Philipp -- Philipp Hahn Open Source

[libvirt] [PATCH] Add missing { for qemudDomainInterfaceStats

2011-03-25 Thread Philipp Hahn
Add missing open curly brace between function declaration of non-linux variant of qemudDomainInterfaceStats() and its body. Signed-off-by: Philipp Hahn h...@univention.de --- src/qemu/qemu_driver.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b

[libvirt] [PATCH] Reserve first 3 PCI slots for hardcoded devices

2011-03-25 Thread Philipp Hahn
addresses, the re-definition fails in qemuAssignDevicePCISlots() with the error message Primary video card must have PCI address 0:0:2.0 To simplify editing existing domains just reserve the first three slots for internal usage by setting qemuDomainPCIAddressSet.nextslot = 3. Signed-off-by: Philipp

Re: [libvirt] [RFC, PATCH] Re: xen:/// vs. xen://FQDN/ vs xen+unix:/// discrepancy

2011-03-18 Thread Philipp Hahn
Hello Jim, Am Donnerstag 17 März 2011 21:11:34 schrieb Jim Fehlig: Philipp Hahn wrote: Today I encountered the bug again: virsh list was not showing any domain, while virsh -c xen+unix:/// did show Domain 0 and my other domain. Are you using xen unstable or Xen 4.1 (i.e. something

[libvirt] [RFC, PATCH] Re: xen:/// vs. xen://FQDN/ vs xen+unix:/// discrepancy

2011-03-16 Thread Philipp Hahn
Hello, Am Freitag 23 Juli 2010 18:02:27 schrieb Philipp Hahn: Am Donnerstag 22 Juli 2010 14:51:22 schrieb Daniel P. Berrange: root@xen4# virsh -c xen://xen4.domain.name/ list root@xen4# virsh -c xen:/// list root@xen4# virsh -c xen+unix:/// list ... To me it looks like some connection

Re: [libvirt] [PATCH 2/4] libvirt-guest.init: quoting variables

2011-03-14 Thread Philipp Hahn
Hello Eric, On Friday Mar 11th 2011 21:48:03 Eric Blake wrote: On 03/09/2011 01:54 AM, Philipp Hahn wrote: At least protect the $uri variable against further expansion by properly quoting it. While doing that, also quote all other variables to protect against shell meta characters

Re: [libvirt] [PATCH] libvirt-guests: avoid globbing when splitting $URIS

2011-03-14 Thread Philipp Hahn
as well, but that's just a question of personally preferred style. Sincerely Philipp Hahn -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbHLinux for Your Businessfon: +49 421 22 232- 0 Mary-Somerville-Str.1 D-28359 Bremen

[libvirt] [PATCH] docs/formatdomain.html.in: Fix spelling PIC-PCI

2011-03-14 Thread Philipp Hahn
Not Programmable Interrupt Controller but Peripheral Component Interconnect. Signed-off-by: Philipp Hahn h...@univention.de --- docs/formatdomain.html.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index d39aee0

[libvirt] [PATCH 0/4] white space handling in libvirt-guest.init script

2011-03-11 Thread Philipp Hahn
is not for application, but since I had to do it anyway, I'll include it for others for inspiration. So #1 is the most important, #2 and #3 depends on your preferred style, and #4 is just FYI only. Philipp Hahn (4): libvirt-guest.init: handle domain name with spaces libvirt-guest.init: quoting variables

[libvirt] [PATCH 2/4] libvirt-guest.init: quoting variables

2011-03-11 Thread Philipp Hahn
At least protect the $uri variable against further expansion by properly quoting it. While doing that, also quote all other variables to protect against shell meta characters. Signed-off-by: Philipp Hahn h...@univention.de --- tools/libvirt-guests.init.sh | 74

[libvirt] [PATCH 3/4] libvirt-guest.init: declare variables as local

2011-03-11 Thread Philipp Hahn
Declare variables used in function only as local. Signed-off-by: Philipp Hahn h...@univention.de --- tools/libvirt-guests.init.sh | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/tools/libvirt-guests.init.sh b/tools/libvirt-guests.init.sh index ab2b907..8da7576

[libvirt] [PATCH 4/4] libvirt-guest.init: Use lsb-init functions

2011-03-11 Thread Philipp Hahn
the appropriate lsb_*-functions. Splash screens integrate with LSB compatibe init scripts by overwriting the lsb_*-functions defined in /lib/lsb/init-functions. Signed-off-by: Philipp Hahn h...@univention.de --- tools/libvirt-guests.init.sh | 67 + 1 files changed, 34

[libvirt] [PATCH 1/4] libvirt-guest.init: handle domain name with spaces

2011-03-11 Thread Philipp Hahn
awk splits the line on consecutive spaces, which breaks getting the name of a domain whose name contains spaces. Use sed instead to strip the Name: prefix from the line Signed-off-by: Philipp Hahn h...@univention.de --- tools/libvirt-guests.init.sh |2 +- 1 files changed, 1 insertions(+), 1

Re: [libvirt] [PATCH V5] Add libxenlight driver

2011-03-10 Thread Philipp Hahn
developers using libvirt.xenlight to connect to Xen servers should expect, that they might have to update their code for newer libvirt version, because it is not yet fully stable. Sincerely Philipp Hahn -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbH

Re: [libvirt] [PATCH v3] domain.rng vs. formatdomain.html#elementsUSB

2011-03-10 Thread Philipp Hahn
Hello Daniel, hello Eric, Ping? Am Dienstag 01 März 2011 11:23:20 schrieb Philipp Hahn: The Relax-NG schema for domains regarding hostdev doesn't match what's implemented in src/conf/domain_conf.c#virDomainHostdevDefFormat(): The implementation only requires @type, but the schema currently

Re: [libvirt] [PATCH v4] Ignore backing file errors in FS storage pool

2011-03-10 Thread Philipp Hahn
Hello Daniel, hello Eric, Ping? Am Dienstag 01 März 2011 16:48:20 schrieb Philipp Hahn: Currently a single storage volume with a broken backing file will disable the whole storage pool. This can happen when the backing file is on some unavailable network storage or if the backing volume

Re: [libvirt] snapshots += domain description?

2011-03-04 Thread Philipp Hahn
working on fixing the problem or are there any plans to fix that? Sincerely Philipp -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbHLinux for Your Businessfon: +49 421 22 232- 0 Mary-Somerville-Str.1 28359 Bremen fax: +49

[libvirt] [PATCH v3] domain.rng vs. formatdomain.html#elementsUSB

2011-03-01 Thread Philipp Hahn
-by: Philipp Hahn h...@univention.de --- docs/formatdomain.html.in |7 --- docs/schemas/domain.rng | 14 -- 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 84b1cab..0ec2045 100644 --- a/docs

[libvirt] [PATCH v4] Ignore backing file errors in FS storage pool

2011-03-01 Thread Philipp Hahn
). As long as the now broken image stays in the directory, you will not be able to re-create or re-start the pool. Signed-off-by: Philipp Hahn h...@univention.de --- src/storage/storage_backend_fs.c | 44 - 1 files changed, 33 insertions(+), 11 deletions(-) diff

[libvirt] [PATCH v2] domain.rng vs. formatdomain.html#elementsUSB

2011-02-28 Thread Philipp Hahn
/hostdev /devices /domain The schema is changed to match the current implementation: 1. @mode is optional (which defaults to 'subsystem') 2. @type is required 3. @managed is optional (which defaults to 'no') Signed-off-by: Philipp Hahn h...@univention.de --- docs/schemas

Re: [libvirt] questions about libvirtd and virsh

2011-02-25 Thread Philipp Hahn
threads, what are these threads doing? I thinks they wait for work to arrive: 1 is accepting new connections, 1 runs the event loop and 5 (configurable) wait for work to be pushed to the internal work queue. Sincerely Philipp -- Philipp Hahn Open Source Software Engineer h

[libvirt] [BUG, ½PATCH] domain.rng vs. formatdomain.html#elementsUSB

2011-02-24 Thread Philipp Hahn
) for that? Sincerely Philipp -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbHLinux for Your Businessfon: +49 421 22 232- 0 Mary-Somerville-Str.1 28359 Bremen fax: +49 421 22 232-99

[libvirt] [PATCH 2/2] Ignore backing file errors in FS storage pool

2011-02-23 Thread Philipp Hahn
After the last step, the pool will be gone (because it was not persistent). As long as the now broken image stays in the directory, you will not be able to re-create or re-start the pool. Signed-off-by: Philipp Hahn h...@univention.de --- src/storage/storage_backend_fs.c | 10 +- 1 files

[libvirt] [PATCH 1/2] Fix spelling mistake: seek

2011-02-23 Thread Philipp Hahn
Replace wrong set by correct seek in error message. Signed-off-by: Philipp Hahn h...@univention.de --- src/util/storage_file.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/util/storage_file.c b/src/util/storage_file.c index 4faa99d..62dad0d 100644 --- a/src/util

[libvirt] [PATCH 2/2] Ignore backing file errors in FS storage pool (v2)

2011-02-23 Thread Philipp Hahn
After the last step, the pool will be gone (because it was not persistent). As long as the now broken image stays in the directory, you will not be able to re-create or re-start the pool. Signed-off-by: Philipp Hahn h...@univention.de --- src/storage/storage_backend_fs.c | 10 +- 1 files

[libvirt] [PATCH 2/2] Ignore backing file errors in FS storage pool (v3)

2011-02-23 Thread Philipp Hahn
After the last step, the pool will be gone (because it was not persistent). As long as the now broken image stays in the directory, you will not be able to re-create or re-start the pool. Signed-off-by: Philipp Hahn h...@univention.de --- src/storage/storage_backend_fs.c | 10 +- 1 files

[libvirt] [BUG] storage_backend_fs: failung virStorageBackendProbeTarget() disabled whole pool

2011-02-17 Thread Philipp Hahn
all errors regarding the detection of the backing files file format. This would at least allow users to still create new volumes and list existing volumes. I appreciate any comments. BYtE Philipp -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbH

[libvirt] [PATCH] qemu: Fix escape_monitor(escape_shell(command))

2011-02-11 Thread Philipp Hahn
with backslashes would also be possible, but the set of special characters heavily depends on the concrete shell (dsh, bash, zsh) and its setting (history expansion, interactive use, ...) Signed-off-by: Philipp Hahn h...@univention.de --- src/qemu/qemu_monitor.c | 65

[libvirt] [BUG] intermediate snapshot deleted

2010-12-08 Thread Philipp Hahn
# virsh snapshot-delete test 1291813672 Is this problem known (libvirt-0.8.3)? Reverting to such an unlinked snapshot is still possible, but deleting it is not. Sincerely Philipp Hahn -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbHLinux

[libvirt] snapshots += domain description?

2010-12-07 Thread Philipp Hahn
size, etc. Any comment or advise is appreciated. Sincerely Philipp Hahn -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbHLinux for Your Businessfon: +49 421 22 232- 0 Mary-Somerville-Str.1 28359 Bremen fax: +49

[libvirt] [PATCH] Fix broken XML entity for ''

2010-11-25 Thread Philipp Hahn
Add missing 'g' to 'gt;' of 'product /' source-element. Signed-off-by: Philipp Hahn h...@univention.de --- docs/formatstorage.html.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/docs/formatstorage.html.in b/docs/formatstorage.html.in index 91f70a3..f13ca6a 100644

[libvirt] [PATCH] Fix xen API documentation.

2010-10-27 Thread Philipp Hahn
Add missing 'on'. Change 'dom' to 'domain' as used in xenDaemonDomainBlockPeek() Signed-off-by: Philipp Hahn h...@univention.de --- src/xen/xend_internal.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/xen/xend_internal.c b/src/xen/xend_internal.c index b90c331

[libvirt] [PATCH] Fix documentation for virEventAddTimeout()

2010-10-26 Thread Philipp Hahn
Fix copypaste error from virEventAddHandle(). Signed-off-by: Philipp Hahn h...@univention.de --- src/util/event.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/util/event.h b/src/util/event.h index 4552d1a..68b06c6 100644 --- a/src/util/event.h +++ b/src/util

Re: [libvirt] [BUG] Xen x86_64 needs PAE?

2010-08-24 Thread Philipp Hahn
expectation would be that the capabilities XML should thus report pae/, if an application is supposed to add the pae/ feature to get an 64 bit xen-fv domain. Sincerely Philipp -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbHLinux

[libvirt] [BUG] Xen x86_64 needs PAE?

2010-08-09 Thread Philipp Hahn
is enabled by default there, and thus gets enabled for each domain using xm create: gopts.var('pae', val='PAE', fn=set_int, default=1, use=Disable or enable PAE of HVM domain.) Any feedback is appreciated. BYtE Philipp -- Philipp Hahn Open Source Software Engineer

[libvirt] [PATCH] bootloader_args is named bootargs in xen-xm

2010-08-05 Thread Philipp Hahn
virsh domxml-to-native xen-xm. The reverse direction (domxml-from-native) is already okay. This patch fixes domxml-to-native and adds two test files to catch this problem. Signed-off-by: Philipp Hahn h...@univention.de --- src/xen/xm_internal.c |2 +- tests/xmconfigdata

Re: [libvirt] xen:/// vs. xen://FQDN/ vs xen+unix:/// discrepancy

2010-07-23 Thread Philipp Hahn
  log_outputs=1:file:/var/log/libvirt/libvirtd.log I'v now enabled that and see if I can gather more data. Sincerely Philipp Hahn -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbHLinux for Your Businessfon: +49 421 22 232- 0 Mary

Re: [libvirt] [PATCH] Fix SEGV on exit after domainEventDeregister()

2010-07-23 Thread Philipp Hahn
Ping. Am Dienstag 13 Juli 2010 10:54:26 schrieb Philipp Hahn: When the last callback is removed using domainEventDeregister(), the events dispatcher is deregistered from the C-library, but domainEventsCallbacks is still an empty list. On shutdown __del__() deregisters the dispatacher again

<    1   2   3   4   >