[libvirt] [PATCH] network: honor the ipv6 network option

2018-10-10 Thread Ryan Goodfellow
According the the documentation for the ipv6 network attribute https://libvirt.org/formatnetwork.html "When set to yes, the optional parameter ipv6 enables a network definition with no IPv6 gateway addresses specified to have guest-to-guest communications." But this is not the current behavior,

Re: [libvirt] [PATCH go-xml] fix type tag for rdp and destkop graphics devices

2018-03-10 Thread Ryan Goodfellow
Signed-off-by: Ryan Goodfellow <rgood...@isi.edu> On Mon, Mar 5, 2018 at 4:25 AM, Daniel P. Berrangé <berra...@redhat.com> wrote: > On Sun, Mar 04, 2018 at 10:41:43AM -0500, Ryan Goodfellow wrote: > > The current behavior is to generate a type="vnc" tag in the &g

[libvirt] [PATCH go-xml] fix type tag for rdp and destkop graphics devices

2018-03-04 Thread Ryan Goodfellow
The current behavior is to generate a type="vnc" tag in the element generated from either a DomainGrapicRDP or DomainGraphicDesktop. The correct tags should be type="rdp" and type="desktop" respectively. This commit emits the correct tags and adds a test for correct graphics device tagging. ---

Re: [libvirt] [PATCH go-xml] add support for domain features

2017-05-04 Thread Ryan Goodfellow
ping, ref < https://www.redhat.com/archives/libvir-list/2017-April/msg01073.html> On Thu, Apr 27, 2017 at 12:35 PM, Ryan Goodfellow <rgood...@isi.edu> wrote: > Hi Daniel, > > I have addressed the issues you brought up in the commit titled 'remove > superfluous state &

Re: [libvirt] [PATCH go-xml] add support for domain features

2017-04-27 Thread Ryan Goodfellow
53:48PM -0700, Ryan Goodfellow wrote: > > This commit adds support for domain features. It does so by introducing > > a new family of types DomainFeature*. The aggregate type > > DomainFeatureList has been added to the Domain type to plumb in the new > > type family. Testing

[libvirt] [PATCH go-xml] remove superfluous state & omitempty entries

2017-04-24 Thread Ryan Goodfellow
This commit removes the superfluous state and omit entries from my last commit. It factors the 'state' data member into a DomainFeatureState struct and only uses that struct where necessary e.g. HyperV features as well as a few top level features such as PMU, HAP etc. The HyperV suffix has also

[libvirt] [PATCH go-xml] add support for domain features

2017-04-23 Thread Ryan Goodfellow
This commit adds support for domain features. It does so by introducing a new family of types DomainFeature*. The aggregate type DomainFeatureList has been added to the Domain type to plumb in the new type family. Testing has also been added in domain_test.go --- domain.go | 91

Re: [libvirt] [PATCH go-xml] Support for filesystem devices

2017-04-20 Thread Ryan Goodfellow
Hi Folks, Any thoughts on this? This is my first time posting to this list, not sure if I should direct the patch at someone in particular. On Tue, Apr 18, 2017 at 3:01 PM, Ryan Goodfellow <rgood...@isi.edu> wrote: > This commit adds filesystem device support. A new family

[libvirt] [PATCH go-xml] Support for filesystem devices

2017-04-18 Thread Ryan Goodfellow
This commit adds filesystem device support. A new family of types DomainFilesystem* are introduced and plumbed into the DomainDeviceList struct. Testing has also been included. --- domain.go | 40 domain_test.go | 55